On 18.12.2017 12:18, Thomas Huth wrote: > On 17.12.2017 22:34, Peter Maydell wrote: >> On 16 December 2017 at 17:41, Stefan Berger <stef...@linux.vnet.ibm.com> >> wrote: >>> The following patch series refactors the TPM TIS and backend drivers for >>> easier addition of new front-end devices. Further, the TPM buffer sizes >>> are read from the backend and the backend's buffer size can be adjusted >>> by the frontend, if necessary. >>> >>> >>> The following changes since commit 0ef0583d5adceb9138bdb47494dabd1549ac5b6d: >>> >>> Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20171214' >>> into staging (2017-12-14 15:32:32 +0000) >>> >>> are available in the git repository at: >>> >>> git://github.com/stefanberger/qemu-tpm.git tags/pull-tpm-2017-12-15-1 >>> >>> for you to fetch changes up to 683c4b775355cc7acd301e8efe7d4c1c9acdafd8: >>> >>> tpm: tpm_passthrough: Fail startup if FE buffer size < BE buffer size >>> (2017-12-14 23:39:15 -0500) >>> >>> ---------------------------------------------------------------- >>> Merge tpm 2017/12/15 v1 >> >> Applied, thanks. > > This apparently broke compilation on non-x86 architectures: > > LINK s390x-softmmu/qemu-system-s390x > ../hw/core/qdev-properties-system.o: In function `release_tpm': > /home/thuth/devel/qemu/hw/core/qdev-properties-system.c:291: undefined > reference to `tpm_backend_reset' > ../hw/core/qdev-properties-system.o: In function `set_tpm': > /home/thuth/devel/qemu/hw/core/qdev-properties-system.c:274: undefined > reference to `qemu_find_tpm_be' > /home/thuth/devel/qemu/hw/core/qdev-properties-system.c:278: undefined > reference to `tpm_backend_init' > collect2: error: ld returned 1 exit status > make: Leaving directory `/home/thuth/s390x/qemu' > make[1]: *** [qemu-system-s390x] Error 1 > make: *** [subdir-s390x-softmmu] Error 2 > > Could you please fix this ASAP?
FWIW, looks like there was a "--disable-tpm" in my config.status file, not sure why. So that's likely causing the issue here, not the non-x86 system. Thomas
