>> Or we could suppress the s390x compiler warning by using a compiler >> pragma. But I don't like that alternative. > > I think the best solution would be to call tcg_s390_program_interrupt() > directly from helper_divs64() instead of going through the > s390_program_interrupt() wrapper. helper_divs64() is for TCG only, so it > should be fine to directly use the tcg_s390_program_interrupt() function > there.
If there is not a good reason, I'd prefer to have only one function for injecting program interrupts. (adding 3 return statements looks IMHO nicer). > > Thomas > -- Thanks, David / dhildenb
