Re: [Qemu-devel] [PATCH 0/2] scsi: Simple ALUA support

2017-12-17 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20171214152246.17503-1-h...@suse.de Subject: [Qemu-devel] [PATCH 0/2] scsi: Simple ALUA support Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline

[Qemu-devel] [PATCH] s390x: Add missing QEMU_NORETURN attribute (CID 1383842)

2017-12-17 Thread Stefan Weil
This should fix the Coverity warning: ** CID 1383842: Integer handling issues (DIVIDE_BY_ZERO) /target/s390x/int_helper.c: 84 in helper_divs64() Signed-off-by: Stefan Weil --- target/s390x/cpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/s390x/cpu.h b/targe

Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations

2017-12-17 Thread Tetsuo Handa
Wei Wang wrote: > > But passing GFP_NOWAIT means that we can handle allocation failure. There is > > no need to use preload approach when we can handle allocation failure. > > I think the reason we need xb_preload is because radix tree insertion > needs the memory being preallocated already (it c

Re: [Qemu-devel] [PATCH] s390x: Add missing QEMU_NORETURN attribute (CID 1383842)

2017-12-17 Thread Stefan Weil
Am 17.12.2017 um 11:25 schrieb no-re...@patchew.org: > Hi, > > This series failed build test on s390x host. Please find the details below. [...] > /var/tmp/patchew-tester-tmp-e2qiwzsb/src/target/s390x/interrupt.c: In > function ‘s390_program_interrupt’: > /var/tmp/patchew-tester-tmp-e2qiwzsb/src/

Re: [Qemu-devel] [PATCH 11/15] apb: split pci_pbm_map_irq() into separate functions for bus A and bus B

2017-12-17 Thread Mark Cave-Ayland
On 19/11/17 11:06, Mark Cave-Ayland wrote: On 17/11/17 14:33, Artyom Tarasenko wrote: On Fri, Nov 17, 2017 at 2:42 PM, Mark Cave-Ayland wrote: After the previous refactoring it is now possible to use separate functions to improve clarity of the interrupt paths. Similarly by checking the PCI

Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations

2017-12-17 Thread Wang, Wei W
> -Original Message- > From: Tetsuo Handa [mailto:penguin-ker...@i-love.sakura.ne.jp] > Sent: Sunday, December 17, 2017 6:22 PM > To: Wang, Wei W ; wi...@infradead.org > Cc: virtio-...@lists.oasis-open.org; linux-ker...@vger.kernel.org; qemu- > de...@nongnu.org; virtualizat...@lists.linux

[Qemu-devel] [PATCH V2 2/5] mem: add share parameter to memory-backend-ram

2017-12-17 Thread Marcel Apfelbaum
Currently only file backed memory backend can be created with a "share" flag in order to allow sharing guest RAM with other processes in the host. Add the "share" flag also to RAM Memory Backend in order to allow remapping parts of the guest RAM to different host virtual addresses. This is needed

[Qemu-devel] [PATCH V2 1/5] pci/shpc: Move function to generic header file

2017-12-17 Thread Marcel Apfelbaum
From: Yuval Shaia This function should be declared in generic header file so we can utilize it. Signed-off-by: Yuval Shaia Signed-off-by: Marcel Apfelbaum --- hw/pci/shpc.c | 11 +-- include/qemu/cutils.h | 10 ++ 2 files changed, 11 insertions(+), 10 deletions(-) dif

[Qemu-devel] [PATCH V2 3/5] docs: add pvrdma device documentation

2017-12-17 Thread Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum Signed-off-by: Yuval Shaia --- docs/pvrdma.txt | 145 1 file changed, 145 insertions(+) create mode 100644 docs/pvrdma.txt diff --git a/docs/pvrdma.txt b/docs/pvrdma.txt new file mode 100644 index

[Qemu-devel] [PATCH V2 0/5] hw/pvrdma: PVRDMA device implementation

2017-12-17 Thread Marcel Apfelbaum
RFC -> V2: - Full implementation of the pvrdma device - Backend is an ibdevice interface, no need for the KDBR module General description === PVRDMA is the QEMU implementation of VMware's paravirtualized RDMA device. It works with its Linux Kernel driver AS IS, no need for any s

[Qemu-devel] [PATCH V2 5/5] MAINTAINERS: add entry for hw/net/pvrdma

2017-12-17 Thread Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum Signed-off-by: Yuval Shaia --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ffd77b461c..d24401a4d0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1960,6 +1960,13 @@ F: block/replication.c F: tests/test-rep

Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations

2017-12-17 Thread Wang, Wei W
On Saturday, December 16, 2017 3:22 AM, Matthew Wilcox wrote: > On Fri, Dec 15, 2017 at 10:49:15AM -0800, Matthew Wilcox wrote: > > Here's the API I'm looking at right now. The user need take no lock; > > the locking (spinlock) is handled internally to the implementation. Another place I saw your

Re: [Qemu-devel] [PATCH] scsi: replace hex constants with #defines

2017-12-17 Thread Philippe Mathieu-Daudé
On 12/17/2017 02:29 AM, Paolo Bonzini wrote: > Sense keys have nice #defines in scsi/constants.h, use them. > > Reported-by: Dr. David Alan Gilbert > Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé > --- > scsi/utils.c | 14 +++--- > 1 file changed, 7 insertions(+),

Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations

2017-12-17 Thread Tetsuo Handa
Wang, Wei W wrote: > > Wei Wang wrote: > > > > But passing GFP_NOWAIT means that we can handle allocation failure. > > > > There is no need to use preload approach when we can handle allocation > > > > failure. > > > > > > I think the reason we need xb_preload is because radix tree insertion > > >

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x: Add missing QEMU_NORETURN attribute (CID 1383842)

2017-12-17 Thread Thomas Huth
On 17.12.2017 11:58, Stefan Weil wrote: > Am 17.12.2017 um 11:25 schrieb no-re...@patchew.org: >> Hi, >> >> This series failed build test on s390x host. Please find the details below. > [...] >> /var/tmp/patchew-tester-tmp-e2qiwzsb/src/target/s390x/interrupt.c: In >> function ‘s390_program_interru

Re: [Qemu-devel] [PATCH V2 1/5] pci/shpc: Move function to generic header file

2017-12-17 Thread Philippe Mathieu-Daudé
Hi Marcel, Yuval, On 12/17/2017 09:54 AM, Marcel Apfelbaum wrote: > From: Yuval Shaia > > This function should be declared in generic header file so we can > utilize it. > > Signed-off-by: Yuval Shaia > Signed-off-by: Marcel Apfelbaum > --- > hw/pci/shpc.c | 11 +-- > include

Re: [Qemu-devel] [PATCH V2 1/5] pci/shpc: Move function to generic header file

2017-12-17 Thread Yuval Shaia
On Sun, Dec 17, 2017 at 03:16:15PM -0300, Philippe Mathieu-Daudé wrote: > Hi Marcel, Yuval, > > On 12/17/2017 09:54 AM, Marcel Apfelbaum wrote: > > From: Yuval Shaia > > > > This function should be declared in generic header file so we can > > utilize it. > > > > Signed-off-by: Yuval Shaia > >

[Qemu-devel] [RFC v6 1/2] virtio: introduce `query-virtio' QMP command

2017-12-17 Thread Jan Dakinevich
The command is intended for gathering virtio information such as status, feature bits, negotiation status. It is convenient and useful for debug purpose. The commands returns generic virtio information for virtio such as common feature names and status bits names and information for all attached t

[Qemu-devel] [RFC v6 2/2] virtio: add `info virtio' HMP command

2017-12-17 Thread Jan Dakinevich
The command prints data from `query-virtio' QMP in human-readable format. Cc: Denis V. Lunev Signed-off-by: Jan Dakinevich --- hmp-commands-info.hx | 14 ++ hmp.c| 74 hmp.h| 1 + 3 files changed, 89 i

[Qemu-devel] [RFC v6 0/2] virtio: introduce `info virtio' hmp command

2017-12-17 Thread Jan Dakinevich
From: Jan Dakinevich After some discussion, I am going to suggest reworked QMP/HMP for gathering virtio info. It would provide the following monitor output. (qemu) info virtio virtio-blk-device at :00:02.0 QOM path: /machine/peripheral-anon/device[0]/virtio-backend status: 0x0f VIRTI

[Qemu-devel] [PATCH 0/4] QOM'ify PCIDevices

2017-12-17 Thread Philippe Mathieu-Daudé
Hi, In this series we QOM'ify the last few PCI devices still using PCIDeviceClass->init() by converting this init() to realize(), Then we finally remove the then PCIDeviceClass->init() method for good. Regards, Phil. Philippe Mathieu-Daudé (4): hw/block/nvme: QOM'ify PCI NVME hw/pci-host/p

[Qemu-devel] [PATCH 1/4] hw/block/nvme: QOM'ify PCI NVME

2017-12-17 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/block/nvme.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 441e21ed1f..9c5f898da0 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -920,9 +920,9 @@ st

[Qemu-devel] [PATCH 4/4] hw/pci: remove obsolete PCIDevice->init()

2017-12-17 Thread Philippe Mathieu-Daudé
All PCI devices are now QOM'ified. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/pci/pci.h | 1 - hw/pci/pci.c | 14 -- 2 files changed, 15 deletions(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 8d02a0a383..0f1ed64c2f 100644 --- a/include/hw/pci/

[Qemu-devel] [PATCH 2/4] hw/pci-host/piix: QOM'ify the IGD Passthrough host bridge

2017-12-17 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/piix.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index a684a7cca9..0153f32a32 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-host/piix.c @@ -804,

[Qemu-devel] [PATCH 3/4] hw/pci-host/xilinx: QOM'ify the AXI-PCIe host bridge

2017-12-17 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/xilinx-pcie.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/hw/pci-host/xilinx-pcie.c b/hw/pci-host/xilinx-pcie.c index 7659253090..756db39fd5 100644 --- a/hw/pci-host/xilinx-pcie.c +++ b/hw/pci-host/

[Qemu-devel] [PULL 05/61] qht: fix kernel-doc markup in qht.h

2017-12-17 Thread Michael Tokarev
From: "Emilio G. Cota" While at it, s/stuct/struct/. Signed-off-by: Emilio G. Cota Signed-off-by: Michael Tokarev --- include/qemu/qht.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/qemu/qht.h b/include/qemu/qht.h index 56c2c7784c..531aa95325 100644 --- a/

[Qemu-devel] [PULL 00/61] Trivial patches for 2017-12-18

2017-12-17 Thread Michael Tokarev
Here's a large pull request for trivial-patches queue. It's been quite a whie since the last request, and many changes has been accumulated. Also there's a large patchset by Philippe Mathieu-Daudé named "remove i386/pc dependency from non-PC world (part 1)" consisting of 42 patches which makes goo

[Qemu-devel] [PULL 15/61] MAINTAINERS: add "hw/registerfields.h" in Register API entry

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Orphan since afb3141c660 Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Darren Kenny Reviewed-by: Alistair Francis Reviewed-by: Edgar E. Iglesias Signed-off-by: Michael Tokarev --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS

[Qemu-devel] [PULL 52/61] hw/acpi: ACPI_PM_* defines are not restricted to i386 arch

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé this allows to remove the old i386/pc dependency on acpi/core. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov --- hw/acpi/core.c | 1 - include/hw/acpi/acpi.h | 11 +++ include/hw/i386/pc.h | 11 --- 3 files changed, 11

[Qemu-devel] [PULL 55/61] hw/display/vga: "vga_int.h" requires "ui/console.h"

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé since The VGACommonState struct has a GraphicHwOps *hw_ops member, then remove the now unnecessary includes. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- hw/display/cirrus_vga.c | 1 - hw/display/qxl.h| 1 - hw/display/vga-isa-mm.c |

[Qemu-devel] [PULL 01/61] Remove empty statements

2017-12-17 Thread Michael Tokarev
From: Ladi Prosek Thanks to Laszlo Ersek for spotting the double semicolon in target/i386/kvm.c I have trivially grepped the tree for ';;' in C files. Suggested-by: Laszlo Ersek Signed-off-by: Ladi Prosek Reviewed-by: Laszlo Ersek Reviewed-by: Cornelia Huck Reviewed-by: Laurent Vivier Sign

[Qemu-devel] [PULL 59/61] i386/pc: move vmport.c to hw/i386/

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé It's a x86-only device, so it does not make sense to keep it in the shared misc folder. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- hw/i386/Makefile.objs | 1 + hw/{misc => i386}/vmport.c | 17 + hw/misc/Makefile.objs

[Qemu-devel] [PULL 39/61] hw/input/vmmouse: remove unused #include

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé --- hw/input/vmmouse.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/input/vmmouse.c b/hw/input/vmmouse.c index b6d22086f4..65ef55329e 100644 --- a/hw/input/vmmouse.c +++ b/hw/input/vmmouse.c @@ -24,7 +24,6 @@ #include

[Qemu-devel] [PULL 13/61] accel/tcg/cpu-exec-common.c: Remove unnecessary include of memory-internal.h

2017-12-17 Thread Michael Tokarev
From: Peter Maydell The cpu-exec-common.c file includes memory-internal.h, but it doesn't actually use anything from that header. Remove the unnecessary include. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson

[Qemu-devel] [PULL 30/61] block: remove "qemu/osdep.h" from header file

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell --- block/dmg.h | 1 - 1 file changed, 1 deletion(-) diff --git a/block/dmg.h b/block/dmg.h index b592d6fa8b..2ecf239ba5 100644 --- a/block/dmg.h +++ b/block/d

[Qemu-devel] [PULL 02/61] hw/alpha/typhoon: simplify using the "unimplemented" sysbus device

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Michael Tokarev --- hw/alpha/alpha_sys.h | 1 - hw/alpha/pci.c | 26 -- hw/alpha/typhoon.c | 6 ++ 3 files changed, 2 insertions(+), 31 deleti

Re: [Qemu-devel] [PULL v1 00/32] Merge tpm 2017/12/15

2017-12-17 Thread Peter Maydell
On 16 December 2017 at 17:41, Stefan Berger wrote: > The following patch series refactors the TPM TIS and backend drivers for > easier addition of new front-end devices. Further, the TPM buffer sizes > are read from the backend and the backend's buffer size can be adjusted > by the frontend, if ne

[Qemu-devel] [PULL 07/61] mmap(2) returns MAP_FAILED, not NULL, on failure

2017-12-17 Thread Michael Tokarev
From: Michael McConville Signed-off-by: Michael McConville Reviewed-by: John Snow Signed-off-by: Michael Tokarev --- hw/i386/xen/xen-mapcache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/xen/xen-mapcache.c b/hw/i386/xen/xen-mapcache.c index baab93b614..efa35dc

[Qemu-devel] [PULL 36/61] nios2: remove duplicated includes (in code commented out)

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell --- disas/nios2.c| 3 --- hw/nios2/boot.c | 1 - target/nios2/cpu.h | 1 - target/nios2/helper.c| 5 + target/nios2/op_helper

[Qemu-devel] [PULL 08/61] .gitignore: remove vscclient

2017-12-17 Thread Michael Tokarev
From: Marc-André Lureau It was removed with libcacard, since: commit 7b02f5447c64d1854468f758398c9f6fe9e5721f Author: Marc-André Lureau Date: Sun Aug 30 11:48:40 2015 +0200 libcacard: use the standalone project Signed-off-by: Marc-André Lureau Signed-off-by: Michael Tokarev --- .giti

[Qemu-devel] [PULL 47/61] hw/tpm: remove old i386 dependency

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Berger --- hw/tpm/tpm_passthrough.c | 1 - hw/tpm/tpm_tis.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/tpm/tpm_passthrough.c b/hw/tpm/tpm_passthrough.c index c440aff4b2..d904d8e33f 10064

[Qemu-devel] [PULL 04/61] translate-all: fix 'consisits' typo in comment

2017-12-17 Thread Michael Tokarev
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Signed-off-by: Michael Tokarev --- accel/tcg/translate-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index e7f0329a52..02dfa361bb 100644 --- a/accel/tcg/transl

[Qemu-devel] [PULL 34/61] i386/hax: remove duplicated includes

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell --- include/sysemu/hax.h | 1 - target/i386/hax-darwin.c | 6 +- target/i386/hax-darwin.h | 3 --- target/i386/hax-windows.h | 2 -- 4 files changed,

[Qemu-devel] [PULL 40/61] hw/misc/pvpanic: remove unused #include

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/pvpanic.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c index 2b1e9a6450..3a0e4ba828 100644 --- a/hw/misc/pvpanic.c +++ b/hw/misc/pvpanic.c @@ -13,14 +13,11 @@ */ #i

[Qemu-devel] [PULL 41/61] hw/ssi/aspeed_smc: remove unused #include

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell --- hw/ssi/aspeed_smc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index 992617fd3a..5059396bc6 100644 --- a/hw/ssi/aspeed_smc.c +++ b/hw/ssi/aspeed_s

[Qemu-devel] [PULL 23/61] MAINTAINERS: add an entry for the i82378 (superio)

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Hervé Poussineau Reviewed-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index b48065aad6..1a379edc80 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7

[Qemu-devel] [PULL 33/61] ppc: remove duplicated includes

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé applied using ./scripts/clean-includes not needed since 7ebaf795560 Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Acked-by: David Gibson --- hw/ppc/spapr_hcall.c | 1 - target/ppc/kvm.c | 3 --- 2 files changed, 4 deletions(-) diff --git

[Qemu-devel] [PULL 35/61] i386/hax: remove duplicated include

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé this file in include in "target/i386/hax-i386.h": #ifdef CONFIG_WIN32 #include "target/i386/hax-windows.h" #endif which guaranties that sysemu/os-win32.h is previously included (CONFIG_WIN32) Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-

[Qemu-devel] [PULL 10/61] Document pretty parameter for mon option

2017-12-17 Thread Michael Tokarev
From: Vicente Jimenez Aguilar Documentation: document pretty parameter for mon option that turns on JSON pretty printing Signed-off-by: Vicente Jimenez Aguilar Signed-off-by: Michael Tokarev --- qemu-options.hx | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/qemu-op

[Qemu-devel] [PULL 06/61] configure: check $CC available before verifying host CPU

2017-12-17 Thread Michael Tokarev
From: Daniel Henrique Barboza When executing 'configure' in a fresh QEMU clone, in a fresh OS install running in a ppc64le host, this is the error shown: - ../configure --enable-trace-backend=simple --enable-debug --target-list=ppc64-softmmu ERROR: Unsupported CPU = ppc64le, try --enab

[Qemu-devel] [PULL v2 00/61] Trivial patches for 2017-12-18

2017-12-17 Thread Michael Tokarev
> Here's a large pull request for trivial-patches queue. > It's been quite a whie since the last request, and many > changes has been accumulated. > > Also there's a large patchset by Philippe Mathieu-Daudé > named "remove i386/pc dependency from non-PC world (part 1)" > consisting of 42 patches w

Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations

2017-12-17 Thread Matthew Wilcox
On Sun, Dec 17, 2017 at 01:47:21PM +, Wang, Wei W wrote: > On Saturday, December 16, 2017 3:22 AM, Matthew Wilcox wrote: > > On Fri, Dec 15, 2017 at 10:49:15AM -0800, Matthew Wilcox wrote: > > > Here's the API I'm looking at right now. The user need take no lock; > > > the locking (spinlock) i

[Qemu-devel] [PULL 48/61] hw/virtio-balloon: remove old i386 dependency

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- hw/virtio/virtio-balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index 37cde38982..14e08d20d0 100644 --- a/hw/vi

[Qemu-devel] [PULL 51/61] hw/timer/mc146818: rename rtc_init() -> mc146818_rtc_init()

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Hervé Poussineau Reviewed-by: David Gibson --- hw/alpha/dp264.c | 2 +- hw/i386/pc.c | 2 +- hw/isa/i82378.c| 3 ++- hw/mips/mips_fulong2e.c| 2 +- hw/mips/m

[Qemu-devel] [PULL 17/61] hw/registerfields: add 64-bit extract/deposit macros

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Darren Kenny Reviewed-by: Alistair Francis Reviewed-by: Edgar E. Iglesias Signed-off-by: Michael Tokarev --- include/hw/registerfields.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/include/h

[Qemu-devel] [PULL 14/61] Makefile: add more targets to the UNCHECKED_GOALS rule

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé These targets don't need a full build of git submodules. (See b8e535ae8af and eaa2ddbb767). Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Michael Tokarev --- Makefile | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefil

[Qemu-devel] [PULL 38/61] numa: remove unused #include

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell --- numa.c | 1 - 1 file changed, 1 deletion(-) diff --git a/numa.c b/numa.c index 98fa9a4bcf..7b9c33ad12 100644 --- a/numa.c +++ b/numa.c @@ -29,7 +29,6 @@ #include "qemu/bitmap.h" #include "qom/c

[Qemu-devel] [PULL 49/61] hw/unicore32: restrict hw addr defines to source file

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé and drop unused #includes Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- hw/unicore32/puv3.c | 15 ++- include/hw/unicore32/puv3.h | 10 -- 2 files changed, 10 insertions(+), 15 deletions(-) diff --git a/hw/unicore3

Re: [Qemu-devel] [PULL v2 00/61] Trivial patches for 2017-12-18

2017-12-17 Thread Peter Maydell
On 17 December 2017 at 22:07, Michael Tokarev wrote: >> Here's a large pull request for trivial-patches queue. >> It's been quite a whie since the last request, and many >> changes has been accumulated. >> >> Also there's a large patchset by Philippe Mathieu-Daudé >> named "remove i386/pc dependen

[Qemu-devel] [PULL 46/61] hw/i2c: remove old i386 dependency

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- hw/i2c/pm_smbus.c | 1 - hw/i2c/smbus_ich9.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/i2c/pm_smbus.c b/hw/i2c/pm_smbus.c index 6fc3923f56..a044dd1b27 100644 --- a/hw/i2c/pm_smbus.c

[Qemu-devel] [PULL 12/61] build: fix typo in error message

2017-12-17 Thread Michael Tokarev
From: Mike Frysinger Signed-off-by: Mike Frysinger Reviewed-by: John Snow Reviewed-by: Eric Blake Signed-off-by: Michael Tokarev --- scripts/git-submodule.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh index 030617b4

[Qemu-devel] [PULL 18/61] hw/registerfields: add missing include

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé This allows to use this header in qtests. This fixes: CC tests/test.o include/hw/registerfields.h:32:41: error: implicit declaration of function ‘MAKE_64BIT_MASK’ [-Werror=implicit-function-declaration] MAKE_64BIT_MASK(shift, length)};

[Qemu-devel] [PULL 37/61] misc: avoid "include/" in include path

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell --- hw/input/adb.c | 2 +- hw/ssi/aspeed_smc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/input/adb.c b/hw/input/adb.c index fcca3a8eb9..924a3f9fd5 100644 --- a/hw/

[Qemu-devel] [PULL 19/61] hw/input/hid: Add support for several keys.

2017-12-17 Thread Michael Tokarev
From: Tao Wu Add support for these keys: audiomute volumedown volumeup power. Tested with "sendkey" command in monitor and verify the behavior in guest OS. Signed-off-by: Tao Wu Signed-off-by: Michael Tokarev --- hw/input/hid.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) di

[Qemu-devel] [PULL 31/61] misc: remove headers implicitly included

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Stefan Hajnoczi Reviewed-by: Ben Warren --- bsd-user/main.c | 1 - chardev/wctablet.c | 4 hw/audio/fmopl.h

Re: [Qemu-devel] [Qemu-trivial] [PULL v2 00/61] Trivial patches for 2017-12-18

2017-12-17 Thread Philippe Mathieu-Daudé
Hi Peter, On 12/17/2017 08:14 PM, Peter Maydell wrote: > On 17 December 2017 at 22:07, Michael Tokarev wrote: >>> Here's a large pull request for trivial-patches queue. >>> It's been quite a whie since the last request, and many >>> changes has been accumulated. >>> >>> Also there's a large patch

Re: [Qemu-devel] [PATCH v2 03/19] spapr: introduce the XIVE interrupt sources

2017-12-17 Thread Benjamin Herrenschmidt
On Thu, 2017-12-14 at 16:24 +0100, Cédric Le Goater wrote: > The API between the source and the IVRE is extremely simple : > > static void spapr_xive_irq(sPAPRXive *xive, int lisn) > > The IVRE then scans its IVT, finds the EQ, and moves on to the > presenter. In HW it's an MMIO store between

[Qemu-devel] [PULL 22/61] MAINTAINERS: add an entry for the i8257 (DMA controller)

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 10079f4a21..b48065aad6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -877,6 +877,7 @@ F: hw/timer/hpet* F: hw/timer/i8254* F:

[Qemu-devel] [PULL 16/61] hw/registerfields: fix a typo in the FIELD() documentation

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Darren Kenny Reviewed-by: Alistair Francis Reviewed-by: Edgar E. Iglesias Signed-off-by: Michael Tokarev --- include/hw/registerfields.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includ

[Qemu-devel] [PULL 60/61] i386/pc: move vmmouse.c to hw/i386/

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé It's a x86-only device, so it does not make sense to keep it in the shared misc folder. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- hw/i386/Makefile.objs| 1 + hw/{input => i386}/vmmouse.c | 0 hw/input/Makefile.objs | 1 - 3 f

[Qemu-devel] [PULL 50/61] hw/timer/i8254: rename pit_init() -> i8254_pit_init()

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé and remove the old i386/pc dependency Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Hervé Poussineau --- hw/alpha/dp264.c | 2 +- hw/i386/pc.c | 2 +- hw/isa/i82378.c | 2 +- hw/mips/mips_fulong2e.c

[Qemu-devel] [PULL 20/61] MAINTAINERS: add entries for i2c/ppc4xx

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Corey Minyard --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 55e403833f..331c2efeaf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -

[Qemu-devel] [PULL 24/61] MAINTAINERS: add an entry for watchdog/wdt_ib700

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1a379edc80..2122a2a024 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -877,6 +877,7 @@ F: hw/misc/pc-te

Re: [Qemu-devel] [PATCH] docs/devel/migration.txt: keep functions consistent with the code

2017-12-17 Thread Zhoujian (jay)
> -Original Message- > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > Sent: Friday, December 15, 2017 11:15 PM > To: Daniel P. Berrange > Cc: Zhoujian (jay) ; qemu-devel@nongnu.org; > quint...@redhat.com; Huangweidong (C) ; wangxin > (U) > Subject: Re: [PATCH] docs/devel/migr

Re: [Qemu-devel] [Qemu-trivial] [PULL v2 00/61] Trivial patches for 2017-12-18

2017-12-17 Thread Philippe Mathieu-Daudé
>> I'm afraid this fails 'make check'. (I only tested the >> first pullreq but if you only changed signoffs then >> it'll still be the same): >> >> TEST: tests/qom-test... (pid=12208) >> /alpha/qom/clipper: >> Broken pipe >> FAIL >> GTester: last random seed: R02S26a31a16d967b2664ad714c1c7f8e7f1

[Qemu-devel] [PATCH] hw/tpm: remove old i386 dependency

2017-12-17 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Berger --- Based-on: 1513446109-9013-33-git-send-email-stef...@linux.vnet.ibm.com --- hw/tpm/tpm_emulator.c| 1 - hw/tpm/tpm_passthrough.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/tpm/tpm_emulator.c b/hw/tpm/tpm_emulato

[Qemu-devel] [PULL 42/61] amd_iommu: avoid needless includes in header file

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé instead move them to the source file Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- hw/i386/amd_iommu.c | 5 - hw/i386/amd_iommu.h | 5 - 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_i

[Qemu-devel] [PULL 09/61] memory: remove unused memory_region_set_global_locking()

2017-12-17 Thread Michael Tokarev
From: Marc-André Lureau This was never used since its introduction in commit 196ea13104f8 ("memory: Add global-locking property to memory regions"). Signed-off-by: Marc-André Lureau Signed-off-by: Michael Tokarev --- include/exec/memory.h | 12 memory.c | 5 - 2

[Qemu-devel] [PULL 27/61] MAINTAINERS: add missing entry for include/hw/net/

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Hervé Poussineau --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 33cd4f6bed..acbff2f1bb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1004,6 +1004,7 @@ Network d

[Qemu-devel] [PULL 29/61] hw: remove "qemu/osdep.h" from header files

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Corey Minyard Tested-by: Corey Minyard --- include/hw/acpi/ipmi.h | 1 - include/hw/cpu/core.h | 1 - include/hw/i2c/ppc4xx_i2c.h | 1

[Qemu-devel] [PULL 45/61] hw/ipmi: remove old i386 dependency

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Corey Minyard Tested-by: Corey Minyard --- hw/ipmi/isa_ipmi_bt.c | 1 - hw/ipmi/isa_ipmi_kcs.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/ipmi/isa_ipmi_bt.c b/hw/ipmi/isa_ipmi_bt.c index 2fcc3d2e7c..

[Qemu-devel] [PULL 53/61] hw/acpi/ich9: extract ACPI_PM_PROP_TCO_ENABLED from i386/pc

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé enable_tco is specific to i386/pc. Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov --- include/hw/acpi/ich9.h | 2 ++ include/hw/i386/pc.h | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/includ

[Qemu-devel] [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image to qemu-slof-20171214

2017-12-17 Thread Alexey Kardashevskiy
The following changes since commit 6b092cf3141ec02fa5f533ecdcd24264febfcd76: pseries: Update SLOF firmware image to qemu-slof-20171214 (2017-12-18 13:16:40 +1100) are available in the git repository at: g...@github.com:aik/qemu.git tags/qemu-slof-20171214 for you to fetch changes up to 6b0

Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations

2017-12-17 Thread Wei Wang
On 12/18/2017 06:18 AM, Matthew Wilcox wrote: On Sun, Dec 17, 2017 at 01:47:21PM +, Wang, Wei W wrote: On Saturday, December 16, 2017 3:22 AM, Matthew Wilcox wrote: On Fri, Dec 15, 2017 at 10:49:15AM -0800, Matthew Wilcox wrote: - xbit_clear() can't return an error. Neither can xbit_zero

Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations

2017-12-17 Thread Matthew Wilcox
On Mon, Dec 18, 2017 at 10:33:00AM +0800, Wei Wang wrote: > > My only qualm is that I've been considering optimising the memory > > consumption when an entire 1024-bit chunk is full; instead of keeping a > > pointer to a 128-byte entry full of ones, store a special value in the > > radix tree which

[Qemu-devel] [Bug 1735653] Re: qemu aarch64 cannot boot linux kernel v4.6+

2017-12-17 Thread Joey Jiao
Thanks Peter, I repeat the step again and it indeed succeed for v4.9 kernel, So I think the ./aarch64-softmmu/qemu-system-aarch64 should be the issue. The case can be closed now. Thanks again. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

[Qemu-devel] [PULL 11/61] Makefile: use $(MAKE) variable

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé For some systems (i.e. FreeBSD) the default 'make' is not compatible with the GNU extensions used by QEMU makefiles. Calling the GNU make (gmake) works, however the help displayed refers to the host 'make' and copy/paste leads to lot of unobvious errors: $ gmake c

[Qemu-devel] [PULL 54/61] hw/display/vga: "vga.h" only contains registers defs, rename it "vga_regs.h"

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- hw/display/vga.c | 2 +- hw/display/{vga.h => vga_regs.h} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename hw/display/{vga.h => vga_regs.h} (100%) diff --git a/hw/display

[Qemu-devel] [PULL 61/61] misc: drop old i386 dependency

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- hw/char/debugcon.c | 1 - hw/intc/lm32_pic.c | 1 - hw/moxie/moxiesim.c | 1 - hw/sparc/sun4m.c| 1 - hw/watchdog/wdt_ib700.c | 1 - 5 files changed, 5 deletions(-) diff --git

[Qemu-devel] [PULL 32/61] misc: remove duplicated includes

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé exec: housekeeping (funny since 02d0e095031) applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Acked-by: Cornelia Huck Reviewed-by: Anthony PERARD --- accel/tcg/translate-all.c | 1 - exec.c

Re: [Qemu-devel] [PATCH] target-ppc: optimize cmp translation

2017-12-17 Thread David Gibson
On Sun, Dec 17, 2017 at 06:49:53AM +0100, Paolo Bonzini wrote: > We know that only one bit (in addition to SO) is going to be set in > the condition register, so do two movconds instead of three setconds, > three shifts and two ORs. > > For ppc64-linux-user, the code size reduction is around 5% an

[Qemu-devel] [PULL 58/61] hw/misc/pvpanic: extract public API from i386/pc to "hw/misc/pvpanic.h"

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé and remove the old i386/pc dependency. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/acpi-build.c | 2 +- hw/misc/pvpanic.c | 9 - include/hw/i386/pc.h | 3 --- include/hw/misc/pvpanic.h | 21 + 4 files changed,

[Qemu-devel] [PULL 43/61] misc: remove old i386 dependency

2017-12-17 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Anthony PERARD --- hw/audio/pcspk.c| 1 - hw/i386/xen/xen_platform.c | 1 - hw/isa/vt82c686.c | 1 - hw/misc/ivshmem.c | 1

Re: [Qemu-devel] [RFC v5 07/26] monitor: unify global init

2017-12-17 Thread Peter Xu
On Sat, Dec 16, 2017 at 09:01:12AM +, Stefan Hajnoczi wrote: > On Sat, Dec 16, 2017 at 11:52:28AM +0800, Peter Xu wrote: > > On Fri, Dec 15, 2017 at 12:47:11PM +, Stefan Hajnoczi wrote: > > > On Fri, Dec 15, 2017 at 04:11:41PM +0800, Peter Xu wrote: > > > > On Wed, Dec 13, 2017 at 03:48:06P

Re: [Qemu-devel] [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image to qemu-slof-20171214

2017-12-17 Thread David Gibson
On Mon, Dec 18, 2017 at 01:26:05PM +1100, Alexey Kardashevskiy wrote: > The following changes since commit 6b092cf3141ec02fa5f533ecdcd24264febfcd76: > > pseries: Update SLOF firmware image to qemu-slof-20171214 (2017-12-18 > 13:16:40 +1100) > > are available in the git repository at: > > g.

Re: [Qemu-devel] [PATCH 0/2] More SM501 improvements

2017-12-17 Thread David Gibson
On Sat, Dec 16, 2017 at 11:57:46PM +0100, BALATON Zoltan wrote: > Two simple patches to add some more registers that were found to be > accessed by some guests. > > BALATON Zoltan (3): > sm501: Add panel hardware cursor registers also to read function > sm501: Add some more unimplemented regis

Re: [Qemu-devel] [PATCH qemu] RFC: vfio-pci: Allow mmap of MSIX BAR

2017-12-17 Thread David Gibson
On Fri, Dec 15, 2017 at 09:04:28AM -0700, Alex Williamson wrote: > On Fri, 15 Dec 2017 15:07:31 +1100 > David Gibson wrote: > > > On Tue, Dec 12, 2017 at 04:21:31PM +1100, Alexey Kardashevskiy wrote: > > > This makes use of a new VFIO_REGION_INFO_CAP_MSIX_MAPPABLE capability > > > which tells tha

Re: [Qemu-devel] [PATCH v2] hw/ide: Emulate SiI3112 SATA controller

2017-12-17 Thread David Gibson
On Sat, Dec 16, 2017 at 11:42:39PM +0100, BALATON Zoltan wrote: > This is a common generic PCI SATA controller that is also used in PCs > but more importantly guests running on the Sam460ex board prefer this > card and have a driver for it (unlike for other SATA controllers > already emulated). >

Re: [Qemu-devel] [PATCH v2] ppc4xx_i2c: Implement basic I2C functions

2017-12-17 Thread David Gibson
On Sat, Dec 16, 2017 at 11:42:14PM +0100, BALATON Zoltan wrote: > Enough to please U-Boot and make it able to detect SDRAM SPD EEPROMs > > Signed-off-by: François Revol > Signed-off-by: BALATON Zoltan > Reviewed-by: David Gibson Applied to ppc-for-2.12, thanks. > --- > v2: > - Removed DPRINTF

[Qemu-devel] [Bug 1738691] [NEW] Guest kernel crashes with kvm_pr on POWER8

2017-12-17 Thread Timothy Pearson
Public bug reported: When attempting to use the kvm_pr module with QEMU 2.10 on a POWER8 host, Debian and Ubuntu guests hang and show crashes. Host kernel is 4.14. Issue is observed with host kernels 4.9 and 4.13 as well; no other host kernels were tested. Is this the correct place to report a

  1   2   >