Hi Peter, On 12/17/2017 08:14 PM, Peter Maydell wrote: > On 17 December 2017 at 22:07, Michael Tokarev <m...@tls.msk.ru> wrote: >>> Here's a large pull request for trivial-patches queue. >>> It's been quite a whie since the last request, and many >>> changes has been accumulated. >>> >>> Also there's a large patchset by Philippe Mathieu-Daudé >>> named "remove i386/pc dependency from non-PC world (part 1)" >>> consisting of 42 patches which makes good portion of this >>> pull request. >> >> I forgot to add my S-o-b lines to the large series by >> Philippe Mathieu-Daudé. So here's a re-send of just the >> cover letter (not all the other patches). The only difference >> is the addition of 42 of my "S-o-b" line. > > I'm afraid this fails 'make check'. (I only tested the > first pullreq but if you only changed signoffs then > it'll still be the same): > > TEST: tests/qom-test... (pid=12208) > /alpha/qom/clipper: > Broken pipe > FAIL > GTester: last random seed: R02S26a31a16d967b2664ad714c1c7f8e7f1 > (pid=12214)
Oops > /alpha/qom/none: OK > FAIL: tests/qom-test > TEST: tests/test-hmp... (pid=12219) > /alpha/hmp/clipper: > Broken pipe > FAIL > GTester: last random seed: R02S0c5a0f7de3fc6e9885b740c77c86eef2 > (pid=12225) > /alpha/hmp/none: OK > /alpha/hmp/none+2MB: OK > FAIL: tests/test-hmp > > This is because qemu-system-alpha segfaults on startup: My bad... eede06dd70f72da489b8f968abbb7cb5445ef834 is the first bad commit Author: Philippe Mathieu-Daudé <f4...@amsat.org> hw/alpha/typhoon: simplify using the "unimplemented" sysbus device I'm pretty sure I run the qtests, but this was 2 months ago... I'll have a look. [...] > There was also a minor merge conflict with the tpm pullreq > (both pulls change the #includes in hw/tpm/tpm_tis.c) which > you might fix when you respin. Yes, I rebased the 42 patches on /master yesterday but I see you merged the TPM tree in your /staging, so I'll rebase there and resend the offending patches fixed to Michael. Regards, Phil.
signature.asc
Description: OpenPGP digital signature