>> I'm afraid this fails 'make check'. (I only tested the >> first pullreq but if you only changed signoffs then >> it'll still be the same): >> >> TEST: tests/qom-test... (pid=12208) >> /alpha/qom/clipper: >> Broken pipe >> FAIL >> GTester: last random seed: R02S26a31a16d967b2664ad714c1c7f8e7f1 >> (pid=12214) > > Oops > >> /alpha/qom/none: OK >> FAIL: tests/qom-test >> TEST: tests/test-hmp... (pid=12219) >> /alpha/hmp/clipper: >> Broken pipe >> FAIL >> GTester: last random seed: R02S0c5a0f7de3fc6e9885b740c77c86eef2 >> (pid=12225) >> /alpha/hmp/none: OK >> /alpha/hmp/none+2MB: OK >> FAIL: tests/test-hmp >> >> This is because qemu-system-alpha segfaults on startup: > > My bad... > > eede06dd70f72da489b8f968abbb7cb5445ef834 is the first bad commit > Author: Philippe Mathieu-Daudé <f4...@amsat.org> > > hw/alpha/typhoon: simplify using the "unimplemented" sysbus device > > I'm pretty sure I run the qtests, but this was 2 months ago... > I'll have a look.
This patch is not _trivial_ :| Let's drop it from this tree, I'll have to rework it. > [...] >> There was also a minor merge conflict with the tpm pullreq >> (both pulls change the #includes in hw/tpm/tpm_tis.c) which >> you might fix when you respin. > > Yes, I rebased the 42 patches on /master yesterday but I see you merged > the TPM tree in your /staging, so I'll rebase there and resend the > offending patches fixed to Michael. Michael, I removed the "hw/alpha/typhoon" patch, and updated the "hw/tpm: remove old i386 dependency" one: no need to modify hw/tpm/tpm_tis.c, Marc-André Lureau already cleaned it, I did however clean the newly added hw/tpm/tpm_emulator.c file. The fixed tree is now available signed in the Git repository at: github.com:philmd/qemu.git tags/trivial-patches-2017-12-18 If this is OK to you I'll only resend the "hw/tpm: remove old i386 dependency" on the list, but if you/Peter prefer I can still resend the whole enchilada (which is unchanged except this unique patch). Regards, Phil.
signature.asc
Description: OpenPGP digital signature
