[Qemu-devel] [PATCH] target/i386: add CPU model "Skylake-Server-clflushopt"

2017-12-11 Thread Haozhong Zhang
The only difference from the existing CPU model "Skylake-Server" is the add of CPUID_7_0_EBX_CLFLUSHOPT, which is missed in "Skylake-Server". Signed-off-by: Haozhong Zhang --- target/i386/cpu.c | 49 + 1 file changed, 49 insertions(+) diff --git a

Re: [Qemu-devel] [PATCH 3/3] ide: abort TRIM operation for invalid range

2017-12-11 Thread Anton Nefedov
On 8/12/2017 10:51 PM, John Snow wrote: Looks about right, just remember that this flow won't call block_acct_invalid because you're bypassing the return to ide_dma_cb. I assume you'll get to that in your next series. Yes; I meant to keep the trim accounting in ide_issue_trim_cb() For now,

Re: [Qemu-devel] [PATCH 00/12] Refactor get_phys_addr() not to return FSR values

2017-12-11 Thread Edgar E. Iglesias
On Tue, Dec 05, 2017 at 07:46:20PM +, Peter Maydell wrote: > Currently get_phys_addr() and its various subfunctions return a > hard-coded fault status register value for translation failures. This > is awkward because FSR values these days may be either long-descriptor > format or short-descrip

Re: [Qemu-devel] [PATCH v2] qemu-img: Document --force-share / -U

2017-12-11 Thread Kashyap Chamarthy
On Fri, Dec 08, 2017 at 09:44:56AM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > > --- > v2: - "code{qemu-img}". [Kashyap, Eric] > - "etc.." -> "etc.". > --- > qemu-img.texi | 9 + > 1 file changed, 9 insertions(+) Reviewed-by: Kashyap Chamarthy [...] -- /kashyap

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-11 Thread Denis V. Lunev
On 12/09/2017 03:57 AM, John Snow wrote: > This is going to be a long one. Maybe go get a cup of coffee. > > On 12/07/2017 04:39 AM, Vladimir Sementsov-Ogievskiy wrote: >> 07.12.2017 03:38, John Snow wrote: >>> I'm sorry, I don't think I understand. >>> >>> "customers needs a possibility to create

Re: [Qemu-devel] [PATCH v6 09/20] parallels: Switch to .bdrv_co_block_status()

2017-12-11 Thread Vladimir Sementsov-Ogievskiy
09.12.2017 19:39, Eric Blake wrote: On 12/09/2017 06:31 AM, Vladimir Sementsov-Ogievskiy wrote: 07.12.2017 23:30, Eric Blake wrote: We are gradually moving away from sector-based interfaces, towards byte-based.  Update the parallels driver accordingly.  Note that the internal function block_sta

Re: [Qemu-devel] [Qemu-block] [PATCH v2] qemu-img: Document --force-share / -U

2017-12-11 Thread Fam Zheng
On Fri, 12/08 09:54, Stefan Hajnoczi wrote: > On Fri, Dec 08, 2017 at 09:44:56AM +0800, Fam Zheng wrote: > > +@item --force-share (-U) > > + > > +If specified, @code{qemu-img} will open the image with shared permissions, > > +which makes it less likely to conflict with a running guest's permissions

[Qemu-devel] [PATCH v3] qemu-img: Document --force-share / -U

2017-12-11 Thread Fam Zheng
Signed-off-by: Fam Zheng --- v3: Document that the option is not allowed for read-write. [Stefan] v2: - "code{qemu-img}". [Kashyap, Eric] - "etc.." -> "etc.". --- qemu-img.texi | 9 + 1 file changed, 9 insertions(+) diff --git a/qemu-img.texi b/qemu-img.texi index fdcf120f36..d85a

Re: [Qemu-devel] [RFC PATCH 0/5] Scoped locks using attribute((cleanup))

2017-12-11 Thread Peter Maydell
On 8 December 2017 at 19:40, Eric Blake wrote: > On 12/08/2017 04:55 AM, Paolo Bonzini wrote: >> Likewise, >> >> QEMU_WITH_LOCK(QemuMutex, guard_name, &some_mutex) { >> ... >> } >> >> is the same as >> >> qemu_mutex_lock(&some_mutex); >> ... >> qemu_mutex_unlock(&some_m

Re: [Qemu-devel] [RFC] vhost: check if ring mapping is still valid when building memmap

2017-12-11 Thread Igor Mammedov
On Fri, 8 Dec 2017 17:51:56 + "Dr. David Alan Gilbert" wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Thu, 7 Dec 2017 18:17:51 + > > "Dr. David Alan Gilbert" wrote: > > > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > > vhost_verify_ring_mappings() were used to

Re: [Qemu-devel] [PATCH v9 12/12] migration: Add multifd test

2017-12-11 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> We set the x-multifd-page-count and x-multifd-channels. >> >> Signed-off-by: Juan Quintela > > > We *must* find a way to share all the boiler plate I've snipped > out; even this test_migrate function is almost id

Re: [Qemu-devel] [PATCH v9 11/12] migration: Flush receive queue

2017-12-11 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> +/* We are getting low on pages flags, so we start using combinations >> + When we need to flush a page, we sent it as >> + RAM_SAVE_FLAG_MULTIFD_PAGE | RAM_SAVE_FLAG_COMPRESS_PAGE >> + We don't allow that com

Re: [Qemu-devel] [PATCH v3] qemu-img: Document --force-share / -U

2017-12-11 Thread Kevin Wolf
Am 11.12.2017 um 10:33 hat Fam Zheng geschrieben: > Signed-off-by: Fam Zheng > > --- > > v3: Document that the option is not allowed for read-write. [Stefan] > > v2: - "code{qemu-img}". [Kashyap, Eric] > - "etc.." -> "etc.". > --- > qemu-img.texi | 9 + > 1 file changed, 9 insertio

Re: [Qemu-devel] [PATCH v3 for-2.12 00/14] s390x/tcg: CCW hotplug, facilities, instructions

2017-12-11 Thread Cornelia Huck
On Fri, 8 Dec 2017 17:01:53 +0100 David Hildenbrand wrote: > Both series in one piece as (most probably) most reviewing is done. > > Wire up some io instructions and implement new facilitites. Make sure > to take care of MTTCG when it comes to atomic operations. Make CCW > hotplug work. > > As

Re: [Qemu-devel] [PATCH 2/5] lock-guard: add scoped lock implementation

2017-12-11 Thread Stefan Hajnoczi
On Fri, Dec 08, 2017 at 06:56:12PM +0100, Paolo Bonzini wrote: > On 08/12/2017 16:30, Stefan Hajnoczi wrote: > > On Fri, Dec 08, 2017 at 11:55:50AM +0100, Paolo Bonzini wrote: > > > > The implementation is somewhat complex. Please structure the header > > file so the public interfaces are clear a

Re: [Qemu-devel] QEMU not honouring bootorder

2017-12-11 Thread Michal Privoznik
On 12/07/2017 01:10 PM, Michal Privoznik wrote: > Dear list, > Ping. Is there anything I can help you with to have this sorted out? Michal

Re: [Qemu-devel] [PATCH 5/5] thread-pool: convert to use lock guards

2017-12-11 Thread Stefan Hajnoczi
On Fri, Dec 08, 2017 at 02:02:32PM -0600, Eric Blake wrote: > On 12/08/2017 12:12 PM, Paolo Bonzini wrote: > > On 08/12/2017 16:13, Stefan Hajnoczi wrote: > >>> -qemu_mutex_lock(&pool->lock); > >>> +QEMU_LOCK_GUARD(QemuMutex, pool_guard, &pool->lock); > >>> if (pool->idle_threads == 0

Re: [Qemu-devel] [PATCH for 2.11 0/2] QEMU crashes with CD device without media

2017-12-11 Thread Denis V. Lunev
On 11/28/2017 03:10 PM, Denis V. Lunev wrote: > There are 2 cases I have spotted so far: > 1) IDE ATAPI read processing. Actually this was reported from field > 2) QEMU IO hmp command (found during evaluation of (1)) > > SCSI code checks during access that blk_is_available(). These patches add > sa

Re: [Qemu-devel] [PATCH v2 0/2] virtio-blk: miscellaneous changes

2017-12-11 Thread Stefan Hajnoczi
On Fri, Dec 08, 2017 at 09:57:25AM -0600, Mark Kanda wrote: > v2: add check for maximum queue size [Stefan] > > This series is for two minor virtio-blk changes. The first patch > makes the virtio-blk queue size user configurable. The second patch > rejects logical block size > physical block confi

Re: [Qemu-devel] [RFC v2 0/8] Rework vhost memory region updates

2017-12-11 Thread Igor Mammedov
On Fri, 8 Dec 2017 20:32:49 + "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This is an experimental set that reworks the way the vhost > code handles changes in physical address space layout that > came from a discussion with Igor. > > It's intention i

Re: [Qemu-devel] [PATCH v3 26/50] qapi: add 'if' on union variants

2017-12-11 Thread Markus Armbruster
Marc-André Lureau writes: > Signed-off-by: Marc-André Lureau > --- > scripts/qapi.py | 15 ++- > tests/qapi-schema/qapi-schema-test.json | 7 ++- > tests/qapi-schema/qapi-schema-test.out | 8 > tests/qapi-schema/test-qapi.py | 5

[Qemu-devel] [PATCH] display: check irq handler index before access

2017-12-11 Thread P J P
From: Prasad J Pandit The ctz32() routine could return value greater than TC6393XB_GPIOS=16. This could lead to an OOB array access. Add check to avoid it. Reported-by: Moguofang Signed-off-by: Prasad J Pandit --- hw/display/tc6393xb.c | 4 1 file changed, 4 insertions(+) diff --git a/h

Re: [Qemu-devel] [PATCH/RFC v2] s390x: start a new memory region if the old one exceeds KVM_MEM_MAX_NR_PAGES

2017-12-11 Thread Cornelia Huck
On Thu, 7 Dec 2017 15:58:16 +0100 Christian Borntraeger wrote: > KVM does not allow memory regions > KVM_MEM_MAX_NR_PAGES, basically > limiting the memory per slot to 8TB-4k. Lets start a new memory region s/Lets/Let's/ :) > if we cross that boundary. > > With that (and optimistic overcommitm

Re: [Qemu-devel] [RFC] vhost: check if ring mapping is still valid when building memmap

2017-12-11 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Fri, 8 Dec 2017 17:51:56 + > "Dr. David Alan Gilbert" wrote: > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > On Thu, 7 Dec 2017 18:17:51 + > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Igor Mammedov (imamm...@redhat.co

Re: [Qemu-devel] [PATCH/RFC v2] s390x: start a new memory region if the old one exceeds KVM_MEM_MAX_NR_PAGES

2017-12-11 Thread David Hildenbrand
[resending as I noticed that I dropped the ccs when I sent this last week] On 07.12.2017 15:58, Christian Borntraeger wrote: > KVM does not allow memory regions > KVM_MEM_MAX_NR_PAGES, basically > limiting the memory per slot to 8TB-4k. Lets start a new memory region > if we cross that boundary. >

Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-11 Thread Stefan Hajnoczi
On Sat, Dec 09, 2017 at 04:23:17PM +, Wang, Wei W wrote: > On Friday, December 8, 2017 4:34 PM, Stefan Hajnoczi wrote: > > On Fri, Dec 8, 2017 at 6:43 AM, Wei Wang wrote: > > > On 12/08/2017 07:54 AM, Michael S. Tsirkin wrote: > > >> > > >> On Thu, Dec 07, 2017 at 06:28:19PM +, Stefan Hajn

Re: [Qemu-devel] [PATCH] display: check irq handler index before access

2017-12-11 Thread Peter Maydell
On 11 December 2017 at 10:55, P J P wrote: > From: Prasad J Pandit > > The ctz32() routine could return value greater than > TC6393XB_GPIOS=16. This could lead to an OOB array access. > Add check to avoid it. > > Reported-by: Moguofang > Signed-off-by: Prasad J Pandit > --- > hw/display/tc6393

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-11 Thread Kevin Wolf
Am 09.12.2017 um 01:57 hat John Snow geschrieben: > Here's an idea of what this API might look like without revealing > explicit merge/split primitives. > > A new bitmap property that lets us set retention: > > :: block-dirty-bitmap-set-retention bitmap=foo slices=10 > > Or something similar, wh

Re: [Qemu-devel] [PATCH 12/12] WIP ucontext: annotate coroutine stack for ASAN

2017-12-11 Thread Marc-André Lureau
Hi - Original Message - > On Fri, Dec 08, 2017 at 01:58:25AM +0100, Marc-André Lureau wrote: > > Not strictly necessary, but it may help ASAN and remove some false > > positives. > > > > Sadly, this annotation produces an ASAN error: > > > > $ tests/test-coroutine -p /basic/lifecycle > >

Re: [Qemu-devel] [PATCH] tests: virtio-9p: fix ISR dependence

2017-12-11 Thread Stefan Hajnoczi
On Fri, Dec 08, 2017 at 03:26:13PM +0100, Greg Kurz wrote: > Like other virtio tests, use the used ring APIs instead of assuming ISR > being set means the request has completed. > > Signed-off-by: Greg Kurz > --- > tests/virtio-9p-test.c | 30 +++--- > 1 file changed, 1

Re: [Qemu-devel] [PATCH v13 00/12] Add ARMv8 RAS virtualization support in QEMU

2017-12-11 Thread gengdongjiu
Hi maintainer, This patch set seems pending about one month, could you help review for them? Thanks. In this series, except the three patches in [1] are dependent on KVM implementation. Other patches does not depend on KVM/host, because KVM/host has already supported them, According to Jame

Re: [Qemu-devel] [PATCH 00/12] Various build-sys and ASAN related fixes

2017-12-11 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Message-id: 20171208005825.14587-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH 00/12] Various build-sys and ASAN related fixes Type: series === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be

Re: [Qemu-devel] QEMU not honouring bootorder

2017-12-11 Thread Fam Zheng
On Thu, 12/07 13:10, Michal Privoznik wrote: > Dear list, > > I've encountered the following problem. I have two disks: > > /var/lib/libvirt/images/fedora.qcow2 (which contains OS) > /dev/sde (iSCSI dummy disk just for testing) > > Now, when I configure QEMU to start with both of them, QEMU

Re: [Qemu-devel] [PATCH v3] qemu-img: Document --force-share / -U

2017-12-11 Thread Fam Zheng
On Mon, 12/11 10:50, Kevin Wolf wrote: > Am 11.12.2017 um 10:33 hat Fam Zheng geschrieben: > > Signed-off-by: Fam Zheng > > > > --- > > > > v3: Document that the option is not allowed for read-write. [Stefan] > > > > v2: - "code{qemu-img}". [Kashyap, Eric] > > - "etc.." -> "etc.". > > --- >

Re: [Qemu-devel] [PATCH 00/12] Various build-sys and ASAN related fixes

2017-12-11 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20171208005825.14587-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH 00/12] Various build-sys and ASAN

qemu-devel@nongnu.org

2017-12-11 Thread Stefan Hajnoczi
On Thu, Dec 07, 2017 at 10:18:52AM +, Fernando Casas Schössow wrote: > Hi there, > > > Last night while doing a backup of a guest using the live snapshot mechanism > the qemu process for the guest seem to had crashed. > > The snapshot succeeded then the backup of the VM disk had place and a

Re: [Qemu-devel] [PATCH/RFC v2] s390x: start a new memory region if the old one exceeds KVM_MEM_MAX_NR_PAGES

2017-12-11 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20171207145816.87347-1-borntrae...@de.ibm.com Subject: [Qemu-devel] [PATCH/RFC v2] s390x: start a new memory region if the old one exceeds KVM_MEM_MAX_NR_PAGES Type: series === TEST SCRI

Re: [Qemu-devel] QEMU not honouring bootorder

2017-12-11 Thread Michal Privoznik
On 12/11/2017 12:41 PM, Fam Zheng wrote: > On Thu, 12/07 13:10, Michal Privoznik wrote: >> Dear list, >> >> I've encountered the following problem. I have two disks: >> >> /var/lib/libvirt/images/fedora.qcow2 (which contains OS) >> /dev/sde (iSCSI dummy disk just for testing) >> >> Now, when I

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-11 Thread Vladimir Sementsov-Ogievskiy
11.12.2017 14:15, Kevin Wolf wrote: Am 09.12.2017 um 01:57 hat John Snow geschrieben: Here's an idea of what this API might look like without revealing explicit merge/split primitives. A new bitmap property that lets us set retention: :: block-dirty-bitmap-set-retention bitmap=foo slices=10 O

[Qemu-devel] [PATCH v3 1/1] s390-ccw-virtio: allow for systems larger that 7.999TB

2017-12-11 Thread Christian Borntraeger
KVM does not allow memory regions > KVM_MEM_MAX_NR_PAGES, basically limiting the memory per slot to 8TB-4k. As memory slots on s390/kvm must be a multiple of 1MB we need start a new memory region if we cross 8TB-1M. With that (and optimistic overcommitment in the kernel) I was able to start a 24TB

Re: [Qemu-devel] It told me to report this...

2017-12-11 Thread Dr. David Alan Gilbert
* Warner Losh (i...@bsdimp.com) wrote: > unknown keycodes `empty+aliases(qwerty)', please report to > qemu-devel@nongnu.org > > My X server is Mac XQuartz 2.7.11. I saw this question raised several years > ago in the archives, with promises of patches, but couldn't find anything > relevant in the

Re: [Qemu-devel] It told me to report this...

2017-12-11 Thread Daniel P. Berrange
On Mon, Dec 11, 2017 at 12:29:36PM +, Dr. David Alan Gilbert wrote: > * Warner Losh (i...@bsdimp.com) wrote: > > unknown keycodes `empty+aliases(qwerty)', please report to > > qemu-devel@nongnu.org > > > > My X server is Mac XQuartz 2.7.11. I saw this question raised several years > > ago in t

Re: [Qemu-devel] [v22 1/2] virtio-crypto: Add virtio crypto device specification

2017-12-11 Thread Longpeng (Mike)
On 2017/12/6 19:01, Halil Pasic wrote: > > > On 12/06/2017 08:37 AM, Longpeng(Mike) wrote: >> +\field{outcome_len} is the size of struct virtio_crypto_session_input or >> +ZERO for the session-destroy operation. > > This ain't correct. It should have been something like > virtio_crypto_destr

[Qemu-devel] [PATCH v1 00/19] re-factor softfloat and add fp16 functions

2017-12-11 Thread Alex Bennée
Hi, In my previous run at this I'd simply taken the existing float32 functions and attempted to copy and paste the code changing the relevant constants. Apart from the usual typos and missed bits there were sections where softfloat pulls tricks because it knows the exact bit positions of things. W

[Qemu-devel] [PATCH v1 02/19] include/fpu/softfloat: implement float16_abs helper

2017-12-11 Thread Alex Bennée
This will be required when expanding the MINMAX() macro for 16 bit/half-precision operations. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- include/fpu/softfloat.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h index

[Qemu-devel] [PATCH v1 03/19] include/fpu/softfloat: implement float16_chs helper

2017-12-11 Thread Alex Bennée
Signed-off-by: Alex Bennée --- include/fpu/softfloat.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h index edf402d422..32036382c6 100644 --- a/include/fpu/softfloat.h +++ b/include/fpu/softfloat.h @@ -381,6 +381,15 @@ static inline

[Qemu-devel] [PATCH v1 06/19] fpu/softfloat: propagate signalling NaNs in MINMAX

2017-12-11 Thread Alex Bennée
While a comparison between a QNaN and a number will return the number it is not the same with a signaling NaN. In this case the SNaN will "win" and after potentially raising an exception it will be quietened. Signed-off-by: Alex Bennée --- v2 - added return for propageFloat --- fpu/softfloat.

[Qemu-devel] [PATCH v1 01/19] fpu/softfloat: implement float16_squash_input_denormal

2017-12-11 Thread Alex Bennée
This will be required when expanding the MINMAX() macro for 16 bit/half-precision operations. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- fpu/softfloat.c | 15 +++ include/fpu/softfloat.h | 1 + 2 files changed, 16 insertions(+) diff --git a/fpu/softfloat

[Qemu-devel] [PATCH v1 07/19] fpu/softfloat: improve comments on ARM NaN propagation

2017-12-11 Thread Alex Bennée
Mention the pseudo-code fragment from which this is based and correct the spelling of signalling. Signed-off-by: Alex Bennée --- fpu/softfloat-specialize.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h inde

[Qemu-devel] [PATCH v1 05/19] include/fpu/softfloat: add some float16 contants

2017-12-11 Thread Alex Bennée
This defines the same set of common constants for float 16 as defined for 32 and 64 bit floats. These are often used by target helper functions. Signed-off-by: Alex Bennée --- include/fpu/softfloat.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/fpu/softfloat.h b/include/fpu

[Qemu-devel] [PATCH v1 13/19] fpu/softfloat: re-factor muladd

2017-12-11 Thread Alex Bennée
We can now add float16_muladd and use the common decompose and canonicalize functions to have a single implementation for float16/32/64 muladd functions. Signed-off-by: Alex Bennée --- fpu/softfloat-specialize.h | 104 --- fpu/softfloat.c| 756 +---

[Qemu-devel] [PATCH v1 04/19] include/fpu/softfloat: implement float16_set_sign helper

2017-12-11 Thread Alex Bennée
Signed-off-by: Alex Bennée --- include/fpu/softfloat.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h index 32036382c6..17dfe60dbd 100644 --- a/include/fpu/softfloat.h +++ b/include/fpu/softfloat.h @@ -390,6 +390,11 @@ static inline floa

[Qemu-devel] [PATCH v1 14/19] fpu/softfloat: re-factor round_to_int

2017-12-11 Thread Alex Bennée
We can now add float16_round_to_int and use the common round_decomposed and canonicalize functions to have a single implementation for float16/32/64 round_to_int functions. Signed-off-by: Alex Bennée --- fpu/softfloat.c | 304 include/fpu/

[Qemu-devel] [PATCH v1 09/19] fpu/softfloat: define decompose structures

2017-12-11 Thread Alex Bennée
These structures pave the way for generic softfloat helper routines that will operate on fully decomposed numbers. Signed-off-by: Alex Bennée --- fpu/softfloat.c | 72 - 1 file changed, 71 insertions(+), 1 deletion(-) diff --git a/fpu/soft

[Qemu-devel] [PATCH v1 15/19] fpu/softfloat: re-factor float to int/uint

2017-12-11 Thread Alex Bennée
We share the common int64/uint64_pack_decomposed function across all the helpers and simply limit the final result depending on the final size. Signed-off-by: Alex Bennée --- fpu/softfloat.c | 1000 ++- include/fpu/softfloat.h | 13 + 2 files

[Qemu-devel] [PATCH v1 17/19] fpu/softfloat: re-factor scalbn

2017-12-11 Thread Alex Bennée
This is one of the simpler manipulations you could make to a floating point number. Signed-off-by: Alex Bennée --- fpu/softfloat.c | 104 +++- include/fpu/softfloat.h | 1 + 2 files changed, 32 insertions(+), 73 deletions(-) diff --git a/fpu

[Qemu-devel] [PATCH v1 08/19] fpu/softfloat: move the extract functions to the top of the file

2017-12-11 Thread Alex Bennée
This is pure code-motion during re-factoring as the helpers will be needed earlier. Signed-off-by: Alex Bennée --- fpu/softfloat.c | 119 +--- 1 file changed, 53 insertions(+), 66 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c ind

[Qemu-devel] [PATCH v1 18/19] fpu/softfloat: re-factor minmax

2017-12-11 Thread Alex Bennée
Let's do the same re-factor treatment for minmax functions. I still use the MACRO trick to expand but now all the checking code is common. Signed-off-by: Alex Bennée --- fpu/softfloat.c | 242 ++-- include/fpu/softfloat.h | 6 ++ 2 files chan

[Qemu-devel] [PATCH v1 11/19] fpu/softfloat: re-factor mul

2017-12-11 Thread Alex Bennée
We can now add float16_mul and use the common decompose and canonicalize functions to have a single implementation for float16/32/64 versions. Signed-off-by: Alex Bennée --- fpu/softfloat.c | 207 ++-- include/fpu/softfloat.h | 1 + 2 files c

[Qemu-devel] [PATCH v1 10/19] fpu/softfloat: re-factor add/sub

2017-12-11 Thread Alex Bennée
We can now add float16_add/sub and use the common decompose and canonicalize functions to have a single implementation for float16/32/64 add and sub functions. Signed-off-by: Alex Bennée --- fpu/softfloat.c | 903 +--- include/fpu/softfloat.h |

[Qemu-devel] [PATCH v1 19/19] fpu/softfloat: re-factor compare

2017-12-11 Thread Alex Bennée
Signed-off-by: Alex Bennée --- fpu/softfloat.c | 135 +--- include/fpu/softfloat.h | 2 + 2 files changed, 83 insertions(+), 54 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 5eba996932..31b437e000 100644 --- a/fpu/softfloa

[Qemu-devel] [PATCH v1 16/19] fpu/softfloat: re-factor int/uint to float

2017-12-11 Thread Alex Bennée
These are considerably simpler as the lower order integers can just use the higher order conversion function. As the decomposed fractional part is a full 64 bit rounding and inexact handling comes from the pack functions. Signed-off-by: Alex Bennée --- fpu/softfloat.c | 358 +

[Qemu-devel] [PATCH v1 12/19] fpu/softfloat: re-factor div

2017-12-11 Thread Alex Bennée
We can now add float16_div and use the common decompose and canonicalize functions to have a single implementation for float16/32/64 versions. Signed-off-by: Alex Bennée --- fpu/softfloat-macros.h | 44 + fpu/softfloat.c | 235 ++-- i

Re: [Qemu-devel] [PATCH V3] pci: removed the is_express field since a uniform interface was inserted

2017-12-11 Thread Yoni Bettan
On 12/07/2017 10:58 PM, Eduardo Habkost wrote: On Tue, Dec 05, 2017 at 07:17:06PM +0200, Yoni Bettan wrote: * according to Eduardo Habkost's commit fd3b02c8896d597dd8b9e053dec579cf0386aee1 * since all PCIEs now implement INTERFACE_PCIE_DEVICE we don't n

[Qemu-devel] [PATCH v4 00/46] Windbg supporting

2017-12-11 Thread Mihail Abakumov
An update of: v1: https://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg07092.html We made the debugger module WinDbg (like GDB) for QEMU. This is the replacement of the remote stub in Windows kernel. Used for remote Windows kernel debugging without debugging mode. WinDbg is a mul

[Qemu-devel] [PATCH v4 04/46] windbg: added '-windbg' option

2017-12-11 Thread Mihail Abakumov
This option starts windbg server. Signed-off-by: Mihail Abakumov Acked-by: Alistair Francis Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- qemu-options.hx |8 vl.c|8 2 files changed, 16 insertions(+) diff --git a/qemu-options.hx b/qe

[Qemu-devel] [PATCH v4 06/46] windbg: added WindbgState

2017-12-11 Thread Mihail Abakumov
Added definition of the WindbgState struct and its initialization. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 28 1 file changed, 28 insertions(+) diff --git a/windbgstub.c b/windbgstub.c inde

[Qemu-devel] [PATCH v4 01/46] windbg: added empty windbgstub files

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- Makefile.target |5 + include/exec/windbgstub-utils.h | 18 ++ include/exec/windbgstub.h | 17 + stubs/Makefile.objs |

[Qemu-devel] [PATCH v4 07/46] windbg: added chardev

2017-12-11 Thread Mihail Abakumov
Added chardev for listening to windbg. Target device is a parameter in the '-windbg' option. Signed-off-by: Mihail Abakumov Acked-by: Alistair Francis Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 30 ++ 1 file changed, 30 ins

[Qemu-devel] [PATCH v4 02/46] windbg: added windbg's KD header file

2017-12-11 Thread Mihail Abakumov
Header file from windbg's source code describing the main structures. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgkd.h | 873 +++ include/exec/windbgstub-utils.h |1 2 fil

[Qemu-devel] [PATCH v4 05/46] windbg: added helper features

2017-12-11 Thread Mihail Abakumov
Added some helper features for windbgstub. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h | 31 +++ include/exec/windbgstub.h |6 ++ 2 files changed, 37 insertions(+)

[Qemu-devel] [PATCH v4 09/46] windbg: handler of fs/gs register

2017-12-11 Thread Mihail Abakumov
Added handler of fs/gs register. It tries to find and check KPCR and version address. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |8 ++ target/i386/windbgstub.c| 49 +++

[Qemu-devel] [PATCH v4 10/46] windbg: structures for parsing data stream

2017-12-11 Thread Mihail Abakumov
Added structures for parsing data stream from windbg to packet. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h | 11 +++ windbgstub.c| 30 ++ 2 files c

[Qemu-devel] [PATCH v4 03/46] windbg: modified windbgkd.h

2017-12-11 Thread Mihail Abakumov
Added useful name arrays of some defines. Not used yet. Needs for the future. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgkd.h | 83 +++ 1 file changed, 83 insertions(+) diff

[Qemu-devel] [PATCH v4 13/46] windbg: handler of parsing context

2017-12-11 Thread Mihail Abakumov
Implemented handler of parsing context. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 36 ++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/windbgstub.c b/windbgstub.c index 8

[Qemu-devel] [PATCH v4 22/46] windbg: kernel's structures

2017-12-11 Thread Mihail Abakumov
Defined Windows kernel's structures (CPU_CONTEXT and CPU_KSPECIAL_REGISTERS) for i386 and x64_86. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 247 ++ 1 file changed, 2

[Qemu-devel] [PATCH v4 11/46] windbg: parsing data stream

2017-12-11 Thread Mihail Abakumov
Added function of parsing data stream from windbg to packet. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 111 +- 1 file changed, 110 insertions(+), 1 deletion(-) diff

[Qemu-devel] [PATCH v4 08/46] windbg: hook to wrmsr operation

2017-12-11 Thread Mihail Abakumov
Inserted hook to wrmsr operation. Windows Kernel put address on KPCR struct to fs/gs (x32/x64) register. Needs catch this moment and allow windbg server handle packets. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-u

[Qemu-devel] [PATCH v4 16/46] windbg: generate LoadSymbolsStateChange

2017-12-11 Thread Mihail Abakumov
Added function for generate LoadSymbolsStateChange packet. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |1 + target/i386/windbgstub.c| 16 2 files changed, 17 insertions(+) dif

[Qemu-devel] [PATCH v4 25/46] windbg: implemented windbg_read_context

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 96 ++ 1 file changed, 96 insertions(+) diff --git a/target/i386/windbgstub.c b/target/i386/windbgstub.c index f72d164bb5..

[Qemu-devel] [PATCH v4 12/46] windbg: send data and control packets

2017-12-11 Thread Mihail Abakumov
Added functions for send data and control packets to windbg. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 56 1 file changed, 56 insertions(+) diff --git a/windbgstub

[Qemu-devel] [PATCH v4 17/46] windbg: windbg_vm_stop

2017-12-11 Thread Mihail Abakumov
Added function for stop vm. Also, ExceptionStateChange data is generated and sent here. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/windbgstu

[Qemu-devel] [PATCH v4 21/46] windbg: implemented kd_api_read_virtual_memory and kd_api_write_virtual_memory

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 ++ windbgstub-utils.c | 47 +++ windbgstub.c|8 +++ 3 files changed, 57 insert

[Qemu-devel] [PATCH v4 28/46] windbg: implemented windbg_write_ks_regs

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 111 ++ 1 file changed, 111 insertions(+) diff --git a/target/i386/windbgstub.c b/target/i386/windbgstub.c index da7d1eae0c.

[Qemu-devel] [PATCH v4 23/46] windbg: implemented kd_api_get_context and kd_api_set_context

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 ++ target/i386/windbgstub.c| 39 +++ windbgstub.c|8 3 files changed, 49 inser

[Qemu-devel] [PATCH v4 19/46] windbg: implemented windbg_process_data_packet

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/windbgstub.c b/windbgstub.c index 07a1815b79..cd46649278 100755 --- a/windbgstub.c +++ b/wind

[Qemu-devel] [PATCH v4 14/46] windbg: init DBGKD_ANY_WAIT_STATE_CHANGE

2017-12-11 Thread Mihail Abakumov
Added function for init DBGKD_ANY_WAIT_STATE_CHANGE. It is a header of 'state change' packets. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |8 ++ target/i386/windbgstub.c| 49 +

[Qemu-devel] [PATCH v4 29/46] windbg: implemented windbg_set_sr

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/target/i386/windbgstub.c b/target/i386/windbgstub.c index 25a0ee8a66..2a09cec9d8 100

[Qemu-devel] [PATCH v4 24/46] windbg: implemented kd_api_read_control_space and kd_api_write_control_space

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 + target/i386/windbgstub.c| 89 +++ windbgstub.c|8 3 files changed, 99 insertions

[Qemu-devel] [PATCH v4 15/46] windbg: generate ExceptionStateChange

2017-12-11 Thread Mihail Abakumov
Added function for generate ExceptionStateChange packet. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 ++ target/i386/windbgstub.c| 21 - 2 files changed, 22 insertions(+),

[Qemu-devel] [PATCH v4 20/46] windbg: implemented windbg_process_manipulate_packet

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 ++ windbgstub-utils.c |8 windbgstub.c| 26 +- 3 files changed, 35 insertions(+), 1 d

[Qemu-devel] [PATCH v4 32/46] windbg: implemented windbg_hw_breakpoint_insert and windbg_hw_breakpoint_remove

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a/target/i386/windbgstub.c b/target/i386/windbgstub.c index 6e167a7473..

[Qemu-devel] [PATCH v4 18/46] windbg: implemented windbg_process_control_packet

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/windbgstub.c b/windbgstub.c index 6eb9517e24..07a1815b79 100755 --- a/windbgstub.c +++

[Qemu-devel] [PATCH v4 26/46] windbg: implemented windbg_write_context

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 216 ++ 1 file changed, 216 insertions(+) diff --git a/target/i386/windbgstub.c b/target/i386/windbgstub.c index de3ffd78b0.

[Qemu-devel] [PATCH v4 31/46] windbg: implemented windbg_set_dr7

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/target/i386/windbgstub.c b/target/i386/windbgstub.c index cae827df50..6e16

[Qemu-devel] [PATCH v4 34/46] windbg: debug exception subscribing

2017-12-11 Thread Mihail Abakumov
Added handler registration of gdb debug exception. Its exception also can be used for windbg. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- cpus.c | 19 ++- gdbstub.c |4 include/syse

[Qemu-devel] [PATCH v4 27/46] windbg: implemented windbg_read_ks_regs

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/target/i386/windbgstub.c b/target/i386/windbgstub.c index 6272a1341d..da7d1ea

Re: [Qemu-devel] [PATCH v18 10/10] virtio-balloon: don't report free pages when page poisoning is enabled

2017-12-11 Thread Michael S. Tsirkin
On Mon, Dec 11, 2017 at 02:38:45PM +0800, Wei Wang wrote: > On 12/01/2017 11:49 PM, Michael S. Tsirkin wrote: > > On Wed, Nov 29, 2017 at 09:55:26PM +0800, Wei Wang wrote: > > > The guest free pages should not be discarded by the live migration thread > > > when page poisoning is enabled with PAGE_

[Qemu-devel] [PATCH v4 30/46] windbg: implemented windbg_set_dr

2017-12-11 Thread Mihail Abakumov
Defined useful macros for breakpoints. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 50 +- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/target/i386/win

[Qemu-devel] [PATCH v4 36/46] windbg: implemented kd_api_read_io_space and kd_api_write_io_space

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 + windbgstub-utils.c | 62 +++ windbgstub.c|8 + 3 files changed, 72 insertion

  1   2   3   >