Am 25.09.2017 um 08:37 schrieb Peter Xu:
> We have object_get_objects_root() to keep user created objects, however
> no place for objects that will be used internally. Create such a
> container for internal objects.
>
> CC: Andreas Färber
> CC: Markus Armbruster
> CC: Paolo Bonzini
> Suggested
* Cornelia Huck [2017-09-08 12:02:38 +0200]:
> On Fri, 8 Sep 2017 11:41:00 +0800
> Dong Jia Shi wrote:
>
> > I think the difficult part is in the Qemu side. For either A or B, in
> > Qemu, we'd need to return a cc0 to indicate the channel program is
> > accepted successfully by the device, and
On 09/18/2017 05:59 PM, David Hildenbrand wrote:
> Let's move it into the machine, so we trigger the IRQ after setting
> ms->possible_cpus (which SCLP uses to construct the list of
> online CPUs).
>
> Signed-off-by: David Hildenbrand
Makes sense
Reviewed-by: Christian Borntraeger
> ---
> hw/s
On Mon, 09/25 14:37, Peter Xu wrote:
> So that internal iothread users can explicitly stop one iothread without
> destroying it.
>
> Since at it, fix iothread_stop() to allow it to be called multiple
> times. Before this patch we may call iothread_stop() more than once on
> single iothread, while
Hi,
> Mac OS X is built on top of Darwin. Darwin is completely open source
> and free. There are no copyright issues because it is released under
> the Apple Public Source License.
As far I know cocoa is not open source though.
So, can you actually build qemu on darwin?
And if so, it will pro
* Cornelia Huck [2017-09-08 11:59:50 +0200]:
> On Fri, 8 Sep 2017 11:21:57 +0200
> Halil Pasic wrote:
>
> > On 09/08/2017 05:41 AM, Dong Jia Shi wrote:
> > > Let' me summarize here, in case I misunderstand things. Now we have
> > > two ways to choose:
> > >
> > > A. Kernel: no change.
> > >
If hotplug memory during migration, the calculation of migration_dirty_pages
maybe not correct,
void migration_bitmap_extend(ram_addr_t old, ram_addr_t new)
{
...
migration_dirty_pages += new - old;
call_rcu(old_bitmap, migration_bitmap_free, rcu);
...
}
Thanks,
Zha
On 9/23/2017 12:33 PM, Manos Pitsidianakis wrote:
On Fri, Sep 22, 2017 at 01:31:58PM +0200, Pradeep Jagadeesh wrote:
On 9/18/2017 6:20 PM, Manos Pitsidianakis wrote:
On Thu, Sep 14, 2017 at 06:40:05AM -0400, Pradeep Jagadeesh wrote:
This patch factors out the duplicate throttle code that was s
With NOUSER=1 the container runs code as root, which may create
privileged files that will not be be accssible next time. Skip ccache
dir mount in this case.
Signed-off-by: Fam Zheng
---
tests/docker/Makefile.include | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests
On Fri, 22 Sep 2017 12:39:41 -0300
Philippe Mathieu-Daudé wrote:
> applied using ./scripts/clean-includes
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/acpi/ipmi-stub.c | 1 +
> hw/audio/fmopl.c| 1 -
> hw/cpu/core.c | 1 +
> hw/ppc/spapr_cp
* Marcel Apfelbaum (mar...@redhat.com) wrote:
> On 23/09/2017 11:23, Mark Cave-Ayland wrote:
> > On 22/09/17 23:18, Laszlo Ersek wrote:
> >
> > > On 09/22/17 14:18, Mark Cave-Ayland wrote:
> > > > Whilst the underlying PCI bridge implementation supports 32-bit PCI IO
> > > > accesses, unfortunatel
On Fri, 22 Sep 2017 12:39:45 -0300
Philippe Mathieu-Daudé wrote:
> exec: housekeeping (funny since 02d0e095031)
>
> applied using ./scripts/clean-includes
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> accel/tcg/translate-all.c | 1 -
> exec.c | 3 ---
>
On Mon, Sep 25, 2017 at 09:14:21AM +0200, Andreas Färber wrote:
> Am 25.09.2017 um 08:37 schrieb Peter Xu:
> > We have object_get_objects_root() to keep user created objects, however
> > no place for objects that will be used internally. Create such a
> > container for internal objects.
> >
> > C
Makes sense. I asked myself if there is code outside that does not zero out
2048-16k so
I looked into the kernel source and it looks like we always did the right thing
(and zeroed out the response buffer), so this should not uncover any bugs.
Reviewed-by: Christian Borntraeger
On 09/18/2017 05:
Feature "dtc" is explicitly required by test-mingw, but is not detected
by the run script since we switched to archive-source.sh in b7f404201e4.
Since it isn't available in the Fedora image which runs this test on
patchew, the way we get dtc is still from submodule.
archive-source.sh takes care of
and exit before uslessly trying to load it if the file does
not exists.
Issue dicovered by Coverity Scan.
Signed-off-by: Cédric Le Goater
---
hw/ppc/pnv.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index 47221158d415..7728eece2eec 100644
--- a/hw/ppc/pnv
On Mon, Sep 25, 2017 at 04:14:26PM +0800, Peter Xu wrote:
On Mon, Sep 25, 2017 at 09:14:21AM +0200, Andreas Färber wrote:
Am 25.09.2017 um 08:37 schrieb Peter Xu:
> We have object_get_objects_root() to keep user created objects, however
> no place for objects that will be used internally. Creat
Hi Philippe,
I have not seen patch went upstream..
On 09/04/2017 09:12 PM, Philippe Mathieu-Daudé wrote:
On 09/04/2017 04:43 AM, Seeteena Thoufeek wrote:
---Steps to Reproduce---
When passed a negative number to 'maxcpus' parameter, Qemu aborts
with a core dump.
Run the following command wi
On 25.09.2017 10:33, Cédric Le Goater wrote:
> and exit before uslessly trying to load it if the file does
s/uslessly/uselessly/
> not exists.
>
> Issue dicovered by Coverity Scan.
/dicovered/discovered/
> Signed-off-by: Cédric Le Goater
> ---
> hw/ppc/pnv.c | 4
> 1 file changed, 4 ins
On Mon, Sep 25, 2017 at 09:31:15AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > Mac OS X is built on top of Darwin. Darwin is completely open source
> > and free. There are no copyright issues because it is released under
> > the Apple Public Source License.
>
> As far I know cocoa is not open sour
On 25.09.2017 10:43, seeteena wrote:
> Hi Philippe,
>
> I have not seen patch went upstream..
You need to get the attention of a maintainer who could pick up the
patch, e.g. by putting them on CC:. See the MAINTAINERS file for who is
responsible for the various parts of QEMU. I've put Eduardo (Nu
On Mon, 25 Sep 2017 10:46:13 +0200
Thomas Huth wrote:
> On 25.09.2017 10:33, Cédric Le Goater wrote:
> > and exit before uslessly trying to load it if the file does
>
> s/uslessly/uselessly/
>
> > not exists.
> >
> > Issue dicovered by Coverity Scan.
>
> /dicovered/discovered/
>
Mention
On 09/25/2017 10:46 AM, Thomas Huth wrote:
> On 25.09.2017 10:33, Cédric Le Goater wrote:
>> and exit before uslessly trying to load it if the file does
>
> s/uslessly/uselessly/
>
>> not exists.
>>
>> Issue dicovered by Coverity Scan.
>
> /dicovered/discovered/
arg. Sorry about that.
>> Signe
On Fri, Sep 22, 2017 at 04:26:40PM -0400, Programmingkid wrote:
>
> > On Sep 22, 2017, at 9:18 AM, Daniel P. Berrange wrote:
> >
> > On Fri, Sep 22, 2017 at 08:44:05PM +0800, Fam Zheng wrote:
> >> On Fri, 09/22 08:10, Programmingkid wrote:
> >>> Could a Darwin test be added? Both x86 and PowerPC
and exit before uselessly trying to load it if the file does not
exists.
Issue discovered by Coverity Scan.
Signed-off-by: Cédric Le Goater
---
Changes since v1:
- fixed spelling
- improved OPAL naming by adding firmware
hw/ppc/pnv.c | 6 +-
1 file changed, 5 insertions(+), 1 deletio
On 09/25/2017 10:52 AM, Greg Kurz wrote:
> On Mon, 25 Sep 2017 10:46:13 +0200
> Thomas Huth wrote:
>
>> On 25.09.2017 10:33, Cédric Le Goater wrote:
>>> and exit before uslessly trying to load it if the file does
>>
>> s/uslessly/uselessly/
>>
>>> not exists.
>>>
>>> Issue dicovered by Coverity
Hi,
Am 25.09.2017 um 10:14 schrieb Peter Xu:
> On Mon, Sep 25, 2017 at 09:14:21AM +0200, Andreas Färber wrote:
>> Am 25.09.2017 um 08:37 schrieb Peter Xu:
>>> We have object_get_objects_root() to keep user created objects, however
>>> no place for objects that will be used internally. Create such
On Mon, Sep 25, 2017 at 09:14:21AM +0200, Andreas Färber wrote:
> Am 25.09.2017 um 08:37 schrieb Peter Xu:
> > We have object_get_objects_root() to keep user created objects, however
> > no place for objects that will be used internally. Create such a
> > container for internal objects.
> >
> > C
On 25.09.2017 10:58, Cédric Le Goater wrote:
> and exit before uselessly trying to load it if the file does not
> exists.
>
> Issue discovered by Coverity Scan.
>
> Signed-off-by: Cédric Le Goater
> ---
>
> Changes since v1:
>
> - fixed spelling
> - improved OPAL naming by adding firmware
On Fri, Sep 22, 2017 at 12:39:44PM -0300, Philippe Mathieu-Daudé wrote:
> applied using ./scripts/clean-includes
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/audio/fmopl.h | 1 -
> bsd-user/main.c | 1 -
> chardev/wctablet.c | 4
> hw/scsi/vhost-us
On 25/09/2017 05:09, Fam Zheng wrote:
> On Fri, 09/22 17:49, Paolo Bonzini wrote:
>> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
>> index 6865689..1522aab 100755
>> --- a/tests/docker/common.rc
>> +++ b/tests/docker/common.rc
>> @@ -36,3 +36,11 @@ build_qemu()
>> $QEMU_SRC/con
On 24/09/2017 23:02, Michael Tokarev wrote:
> 15.09.2017 12:06, Eduardo Otubo wrote:
>> QEMU fails when used with the following command line:
>>
>> ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374
>> qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion
>> `
On 18.09.2017 17:59, David Hildenbrand wrote:
> Not that it would matter in the near future, but it is actually 2048
> bytes, therefore 16384 possible bits.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/cpu_features.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
On Mon, Sep 25, 2017 at 11:11:37AM +0200, Paolo Bonzini wrote:
> On 24/09/2017 23:02, Michael Tokarev wrote:
> > 15.09.2017 12:06, Eduardo Otubo wrote:
> >> QEMU fails when used with the following command line:
> >>
> >> ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device
> >> i8
On Sat, Sep 23, 2017 at 07:33:34PM +0300, Michael Tokarev wrote:
> Remove trailing whitespace in qemu-options documentation, as it causes
> reproducibility issues depending on the echo implementation used by
> the Makefile.
>
> Reported-By: Vagrant Cascadian
> Signed-off-by: Michael Tokarev
> --
On Fri, Sep 22, 2017 at 05:43:53PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Without initialization to zero dirty_bitmap field may be not zero
> for a bitmap which should not be stored and
> qcow2_store_persistent_dirty_bitmaps will erroneously call
> store_bitmap for it which leads to SYGSEGV o
On 25/09/2017 11:26, Eduardo Otubo wrote:
> On Mon, Sep 25, 2017 at 11:11:37AM +0200, Paolo Bonzini wrote:
>> On 24/09/2017 23:02, Michael Tokarev wrote:
>>> 15.09.2017 12:06, Eduardo Otubo wrote:
QEMU fails when used with the following command line:
./ppc64-softmmu/qemu-system-ppc
13.09.2017 21:18, Max Reitz wrote:
When converting mirror's I/O to coroutines, we are going to need a point
where these coroutines are created. mirror_perform() is going to be
that point.
Signed-off-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/mirror.c | 53 +++
The CPU core abstraction belongs to the machine code. This also gets
rid of some code duplication.
Signed-off-by: Greg Kurz
---
hw/ppc/spapr_cpu_core.h is also included elsewhere in target/ppc/kvm.c
but this is already handled by the following cleanup patch:
https://patchwork.ozlabs.org/patch/8
On Mon, Sep 25, 2017 at 11:34:58AM +0300, Manos Pitsidianakis wrote:
> On Mon, Sep 25, 2017 at 04:14:26PM +0800, Peter Xu wrote:
> > On Mon, Sep 25, 2017 at 09:14:21AM +0200, Andreas Färber wrote:
> > > Am 25.09.2017 um 08:37 schrieb Peter Xu:
> > > > We have object_get_objects_root() to keep user
Public bug reported:
Hi,
I am using "drive-mirror" qmp block-job command to transfer VM disk image to
other path (different physical disk on host).
Unfortunately after shutting down and starting from new image, VM is unable to
boot and qrub enters rescue mode displaying following error:
```
erro
On Mon, Sep 25, 2017 at 02:37:28PM +0800, Peter Xu wrote:
> So that internal iothread users can explicitly stop one iothread without
> destroying it.
>
> Since at it, fix iothread_stop() to allow it to be called multiple
> times. Before this patch we may call iothread_stop() more than once on
> s
On Mon, Sep 25, 2017 at 02:37:29PM +0800, Peter Xu wrote:
> When gcontext is used with iothread, the context will be destroyed
> during iothread_stop(). That's not good since sometimes we would like
> to keep the resources until iothread is destroyed, but we may want to
> stop the thread before th
On Sat, Sep 23, 2017 at 02:14:09PM +0300, Manos Pitsidianakis wrote:
> BlockDriverState has a bdrv_co_drain() callback but no equivalent for
> the end of the drain. The throttle driver (block/throttle.c) needs a way
> to mark the end of the drain in order to toggle io_limits_disabled
> correctly, t
On Sat, Sep 23, 2017 at 02:14:10PM +0300, Manos Pitsidianakis wrote:
> Reviewed-by: Stefan Hajnoczi
> Reviewed-by: Fam Zheng
> Signed-off-by: Manos Pitsidianakis
> ---
> include/block/block_int.h | 4 ++--
> block/io.c| 4 ++--
> block/qed.c | 6 +++---
> 3 files c
On Fri, 22 Sep 2017 16:27:00 +0200
Halil Pasic wrote:
> One thing I would find very helpful is what do we expect to work and not
> work for which version. Kind of a matrix. For instance should vfio pci
> work for versions prior 2.11. I think in the not so distant past we
> changed how SIC works (
On 18.09.2017 17:59, David Hildenbrand wrote:
> Will be handy in the next patches.
>
> Signed-off-by: David Hildenbrand
> ---
> hw/s390x/s390-virtio-ccw.c | 2 +-
> target/s390x/cpu.h | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/s390x/s390-virtio-ccw.c b
On 09/25/2017 12:07 PM, Cornelia Huck wrote:
> On Fri, 22 Sep 2017 16:27:00 +0200
> Halil Pasic wrote:
>
>> One thing I would find very helpful is what do we expect to work and not
>> work for which version. Kind of a matrix. For instance should vfio pci
>> work for versions prior 2.11. I think
On 22/09/2017 12:16, Thomas Huth wrote:
Historically we've marked all devices as hotpluggable by default. However,
most devices are not hotpluggable, and you also need a HotplugHandler to
support these devices. So if the user tries to "device_add" or "device_del"
such a non-hotpluggable device du
On 18.09.2017 17:59, David Hildenbrand wrote:
> This will now also detect crashes under TCG. We can directly use
> cpu->env.psw.addr instead of kvm_run, as we do a
> cpu_synchronize_state().
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/helper.c | 28 ++--
>
I still have this patch on my queue as the last remaining z14 item.
Since I have already rebase it several time, its time for some
additional review.
Collin L. Walling (2):
linux-headers: Update linux headers for extended TOD-Clock
s390/kvm: Support for get/set of extended TOD-Clock for gues
From: "Collin L. Walling"
Conny: to be replaced with 4.14-rc*.
Adds KVM_S390_VM_TOD_EXT attribute for the extended TOD-Clock
attribute and kvm_s390_vm_tod_clock struct for TOD-Clock data.
Signed-off-by: Collin L. Walling
---
linux-headers/asm-s390/kvm.h | 6 ++
1 file changed, 6 insertion
From: "Collin L. Walling"
Provides an interface for getting and setting the guest's extended
TOD-Clock via a single ioctl to kvm. If the ioctl fails because it
is not support by kvm, then we fall back to the old style of
retrieving the clock via two ioctls.
If kvm fails to set a nonzero epoch in
On 18.09.2017 17:59, David Hildenbrand wrote:
> No need to pass kvm_run.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/kvm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
> index 14f864697d..da3f7e9895 100644
>
On 18.09.2017 18:00, David Hildenbrand wrote:
> Preparation for moving it out of kvm.c.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/kvm.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
> index 01c4125d21..d759edf1c8 100644
> --- a
ping
On Mon, Sep 11, 2017 at 6:59 PM, Marc-André Lureau
wrote:
> Recent linux kernels enable KASLR to randomize phys/virt memory
> addresses. This series aims to provide enough information in qemu
> dumps so that crash utility can work with randomized kernel too (it
> hasn't been tested on other
25.09.2017 12:26, Eduardo Otubo wrote:
> On Mon, Sep 25, 2017 at 11:11:37AM +0200, Paolo Bonzini wrote:
>> On 24/09/2017 23:02, Michael Tokarev wrote:
>>> 15.09.2017 12:06, Eduardo Otubo wrote:
QEMU fails when used with the following command line:
./ppc64-softmmu/qemu-system-ppc64
On 09/25/2017 09:31 AM, Dong Jia Shi wrote:
> * Cornelia Huck [2017-09-08 11:59:50 +0200]:
>
>> On Fri, 8 Sep 2017 11:21:57 +0200
>> Halil Pasic wrote:
>>
>>> On 09/08/2017 05:41 AM, Dong Jia Shi wrote:
Let' me summarize here, in case I misunderstand things. Now we have
two ways to c
When running with KVM PR, if a new HPT is allocated we need to inform
KVM about the HPT address and size. This is currently done by hacking
the value of SDR1 and pushing it to KVM in several places.
Also, migration breaks the guest since it is very unlikely the HPT has
the same address in source a
On Mon, 09/25 11:11, Paolo Bonzini wrote:
> On 25/09/2017 05:09, Fam Zheng wrote:
> > On Fri, 09/22 17:49, Paolo Bonzini wrote:
> >> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> >> index 6865689..1522aab 100755
> >> --- a/tests/docker/common.rc
> >> +++ b/tests/docker/common.rc
>
* Igor Mammedov (imamm...@redhat.com) wrote:
> On Thu, 24 Aug 2017 20:27:28 +0100
> "Dr. David Alan Gilbert (git)" wrote:
>
> > From: "Dr. David Alan Gilbert"
> >
> > Where two regions are created with a gap such that when aligned
> > to hugepage boundaries, the two regions overlap, merge them.
On 25/09/2017 12:54, Michael Tokarev wrote:
>> Yes, that's correct. I can revert this patch with the error
>> propagation patch as well, if you guys don't mind.
> Hmm. After reading the original discussion I concluded this patch
> is okay. I can remove it right now before the series has been
> app
From: "Dr. David Alan Gilbert"
Check the return value of pre_save state and fail vmstate_save_state
if the pre_save failed.
Signed-off-by: Dr. David Alan Gilbert
---
include/migration/vmstate.h | 4 ++--
migration/trace-events | 1 +
migration/vmstate.c | 12 ++--
3 file
From: "Dr. David Alan Gilbert"
Check the return values from vmstate_save_state for fields and also the
return values from 'put' for fields that use that.
Signed-off-by: Dr. David Alan Gilbert
---
migration/vmstate.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff -
From: "Dr. David Alan Gilbert"
At the moment the pre-save method on VMStateDescription returns void
which means there's no sane way of a pre_save routine failing. There
are quite a few pre_save's that abort or do other nasty things, and it
would be better if they could fail cleanly.
This patch
From: "Dr. David Alan Gilbert"
Modify the pre_save method on VMStateDescription to return an int
rather than void so that it potentially can fail.
Changed zillions of devices to make them return 0; the only
case I've made it return non-0 is hw/intc/s390_flic_kvm.c that already
had an error_repor
From: "Dr. David Alan Gilbert"
Route the errors from vsmtate_save_state back up through
vmstate_save and out to the normal device state path.
That's the normal error path done.
Signed-off-by: Dr. David Alan Gilbert
---
migration/savevm.c | 19 ++-
1 file changed, 14 insertions(
From: "Dr. David Alan Gilbert"
Route the errors from vmstate_subsection_save up through
vmstate_subsection_save (and back down, all rather recursive).
Signed-off-by: Dr. David Alan Gilbert
---
migration/vmstate.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff
From: "Dr. David Alan Gilbert"
vmstate_save is called in a few places, and vmstate_save_state is
called in lots of places.
Route error returns from the easier cases back up; there are lots
of more complex cases where their own error paths need fixing.
Signed-off-by: Dr. David Alan Gilbert
---
On Fri, Sep 22, 2017 at 10:01 AM, Laurent Vivier wrote:
> Le 22/09/2017 à 16:02, Carlo Marcelo Arenas Belón a écrit :
> > Signed-off-by: Carlo Marcelo Arenas Belón
> > ---
> > linux-user/mips64/sockbits.h | 1 +
> > linux-user/socket.h | 4 ++--
> > linux-user/sparc64/sockbits.h | 1
On Mon, 25 Sep 2017 12:12:49 +0200
Christian Borntraeger wrote:
> On 09/25/2017 12:07 PM, Cornelia Huck wrote:
> > On Fri, 22 Sep 2017 16:27:00 +0200
> > Halil Pasic wrote:
> >
> >> One thing I would find very helpful is what do we expect to work and not
> >> work for which version. Kind of a
On 09/25/2017 01:45 PM, Cornelia Huck wrote:
> On Mon, 25 Sep 2017 12:12:49 +0200
> Christian Borntraeger wrote:
>
>> On 09/25/2017 12:07 PM, Cornelia Huck wrote:
>>> On Fri, 22 Sep 2017 16:27:00 +0200
>>> Halil Pasic wrote:
>>>
One thing I would find very helpful is what do we expect to
On Fri, 22 Sep 2017 11:16:34 +0200
Thomas Huth wrote:
> Historically we've marked all devices as hotpluggable by default. However,
> most devices are not hotpluggable, and you also need a HotplugHandler to
> support these devices. So if the user tries to "device_add" or "device_del"
> such a non-
On Fri, Sep 22, 2017 at 10:04 AM, Laurent Vivier wrote:
> And you should move powerpc bits to linux-user/ppc/sockbits.
PPC is IMHO a special case, since it is kept together with the generic
header in the linux kernel (except for a similar exception to those few
values that differ) as you can se
On Fri, 2017-09-22 at 17:35 +0200, Marc-André Lureau wrote:
> Hi
>
> On Fri, Sep 22, 2017 at 2:33 PM, Amarnath Valluri
> wrote:
> >
> > TPM configuration options are backend implementation details and
> > shall not be
> > part of base TPMBackend object, and these shall not be accessed
> > direct
If hotplug memory during migration, the calculation of migration_dirty_pages
maybe incorrect, should fixed as below,
-void migration_bitmap_extend(ram_addr_t old, ram_addr_t new)
+void migration_bitmap_extend(RAMBlock *block, ram_addr_t old, ram_addr_t new)
{
/* called in qemu main thread, so
On Wed, Sep 20, Stefano Stabellini wrote:
> From: Olaf Hering
> g_malloc0_n is available since glib-2.24. To allow build with older glib
> versions use the generic g_new0, which is already used in many other
> places in the code.
> Fixes commit 3284fad728 ("xen-disk: add support for multi-page sh
QMP responses to certain commands can become quite long, which doesn't
only make reading them hard, but also means that the maximum line length
in patch emails can be exceeded. Allow tests to switch to QMP pretty
printing, which results in more, but shorter lines.
We also need to make sure to keep
This changes the commit block job to support operation in a graph where
there is more than a single active layer that references the top node.
This involves inserting the commit filter node not only on the path
between the given active node and the top node, but between the top node
and all of its
This is a step towards making the commit job flexible enough that it can
work with any kind of block graph. Currently, it requires that not only
the top and base node of the commit operation are specified, but also
the active layer of the backing file chain. Of course, the assumption
that a single
There is no good reason for bdrv_drop_intermediate() to know the active
layer above the subchain it is operating on - even more so, because
the assumption that there is a single active layer above it is not
generally true.
In order to prepare removal of the active parameter, use a BdrvChildRole
ca
We don't need to make any assumptions about the graph layout above the
top node of the commit operation any more. Remove the use of
bdrv_find_overlay() and related variables from the commit job code.
bdrv_drop_intermediate() doesn't use the 'active' parameter any more, so
we can just drop it.
The
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/191 | 152 +
tests/qemu-iotests/191.out | 827 +
tests/qemu-iotests/group | 1 +
3 files changed, 980 insertions(+)
create mode 100755 tests/qemu-iotests/191
create mode 100644 tests/qem
On Fri, Sep 22, 2017 at 9:13 AM, Laurent Vivier wrote:
> Le 22/09/2017 à 16:02, Carlo Marcelo Arenas Belón a écrit :
> > updated to match arch/parisc/include/uapi/asm/socket.h from linux 4.14
>
> I think it's not a good idea to change indentation, by adding spaces you
> hide the real changes that
On 18.09.2017 18:00, David Hildenbrand wrote:
> Preparation for TCG, for KVM is this is completely handled in the
> kernel.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/cpu.h | 2 ++
> target/s390x/sigp.c | 25 +
> 2 files changed, 27 insertions(+)
>
> dif
On 25.09.2017 14:47, Thomas Huth wrote:
> On 18.09.2017 18:00, David Hildenbrand wrote:
>> Preparation for TCG, for KVM is this is completely handled in the
>> kernel.
>>
>> Signed-off-by: David Hildenbrand
>> ---
>> target/s390x/cpu.h | 2 ++
>> target/s390x/sigp.c | 25 +++
On Mon, 25 Sep 2017 12:23:02 +0200
Christian Borntraeger wrote:
> From: "Collin L. Walling"
>
> Provides an interface for getting and setting the guest's extended
> TOD-Clock via a single ioctl to kvm. If the ioctl fails because it
> is not support by kvm, then we fall back to the old style of
> @@ -248,6 +249,19 @@ static void do_ext_interrupt(CPUS390XState *env)
> lowcore->ext_int_code = cpu_to_be16(EXT_CPU_TIMER);
> lowcore->cpu_addr = 0;
> env->pending_int &= ~INTERRUPT_EXT_CPU_TIMER;
> +} else if (env->pending_int & INTERRUPT_EMERGENCY_SIGNAL) {
> +
On 09/25/2017 06:29 AM, Dr. David Alan Gilbert (git) wrote:
> Modify the pre_save method on VMStateDescription to return an int
> rather than void so that it potentially can fail.
What does the int value signify? Why not a bool?
r~
Am 20.09.2017 um 13:45 hat Juan Quintela geschrieben:
> "Dr. David Alan Gilbert" wrote:
> > * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote:
> >> ping for 1-3
> >> Can we merge them?
> >
> > I see all of them have R-b's; so lets try and put them in the next
> > migration merge.
> >
* Richard Henderson (r...@twiddle.net) wrote:
> On 09/25/2017 06:29 AM, Dr. David Alan Gilbert (git) wrote:
> > Modify the pre_save method on VMStateDescription to return an int
> > rather than void so that it potentially can fail.
>
> What does the int value signify?
0 is success, anything else
On 09/25/2017 06:25 AM, Dr. David Alan Gilbert wrote:
>> Why not a bool?
>
> Consistency with pre_load, post_load, put and get methods
> that are already int.
Fair enough, thanks.
r~
On Mon, Sep 25, 2017 at 01:53:16PM +0200, Cornelia Huck wrote:
> On Fri, 22 Sep 2017 11:16:34 +0200
> Thomas Huth wrote:
>
> > Historically we've marked all devices as hotpluggable by default. However,
> > most devices are not hotpluggable, and you also need a HotplugHandler to
> > support these
The following changes since commit 460b6c8e581aa06b86f59eebd9e52edfe7adf417:
Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging
(2017-09-23 12:55:40 +0100)
are available in the git repository at:
git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2017-09-25
for you to
On Mon, 25 Sep 2017 11:47:33 +0200
Greg Kurz wrote:
> The CPU core abstraction belongs to the machine code. This also gets
> rid of some code duplication.
>
> Signed-off-by: Greg Kurz
> ---
>
> hw/ppc/spapr_cpu_core.h is also included elsewhere in target/ppc/kvm.c
> but this is already handled
From: Vladimir Sementsov-Ogievskiy
"NBDReply *reply" parameter of nbd_co_receive_reply is used only
to pass return value for nbd_co_request (reply.error). Remove it
and use function return value instead.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <201709201
If 'bs' is a complex expression, we were only casting the front half
rather than the full expression. Luckily, none of the callers were
passing bad arguments, but it's better to be robust up front.
Signed-off-by: Eric Blake
Message-Id: <20170918214649.17550-1-ebl...@redhat.com>
Reviewed-by: Phil
From: Vladimir Sementsov-Ogievskiy
It's incorrect to return success rc >= 0 if we skip qio_channel_writev_all()
call due to s->quit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20170920124507.18841-4-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
On 09/23/2017 07:04 AM, Vladimir Sementsov-Ogievskiy wrote:
> 19.09.2017 23:18, Eric Blake wrote:
>> We've previously fixed several places where we failed to account
>> for possible errors from bdrv_nb_sectors(). Fix another one by
>> making bdrv_dirty_bitmap_truncate() take the new size from the
From: Vladimir Sementsov-Ogievskiy
If we are woken up from while() loop in nbd_read_reply_entry
handles must be equal. If we are woken up from
nbd_recv_coroutines_wake_all s->quit must be true, so we do
not need checking handles equality.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by:
1 - 100 of 312 matches
Mail list logo
