[Qemu-devel] [PATCH v9 03/13] scripts: Add archive-source.sh

2017-09-19 Thread Fam Zheng
Signed-off-by: Fam Zheng --- scripts/archive-source.sh | 46 ++ 1 file changed, 46 insertions(+) create mode 100755 scripts/archive-source.sh diff --git a/scripts/archive-source.sh b/scripts/archive-source.sh new file mode 100755 index 00..e15

[Qemu-devel] [PATCH v9 01/13] gitignore: Ignore vm test images

2017-09-19 Thread Fam Zheng
Signed-off-by: Fam Zheng --- .gitignore | 1 + tests/.gitignore | 1 + 2 files changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index cf65316863..40acfcb9e2 100644 --- a/.gitignore +++ b/.gitignore @@ -52,6 +52,7 @@ /vscclient /vhost-user-scsi /fsdev/virtfs-proxy-helper +*.

[Qemu-devel] [PATCH v9 00/13] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)

2017-09-19 Thread Fam Zheng
v9: Don't use 'set -e' in archive-source.sh. [Eric] Add tests/keys/README. [Eric] Fix direct invocation of ./netbsd etc. [Alex] Add a note about test image well-known ssh key. [Eric] v8: Fix typo in code "od" => "os". QEMU to listen on 127.0.0.1 to be more secure. Update README

[Qemu-devel] [PATCH v9 02/13] qemu.py: Add "wait()" method

2017-09-19 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Reviewed-by: Alex Bennée --- scripts/qemu.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/scripts/qemu.py b/scripts/qemu.py index 5e02dd8e78..2b5c2accb5 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -215,6 +215,13 @@ cl

[Qemu-devel] [PATCH v9 08/13] tests: Add NetBSD image

2017-09-19 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng Reviewed-by: Kamil Rytarowski --- tests/vm/netbsd | 42 ++ 1 file changed, 42 insertions(+) create mode 100755 tests/vm/netbsd diff --git a/tes

[Qemu-devel] [PATCH v9 13/13] docker: Use archive-source.py

2017-09-19 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Alex Bennée --- tests/docker/Makefile.include | 15 ++- tests/docker/run | 8 +--- 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index aaab1a4208..7

[Qemu-devel] [PATCH v9 06/13] tests: Add ubuntu.i386 image

2017-09-19 Thread Fam Zheng
This adds a 32bit guest. The official LTS cloud image is downloaded and initialized with cloud-init. Signed-off-by: Fam Zheng --- tests/vm/ubuntu.i386 | 88 1 file changed, 88 insertions(+) create mode 100755 tests/vm/ubuntu.i386 diff --git

[Qemu-devel] [PATCH v9 04/13] tests: Add a test key pair

2017-09-19 Thread Fam Zheng
This will be used by setup test user ssh. Signed-off-by: Fam Zheng --- tests/keys/README | 6 ++ tests/keys/id_rsa | 27 +++ tests/keys/id_rsa.pub | 1 + 3 files changed, 34 insertions(+) create mode 100644 tests/keys/README create mode 100644 tests/keys/i

[Qemu-devel] [PATCH v9 05/13] tests: Add vm test lib

2017-09-19 Thread Fam Zheng
This is the common code to implement a "VM test" to 1) Download and initialize a pre-defined VM that has necessary dependencies to build QEMU and SSH access. 2) Archive $SRC_PATH to a .tar file. 3) Boot the VM, and pass the source tar file to the guest. 4) SSH into the VM, untar the s

[Qemu-devel] [PATCH v9 09/13] tests: Add OpenBSD image

2017-09-19 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng --- tests/vm/openbsd | 43 +++ 1 file changed, 43 insertions(+) create mode 100755 tests/vm/openbsd diff --git a/tests/vm/openbsd b/tests/vm/ope

Re: [Qemu-devel] [PATCH] block/throttle-groups.c: allocate RestartData on the heap

2017-09-19 Thread Kevin Wolf
Am 18.09.2017 um 22:25 hat Manos Pitsidianakis geschrieben: > RestartData is the opaque data of the throttle_group_restart_queue_entry > coroutine. By being stack allocated, it isn't available anymore if > aio_co_enter schedules the coroutine with a bottom halve and runs after > throttle_group_rest

[Qemu-devel] [PATCH v9 11/13] MAINTAINERS: Add tests/vm entry

2017-09-19 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4bd1797330..e9be7faff7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1890,6 +1890,7 @@ S: Maintained F: .travis.yml F: .shippable.yml F: t

[Qemu-devel] [PATCH v9 07/13] tests: Add FreeBSD image

2017-09-19 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng --- tests/vm/freebsd | 42 ++ 1 file changed, 42 insertions(+) create mode 100755 tests/vm/freebsd diff --git a/tests/vm/freebsd b/tests/vm/free

[Qemu-devel] [PATCH v9 10/13] Makefile: Add rules to run vm tests

2017-09-19 Thread Fam Zheng
Reviewed-by: Alex Bennée Tested-by: Alex Bennée Signed-off-by: Fam Zheng --- Makefile | 2 ++ configure | 2 +- tests/vm/Makefile.include | 42 ++ 3 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 test

[Qemu-devel] [PATCH v9 12/13] tests: Add README for vm tests

2017-09-19 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/vm/README | 89 + 1 file changed, 89 insertions(+) create mode 100644 tests/vm/README diff --git a/tests/vm/README b/tests/vm/README new file mode 100644 index 00..ae53dce6ee --- /dev/null +++ b/t

Re: [Qemu-devel] [PATCH qemu v3 01/13] memory: Postpone flatview and dispatch tree building till all devices are added

2017-09-19 Thread Paolo Bonzini
On 19/09/2017 08:57, Alexey Kardashevskiy wrote: >>> 3) you can consult the list (or hash table :)) of live FlatViews (which >>> means you keep it live after memory_region_transaction_commit ends, and >>> only clear it on the next call), and reuse an existing FlatView. Note >>> that the number of

[Qemu-devel] [Bug 1718118] [NEW] qemu crashes with hw/ppc/spapr_drc.c:417:spapr_drc_detach: assertion failed: (drc->dev)

2017-09-19 Thread R.Nageswara Sastry
Public bug reported: Qemu crashes with error "hw/ppc/spapr_drc.c:417:spapr_drc_detach: assertion failed: (drc->dev)" when memory hotplug and hotunplug was done continuously. Steps to re-produce: 1. git clone (today's i.e 19th Sept) 2. Bring up ppc64le guest with memory hotplug capabilities ( I us

Re: [Qemu-devel] [PATCH qemu v3 01/13] memory: Postpone flatview and dispatch tree building till all devices are added

2017-09-19 Thread Paolo Bonzini
On 19/09/2017 08:57, Alexey Kardashevskiy wrote: >>> 2) also, after patch 2 you know that the address space has no listeners >>> here, so the begin/commit isn't really needed. Instead you can use the >>> open-coded loop to directly generate the FlatView. This avoids touching >>> _all_ address spa

Re: [Qemu-devel] [PATCH] virtio-serial: add enable_backend callback

2017-09-19 Thread Paolo Bonzini
On 18/09/2017 11:37, Pavel Butsykin wrote: >>> >> >> To understand the patch better this doesn't fix _all_ stopped states, >> only migration, right? That said it's a valid bugfix even independent >> of the effects for stopped runstate. > Yes, the bug only appears on the migration. Actually, to pro

[Qemu-devel] [PATCH v2] s390x/cpu: expose the guest crash information

2017-09-19 Thread Christian Borntraeger
From: Jing Liu This patch is the s390 implementation of guest crash information, similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM property") and the related commits. We will detect several crash reasons, with the "disabled wait" being the most important one, since this is used b

[Qemu-devel] [RFC v4 00/16] VIRTIO-IOMMU device

2017-09-19 Thread Eric Auger
This series implements the virtio-iommu device. This v4 is an upgrade to v0.4 spec [1] and applies on QEMU v2.10.0. - probe request support although no reserved region is returned at the moment - unmap semantics less strict, as specified in v0.4 - device registration, attach/detach revisited - s

[Qemu-devel] [RFC v4 01/16] update-linux-headers: import virtio_iommu.h

2017-09-19 Thread Eric Auger
Update the script to update the virtio_iommu.h header. Signed-off-by: Eric Auger --- scripts/update-linux-headers.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh index 2f906c4..03f6712 100755 --- a/scripts/update-linux-h

[Qemu-devel] [RFC v4 04/16] virtio-iommu: Decode the command payload

2017-09-19 Thread Eric Auger
This patch adds the command payload decoding and introduces the functions that will do the actual command handling. Those functions are not yet implemented. Signed-off-by: Eric Auger --- v3 -> v4: - no flags field anymore in struct virtio_iommu_req_unmap - test reserved on attach/detach, change

[Qemu-devel] [RFC v4 05/16] virtio-iommu: Add the iommu regions

2017-09-19 Thread Eric Auger
This patch initializes the iommu memory regions so that PCIe end point transactions get translated. The translation function is not yet implemented at that stage. Signed-off-by: Eric Auger --- v3 -> v4: - add trace_virtio_iommu_init_iommu_mr v2 -> v3: - use IOMMUMemoryRegion - iommu mr name bui

[Qemu-devel] [RFC v4 07/16] virtio-iommu: Implement attach/detach command

2017-09-19 Thread Eric Auger
This patch implements the device attach/detach to an address space. Signed-off-by: Eric Auger --- hw/virtio/virtio-iommu.c | 38 -- 1 file changed, 32 insertions(+), 6 deletions(-) diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c index 41a4bbc

[Qemu-devel] [RFC v4 03/16] virtio-iommu: add skeleton

2017-09-19 Thread Eric Auger
This patchs adds the skeleton for the virtio-iommu device. Signed-off-by: Eric Auger --- v3 -> v4: - use page_size_mask instead of page_sizes - added set_features() - added some traces (reset, set_status, set_features) - empty virtio_iommu_set_config() as the driver MUST NOT write to device c

[Qemu-devel] [RFC v4 02/16] linux-headers: Update for virtio-iommu

2017-09-19 Thread Eric Auger
This is a partial linux header update against Jean-Philippe's branch: git://linux-arm.org/linux-jpb.git virtio-iommu/v0.4 (unstable) Signed-off-by: Eric Auger --- v3- >v3: - upgrade the API from v0.1 to v0.4 --- include/standard-headers/linux/virtio_ids.h | 1 + include/standard-headers/li

[Qemu-devel] [RFC v4 06/16] virtio-iommu: Register attached devices

2017-09-19 Thread Eric Auger
This patch introduce address space and device internal datatypes. Both are stored in RB trees. The address space owns a list of devices attached to it. It is assumed the devid corresponds to the PCI BDF. Signed-off-by: Eric Auger --- v3 -> v4: - new separate patch --- hw/virtio/trace-events

[Qemu-devel] [RFC v4 08/16] virtio-iommu: Implement map/unmap

2017-09-19 Thread Eric Auger
This patch implements virtio_iommu_map/unmap. Signed-off-by: Eric Auger --- v3 -> v4: - implement unmap semantics as specified in v0.4 --- hw/virtio/trace-events | 3 ++ hw/virtio/virtio-iommu.c | 91 ++-- 2 files changed, 92 insertions(+), 2 dele

[Qemu-devel] [RFC v4 10/16] virtio-iommu: Implement probe request

2017-09-19 Thread Eric Auger
This patch implements the PROBE request. At the moment, no reserved regions are returned. At the moment reserved regions are stored per device. Signed-off-by: Eric Auger --- Waiting for clarifications on v0.4 spec --- hw/virtio/trace-events | 2 + hw/virtio/virtio-iommu.c | 173 ++

[Qemu-devel] [RFC v4 11/16] hw/arm/virt: Add 2.11 machine type

2017-09-19 Thread Eric Auger
The new machine type allows virtio-iommu instantiation. Signed-off-by: Eric Auger --- --- hw/arm/virt.c | 23 +-- include/hw/arm/virt.h | 1 + 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index cfd834d..9737a5f 100644

[Qemu-devel] [RFC v4 09/16] virtio-iommu: Implement translate

2017-09-19 Thread Eric Auger
This patch implements the translate callback Signed-off-by: Eric Auger --- hw/virtio/trace-events | 1 + hw/virtio/virtio-iommu.c | 39 +-- 2 files changed, 38 insertions(+), 2 deletions(-) diff --git a/hw/virtio/trace-events b/hw/virtio/trace-events index

[Qemu-devel] [RFC v4 16/16] hw/vfio/common: Do not print error when viommu translates into an mmio region

2017-09-19 Thread Eric Auger
On ARM, the MSI doorbell is translated by the virtual IOMMU. As such address_space_translate() returns the MSI controller MMIO region and we get an "iommu map to non memory area" message. Let's remove this latter. Signed-off-by: Eric Auger --- hw/vfio/common.c | 2 -- 1 file changed, 2 deletions

[Qemu-devel] [RFC v4 13/16] memory.h: Add set_page_size_mask IOMMUMemoryRegion callback

2017-09-19 Thread Eric Auger
This callback allows to inform the IOMMU memory region about restrictions on the supported page sizes. Signed-off-by: Eric Auger --- include/exec/memory.h | 4 1 file changed, 4 insertions(+) diff --git a/include/exec/memory.h b/include/exec/memory.h index 1dcd312..0c91dca 100644 --- a/inc

[Qemu-devel] [RFC v4 14/16] hw/vfio/common: Set the IOMMUMemoryRegion supported page sizes

2017-09-19 Thread Eric Auger
We store the page_size_mask in the container and on vfio_listener_region_add(), the information is conveyed to the IOMMUMemoryRegion. Signed-off-by: Eric Auger --- hw/vfio/common.c | 5 + include/hw/vfio/vfio-common.h | 1 + 2 files changed, 6 insertions(+) diff --git a/hw/vfio

[Qemu-devel] [RFC v4 12/16] hw/arm/virt: Add virtio-iommu to the virt board

2017-09-19 Thread Eric Auger
The specific virtio-mmio node is inconditionally added on machine init while the binding between this latter and the PCIe host bridge is done on machine init done notifier, only if -device virtio-iommu-device was added to the qemu command line. Signed-off-by: Eric Auger --- --- hw/arm/virt.c

[Qemu-devel] [RFC v4 15/16] virtio-iommu: Implement set_page_size_mask

2017-09-19 Thread Eric Auger
We implement the set_page_size_mask callback to allow the virtio-iommu to be aware of any restrictions on the page size mask due to an underlying HW IOMMU. Signed-off-by: Eric Auger --- hw/virtio/trace-events | 1 + hw/virtio/virtio-iommu.c | 16 2 files changed, 17 insertion

Re: [Qemu-devel] [PATCH qemu v3 01/13] memory: Postpone flatview and dispatch tree building till all devices are added

2017-09-19 Thread Paolo Bonzini
On 19/09/2017 09:57, Alexey Kardashevskiy wrote: >> We can also resolve "fake" aliases, obtained through a region with only >> one subregion. > I just do this now (will post soon): > > > empty_view = generate_memory_topology(NULL); > [...] > > new_view = generate_memory_topology(physmr); > > if

Re: [Qemu-devel] [virtio-dev] Re: [PATCH REPOST v19 1/2] virtio-crypto: Add virtio crypto device specification

2017-09-19 Thread Zeng, Xin
on September 19, 2017 12:33 AM Halil Pasic Wrote: < > < > >> Destroy does not need to specify queue_id. That means session_id's < aren't < > < > >> queue scoped from namespace perspective. The question remains what < is < > < > >> queue_id good for, and whether a session type op request should be <

Re: [Qemu-devel] [PATCH qemu v3 01/13] memory: Postpone flatview and dispatch tree building till all devices are added

2017-09-19 Thread Alexey Kardashevskiy
On 19/09/17 17:40, Paolo Bonzini wrote: > On 19/09/2017 08:57, Alexey Kardashevskiy wrote: 3) you can consult the list (or hash table :)) of live FlatViews (which means you keep it live after memory_region_transaction_commit ends, and only clear it on the next call), and reuse an exi

Re: [Qemu-devel] [PATCH] block: Clean up some bad code in the vvfat driver

2017-09-19 Thread Kevin Wolf
Am 13.09.2017 um 12:21 hat Thomas Huth geschrieben: > Remove the unnecessary home-grown redefinition of the assert() macro here, > and remove the unusable debug code at the end of the checkpoint() function. > The code there uses assert() with side-effects (assignment to the "mapping" > variable), w

Re: [Qemu-devel] [PATCH 17/18] qemu-io: Add background write

2017-09-19 Thread Fam Zheng
On Mon, 09/18 19:53, Max Reitz wrote: > On 2017-09-18 08:46, Fam Zheng wrote: > > On Wed, 09/13 20:19, Max Reitz wrote: > >> Add a new parameter -B to qemu-io's write command. When used, qemu-io > >> will not wait for the result of the operation and instead execute it in > >> the background. > >

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Clean up some bad code in the vvfat driver

2017-09-19 Thread Paolo Bonzini
On 13/09/2017 21:08, John Snow wrote: > > > On 09/13/2017 06:21 AM, Thomas Huth wrote: >> Remove the unnecessary home-grown redefinition of the assert() macro here, >> and remove the unusable debug code at the end of the checkpoint() function. >> The code there uses assert() with side-effects (as

Re: [Qemu-devel] [PATCH 18/18] iotests: Add test for active mirroring

2017-09-19 Thread Fam Zheng
On Mon, 09/18 18:53, Max Reitz wrote: > >> + > >> +if sync_source_and_target: > >> +# If source and target should be in sync after the mirror, > >> +# we have to flush before completion > > > > Not sure I understand this requirements, does it apply to libvirt and us

Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure

2017-09-19 Thread Pradeep Jagadeesh
On 9/18/2017 6:25 PM, Manos Pitsidianakis wrote: On Thu, Sep 14, 2017 at 06:40:06AM -0400, Pradeep Jagadeesh wrote: This patch factors out code to use the ThrottleLimits strurcture. Signed-off-by: Pradeep Jagadeesh Reviewed-by: Greg Kurz Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia R

[Qemu-devel] Dead code in cpu-models.h (was: block: Clean up some bad code in the vvfat driver)

2017-09-19 Thread Thomas Huth
On 19.09.2017 10:06, Paolo Bonzini wrote: > On 13/09/2017 21:08, John Snow wrote: [...] >> Farewell, bitrot code. >> >> Reviewed-by: John Snow >> >> Out of curiosity, I wonder ... >> >> jhuston@probe (foobar) ~/s/qemu> git grep '#if 0' | wc -l >> 320 > > $ git grep -c '#if 0' | sort -k2 --field-s

[Qemu-devel] [PATCH v3] linux-user: syscall: Add SO_LINGER for setsockopt

2017-09-19 Thread Carlo Marcelo Arenas Belón
Original implementation from Chen Gang; code moved around as per v2 Signed-off-by: Chen Gang Signed-off-by: Carlo Marcelo Arenas Belón --- linux-user/syscall.c | 16 linux-user/syscall_defs.h | 5 + 2 files changed, 21 insertions(+) diff --git a/linux-user/syscall.c

Re: [Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

2017-09-19 Thread Michael Olbrich
On Mon, Sep 18, 2017 at 02:28:26PM -0700, Alistair Francis wrote: > On Sat, Sep 16, 2017 at 3:35 AM, Michael Olbrich > wrote: > > The current code checks if the next block exceeds the size of the card. > > This generates an error while reading the last block of the card. > > Do the out-of-bounds c

Re: [Qemu-devel] [PATCH 2/3] migration: Cancel migration at exit

2017-09-19 Thread Peter Xu
On Mon, Sep 18, 2017 at 11:00:15AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Fri, Sep 15, 2017 at 10:22:43AM +0100, Dr. David Alan Gilbert wrote: > > > * Fam Zheng (f...@redhat.com) wrote: > > > > On Fri, 09/15 09:42, Dr. David Alan Gilbert wrote: > > > > >

Re: [Qemu-devel] [PATCH v2 1/4] s390x/css: introduce css data stream

2017-09-19 Thread Cornelia Huck
On Tue, 19 Sep 2017 10:21:42 +0800 Dong Jia Shi wrote: > * Halil Pasic [2017-09-13 13:50:26 +0200]: > > [...] > > > diff --git a/include/hw/s390x/css.h b/include/hw/s390x/css.h > > index 0653d3c9be..79acaf99b7 100644 > > --- a/include/hw/s390x/css.h > > +++ b/include/hw/s390x/css.h > > @@ -75,

[Qemu-devel] [Bug 1718118] Re: qemu crashes with hw/ppc/spapr_drc.c:417:spapr_drc_detach: assertion failed: (drc->dev)

2017-09-19 Thread R.Nageswara Sastry
(gdb) bt #0 0x3fffb24beff0 in raise () at /lib64/libc.so.6 #1 0x3fffb24c136c in abort () at /lib64/libc.so.6 #2 0x3fffb2bcaa04 in g_assertion_message () at /lib64/libglib-2.0.so.0 #3 0x3fffb2bcab0c in g_assertion_message_expr () at /lib64/libglib-2.0.so.0 #4 0x101b85a0

[Qemu-devel] [RFC PATCH] qdev: Mark devices as non-hotpluggable by default

2017-09-19 Thread Thomas Huth
Historically we've marked all devices as hotpluggable by default. However, most devices are not hotpluggable, and you also need a HotplugHandler to support these devices. So if the user tries to "device_add" or "device_del" such a non-hotpluggable device during runtime, either nothing really usable

Re: [Qemu-devel] [Qemu devel v10 PATCH 4/5] msf2: Add Smartfusion2 SoC

2017-09-19 Thread sundeep subbaraya
Hi Philippe and Peter, On Tue, Sep 19, 2017 at 3:34 AM, Philippe Mathieu-Daudé wrote: > On 09/18/2017 04:23 PM, Subbaraya Sundeep wrote: > >> Smartfusion2 SoC has hardened Microcontroller subsystem >> and flash based FPGA fabric. This patch adds support for >> Microcontroller subsystem in the So

[Qemu-devel] [PATCH] trivial: Add missing "-m" parameter in docs/memory-hotplug.txt

2017-09-19 Thread Thomas Huth
The example obviously lacks the "-m" parameter. Signed-off-by: Thomas Huth --- docs/memory-hotplug.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/memory-hotplug.txt b/docs/memory-hotplug.txt index 56bdd0a..d96397c 100644 --- a/docs/memory-hotplug.txt +++ b/docs/memo

Re: [Qemu-devel] [RFC PATCH] vl.c: add is_system_on_chip flag to force board default cpu

2017-09-19 Thread Peter Maydell
On 18 September 2017 at 22:57, Philippe Mathieu-Daudé wrote: > add a property to restrict the CPU for SoCs once on machine creation and avoid > duplicate code in each board. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Based-on: 1505318697-77161-6-git-send-email-imamm...@redhat.com > > incl

Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Extend PAR format determination

2017-09-19 Thread Peter Maydell
On 19 September 2017 at 05:43, Edgar E. Iglesias wrote: > On Mon, Sep 18, 2017 at 04:50:23PM +0100, Peter Maydell wrote: >> I'm currently running into a similar issue with M profile, >> where at the moment we stuff the information about what >> kind of fault the MPU generates into a v7PMSA format

Re: [Qemu-devel] [PATCH v2 3/4] virtio-ccw: use ccw data stream

2017-09-19 Thread Cornelia Huck
On Tue, 19 Sep 2017 11:37:30 +0800 Dong Jia Shi wrote: > * Halil Pasic [2017-09-13 13:50:28 +0200]: > > > Replace direct access which implicitly assumes no IDA > > or MIDA with the new ccw data stream interface which should > > cope with these transparently in the future. > > > > Signed-off-by

Re: [Qemu-devel] [PATCH v2 1/4] s390x/css: introduce css data stream

2017-09-19 Thread Pierre Morel
On 13/09/2017 13:50, Halil Pasic wrote: This is a preparation for introducing handling for indirect data addressing and modified indirect data addressing (CCW). Here we introduce an interface which should make the addressing scheme transparent for the client code. Here we implement only the basic

Re: [Qemu-devel] [Qemu-block] [PATCH] nbd-client: Use correct macro parenthesization

2017-09-19 Thread Stefan Hajnoczi
On Mon, Sep 18, 2017 at 04:46:49PM -0500, Eric Blake wrote: > If 'bs' is a complex expression, we were only casting the front half > rather than the full expression. Luckily, none of the callers were > passing bad arguments, but it's better to be robust up front. > > Signed-off-by: Eric Blake >

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-19 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Mon, Sep 18, 2017 at 11:40:40AM +0100, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > On Fri, Sep 15, 2017 at 04:17:07PM +0100, Dr. David Alan Gilbert wrote: > > > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > > > On

Re: [Qemu-devel] [PATCH v8 05/20] dirty-bitmap: Avoid size query failure during truncate

2017-09-19 Thread Fam Zheng
On Mon, 09/18 13:58, Eric Blake wrote: > We've previously fixed several places where we failed to account > for possible errors from bdrv_nb_sectors(). Fix another one by > making bdrv_dirty_bitmap_truncate() take the new size from the > caller instead of querying itself; then adjust the sole call

Re: [Qemu-devel] What is the best commit for record-replay?

2017-09-19 Thread Pavel Dovgalyuk
> From: Aleksandr Bezzubikov [mailto:zuban...@gmail.com] > 2017-09-18 15:02 GMT+03:00 Aleksandr Bezzubikov : > > 2017-05-02 15:42 GMT+03:00 Igor R : > >> I'm trying to use the deterministic record/replay feature, and I would > >> like to know which commit I should take to get it work. > >>>

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-19 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Mon, Sep 18, 2017 at 06:09:29PM +0200, Marc-André Lureau wrote: > > On Mon, Sep 18, 2017 at 1:26 PM, Dr. David Alan Gilbert > > wrote: > > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > >> Hi > > >> > > >> On Mon, Sep 18, 2017 at 12:55 PM,

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-19 Thread Peter Xu
On Tue, Sep 19, 2017 at 10:13:52AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Mon, Sep 18, 2017 at 11:40:40AM +0100, Dr. David Alan Gilbert wrote: > > > * Peter Xu (pet...@redhat.com) wrote: > > > > On Fri, Sep 15, 2017 at 04:17:07PM +0100, Dr. David Alan Gi

Re: [Qemu-devel] Disk Image Read Location

2017-09-19 Thread Stefan Hajnoczi
On Mon, Sep 18, 2017 at 06:47:38PM +, Derrick McKee wrote: > I am trying to figure out if a particular disk operation is reading from > the same location in an image file. The following trace event is fired when a BlockBackend (a drive) is read: # block/block-backend.c blk_co_preadv(void

Re: [Qemu-devel] [PATCH v2 3/7] block/nbd-client: refactor reading reply

2017-09-19 Thread Vladimir Sementsov-Ogievskiy
18.09.2017 18:43, Paolo Bonzini wrote: On 18/09/2017 15:59, Vladimir Sementsov-Ogievskiy wrote: Read the whole reply in one place - in nbd_read_reply_entry. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd-client.h | 1 + block/nbd-client.c | 42 ---

Re: [Qemu-devel] What is the best commit for record-replay?

2017-09-19 Thread Alex Bennée
Pavel Dovgalyuk writes: >> From: Aleksandr Bezzubikov [mailto:zuban...@gmail.com] >> 2017-09-18 15:02 GMT+03:00 Aleksandr Bezzubikov : >> > 2017-05-02 15:42 GMT+03:00 Igor R : >> >> I'm trying to use the deterministic record/replay feature, and I would >> >> like to know which commit I s

[Qemu-devel] [Bug 1715700] Re: Windows 7 guest won't boot on qemu 2.10 (works on 2.9)

2017-09-19 Thread Dr. David Alan Gilbert
Added Imammedo to this lp. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1715700 Title: Windows 7 guest won't boot on qemu 2.10 (works on 2.9) Status in QEMU: New Bug description: Qemu versio

Re: [Qemu-devel] [PATCH v2 6/7] block/nbd-client: early fail nbd_read_reply_entry if s->quit is set

2017-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2017 01:27, Eric Blake wrote: On 09/18/2017 08:59 AM, Vladimir Sementsov-Ogievskiy wrote: Do not continue any operation if s->quit is set in parallel. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd-client.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff

Re: [Qemu-devel] [Qemu-block] [PATCH 15/18] block/mirror: Add active mirroring

2017-09-19 Thread Stefan Hajnoczi
On Mon, Sep 18, 2017 at 06:26:51PM +0200, Max Reitz wrote: > On 2017-09-18 12:06, Stefan Hajnoczi wrote: > > On Sat, Sep 16, 2017 at 03:58:01PM +0200, Max Reitz wrote: > >> On 2017-09-14 17:57, Stefan Hajnoczi wrote: > >>> On Wed, Sep 13, 2017 at 08:19:07PM +0200, Max Reitz wrote: > This patch

[Qemu-devel] [PATCH] nvme: fix cmbuf leak on exit

2017-09-19 Thread Stefan Hajnoczi
Cc: Keith Busch Signed-off-by: Stefan Hajnoczi --- hw/block/nvme.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 9aa32692a3..513ec7065d 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -1057,6 +1057,7 @@ static void nvme_exit(PCIDevice *pci_dev)

Re: [Qemu-devel] [PATCH] msf2: drop cpu_model to directly use cpu type

2017-09-19 Thread Philippe Mathieu-Daudé
On 09/18/2017 11:08 PM, Fam Zheng wrote: On Mon, 09/18 19:11, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- after Igor comment: http://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg04709.html Fam: I'm trying your patchew "apply over series" feature on these 2 se

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

2017-09-19 Thread Cornelia Huck
On Tue, 19 Sep 2017 13:50:05 +0800 Dong Jia Shi wrote: > * Halil Pasic [2017-09-13 13:50:29 +0200]: > > > Let's add indirect data addressing support for our virtual channel > > subsystem. This implementation does no bother with any kind of > > prefetching. We simply step trough the IDAL on dema

Re: [Qemu-devel] [RFC 0/6] initial plugin support

2017-09-19 Thread Stefan Hajnoczi
On Mon, Sep 18, 2017 at 04:05:31PM +0100, Peter Maydell wrote: > On 18 September 2017 at 15:59, Stefan Hajnoczi wrote: > > Thanks for sending this! Could you and Lluís collaborate on a single > > instrumentation plugin API? > > > > Let's have a discussion with Lluís, Peter, myself, and potentiall

Re: [Qemu-devel] [RFC v1 0/2] Add a valid_cpu_types property

2017-09-19 Thread Philippe Mathieu-Daudé
On 09/18/2017 07:55 PM, Eduardo Habkost wrote: On Mon, Sep 18, 2017 at 06:57:19PM -0300, Philippe Mathieu-Daudé wrote: add a property to restrict the CPU for SoCs once on machine creation and avoid duplicate code in each board. Signed-off-by: Philippe Mathieu-Daudé The valid_cpu_types approa

Re: [Qemu-devel] [PATCH v2 1/4] s390x/css: introduce css data stream

2017-09-19 Thread Cornelia Huck
On Tue, 19 Sep 2017 11:11:27 +0200 Pierre Morel wrote: > On 13/09/2017 13:50, Halil Pasic wrote: > > This is a preparation for introducing handling for indirect data > > addressing and modified indirect data addressing (CCW). Here we introduce > > an interface which should make the addressing sch

Re: [Qemu-devel] [Qemu-block] [PATCH 15/18] block/mirror: Add active mirroring

2017-09-19 Thread Daniel P. Berrange
On Tue, Sep 19, 2017 at 10:44:16AM +0100, Stefan Hajnoczi wrote: > On Mon, Sep 18, 2017 at 06:26:51PM +0200, Max Reitz wrote: > > On 2017-09-18 12:06, Stefan Hajnoczi wrote: > > > On Sat, Sep 16, 2017 at 03:58:01PM +0200, Max Reitz wrote: > > >> On 2017-09-14 17:57, Stefan Hajnoczi wrote: > > >>> O

Re: [Qemu-devel] [PATCH v2 7/7] block/nbd-client: do not yield from nbd_read_reply_entry

2017-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2017 01:36, Eric Blake wrote: On 09/18/2017 08:59 AM, Vladimir Sementsov-Ogievskiy wrote: Refactor nbd client to not yield from nbd_read_reply_entry. It's possible now as all reading is done in nbd_read_reply_entry and all request-related data is stored in per-request s->requests[i]. We n

Re: [Qemu-devel] [PATCH v2 3/7] block/nbd-client: refactor reading reply

2017-09-19 Thread Paolo Bonzini
On 19/09/2017 11:25, Vladimir Sementsov-Ogievskiy wrote: > 18.09.2017 18:43, Paolo Bonzini wrote: >> On 18/09/2017 15:59, Vladimir Sementsov-Ogievskiy wrote: >>> Read the whole reply in one place - in nbd_read_reply_entry. >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>> --- >>> block/nbd

Re: [Qemu-devel] [PATCH v2 6/7] block/nbd-client: early fail nbd_read_reply_entry if s->quit is set

2017-09-19 Thread Paolo Bonzini
On 19/09/2017 11:43, Vladimir Sementsov-Ogievskiy wrote: >> >> I'm trying to look forward to structured reads, where we will have to >> deal with more than one server message in reply to a single client >> request. For read, we just piece together portions of the qiov until >> the server has sent

Re: [Qemu-devel] [PULL 00/13] Ide patches

2017-09-19 Thread Peter Maydell
On 19 September 2017 at 01:11, John Snow wrote: > The following changes since commit a9158a5cba955b79d580a252cc58ff44d154e370: > > Merge remote-tracking branch > 'remotes/kraxel/tags/audio-20170918-pull-request' into staging (2017-09-18 > 12:40:54 +0100) > > are available in the git repository

Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure

2017-09-19 Thread Pradeep Jagadeesh
On 9/18/2017 7:10 PM, Eric Blake wrote: On 09/14/2017 05:40 AM, Pradeep Jagadeesh wrote: This patch factors out code to use the ThrottleLimits strurcture. s/strurcture/structure/ Signed-off-by: Pradeep Jagadeesh Reviewed-by: Greg Kurz Reviewed-by: Eric Blake Echoing the sentiments made

Re: [Qemu-devel] [PATCH v5 00/12] Convert over to use keycodemapdb

2017-09-19 Thread Daniel P. Berrange
On Mon, Sep 18, 2017 at 05:12:55PM +0200, Gerd Hoffmann wrote: > On Thu, 2017-09-14 at 13:40 +0100, Daniel P. Berrange wrote: > > On Thu, Sep 14, 2017 at 12:58:26PM +0100, Peter Maydell wrote: > > > On 14 September 2017 at 12:55, Gerd Hoffmann > > > wrote: > > > >   Hi, > > > > > > > > > I think

[Qemu-devel] [Bug 1715700] Re: Windows 7 guest won't boot on qemu 2.10 (works on 2.9)

2017-09-19 Thread Dr. David Alan Gilbert
Igor asked to add Gerd. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1715700 Title: Windows 7 guest won't boot on qemu 2.10 (works on 2.9) Status in QEMU: New Bug description: Qemu version:

[Qemu-devel] [PATCH 1/4] scsi, file-posix: add support for persistent reservation management

2017-09-19 Thread Paolo Bonzini
It is a common requirement for virtual machine to send persistent reservations, but this currently requires either running QEMU with CAP_SYS_RAWIO, or using out-of-tree patches that let an unprivileged QEMU bypass Linux's filter on SG_IO commands. As an alternative mechanism, the next patches will

[Qemu-devel] [PATCH 2/4] scsi: build qemu-pr-helper

2017-09-19 Thread Paolo Bonzini
Introduce a privileged helper to run persistent reservation commands. This lets virtual machines send persistent reservations without using CAP_SYS_RAWIO or out-of-tree patches. The helper uses Unix permissions and SCM_RIGHTS to restrict access to processes that can access its socket and prove tha

[Qemu-devel] [PATCH v2 0/4] scsi, block: introduce persistent reservation managers

2017-09-19 Thread Paolo Bonzini
SCSI persistent Reservations allow restricting access to block devices to specific initiators in a shared storage setup. When implementing clustering of virtual machines, it is a common requirement for virtual machines to send persistent reservation SCSI commands. However, the operating system re

[Qemu-devel] [PATCH 3/4] scsi: add multipath support to qemu-pr-helper

2017-09-19 Thread Paolo Bonzini
Proper support of persistent reservation for multipath devices requires communication with the multipath daemon, so that the reservation is registered and applied when a path comes up. The device mapper utilities provide a library to do so; this patch makes qemu-pr-helper.c detect multipath device

[Qemu-devel] [PATCH 4/4] scsi: add persistent reservation manager using qemu-pr-helper

2017-09-19 Thread Paolo Bonzini
This adds a concrete subclass of pr-manager that talks to qemu-pr-helper. Signed-off-by: Paolo Bonzini --- v1->v2: fixed string property double-free fixed/cleaned up error handling handle buffer underrun scsi/Makefile.objs | 2 +- scsi/pr-manager-helper.c | 302 +

Re: [Qemu-devel] [Qemu-trivial] [PATCH] nbd-client: Use correct macro parenthesization

2017-09-19 Thread Philippe Mathieu-Daudé
On 09/18/2017 07:42 PM, Eric Blake wrote: On 09/18/2017 05:13 PM, Philippe Mathieu-Daudé wrote: Any magic cocci script to verify there aren't no more? I don't know if cocci can do it; checkpatch tries to check whether macro arguments are parenthesized, but even that's prone to missing things.

Re: [Qemu-devel] [PATCH 2/8] ppc/mac: Advertise a high clock frequency for NewWorld Macs

2017-09-19 Thread David Gibson
On Sun, Sep 17, 2017 at 06:15:42PM +0100, Mark Cave-Ayland wrote: > From: Benjamin Herrenschmidt > > We use 900Mhz, otherwise MacOS X 10.5 refuses to install. > > Signed-off-by: Benjamin Herrenschmidt Applied to ppc-for-2.11. > --- > hw/ppc/mac_newworld.c |2 +- > 1 file changed, 1 inser

Re: [Qemu-devel] [RFC PATCH v2 05/21] ppc/xive: allocate IRQ numbers for the IPIs

2017-09-19 Thread David Gibson
On Mon, Sep 11, 2017 at 07:12:19PM +0200, Cédric Le Goater wrote: > The number of IPIs is deduced from the max number of CPUs the guest > supports and the IRQ numbers for the IPIs are allocated from the top > of the IRQ number space to reduce conflict with other IRQ numbers > allocated by the devic

Re: [Qemu-devel] [PATCH 6/8] ppc: Fix OpenPIC model

2017-09-19 Thread David Gibson
On Sun, Sep 17, 2017 at 06:15:46PM +0100, Mark Cave-Ayland wrote: > From: Benjamin Herrenschmidt > > Apple uses an IBM MPIC2A without timers, it has 64 sources. > > Signed-off-by: Benjamin Herrenschmidt Applied to ppc-for-2.11. > --- > hw/intc/openpic.c| 35

Re: [Qemu-devel] [PATCH 3/4] ppc/kvm: change kvmppc_get_htab_fd() to return -errno on error

2017-09-19 Thread David Gibson
On Fri, Sep 15, 2017 at 03:16:10PM +0200, Greg Kurz wrote: > When kvmppc_get_htab_fd() fails, its return value is propagated up to > qemu_savevm_state_iterate() or to qemu_savevm_state_complete_precopy(). > All savevm handlers expect to receive a negative errno on error. > > Let's patch kvmppc_get

Re: [Qemu-devel] [PATCH 3/8] ppc/ide/macio: Add missing registers

2017-09-19 Thread David Gibson
On Sun, Sep 17, 2017 at 06:15:43PM +0100, Mark Cave-Ayland wrote: > From: Benjamin Herrenschmidt > > The timing register exists on all variants of MacIO IDE, we just > store and return its value. > > The interrupts register only exists on KeyLargo but it doesn't > hurt to have it. The lack of th

Re: [Qemu-devel] [PATCH 7/8] openpic: add missing timer fields to vmstate_openpic_timer

2017-09-19 Thread David Gibson
On Sun, Sep 17, 2017 at 06:15:47PM +0100, Mark Cave-Ayland wrote: > Observation of the code shows indicates that several timer fields are > missing from the migration stream. So, adding new things to the migration stream always requires some thought. The commit message should contain a rationale

Re: [Qemu-devel] [RFC PATCH v2 11/21] ppc/xive: push the EQ data in OS event queue

2017-09-19 Thread David Gibson
On Mon, Sep 11, 2017 at 07:12:25PM +0200, Cédric Le Goater wrote: > If a triggered event is let through, the Event Queue data defined in > the associated IVE is pushed in the in-memory event queue. The latter > is a circular buffer provided by the OS using the H_INT_SET_QUEUE_CONFIG > hcall, one pe

Re: [Qemu-devel] [PATCH 2/4] spapr: introduce helpers to migrate HPT chunks and the end marker

2017-09-19 Thread David Gibson
On Fri, Sep 15, 2017 at 03:16:01PM +0200, Greg Kurz wrote: > This consolidates some duplicated code in a single helper. > > Signed-off-by: Greg Kurz > --- > hw/ppc/spapr.c | 38 +- > 1 file changed, 21 insertions(+), 17 deletions(-) > > diff --git a/hw/ppc/

Re: [Qemu-devel] [RFC PATCH v2 14/21] ppc/xive: add support for the SET_OS_PENDING command

2017-09-19 Thread David Gibson
On Mon, Sep 11, 2017 at 07:12:28PM +0200, Cédric Le Goater wrote: > Adjusting the Interrupt Pending Buffer for the O/S would allow a CPU > to process event queues of other priorities during one physical > interrupt cycle. This is not currently used by the XIVE support for > sPAPR in Linux but it is

Re: [Qemu-devel] [PATCH 8/8] openpic: Fix problem when IRQ transitions from edge to level

2017-09-19 Thread David Gibson
On Sun, Sep 17, 2017 at 06:15:48PM +0100, Mark Cave-Ayland wrote: > From: Benjamin Herrenschmidt > > Some interrupts get triggered before the OS has setup the > right interrupt type. If an edge interrupt is latched that > way, not delivered (still masked), then the interrupt is > changed to level

  1   2   3   4   5   6   7   >