On Tue, 19 Sep 2017 10:21:42 +0800
Dong Jia Shi <bjsdj...@linux.vnet.ibm.com> wrote:
> * Halil Pasic <pa...@linux.vnet.ibm.com> [2017-09-13 13:50:26 +0200]:
>
> [...]
>
> > diff --git a/include/hw/s390x/css.h b/include/hw/s390x/css.h
> > index 0653d3c9be..79acaf99b7 100644
> > --- a/include/hw/s390x/css.h
> > +++ b/include/hw/s390x/css.h
> > @@ -75,6 +75,29 @@ typedef struct CMBE {
> > uint32_t reserved[7];
> > } QEMU_PACKED CMBE;
> >
> > +typedef enum CcwDataStreamOp {
> > + CDS_OP_R = 0,
> > + CDS_OP_W = 1,
> > + CDS_OP_A = 2
>
> Nit:
>
> typedef enum CcwDataStreamOp {
> CDS_OP_R, /* read */
> CDS_OP_W, /* write */
> CDS_OP_A /* advance */
> } CcwDataStreamOp;
>
> (I just keep translating 'A' as append in my mind...)
Adding comments makes sense. Done.
>
> > +} CcwDataStreamOp;
> > +
> [...]
>
> > +static inline uint16_t ccw_dstream_avail(CcwDataStream *cds)
> > +{
> > + return ccw_dstream_good(cds) ? ccw_dstream_residual_count(cds) : 0;
> ^^
> Nit.
Fixed.
>
> > +}
>
> [...]
>
> With or w/o responses the nit picks:
> Reviewed-by: Dong Jia Shi <bjsdj...@linux.vnet.ibm.com>
>
Thanks!
