Re: [Qemu-devel] [PATCH 09/14] qlit: replace assert(qnum_get_try_int)

2017-08-25 Thread Markus Armbruster
Marc-André Lureau writes: > qnum_get_int() will assert if underlying type isn't compatible. > > Signed-off-by: Marc-André Lureau > --- > qobject/qlit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qobject/qlit.c b/qobject/qlit.c > index 07ad6b05e8..7e4bf92862 100644

Re: [Qemu-devel] [PATCH] hw/ppc: CAS reset on early device hotplug

2017-08-25 Thread David Gibson
On Wed, Aug 23, 2017 at 05:57:31PM -0300, Daniel Henrique Barboza wrote: > This patch is a follow up on the discussions made in patch > "hw/ppc: disable hotplug before CAS is completed" that can be > found at [1]. > > At this moment, we do not support CPU/memory hotplug in early > boot stages, bef

Re: [Qemu-devel] S390 bios breaks in qemu 2.10.rc3

2017-08-25 Thread Cornelia Huck
On Thu, 24 Aug 2017 20:14:06 +0200 Christian Borntraeger wrote: > On 08/24/2017 07:38 PM, Farhan Ali wrote: > > > > > > On 08/24/2017 12:07 PM, Peter Maydell wrote: > >> On 24 August 2017 at 16:53, Farhan Ali wrote: > >>> > >>> > >>> On 08/24/2017 11:50 AM, Thomas Huth wrote: > True

Re: [Qemu-devel] [PATCH for-2.11 2/6] ppc: make cpu_model translation to type consistent

2017-08-25 Thread Igor Mammedov
On Fri, 25 Aug 2017 11:38:19 +1000 David Gibson wrote: > On Thu, Aug 24, 2017 at 10:21:47AM +0200, Igor Mammedov wrote: > > PPC handles -cpu FOO rather incosistently, > > i.e. it does case-insensitive matching of FOO to > > a CPU type (see: ppc_cpu_compare_class_name) but > > handles alias names

Re: [Qemu-devel] [PATCH for-2.11 1/6] ppc: use macros to make cpu type name from string literal

2017-08-25 Thread Igor Mammedov
On Fri, 25 Aug 2017 11:30:47 +1000 David Gibson wrote: > On Thu, Aug 24, 2017 at 10:21:46AM +0200, Igor Mammedov wrote: > > Replace > > "-" TYPE_POWERPC_CPU > > when composing cpu type name from cpu model string literal > > and the same pattern in format strings with > > POWERPC_CPU_TYPE_SUFFI

Re: [Qemu-devel] [PATCH 0/3] iotests: clean up resources using context managers

2017-08-25 Thread Fam Zheng
On Thu, 08/24 19:04, Stefan Hajnoczi wrote: > On Thu, Aug 24, 2017 at 04:38:43PM +0800, Fam Zheng wrote: > > On Thu, 08/24 08:21, Stefan Hajnoczi wrote: > > > Tests should declare resources upfront in a with statement. Resources are > > > automatically cleaned up whether the test passes or fails:

Re: [Qemu-devel] [PATCH for-2.11 4/6] ppc: replace inter-function cyclic dependency/recurssion with 2 simple lookups

2017-08-25 Thread Igor Mammedov
On Fri, 25 Aug 2017 14:12:08 +1000 David Gibson wrote: > On Thu, Aug 24, 2017 at 10:21:49AM +0200, Igor Mammedov wrote: > > previous patches cleaned up cpu model/alias naming which > > allows to simplify cpu model/alias to cpu type lookup a bit > > byt removing recurssion and dependency of ppc_cp

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.10.0-rc4 is now available

2017-08-25 Thread Paolo Bonzini
On 24/08/2017 21:06, Laszlo Ersek wrote: > On 08/24/17 20:53, Michael Roth wrote: >> Hello, >> >> On behalf of the QEMU Team, I'd like to announce the availability of the >> fifth release candidate for the QEMU 2.10 release. This release is meant >> for testing purposes and should not be used in a

Re: [Qemu-devel] Why got no response of vnc?

2017-08-25 Thread Sam
Actually, I just want to install OS and use it, but I found I can't go into guest OS (as vnc time out), so what should I do? 2017-08-25 14:45 GMT+08:00 Sam : > I follow this: > https://en.wikibooks.org/wiki/QEMU/QEMU_Hello_World:_ > Installing_QEMU_and_getting_it_up_and_running > > 2017-08-25 14:

Re: [Qemu-devel] [PATCH for-2.11 5/6] ppc: simplify cpu model lookup by PVR

2017-08-25 Thread Igor Mammedov
On Fri, 25 Aug 2017 14:16:44 +1000 David Gibson wrote: > On Thu, Aug 24, 2017 at 10:21:50AM +0200, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > target/ppc/translate_init.c | 27 +++ > > 1 file changed, 11 insertions(+), 16 deletions(-) > > > > diff

Re: [Qemu-devel] Why got no response of vnc?

2017-08-25 Thread Sam
I use ssh to the host PC, so I think I could not use two screen. 2017-08-25 15:38 GMT+08:00 Sam : > Actually, I just want to install OS and use it, but I found I can't go > into guest OS (as vnc time out), so what should I do? > > 2017-08-25 14:45 GMT+08:00 Sam : > >> I follow this: >> https://en

Re: [Qemu-devel] [PATCH for-2.11 6/6] ppc: drop caching ObjectClass from PowerPCCPUAlias

2017-08-25 Thread Igor Mammedov
On Fri, 25 Aug 2017 14:22:03 +1000 David Gibson wrote: > On Thu, Aug 24, 2017 at 10:21:51AM +0200, Igor Mammedov wrote: > > Caching there practically doesn't give any benefits > > and that at slow path druring querying supported CPU list. > > But it introduces non conventional path of where from

Re: [Qemu-devel] [PATCH for-2.11 v3 01/25] qom: cpu: fix parsed feature string length

2017-08-25 Thread Igor Mammedov
On Thu, 24 Aug 2017 14:00:21 -0300 Philippe Mathieu-Daudé wrote: > Hi Igor, > > On 08/24/2017 01:31 PM, Igor Mammedov wrote: > > since commit ( 9262685b cpu: Factor out cpu_generic_init() ) > > features parsed by it were truncated only to the 1st feature > > after CPU name due to fact that > >

Re: [Qemu-devel] S390 bios breaks in qemu 2.10.rc3

2017-08-25 Thread Christian Borntraeger
On 08/25/2017 09:20 AM, Cornelia Huck wrote: > On Thu, 24 Aug 2017 20:14:06 +0200 > Christian Borntraeger wrote: > >> On 08/24/2017 07:38 PM, Farhan Ali wrote: >>> >>> >>> On 08/24/2017 12:07 PM, Peter Maydell wrote: On 24 August 2017 at 16:53, Farhan Ali wrote: > > > On 0

Re: [Qemu-devel] Why got no response of vnc?

2017-08-25 Thread Thomas Huth
On 25.08.2017 08:31, Sam wrote: > Hi all, > > I'm starting vm using: > > kvm]$ sudo /usr/local/bin/qemu-system-x86_64 -m 256 -hda test.qcow2 -cdrom >> CentOS-7-x86_64-DVD-1503-01.iso -boot d >> VNC server running on '127.0.0.1:5900' > > then I start vnc client in another PC to connect 10.253.23.

Re: [Qemu-devel] S390 bios breaks in qemu 2.10.rc3

2017-08-25 Thread Cornelia Huck
On Fri, 25 Aug 2017 10:21:58 +0200 Christian Borntraeger wrote: > On 08/25/2017 09:20 AM, Cornelia Huck wrote: > > OK, to recap: > > > > - the current pre-built bios seems fine > > - rebuilding the bios may yield a version that fails on some systems > > (different compiler?) > > - adding alig

[Qemu-devel] [RFC PATCH qemu] exec: Destroy dispatch immediately

2017-08-25 Thread Alexey Kardashevskiy
Otherwise old dispatch holds way too much memory before RCU gets a chance to free old dispatches. Signed-off-by: Alexey Kardashevskiy --- This is a follow-up to the "Memory use with >100 virtio devices" thread. I assume this is a dirty hack (which fixes the problem though) and I wonder what th

Re: [Qemu-devel] [PATCH 0/3] iotests: clean up resources using context managers

2017-08-25 Thread Stefan Hajnoczi
On Fri, Aug 25, 2017 at 03:32:29PM +0800, Fam Zheng wrote: > On Thu, 08/24 19:04, Stefan Hajnoczi wrote: > > On Thu, Aug 24, 2017 at 04:38:43PM +0800, Fam Zheng wrote: > > > On Thu, 08/24 08:21, Stefan Hajnoczi wrote: > > > > Tests should declare resources upfront in a with statement. Resources >

Re: [Qemu-devel] [RFC PATCH qemu] exec: Destroy dispatch immediately

2017-08-25 Thread Paolo Bonzini
On 25/08/2017 10:31, Alexey Kardashevskiy wrote: > Otherwise old dispatch holds way too much memory before RCU gets > a chance to free old dispatches. > > Signed-off-by: Alexey Kardashevskiy > --- > > This is a follow-up to the "Memory use with >100 virtio devices" > thread. > > I assume this i

Re: [Qemu-devel] [PATCH v3 06/10] tests: Add NetBSD image

2017-08-25 Thread Fam Zheng
On Thu, 08/24 11:37, Cleber Rosa wrote: > > > On 08/22/2017 12:41 AM, Fam Zheng wrote: > > The image is prepared following instructions as in: > > > > https://wiki.qemu.org/Hosts/BSD > > > > Signed-off-by: Fam Zheng > > Reviewed-by: Kamil Rytarowski > > --- > > tests/vm/netbsd | 45 +

Re: [Qemu-devel] [RFC PATCH qemu] exec: Destroy dispatch immediately

2017-08-25 Thread Paolo Bonzini
On 25/08/2017 10:31, Alexey Kardashevskiy wrote: > > Interestingly, mem_add() from exec.c is called twice: > as as->dispatch_listener.region_add() and > as as->dispatch_listener.region_nop() - I did not understand > the trick but it does not work if I remove the .region_nop() hook. > How does it w

Re: [Qemu-devel] [RFC PATCH qemu] exec: Destroy dispatch immediately

2017-08-25 Thread Paolo Bonzini
On 25/08/2017 10:31, Alexey Kardashevskiy wrote: > Each address_space_init() updates topology for _every_ address space. And finally, does this patch help with the above? diff --git a/memory.c b/memory.c index c0adc35..97c16cc 100644 --- a/memory.c +++ b/memory.c @@ -2607,10 +2607,16 @@ void memo

Re: [Qemu-devel] [RFC v2 4/8] QAPI: new QMP command option "without-bql"

2017-08-25 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Aug 23, 2017 at 06:44:12PM +0100, Dr. David Alan Gilbert wrote: > > [...] > > > > +Most of the commands require the Big QEMU Lock (BQL) be held during > > > +execution. However, there is a small subset of the commands that may > > > +not really nee

Re: [Qemu-devel] Make test

2017-08-25 Thread Peter Maydell
On 25 August 2017 at 06:49, Thomas Huth wrote: > On 25.08.2017 00:16, Cleber Rosa wrote: >> >> On 08/24/2017 05:50 PM, Programmingkid wrote: >>> >>> Thank you for the patches. I will test them. I was wondering what is the >>> point to having both 'make check' and 'make test'. It looks like everyo

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.10.0-rc4 is now available

2017-08-25 Thread Peter Maydell
On 24 August 2017 at 20:06, Laszlo Ersek wrote: > Has it not been the intent to include the following patch in 2.10: > > [PATCH] scsi-bus: correct responses for INQUIRY and REQUEST SENSE > http://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg03351.html > Message-Id: <1503049022-14749-1

Re: [Qemu-devel] [RFC v2 4/8] QAPI: new QMP command option "without-bql"

2017-08-25 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Thu, Aug 24, 2017 at 07:37:32AM +0800, Fam Zheng wrote: > > On Wed, 08/23 18:44, Dr. David Alan Gilbert wrote: > > > * Peter Xu (pet...@redhat.com) wrote: > > > > Introducing this new parameter for QMP commands in general to mark out > > > > when the comma

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.10.0-rc4 is now available

2017-08-25 Thread Paolo Bonzini
On 25/08/2017 11:13, Peter Maydell wrote: > On 24 August 2017 at 20:06, Laszlo Ersek wrote: >> Has it not been the intent to include the following patch in 2.10: >> >> [PATCH] scsi-bus: correct responses for INQUIRY and REQUEST SENSE >> http://lists.nongnu.org/archive/html/qemu-devel/2017-08/m

Re: [Qemu-devel] [RFC PATCH qemu] exec: Destroy dispatch immediately

2017-08-25 Thread Alexey Kardashevskiy
On 25/08/17 19:01, Paolo Bonzini wrote: > On 25/08/2017 10:31, Alexey Kardashevskiy wrote: >> Each address_space_init() updates topology for _every_ address space. > > And finally, does this patch help with the above? > > diff --git a/memory.c b/memory.c > index c0adc35..97c16cc 100644 > --- a/me

Re: [Qemu-devel] [RFC PATCH qemu] exec: Destroy dispatch immediately

2017-08-25 Thread Peter Maydell
On 25 August 2017 at 09:53, Paolo Bonzini wrote: > The solution is to: 1) share the FlatView structures if they refer to > the same root memory region; 2) have one AddressSpaceDispatch per > FlatView instead of one per AddressSpace, so that FlatView reference > counting takes care of clearing the

Re: [Qemu-devel] [PATCH v3 00/10] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)

2017-08-25 Thread Fam Zheng
On Thu, 08/24 11:06, Cleber Rosa wrote: > I replayed manually the FreeBSD VM setup, just to get a sense of how it > could be automated. Taking a few steps back, I realized that: > > * describing how to prepare a given OS to build QEMU is a generic task, > not really bound to this VM setup > * c

Re: [Qemu-devel] [PATCH v3 for-2.11 00/18] target/s390x: cleanup cpu.h

2017-08-25 Thread David Hildenbrand
On 24.08.2017 14:30, Cornelia Huck wrote: > On Fri, 18 Aug 2017 13:43:35 +0200 > David Hildenbrand wrote: > >> ... now featuring even more cleanups. >> >> cpu.h is accessed outside of target/s390x. It should only contain >> what is expected to be accessed outside of this folder. Therefore, create

Re: [Qemu-devel] [PATCH 0/3] iotests: clean up resources using context managers

2017-08-25 Thread Fam Zheng
On Fri, 08/25 09:52, Stefan Hajnoczi wrote: > On Fri, Aug 25, 2017 at 03:32:29PM +0800, Fam Zheng wrote: > > On Thu, 08/24 19:04, Stefan Hajnoczi wrote: > > > On Thu, Aug 24, 2017 at 04:38:43PM +0800, Fam Zheng wrote: > > > > On Thu, 08/24 08:21, Stefan Hajnoczi wrote: > > > > > Tests should declar

Re: [Qemu-devel] [PATCH v2 12/16] qapi-schema: Move block events from event.json to block.json

2017-08-25 Thread Alberto Garcia
On Thu 24 Aug 2017 09:14:04 PM CEST, Markus Armbruster wrote: > Cc: Alberto Garcia > Signed-off-by: Markus Armbruster I'm not even sure about the difference between block.json and block-core.json :) but I'm fine with the move anyway. Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

2017-08-25 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Aug 23, 2017 at 06:35:35PM +0100, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > Firstly, introduce Monitor.use_thread, and set it for monitors that are > > > using non-mux typed backend chardev. We only do this for mon

Re: [Qemu-devel] Make test

2017-08-25 Thread Fam Zheng
On Fri, 08/25 10:10, Peter Maydell wrote: > On 25 August 2017 at 06:49, Thomas Huth wrote: > > On 25.08.2017 00:16, Cleber Rosa wrote: > >> > >> On 08/24/2017 05:50 PM, Programmingkid wrote: > >>> > >>> Thank you for the patches. I will test them. I was wondering what is the > >>> point to having

Re: [Qemu-devel] [Qemu-arm] [PATCH 05/20] target/arm: Add MMU indexes for secure v8M

2017-08-25 Thread Peter Maydell
On 22 August 2017 at 16:08, Peter Maydell wrote: > Now that MPU lookups can return different results for v8M > when the CPU is in secure vs non-secure state, we need to > have separate MMU indexes; add the secure counterparts > to the existing three M profile MMU indexes. > @@ -2206,7 +2217,11 @@

Re: [Qemu-devel] [RFC v2 8/8] migration: add incoming mgmt lock

2017-08-25 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Aug 23, 2017 at 07:01:35PM +0100, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > Now at least migrate_incoming can be run in parallel. Let's provide a > > > migration lock to protect it. > > > > > > Signed-off-by: Pete

Re: [Qemu-devel] [PATCH v8 4/6] block: convert ThrottleGroup to object with QOM

2017-08-25 Thread Alberto Garcia
On Thu 24 Aug 2017 02:05:59 PM CEST, Manos Pitsidianakis wrote: > ThrottleGroup is converted to an object. This will allow the future > throttle block filter drive easy creation and configuration of throttle > groups in QMP and cli. Stefan pointed out a couple of important things in a reply to v7

Re: [Qemu-devel] Make test

2017-08-25 Thread Peter Maydell
On 25 August 2017 at 10:33, Fam Zheng wrote: > On Fri, 08/25 10:10, Peter Maydell wrote: >> The problem is that we don't have a good framework for building >> guest binaries to run under TCG. We should sort out one of those >> so that it's easy for a new test to say "this is the .c file, >> build

Re: [Qemu-devel] [PATCH v8 5/6] block: add throttle block filter driver

2017-08-25 Thread Alberto Garcia
On Thu 24 Aug 2017 02:06:00 PM CEST, Manos Pitsidianakis wrote: > +bool throttle_group_exists(const char *name) > +{ > +return throttle_group_by_name(name) != NULL; > +} I realized that you needed to add throttle_group_exists() after all because you need it in block/throttle.c > /* error

Re: [Qemu-devel] [RFC PATCH qemu] exec: Destroy dispatch immediately

2017-08-25 Thread Paolo Bonzini
On 25/08/2017 11:22, Peter Maydell wrote: > On 25 August 2017 at 09:53, Paolo Bonzini wrote: >> The solution is to: 1) share the FlatView structures if they refer to >> the same root memory region; 2) have one AddressSpaceDispatch per >> FlatView instead of one per AddressSpace, so that FlatView r

Re: [Qemu-devel] [RFC PATCH qemu] exec: Destroy dispatch immediately

2017-08-25 Thread Paolo Bonzini
On 25/08/2017 11:16, Alexey Kardashevskiy wrote: > On 25/08/17 19:01, Paolo Bonzini wrote: >> On 25/08/2017 10:31, Alexey Kardashevskiy wrote: >>> Each address_space_init() updates topology for _every_ address space. >> >> And finally, does this patch help with the above? >> >> diff --git a/memory.

Re: [Qemu-devel] [PATCH v3 00/10] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)

2017-08-25 Thread Paolo Bonzini
On 25/08/2017 11:25, Fam Zheng wrote: >> I'm no expert in ansible, but I can give it that a try if you fancy the >> idea. >> > I have no objection if you want to give it a try. However it is basically a > separate problem, and I don't think this series would depend on that. The > reason > is that

Re: [Qemu-devel] Why got no response of vnc?

2017-08-25 Thread Sam
No firewall, as another vm could be connect by vnc, this is the start command used by that vm, and the disk(*.img) is copied from other place. $QEMU -smp 4 -m 4096 -enable-kvm $SCRIPT_PATH/$IMG -cdrom $CD -daemonize -vnc 0.0.0.0:2520 \ -chardev socket,id=char-$IF,path=/usr/local/var/run/openvswit

Re: [Qemu-devel] [PATCH 04/14] qlit: remove needless type cast

2017-08-25 Thread Marc-André Lureau
Hi On Fri, Aug 25, 2017 at 8:20 AM Markus Armbruster wrote: > Marc-André Lureau writes: > > > And misc code style fix. > > > > Signed-off-by: Marc-André Lureau > > --- > > include/qapi/qmp/qlit.h | 8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/include/qa

Re: [Qemu-devel] [PATCH v11 1/6] ACPI: add APEI/HEST/CPER structures and macros

2017-08-25 Thread gengdongjiu
Shannon, Thanks for the review. please see my reply. On 2017/8/24 20:33, Shannon Zhao wrote: > > > On 2017/8/18 22:23, Dongjiu Geng wrote: >> (1) Add related APEI/HEST table structures and macros, these >> definition refer to ACPI 6.1 and UEFI 2.6 spec. >> (2) Add generic error status bl

Re: [Qemu-devel] [Qemu-block] [PATCH 1/3] nbd-client: enter read_reply_co during init to avoid crash

2017-08-25 Thread Stefan Hajnoczi
On Thu, Aug 24, 2017 at 5:21 PM, Paolo Bonzini wrote: > On 24/08/2017 17:33, Stefan Hajnoczi wrote: >> This patch enters read_reply_co directly in >> nbd_client_attach_aio_context(). This is safe because new_context is >> acquired by the caller. This ensures that read_reply_co reaches its >> fir

Re: [Qemu-devel] Memory use with >100 virtio devices

2017-08-25 Thread Paolo Bonzini
On 24/08/2017 14:30, David Gibson wrote: >> >> Ideas what to tweak or what valgrind tool to try? > valgrind probably isn't that useful at this point. I think we need to > instrument bits of the code to find what the O(n^2) algo is and fix it. > > Seems to me checking if the address_spaces list is

[Qemu-devel] [PATCH v2 00/14] Generate a literal qobject for introspection

2017-08-25 Thread Marc-André Lureau
Hi, This series is based on patches 2-5 from "[PATCH v2 00/54] qapi: add #if pre-processor conditions to generated code". Generating a literal qobject will allow to easily introduce #if conditionals from the original series. v2: - use QLIST_FOREACH_ENTRY for list comparison - update qdict compari

[Qemu-devel] [PATCH v2 04/14] qlit: remove compound literals

2017-08-25 Thread Marc-André Lureau
They are not considered constant expressions in C, producing an error when compiling a const QLit. Signed-off-by: Marc-André Lureau --- include/qapi/qmp/qlit.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/qapi/qmp/qlit.h b/include/qapi/qmp/qlit.h index a4ad

[Qemu-devel] [PATCH v2 06/14] qlit: make qlit_equal_qobject return a bool

2017-08-25 Thread Marc-André Lureau
Make it more obvious about the expected return values. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- include/qapi/qmp/qlit.h | 2 +- qobject/qlit.c | 18 +- tests/check-qjson.c | 14 +++--- 3 files changed, 17 insertions(+), 17 deletio

[Qemu-devel] [PATCH v2 08/14] qlit: add QLIT_QNULL and QLIT_BOOL

2017-08-25 Thread Marc-André Lureau
As they are going to be used in the following patches. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- include/qapi/qmp/qlit.h | 5 + qobject/qlit.c | 4 2 files changed, 9 insertions(+) diff --git a/include/qapi/qmp/qlit.h b/include/qapi/qmp/qlit.h index

[Qemu-devel] [PATCH v2 01/14] qdict: add qdict_put_null() helper

2017-08-25 Thread Marc-André Lureau
A step towards completeness. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- include/qapi/qmp/qdict.h | 4 +++- target/i386/cpu.c| 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/include/qapi/qmp/qdict.h b/include/qapi/qmp/qdict.h index 363e431

[Qemu-devel] [PATCH v2 09/14] qlit: Replace open-coded qnum_get_int() by call

2017-08-25 Thread Marc-André Lureau
Bonus: rids us of a side effect in an assertion. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- qobject/qlit.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/qobject/qlit.c b/qobject/qlit.c index 07ad6b05e8..b1d9146220 100644 --- a/qobject/qlit.c ++

[Qemu-devel] [PATCH v2 07/14] qlit: make qlit_equal_qobject() take const arguments

2017-08-25 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- include/qapi/qmp/qlit.h | 2 +- qobject/qlit.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/qapi/qmp/qlit.h b/include/qapi/qmp/qlit.h index 35aabbdc9f..fc1a2d845d 100644 --- a/include/q

[Qemu-devel] [PATCH v2 12/14] qlit: improve QLit list vs qlist comparison

2017-08-25 Thread Marc-André Lureau
Use QLIST_FOREACH_ENTRY() to simplify the code and break earlier. Check that the QLit list has the same size as the qlist, this should ensure that we have an exact match when iterating over qlist for comparing the elements. Signed-off-by: Marc-André Lureau --- qobject/qlit.c | 53 ++

[Qemu-devel] [PATCH v2 02/14] qlit: move qlit from check-qjson to qobject/

2017-08-25 Thread Marc-André Lureau
Fix code style issues while at it, to please checkpatch. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- include/qapi/qmp/qlit.h | 49 + qobject/qlit.c | 89 + tests/check-qjson.c | 96 +

[Qemu-devel] [PATCH v2 14/14] qapi: generate a literal qobject for introspection

2017-08-25 Thread Marc-André Lureau
Replace the generated json string with a literal qobject. The later is easier to deal with, at run time as well as compile time: adding #if conditionals will be easier than in a json string. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- scripts/qapi-introspect.py |

[Qemu-devel] [PATCH v2 11/14] qlit: improve QLit dict vs qdict comparison

2017-08-25 Thread Marc-André Lureau
Verify that all qdict values are covered. (a previous iteration of this patch created a copy of qdict to remove all checked elements, verifying no duplicates exist in the literal qdict, however this is a programming error, and a size comparison should be enough) Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH v2 04/16] qapi-schema: Collect sockets stuff in qapi/sockets.json

2017-08-25 Thread Marc-André Lureau
On Thu, Aug 24, 2017 at 9:18 PM Markus Armbruster wrote: > Cc: "Daniel P. Berrange" > Cc: Gerd Hoffmann > Cc: Paolo Bonzini > Signed-off-by: Markus Armbruster > Reviewed-by: Marc-André Lureau > --- > MAINTAINERS | 1 + > Makefile | 4 +- > qapi-schema.json |

[Qemu-devel] [PATCH v2 03/14] qlit: use QLit prefix consistently

2017-08-25 Thread Marc-André Lureau
Rename from LiteralQ to QLit. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- include/qapi/qmp/qlit.h | 24 qobject/qlit.c | 4 ++-- tests/check-qjson.c | 40 3 files changed, 34 insertions(+), 3

Re: [Qemu-devel] [PATCH v7 6/6] qemu-iotests: add 184 for throttle filter driver

2017-08-25 Thread Stefan Hajnoczi
On Thu, Aug 24, 2017 at 10:15 PM, Manos Pitsidianakis wrote: > On Thu, Aug 24, 2017 at 07:43:08PM +0100, Stefan Hajnoczi wrote: >> >> On Tue, Aug 22, 2017 at 01:15:35PM +0300, Manos Pitsidianakis wrote: >>> >>> +_supported_fmt qcow2 >> >> >> What makes this test qcow2-specific? With additional fi

[Qemu-devel] [PATCH v2 13/14] qlit: add qobject_form_qlit()

2017-08-25 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- include/qapi/qmp/qlit.h | 2 ++ qobject/qlit.c | 37 + tests/check-qlit.c | 26 ++ 3 files changed, 65 insertions(+) diff --git a/include/qapi/qmp/qlit.h b/include/qapi/qmp/qlit.h inde

[Qemu-devel] [PATCH v2 05/14] qlit: rename compare_litqobj_to_qobj() to qlit_equal_qobject()

2017-08-25 Thread Marc-André Lureau
compare_litqobj_to_qobj() lacks a qlit_ prefix. Moreover, "compare" suggests -1, 0, +1 for less than, equal and greater than. The function actually returns non-zero for equal, zero for unequal. Rename to qlit_equal_qobject(). Its return type will be cleaned up in the next patch. Signed-off-by:

Re: [Qemu-devel] [PATCH v2 05/16] qapi-schema: Collect run state stuff in qapi/run-state.json

2017-08-25 Thread Marc-André Lureau
On Thu, Aug 24, 2017 at 9:20 PM Markus Armbruster wrote: > Cc: Paolo Bonzini > Signed-off-by: Markus Armbruster > Nice one Reviewed-by: Marc-André Lureau --- > MAINTAINERS | 1 + > Makefile| 1 + > qapi-schema.json| 165 +--- > qapi/event.json

Re: [Qemu-devel] [PATCH v2 06/16] qapi-schema: Collect char device stuff in qapi/char.json

2017-08-25 Thread Marc-André Lureau
On Thu, Aug 24, 2017 at 9:24 PM Markus Armbruster wrote: > Cc: Paolo Bonzini > Cc: Marc-André Lureau > Signed-off-by: Markus Armbruster > Reviewed-by: Marc-André Lureau --- > MAINTAINERS | 1 + > Makefile | 1 + > qapi-schema.json | 511 > +-

[Qemu-devel] [PATCH v2 10/14] tests: add qlit tests

2017-08-25 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- tests/check-qlit.c | 64 ++ tests/Makefile.include | 5 +++- 2 files changed, 68 insertions(+), 1 deletion(-) create mode 100644 tests/check-qlit.c diff --git a/tests/check-qlit.c b/tests/check-qlit.c new

Re: [Qemu-devel] RFC: qemu RISC-V

2017-08-25 Thread KONRAD Frederic
Hi Paolo, Thanks for the information. Fred On 08/23/2017 10:29 PM, Paolo Bonzini wrote: On 23/08/2017 21:25, KONRAD Frederic wrote: Hi all, I found somes slides about RISC-V at the KVM forum 2016. Seems the upstreaming process should have started in september 2016 but I didn't see anything.

Re: [Qemu-devel] [PATCH v2 07/16] qapi-schema: Collect net device stuff in qapi/net.json

2017-08-25 Thread Marc-André Lureau
On Thu, Aug 24, 2017 at 9:25 PM Markus Armbruster wrote: > Cc: Jason Wang > Signed-off-by: Markus Armbruster > Reviewed-by: Marc-André Lureau --- > MAINTAINERS | 1 + > Makefile | 1 + > qapi-schema.json | 675 > +--- > qapi/e

Re: [Qemu-devel] [PATCH v2 08/16] qapi-schema: Collect UI stuff in qapi/ui.json

2017-08-25 Thread Marc-André Lureau
On Thu, Aug 24, 2017 at 9:27 PM Markus Armbruster wrote: > UI stuff is remote desktop stuff (Spice, VNC) and input stuff (mouse, > keyboard). > > Cc: Gerd Hoffmann > Signed-off-by: Markus Armbruster > Reviewed-by: Marc-André Lureau --- > MAINTAINERS | 2 + > Makefile | 3 +-

Re: [Qemu-devel] [PATCH for-2.11 5/6] ppc: simplify cpu model lookup by PVR

2017-08-25 Thread David Gibson
On Fri, Aug 25, 2017 at 09:40:37AM +0200, Igor Mammedov wrote: > On Fri, 25 Aug 2017 14:16:44 +1000 > David Gibson wrote: > > > On Thu, Aug 24, 2017 at 10:21:50AM +0200, Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > > --- > > > target/ppc/translate_init.c | 27 +++-

Re: [Qemu-devel] [PATCH v2 09/16] qapi-schema: Collect migration stuff in qapi/migration.json

2017-08-25 Thread Marc-André Lureau
On Thu, Aug 24, 2017 at 9:28 PM Markus Armbruster wrote: > Cc: Juan Quintela > Cc: Dr. David Alan Gilbert > Signed-off-by: Markus Armbruster > Reviewed-by: Marc-André Lureau --- > MAINTAINERS |1 + > Makefile|1 + > qapi-schema.json| 1056 > +

Re: [Qemu-devel] [PATCH v2 10/16] qapi-schema: Collect transaction stuff in qapi/transaction.json

2017-08-25 Thread Marc-André Lureau
On Thu, Aug 24, 2017 at 9:18 PM Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > Reviewed-by: Marc-André Lureau --- > MAINTAINERS | 1 + > Makefile | 1 + > qapi-schema.json | 151 > +-- > qapi/transacti

Re: [Qemu-devel] [PATCH for-2.11 2/6] ppc: make cpu_model translation to type consistent

2017-08-25 Thread David Gibson
On Fri, Aug 25, 2017 at 09:27:40AM +0200, Igor Mammedov wrote: > On Fri, 25 Aug 2017 11:38:19 +1000 > David Gibson wrote: > > > On Thu, Aug 24, 2017 at 10:21:47AM +0200, Igor Mammedov wrote: > > > PPC handles -cpu FOO rather incosistently, > > > i.e. it does case-insensitive matching of FOO to >

Re: [Qemu-devel] [PATCH v2 08/16] qapi-schema: Collect UI stuff in qapi/ui.json

2017-08-25 Thread Gerd Hoffmann
On Thu, 2017-08-24 at 21:14 +0200, Markus Armbruster wrote: > UI stuff is remote desktop stuff (Spice, VNC) and input stuff (mouse, > keyboard). > > Cc: Gerd Hoffmann > Signed-off-by: Markus Armbruster Reviewed-by: Gerd Hoffmann cheers, Gerd

Re: [Qemu-devel] [PATCH v11 2/6] ACPI: Add APEI GHES Table Generation support

2017-08-25 Thread gengdongjiu
Hi Shannon, On 2017/8/24 21:03, Shannon Zhao wrote: > > > On 2017/8/18 22:23, Dongjiu Geng wrote: >> This implements APEI GHES Table by passing the error CPER info >> to the guest via a fw_cfg_blob. After a CPER info is recorded, an >> SEA(Synchronous External Abort)/SEI(SError Interrupt) except

Re: [Qemu-devel] [PATCH v2 11/16] qapi-schema: Collect TPM stuff in qapi/tpm.json

2017-08-25 Thread Marc-André Lureau
On Thu, Aug 24, 2017 at 9:23 PM Markus Armbruster wrote: > Sadly, we don't have a TPM maintainer, not even a MAINTAINERS entry. > Create one, and mark it orphaned. > > This is also proposed in: http://patchew.org/QEMU/20170728053610.15770-1-f4...@amsat.org/ Stefan Berger, any chance you declare

Re: [Qemu-devel] [PATCH v11 3/6] ACPI: build and enable APEI GHES in the Makefile and configuration

2017-08-25 Thread gengdongjiu
On 2017/8/24 21:04, Shannon Zhao wrote: > > > On 2017/8/18 22:23, Dongjiu Geng wrote: >> Add CONFIG_ACPI_APEI configuration in the Makefile and >> enable it in the arm-softmmu.mak >> >> Signed-off-by: Dongjiu Geng >> --- >> default-configs/arm-softmmu.mak | 1 + >> hw/acpi/Makefile.objs

Re: [Qemu-devel] [PATCH] vga: stop passing pointers to vga_draw_line* functions

2017-08-25 Thread Gerd Hoffmann
Hi, > s/simliar/similar/ > s/priviledged/privileged/ Fixed. > > a segfault, when hitting the guard page after vga memory > > allocation, while reading vga memory for display updates. > > > > Fixes: CVE-2017- > > Do we have the actual number? Not yet, pjp still busy getting one, but will

Re: [Qemu-devel] [PATCH v2 13/16] qapi-schema: Fold event.json back into qapi-schema.json

2017-08-25 Thread Marc-André Lureau
On Thu, Aug 24, 2017 at 9:17 PM Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > Looks like you tried to find a reasonable location in the file for each events. Reviewed-by: Marc-André Lureau > --- > Makefile | 2 +- > qapi-schema.json | 134 > +

Re: [Qemu-devel] [PATCH v2 12/16] qapi-schema: Move block events from event.json to block.json

2017-08-25 Thread Marc-André Lureau
On Thu, Aug 24, 2017 at 9:25 PM Markus Armbruster wrote: > Cc: Alberto Garcia > Signed-off-by: Markus Armbruster > Reviewed-by: Marc-André Lureau > --- > qapi/block.json | 68 > + > qapi/event.json | 68 >

Re: [Qemu-devel] [PATCH v2 14/16] qapi-schema: Make block-core.json self-contained

2017-08-25 Thread Marc-André Lureau
On Thu, Aug 24, 2017 at 9:15 PM Markus Armbruster wrote: > Except for block-core.json, the sub-schemas are self-contained: if > they use a symbol defined in another sub-schema, they include that > sub-schema. To check, feed the sub-schema to qapi2texi (or any other > QAPI generator) along with t

Re: [Qemu-devel] [PATCH v2 15/16] qapi-schema: Move queries from common.json to qapi-schema.json

2017-08-25 Thread Marc-André Lureau
Hi On Thu, Aug 24, 2017 at 9:20 PM Markus Armbruster wrote: > query-version and query-commands are in common.json for no good > reason. Several similar queries are in qapi-schema.json. Move them > there. > > I suppose it was initially meant to be shared with all QMP users, qga etc? That didn't

Re: [Qemu-devel] [PATCH v2 16/16] qapi-schema: Improve section headings

2017-08-25 Thread Marc-André Lureau
On Thu, Aug 24, 2017 at 9:14 PM Markus Armbruster wrote: > The generated QEMU QMP reference is now structured as follows: > > 1.1 Introduction > 1.2 Stability Considerations > 1.3 Common data types > 1.4 Socket data types > 1.5 VM run state > 1.6 Cryptography > 1.7 Blo

Re: [Qemu-devel] [PATCH for-2.11 2/6] ppc: make cpu_model translation to type consistent

2017-08-25 Thread Igor Mammedov
On Fri, 25 Aug 2017 19:45:38 +1000 David Gibson wrote: > On Fri, Aug 25, 2017 at 09:27:40AM +0200, Igor Mammedov wrote: > > On Fri, 25 Aug 2017 11:38:19 +1000 > > David Gibson wrote: > > > > > On Thu, Aug 24, 2017 at 10:21:47AM +0200, Igor Mammedov wrote: > > > > PPC handles -cpu FOO rather

Re: [Qemu-devel] [PATCH for-2.11 5/6] ppc: simplify cpu model lookup by PVR

2017-08-25 Thread Igor Mammedov
On Fri, 25 Aug 2017 19:32:29 +1000 David Gibson wrote: > On Fri, Aug 25, 2017 at 09:40:37AM +0200, Igor Mammedov wrote: > > On Fri, 25 Aug 2017 14:16:44 +1000 > > David Gibson wrote: > > > > > On Thu, Aug 24, 2017 at 10:21:50AM +0200, Igor Mammedov wrote: > > > > Signed-off-by: Igor Mammedo

[Qemu-devel] wrong ioctl error handling on dirty pages sync?

2017-08-25 Thread Ján Poctavek
Hi guys, Maybe it is just my lack of understanding, this seems like a bug to me: To get list of dirty pages, qemu calls kvm_vm_ioctl() with KVM_GET_DIRTY_LOG: https://github.com/qemu/qemu/blob/v2.10.0-rc4/accel/kvm/kvm-all.c#L494 and considers the ioctl call failed when -1 is returned. But t

[Qemu-devel] [PATCH for-2.11] aux-to-i2c-bridge: don't allow user to create one

2017-08-25 Thread KONRAD Frederic
This device is private and is created once per aux-bus. So don't allow the user to create one from command-line. Reported-by: Thomas Huth Signed-off-by: KONRAD Frederic --- hw/misc/auxbus.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/misc/auxbus.c b/hw/misc/auxbus.c inde

Re: [Qemu-devel] [PATCH for-2.11] aux-to-i2c-bridge: don't allow user to create one

2017-08-25 Thread Thomas Huth
On 25.08.2017 13:46, KONRAD Frederic wrote: > This device is private and is created once per aux-bus. > So don't allow the user to create one from command-line. > > Reported-by: Thomas Huth > Signed-off-by: KONRAD Frederic > --- > hw/misc/auxbus.c | 11 +++ > 1 file changed, 11 insertio

Re: [Qemu-devel] [PATCH for-2.11 v3 01/25] qom: cpu: fix parsed feature string length

2017-08-25 Thread Philippe Mathieu-Daudé
On 08/25/2017 05:11 AM, Igor Mammedov wrote: Philippe Mathieu-Daudé wrote: On 08/24/2017 01:31 PM, Igor Mammedov wrote: since commit ( 9262685b cpu: Factor out cpu_generic_init() ) features parsed by it were truncated only to the 1st feature after CPU name due to fact that featurestr = s

Re: [Qemu-devel] [Qemu-arm] [PATCH 4/8] boards.h: Define new flag ignore_memory_transaction_failures

2017-08-25 Thread Peter Maydell
On 24 August 2017 at 21:28, Richard Henderson wrote: > Peter and I had a chat on IRC about this. > > While I think the background region idea is tempting, it does nothing to help > legacy boards once devices start signaling their own errors. Therefore some > sort of flag is the only reasonable so

Re: [Qemu-devel] Persistent bitmaps for non-qcow2 formats

2017-08-25 Thread Vladimir Sementsov-Ogievskiy
25.08.2017 03:55, John Snow wrote: Sorry in advance for :words: ... On 08/23/2017 02:04 PM, Vladimir Sementsov-Ogievskiy wrote: 23.08.2017 11:59, Vladimir Sementsov-Ogievskiy wrote: 22.08.2017 22:07, John Snow wrote: Well, we knew we'd want this sooner or later. I've got some pings downstream

Re: [Qemu-devel] [PATCH v2 1/3] vl: Clean up user-creatable objects when exiting

2017-08-25 Thread Philippe Mathieu-Daudé
On 08/24/2017 04:23 PM, Eduardo Habkost wrote: Delete all user-creatable objects in /objects when exiting QEMU, so they can perform cleanup actions. Signed-off-by: Eduardo Habkost Acked-by: Philippe Mathieu-Daudé --- Changes v1 -> v2: * (none) --- include/qom/object_interfaces.h | 8

Re: [Qemu-devel] [PATCH qemu] pci: Initialize pci_dev->name before use

2017-08-25 Thread Philippe Mathieu-Daudé
On 08/25/2017 12:21 AM, Alexey Kardashevskiy wrote: This moves pci_dev->name initialization earlier so pci_dev->bus_master_as could get a name instead of empry string. Signed-off-by: Alexey Kardashevskiy Reviewed-by: Philippe Mathieu-Daudé --- hw/pci/pci.c | 2 +- 1 file changed, 1 inse

Re: [Qemu-devel] [RFC v2 04/32] qemu_ram_block_host_offset

2017-08-25 Thread Philippe Mathieu-Daudé
Hi David, On 08/24/2017 04:27 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Utility to give the offset of a host pointer within a RAMBlock (assuming we already know it's in that RAMBlock) Signed-off-by: Dr. David Alan Gilbert --- exec.c| 10

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.10.0-rc4 is now available

2017-08-25 Thread Laszlo Ersek
On 08/25/17 11:15, Paolo Bonzini wrote: > On 25/08/2017 11:13, Peter Maydell wrote: >> On 24 August 2017 at 20:06, Laszlo Ersek wrote: >>> Has it not been the intent to include the following patch in 2.10: >>> >>> [PATCH] scsi-bus: correct responses for INQUIRY and REQUEST SENSE >>> http://lis

Re: [Qemu-devel] [PATCH 1/3] qemu.py: make VM() a context manager

2017-08-25 Thread Eduardo Habkost
On Thu, Aug 24, 2017 at 08:22:00AM +0100, Stefan Hajnoczi wrote: > There are a number of ways to ensure that the QEMU process is shut down > when the test ends, including atexit.register(), try: finally:, or > unittest.teardown() methods. All of these require extra code and the > programmer must r

Re: [Qemu-devel] [PATCH 01/14] qdict: add qdict_put_null() helper

2017-08-25 Thread Eduardo Habkost
On Thu, Aug 24, 2017 at 12:33:37PM +0200, Marc-André Lureau wrote: > A step towards completeness. > > Signed-off-by: Marc-André Lureau Reviewed-by: Eduardo Habkost -- Eduardo

[Qemu-devel] Make NVME device "migratable" (savevm)

2017-08-25 Thread Sergei Dyshel
Hi all, >From what I understand, I can't "savevm" a VM that uses NVME device because it has ".unmigratable = 1" in the code. What support must be implemented in order to make it "migratable"? -- Regards, Sergei Dyshel

Re: [Qemu-devel] [PATCH v2 01/54] qapi: fix type_seen key error

2017-08-25 Thread Eduardo Habkost
On Fri, Aug 25, 2017 at 08:02:26AM +0200, Markus Armbruster wrote: > Conflicts with Eduardo's "[PATCH v2] qapi: Fix error handling code on > alternate conflict". > Message-Id: <20170717180926.14924-1-ehabk...@redhat.com> > > Marc-André, could you have a look? You can rebase your fix on top of > E

  1   2   3   >