Re: [Qemu-devel] [PATCH v3 2/5] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2017-08-22 Thread Aravinda Prasad
On Tuesday 22 August 2017 07:38 AM, David Gibson wrote: > On Mon, Aug 21, 2017 at 06:05:34PM +0530, Aravinda Prasad wrote: >> >> >> On Thursday 17 August 2017 07:09 AM, David Gibson wrote: >>> What's with the extra spaces in the subject line? >> >> I don't see any. Can you pls point out? > > I s

Re: [Qemu-devel] [PATCH v3 1/5] ppc: spapr: Register and handle HCALL to receive updated RTAS region

2017-08-22 Thread Aravinda Prasad
On Tuesday 22 August 2017 09:03 AM, David Gibson wrote: > On Mon, Aug 21, 2017 at 03:12:49PM +0530, Aravinda Prasad wrote: >> >> >> On Thursday 17 August 2017 07:04 AM, David Gibson wrote: >>> On Wed, Aug 16, 2017 at 02:42:13PM +0530, Aravinda Prasad wrote: Receive updates from SLOF about th

Re: [Qemu-devel] [PATCH V4 0/3] Optimize COLO-compare performance

2017-08-22 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1503305719-2512-1-git-send-email-zhangchen.f...@cn.fujitsu.com Subject: [Qemu-devel] [PATCH V4 0/3] Optimize COLO-compare performance === TEST SCRIPT BEGIN === #!/bin/bash B

Re: [Qemu-devel] [PATCH v4 0/4] scsi-block: Support werror/rerror

2017-08-22 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170821141008.19383-1-f...@redhat.com Subject: [Qemu-devel] [PATCH v4 0/4] scsi-block: Support werror/rerror === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node

2017-08-22 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170821200036.15036-1-bauer...@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node === TEST SCRIPT BEGIN === #!/

Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes

2017-08-22 Thread Markus Armbruster
John Snow writes: > On 08/18/2017 10:26 AM, Lukáš Doktor wrote: >> Hello guys, >> >> I'm reading the available python modules to exercise qemu and while reading >> them >> I fixed some issues that caught my attention. It usually starts with a simple >> pylint/docstring fixes and slowly graduate

[Qemu-devel] [PATCH] NUMA: Replace MAX_NODES with nb_numa_nodes in for loop

2017-08-22 Thread Dou Liyang
In QEMU, the number of the NUMA nodes is determined by parse_numa_opts(). Then, QEMU uses it for iteration, for example: for (i = 0; i < nb_numa_nodes; i++) However, in memory_region_allocate_system_memory(), it uses MAX_NODES not nb_numa_nodes. So, replace MAX_NODES with nb_numa_nodes to keep

Re: [Qemu-devel] [PATCH v3 00/10] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)

2017-08-22 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170822044155.2451-1-f...@redhat.com Subject: [Qemu-devel] [PATCH v3 00/10] tests: Add VM based build tests (for non-x86_64 and/or non-Linux) === TEST SCRIPT BEGIN === #!/b

Re: [Qemu-devel] [PATCH] xen: Emit RTC_CHANGE upon TIMEOFFSET ioreq

2017-08-22 Thread Ross Lagerwall
On 08/21/2017 11:30 PM, Stefano Stabellini wrote: On Mon, 21 Aug 2017, Ross Lagerwall wrote: When the guest writes to the RTC, Xen emulates it and broadcasts a TIMEOFFSET ioreq. Emit an RTC_CHANGE QMP message when this happens rather than ignoring it so that something useful can be done with the

Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread

2017-08-22 Thread Dr. David Alan Gilbert
* Fam Zheng (f...@redhat.com) wrote: > On Tue, 08/22 13:59, Peter Xu wrote: > > On Tue, Aug 22, 2017 at 12:15:19PM +0800, Fam Zheng wrote: > > > On Tue, 08/22 10:56, Peter Xu wrote: > > > > I haven't really encountered (c), but I think it's the migrate_cancel > > > > command that matters, which sho

Re: [Qemu-devel] [PATCH] qobject: Explain how QNum works, and why

2017-08-22 Thread Marc-André Lureau
- Original Message - > Suggested-by: Max Reitz > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau > --- > include/qapi/qmp/qnum.h | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/include/qapi/qmp/qnum.h b/include/qapi/qmp/qnum.h > inde

Re: [Qemu-devel] [Qemu-arm] [PATCH 4/8] boards.h: Define new flag ignore_memory_transaction_failures

2017-08-22 Thread Peter Maydell
On 22 August 2017 at 04:45, Philippe Mathieu-Daudé wrote: > On 08/17/2017 07:25 AM, Peter Maydell wrote: >> >> On 5 August 2017 at 11:13, Peter Maydell wrote: >> So, this question (should we have a board flag to disable reporting >> of tx failures to the CPU hook, or use unimplemented_device as a

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-22 Thread Cornelia Huck
On Mon, 21 Aug 2017 18:24:15 +0200 Halil Pasic wrote: > On 08/21/2017 04:58 PM, Pierre Morel wrote: > > On 21/08/2017 11:16, Cornelia Huck wrote: > >> If we do not provide zpci, pci reconfiguration via sclp is not available > >> either. Don't indicate it in the sclp facilities and return an inv

Re: [Qemu-devel] [PATCH] audio: intel-hda: do not use old_mmio accesses

2017-08-22 Thread Peter Maydell
On 21 August 2017 at 22:13, Matt Parker wrote: > intel-hda is still using the old_mmio accessors for io. > This updates the device to use .read and .write accessors instead. Hi; thanks for this patch. It looks like you forgot to provide your Signed-off-by: line; we can't accept patches without o

Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator

2017-08-22 Thread Peter Maydell
On 22 August 2017 at 02:09, David Gibson wrote: > On Wed, Aug 16, 2017 at 12:18:07PM +0100, Peter Maydell wrote: >> On 16 August 2017 at 11:51, Paolo Bonzini wrote: >> > On 16/08/2017 10:26, Cornelia Huck wrote: >> >> Prefer to use the tcg accelarator if it is available: This is our only >> >> re

Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread

2017-08-22 Thread Fam Zheng
On Tue, 08/22 09:29, Dr. David Alan Gilbert wrote: > * Fam Zheng (f...@redhat.com) wrote: > > On Tue, 08/22 13:59, Peter Xu wrote: > > > On Tue, Aug 22, 2017 at 12:15:19PM +0800, Fam Zheng wrote: > > > > On Tue, 08/22 10:56, Peter Xu wrote: > > > > > I haven't really encountered (c), but I think it

[Qemu-devel] [PATCHv4 02/03] colo-compare: Use IOThread to Check old packet regularly and Process pactkets of the primary

2017-08-22 Thread Wang yong
From: Wang Yong Remove the task which check old packet in the comparing thread, then use IOthread context timer to handle it. Process pactkets in the IOThread which arrived over the socket. we use iothread_get_g_main_context to create a new g_main_loop in the IOThread.then the packets from the p

Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator

2017-08-22 Thread Laurent Vivier
On 22/08/2017 10:47, Peter Maydell wrote: > On 22 August 2017 at 02:09, David Gibson wrote: >> On Wed, Aug 16, 2017 at 12:18:07PM +0100, Peter Maydell wrote: >>> On 16 August 2017 at 11:51, Paolo Bonzini wrote: On 16/08/2017 10:26, Cornelia Huck wrote: > Prefer to use the tcg accelarator

[Qemu-devel] [PATCHv4 01/03] qemu-iothread: IOThread supports the GMainContext event loop

2017-08-22 Thread Wang yong
From: Wang Yong IOThread uses AioContext event loop and does not run a GMainContext. Therefore,chardev cannot work in IOThread,such as the chardev is used for colo-compare packets reception. This patch makes the IOThread run the GMainContext event loop, chardev and IOThread can work together. S

Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread

2017-08-22 Thread Dr. David Alan Gilbert
* Fam Zheng (f...@redhat.com) wrote: > On Tue, 08/22 10:56, Peter Xu wrote: > > I haven't really encountered (c), but I think it's the migrate_cancel > > command that matters, which should not need BQL as well. > > There is bdrv_invalidate_cache_all() in migrate_cancel which clearly isn't > safe.

[Qemu-devel] [PATCHv4 03/03] colo-compare: Update the COLO document to add the IOThread configuration

2017-08-22 Thread Wang yong
From: Wang Yong Update colo-proxy.txt,add IOThread configuration. Later we have to configure IOThread,if not COLO can not work. Signed-off-by: Wang Yong Signed-off-by: Wang Guang --- docs/colo-proxy.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/colo-proxy.txt

[Qemu-devel] [PATCHv4 00/03] Replace the COLO comparing thread with IOThread

2017-08-22 Thread Wang yong
From: Wang Yong It's a good idea to use IOThread instead of COLO comparing thread. comparing thread can be completely replaced by IOThread, so this idea came. This series of updates mainly include IOThread supports the GMainContext event loop, then the old packet regularly check and primary/seco

Re: [Qemu-devel] [RFC PATCH 0/9] TCG Vector types and example conversion

2017-08-22 Thread Kirill Batuzov
On Fri, 18 Aug 2017, Richard Henderson wrote: > On 08/18/2017 04:33 AM, Kirill Batuzov wrote: > > From my own experimentations some times ago, > > > > (1) translating vector instructions to vector instructions in TCG is faster > > than > > > > (2) translating vector instructions to series of sc

Re: [Qemu-devel] [PATCH v4 02/10] kvm: remove hard dependency on pci

2017-08-22 Thread Cornelia Huck
On Mon, 21 Aug 2017 18:02:12 +0200 Pierre Morel wrote: > On 21/08/2017 11:16, Cornelia Huck wrote: > > The msi routing code in kvm calls some pci functions: provide > > some stubs to enable builds without pci. > > > > Also, to make this more obvious, guard them via a pci_available boolean > > (w

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-22 Thread ChristianEhrhardt
Via a watchpoints I found that the error is set by qemu_fill_buffer. b qemu_loadvm_state handle SIGUSR1 nostop noprint pass c # on the break check and watch the status (gdb) p f $1 = (QEMUFile *) 0xb9babb3c00 (gdb) p *f $2 = {ops = 0xb9b89880a0 , hooks = 0x0, opaque = 0xb9bbabfe00, bytes_xfer = 0

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-22 Thread ChristianEhrhardt
Sure, but initially I wanted to see what is going on overall so I let it pop up. Started a debugging another session today. First I confirmed with (gdb) catch syscall exit exit_group That this is the "normal" exit along the error message we knew: migrate_set_state(&mis->state, MIGRATION_STA

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-22 Thread ChristianEhrhardt
So this is failing I/O that iterates over a channel. I was tracking down the len, pending and pos used. I found that this is not completely broken (like no access or generla I/O error) It starts at pos 0 and iterated with varying offsets, but works for quite some time. Example: [...] Thread 1 "q

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-22 Thread ChristianEhrhardt
(gdb) handle SIGUSR1 nostop noprint pass (gdb) b migration/qemu-file.c:295 (gdb) command p f->pos c end That showed the pos is ever increasing and fails at an offset it never read before. Yet the absolute number was different. $1 = 0 $2 = 8948 $3 = 41423 [...] $11359 = 326387440 $11360 = 32642020

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-22 Thread ChristianEhrhardt
So TL;DR summary for now: - error triggers in qio_channel_read - file is migration-socket-incoming - reads work a while, but then fail at high f->pos offsets (slightly different ones each time) - slower execution seems to lead to slightly higher offsets that are failing - only happens on --copy-st

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-22 Thread Halil Pasic
On 08/22/2017 10:39 AM, Cornelia Huck wrote: >> I'm fine either way. If I imagine having a lots of adapter types, then I >> would expect a switch or a jumptable on the type before handling control >> to the pci specific function. In this case statically not supported types >> would probably get c

Re: [Qemu-devel] [PULL 0/7] ppc-for-2.10 queue 20170822

2017-08-22 Thread Peter Maydell
qemu.git tags/ppc-for-2.10-20170822 > > for you to fetch changes up to d3234e2851f1630c695c681beac1e87ac0881260: > > hw/ppc/spapr_iommu: Fix crash when removing the "spapr-tce-table" device > (2017-08-22 11:11:30 +1000) > > -

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-22 Thread Dr. David Alan Gilbert
OK, so that looks like a real case of the migration stream failing and getting an IO error; so the question is why: a) Is the source qemu dieing first and closing the socket? b) Is libvirt closing the socket for some reason -- You received this bug notification because you are a member of qe

Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator

2017-08-22 Thread Peter Maydell
On 22 August 2017 at 09:49, Laurent Vivier wrote: > On 22/08/2017 10:47, Peter Maydell wrote: >> On 22 August 2017 at 02:09, David Gibson wrote: >>> On Wed, Aug 16, 2017 at 12:18:07PM +0100, Peter Maydell wrote: On 16 August 2017 at 11:51, Paolo Bonzini wrote: > On 16/08/2017 10:26, Cor

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-22 Thread Cornelia Huck
On Tue, 22 Aug 2017 11:20:51 +0200 Halil Pasic wrote: > On 08/22/2017 10:39 AM, Cornelia Huck wrote: > >> I'm fine either way. If I imagine having a lots of adapter types, then I > >> would expect a switch or a jumptable on the type before handling control > >> to the pci specific function. In th

Re: [Qemu-devel] [PULL 0/7] ppc-for-2.10 queue 20170822

2017-08-22 Thread Laurent Vivier
vailable in the git repository at: >> >> git://github.com/dgibson/qemu.git tags/ppc-for-2.10-20170822 >> >> for you to fetch changes up to d3234e2851f1630c695c681beac1e87ac0881260: >> >> hw/ppc/spapr_iommu: Fix crash when

Re: [Qemu-devel] [PATCHv4 01/03] qemu-iothread: IOThread supports the GMainContext event loop

2017-08-22 Thread Fam Zheng
On Tue, 08/22 16:46, Wang yong wrote: > From: Wang Yong > > IOThread uses AioContext event loop and does not run a GMainContext. > Therefore,chardev cannot work in IOThread,such as the chardev is > used for colo-compare packets reception. > > This patch makes the IOThread run the GMainContext ev

[Qemu-devel] Why I got "timeout" while using qga socket to connect VM?

2017-08-22 Thread Sam
Hi all, I start VM using command like this: -chardev socket,path=/home/gangyewei-3/kvm/qga.sock,server,nowait,id=qga0 > -device virtio-serial -device > virtserialport,chardev=qga0,name=org.qemu.guest_agent.0 But When I use socat to send command ( https://wiki.qemu.org/Features/GuestAgent), it b

Re: [Qemu-devel] [PULL 0/7] ppc-for-2.10 queue 20170822

2017-08-22 Thread Peter Maydell
0.0-rc3 release (2017-08-15 18:53:31 +0100) >>> >>> are available in the git repository at: >>> >>> git://github.com/dgibson/qemu.git tags/ppc-for-2.10-20170822 >>> >>> for you to fetch changes up to d3234e2851f1630c695c681beac1e87ac0881260: >

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-22 Thread Dr. David Alan Gilbert
also, you might want to chase it a bit further down, I think we've got: qemu-file-channel.c:channel_get_buffer io/channel-socket.c or io/channel-file.c qio_channel_file_readv it would be good to know what the readv/readmsg is actually returning in the case where it's failing. Dave

Re: [Qemu-devel] Why I got "timeout" while using qga socket to connect VM?

2017-08-22 Thread Sam
whole command is : /usr/local/kvm/bin/qemu-system-x86_64 -smp 4 -m 4096 -enable-kvm > /home/gangyewei-3/kvm/centos6.6_2.img -cdrom > /home/gangyewei-3/kvm/CentOS-7-x86_64-DVD-1503-01.iso -daemonize -vnc > 0.0.0.0:2520 -chardev > socket,id=char-client-07-1,path=/usr/local/var/run/openvswitch/client

Re: [Qemu-devel] [PATCH] hw/arm/allwinner: Fix crash with -nodefaults -M cubieboard

2017-08-22 Thread Thomas Huth
On 18.08.2017 19:14, Peter Maydell wrote: > On 18 August 2017 at 18:08, Thomas Huth wrote: >> The allwinner-a10 device uses serial_hds[0] without checking whether >> it is available or not. So using the cubieboard with -nodefaults >> currently results in a segmentation fault. Fix it by adding a >>

[Qemu-devel] [PATCH v7 0/6] add throttle block driver filter

2017-08-22 Thread Manos Pitsidianakis
This series adds a throttle block driver filter. Currently throttling is done at the BlockBackend level. Using block driver interfaces we can move the throttling to any point in the BDS graph using a throttle node which uses the existing throttling code. This allows for potentially more complex con

[Qemu-devel] [PATCH v7 1/6] block: move ThrottleGroup membership to ThrottleGroupMember

2017-08-22 Thread Manos Pitsidianakis
This commit eliminates the 1:1 relationship between BlockBackend and throttle group state. Users will be able to create multiple throttle nodes, each with its own throttle group state, in the future. The throttle group state cannot be per-BlockBackend anymore, it must be per-throttle node. This i

[Qemu-devel] [PATCH v7 3/6] block: tidy ThrottleGroupMember initializations

2017-08-22 Thread Manos Pitsidianakis
Move the CoMutex and CoQueue inits inside throttle_group_register_tgm() which is called whenever a ThrottleGroupMember is initialized. There's no need for them to be separate. Reviewed-by: Alberto Garcia Reviewed-by: Stefan Hajnoczi Signed-off-by: Manos Pitsidianakis --- block/block-backend.c

[Qemu-devel] [PATCH v7 6/6] qemu-iotests: add 184 for throttle filter driver

2017-08-22 Thread Manos Pitsidianakis
Signed-off-by: Manos Pitsidianakis --- tests/qemu-iotests/184 | 205 +++ tests/qemu-iotests/184.out | 300 + tests/qemu-iotests/group | 1 + 3 files changed, 506 insertions(+) create mode 100755 tests/qemu-iotests/18

[Qemu-devel] [PATCH v7 2/6] block: add aio_context field in ThrottleGroupMember

2017-08-22 Thread Manos Pitsidianakis
timer_cb() needs to know about the current Aio context of the throttle request that is woken up. In order to make ThrottleGroupMember backend agnostic, this information is stored in an aio_context field instead of accessing it from BlockBackend. Reviewed-by: Alberto Garcia Reviewed-by: Stefan Haj

Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes

2017-08-22 Thread Philippe Mathieu-Daudé
On 08/22/2017 04:24 AM, Markus Armbruster wrote: John Snow writes: [...] Looks like all ten patches have an R-B despite changes; but it looks like nothing particularly major was changed anyway. Does this fall under Markus's jurisdiction? (Well, except for qtest.py which seemingly has double

[Qemu-devel] [PATCH v7 5/6] block: add throttle block filter driver

2017-08-22 Thread Manos Pitsidianakis
block/throttle.c uses existing I/O throttle infrastructure inside a block filter driver. I/O operations are intercepted in the filter's read/write coroutines, and referred to block/throttle-groups.c The driver can be used with the syntax -drive driver=throttle,file.filename=foo.qcow2,throttle-grou

Re: [Qemu-devel] [PATCH v7 02/11] qemu.py: avoid writing to stdout/stderr

2017-08-22 Thread Fam Zheng
On Fri, 08/18 19:05, Amador Pahim wrote: > This module should not write directly to stdout/stderr. Instead, it > should either raise exceptions or just log the messages and let the > callers handle them and decide what to do. For example, scripts could > choose to send the log messages stderr or/an

[Qemu-devel] [PATCH v7 4/6] block: convert ThrottleGroup to object with QOM

2017-08-22 Thread Manos Pitsidianakis
ThrottleGroup is converted to an object. This will allow the future throttle block filter drive easy creation and configuration of throttle groups in QMP and cli. A new QAPI struct, ThrottleLimits, is introduced to provide a shared struct for all throttle configuration needs in QMP. ThrottleGroup

Re: [Qemu-devel] [PATCH v7 03/11] qemu.py: use os.path.null instead of /dev/null

2017-08-22 Thread Fam Zheng
On Fri, 08/18 19:05, Amador Pahim wrote: > For increased portability, let's use os.path.devnull. > > Signed-off-by: Amador Pahim > --- > scripts/qemu.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/qemu.py b/scripts/qemu.py > index ef531bb23b..51545f7f97

Re: [Qemu-devel] [PATCH v2 3/6] block: require job-id when device is a node name

2017-08-22 Thread Alberto Garcia
On Mon 21 Aug 2017 05:39:48 PM CEST, Manos Pitsidianakis wrote: >>> -if (job_id == NULL && !(flags & BLOCK_JOB_INTERNAL)) { >>> -job_id = bdrv_get_device_name(bs); >>> -if (!*job_id) { >>> -error_setg(errp, "An explicit job ID is required for this >>> node"); >>> -

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-22 Thread ChristianEhrhardt
I'll track down the actual read and then add debugging the source at the same time (that should be the best way to track the migration socket on both sides). This might be slightly tricky since I don't know exactly on which offset but I can surely start over 310*10^6 it seems. I'll report back o

Re: [Qemu-devel] [PATCH v2 3/6] block: require job-id when device is a node name

2017-08-22 Thread Manos Pitsidianakis
On Tue, Aug 22, 2017 at 11:57:28AM +0200, Alberto Garcia wrote: On Mon 21 Aug 2017 05:39:48 PM CEST, Manos Pitsidianakis wrote: -if (job_id == NULL && !(flags & BLOCK_JOB_INTERNAL)) { -job_id = bdrv_get_device_name(bs); -if (!*job_id) { -error_setg(errp, "An expli

Re: [Qemu-devel] [PATCH v7 09/11] qemu.py: launch vm only if it's not running

2017-08-22 Thread Fam Zheng
On Fri, 08/18 19:05, Amador Pahim wrote: > A new call to launch() with a running VM will fall in exception and > consequently call shutdown(). > > This patch makes launch() to raise an exception when it's called with VM > already running. > > Signed-off-by: Amador Pahim > --- > scripts/qemu.py

Re: [Qemu-devel] [PATCH] nvme: Fix get/set number of queues feature, again

2017-08-22 Thread Stefan Hajnoczi
On Sun, May 28, 2017 at 04:06:49PM +0300, Dan Aloni wrote: > The number of queues that should be return by the admin command should: > > 1) Only mention the number of non-admin queues. > 2) It is zero-based, meaning that '0 == one non-admin queue', > '1 == two non-admin queues', and so fo

Re: [Qemu-devel] [PULL 0/7] ppc-for-2.10 queue 20170822

2017-08-22 Thread Laurent Vivier
t;>> 1f296733876434118fd766cfef5eb6f29ecab6a8: >>>> >>>> Update version for v2.10.0-rc3 release (2017-08-15 18:53:31 +0100) >>>> >>>> are available in the git repository at: >>>> >>>> git://github.com/dgibson/qemu.git tags/

Re: [Qemu-devel] [PULL 0/7] ppc-for-2.10 queue 20170822

2017-08-22 Thread Peter Maydell
On 22 August 2017 at 11:41, Laurent Vivier wrote: > On 22/08/2017 11:53, Peter Maydell wrote: >> On 22 August 2017 at 10:43, Laurent Vivier wrote: >>> On 22/08/2017 11:34, Peter Maydell wrote: I get a make check failure on ppc64 Linux: TEST: tests/postcopy-test... (pid=12468)

Re: [Qemu-devel] [PATCH v2 3/6] block: require job-id when device is a node name

2017-08-22 Thread Alberto Garcia
On Tue 22 Aug 2017 12:31:26 PM CEST, Manos Pitsidianakis wrote: > On Tue, Aug 22, 2017 at 11:57:28AM +0200, Alberto Garcia wrote: >>On Mon 21 Aug 2017 05:39:48 PM CEST, Manos Pitsidianakis wrote: > -if (job_id == NULL && !(flags & BLOCK_JOB_INTERNAL)) { > -job_id = bdrv_get_devi

[Qemu-devel] [Bug 1663287] Re: Illegal delay slot code causes abort on mips64

2017-08-22 Thread Brian Campbell
Thanks for that fix. I've just noticed that the second part, in gen_compute_branch1, wasn't included, though. Could you take a look at it? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1663287 Titl

Re: [Qemu-devel] [PATCH v3 01/10] gitignore: Ignore vm test images

2017-08-22 Thread Philippe Mathieu-Daudé
Hi Fam, On 08/22/2017 01:41 AM, Fam Zheng wrote: Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index cf65316863..693e2f3009 100644 --- a/.gitignore +++ b/.gitignore @@ -52,6 +52,8 @@ /vscc

Re: [Qemu-devel] [PATCH 09/15] hw/ide: Emulate SiI3112 SATA controller

2017-08-22 Thread BALATON Zoltan
Hello, Thanks for the review. On Mon, 21 Aug 2017, John Snow wrote: On 08/20/2017 01:23 PM, BALATON Zoltan wrote: This is a common generic PCI SATA conroller that is also used in PCs but more importantly guests running on the Sam460ex board prefer this card and have a driver for it (unlike for

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-22 Thread Dr. David Alan Gilbert
Hmm i just tried to reproduce this and hit (on the source): main_channel_client_handle_migrate_connected: client 0x5607d785f610 connected: 0 seamless 0 qemu-system-x86_64: /root/qemu/io/channel.c:303: qio_channel_yield: Assertion `!ioc->write_coroutine' failed. 2017-08-22 10:50:04.888+: shut

Re: [Qemu-devel] [PATCH v7 02/11] qemu.py: avoid writing to stdout/stderr

2017-08-22 Thread Amador Pahim
On Tue, Aug 22, 2017 at 12:24 PM, Fam Zheng wrote: > On Fri, 08/18 19:05, Amador Pahim wrote: >> This module should not write directly to stdout/stderr. Instead, it >> should either raise exceptions or just log the messages and let the >> callers handle them and decide what to do. For example, scr

Re: [Qemu-devel] [PATCH 03/26] qboject: add literal qobject type

2017-08-22 Thread Marc-André Lureau
Hi On Wed, Aug 16, 2017 at 10:59 AM, Markus Armbruster wrote: > In the subject: s/qboject: add/qobject: Add/ > > Marc-André Lureau writes: > >> Promote LiteralQObject from tests/check-qjson.c to qobject/qlit.c, >> allowing to statically declare complex qobjects. >> >> Add a helper qobject_from_q

Re: [Qemu-devel] [PATCH 04/26] qapi: generate a literal qobject for introspection

2017-08-22 Thread Marc-André Lureau
Hi On Wed, Aug 16, 2017 at 12:21 PM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Replace the generated json string with a literal qobject. The later is >> easier to deal with, at run time, as well as compile time: > > at run time as well as compile time > >>

Re: [Qemu-devel] [PATCH 05/26] visitor: pass size of strings array to enum visitor

2017-08-22 Thread Marc-André Lureau
hi On Wed, Aug 16, 2017 at 2:54 PM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> The size is known at compile time, this avoids having to compute to >> check array boundaries. >> >> Additionally, the following conditional enum entry change will create >> "hole" in the generated _loo

Re: [Qemu-devel] [PATCH 21/26] build-sys: make qemu qapi objects per-target

2017-08-22 Thread Marc-André Lureau
Hi On Thu, Aug 17, 2017 at 1:44 PM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> The qapi schema has per-target definitions. Move qapi objects in the >> per-target build, so they can be configured at compile time. > > Suggest something like: > > QAPI can't do target-specific con

Re: [Qemu-devel] [PATCH 07/26] qapi: add 'if' condition on top-level schema elements

2017-08-22 Thread Marc-André Lureau
Hi On Wed, Aug 16, 2017 at 5:43 PM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Add 'if' c-preprocessor condition on top-level schema elements: >> struct, enum, union, alternate, command, event. > > An example would be useful here. Your cover letter has nice ones, would > be a sha

Re: [Qemu-devel] [RFC PATCH 12/12] ppc: Add aCube Sam460ex board

2017-08-22 Thread BALATON Zoltan
On Tue, 22 Aug 2017, David Gibson wrote: On Fri, Aug 18, 2017 at 02:46:42PM +0200, BALATON Zoltan wrote: On Fri, 18 Aug 2017, David Gibson wrote: On Sun, Aug 13, 2017 at 07:04:38PM +0200, BALATON Zoltan wrote: Add emulation of aCube Sam460ex board based on AMCC 460EX embedded SoC. This is not

Re: [Qemu-devel] [PATCH 22/26] qapi: make rtc-reset-reinjection depend on TARGET_I386

2017-08-22 Thread Marc-André Lureau
Hi On Thu, Aug 17, 2017 at 1:57 PM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Signed-off-by: Marc-André Lureau >> --- >> qapi-schema.json | 3 ++- >> monitor.c| 10 -- >> 2 files changed, 2 insertions(+), 11 deletions(-) >> >> diff --git a/qapi-schema.json b/qa

Re: [Qemu-devel] [PATCH 18/26] qapi: add conditions to REPLICATION type/commands on the schema

2017-08-22 Thread Marc-André Lureau
Hi On Thu, Aug 17, 2017 at 11:16 AM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Add #if defined(CONFIG_REPLICATION) in generated code, and adjust the >> code accordingly. >> >> Signed-off-by: Marc-André Lureau >> --- >> qapi-schema.json | 12 >> migration/colo.c | 1

Re: [Qemu-devel] [PATCH 0/3]

2017-08-22 Thread Sameeh Jubran
Ping. On Sun, Aug 13, 2017 at 6:58 PM, Sameeh Jubran wrote: > From: Sameeh Jubran > > This series fixes qemu-ga's behaviour upon facing a missing serial/serial > driver by listening to the serial device's events. > > For more info on why this series is needed checkout the commit message > of th

Re: [Qemu-devel] [RFC PATCH] osdep.h: Prohibit disabling assert() in supported builds

2017-08-22 Thread Halil Pasic
On 08/19/2017 12:23 AM, Eric Blake wrote: > We already have several files that knowingly require assert() > to work. While we do NOT want to encourage the use of > 'assert(side-effects)' (that is a bad practice that prevents > copy-and-paste of code to other projects that CAN disable > assertion

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-22 Thread Dr. David Alan Gilbert
OK, 3rd try and I've hit the same behaviour as Christian. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1711602 Title: --copy-storage-all failing with qemu 2.10 Status in QEMU: New Status in lib

Re: [Qemu-devel] [RFC PATCH 02/56] qdict: New helpers to put and get unsigned integers

2017-08-22 Thread Marc-André Lureau
Hi Is this based on https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg01894.html ? If so, you should probably keep me signed-off. My patch had also a test :) - Original Message - > Signed-off-by: Markus Armbruster > --- > include/qapi/qmp/qdict.h | 5 + > qobject/qdict.c

Re: [Qemu-devel] [PATCH v3 03/10] tests: Add vm test lib

2017-08-22 Thread Philippe Mathieu-Daudé
Hi Fam, On 08/22/2017 01:41 AM, Fam Zheng wrote: This is the common code to implement a "VM test" to 1) Download and initialize a pre-defined VM that has necessary dependencies to build QEMU and SSH access. 2) Archive $SRC_PATH to a .tar file. 3) Boot the VM, and pass the source t

Re: [Qemu-devel] [PATCH 00/26] qapi: add #if pre-processor conditions to generated code

2017-08-22 Thread Marc-André Lureau
Hi On Thu, Aug 17, 2017 at 3:55 PM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Hi, >> >> In order to clean-up some hacks in qapi (having to unregister commands >> at runtime), I proposed a "[PATCH v5 02/20] qapi.py: add a simple #ifdef >> condition" >> >> (see http://lists.gnu.or

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-22 Thread Dr. David Alan Gilbert
(4th try) breakpoint on qemu_file_set_error, it's bdrv_inactivate_all that's returning the error. (gdb) list 1155if (inactivate_disks) { 1156/* Inactivate before sending QEMU_VM_EOF so that the 1157 * bdrv_invalidate_cache_all() on the other end won't fail. */ 1158

[Qemu-devel] [Bug 1708551] Re: macOS Guest Reading USB 3.0 Bus as USB 2.0

2017-08-22 Thread Gerd Hoffmann
xhci doesn't work with macos because macos has a white list of supported xhci controllers and ignores the xhci adapters emulated by qemu. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1708551 Title:

Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator

2017-08-22 Thread David Gibson
On Tue, Aug 22, 2017 at 10:35:17AM +0100, Peter Maydell wrote: > On 22 August 2017 at 09:49, Laurent Vivier wrote: > > On 22/08/2017 10:47, Peter Maydell wrote: > >> On 22 August 2017 at 02:09, David Gibson > >> wrote: > >>> On Wed, Aug 16, 2017 at 12:18:07PM +0100, Peter Maydell wrote: > O

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-22 Thread ChristianEhrhardt
Only now read comment #27, thanks David for reproducing with me, it is somewhat relieving that you seem to see the same. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1711602 Title: --copy-storage-

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-22 Thread ChristianEhrhardt
Stack from qemu_fill_buffer to qio_channel_socket_readv #0 qio_channel_socket_readv (ioc=, iov=, niov=, fds=0x0, nfds=0x0, errp=0x0) at ./io/channel-socket.c:477 #1 0x001486ec97e2 in qio_channel_read (ioc=ioc@entry=0x148a73a6c0, buf=buf@entry=\060\nLw", buflen=buflen@entry=28728, er

Re: [Qemu-devel] [RFC PATCH 04/56] char: Make ringbuf-read size unsigned in QAPI/QMP

2017-08-22 Thread Marc-André Lureau
Hi On Mon, Aug 7, 2017 at 4:45 PM, Markus Armbruster wrote: > Sizes should use QAPI type 'size' (uint64_t). ringbuf-read parameter > @size is 'int' (int64_t). qmp_ringbuf_read() rejects negative values, > then implicitly converts to size_t. > > Change the parameter to 'size' and drop the check

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-22 Thread ChristianEhrhardt
For me qemu_file_set_error was always called from qemu_fill_buffer, interesting that it seems different for you. I'll rerun a few times to ensure it really always is always from qemu_fill_buffer for me. -- You received this bug notification because you are a member of qemu- devel-ml, which is s

Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator

2017-08-22 Thread Cornelia Huck
On Tue, 22 Aug 2017 21:20:46 +1000 David Gibson wrote: > Obviously it's not a thing to fix right now, but I've really been > thinking that none of the tests should use this "TCG or KVM" stuff. > They should instead be run with *both* options - or at least the ones > that are available on the host

Re: [Qemu-devel] [PATCH v2 4/6] block: remove legacy I/O throttling

2017-08-22 Thread Alberto Garcia
On Wed 09 Aug 2017 04:02:54 PM CEST, Manos Pitsidianakis wrote: > +void blk_io_limits_update_group(BlockBackend *blk, const char *group, Error > **errp) > { > +ThrottleGroupMember *tgm; > + > /* this BB is not part of any group */ > -if (!blk->public.throttle_group_member.throttle_st

Re: [Qemu-devel] [PATCH v7 0/4] Generic PCIE-PCI Bridge

2017-08-22 Thread Marcel Apfelbaum
On 18/08/2017 2:36, Aleksandr Bezzubikov wrote: This series introduces a new device - Generic PCI Express to PCI bridge, and also makes all necessary changes to enable hotplug of the bridge itself and any device into the bridge. Hi, Series Tested-by: Marcel Apfelbaum (focused on changes f

Re: [Qemu-devel] [PATCH v7 02/11] qemu.py: avoid writing to stdout/stderr

2017-08-22 Thread Fam Zheng
On Tue, 08/22 13:11, Amador Pahim wrote: > I don't think that the 'keep the behavior' principle should overcome > what the messages actually are. The question is: are they warning > messages? The way I see, the messages I changed in this commit to use > the logging system are both debug messages.

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-22 Thread Dr. David Alan Gilbert
The difference with the qemu_file_set_error is I'm looking on the source - because what's happening is the source is erroring so closing the socket, and so the error you're seeing on the destination is real - the socket just EOF'd! -- You received this bug notification because you are a member of

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-22 Thread Dr. David Alan Gilbert
repeated the assert in #26: Program received signal SIGABRT, Aborted. 0x7f02163005f7 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 56return INLINE_SYSCALL (tgkill, 3, pid, selftid, sig); (gdb) where #0 0x7f02163005f7 in __GI_raise (sig=sig@entry=6)

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-22 Thread ChristianEhrhardt
In 5/5 tries this was on qemu_fill_buffer for my case. But that was on the receiving side, and what you found is closer to the root cause on the source of the migration. I checked on qemu_file_set_error on the source and can confirm your finding that on the source it is from bdrv_inactivate_all.

Re: [Qemu-devel] [PATCH v2 6/6] block: remove BlockBackendPublic

2017-08-22 Thread Alberto Garcia
On Wed 09 Aug 2017 04:02:56 PM CEST, Manos Pitsidianakis wrote: > All BlockBackend level throttling (via the implicit throttle filter node) is > done in block/block-backend.c and block/throttle-groups.c doesn't know > about BlockBackends anymore. Since BlockBackendPublic is not needed anymore, > r

[Qemu-devel] [PATCH] qga-win: Updating guest_set_time action

2017-08-22 Thread Bishara AbuHattoum
At the moment, Windows libraries don't provide a way to access RTC, so, a workaround is to use the Windows w32tm command to resync the time. Related bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1183874 Signed-off-by: Bishara AbuHattoum --- configure| 2 +- qga/comma

Re: [Qemu-devel] [PATCH] qga-win: Updating guest_set_time action

2017-08-22 Thread Sameeh Jubran
Reviewed-by: Sameeh Jubran On Tue, Aug 22, 2017 at 3:20 PM, Bishara AbuHattoum wrote: > At the moment, Windows libraries don't provide a way to access > RTC, so, a workaround is to use the Windows w32tm command to > resync the time. > Related bugzilla: https://bugzilla.redhat.com/show_b

[Qemu-devel] [PATCH v2] target/ppc: 'PVR != host PVR' in KVM_SET_SREGS workaround

2017-08-22 Thread Daniel Henrique Barboza
v2: - added Laurent's fix in 'kvmppc_pvr_workaround_required' to avoid returning true when running with TCG. Daniel Henrique Barboza (1): target/ppc: 'PVR != host PVR' in KVM_SET_SREGS workaround target/ppc/kvm.c | 34 ++ target/ppc/kvm_ppc.h | 1 + target

[Qemu-devel] [PATCH v2] target/ppc: 'PVR != host PVR' in KVM_SET_SREGS workaround

2017-08-22 Thread Daniel Henrique Barboza
Commit d5fc133eed ("ppc: Rework CPU compatibility testing across migration") changed the way cpu_post_load behaves with the PVR setting, causing an unexpected bug in KVM-HV migrations between hosts that are compatible (POWER8 and POWER8E, for example). Even with pvr_match() returning true, the gues

Re: [Qemu-devel] [Qemu-ppc] [PULL 0/7] ppc-for-2.10 queue 20170822

2017-08-22 Thread Daniel Henrique Barboza
On 08/22/2017 07:52 AM, Peter Maydell wrote: On 22 August 2017 at 11:41, Laurent Vivier wrote: On 22/08/2017 11:53, Peter Maydell wrote: On 22 August 2017 at 10:43, Laurent Vivier wrote: On 22/08/2017 11:34, Peter Maydell wrote: I get a make check failure on ppc64 Linux: TEST: tests/post

Re: [Qemu-devel] [PATCH v7 02/11] qemu.py: avoid writing to stdout/stderr

2017-08-22 Thread Amador Pahim
On Tue, Aug 22, 2017 at 1:56 PM, Fam Zheng wrote: > On Tue, 08/22 13:11, Amador Pahim wrote: >> I don't think that the 'keep the behavior' principle should overcome >> what the messages actually are. The question is: are they warning >> messages? The way I see, the messages I changed in this commi

Re: [Qemu-devel] [PATCH v3 03/10] tests: Add vm test lib

2017-08-22 Thread Kamil Rytarowski
On 22.08.2017 13:19, Philippe Mathieu-Daudé wrote: > Hi Fam, > > On 08/22/2017 01:41 AM, Fam Zheng wrote: >> This is the common code to implement a "VM test" to >> >>1) Download and initialize a pre-defined VM that has necessary >>dependencies to build QEMU and SSH access. >> >>2) Arch

  1   2   3   4   >