On 08/22/2017 04:24 AM, Markus Armbruster wrote:
John Snow <js...@redhat.com> writes:
[...]
Looks like all ten patches have an R-B despite changes; but it looks
like nothing particularly major was changed anyway.
Does this fall under Markus's jurisdiction?
(Well, except for qtest.py which seemingly has double-extra-no
maintainer...!)
qemu.py is about starting and controlling QEMU, commonly for testing
purposes. It's related to QMP only by virtue of using QMP for control
(well, what else could it use?); if that makes me maintainer, I'll soon
maintain basically all tests :)
As far as I can tell, qemu.py's main user is still qemu-iotests, via
qtest.py. Dan factored it out to make it available for
tests/migration/guestperf/.
Options for maintaining qemu.py and qtest.py:
* Maintain them with qemu-iotest
Currently mainained with the block layer core, by Kevin and Max.
- Keep it that way
- Appoint qemu-iotest maintainer(s).
* Maintain them separately, say as "Python qtest support", appoint
maintainer(s)
Dan appears to be a hot contender:
$ scripts/get_maintainer.pl -f --git-blame scripts/qtest.py
Fam Zheng <f...@redhat.com> (authored lines:71/110=65%,commits:1/3=33%)
"Daniel P. Berrange" <berra...@redhat.com> (authored
lines:39/110=35%,commits:2/3=67%)
Max Reitz <mre...@redhat.com> (commits:2/3=67%)
Amit Shah <amit.s...@redhat.com> (commits:1/3=33%)
Stefan Hajnoczi <stefa...@redhat.com> (commits:1/3=33%)
qemu-devel@nongnu.org (open list:All patches CC here)
$ scripts/get_maintainer.pl -f --git-blame scripts/qemu.py
"Daniel P. Berrange" <berra...@redhat.com> (authored
lines:217/229=95%,commits:2/4=50%)
Eduardo Habkost <ehabk...@redhat.com> (authored
lines:12/229=5%,commits:4/4=100%)
Markus Armbruster <arm...@redhat.com> (commits:1/4=25%)
Max Reitz <mre...@redhat.com> (commits:1/4=25%)
Amit Shah <amit.s...@redhat.com> (commits:1/4=25%)
qemu-devel@nongnu.org (open list:All patches CC here)
Eduardo made the mistake^W^W^Wgraciously volunteered to maintain
scripts/qmp/qmp-shell, which is also used for testing. Perhaps he'd
be willing to maintain these guys as well.
* Do nothing
Hope "somebody" will take pity and merge patches. A common value of
"somebody" would be Paolo.
:'(
* Fam is also a good candidate for scripts/qemu.py with VM testing
* trivial queue?
* Add global Python maintainers
Mostly to review/merge...
Can we predict how the python scripts will evolve? Only fast-testing?
Is there some users hacking on qemu.py unaware they can/should use
libvirt-python?
If so, shouldn't we think about running more tests through libvirt and
add effort there?
