On Sun, May 28, 2017 at 04:06:49PM +0300, Dan Aloni wrote: > The number of queues that should be return by the admin command should: > > 1) Only mention the number of non-admin queues. > 2) It is zero-based, meaning that '0 == one non-admin queue', > '1 == two non-admin queues', and so forth. > > Because our `num_queues` means the number of queues _plus_ the admin > queue, then the right calculation for the number returned from the admin > command is `num_queues - 2`, combining the two requirements mentioned. > > The issue was discovered by reducing num_queues from 64 to 8 and running > a Linux VM with an SMP parameter larger than that (e.g. 22). It tries to > utilize all queues, and therefore fails with an invalid queue number > when trying to queue I/Os on the last queue. > > Signed-off-by: Dan Aloni <d...@kernelim.com> > CC: Alex Friedman <a...@e8storage.com> > CC: Keith Busch <keith.bu...@intel.com> > CC: Stefan Hajnoczi <stefa...@redhat.com> > --- > hw/block/nvme.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Sorry for the delay. Please send future nvme.c patches through Kevin Wolf: $ scripts/get_maintainer.pl -f hw/block/nvme.c Keith Busch <keith.bu...@intel.com> (supporter:nvme) Kevin Wolf <kw...@redhat.com> (supporter:Block layer core) Max Reitz <mre...@redhat.com> (supporter:Block layer core) qemu-bl...@nongnu.org (open list:nvme) qemu-devel@nongnu.org (open list:All patches CC here) This patch will be in QEMU 2.11. Thanks, applied to my block-next tree: https://github.com/stefanha/qemu/commits/block-next Stefan
