Hi Drew,
On 07/08/2017 09:06, Andrew Jones wrote:
> On Fri, Aug 04, 2017 at 06:42:54PM +0100, Peter Maydell wrote:
>> Hi; I noticed today that the virt board doesn't have a virt-2.10
>> machine type defined. Do we need to add it before release?
>>
>> (I don't know if there have in fact been any cha
On Fri, Aug 04, 2017 at 06:42:54PM +0100, Peter Maydell wrote:
> Hi; I noticed today that the virt board doesn't have a virt-2.10
> machine type defined. Do we need to add it before release?
>
> (I don't know if there have in fact been any changes between
> 2.9 and 2.10 that would be compatibility
On Fri, Aug 04, 2017 at 06:50:11PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> There's a race if someone does a 'stop' near the end of migrate;
> the migration process goes through two runstates:
> 'finish migrate'
> 'postmigrate'
>
> If the user issue
On 24/07/17 20:48, Alexey Kardashevskiy wrote:
> On 24/07/17 15:53, David Gibson wrote:
>> On Thu, Jul 20, 2017 at 05:22:29PM +1000, Alexey Kardashevskiy wrote:
>>> This replaces g_malloc() with spapr_tce_alloc_table() as this is
>>> the standard way of allocating tables and this allows moving the
On Mon, 08/07 14:43, Fam Zheng wrote:
> On Fri, 08/04 20:10, Fam Zheng wrote:
> > On Fri, 08/04 06:50, Eric Blake wrote:
> > > On 08/03/2017 08:54 PM, no-re...@patchew.org wrote:
> > > > Hi,
> > > >
> > > > This series failed automatic build test. Please find the testing
> > > > commands and
> >
On 7/7/2017 8:14 AM, Markus Armbruster wrote:
Pradeep Jagadeesh writes:
These patches provide the qmp interface, to query the io throttle
status of the all fsdev devices that are present in a vm.
also, it provides an interface to set the io throttle parameters of a
fsdev to a required value. s
On Thu, 08/03 18:54, no-re...@patchew.org wrote:
> Hi,
>
> This series failed automatic build test. Please find the testing commands and
> their output below. If you have docker installed, you can probably reproduce
> it
> locally.
As said in the sub-thread of this message, this is a false posit
Public bug reported:
I found the vm disk corruption after snapshot deletion sometimes(the
probability is very low, I'm afraid i can't reproduce it). And I found there is
a patch for it as follow, but I'm not sure whether the patch repaired the bug.
Drain disk before snapshot deletion can't
On Fri, Aug 04, 2017 at 06:14:27PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Fix nbd_send_request to return int, as it returns a return value
> of nbd_write (which is int), and the only user of nbd_send_request's
> return value (nbd_co_send_request) consider it as int too.
The real problem here
On Mon, Aug 07, 2017 at 09:57:30AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 04.08.2017 19:11, Daniel P. Berrange wrote:
> > On Fri, Aug 04, 2017 at 06:14:28PM +0300, Vladimir Sementsov-Ogievskiy
> > wrote:
> > > Use int variable for nbd_co_send_request return value (as
> > > nbd_co_send_reques
On Sun, Aug 06, 2017 at 01:44:52PM +0200, Stefan Weil wrote:
> Am 06.08.2017 um 13:25 schrieb Shantanu Agarwal:
> > Hello all,
> > I was reading about qemu, trying to understand the source code. I found
> > that vl.c is considered the main file of qemu source code from where all
> > the execution s
On Fri, Aug 04, 2017 at 05:26:55PM +0200, Paolo Bonzini wrote:
> This is not used anymore since c01c214b69 ("block: remove all encryption
> handling APIs", 2017-07-11).
>
> Signed-off-by: Paolo Bonzini
> ---
> include/block/block_int.h | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Stefan
On Sat, Jul 29, 2017 at 11:18:17PM +0200, Knut Omang wrote:
> Another refactoring step to prepare for fixing the problem
> exposed with the test-listen test in the previous commit
>
> Signed-off-by: Knut Omang
> ---
> util/qemu-sockets.c | 15 ---
> 1 file changed, 12 insertions(+),
On Sat, Jul 29, 2017 at 11:18:18PM +0200, Knut Omang wrote:
> If an offset of ports is specified to the inet_listen_saddr function(),
> and two or more processes tries to bind from these ports at the same time,
> occasionally more than one process may be able to bind to the same
> port. The conditi
On Fri 04 Aug 2017 05:44:00 PM CEST, Eric Blake wrote:
>> --- a/block/quorum.c
>> +++ b/block/quorum.c
>> @@ -785,8 +785,9 @@ static coroutine_fn int quorum_co_flush(BlockDriverState
>> *bs)
>> for (i = 0; i < s->num_children; i++) {
>> result = bdrv_co_flush(s->children[i]->bs);
>>
On Sat, Jul 29, 2017 at 11:18:15PM +0200, Knut Omang wrote:
> There's a potential race condition between multiple bind()'s
> attempting to bind to the same port, which occasionally
> allows more than one bind to succeed against the same port.
>
> When a subsequent listen() call is made with the sa
Move the "is TSC stable and known" condition to a reusable helper.
Signed-off-by: Ladi Prosek
---
target/i386/kvm.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/target/i386/kvm.c b/target/i386/kvm.c
index 15d56ae..2dc01c9 100644
--- a/target/i386/kvm.c
+++ b
Switch is easier on the eye and might lead to better codegen.
Signed-off-by: Ladi Prosek
---
target/i386/kvm.c | 75 +++
1 file changed, 31 insertions(+), 44 deletions(-)
diff --git a/target/i386/kvm.c b/target/i386/kvm.c
index 6db7783..b14a0d
This is the QEMU part of the changes required for nested Hyper-V to read
timestamps with RDTSC + TSC page. Without exposing the frequency MSRs,
Windows with the Hyper-V role enabled use the much slower
HV_X64_MSR_TIME_REF_COUNT (0x4020) RDMSR to read timestamps.
The new registers are exposed o
Timing-related Hyper-V enlightenments will benefit from knowing the final
tsc_khz value. This commit just moves the code in preparation for further
changes.
Signed-off-by: Ladi Prosek
---
target/i386/kvm.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletion
As of kernel commit eb82feea59d6 ("KVM: hyperv: support HV_X64_MSR_TSC_FREQUENCY
and HV_X64_MSR_APIC_FREQUENCY"), KVM supports two new MSRs which are required
for nested Hyper-V to read timestamps with RDTSC + TSC page.
This commit makes QEMU advertise the MSRs with CPUID.4003H:EAX[11] and
CPU
On Fri, 4 Aug 2017 12:35:30 +1000
David Gibson wrote:
> On Thu, Aug 03, 2017 at 07:28:06PM +0200, Greg Kurz wrote:
> > On Thu, 13 Jul 2017 11:21:18 +1000
> > David Gibson wrote:
> >
> > > On Wed, Jul 12, 2017 at 04:45:17PM +1000, Suraj Jitindar Singh wrote:
> > > > On Mon, 2017-07-03 at 19:
07.08.2017 11:23, Daniel P. Berrange wrote:
On Fri, Aug 04, 2017 at 06:14:27PM +0300, Vladimir Sementsov-Ogievskiy wrote:
Fix nbd_send_request to return int, as it returns a return value
of nbd_write (which is int), and the only user of nbd_send_request's
return value (nbd_co_send_request) consi
* Peter Xu (pet...@redhat.com) wrote:
> On Fri, Aug 04, 2017 at 10:49:42AM +0100, Dr. David Alan Gilbert wrote:
> > * Peter Xu (pet...@redhat.com) wrote:
> > > On Thu, Aug 03, 2017 at 11:50:22AM +0100, Dr. David Alan Gilbert wrote:
> > > > > +/* Size of the bitmap, in bytes */
> > > > > +si
On 3 August 2017 at 19:12, Richard Henderson wrote:
> Two of these have been posted before. The third I discovered in
> testing on a Sparc host yesterday.
>
>
> r~
>
>
> The following changes since commit aaaec6acad7cf97372d48c1b09126a09697519c8:
>
> Update version for v2.10.0-rc1 release (2017
On Mon, 2017-08-07 at 09:45 +0100, Daniel P. Berrange wrote:
> On Sat, Jul 29, 2017 at 11:18:15PM +0200, Knut Omang wrote:
> > There's a potential race condition between multiple bind()'s
> > attempting to bind to the same port, which occasionally
> > allows more than one bind to succeed against th
On 7/6/2017 8:47 PM, Markus Armbruster wrote:
Pradeep Jagadeesh writes:
This patch introduces qmp interfaces for the fsdev
devices. This provides two interfaces one
for querying info of all the fsdev devices. The second one
to set the IO limits for the required fsdev device.
Signed-off-by: Pr
On 7/10/2017 4:41 PM, Eric Blake wrote:
On 07/04/2017 10:30 AM, Pradeep Jagadeesh wrote:
This patch factor out the duplicate throttle code that was present in
s/This patch factor/Factor/
It's okay to write commit messages in the imperative tense; the easiest
way I know to start a good message
On 7/6/2017 8:15 PM, Markus Armbruster wrote:
Pradeep Jagadeesh writes:
This patch introduces hmp interfaces for the fsdev
devices.
Signed-off-by: Pradeep Jagadeesh
Fails to compile, first error:
/work/armbru/qemu/hmp.c: In function ‘hmp_fsdev_set_io_throttle’:
/work/armbru/qemu/hmp.c:179
On Fri, 4 Aug 2017 15:20:26 +0200
David Hildenbrand wrote:
> On 04.08.2017 13:29, Cornelia Huck wrote:
> > Don't create the s390 pci host bridge if we do not provide the zpci
> > facility.
> >
> > Reviewed-by: Thomas Huth
> > Acked-by: Christian Borntraeger
> > Signed-off-by: Cornelia Huck
On Fri, 4 Aug 2017 15:18:14 +0200
David Hildenbrand wrote:
> On 04.08.2017 13:29, Cornelia Huck wrote:
> > If we don't provide pci, we cannot have a pci device for which we
> > have to translate to adapter routes: just return -ENODEV.
> >
> > Signed-off-by: Cornelia Huck
> > ---
> > target/s39
On Fri, 4 Aug 2017 15:17:25 +0200
David Hildenbrand wrote:
> On 04.08.2017 13:29, Cornelia Huck wrote:
> > If a guest running on a machine without zpci issues a pci instruction,
> > throw them an exception.
> >
> > Reviewed-by: Thomas Huth
> > Signed-off-by: Cornelia Huck
> > ---
> > target/s
On 7/6/2017 7:55 PM, Markus Armbruster wrote:
Pradeep Jagadeesh writes:
This patch enables qmp interfaces for the fsdev
devices. This provides two interfaces one
for querying info of all the fsdev devices. The second one
to set the IO limits for the required fsdev device.
Signed-off-by: Prade
Dr. David Alan Gilbert writes:
> * Peter Maydell (peter.mayd...@linaro.org) wrote:
>> On 1 August 2017 at 17:17, Paolo Bonzini wrote:
>> > From: "Dr. David Alan Gilbert"
>> >
>> > This code has an optimised, word aligned version, and a boring
>> > unaligned version. Recently 084140bd498909 fi
On Mon, Aug 07, 2017 at 11:21:25AM +0200, Knut Omang wrote:
> On Mon, 2017-08-07 at 09:45 +0100, Daniel P. Berrange wrote:
> > On Sat, Jul 29, 2017 at 11:18:15PM +0200, Knut Omang wrote:
> > > There's a potential race condition between multiple bind()'s
> > > attempting to bind to the same port, wh
On 07.08.2017 12:00, Cornelia Huck wrote:
> On Fri, 4 Aug 2017 15:20:26 +0200
> David Hildenbrand wrote:
>
>> On 04.08.2017 13:29, Cornelia Huck wrote:
>>> Don't create the s390 pci host bridge if we do not provide the zpci
>>> facility.
>>>
>>> Reviewed-by: Thomas Huth
>>> Acked-by: Christian B
On Mon, 2017-08-07 at 11:27 +0100, Daniel P. Berrange wrote:
> On Mon, Aug 07, 2017 at 11:21:25AM +0200, Knut Omang wrote:
> > On Mon, 2017-08-07 at 09:45 +0100, Daniel P. Berrange wrote:
> > > On Sat, Jul 29, 2017 at 11:18:15PM +0200, Knut Omang wrote:
> > > > There's a potential race condition be
Am 07.08.2017 um 05:08 hat Jeff Cody geschrieben:
> Calls to bdrv_getlength() were not checking for error. In vhdx.c, this
> can lead to truncating an image file, so it is a definite bug. In
> vhdx-log.c, the path for improper behavior is less clear, but it is best
> to check in any case.
>
> Re
Am 07.08.2017 um 05:08 hat Jeff Cody geschrieben:
> VHDX uses uint64_t types for most offsets, following the VHDX spec.
> However, bdrv_truncate() takes an int64_t value for the truncating
> offset. Check for overflow before calling bdrv_truncate().
>
> N.B.: For a compliant image this is not an
Am 07.08.2017 um 05:08 hat Jeff Cody geschrieben:
> Two VHDX items cleaned up:
>
> 1. Check for error when calling bdrv_getlength() [Markus]
>
> 2. Check for overflow in offset prior to calling bdrv_truncate().
This doesn't look like cleanups to me, but like proper fixes. I think it
would still
This series contains:
* a unit test that exposes a race condition which causes QEMU to fail
to find a port even when there is plenty of available ports.
* a refactor of the qemu-sockets inet_listen_saddr() function
to better handle this situation.
Changes from v6:
* Changed license of the (new
Another refactoring step to prepare for fixing the problem
exposed with the test-listen test in the previous commit
Signed-off-by: Knut Omang
Reviewed-by: Daniel P. Berrange
---
util/qemu-sockets.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/util/qemu-so
There's a potential race condition between multiple bind()'s
attempting to bind to the same port, which occasionally
allows more than one bind to succeed against the same port.
When a subsequent listen() call is made with the same socket
only one will succeed.
The current QEMU code does however n
If an offset of ports is specified to the inet_listen_saddr function(),
and two or more processes tries to bind from these ports at the same time,
occasionally more than one process may be able to bind to the same
port. The condition is detected by listen() but too late to avoid a failure.
This fu
A refactoring step to prepare for the problem
exposed by the test-listen test in the previous commit.
Simplify and reorganize the IPv6 specific extra
measures and move it out of the for loop to increase
code readability. No semantic changes.
Signed-off-by: Knut Omang
Reviewed-by: Daniel P. Berra
On 08/05/2017 01:52 PM, Pranith Kumar wrote:
> FYI,
>
> This commit breaks the build with gcc-7:
>
> CC block/vvfat.o
> qemu/block/vvfat.c: In function ‘read_directory’:
> qemu/block/vvfat.c:605:37: error: ‘__builtin___sprintf_chk’ may write
> a terminating nul past the end of the destinat
On Mon, 7 Aug 2017 12:21:30 +0200
David Hildenbrand wrote:
> On 07.08.2017 12:00, Cornelia Huck wrote:
> > On Fri, 4 Aug 2017 15:20:26 +0200
> > David Hildenbrand wrote:
> >
> >> On 04.08.2017 13:29, Cornelia Huck wrote:
> >>> Don't create the s390 pci host bridge if we do not provide the z
The following changes since commit ac44ed2afb7c60255e989b163301479f5b4ecd04:
Merge remote-tracking branch 'remotes/ehabkost/tags/machine-pull-request'
into staging (2017-08-04 13:46:22 +0100)
are available in the git repository at:
git://github.com/stefanha/qemu.git tags/tracing-pull-reques
On Thu, 3 Aug 2017 13:56:45 -0500
Eric Blake wrote:
> On 08/03/2017 01:38 PM, Greg Kurz wrote:
> > The following code snippet spits a warning with gcc-7.1.1-3.fc26 and -Wall
> > on
> > ppc64le AND x86_64:
> >
> > int foo(void)
> > {
> > char empty_array[] = { };
> > int i, ret = 0;
> >
From: "Daniel P. Berrange"
There are trace probes in bdrv_co_readv|writev, however, the
block drivers are being gradually moved over to using the
bdrv_co_preadv|pwritev functions instead. As a result some
block drivers miss the current probes. Move the probes
into bdrv_co_preadv|pwritev instead,
On 08/06/2017 10:08 PM, Jeff Cody wrote:
> VHDX uses uint64_t types for most offsets, following the VHDX spec.
> However, bdrv_truncate() takes an int64_t value for the truncating
> offset. Check for overflow before calling bdrv_truncate().
>
> N.B.: For a compliant image this is not an issue, as
On 08/06/2017 10:08 PM, Jeff Cody wrote:
> Calls to bdrv_getlength() were not checking for error. In vhdx.c, this
> can lead to truncating an image file, so it is a definite bug. In
> vhdx-log.c, the path for improper behavior is less clear, but it is best
> to check in any case.
>
> Reported-by
On 08/07/2017 03:43 AM, Alberto Garcia wrote:
> On Fri 04 Aug 2017 05:44:00 PM CEST, Eric Blake wrote:
>>> --- a/block/quorum.c
>>> +++ b/block/quorum.c
>>> @@ -785,8 +785,9 @@ static coroutine_fn int
>>> quorum_co_flush(BlockDriverState *bs)
>>> for (i = 0; i < s->num_children; i++) {
>>>
On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote:
> Do not send NBD_OPT_ABORT to the broken server. After sending
> NBD_REP_ACK on NBD_OPT_GO server is most probably in transmission
> phase, when option sending is finished.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> nbd/cl
Building QEMU on fedora26 with the latest gcc package fails:
CC ppc64-softmmu/target/ppc/kvm.o
In file included from include/sysemu/hw_accel.h:16:0,
from target/ppc/kvm.c:31:
target/ppc/kvm.c: In function ‘kvmppc_booke_watchdog_enable’:
include/sysemu/kvm.h:449:35: error: ‘
On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote:
> Refactor nbd_read_eof to return 1 on success, 0 on eof, when no
> data was read and <0 for other cases, because returned size of
> read data is not actually used.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> nbd/nbd-interna
Add virt-2.10 machine type.
Signed-off-by: Eric Auger
---
---
hw/arm/virt.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 31739d7..6b7a0fe 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -1639,7 +1639,7 @@ static v
On 08/07/2017 03:57 AM, Vladimir Sementsov-Ogievskiy wrote:
> 07.08.2017 11:23, Daniel P. Berrange wrote:
>> On Fri, Aug 04, 2017 at 06:14:27PM +0300, Vladimir Sementsov-Ogievskiy
>> wrote:
>>> Fix nbd_send_request to return int, as it returns a return value
>>> of nbd_write (which is int), and the
On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote:
> Set reply.handle to 0 on error path to prevent normal path of
> nbd_co_receive_reply.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/nbd-client.c | 1 +
> 1 file changed, 1 insertion(+)
Can you document a case where no
On 07/08/2017 13:36, Greg Kurz wrote:
> Building QEMU on fedora26 with the latest gcc package fails:
>
> CC ppc64-softmmu/target/ppc/kvm.o
> In file included from include/sysemu/hw_accel.h:16:0,
> from target/ppc/kvm.c:31:
> target/ppc/kvm.c: In function ‘kvmppc_booke_watch
On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote:
> We set s->reply.handle to 0 on one error path and don't set on another.
> For consistancy and to avoid assert in nbd_read_reply_entry let's
> set s->reply.handle to 0 in case of wrong handle too.
>
> Signed-off-by: Vladimir Sementsov-Og
On Mon, Aug 07, 2017 at 11:57:12AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 07.08.2017 11:23, Daniel P. Berrange wrote:
> > On Fri, Aug 04, 2017 at 06:14:27PM +0300, Vladimir Sementsov-Ogievskiy
> > wrote:
> > > Fix nbd_send_request to return int, as it returns a return value
> > > of nbd_writ
07.08.2017 14:42, Eric Blake wrote:
On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote:
Refactor nbd_read_eof to return 1 on success, 0 on eof, when no
data was read and <0 for other cases, because returned size of
read data is not actually used.
Signed-off-by: Vladimir Sementsov-Ogievs
On 08/04/2017 11:00 PM, Eric Blake wrote:
On 08/01/2017 09:19 AM, Anton Nefedov wrote:
Qcow2State and BlockDriverState flags have to be in sync
Signed-off-by: Anton Nefedov
---
block/qcow2.c | 1 +
1 file changed, 1 insertion(+)
Is this a bug fix needed for 2.10?
I don't think this bi
On Mon 07 Aug 2017 01:29:09 PM CEST, Eric Blake wrote:
> On 08/07/2017 03:43 AM, Alberto Garcia wrote:
>> On Fri 04 Aug 2017 05:44:00 PM CEST, Eric Blake wrote:
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -785,8 +785,9 @@ static coroutine_fn int
quorum_co_flush(BlockDriverStat
On Mon, Aug 07, 2017 at 06:24:30AM -0500, Eric Blake wrote:
> On 08/06/2017 10:08 PM, Jeff Cody wrote:
> > VHDX uses uint64_t types for most offsets, following the VHDX spec.
> > However, bdrv_truncate() takes an int64_t value for the truncating
> > offset. Check for overflow before calling bdrv_t
On Mon, Aug 07, 2017 at 11:49:41AM +, Eric Auger wrote:
> Add virt-2.10 machine type.
>
> Signed-off-by: Eric Auger
>
> ---
> ---
> hw/arm/virt.c | 19 +--
> 1 file changed, 17 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 31739d7..6b7
On Mon, 07 Aug 2017 13:36:44 +0200
Greg Kurz wrote:
> Building QEMU on fedora26 with the latest gcc package fails:
>
> CC ppc64-softmmu/target/ppc/kvm.o
> In file included from include/sysemu/hw_accel.h:16:0,
> from target/ppc/kvm.c:31:
> target/ppc/kvm.c: In function ‘kv
On Mon, Aug 07, 2017 at 12:46:30PM +0200, Kevin Wolf wrote:
> Am 07.08.2017 um 05:08 hat Jeff Cody geschrieben:
> > Calls to bdrv_getlength() were not checking for error. In vhdx.c, this
> > can lead to truncating an image file, so it is a definite bug. In
> > vhdx-log.c, the path for improper be
On 08/04/2017 06:23 PM, Eric Blake wrote:
On 08/01/2017 09:18 AM, Anton Nefedov wrote:
Signed-off-by: Anton Nefedov
---
block/blkverify.c | 9 +
1 file changed, 9 insertions(+)
Basically, blkverify supports a flag if BOTH of its underlying files
also support the flag; if either sid
* Peter Xu (pet...@redhat.com) wrote:
> On Fri, Aug 04, 2017 at 06:50:11PM +0100, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > There's a race if someone does a 'stop' near the end of migrate;
> > the migration process goes through two runstates:
> > 'finish m
The QUORUM_REPORT_BAD event has fields to report the sector in which
the error was detected and the number of affected sectors starting
from that one. This is important for read and write errors, but not
for flush errors.
For flush errors the current code reports the total size of the disk
image.
This patch enables qmp interfaces for the fsdev
devices. This provides two interfaces one
for querying info of all the fsdev devices. The second one
to set the IO limits for the required fsdev device.
Signed-off-by: Pradeep Jagadeesh
Reviewed-by: Greg Kurz
Reviewed-by: Eric Blake
Reviewed-by: A
This patch move out the throttle code to util/throttle.c to maximize
the reusability of the code.The same code is also used by fsdev.
Signed-off-by: Pradeep Jagadeesh
---
blockdev.c | 53 +++-
include/qemu/throttle-options.h | 3 +++
util/thr
These patches provide the qmp interface, to query the io throttle
status of the all fsdev devices that are present in a vm.
also, it provides an interface to set the io throttle parameters of a
fsdev to a required value. some of the patches also remove the duplicate
code that was present in block
This patch creates a throttle initialization function to maximize the
code reusability. The same code is also used by fsdev.
Acked-by: Dr. David Alan Gilbert
Signed-off-by: Pradeep Jagadeesh
---
hmp.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/hmp.c
This patch introduces qmp interfaces for the fsdev
devices. This provides two interfaces one
for querying info of all the fsdev devices. The second one
to set the IO limits for the required fsdev device.
Signed-off-by: Pradeep Jagadeesh
---
Makefile| 4 +++
fsdev/qemu-fsdev-
This patch factor out the duplicate throttle code that was present in
block and fsdev devices.
Signed-off-by: Pradeep Jagadeesh
Reviewed-by: Alberto Garcia
---
blockdev.c | 44 +--
fsdev/qemu-fsdev-throttle.c | 44 ++--
Some VHDX bug fixes, including:
1. Checking bdrv_getlength(), bdrv_flush(), and bdrv_truncate() return values
Changes from v1->v2:
git-backport-diff -r qemu/master.. -u vhdx-fixes-v1
Key:
[] : patches are identical
[] : number of functional differences between upstream/downstream patch
This patch introduces hmp interfaces for the fsdev
devices.
Signed-off-by: Pradeep Jagadeesh
---
hmp-commands-info.hx | 18 +++
hmp-commands.hx | 19
hmp.c| 62
hmp.h| 4
VHDX uses uint64_t types for most offsets, following the VHDX spec.
However, bdrv_truncate() takes an int64_t value for the truncating
offset. Check for overflow before calling bdrv_truncate().
While we are here, replace the bit shifting with QEMU_ALIGN_UP as well.
N.B.: For a compliant image th
On 08/07/2017 07:37 AM, Pradeep Jagadeesh wrote:
> This patch enables qmp interfaces for the fsdev
> devices. This provides two interfaces one
> for querying info of all the fsdev devices. The second one
> to set the IO limits for the required fsdev device.
>
> Signed-off-by: Pradeep Jagadeesh
>
Calls to bdrv_getlength() were not checking for error. In vhdx.c, this
can lead to truncating an image file, so it is a definite bug. In
vhdx-log.c, the path for improper behavior is less clear, but it is best
to check in any case.
Some minor code movement of the log_guid intialization, as well.
Signed-off-by: Jeff Cody
---
block/vhdx-log.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/block/vhdx-log.c b/block/vhdx-log.c
index a27dc05..14b724e 100644
--- a/block/vhdx-log.c
+++ b/block/vhdx-log.c
@@ -558,7 +558,11 @@ static int vhdx_log_flush(BlockDriverState *b
Reported-by: Kevin Wolf
Signed-off-by: Jeff Cody
---
block/vhdx-log.c | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/block/vhdx-log.c b/block/vhdx-log.c
index 9597223..a27dc05 100644
--- a/block/vhdx-log.c
+++ b/block/vhdx-log.c
@@ -565,7 +565,10 @@ static
On 08/07/2017 07:37 AM, Pradeep Jagadeesh wrote:
> This patch introduces qmp interfaces for the fsdev
> devices. This provides two interfaces one
> for querying info of all the fsdev devices. The second one
> to set the IO limits for the required fsdev device.
>
> Signed-off-by: Pradeep Jagadeesh
On 08/07/2017 07:36 AM, Alberto Garcia wrote:
> The QUORUM_REPORT_BAD event has fields to report the sector in which
> the error was detected and the number of affected sectors starting
> from that one. This is important for read and write errors, but not
> for flush errors.
>
> For flush errors t
On 8/7/2017 2:44 PM, Eric Blake wrote:
On 08/07/2017 07:37 AM, Pradeep Jagadeesh wrote:
This patch introduces qmp interfaces for the fsdev
devices. This provides two interfaces one
for querying info of all the fsdev devices. The second one
to set the IO limits for the required fsdev device.
Sig
On 08/03/2017 03:13 PM, Thomas Huth wrote:
On 03.08.2017 14:08, KONRAD Frederic wrote:
On 08/03/2017 01:37 PM, Thomas Huth wrote:
On 01.08.2017 10:44, KONRAD Frederic wrote:
When a tlb instruction miss happen, rw is set to 0 at the bottom
of cpu_ppc_handle_mmu_fault which cause the MAS upd
On 08/07/2017 07:38 AM, Jeff Cody wrote:
> Reported-by: Kevin Wolf
> Signed-off-by: Jeff Cody
> ---
> block/vhdx-log.c | 17 ++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-9
On 08/07/2017 07:38 AM, Jeff Cody wrote:
> Signed-off-by: Jeff Cody
> ---
> block/vhdx-log.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
Reviewed-by: Eric Blake
> diff --git a/block/vhdx-log.c b/block/vhdx-log.c
> index a27dc05..14b724e 100644
> --- a/block/vhdx-log.c
> +++
07.08.2017 14:52, Eric Blake wrote:
On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote:
Set reply.handle to 0 on error path to prevent normal path of
nbd_co_receive_reply.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/nbd-client.c | 1 +
1 file changed, 1 insertion(+)
Can y
Bad news... The performance had dropped dramatically when using emulated
switches.
I was referring to the PCIe doc at
https://github.com/qemu/qemu/blob/master/docs/pcie.txt
# qemu-system-x86_64_2.6.2 -enable-kvm -cpu host,kvm=off -machine
q35,accel=kvm -nodefaults -nodefconfig \
-device ioh3420,i
Besides, I checked the lspci -vvv output, no capabilities of Access Control
are seen.
2017-08-01 23:01 GMT+08:00 Alex Williamson :
> On Tue, 1 Aug 2017 17:35:40 +0800
> Bob Chen wrote:
>
> > 2017-08-01 13:46 GMT+08:00 Alex Williamson :
> >
> > > On Tue, 1 Aug 2017 13:04:46 +0800
> > > Bob Chen
On Mon, 7 Aug 2017 16:33:29 +1000
Sam Bobroff wrote:
> The concept of a VCPU ID that differs from the CPU's index
> (cpu->cpu_index) exists only within SPAPR machines so, move the
> functions ppc_get_vcpu_id() and ppc_get_cpu_by_vcpu_id() into spapr.c
> and rename them appropriately.
>
> Signed-
On 7 August 2017 at 12:04, Stefan Hajnoczi wrote:
> The following changes since commit ac44ed2afb7c60255e989b163301479f5b4ecd04:
>
> Merge remote-tracking branch 'remotes/ehabkost/tags/machine-pull-request'
> into staging (2017-08-04 13:46:22 +0100)
>
> are available in the git repository at:
>
07.08.2017 14:55, Eric Blake wrote:
On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote:
We set s->reply.handle to 0 on one error path and don't set on another.
For consistancy and to avoid assert in nbd_read_reply_entry let's
set s->reply.handle to 0 in case of wrong handle too.
Signed-
Am 07.08.2017 um 14:36 hat Alberto Garcia geschrieben:
> The QUORUM_REPORT_BAD event has fields to report the sector in which
> the error was detected and the number of affected sectors starting
> from that one. This is important for read and write errors, but not
> for flush errors.
>
> For flush
On 7 August 2017 at 13:14, Andrew Jones wrote:
> On Mon, Aug 07, 2017 at 11:49:41AM +, Eric Auger wrote:
>> Add virt-2.10 machine type.
>>
>> Signed-off-by: Eric Auger
>>
>> ---
Applied to master, thanks.
-- PMM
Am 07.08.2017 um 14:38 hat Jeff Cody geschrieben:
>
> Some VHDX bug fixes, including:
>
> 1. Checking bdrv_getlength(), bdrv_flush(), and bdrv_truncate() return values
Thanks, applied to the block branch.
Kevin
1 - 100 of 336 matches
Mail list logo
