On Mon, Aug 07, 2017 at 09:57:30AM +0300, Vladimir Sementsov-Ogievskiy wrote: > 04.08.2017 19:11, Daniel P. Berrange wrote: > > On Fri, Aug 04, 2017 at 06:14:28PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > Use int variable for nbd_co_send_request return value (as > > > nbd_co_send_request returns int). > > Hmm, nbd_co_send_request() propagates return value of nbd_send_request, > > which returns ssize_t. > > See patch 04, nbd_send_request fixed in it to return int. It propagates > return > value of nbd_write which is int.
That's wrong too - nbd_write() should have been fixed to have ssize_t as its return type, since its returning the value of a ssize_t variable. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
