On Mon, 7 Aug 2017 12:21:30 +0200 David Hildenbrand <da...@redhat.com> wrote:
> On 07.08.2017 12:00, Cornelia Huck wrote: > > On Fri, 4 Aug 2017 15:20:26 +0200 > > David Hildenbrand <da...@redhat.com> wrote: > > > >> On 04.08.2017 13:29, Cornelia Huck wrote: > >>> Don't create the s390 pci host bridge if we do not provide the zpci > >>> facility. > >>> > >>> Reviewed-by: Thomas Huth <th...@redhat.com> > >>> Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> > >>> Signed-off-by: Cornelia Huck <coh...@redhat.com> > >> > >> This works, because s390_init_cpus(machine) (which sets up features) is > >> called before adding the bus. Mind to add a comment so nobody tries to > >> reshuffle these functions? > > > > This is already needed by the flic setup (which also relies on the > > features being set up). We really want the cpu setup as early as > > possible. > > > > Do you have a good comment handy? :) > > > > /* init CPUs (incl. CPU model) early so s390_has_feature() works */ > Thanks, I'll go with that.
