Re: [Qemu-devel] [PATCH 03/47] MAINTAINERS: add missing STM32 entry

2017-07-28 Thread Thomas Huth
On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 795f89f709..f10252c292 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -556,6 +556,7 @@ F:

Re: [Qemu-devel] [PATCH 05/47] MAINTAINERS: add missing KVM entry

2017-07-28 Thread Thomas Huth
On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 3b472d7a09..ece02522be 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -278,6 +278,7 @@ S:

Re: [Qemu-devel] [PATCH 07/47] MAINTAINERS: add missing entry for vfio/ccw

2017-07-28 Thread Thomas Huth
On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index ddf6f3f6d8..69987b5e5b 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1029,6 +1029,7 @@

Re: [Qemu-devel] [PATCH 08/47] MAINTAINERS: add missing entry for virtio

2017-07-28 Thread Thomas Huth
On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 69987b5e5b..6da3264d4e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1046,6 +1046,7 @@

Re: [Qemu-devel] [PATCH v8 3/3] migration: add bitmap for received page

2017-07-28 Thread Alexey Perevalov
On 07/28/2017 09:57 AM, Peter Xu wrote: On Fri, Jul 28, 2017 at 09:43:28AM +0300, Alexey Perevalov wrote: On 07/28/2017 07:27 AM, Peter Xu wrote: On Thu, Jul 27, 2017 at 10:27:41AM +0300, Alexey Perevalov wrote: On 07/27/2017 05:35 AM, Peter Xu wrote: On Wed, Jul 26, 2017 at 06:24:11PM +0300,

Re: [Qemu-devel] [RFC PATCH 15/47] MAINTAINERS: add missing VMWare entry

2017-07-28 Thread Thomas Huth
On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > > RFC because I'm not sure about tests/ I think that should be fine, we've got a couple of such entries already in the MAINTAINERS file. > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > >

Re: [Qemu-devel] [PATCH 1/3] s390x/css: use macro for event-information pending error recover code

2017-07-28 Thread Dong Jia Shi
* Cornelia Huck [2017-07-27 12:10:17 +0200]: [...] > > diff --git a/include/hw/s390x/ioinst.h b/include/hw/s390x/ioinst.h > > index 92d15655e4..c1d1052279 100644 > > --- a/include/hw/s390x/ioinst.h > > +++ b/include/hw/s390x/ioinst.h > > @@ -201,8 +201,9 @@ typedef struct CRW { > > #define CRW_

Re: [Qemu-devel] [PATCH 07/47] MAINTAINERS: add missing entry for vfio/ccw

2017-07-28 Thread Cornelia Huck
On Fri, 28 Jul 2017 09:02:27 +0200 Thomas Huth wrote: > On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > MAINTAINERS | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index ddf6f3f6d8..69987b5e5b

Re: [Qemu-devel] [PATCH 11/47] MAINTAINERS: add missing entry for virtio/ccw

2017-07-28 Thread Cornelia Huck
On Fri, 28 Jul 2017 02:35:34 -0300 Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 2958dd2479..bfdb2f8928 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -10

Re: [Qemu-devel] Status and RFC of patchew testings on QEMU

2017-07-28 Thread Cornelia Huck
On Fri, 28 Jul 2017 14:33:37 +0800 Fam Zheng wrote: > On Fri, 07/28 02:46, Philippe Mathieu-Daudé wrote: > > Hi Fam, > > > > On 07/17/2017 03:35 AM, Fam Zheng wrote: > > > So far we have these tests running by patchew on each patch series: > > > > > >* Docker tests > > > Basically it

Re: [Qemu-devel] [PATCH 2/3] s390x/css: generate solicited crw for rchp completion signaling

2017-07-28 Thread Dong Jia Shi
* Cornelia Huck [2017-07-27 13:22:59 +0200]: [...] > > diff --git a/hw/s390x/css.c b/hw/s390x/css.c [...] > > @@ -2028,7 +2028,7 @@ void css_subch_assign(uint8_t cssid, uint8_t ssid, > > uint16_t schid, > > } > > } > > > > -void css_queue_crw(uint8_t rsc, uint8_t erc, int chain, uint16

Re: [Qemu-devel] [PATCH 1/3] s390x/css: use macro for event-information pending error recover code

2017-07-28 Thread Cornelia Huck
On Fri, 28 Jul 2017 15:12:25 +0800 Dong Jia Shi wrote: > * Cornelia Huck [2017-07-27 12:10:17 +0200]: > > Do we want to add all ERCs while we're at it? > > > > > +#define CRW_ERC_INIT 0x02 > > > +#define CRW_ERC_IPI0x04 > No problem for me. I can do that by stealing again: > > #defi

Re: [Qemu-devel] [PATCH 2/3] s390x/css: generate solicited crw for rchp completion signaling

2017-07-28 Thread Cornelia Huck
On Fri, 28 Jul 2017 15:25:26 +0800 Dong Jia Shi wrote: > So, I only need to s/s/solicited for the new version of this one? Yes, that would be fine.

Re: [Qemu-devel] [RFC PATCH 15/47] MAINTAINERS: add missing VMWare entry

2017-07-28 Thread Dmitry Fleytman
> On 28 Jul 2017, at 10:08, Thomas Huth wrote: > >> On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> >> RFC because I'm not sure about tests/ > > I think that should be fine, we've got a couple of such entries already > in the MAINTAINERS

Re: [Qemu-devel] [Qemu-trivial] [PATCH for 2.10 v2 18/20] 9pfs: avoid sign conversion error simplifying the code

2017-07-28 Thread Greg Kurz
On Thu, 27 Jul 2017 16:18:07 -0300 Philippe Mathieu-Daudé wrote: > On 07/27/2017 08:40 AM, Greg Kurz wrote: > > On Wed, 26 Jul 2017 23:42:22 -0300 > > Philippe Mathieu-Daudé wrote: > > Reviewed-by: Greg Kurz > > > > Now, I'm not sure this can be merged during hard freeze since it is > > more c

Re: [Qemu-devel] [PATCH 22/47] MAINTAINERS: add missing M68k entry

2017-07-28 Thread Laurent Vivier
Le 28/07/2017 à 07:35, Philippe Mathieu-Daudé a écrit : > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 14109f4513..06b092bf85 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -156,6 +156,7

[Qemu-devel] [RFC 02/29] migration: fix comment disorder in RAMState

2017-07-28 Thread Peter Xu
Comments for "migration_dirty_pages" and "bitmap_mutex" are switched. Fix it. Signed-off-by: Peter Xu --- migration/ram.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index c93973c..c12358d 100644 --- a/migration/ram.c +++ b/migration/

[Qemu-devel] [RFC 03/29] io: fix qio_channel_socket_accept err handling

2017-07-28 Thread Peter Xu
When accept failed, we should setup errp with the reason. More importantly, the caller may assume errp be non-NULL when error happens, and not setting the errp may crash QEMU. Signed-off-by: Peter Xu --- io/channel-socket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/io/channel-socket.c

[Qemu-devel] [RFC 10/29] migration: new property "x-postcopy-fast"

2017-07-28 Thread Peter Xu
This provides a way to start postcopy ASAP when migration starts. To do this, we need both: -global migration.x-postcopy-ram=on \ -global migration.x-postcopy-fast=on Signed-off-by: Peter Xu --- migration/migration.c | 9 - migration/migration.h | 2 ++ 2 files changed, 10 insertion

[Qemu-devel] [RFC 00/29] Migration: postcopy failure recovery

2017-07-28 Thread Peter Xu
As we all know that postcopy migration has a potential risk to lost the VM if the network is broken during the migration. This series tries to solve the problem by allowing the migration to pause at the failure point, and do recovery after the link is reconnected. There was existing work on this i

[Qemu-devel] [RFC 01/29] migration: fix incorrect postcopy recved_bitmap

2017-07-28 Thread Peter Xu
The bitmap setup during postcopy is incorrectly when the pgaes are huge pages. Fix it. Signed-off-by: Peter Xu --- migration/postcopy-ram.c | 2 +- migration/ram.c | 8 migration/ram.h | 2 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/migration/pos

[Qemu-devel] [RFC 04/29] bitmap: introduce bitmap_invert()

2017-07-28 Thread Peter Xu
It is used to invert the whole bitmap. Signed-off-by: Peter Xu --- include/qemu/bitmap.h | 10 ++ util/bitmap.c | 13 + 2 files changed, 23 insertions(+) diff --git a/include/qemu/bitmap.h b/include/qemu/bitmap.h index c318da1..460d899 100644 --- a/include/qemu/bitma

[Qemu-devel] [RFC 11/29] migration: new postcopy-pause state

2017-07-28 Thread Peter Xu
Introducing a new state "postcopy-paused", which can be used to pause a postcopy migration. It is targeted to support network failures during postcopy migration. Now when network down for postcopy, the source side will not fail the migration. Instead we convert the status into this new paused state

[Qemu-devel] [RFC 05/29] bitmap: introduce bitmap_count_one()

2017-07-28 Thread Peter Xu
Count how many bits set in the bitmap. Signed-off-by: Peter Xu --- include/qemu/bitmap.h | 10 ++ util/bitmap.c | 15 +++ 2 files changed, 25 insertions(+) diff --git a/include/qemu/bitmap.h b/include/qemu/bitmap.h index 460d899..9c18da0 100644 --- a/include/qemu/bit

[Qemu-devel] [RFC 08/29] migration: reuse mis->userfault_quit_fd

2017-07-28 Thread Peter Xu
It was only used for quitting the page fault thread before. Let it be something more useful - now we can use it to notify a "wake" for the page fault thread (for any reason), and it only means "quit" if the fault_thread_quit is set. Since we changed what it does, renaming it to userfault_event_fd.

[Qemu-devel] [RFC 09/29] migration: provide postcopy_fault_thread_notify()

2017-07-28 Thread Peter Xu
A general helper to notify the fault thread. Signed-off-by: Peter Xu --- migration/postcopy-ram.c | 35 --- migration/postcopy-ram.h | 2 ++ 2 files changed, 22 insertions(+), 15 deletions(-) diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index

[Qemu-devel] [RFC 18/29] migration: new state "postcopy-recover"

2017-07-28 Thread Peter Xu
Introducing new migration state "postcopy-recover". If a migration procedure is paused and the connection is rebuilt afterward successfully, we'll switch the source VM state from "postcopy-paused" to the new state "postcopy-recover", then we'll do the resume logic in the migration thread (along wit

[Qemu-devel] [RFC 06/29] migration: dump str in migrate_set_state trace

2017-07-28 Thread Peter Xu
Strings are more readable for debugging. Signed-off-by: Peter Xu --- migration/migration.c | 3 ++- migration/trace-events | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 6803187..bdc4445 100644 --- a/migration/migration

[Qemu-devel] [RFC 14/29] migration: allow send_rq to fail

2017-07-28 Thread Peter Xu
We will not allow failures to happen when sending data from destination to source via the return path. However it is possible that there can be errors along the way. This patch allows the migrate_send_rp_message() to return error when it happens, and further extended it to migrate_send_rp_req_page

[Qemu-devel] [RFC 12/29] migration: allow dst vm pause on postcopy

2017-07-28 Thread Peter Xu
When there is IO error on the incoming channel (e.g., network down), instead of bailing out immediately, we allow the dst vm to switch to the new POSTCOPY_PAUSE state. Currently it is still simple - it waits the new semaphore, until someone poke it for another attempt. Signed-off-by: Peter Xu ---

[Qemu-devel] [RFC 23/29] migration: new cmd MIG_CMD_POSTCOPY_RESUME

2017-07-28 Thread Peter Xu
Introducing this new command to be sent when the source VM is ready to resume the paused migration. What the destination does here is basically release the fault thread to continue service page faults. Signed-off-by: Peter Xu --- migration/savevm.c | 27 +++ migratio

[Qemu-devel] [RFC 07/29] migration: better error handling with QEMUFile

2017-07-28 Thread Peter Xu
If the postcopy down due to some reason, we can always see this on dst: qemu-system-x86_64: RP: Received invalid message 0x length 0x However in most cases that's not the real issue. The problem is that qemu_get_be16() has no way to show whether the returned data is valid or not, and we

[Qemu-devel] [RFC 15/29] migration: allow fault thread to pause

2017-07-28 Thread Peter Xu
Allows the fault thread to stop handling page faults temporarily. When network failure happened (and if we expect a recovery afterwards), we should not allow the fault thread to continue sending things to source, instead, it should halt for a while until the connection is rebuilt. When the dest ma

[Qemu-devel] [RFC 28/29] migration: final handshake for the resume

2017-07-28 Thread Peter Xu
Finish the last step to do the final handshake for the recovery. First source sends one MIG_CMD_RESUME to dst, telling that source is ready to resume. Then, dest replies with MIG_RP_MSG_RESUME_ACK to source, telling that dest is ready to resume (after switch to postcopy-active state). When sourc

[Qemu-devel] [RFC 25/29] migration: introduce SaveVMHandlers.resume_prepare

2017-07-28 Thread Peter Xu
This is hook function to be called when a postcopy migration wants to resume from a failure. For each module, it should provide its own recovery logic before we switch to the postcopy-active state. Signed-off-by: Peter Xu --- include/migration/register.h | 2 ++ migration/migration.c| 2

[Qemu-devel] [RFC 13/29] migration: allow src return path to pause

2017-07-28 Thread Peter Xu
Let the thread pause for network issues. Signed-off-by: Peter Xu --- migration/migration.c | 35 +-- migration/migration.h | 1 + migration/trace-events | 2 ++ 3 files changed, 36 insertions(+), 2 deletions(-) diff --git a/migration/migration.c b/migration/m

[Qemu-devel] [RFC 16/29] qmp: hmp: add migrate "resume" option

2017-07-28 Thread Peter Xu
It will be used when we want to resume one paused migration. Signed-off-by: Peter Xu --- hmp-commands.hx | 7 --- hmp.c | 4 +++- migration/migration.c | 2 +- qapi-schema.json | 5 - 4 files changed, 12 insertions(+), 6 deletions(-) diff --git a/hmp-commands.

[Qemu-devel] [RFC 17/29] migration: rebuild channel on source

2017-07-28 Thread Peter Xu
This patch detects the "resume" flag of migration command, rebuild the channels only if the flag is set. Signed-off-by: Peter Xu --- migration/migration.c | 52 --- 1 file changed, 41 insertions(+), 11 deletions(-) diff --git a/migration/migration

Re: [Qemu-devel] [RFC PATCH] tcg/softmmu: Increase size of TLB cache

2017-07-28 Thread Alex Bennée
Paolo Bonzini writes: > On 24/07/2017 23:03, Pranith Kumar wrote: >> This patch increases the number of entries we allow in the TLB. I went >> over a few architectures to see if increasing it is problematic. Only >> armv6 seems to have a limitation that only 8 bits can be used for >> indexing th

Re: [Qemu-devel] [PATCH] ui: drop ac_search and ac_stop

2017-07-28 Thread Daniel P. Berrange
On Fri, Jul 28, 2017 at 08:34:15AM +0200, Gerd Hoffmann wrote: > Both keys exist already: "ac_search" is "find" and "ac_stop" is "stop". > > Fixes: 37810e80553c19f0dac3644924895a9bf5c70785 > Signed-off-by: Gerd Hoffmann > --- > hw/input/ps2.c| 8 > ui/input-keymap.c | 8 >

[Qemu-devel] [RFC 19/29] migration: let dst listen on port always

2017-07-28 Thread Peter Xu
Signed-off-by: Peter Xu --- migration/exec.c | 2 +- migration/fd.c | 2 +- migration/socket.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/migration/exec.c b/migration/exec.c index 08b599e..b4412db 100644 --- a/migration/exec.c +++ b/migration/exec.c @@ -49,7 +4

[Qemu-devel] [RFC 20/29] migration: wakeup dst ram-load-thread for recover

2017-07-28 Thread Peter Xu
On the destination side, we cannot wake up all the threads when we got reconnected. The first thing to do is to wake up the main load thread, so that we can continue to receive valid messages from source again and reply when needed. At this point, we switch the destination VM state from postcopy-p

Re: [Qemu-devel] [PATCH] ui: add pause key to linux_to_qcode

2017-07-28 Thread Daniel P. Berrange
On Fri, Jul 28, 2017 at 08:34:32AM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > ui/input-keymap.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |:

[Qemu-devel] [RFC 21/29] migration: new cmd MIG_CMD_RECV_BITMAP

2017-07-28 Thread Peter Xu
Add a new vm command MIG_CMD_RECV_BITMAP to request received bitmap for one ramblock. Signed-off-by: Peter Xu --- migration/savevm.c | 59 ++ migration/savevm.h | 1 + migration/trace-events | 1 + 3 files changed, 61 insertions(+) diff

[Qemu-devel] [RFC 24/29] migration: new message MIG_RP_MSG_RESUME_ACK

2017-07-28 Thread Peter Xu
Creating new message to reply for MIG_CMD_POSTCOPY_RESUME. One uint32_t is used as payload to let the source know whether destination is ready to continue the migration. Signed-off-by: Peter Xu --- migration/migration.c | 37 + migration/migration.h | 1 +

[Qemu-devel] [RFC 22/29] migration: new message MIG_RP_MSG_RECV_BITMAP

2017-07-28 Thread Peter Xu
Introducing new return path message MIG_RP_MSG_RECV_BITMAP to send received bitmap of ramblock back to source. This is the reply message of MIG_CMD_RECV_BITMAP, it contains not only the header (including the ramblock name), and it was appended with the whole ramblock received bitmap on the destina

[Qemu-devel] [RFC 26/29] migration: synchronize dirty bitmap for resume

2017-07-28 Thread Peter Xu
This patch implements the first part of core RAM resume logic for postcopy. ram_resume_prepare() is provided for the work. When the migration is interrupted by network failure, the dirty bitmap on the source side will be meaningless, because even the dirty bit is cleared, it is still possible that

[Qemu-devel] [RFC 27/29] migration: setup ramstate for resume

2017-07-28 Thread Peter Xu
After we updated the dirty bitmaps of ramblocks, we also need to update the critical fields in RAMState to make sure it is ready for a resume. Signed-off-by: Peter Xu --- migration/ram.c | 35 ++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/migra

[Qemu-devel] [RFC 29/29] migration: reset migrate thread vars when resumed

2017-07-28 Thread Peter Xu
Firstly, MigThrError enumeration is introduced to describe the error in migration_detect_error() better. This gives the migration_thread() a chance to know whether a recovery has happened. Then, if a recovery is detected, migration_thread() will reset its local variables to prepare for that. Sign

Re: [Qemu-devel] [PATCH v2 1/1] s390x/css: check ccw address validity

2017-07-28 Thread Cornelia Huck
On Thu, 27 Jul 2017 17:48:42 +0200 Halil Pasic wrote: > According to the PoP channel command words (CCW) must be doubleword > aligned and 31 bit addressable for format 1 and 24 bit addressable for > format 0 CCWs. > > If the channel subsystem encounters ccw address which does not satisfy missin

Re: [Qemu-devel] [PATCH 1/2] Add more function keys to QEMU

2017-07-28 Thread Daniel P. Berrange
On Thu, Jul 27, 2017 at 10:36:02PM -0400, Programmingkid wrote: > > > On Jul 27, 2017, at 10:54 AM, Daniel P. Berrange > > wrote: > > > > On Thu, Jul 27, 2017 at 10:51:33AM -0400, Programmingkid wrote: > >> There are now keyboards that have 19 function keys. This patch extends > >> QEMU so thes

Re: [Qemu-devel] [PATCH v12 5/8] virtio-balloon: VIRTIO_BALLOON_F_SG

2017-07-28 Thread Wei Wang
On 07/12/2017 08:40 PM, Wei Wang wrote: Add a new feature, VIRTIO_BALLOON_F_SG, which enables to transfer a chunk of ballooned (i.e. inflated/deflated) pages using scatter-gather lists to the host. The implementation of the previous virtio-balloon is not very efficient, because the balloon pages

Re: [Qemu-devel] [PATCH 09/47] MAINTAINERS: add missing entry for virtio/9p

2017-07-28 Thread Greg Kurz
On Fri, 28 Jul 2017 02:35:32 -0300 Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 6da3264d4e..4f9ce6e686 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -10

Re: [Qemu-devel] [Qemu-block] [PATCH v3 1/3] block: add bdrv_get_format_alloc_stat format interface

2017-07-28 Thread Vladimir Sementsov-Ogievskiy
28.07.2017 00:23, John Snow wrote: On 07/12/2017 11:18 AM, Vladimir Sementsov-Ogievskiy wrote: 30.06.2017 03:27, John Snow wrote: On 06/06/2017 12:26 PM, Vladimir Sementsov-Ogievskiy wrote: The function should collect statistics, about used/unused by top-level format driver space (in its .f

Re: [Qemu-devel] [PULL 4/7] ui: add multimedia keys

2017-07-28 Thread Daniel P. Berrange
On Fri, Jul 28, 2017 at 08:21:49AM +0200, Gerd Hoffmann wrote: > On Thu, 2017-07-27 at 18:45 +0100, Daniel P. Berrange wrote: > > On Thu, Jul 27, 2017 at 04:00:22PM +0200, Gerd Hoffmann wrote: > > > Add multimedia keys to QKeyCodes and to the keymaps. > > > > > > Signed-off-by: Gerd Hoffmann > >

Re: [Qemu-devel] [Qemu-ppc] [for-2.11 PATCH 00/26] spapr: add support for PHB hotplug

2017-07-28 Thread Greg Kurz
On Fri, 28 Jul 2017 07:35:34 +0200 Cédric Le Goater wrote: > On 07/28/2017 05:40 AM, David Gibson wrote: > > On Fri, Jul 28, 2017 at 01:27:05PM +1000, Alexey Kardashevskiy wrote: > >> On 28/07/17 02:39, Greg Kurz wrote: > >>> On Wed, 26 Jul 2017 17:31:17 -0300 > >>> Daniel Henrique Barboza w

Re: [Qemu-devel] [Qemu-arm] [PATCH for-2.10 3/5] target/arm: Rename cp15.c6_rgnr to pmsav7.rnr

2017-07-28 Thread Peter Maydell
On 27 July 2017 at 23:58, Philippe Mathieu-Daudé wrote: > On 07/27/2017 07:43 PM, Philippe Mathieu-Daudé wrote: >> >> On 07/27/2017 07:59 AM, Peter Maydell wrote: > > [...] >>> >>> -u32p += env->cp15.c6_rgnr; >>> +u32p += env->pmsav7.rnr; >>> tlb_flush(CPU(cpu)); /* Mappings may have

Re: [Qemu-devel] [RFC] block-insert-node and block-job-delete

2017-07-28 Thread Manos Pitsidianakis
On Thu, Jul 27, 2017 at 06:09:04PM -0400, John Snow wrote: On 07/26/2017 02:23 PM, Manos Pitsidianakis wrote: On Wed, Jul 26, 2017 at 04:12:21PM +0100, Stefan Hajnoczi wrote: On Wed, Jul 26, 2017 at 05:19:24PM +0300, Manos Pitsidianakis wrote: This proposal follows a discussion we had with Ke

Re: [Qemu-devel] [Qemu-arm] [PATCH for-2.10 2/5] target/arm: Don't allow guest to make System space executable for M profile

2017-07-28 Thread Peter Maydell
On 28 July 2017 at 00:59, Philippe Mathieu-Daudé wrote: > Hi Peter, > > On 07/27/2017 07:59 AM, Peter Maydell wrote: >> >> For an M profile v7PMSA, the system space (0xe000 - 0x) can >> never be executable, even if the guest tries to set the MPU registers >> up that way. Enforce this r

Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers

2017-07-28 Thread Peter Maydell
On 28 July 2017 at 09:55, Vladimir Sementsov-Ogievskiy wrote: > To make logs more readable prefix all hex values with '0x' mark. > This is needed for consistency too, as a lot of hex values are already > prefixed with '0x'. Also, bring all hex outputs to the common form - > use '%#', not '0x%'. >

Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers

2017-07-28 Thread Daniel P. Berrange
On Fri, Jul 28, 2017 at 11:55:47AM +0300, Vladimir Sementsov-Ogievskiy wrote: > To make logs more readable prefix all hex values with '0x' mark. > This is needed for consistency too, as a lot of hex values are already > prefixed with '0x'. Also, bring all hex outputs to the common form - > use '%#'

[Qemu-devel] [PATCH for 2.10] pc: make 'pc.rom' readonly when machine has PCI enabled

2017-07-28 Thread Igor Mammedov
looking at bios ROM mapping in QEMU it seems that only isapc (i.e. not PCI enabled machine) requires ROM being mapped as RW in other cases BIOS is mapped as RO. Do the same for option ROM 'pc.rom' when machine has PCI enabled. As useful side-effect pc.rom MemoryRegion stops being put in vhost memo

Re: [Qemu-devel] [PATCH for 2.10 2/8] docs: fix broken paths to docs/interop/qcow2.txt

2017-07-28 Thread Kevin Wolf
Am 28.07.2017 um 03:25 hat Philippe Mathieu-Daudé geschrieben: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers

2017-07-28 Thread Vladimir Sementsov-Ogievskiy
28.07.2017 12:06, Daniel P. Berrange wrote: On Fri, Jul 28, 2017 at 11:55:47AM +0300, Vladimir Sementsov-Ogievskiy wrote: To make logs more readable prefix all hex values with '0x' mark. This is needed for consistency too, as a lot of hex values are already prefixed with '0x'. Also, bring all he

Re: [Qemu-devel] [PATCH v2 1/1] monitor: improve tracing in handle_qmp_command

2017-07-28 Thread Stefan Hajnoczi
On Tue, Jul 25, 2017 at 05:39:23PM +0300, Denis V. Lunev wrote: > Calculate req_json only if trace_handle_qmp_command enabled. > > Signed-off-by: Denis V. Lunev > CC: Stefan Hajnoczi > CC: Lluís Vilanova > CC: Dr. David Alan Gilbert > CC: Markus Armbruster > --- > Changes from v1: > - written

Re: [Qemu-devel] [PATCH 30/47] MAINTAINERS: add missing SPARC entry

2017-07-28 Thread Artyom Tarasenko
On Fri, Jul 28, 2017 at 7:35 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Acked-By: Artyom Tarasenko > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index bb1cb1fc1c..e363a18631 100644 > --- a/MAINTAINERS >

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-28 Thread Peter Maydell
On 20 July 2017 at 10:42, Peter Maydell wrote: > OK, so what should we do for 2.10 ? > > We could: > * implement the changes you suggest above, and mark only >vmstate_register_ram'd blocks as migratable >(would probably need to fix some places which buggily >don't call vmstate_registe

Re: [Qemu-devel] [PATCH V2] vhost: fix a migration failed because of vhost region merge

2017-07-28 Thread Igor Mammedov
On Wed, 26 Jul 2017 19:01:39 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jul 26, 2017 at 04:05:43PM +0200, Igor Mammedov wrote: > > On Tue, 25 Jul 2017 22:47:18 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Jul 25, 2017 at 10:44:38AM +0200, Igor Mammedov wrote: > > > > On Mon, 24

Re: [Qemu-devel] [PATCH 0/3] Channel Path realted CRW generation

2017-07-28 Thread Dong Jia Shi
* Cornelia Huck [2017-07-27 11:46:03 +0200]: > On Thu, 27 Jul 2017 03:54:15 +0200 > Dong Jia Shi wrote: > > > This series is trying to: > > 1. clear up CRW related code. > > 2. generate the right channel path related CRW at the right time. > > > > I did this mainly because it's a requirement f

Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers

2017-07-28 Thread Vladimir Sementsov-Ogievskiy
28.07.2017 12:04, Peter Maydell wrote: On 28 July 2017 at 09:55, Vladimir Sementsov-Ogievskiy wrote: To make logs more readable prefix all hex values with '0x' mark. This is needed for consistency too, as a lot of hex values are already prefixed with '0x'. Also, bring all hex outputs to the com

[Qemu-devel] [PULL for-2.10 1/4] target/s390x: fix pgm irq ilen for stsi

2017-07-28 Thread Cornelia Huck
From: David Hildenbrand The instruction is 4 bytes long. Signed-off-by: David Hildenbrand Message-Id: <20170721125609.7-2-da...@redhat.com> Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck --- target/s390x/misc_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[Qemu-devel] [PULL for-2.10 0/4] s390x: more fixes

2017-07-28 Thread Cornelia Huck
The following changes since commit e01151de165070c25a1b202e9e2392950bd7c8da: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20170727-pull-request' into staging (2017-07-27 15:27:06 +0100) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-201

[Qemu-devel] [PULL for-2.10 3/4] s390x/css: check ccw address validity

2017-07-28 Thread Cornelia Huck
From: Halil Pasic According to the PoP channel command words (CCW) must be doubleword aligned and 31 bit addressable for format 1 and 24 bit addressable for format 0 CCWs. If the channel subsystem encounters a ccw address which does not satisfy this alignment requirement a program-check conditio

[Qemu-devel] [PULL for-2.10 2/4] target/s390x: fix pgm irq ilen in translate_pages()

2017-07-28 Thread Cornelia Huck
From: David Hildenbrand 0 is certainly wrong. Let's use ILEN_AUTO. Signed-off-by: David Hildenbrand Message-Id: <20170721125609.7-3-da...@redhat.com> Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck --- target/s390x/mmu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [PATCH 0/2] trace: fix trace_event_get_state() for SystemTap and LTTng UST

2017-07-28 Thread Stefan Hajnoczi
Trace events that compute their arguments can affect performance. The following idom can be used to avoid computing arguments when the trace event is disabled: if (trace_event_get_state(TRACE_MY_EVENT)) { char *str = g_strdup_printf("Expensive string ...", ...); trace_my_event(str);

[Qemu-devel] [PULL for-2.10 4/4] s390x/css: fix bits must be zero check for TIC

2017-07-28 Thread Cornelia Huck
From: Halil Pasic According to the PoP bit positions 0-3 and 8-32 of the format-1 CCW must contain zeros. Bits 0-3 are already covered by cmd_code validity checking, and bit 32 is covered by the CCW address checking. Bits 8-31 correspond to CCW1.flags and CCW1.count. Currently we only check fo

Re: [Qemu-devel] [PATCH 19/47] MAINTAINERS: add missing qcow2 entry

2017-07-28 Thread Kevin Wolf
Am 28.07.2017 um 07:35 hat Philippe Mathieu-Daudé geschrieben: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 6b83dac812..2dcdda4cd5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1856,6

[Qemu-devel] [PATCH 1/2] trace: add TRACE__BACKEND_DSTATE()

2017-07-28 Thread Stefan Hajnoczi
QEMU keeps track of trace event enabled/disabled state and provides monitor commands to inspect and modify the "dstate". SystemTap and LTTng UST maintain independent enabled/disabled states for each trace event. Introduce a new per-event macro that combines backend-specific dstate like this: #

[Qemu-devel] [PATCH 2/2] trace: check backend dstate in trace_event_get_state()

2017-07-28 Thread Stefan Hajnoczi
Code that checks dstate is unaware of SystemTap and LTTng UST dstate, so the following trace event will not fire when solely enabled by SystemTap or LTTng UST: if (trace_event_get_state(TRACE_MY_EVENT)) { str = g_strdup_printf("Expensive string to generate ...",

Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers

2017-07-28 Thread Cornelia Huck
On Fri, 28 Jul 2017 11:55:47 +0300 Vladimir Sementsov-Ogievskiy wrote: > To make logs more readable prefix all hex values with '0x' mark. > This is needed for consistency too, as a lot of hex values are already > prefixed with '0x'. Also, bring all hex outputs to the common form - > use '%#', not

Re: [Qemu-devel] [PATCH 25/47] MAINTAINERS: add missing MIPS entry

2017-07-28 Thread Yongbok Kim
On 28/07/2017 06:35, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index fa6b0d189a..7354afb9f4 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -182,6 +182,7 @@

Re: [Qemu-devel] [PULL 4/7] ui: add multimedia keys

2017-07-28 Thread Gerd Hoffmann
Hi, > > > Missing Q_KEY_CODE_MEDIASELECT entry - presumably it was supposed > > > to map to  KEY_MEDIA > > > > There is KEY_SELECT too, but not KEY_MEDIASELECT.  Hmm. > > I found a keyboard with a key labelled "Media"  and when pressed > it generates Linux key 171  / AT set1  0xe0 0x01 which i

[Qemu-devel] [PATCH] net/filter-rewriter.c: Fix rewirter checksum bug when use virtio-net

2017-07-28 Thread Zhang Chen
Because vnet_hdr have a offset to net packet, we must add it when use virtio-net. Signed-off-by: Zhang Chen --- net/filter-rewriter.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c index 55a6cf5..72e4928 100644 --- a/net/fi

Re: [Qemu-devel] [PULL 4/7] ui: add multimedia keys

2017-07-28 Thread Daniel P. Berrange
On Fri, Jul 28, 2017 at 11:57:09AM +0200, Gerd Hoffmann wrote: > Hi, > > > > > Missing Q_KEY_CODE_MEDIASELECT entry - presumably it was supposed > > > > to map to  KEY_MEDIA > > > > > > There is KEY_SELECT too, but not KEY_MEDIASELECT.  Hmm. > > > > I found a keyboard with a key labelled "Medi

Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers

2017-07-28 Thread Vladimir Sementsov-Ogievskiy
28.07.2017 12:41, Cornelia Huck wrote: On Fri, 28 Jul 2017 11:55:47 +0300 Vladimir Sementsov-Ogievskiy wrote: To make logs more readable prefix all hex values with '0x' mark. This is needed for consistency too, as a lot of hex values are already prefixed with '0x'. Also, bring all hex outputs

Re: [Qemu-devel] [for-2.10 PATCH] spapr_drc: fix realize and unrealize

2017-07-28 Thread Greg Kurz
On Thu, 27 Jul 2017 15:50:37 -0500 Michael Roth wrote: > Quoting Greg Kurz (2017-07-27 08:45:47) > > If object_property_add_alias() returns an error in realize(), we should > > propagate it to the caller and certainly not unref the DRC. > > Indeed. I think that was the result of this part of t

Re: [Qemu-devel] [RFC 00/29] Migration: postcopy failure recovery

2017-07-28 Thread Peter Xu
On Fri, Jul 28, 2017 at 04:06:09PM +0800, Peter Xu wrote: > As we all know that postcopy migration has a potential risk to lost > the VM if the network is broken during the migration. This series > tries to solve the problem by allowing the migration to pause at the > failure point, and do recovery

Re: [Qemu-devel] [PATCH 3/3] s390x/css: generate channel path initialized CRW for channel path hotplug

2017-07-28 Thread Cornelia Huck
On Thu, 27 Jul 2017 18:15:07 +0200 Halil Pasic wrote: > On 07/27/2017 04:14 PM, Cornelia Huck wrote: > > On Thu, 27 Jul 2017 15:37:08 +0200 > > Halil Pasic wrote: > > > >> On 07/27/2017 01:59 PM, Cornelia Huck wrote: > >>> On Thu, 27 Jul 2017 03:54:18 +0200 > >>> Dong Jia Shi wrote: > >>>

[Qemu-devel] [PATCH for-2.10] exec: Disable "execute from MMIO memory region" feature

2017-07-28 Thread Peter Maydell
Unfortunately it turns out that the implementation of the "execute from MMIO memory region" feature does not interact well with migration: it creates and destroys RAMBlocks on the fly, but migration assumes that the set of RAMBlocks is fixed while migration is in progress. The effect is that migra

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-28 Thread Peter Maydell
On 28 July 2017 at 10:18, Peter Maydell wrote: > Talking to David about this on IRC, even "don't allow > migration" is a bit tricky, because you can't register > a migration-blocker if a migration is already in progress. > Two further options: > * disable this mmio-exec-in-place entirely for 2.10

Re: [Qemu-devel] [PATCH 0/2] trace: fix trace_event_get_state() for SystemTap and LTTng UST

2017-07-28 Thread Denis V. Lunev
On 07/28/2017 12:20 PM, Stefan Hajnoczi wrote: > Trace events that compute their arguments can affect performance. The > following idom can be used to avoid computing arguments when the trace event > is > disabled: > > if (trace_event_get_state(TRACE_MY_EVENT)) { > char *str = g_strdup_pr

[Qemu-devel] [PATCH v3] migration: optimize the downtime

2017-07-28 Thread Jay Zhou
Qemu_savevm_state_cleanup takes about 300ms in my ram migration tests with a 8U24G vm(20G is really occupied), the main cost comes from KVM_SET_USER_MEMORY_REGION ioctl when mem.memory_size = 0 in kvm_set_user_memory_region. In kmod, the main cost is kvm_zap_obsolete_pages, which traverses the acti

Re: [Qemu-devel] [for-2.11 PATCH 18/26] spapr: create DR connectors for PHBs

2017-07-28 Thread Greg Kurz
On Fri, 28 Jul 2017 13:49:25 +1000 David Gibson wrote: > On Tue, Jul 25, 2017 at 08:01:50PM +0200, Greg Kurz wrote: > > From: Michael Roth > > > > Signed-off-by: Michael Roth > > Reviewed-by: David Gibson > > Signed-off-by: Greg Kurz > > > > > --- > > Changes since RFC: > > - rebased ag

Re: [Qemu-devel] [PATCH 1/2] vhost-user-blk: introduce a new vhost-user-blk host device

2017-07-28 Thread Stefan Hajnoczi
On Thu, Jul 27, 2017 at 10:08:49AM +, Liu, Changpeng wrote: > > -Original Message- > > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > > Sent: Thursday, July 27, 2017 5:49 PM > > To: Liu, Changpeng > > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; fel...@nutanix.com; > > m...@re

Re: [Qemu-devel] [PATCH v3] vhost-user: fix watcher need be removed when vhost-user hotplug

2017-07-28 Thread Marc-André Lureau
- Original Message - > From: Yunjian Wang > > "nc" is freed after hotplug vhost-user, but the watcher is not removed. > The QEMU crash when the watcher access the "nc" when socket disconnects. > > Program received signal SIGSEGV, Segmentation fault. > #0 object_get_class (obj=

Re: [Qemu-devel] [PULL for-2.10 0/4] s390x: more fixes

2017-07-28 Thread Peter Maydell
ble in the git repository at: > > git://github.com/cohuck/qemu tags/s390x-20170728 > > for you to fetch changes up to 4add0da64942d83e0564147c0876b01074bde9cb: > > s390x/css: fix bits must be zero check for TIC (2017-07-28 10:06:25 +0200) > > ---

Re: [Qemu-devel] [PATCH 2/2] trace: check backend dstate in trace_event_get_state()

2017-07-28 Thread Daniel P. Berrange
On Fri, Jul 28, 2017 at 10:20:53AM +0100, Stefan Hajnoczi wrote: > Code that checks dstate is unaware of SystemTap and LTTng UST dstate, so > the following trace event will not fire when solely enabled by SystemTap > or LTTng UST: > > if (trace_event_get_state(TRACE_MY_EVENT)) { > str = g_

Re: [Qemu-devel] [RFC] virtio-mem: paravirtualized memory

2017-07-28 Thread David Hildenbrand
Btw, I am thinking about the following addition to the concept: 1. Add a type to each virtio-mem device. This describes the type of the memory region we expose to the guest. Initially, we could have RAM and RAM_HUGE. The latter one would be interesting, because the guest would know that this memo

Re: [Qemu-devel] [PATCH 29/47] MAINTAINERS: add missing SH-4 entry

2017-07-28 Thread Aurelien Jarno
On 2017-07-28 02:35, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 9a0da13bcd..bb1cb1fc1c 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -235,6 +235,7 @@ F:

Re: [Qemu-devel] qemu-system-tricore: segfault when entering "x 0" on the monitor

2017-07-28 Thread Michael Tokarev
27.07.2017 17:30, Eduardo Otubo wrote: > Starting Qemu with "qemu-system-tricore -nographic -M tricore_testboard -S" > and entering "x 0" at the monitor prompt leads to Segmentation fault. This > happens > because tricore_cpu_get_phys_page_debug() is not implemented yet, this > is a temporary work

  1   2   3   4   >