On Thu, Jul 27, 2017 at 10:36:02PM -0400, Programmingkid wrote: > > > On Jul 27, 2017, at 10:54 AM, Daniel P. Berrange <berra...@redhat.com> > > wrote: > > > > On Thu, Jul 27, 2017 at 10:51:33AM -0400, Programmingkid wrote: > >> There are now keyboards that have 19 function keys. This patch extends > >> QEMU so these function keys can be used. > >> > >> Signed-off-by: John Arbuckle <programmingk...@gmail.com> > >> --- > >> qapi-schema.json | 6 +++++- > >> ui/input-keymap.c | 4 ++++ > >> 2 files changed, 9 insertions(+), 1 deletion(-) > >> > >> diff --git a/qapi-schema.json b/qapi-schema.json > >> index 9c6c3e1..a051820 100644 > >> --- a/qapi-schema.json > >> +++ b/qapi-schema.json > >> @@ -4842,6 +4842,10 @@ > >> # @hiragana: since 2.9 > >> # @henkan: since 2.9 > >> # @yen: since 2.9 > >> +# @f16: since 2.10 > >> +# @f17: since 2.10 > >> +# @f18: since 2.10 > >> +# @f19: since 2.10 > >> # > >> # Since: 1.3.0 > >> # > >> @@ -4864,7 +4868,7 @@ > >> 'props', 'undo', 'front', 'copy', 'open', 'paste', 'find', > >> 'cut', > >> 'lf', 'help', 'meta_l', 'meta_r', 'compose', 'pause', > >> 'ro', 'hiragana', 'henkan', 'yen', > >> - 'kp_comma', 'kp_equals', 'power' ] } > >> + 'kp_comma', 'kp_equals', 'power', 'f16', 'f17', 'f18', 'f19'] > >> } > > > > Linux and AT set 1 go all the way to F24, and OS-X goes to F20, so don't > > arbitrarily stop short at F19 > > I think I will future-proof this patch by going all the way to F30.
No, don't do that - we only want QKeyCodes that have a corresponding mapping in the Linux key names, so F24 is the max we should have. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
