Re: [Qemu-devel] [RFC PATCH 08/26] ppc/xive: add flags to the XIVE interrupt source

2017-07-24 Thread Benjamin Herrenschmidt
On Mon, 2017-07-24 at 14:36 +1000, David Gibson wrote: > On Wed, Jul 05, 2017 at 07:13:21PM +0200, Cédric Le Goater wrote: > > These flags define some characteristics of the source : > > > > - XIVE_SRC_H_INT_ESB the Event State Buffer are controlled with a > >specific hca

Re: [Qemu-devel] >256 Virtio-net-pci hotplug Devices

2017-07-24 Thread Marcel Apfelbaum
On 24/07/2017 7:53, Kinsella, Ray wrote: Hi Ray, Thank you for the details, So as it turns out at 512 devices, it is nothing to do SeaBIOS, it was the Kernel again. It is taking quite a while to startup, a little over two hours (7489 seconds). The main culprits appear to be enumerating/init

Re: [Qemu-devel] [RFC PATCH 04/26] ppc/xive: introduce a skeleton for the XIVE interrupt controller model

2017-07-24 Thread Benjamin Herrenschmidt
On Mon, 2017-07-24 at 15:38 +1000, David Gibson wrote: > > Can we assign our logical numbers sparsely, or will that cause other > problems? The main issue is that they probably needs to be the same between XICS and XIVE because by the time we get the CAS call to chose between XICS and XIVE, we ha

Re: [Qemu-devel] [RFC PATCH 00/26] guest exploitation of the XIVE interrupt controller (POWER9)

2017-07-24 Thread Cédric Le Goater
On 07/19/2017 05:55 AM, Benjamin Herrenschmidt wrote: > On Wed, 2017-07-19 at 13:00 +1000, David Gibson wrote: >> So, this is probably obvious, but I'm not considering this a candidate >> for qemu 2.10 (seeing as the soft freeze was yesterday). I'll still >> try to review and, once ready, queue fo

Re: [Qemu-devel] [Device passthrough] Is there a way to passthrough PCIE switch/bridge ?

2017-07-24 Thread Bob Chen
Details attached... I was trying to passthrough multiple GPUs into a single VM, the topology looks like these below. Without the help of PCIE switches, data traversing between GPUs are extremely slow. (depends on memcopy by CPU) So my question is can I passthrough all the switches and PCIE Root,

Re: [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report()

2017-07-24 Thread Paolo Bonzini
On 24/07/2017 08:30, Markus Armbruster wrote: > Markus Armbruster writes: > >> Kevin Wolf writes: >> >>> Am 13.07.2017 um 15:27 hat Markus Armbruster geschrieben: From: Alistair Francis Convert all uses of error_report("warning:"... to use warn_report() instead. This helps s

Re: [Qemu-devel] [PATCH] vhost: fix a migration failed because of vhost region merge

2017-07-24 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, Jul 20, 2017 at 06:22:15PM +0100, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Wed, Jul 19, 2017 at 03:24:27PM +0200, Igor Mammedov wrote: > > > > On Wed, 19 Jul 2017 12:46:13 +0100 > > > > "Dr. Davi

Re: [Qemu-devel] [PATCH v2 0/5] target/s390x: Fix broken build with --disable-tcg

2017-07-24 Thread Thomas Huth
On 21.07.2017 17:07, no-re...@patchew.org wrote: > Hi, > > This series failed build test on s390x host. Please find the details below. [...] > CC s390x-linux-user/target/s390x/interrupt.o > CC sh4eb-linux-user/linux-user/linuxload.o > CC sparc32plus-linux-user/accel/tcg/cpu-ex

Re: [Qemu-devel] [PATCH 4/9] tests: Clean up string interpolation into QMP input (simple cases)

2017-07-24 Thread Markus Armbruster
Eric Blake writes: > On 07/21/2017 11:48 AM, Markus Armbruster wrote: >> I forgot that PRId64 expands into non-standard crap on some systems. >> >> Options: >> >> 1. Outlaw use of PRI macros, limit integer length modifiers for >>conversion specifiers "d" and "u" to "l" and "ll". When PRI m

[Qemu-devel] [Bug 1089005] Re: Qemu does not shutdown with vnc enabled on OS X

2017-07-24 Thread Thomas Huth
Rida, this bug was about stopping QEMU with CTRL-c, so I guess you tried to do something else here? What do you mean by "running process"? The emulated process that is running with QEMU? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [SeaBIOS] [RFC PATCH 0/2] Allow RedHat PCI bridges reserve more buses than necessary during init

2017-07-24 Thread Gerd Hoffmann
On Fri, 2017-07-21 at 13:28 -0400, Kevin O'Connor wrote: > On Fri, Jul 21, 2017 at 03:15:46PM +0300, Marcel Apfelbaum wrote: > > On 21/07/2017 13:04, Gerd Hoffmann wrote: > > > I'd prefer to have a single vendor capability for all resource > > > allocation hints provided by qemu. > > > > Sure, the

Re: [Qemu-devel] [SeaBIOS] [RFC PATCH 0/2] Allow RedHat PCI bridges reserve more buses than necessary during init

2017-07-24 Thread Gerd Hoffmann
Hi, > Maybe we don't want to allocate IO at all, > So value 0 would say do not allocate. > > But we can disable IO by other means. Indeed. As IO is optional for pcie we don't need a qemu-specific extension for that. cheers, Gerd

Re: [Qemu-devel] [RFC 0/5] vfio: Introduce Live migration capability to vfio_mdev device

2017-07-24 Thread Zhang, Yulei
> -Original Message- > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > Sent: Tuesday, June 27, 2017 6:28 PM > To: Zhang, Yulei > Cc: qemu-devel@nongnu.org; Tian, Kevin ; > joonas.lahti...@linux.intel.com; zhen...@linux.intel.com; Zheng, Xiao > ; Wang, Zhi A > Subject: Re: [Q

[Qemu-devel] [PATCH v3 3/5] target/s390x: Rework program_interrupt() and related functions

2017-07-24 Thread Thomas Huth
misc_helper.c won't be compiled with --disable-tcg anymore, but we still need the program_interrupt() function in that case. Move it to interrupt.c instead, and refactor it to re-use the code from trigger_pgm_exception() (for TCG) and enter_pgmcheck() (for KVM, which now got renamed to kvm_s390_pro

[Qemu-devel] [PATCH v3 1/5] target/s390x: Move s390_cpu_dump_state() to helper.c

2017-07-24 Thread Thomas Huth
translate.c can not be compiled with --disable-tcg, but we need the s390_cpu_dump_state() in KVM-only builds, too. So let's move that function to helper.c instead, which will also be compiled when --disable-tcg has been specified. Reviewed-by: Richard Henderson Signed-off-by: Thomas Huth --- ta

[Qemu-devel] [PATCH v3 2/5] target/s390x: Move diag helpers to a separate file

2017-07-24 Thread Thomas Huth
misc_helper.c won't be compiled with --disable-tcg anymore, but we still need the diag helpers in KVM builds, too, so move the helper functions to a separate file. Reviewed-by: Richard Henderson Signed-off-by: Thomas Huth --- target/s390x/Makefile.objs | 2 +- target/s390x/diag.c| 179

[Qemu-devel] [PATCH v3 0/5] target/s390x: Fix broken build with --disable-tcg

2017-07-24 Thread Thomas Huth
Our configure script was recently equipped with a new --disable-tcg parameter, but this does unfortunately not work on s390x hosts yet. Fix the build by moving some code around and by adding some few #ifdefs in the right places. v3: - Fixed the problem when building the s390x-linux-user target - A

[Qemu-devel] [PATCH v3 5/5] target/s390x: Add remaining switches to compile with --disable-tcg

2017-07-24 Thread Thomas Huth
Adding some CONFIG_TCG tests to be finally able to compile QEMU on s390x also without TCG. Reviewed-by: Richard Henderson Signed-off-by: Thomas Huth --- target/s390x/Makefile.objs | 6 +++--- target/s390x/cpu.c | 4 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/tar

[Qemu-devel] [PATCH v3 4/5] target/s390x: Move exception-related functions to a new excp_helper.c file

2017-07-24 Thread Thomas Huth
These functions can not be compiled with --disable-tcg. But since we need the other functions from helper.c in the non-tcg build, we can also not simply remove helper.c from the non-tcg builds. Thus the problematic functions have to be moved into a separate new file instead that we can later omit i

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-24 Thread Vladimir Sementsov-Ogievskiy
21.07.2017 20:04, Lluís Vilanova wrote: Vladimir Sementsov-Ogievskiy writes: Current trace system have a drawback: parameters of trace functions are calculated even if corresponding tracepoint is disabled. Also, it looks like trace function are not actually inlined by compiler (at least for me)

Re: [Qemu-devel] [RFC PATCH 07/26] ppc/xive: add MMIO handlers to the XIVE interrupt source

2017-07-24 Thread Benjamin Herrenschmidt
On Mon, 2017-07-24 at 14:29 +1000, David Gibson wrote: > > +case XIVE_ESB_SET_PQ_00: > > +case XIVE_ESB_SET_PQ_01: > > +case XIVE_ESB_SET_PQ_10: > > +case XIVE_ESB_SET_PQ_11: > > +ret = xive_pq_get(x, lisn); > > +xive_pq_set(x, lisn, (offset >> 8) & 0x3); > > Again

Re: [Qemu-devel] [PATCH] iotests: Remove a few tests from 'quick' group

2017-07-24 Thread Kevin Wolf
Am 17.07.2017 um 16:26 hat Eric Blake geschrieben: > A run of './check -qcow2 -g quick' on my machine produced only > two tests that took longer than 5 seconds; 178 took 18, and > 189 took 7. Remove them from the quick group. > > Signed-off-by: Eric Blake Thanks, applied to the block branch. K

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-24 Thread Michal Hocko
On Wed 19-07-17 20:01:18, Wei Wang wrote: > On 07/19/2017 04:13 PM, Michal Hocko wrote: [... > >All you should need is the check for the page reference count, no? I > >assume you do some sort of pfn walk and so you should be able to get an > >access to the struct page. > > Not necessarily - the g

[Qemu-devel] [PATCH] rtc: fix a infinite loop in windows vm startup

2017-07-24 Thread Peng Hao
When a windows vm starts, periodic timer of rtc will stop several times. windows kernel will check whether REG_A_UIP is changed. REG_C's interrupt flags will not be cleared when periodic timer stops and the update timer will switch to alarm timer. So the expiration time of alarm timer is very long

Re: [Qemu-devel] [PATCH] qobject: Accept "%"PRId64 in qobject_from_jsonf()

2017-07-24 Thread Markus Armbruster
Eric Blake writes: > Commit 1792d7d0 was written because PRId64 expands to non-portable > crap for some libc, and we had testsuite failures on Mac OS as a > result. This in turn makes it difficult to rely on the obvious > conversions of 64-bit values into JSON, requiring things such as > casting

Re: [Qemu-devel] [PATCH] rtc: fix a infinite loop in windows vm startup

2017-07-24 Thread no-reply
Hi, This series failed build test on FreeBSD host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH] rtc: fix a infinite loop in windows vm startup Message-id: 1500916540-33510-1-git-send-email-peng.h...@zte.com.cn === TEST SCRIPT BEGIN === #!/bin/sh # Testing script will

Re: [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./README

2017-07-24 Thread Kevin Wolf
Am 21.07.2017 um 11:34 hat Stefan Hajnoczi geschrieben: > There is not much getting started documentation for qemu-iotests. This > patch explains how to create a new test and covers the overall testing > approach. > > Cc: Ishani Chugh > Signed-off-by: Stefan Hajnoczi > --- > tests/qemu-iotests

Re: [Qemu-devel] [PATCH V2] vhost: fix a migration failed because of vhost region merge

2017-07-24 Thread Igor Mammedov
On Sun, 23 Jul 2017 20:46:11 +0800 Peng Hao wrote: > When a guest that has several hotplugged dimms is migrated, on > destination it will fail to resume. Because regions on source > are merged and on destination the order of realizing devices > is different from on source with dimms, so when part

[Qemu-devel] [PATCH V2] rtc: fix a infinite loop in windows vm startup

2017-07-24 Thread Peng Hao
When a windows vm starts, periodic timer of rtc will stop several times. windows kernel will check whether REG_A_UIP is changed. REG_C's interrupt flags will not be cleared when periodic timer stops and the update timer will switch to alarm timer. So the expiration time of alarm timer is very long

Re: [Qemu-devel] [PATCH V2] rtc: fix a infinite loop in windows vm startup

2017-07-24 Thread no-reply
Hi, This series failed build test on FreeBSD host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH V2] rtc: fix a infinite loop in windows vm startup Message-id: 1500917557-34253-1-git-send-email-peng.h...@zte.com.cn === TEST SCRIPT BEGIN === #!/bin/sh # Testing script w

Re: [Qemu-devel] [PATCH for-2.10 0/2] Bug fixes from byte-based block status

2017-07-24 Thread Kevin Wolf
Am 21.07.2017 um 20:32 hat Eric Blake geschrieben: > Series 2-4 of my byte-based conversion missed soft freeze, so they > are now 2.11 material. However, there are some bug fixes in those > series that we should fix now in 2.10 (patch 1 from series two > on dirty bitmaps, patch 2 extracted from "q

Re: [Qemu-devel] [PATCH V2] rtc: fix a infinite loop in windows vm startup

2017-07-24 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Subject: [Qemu-devel] [PATCH V2] rtc: fix a infinite loop in windows vm startup Message-id: 1500917557-34253-1-git-send-email-peng.h...@zte.com.cn Type: series === TEST SCRIPT BEGIN === #!/bin/bash # Testing script w

Re: [Qemu-devel] [PATCH for-2.10 v3] block: Skip implicit nodes in query-block/blockstats

2017-07-24 Thread Kevin Wolf
Am 20.07.2017 um 15:11 hat Kevin Wolf geschrieben: > Commits 0db832f and 6cdbceb introduced the automatic insertion of filter > nodes above the top layer of mirror and commit block jobs. The > assumption made there was that since libvirt doesn't do node-level > management of the block layer yet, it

Re: [Qemu-devel] [PATCH] qemu-iotests: Avoid unnecessary sleeps

2017-07-24 Thread Kevin Wolf
Am 21.07.2017 um 17:10 hat Kevin Wolf geschrieben: > Test cases 030, 041 and 055 used to sleep for a second after calling > block-job-pause to make sure that the block job had time to actually > get into paused state. We can instead poll its status and use that one > second only as a timeout. > >

Re: [Qemu-devel] [PATCH v3 9/9] checkpatch: add virtio_error and virtqueue_error to error funcs

2017-07-24 Thread Greg Kurz
On Mon, 17 Jul 2017 10:11:52 +0200 Ladi Prosek wrote: > Two more error functions that should not contain newlines. > > Suggested-by: Greg Kurz > Signed-off-by: Ladi Prosek > --- Reviewed-by: Greg Kurz > scripts/checkpatch.pl | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > d

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 17/26] ppc/xive: add hcalls support

2017-07-24 Thread Alexey Kardashevskiy
On 06/07/17 03:13, Cédric Le Goater wrote: > A set of Hypervisor's call are used to configure the interrupt sources > and the event/notification queues of the guest: > >H_INT_GET_SOURCE_INFO >H_INT_SET_SOURCE_CONFIG >H_INT_GET_SOURCE_CONFIG >H_INT_GET_QUEUE_INFO >H_INT_SET_QUEU

Re: [Qemu-devel] [RFC PATCH v2 4/4] pci: enable RedHat PCI bridges to reserve additional buses on PCI init

2017-07-24 Thread Gerd Hoffmann
On Sun, 2017-07-23 at 22:44 +0300, Alexander Bezzubikov wrote: > By the way, any ideas on how to avoid 'bus overstealing' would  > be greatly appreciated. > Static BIOS variable isn't applicable since its value isn't saved > across reboots. I think the reservation hints should be a absolute number

Re: [Qemu-devel] [PATCH v2] docs: add qemu-block-drivers(7) man page

2017-07-24 Thread Kevin Wolf
Am 27.06.2017 um 17:41 hat Stefan Hajnoczi geschrieben: > Block driver documentation is available in qemu-doc.html. It would be > convenient to have documentation for formats, protocols, and filter > drivers in a man page. This is specifically for create options, which is a good start. I think w

[Qemu-devel] [Bug 1705717] Re: Live migration fails with 'host' cpu when KVM is inserted with nested=1

2017-07-24 Thread Dr. David Alan Gilbert
Hi, Can you please give the exact assertion failure. However, I'm confused - I think you're saying that your setup is that both hosts have nested enabled, but this is a migration of top level VM - correct? Does the top level VM have a guest inside it - migration with a nested guest is known not

Re: [Qemu-devel] [RFC PATCH 08/26] ppc/xive: add flags to the XIVE interrupt source

2017-07-24 Thread David Gibson
On Mon, Jul 24, 2017 at 05:00:57PM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2017-07-24 at 14:36 +1000, David Gibson wrote: > > On Wed, Jul 05, 2017 at 07:13:21PM +0200, Cédric Le Goater wrote: > > > These flags define some characteristics of the source : > > > > > > - XIVE_SRC_H_INT_ESB th

Re: [Qemu-devel] [RFC PATCH 04/26] ppc/xive: introduce a skeleton for the XIVE interrupt controller model

2017-07-24 Thread David Gibson
On Mon, Jul 24, 2017 at 05:20:26PM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2017-07-24 at 15:38 +1000, David Gibson wrote: > > > > Can we assign our logical numbers sparsely, or will that cause other > > problems? > > The main issue is that they probably needs to be the same between XICS >

Re: [Qemu-devel] [PATCH] vhost: fix a migration failed because of vhost region merge

2017-07-24 Thread Igor Mammedov
On Sat, 22 Jul 2017 00:30:17 +0300 "Michael S. Tsirkin" wrote: > On Fri, Jul 21, 2017 at 04:41:58PM +0200, Igor Mammedov wrote: > > On Wed, 19 Jul 2017 18:52:56 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Jul 19, 2017 at 03:24:27PM +0200, Igor Mammedov wrote: > > > > On Wed, 19

Re: [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./README

2017-07-24 Thread Stefan Hajnoczi
On Sun, Jul 23, 2017 at 11:18:50AM -0300, Philippe Mathieu-Daudé wrote: > On 07/21/2017 12:51 PM, Stefan Hajnoczi wrote: > > On Fri, Jul 21, 2017 at 07:16:34AM -0500, Eric Blake wrote: > > > On 07/21/2017 04:34 AM, Stefan Hajnoczi wrote: > > > > There is not much getting started documentation for q

Re: [Qemu-devel] [PATCH] pc: acpi: force FADT rev1 for old i440fx machine types

2017-07-24 Thread Ladi Prosek
On Fri, Jul 21, 2017 at 12:12 PM, Igor Mammedov wrote: > On Fri, 21 Jul 2017 11:54:20 +0200 > Ladi Prosek wrote: > >> On Fri, Jul 21, 2017 at 11:32 AM, Igor Mammedov wrote: >> > w2k used to boot on QEMU until we bumped revision of FADT to rev3 >> > (commit 77af8a2b hw/i386: Use Rev3 FADT (ACPI 2

Re: [Qemu-devel] [PULL for-2.10 0/2] please pull xen-20170721-tag

2017-07-24 Thread Peter Maydell
On 22 July 2017 at 01:45, Stefano Stabellini wrote: > The following changes since commit 91939262ffcd3c85ea6a4793d3029326eea1d649: > > configure: Drop ancient Solaris 9 and earlier support (2017-07-21 15:04:05 > +0100) > > are available in the git repository at: > > git://xenbits.xen.org/peop

Re: [Qemu-devel] [PATCH v5 01/17] migrate: Add gboolean return type to migrate_channel_process_incoming

2017-07-24 Thread Juan Quintela
"Daniel P. Berrange" wrote: > On Thu, Jul 20, 2017 at 03:00:23PM +0800, Peter Xu wrote: >> On Wed, Jul 19, 2017 at 04:01:10PM +0100, Dr. David Alan Gilbert wrote: >> > * Juan Quintela (quint...@redhat.com) wrote: >> > > >> > > -void migration_channel_process_incoming(QIOChannel *ioc); >> > > +gb

Re: [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./README

2017-07-24 Thread Peter Maydell
On 21 July 2017 at 10:34, Stefan Hajnoczi wrote: > There is not much getting started documentation for qemu-iotests. This > patch explains how to create a new test and covers the overall testing > approach. > > Cc: Ishani Chugh > Signed-off-by: Stefan Hajnoczi > --- > tests/qemu-iotests/README

[Qemu-devel] [PATCH V3] rtc: fix a infinite loop in windows vm startup

2017-07-24 Thread Peng Hao
When a windows vm starts, periodic timer of rtc will stop several times. windows kernel will check whether REG_A_UIP is changed. REG_C's interrupt flags will not be cleared when periodic timer stops and the update timer will switch to alarm timer. So the expiration time of alarm timer is very long

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-07-24 Thread Jan Kara
On Sun 23-07-17 13:10:34, Dan Williams wrote: > On Sun, Jul 23, 2017 at 11:10 AM, Rik van Riel wrote: > > On Sun, 2017-07-23 at 09:01 -0700, Dan Williams wrote: > >> [ adding Ross and Jan ] > >> > >> On Sun, Jul 23, 2017 at 7:04 AM, Rik van Riel > >> wrote: > >> > > >> > The goal is to increase d

Re: [Qemu-devel] [PATCH for-2.10] hw/display/sm501: Don't use vmstate_register_ram_global()

2017-07-24 Thread Peter Maydell
Ping for review, please? Would be nice to get this into rc0. thanks -- PMM On 17 July 2017 at 17:37, Peter Maydell wrote: > The sm501 device uses vmstate_register_ram_global() to register its > memory region for migration. This means it gets a name that is > assumed to be global to the whole sy

Re: [Qemu-devel] [PATCH V2] vhost: fix a migration failed becauseof vhost region merge

2017-07-24 Thread peng.hao2
> On Sun, 23 Jul 2017 20:46:11 +0800 > Peng Hao wrote: > > When a guest that has several hotplugged dimms is migrated, on > > destination it will fail to resume. Because regions on source > > are merged and on destination the order of realizing devices > > is different from on source with di

Re: [Qemu-devel] [PATCHv2 02/04] colo-compare: Processpactkets in the IOThread ofthe primary

2017-07-24 Thread wang.yong155
>On Thu, Jun 15, 2017 at 12:23:27PM +0800, Jason Wang wrote: >> Paolo, Marc and Stefan: >> >> We want let chardev front-end run in colo comparing IOThread. This looks not >> supported by current chardev frontend API. Any idea/suggestion on how to >> achieve this? > >A follow-up: > >I just

Re: [Qemu-devel] [PATCH for-2.10] util: Introduce include/qemu/cpuid.h

2017-07-24 Thread Peter Maydell
On 19 July 2017 at 05:40, Richard Henderson wrote: > Clang 3.9 passes the CONFIG_AVX2_OPT configure test. However, the > supplied does not contain the bit_AVX2 define that we use > when detecting whether the routine can be enabled. > > Introduce a qemu-specific header that uses the compiler's de

Re: [Qemu-devel] [PATCH RFC v2 0/9] s390x: zPCI detangling

2017-07-24 Thread Christian Borntraeger
On 07/19/2017 03:31 PM, Thomas Huth wrote: > On 19.07.2017 15:03, Cornelia Huck wrote: >> On Tue, 18 Jul 2017 16:24:46 +0200 >> Cornelia Huck wrote: >> >>> Next try of the zPCI detangling, taking cpu models into account. >>> >>> The goal of this is twofold: >>> - Being able to disable PCI support

Re: [Qemu-devel] [PATCH] vhost: fix a migration failed because of vhost region merge

2017-07-24 Thread Igor Mammedov
On Mon, 24 Jul 2017 09:06:33 +0100 "Dr. David Alan Gilbert" wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Thu, Jul 20, 2017 at 06:22:15PM +0100, Dr. David Alan Gilbert wrote: > > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > > On Wed, Jul 19, 2017 at 03:24:27PM +0200,

Re: [Qemu-devel] [PATCH qemu v4 1/3] spapr_iommu: Realloc guest visible TCE table when hot(un)plugging vfio-pci

2017-07-24 Thread Alexey Kardashevskiy
On 24/07/17 15:53, David Gibson wrote: > On Thu, Jul 20, 2017 at 05:22:29PM +1000, Alexey Kardashevskiy wrote: >> This replaces g_malloc() with spapr_tce_alloc_table() as this is >> the standard way of allocating tables and this allows moving the table >> back to KVM when unplugging a VFIO PCI devi

Re: [Qemu-devel] [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

2017-07-24 Thread David Gibson
itory at: > > g...@github.com:aik/qemu.git tags/qemu-slof-20170724 > > for you to fetch changes up to 9f581865da041772eb2e1700c30d75489fe2c971: > > pseries: Update SLOF firmware image (2017-07-24 15:25:04 +1000) pulled, thanks. > > ---

Re: [Qemu-devel] [PATCH v2 0/5] target/s390x: cpu model cleanups + improvements

2017-07-24 Thread Cornelia Huck
On Thu, 20 Jul 2017 14:37:16 +0200 David Hildenbrand wrote: > We want to reuse e.g. s390_get_feat_block() in tcg. Turns out, that > set_bit_inv() doesn't work as expected on other architectures (if we > want to expose the uint8_t[] based data to the VM later), so let's > fix that. > > Some other

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-24 Thread Lluís Vilanova
Vladimir Sementsov-Ogievskiy writes: > 21.07.2017 20:04, Lluís Vilanova wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> Current trace system have a drawback: parameters of trace functions >>> are calculated even if corresponding tracepoint is disabled. Also, it >>> looks like trace function

Re: [Qemu-devel] [RFC PATCH 08/26] ppc/xive: add flags to the XIVE interrupt source

2017-07-24 Thread Benjamin Herrenschmidt
On Mon, 2017-07-24 at 19:50 +1000, David Gibson wrote: > On Mon, Jul 24, 2017 at 05:00:57PM +1000, Benjamin Herrenschmidt wrote: > > On Mon, 2017-07-24 at 14:36 +1000, David Gibson wrote: > > > On Wed, Jul 05, 2017 at 07:13:21PM +0200, Cédric Le Goater wrote: > > > > These flags define some charact

Re: [Qemu-devel] [PATCH v5 02/17] migration: Create migration_ioc_process_incoming()

2017-07-24 Thread Juan Quintela
"Daniel P. Berrange" wrote: > On Mon, Jul 17, 2017 at 03:42:23PM +0200, Juan Quintela wrote: >> We need to receive the ioc to be able to implement multifd. >> >> Signed-off-by: Juan Quintela >> --- >> migration/channel.c | 3 +-- >> migration/migration.c | 16 +--- >> migration/m

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-24 Thread Denis V. Lunev
On 07/24/2017 02:07 PM, Lluís Vilanova wrote: > Vladimir Sementsov-Ogievskiy writes: > >> 21.07.2017 20:04, Lluís Vilanova wrote: >>> Vladimir Sementsov-Ogievskiy writes: >>> Current trace system have a drawback: parameters of trace functions are calculated even if corresponding tracepoin

Re: [Qemu-devel] About virtio device hotplug in Q35!

2017-07-24 Thread Zhong Yang
On Mon, Jul 24, 2017 at 08:05:54AM +0300, Marcel Apfelbaum wrote: + Anthony > On 24/07/2017 4:47, Zhong Yang wrote: > >Hello all, > > > > Hi, > > >When we did virtio device hotplug in Q35 platform, which always failed in > >hotplug. > > > > Can we please see the QEMU command line and the desc

Re: [Qemu-devel] [PATCH for-2.10 0/2] Bug fixes from byte-based block status

2017-07-24 Thread Stefan Hajnoczi
On Fri, Jul 21, 2017 at 01:32:41PM -0500, Eric Blake wrote: > Series 2-4 of my byte-based conversion missed soft freeze, so they > are now 2.11 material. However, there are some bug fixes in those > series that we should fix now in 2.10 (patch 1 from series two > on dirty bitmaps, patch 2 extracte

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-24 Thread Stefan Hajnoczi
On Fri, Jul 21, 2017 at 08:04:17PM +0300, Lluís Vilanova wrote: > Vladimir Sementsov-Ogievskiy writes: > > > Current trace system have a drawback: parameters of trace functions > > are calculated even if corresponding tracepoint is disabled. Also, it > > looks like trace function are not actually

Re: [Qemu-devel] [PATCH v3 0/5] target/s390x: Fix broken build with --disable-tcg

2017-07-24 Thread Cornelia Huck
On Mon, 24 Jul 2017 10:52:45 +0200 Thomas Huth wrote: > Our configure script was recently equipped with a new --disable-tcg > parameter, but this does unfortunately not work on s390x hosts yet. Fix > the build by moving some code around and by adding some few #ifdefs > in the right places. > > v

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-24 Thread Stefan Hajnoczi
On Fri, Jul 21, 2017 at 05:31:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Current trace system have a drawback: parameters of trace functions > are calculated even if corresponding tracepoint is disabled. Also, it > looks like trace function are not actually inlined by compiler (at > least fo

Re: [Qemu-devel] [PATCH 2/2] monitor: improve tracing in handle_qmp_command

2017-07-24 Thread Stefan Hajnoczi
On Fri, Jul 21, 2017 at 05:31:49PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Calculate req_json only if trace_handle_qmp_command enabled. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Is there a real-world performance issue? (I'm not against this change but it's important to understand the

Re: [Qemu-devel] [PATCH] hw/core/loader: do not check for regions overlap

2017-07-24 Thread Hua Yanghao
> I have seen ELF files which have this overlap and > where both segments are PT_LOAD. (I think in the cases > I've seen the contents in both segments agree rather than > being different data, but a loader is not going to be > expected to do a comparison of the file data.) Hmm ... OK. there are def

Re: [Qemu-devel] [RFC PATCH 08/26] ppc/xive: add flags to the XIVE interrupt source

2017-07-24 Thread Cédric Le Goater
On 07/24/2017 01:07 PM, Benjamin Herrenschmidt wrote: > On Mon, 2017-07-24 at 19:50 +1000, David Gibson wrote: >> On Mon, Jul 24, 2017 at 05:00:57PM +1000, Benjamin Herrenschmidt wrote: >>> On Mon, 2017-07-24 at 14:36 +1000, David Gibson wrote: On Wed, Jul 05, 2017 at 07:13:21PM +0200, Cédric

Re: [Qemu-devel] [PATCH] qobject: Accept "%"PRId64 in qobject_from_jsonf()

2017-07-24 Thread Eric Blake
On 07/24/2017 04:06 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Commit 1792d7d0 was written because PRId64 expands to non-portable >> crap for some libc, and we had testsuite failures on Mac OS as a >> result. This in turn makes it difficult to rely on the obvious >> conversions of 64

Re: [Qemu-devel] [PATCH V3] rtc: fix a infinite loop in windows vm startup

2017-07-24 Thread Paolo Bonzini
On 24/07/2017 20:35, Peng Hao wrote: > When a windows vm starts, periodic timer of rtc will stop several times. > windows kernel will check whether REG_A_UIP is changed. REG_C's interrupt > flags will not be cleared when periodic timer stops and the update timer > will switch to alarm timer. So the

Re: [Qemu-devel] [PATCH] hw/core/loader: do not check for regions overlap

2017-07-24 Thread Peter Maydell
On 24 July 2017 at 12:42, Hua Yanghao wrote: >> If you're hitting this error case then I think the >> affected segments must both be of type PT_LOAD. >> (If you're not sure you can post here the output >> of running 'objdump -p' on the binary or otherwise >> show us the program header.) > > Here

Re: [Qemu-devel] [PATCH V2] vhost: fix a migration failed becauseof vhost region merge

2017-07-24 Thread Igor Mammedov
On Mon, 24 Jul 2017 18:32:35 +0800 (CST) wrote: > > On Sun, 23 Jul 2017 20:46:11 +0800 > > > > > > > Peng Hao wrote: > > > > When a guest that has several hotplugged dimms is migrated, on > > > destination it will fail to resume. Because regions on source > > > are merged and on destin

Re: [Qemu-devel] [PATCH V3] rtc: fix a infinite loop in windows vm startup

2017-07-24 Thread Eric Blake
On 07/24/2017 01:35 PM, Peng Hao wrote: > When a windows vm starts, periodic timer of rtc will stop several times. > windows kernel will check whether REG_A_UIP is changed. REG_C's interrupt > flags will not be cleared when periodic timer stops and the update timer > will switch to alarm timer. So

[Qemu-devel] [PULL v2 00/10] QAPI patches for 2017-07-18

2017-07-24 Thread Markus Armbruster
The following changes since commit df95f1a298a3e16c80293343143dcedbe7978f6c: Merge remote-tracking branch 'remotes/sstabellini/tags/xen-20170721-tag' into staging (2017-07-24 10:01:15 +0100) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2017-07-18-v

[Qemu-devel] [PULL v2 01/10] qapi: Separate type QNull from QObject

2017-07-24 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange --- include/qapi/qmp/qobject.h| 10 +++--- qapi/qobject-output-visitor.c | 2 +- qobject/json-parser.c | 2 +- qobject/qnull.c | 8 +--- target/i386/cpu.c |

[Qemu-devel] [PULL v2 04/10] tests/test-qobject-input-visitor: Drop redundant test

2017-07-24 Thread Markus Armbruster
test_visitor_in_alternate() tests UserDefAlternate with inadmissible input. test_visitor_in_fail_alternate() does basically the same. Drop the former, keep the latter. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange --- tests/test-qobject-input-visitor

[Qemu-devel] [PULL v2 03/10] qapi: Introduce a first class 'null' type

2017-07-24 Thread Markus Armbruster
I expect the 'null' type to be useful mostly for members of alternate types. Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrange Reviewed-by: Eric Blake Signed-off-by: Markus Armbruster --- docs/devel/qapi-code-gen.txt| 10 ++ include/qapi/qmp/qobject.h

[Qemu-devel] [PULL v2 10/10] migration: Use JSON null instead of "" to reset parameter to default

2017-07-24 Thread Markus Armbruster
migrate-set-parameters sets migration parameters according to is arguments like this: * Present means "set the parameter to this value" * Absent means "leave the parameter unchanged" * Except for parameters tls_creds and tls_hostname, "" means "reset the parameter to its default value The fir

[Qemu-devel] [PULL v2 06/10] hmp: Clean up and simplify hmp_migrate_set_parameter()

2017-07-24 Thread Markus Armbruster
The bulk of hmp_migrate_set_parameter()'s code sets one member of MigrationParameters according to the command's arguments. It uses a string visitor for integer and boolean members, but not for string and size members. It calls visit_type_bool() right away, but delays visit_type_int() some. The

[Qemu-devel] [PULL v2 07/10] migration: Clean up around tls_creds, tls_hostname

2017-07-24 Thread Markus Armbruster
Optional MigrationParameters members tls_creds and tls_hostname can't actually be absent outside qmp_migrate_set_parameters() since commit 4af245d (v2.9.0). Note that commit 4af245d reverted the part of commit de63ab6 (v2.8.0) that made tls_creds and tls_hostname absent instead of "" in the value

[Qemu-devel] [PULL v2 08/10] migration: Add TODO comments on duplication of QAPI_CLONE()

2017-07-24 Thread Markus Armbruster
qmp_query_migrate_parameters() and qmp_migrate_set_parameters() effectively duplicate QAPI_CLONE() inline. Add suitable TODO comments. Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrange Reviewed-by: Eric Blake --- migration/migration.c | 3 +++ 1 file changed, 3 insertions(+) d

[Qemu-devel] [PULL v2 02/10] qapi: Use QNull for a more regular visit_type_null()

2017-07-24 Thread Markus Armbruster
Make visit_type_null() take an @obj argument like its buddies. This helps keep the next commit simple. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange --- hw/ppc/spapr_drc.c | 4 +++- include/qapi/visitor-impl.h | 3 ++- incl

Re: [Qemu-devel] [PATCHv2 02/04] colo-compare: Processpactkets in the IOThread ofthe primary

2017-07-24 Thread Paolo Bonzini
On 24/07/2017 12:38, wang.yong...@zte.com.cn wrote: > finally use g_main_loop_run to replace aio_poll in the > iothread_run function. That would make the performance of virtio-blk with iothreads worse, unfortunately. aio_poll is much more optimized than g_main_loop_run. Paolo > After that IOTh

[Qemu-devel] [PULL v2 05/10] block: Use JSON null instead of "" to disable backing file

2017-07-24 Thread Markus Armbruster
BlockdevRef is an alternate of BlockdevOptions (inline definition) and str (reference to an existing block device by name). BlockdevRef value "" is special: "no block device should be referenced." It's actually interpreted that way in just one place: optional member @backing of COW formats. Sema

[Qemu-devel] [PULL v2 09/10] migration: Unshare MigrationParameters struct for now

2017-07-24 Thread Markus Armbruster
Commit de63ab6 "migrate: Share common MigrationParameters struct" reused MigrationParameters for the arguments of migrate-set-parameters, with the following rationale: It is rather verbose, and slightly error-prone, to repeat the same set of parameters for input (migrate-set-parameters)

Re: [Qemu-devel] [PATCH for-2.10 0/2] Bug fixes from byte-based block status

2017-07-24 Thread Eric Blake
On 07/21/2017 01:32 PM, Eric Blake wrote: > Series 2-4 of my byte-based conversion missed soft freeze, so they > are now 2.11 material. However, there are some bug fixes in those > series that we should fix now in 2.10 (patch 1 from series two > on dirty bitmaps, patch 2 extracted from "qcow2: Swi

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-07-24 Thread Pankaj Gupta
> On Sun 23-07-17 13:10:34, Dan Williams wrote: > > On Sun, Jul 23, 2017 at 11:10 AM, Rik van Riel wrote: > > > On Sun, 2017-07-23 at 09:01 -0700, Dan Williams wrote: > > >> [ adding Ross and Jan ] > > >> > > >> On Sun, Jul 23, 2017 at 7:04 AM, Rik van Riel > > >> wrote: > > >> > > > >> > The go

Re: [Qemu-devel] [PATCH for-2.10 0/2] Update qemu-nbd version

2017-07-24 Thread Eric Blake
On 07/21/2017 08:50 AM, Eric Blake wrote: > 陳培泓 reported that 'qemu-nbd -V' was stuck at 0.0.1; fix that, > along with a nearby style issue noticed in the process. Not > having a useful version number is a bug in my eyes, so I'm > proposing this series for 2.10. > > Eric Blake (2): > qemu-nbd:

Re: [Qemu-devel] [PATCH for-2.10 0/2] Bug fixes from byte-based block status

2017-07-24 Thread Eric Blake
On 07/24/2017 07:05 AM, Eric Blake wrote: > On 07/21/2017 01:32 PM, Eric Blake wrote: >> Series 2-4 of my byte-based conversion missed soft freeze, so they >> are now 2.11 material. However, there are some bug fixes in those >> series that we should fix now in 2.10 (patch 1 from series two >> on d

Re: [Qemu-devel] [PATCH] hw/core/loader: do not check for regions overlap

2017-07-24 Thread Hua Yanghao
> Yep, this is complaining because you have two LOAD > segments which overlap: > LOAD off0x00e0 vaddr 0x6000 paddr 0x6000 align 2**5 > filesz 0x0007773c memsz 0x00077c00 flags rwx > > which goes from 0x6000 up to 0x600077bff, and > > LOAD off0x00077820 va

[Qemu-devel] [PATCH] vfio/pci-quirks: Set non-zero GMS memory size for IGD

2017-07-24 Thread Dmitry Fleytman
There is a claim that GMS memory is unused however Intel Windows 10 drivers starting from V.4534 (10/7/2016) allocate extra ~4G memory when GMS size set to 0. This patch fixes this issue by seting IGD GMS memory size to minimum by changing default value of x-igd-gms device parameter. Signed-off-b

Re: [Qemu-devel] [PATCH 05/11] qemu.py: Use custom exceptions rather than Exception

2017-07-24 Thread Lukáš Doktor
Dne 21.7.2017 v 20:42 Eduardo Habkost napsal(a): > On Fri, Jul 21, 2017 at 08:37:34AM +0200, Lukáš Doktor wrote: >> Dne 20.7.2017 v 20:27 Eduardo Habkost napsal(a): >>> On Thu, Jul 20, 2017 at 06:28:09PM +0200, Lukáš Doktor wrote: The naked Exception should not be widely used. It makes sense t

[Qemu-devel] [PATCH] hmp/(p)memsave: Allow >32bit file size

2017-07-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" memsave and pmemsave only take 32bit size arguments in HMP at the moment; let them take 64bit values. Reported-by: Pierre Kim Signed-off-by: Dr. David Alan Gilbert --- hmp-commands.hx | 4 ++-- hmp.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deleti

Re: [Qemu-devel] [PATCH] error: Revert unwanted change of warning messages

2017-07-24 Thread Kevin Wolf
Am 19.07.2017 um 09:33 hat Markus Armbruster geschrieben: > Commit 97f4030 changed warning messages from > > timestamp-if-enabled progname ":" location "warning: " message > > to > > "warning: " timestamp-if-enabled progname ":" location message > > This regressed qemu-iotests 051. Put

Re: [Qemu-devel] [PATCH 19/29] disas: use QEMU_IS_ALIGNED macro

2017-07-24 Thread Eric Blake
On 07/23/2017 09:52 AM, Paolo Bonzini wrote: > > But I agree that QEMU_IS_ALIGNED looks weird here. I think it should > mostly be used when the argument is a pointer, to hide the cast. Uses > for non-pointer arguments should be decided on a one-by-one basis; "is > the first argument an address"

Re: [Qemu-devel] [RFC 10/29] vhub: Open userfaultfd

2017-07-24 Thread Maxime Coquelin
On 06/28/2017 09:00 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Open a userfaultfd (on a postcopy_advise) and send it back in the reply to the qemu for it to monitor. Signed-off-by: Dr. David Alan Gilbert --- contrib/libvhost-user/libvhost-user.c | 24 ++

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-24 Thread Denis V. Lunev
On 07/24/2017 02:34 PM, Stefan Hajnoczi wrote: > On Fri, Jul 21, 2017 at 05:31:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> Current trace system have a drawback: parameters of trace functions >> are calculated even if corresponding tracepoint is disabled. Also, it >> looks like trace function

Re: [Qemu-devel] [PATCH for-2.10] util: Introduce include/qemu/cpuid.h

2017-07-24 Thread Peter Maydell
On 24 July 2017 at 11:40, Peter Maydell wrote: > On 19 July 2017 at 05:40, Richard Henderson wrote: >> Clang 3.9 passes the CONFIG_AVX2_OPT configure test. However, the >> supplied does not contain the bit_AVX2 define that we use >> when detecting whether the routine can be enabled. >> >> Intro

  1   2   3   4   5   >