"Daniel P. Berrange" <berra...@redhat.com> wrote: > On Thu, Jul 20, 2017 at 03:00:23PM +0800, Peter Xu wrote: >> On Wed, Jul 19, 2017 at 04:01:10PM +0100, Dr. David Alan Gilbert wrote: >> > * Juan Quintela (quint...@redhat.com) wrote: >> > > >> > > -void migration_channel_process_incoming(QIOChannel *ioc); >> > > +gboolean migration_channel_process_incoming(QIOChannel *ioc); >> > >> > Can you add a comment here that says what the return value means.
Added comment for the two functions (in the .c file through) >> >> And, looks like we have G_SOURCE_CONTINUE and G_SOURCE_REMOVE: Used this ones, thanks. >> https://developer.gnome.org/glib/stable/glib-The-Main-Event-Loop.html#G-SOURCE-CONTINUE:CAPS >> >> Maybe we can use them as well? > > Those are newer than our min required glib version, though we could > add compat defines for them Added the compatibility macros. Thanks to all of you, Juan.
