Re: [Qemu-devel] [PATCH v12 5/8] virtio-balloon: VIRTIO_BALLOON_F_SG

2017-07-14 Thread Wei Wang
On 07/14/2017 04:19 AM, Michael S. Tsirkin wrote: On Thu, Jul 13, 2017 at 03:42:35PM +0800, Wei Wang wrote: On 07/12/2017 09:56 PM, Michael S. Tsirkin wrote: So the way I see it, there are several issues: - internal wait - forces multiple APIs like kick/kick_sync note how kick_sync can fai

Re: [Qemu-devel] [RFC v5 0/8] ARM SMMUv3 Emulation Support

2017-07-14 Thread Tomasz Nowicki
Hi Eric, With fixes in comments that I made, I was able to run VM with virtio-blk-pci and virtio-net-pci devices. I have tried vhost-net as well but I am seeing outgoing packets payload corrupted from host perspective, tcpdump on host tun i/f shows zeroes in packet payload. However, tcpdump

Re: [Qemu-devel] [RFC v2 0/8] VIRTIO-IOMMU device

2017-07-14 Thread Tian, Kevin
> From: Jean-Philippe Brucker [mailto:jean-philippe.bruc...@arm.com] > Sent: Friday, July 7, 2017 11:15 PM > > On 07/07/17 07:21, Tian, Kevin wrote: > > sorry I didn't quite get this part, and here is my understanding: > > > > Guest programs vIOMMU to map a gIOVA (used by MSI to a GPA > > of doorb

[Qemu-devel] [Bug 984516] Re: should use sdl-config for static build not pkg-config

2017-07-14 Thread Thomas Huth
Finally fixed here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=5f37e6d4a7b22ccf1bb8fa4 ** Changed in: qemu Status: New => Fix Committed ** Changed in: qemu Assignee: (unassigned) => Thomas Huth (th-huth) -- You received this bug notification because you are a member of qemu- dev

[Qemu-devel] [RFC v2 PATCH 0/2] VFIO integration

2017-07-14 Thread Bharat Bhushan
This patch series allows PCI pass-through using virtio-iommu. This series is based on: - virtio-iommu specification written by Jean-Philippe Brucker [RFC 0/3] virtio-iommu: a paravirtualized IOMMU, - virtio-iommu driver by Jean-Philippe Brucker [RFC PATCH linux] iommu: Add virtio-iommu d

[Qemu-devel] [RFC v2 PATCH 1/2] target/arm/kvm: Translate the MSI doorbell in kvm_arch_fixup_msi_route

2017-07-14 Thread Bharat Bhushan
Translate msi address if device is behind virtio-iommu. This logic is similar to vSMMUv3/Intel iommu emulation. This RFC patch does not handle the case where both vsmmuv3 and virtio-iommu are available. Signed-off-by: Bharat Bhushan --- v1-v2: - Added trace events - removed vSMMU3 link in pa

Re: [Qemu-devel] [PATCH v5 3/4] qcow2: add shrink image support

2017-07-14 Thread Kevin Wolf
Am 13.07.2017 um 19:28 hat Pavel Butsykin geschrieben: > On 13.07.2017 17:36, Max Reitz wrote: > >On 2017-07-13 10:41, Kevin Wolf wrote: > >>Am 12.07.2017 um 18:58 hat Max Reitz geschrieben: > >>>On 2017-07-12 16:52, Kevin Wolf wrote: > Am 12.07.2017 um 13:46 hat Pavel Butsykin geschrieben: > >

[Qemu-devel] [RFC v2 PATCH 2/2] virtio-iommu: vfio integration with virtio-iommu

2017-07-14 Thread Bharat Bhushan
This patch allows virtio-iommu protection for PCI device-passthrough. MSI region is mapped by current version of virtio-iommu driver. This MSI region mapping in not getting pushed on hw iommu vfio_get_vaddr() allows only ram-region. This RFC patch needed to be improved. Signed-off-by: Bharat Bhus

Re: [Qemu-devel] [PATCH v3 4/4] intel_iommu: implement mru list for iotlb

2017-07-14 Thread Jason Wang
On 2017年07月14日 12:32, Peter Xu wrote: On Thu, Jul 13, 2017 at 04:48:42PM +0800, Jason Wang wrote: On 2017年07月12日 16:13, Peter Xu wrote: It is not wise to disgard all the IOTLB cache when cache size reaches max, but that's what we do now. A slightly better (but still simple) way to do this is

Re: [Qemu-devel] [PATCH 0/3] Fix qemu-bridge-helper with SUID

2017-07-14 Thread Jason Wang
On 2017年07月11日 22:54, Daniel P. Berrange wrote: On Tue, Jul 11, 2017 at 03:10:43PM +0200, Michal Privoznik wrote: On 06/22/2017 05:58 PM, Michal Privoznik wrote: On 05/30/2017 10:23 AM, Michal Privoznik wrote: For more description see patch 3. Long story short, if the bridge helper runs with

[Qemu-devel] [PATCH V2] target-i386:kvm_get/put_vcpu_events don't handle sipi_vector

2017-07-14 Thread Peng Hao
qemu call kvm_get_vcpu_events, and kernel return sipi_vector always 0, never valid when reporting to user space. But qemu call kvm_put_vcpu_events will make sipi_vector in kernel be 0. This will accidently modify sipi_vector when sipi_vector in kernel is not 0. Signed-off-by: Peng Hao Reviewed-by

Re: [Qemu-devel] [PATCH 0/3] Fix qemu-bridge-helper with SUID

2017-07-14 Thread Jason Wang
On 2017年07月14日 15:31, Jason Wang wrote: On 2017年07月11日 22:54, Daniel P. Berrange wrote: On Tue, Jul 11, 2017 at 03:10:43PM +0200, Michal Privoznik wrote: On 06/22/2017 05:58 PM, Michal Privoznik wrote: On 05/30/2017 10:23 AM, Michal Privoznik wrote: For more description see patch 3. Long s

Re: [Qemu-devel] [PATCH] virtion-net: Prefer is_power_of_2()

2017-07-14 Thread Jason Wang
On 2017年07月13日 15:44, Michal Privoznik wrote: We have a function that checks if given number is power of two. We should prefer it instead of expanding the check on our own. Signed-off-by: Michal Privoznik --- hw/net/virtio-net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [Qemu-devel] [PATCH v5 3/4] qcow2: add shrink image support

2017-07-14 Thread Kevin Wolf
Am 13.07.2017 um 19:18 hat Pavel Butsykin geschrieben: > On 13.07.2017 11:41, Kevin Wolf wrote: > >Am 12.07.2017 um 18:58 hat Max Reitz geschrieben: > >>On 2017-07-12 16:52, Kevin Wolf wrote: > >>>Am 12.07.2017 um 13:46 hat Pavel Butsykin geschrieben: > This patch add shrinking of the image fil

Re: [Qemu-devel] [PATCH 1/7] s390x/cpumodel: wire up new hardware features

2017-07-14 Thread Cornelia Huck
On Thu, 13 Jul 2017 18:03:03 +0200 Christian Borntraeger wrote: > From: "Jason J. Herne" > > Some new guest features have been introduced recently. Lets wire s/Lets/Let's/ :) > them up in the CPU model. > > Signed-off-by: Jason J. Herne > Acked-by: Christian Borntraeger > Signed-off-by: C

[Qemu-devel] [PATCH] spapr: fix memory leak in spapr_core_pre_plug()

2017-07-14 Thread Greg Kurz
In case of error, we must ensure the dynamically allocated base_core_type is freed, like it is done everywhere else in this function. This is a regression introduced in QEMU 2.9 by commit 8149e2992f78. Signed-off-by: Greg Kurz --- hw/ppc/spapr.c |4 ++-- 1 file changed, 2 insertions(+), 2 d

Re: [Qemu-devel] [PATCH 3/7] s390x/cpumodel: add esop/esop2 to z12 model

2017-07-14 Thread Cornelia Huck
On Thu, 13 Jul 2017 18:03:05 +0200 Christian Borntraeger wrote: > From: "Jason J. Herne" > > Add esop and esop2 features to z12 model where esop2 was originally > introduced. > Provide a mechanism to disable features in compatibility machines and use this > method to disable esop and esop2 whe

Re: [Qemu-devel] [PATCH 3/7] s390x/cpumodel: add esop/esop2 to z12 model

2017-07-14 Thread Christian Borntraeger
On 07/14/2017 09:55 AM, Cornelia Huck wrote: > On Thu, 13 Jul 2017 18:03:05 +0200 > Christian Borntraeger wrote: > >> From: "Jason J. Herne" >> >> Add esop and esop2 features to z12 model where esop2 was originally >> introduced. >> Provide a mechanism to disable features in compatibility machi

Re: [Qemu-devel] [PATCH 4/7] s390x/kvm: Enable KSS facility for nested virtualization

2017-07-14 Thread Cornelia Huck
On Thu, 13 Jul 2017 18:03:06 +0200 Christian Borntraeger wrote: > From: Farhan Ali > > If the host supports keyless subset (KSS) then first level > guest (G2) should enable KSS facility as well. > > Signed-off-by: Farhan Ali > Reviewed-by: Eric Farman > Signed-off-by: Christian Borntraeger

Re: [Qemu-devel] [PATCH v2 01/29] i386: use ROUND_UP macro

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:31 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check (with the option OnlyAlignUp) to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Juan Quintela --- target/i386/arch_dump.c | 16

Re: [Qemu-devel] [PATCH v2 02/29] vnc: use QEMU_ALIGN_DOWN

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:31 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- ui/vnc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderso

Re: [Qemu-devel] [PATCH v2 04/29] vhost: use QEMU_ALIGN_DOWN

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:31 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin --- hw/virtio/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

Re: [Qemu-devel] [PATCH v2 05/29] i8254: use QEMU_ALIGN_DOWN

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:31 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- hw/timer/i8254_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richa

Re: [Qemu-devel] [PATCH v2 03/29] vhdx: use QEMU_ALIGN_DOWN

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:31 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- block/vhdx-log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderso

[Qemu-devel] [PATCH v13 00/26] translate: [tcg] Generic translation framework

2017-07-14 Thread Lluís Vilanova
This series proposes a generic (target-agnostic) instruction translation framework. It basically provides a generic main loop for instruction disassembly, which calls target-specific functions when necessary. This generalization makes inserting new code in the main loop easier, and helps in keepin

[Qemu-devel] [PATCH v13 01/26] Pass generic CPUState to gen_intermediate_code()

2017-07-14 Thread Lluís Vilanova
Needed to implement a target-agnostic gen_intermediate_code() in the future. Signed-off-by: Lluís Vilanova Reviewed-by: David Gibson Reviewed-by: Richard Henderson Reviewed-by: Alex Benneé --- accel/tcg/translate-all.c |2 +- include/exec/exec-all.h |2 +- target/alpha/trans

[Qemu-devel] [PATCH v13 02/26] target: [tcg] Use a generic enum for DISAS_ values

2017-07-14 Thread Lluís Vilanova
Used later. An enum makes expected values explicit and bounds the value space of switches. Signed-off-by: Lluís Vilanova Reviewed-by: Emilio G. Cota Reviewed-by: Richard Henderson --- include/exec/exec-all.h |6 -- include/exec/translator.h | 40

Re: [Qemu-devel] [PULL 23/41] mttcg/i386: Patch instruction using async_safe_* framework

2017-07-14 Thread Thomas Huth
On 13.07.2017 17:16, Alex Bennée wrote: > > Paolo Bonzini writes: > >> From: Pranith Kumar >> >> In mttcg, calling pause_all_vcpus() during execution from the >> generated TBs causes a deadlock if some vCPU is waiting for exclusive >> execution in start_exclusive(). Fix this by using the aync_s

Re: [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros

2017-07-14 Thread gengdongjiu
Dear Michael, On 2017/7/14 1:13, Michael S. Tsirkin wrote: > On Thu, Jul 13, 2017 at 05:33:30PM +0200, Laszlo Ersek wrote: >> On 07/13/17 14:00, gengdongjiu wrote: >>> Laszlo, >>> Thank you for your review and comments. >>> >>> >>> On 2017/7/13 18:33, Laszlo Ersek wrote: On 07/12/17 04:08,

[Qemu-devel] [PATCH v13 03/26] target: [tcg] Add generic translation framework

2017-07-14 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- accel/tcg/Makefile.objs |1 accel/tcg/translator.c| 141 + include/exec/translator.h | 94 ++ 3 files changed, 236 insertions(+) create mode 100644 accel/tcg/translator.c diff

Re: [Qemu-devel] [PATCH v2 06/29] pcspk: use QEMU_ALIGN_DOWN

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:31 AM, Marc-André Lureau wrote: -s->samples = (PCSPK_BUF_LEN * PIT_FREQ / m * m / (PIT_FREQ >> 1) + 1) >> 1; +s->samples = (QEMU_ALIGN_DOWN(PCSPK_BUF_LEN * PIT_FREQ, m) / (PIT_FREQ >> 1) + 1) >> 1; Wow. Um. Two divisions? Irritatingly, "m" appears to be the

[Qemu-devel] [PATCH v13 04/26] target/i386: [tcg] Port to DisasContextBase

2017-07-14 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Emilio G. Cota Reviewed-by: Richard Henderson Reviewed-by: Alex Benneé --- target/i386/translate.c | 142 +++ 1 file chan

Re: [Qemu-devel] [PATCH v2 08/29] qcow2: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:31 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- block/qcow2-cluster.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Hen

[Qemu-devel] [PATCH 0/3] Fix NetBSD build (don't build ivshmem tools)

2017-07-14 Thread Peter Maydell
This patchset fixes the build on NetBSD by making sure we only build the ivshmem-client and ivshmem-server tools if the host OS actually supports ivshmem. (Previously we were only gating building of the within-QEMU ivshmem PCI device.) Most of this patchset is the work of Kamil Rytarowski; I just

Re: [Qemu-devel] [PATCH v2 07/29] dmg: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:31 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Hajnoczi --- block/dmg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Revie

Re: [Qemu-devel] [PATCH 0/3] Fix NetBSD build (don't build ivshmem tools)

2017-07-14 Thread Peter Maydell
On 13 July 2017 at 18:03, Peter Maydell wrote: > This patchset fixes the build on NetBSD by making sure we only > build the ivshmem-client and ivshmem-server tools if the host OS > actually supports ivshmem. (Previously we were only gating building > of the within-QEMU ivshmem PCI device.) Markus

[Qemu-devel] [PATCH v13 05/26] target/i386: [tcg] Port to init_disas_context

2017-07-14 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Richard Henderson Reviewed-by: Alex Benneé --- target/i386/translate.c | 41 +++-- 1 file changed, 23 insertions(+), 18 deletions

Re: [Qemu-devel] [PATCH v2 09/29] vpc: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:31 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- block/vpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH v2 10/29] vvfat: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:32 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- block/vvfat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henders

Re: [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros

2017-07-14 Thread gengdongjiu
Michael, thanks for the review and comments. On 2017/7/14 1:11, Michael S. Tsirkin wrote: > On Wed, Jul 12, 2017 at 10:08:15AM +0800, Dongjiu Geng wrote: >> (1) Add related APEI/HEST table structures and macros, these >> definition refer to ACPI 6.1 and UEFI 2.6 spec. >> (2) Add generic err

Re: [Qemu-devel] [PATCH v2 16/29] console: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:32 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- include/ui/console.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Hend

Re: [Qemu-devel] [PATCH v2 11/29] vnc: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:32 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- ui/vnc-enc-tight.c | 2 +- ui/vnc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-

Re: [Qemu-devel] [PATCH v2 12/29] ui: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:32 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- ui/cursor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH v2 19/29] q35: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:32 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- hw/pci-host/q35.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henders

Re: [Qemu-devel] [PULL v2 0/5] Merge sockets 2017/07/11

2017-07-14 Thread Peter Maydell
On 12 July 2017 at 17:18, Daniel P. Berrange wrote: > The following changes since commit 3d0bf8dfdfebd7f2ae41b6f220444b8047d6b1ee: > > Merge remote-tracking branch > 'remotes/dgilbert/tags/pull-migration-20170710a' into staging (2017-07-10 > 18:13:03 +0100) > > are available in the git reposit

Re: [Qemu-devel] [PATCH v2 13/29] vga: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:32 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- hw/display/vga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderso

Re: [Qemu-devel] [PATCH v2 14/29] virtio-gpu: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:32 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- hw/display/virtio-gpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richa

Re: [Qemu-devel] [PATCH v2 28/29] test-iov: replace g_malloc()+memcpy() with g_memdup()

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:32 AM, Marc-André Lureau wrote: I found these pattern via grepping the source tree. I don't have a coccinelle script for it! Signed-off-by: Marc-André Lureau --- tests/test-iov.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2 20/29] usb-hub: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:32 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- hw/usb/dev-hub.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Richard

[Qemu-devel] [PATCH v13 06/26] target/i386: [tcg] Port to insn_start

2017-07-14 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Emilio G. Cota Reviewed-by: Richard Henderson Reviewed-by: Alex Benneé --- target/i386/translate.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) d

Re: [Qemu-devel] [PATCH v2 29/29] eepro100: replace g_malloc()+memcpy() with g_memdup()

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:32 AM, Marc-André Lureau wrote: I found these pattern via grepping the source tree. I don't have a coccinelle script for it! Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Weil Reviewed-by: Jason Wang --- hw/net/eepro100.c | 3 +-- 1 file changed, 1 insertion(+), 2 dele

Re: [Qemu-devel] [PATCH v2 15/29] monitor: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:32 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- monitor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH v2 25/29] decnumber: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:32 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- libdecnumber/decNumber.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard

[Qemu-devel] [PATCH v13 09/26] target/i386: [tcg] Port to tb_stop

2017-07-14 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Emilio G. Cota Reviewed-by: Richard Henderson --- target/i386/translate.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --

Re: [Qemu-devel] [PATCH v2 17/29] virtio-serial: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:32 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- hw/char/virtio-serial-bus.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-b

[Qemu-devel] [PATCH v13 10/26] target/i386: [tcg] Port to disas_log

2017-07-14 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Emilio G. Cota Reviewed-by: Richard Henderson --- target/i386/translate.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff

Re: [Qemu-devel] [PATCH v2 18/29] piix: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:32 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- hw/pci-host/piix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Hender

Re: [Qemu-devel] [PATCH v2 21/29] msix: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:32 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- hw/pci/msix.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henders

[Qemu-devel] [PATCH v13 11/26] target/i386: [tcg] Port to generic translation framework

2017-07-14 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova Reviewed-by: Richard Henderson Reviewed-by: Emilio G. Cota Tested-by: Emilio G. Cota --- target/i386/translate.c | 107 +-- 1 file changed, 20 insertions(+), 87 deletions(-) diff --git a/target/i386/translate.c b/targe

Re: [Qemu-devel] [RFC PATCH 7/8] VFIO: Add new IOCTL for IOMMU TLB invalidate propagation

2017-07-14 Thread Liu, Yi L
Hi Alex, Against to the opaque open, I'd like to propose the following definition based on the existing comments. Pls note that I've merged the pasid table binding and iommu tlb invalidation into a single IOCTL and make different flags to indicate the iommu operations. Per Kevin's comments, there

Re: [Qemu-devel] [PATCH v2 22/29] ppc: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:32 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Acked-by: David Gibson --- target/ppc/mem_helper.c | 2 +- target/ppc/translate.c | 2 +- 2 files change

Re: [Qemu-devel] [PATCH 5/7] s390x/kvm: enable guarded storage

2017-07-14 Thread Cornelia Huck
On Thu, 13 Jul 2017 18:03:07 +0200 Christian Borntraeger wrote: > From: Fan Zhang > > Introduce guarded storage support for KVM guests on s390. > We need to enable the capability, extend machine check validity, > sigp store-additional-status-at-address, and migration. > > The feature is fenced

[Qemu-devel] [PATCH v13 07/26] target/i386: [tcg] Port to breakpoint_check

2017-07-14 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Richard Henderson Reviewed-by: Emilio G. Cota --- target/i386/translate.c | 45 + 1 file changed, 33 insertions(+), 12 de

Re: [Qemu-devel] [PATCH 7/7] s390x/gdb: add gs registers

2017-07-14 Thread Cornelia Huck
On Thu, 13 Jul 2017 18:03:09 +0200 Christian Borntraeger wrote: > Let's provide the guarded storage registers via gdb server. > > Signed-off-by: Christian Borntraeger > --- > configure | 2 +- > gdb-xml/s390-gs.xml| 14 ++ > target/s390x/gdbstub.c | 24 +++

Re: [Qemu-devel] [PULL 24/42] configure: add --disable-tcg configure option

2017-07-14 Thread Paolo Bonzini
- Original Message - > From: "Philippe Mathieu-Daudé" > To: "Paolo Bonzini" , qemu-devel@nongnu.org > Cc: "Anthony Liguori" > Sent: Friday, July 14, 2017 7:24:29 AM > Subject: Re: [Qemu-devel] [PULL 24/42] configure: add --disable-tcg configure > option > > Hi Paolo, > > trying "./co

[Qemu-devel] [PATCH 2/3] configure: Use an explicit CONFIG_IVSHMEM rather than CONFIG_EVENTFD

2017-07-14 Thread Peter Maydell
From: Kamil Rytarowski Rather than relying on everywhere that cares about whether the host supports ivshmem using CONFIG_EVENTFD, make configure set an explicit CONFIG_IVSHMEM. Signed-off-by: Kamil Rytarowski [PMM: split out from another patch, add commit message] Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH v2 23/29] i386/dump: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:32 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- target/i386/arch_dump.c | 24 1 file changed, 12 insertions(+), 12 deletions(

[Qemu-devel] [PATCH v13 12/26] target/arm: [tcg] Port to DisasContextBase

2017-07-14 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Richard Henderson Reviewed-by: Alex Benneé --- target/arm/translate-a64.c | 119 ++-- target/arm/translate.c | 114 ++

Re: [Qemu-devel] [PATCH 0/7] s390: remaining patches

2017-07-14 Thread Cornelia Huck
On Thu, 13 Jul 2017 18:03:02 +0200 Christian Borntraeger wrote: > here is a bunch of patches that teaches recent HW features > to the CPU model and kvm code in QEMU. We also add the > enhanced suppression on protection facility to the z12 and later > for the 2.10 machine type. Looks good from m

Re: [Qemu-devel] [PATCH v2 24/29] kvm: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:32 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- linux-headers/asm-x86/kvm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richa

[Qemu-devel] [PATCH v13 13/26] target/arm: [tcg] Port to init_disas_context

2017-07-14 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Richard Henderson Reviewed-by: Alex Benneé --- target/arm/translate.c | 86 +++- 1 file changed, 48 insertions(+), 38 del

Re: [Qemu-devel] [PATCH v2 27/29] i386: replace g_malloc()+memcpy() with g_memdup()

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:32 AM, Marc-André Lureau wrote: I found these pattern via grepping the source tree. I don't have a coccinelle script for it! Signed-off-by: Marc-André Lureau --- hw/i386/multiboot.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

[Qemu-devel] [PATCH v13 08/26] target/i386: [tcg] Port to translate_insn

2017-07-14 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Richard Henderson Reviewed-by: Emilio G. Cota --- target/i386/translate.c | 71 +++ 1 file changed, 47 insertions(+), 24

Re: [Qemu-devel] [PATCH v2 26/29] i386: introduce ELF_NOTE_SIZE macro

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:32 AM, Marc-André Lureau wrote: Factour out a common pattern to compute the ELF note size. Signed-off-by: Marc-André Lureau --- target/i386/arch_dump.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 6/7] s390x/arch_dump: also dump guarded storage control block

2017-07-14 Thread Cornelia Huck
On Thu, 13 Jul 2017 18:03:08 +0200 Christian Borntraeger wrote: > Write the new note section of type 30b (guarded storage control block). > > Signed-off-by: Christian Borntraeger > --- > include/elf.h| 1 + > target/s390x/arch_dump.c | 18 ++ > 2 files changed, 19

[Qemu-devel] [PATCH 1/3] configure: Rename CONFIG_IVSHMEM to CONFIG_IVSHMEM_DEVICE

2017-07-14 Thread Peter Maydell
The current CONFIG_IVSHMEM is confusing, because it looks like it's a flag for "do we have ivshmem support?", but actually it's a flag for "is the ivshmem PCI device being compiled?" (and implicitly "do we have ivshmem support?" is tested with CONFIG_EVENTFD). Rename it to CONFIG_IVSHMEM_DEVICE to

[Qemu-devel] [PATCH 3/3] configure: Don't build ivshmem tools unless CONFIG_IVSHMEM is set

2017-07-14 Thread Peter Maydell
From: Kamil Rytarowski Don't try to build the ivshmem-server and ivshmem-client tools unless CONFIG_IVSHMEM is set. This fixes in passing a build bug on NetBSD, which fails to build the ivshmem tools because they use shm_open() and on NetBSD that requires linking against -lrt. Signed-off-by: Ka

Re: [Qemu-devel] [PATCH 0/7] s390: remaining patches

2017-07-14 Thread Christian Borntraeger
On 07/14/2017 11:03 AM, Cornelia Huck wrote: > On Thu, 13 Jul 2017 18:03:02 +0200 > Christian Borntraeger wrote: > >> here is a bunch of patches that teaches recent HW features >> to the CPU model and kvm code in QEMU. We also add the >> enhanced suppression on protection facility to the z12 and

[Qemu-devel] [PATCH v13 16/26] target/arm: [tcg] Port to insn_start

2017-07-14 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Richard Henderson Reviewed-by: Alex Benneé --- target/arm/translate.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) d

[Qemu-devel] [PATCH v13 14/26] target/arm: [tcg, a64] Port to init_disas_context

2017-07-14 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Richard Henderson Reviewed-by: Alex Benneé --- target/arm/translate-a64.c | 36 ++-- 1 file changed, 22 insertions(+), 14 deletions(-

Re: [Qemu-devel] [PULL v2 0/5] Merge sockets 2017/07/11

2017-07-14 Thread Christian Borntraeger
On 07/14/2017 10:36 AM, Peter Maydell wrote: > On 12 July 2017 at 17:18, Daniel P. Berrange wrote: >> The following changes since commit 3d0bf8dfdfebd7f2ae41b6f220444b8047d6b1ee: >> >> Merge remote-tracking branch >> 'remotes/dgilbert/tags/pull-migration-20170710a' into staging (2017-07-10 >>

[Qemu-devel] [PATCH v13 15/26] target/arm: [tcg] Port to tb_start

2017-07-14 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Richard Henderson Reviewed-by: Alex Benneé --- target/arm/translate.c | 83 ++-- 1 file changed, 45 insertions(+), 38 del

[Qemu-devel] [PATCH v13 17/26] target/arm: [tcg, a64] Port to insn_start

2017-07-14 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Richard Henderson Reviewed-by: Alex Benneé --- target/arm/translate-a64.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/target/arm/

[Qemu-devel] [PATCH v13 18/26] target/arm: [tcg] Port to breakpoint_check

2017-07-14 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Richard Henderson --- target/arm/translate.c | 53 +++- 1 file changed, 34 insertions(+), 19 deletions(-) diff --git a/ta

Re: [Qemu-devel] [PULL v2 0/5] Merge sockets 2017/07/11

2017-07-14 Thread Daniel P. Berrange
On Fri, Jul 14, 2017 at 11:18:33AM +0200, Christian Borntraeger wrote: > On 07/14/2017 10:36 AM, Peter Maydell wrote: > > On 12 July 2017 at 17:18, Daniel P. Berrange wrote: > >> The following changes since commit > >> 3d0bf8dfdfebd7f2ae41b6f220444b8047d6b1ee: > >> > >> Merge remote-tracking br

Re: [Qemu-devel] [PATCH v6 00/13] chardevice hotswap

2017-07-14 Thread Denis V. Lunev
On 07/06/2017 03:08 PM, Anton Nefedov wrote: > Changed in v6: > - patch 3: chr_lock mutex removed (as discussed, thread safety can be left > to > the front-ends, and the front-ends currently supported are good as is). > - patch 5 now includes related changes for serial and virtio-serial >

[Qemu-devel] [PATCH] travis: add no-TCG build

2017-07-14 Thread Paolo Bonzini
It's fairly easy for --disable-tcg to bitrot. Test it in our CI. Signed-off-by: Paolo Bonzini --- .travis.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.travis.yml b/.travis.yml index 6809e25eca..f583839755 100644 --- a/.travis.yml +++ b/.travis.yml @@ -87,6 +87,9 @@ matrix: -

[Qemu-devel] [PATCH v13 19/26] target/arm: [tcg, a64] Port to breakpoint_check

2017-07-14 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Richard Henderson --- target/arm/translate-a64.c | 48 1 file changed, 31 insertions(+), 17 deletions(-) diff --git a/ta

[Qemu-devel] [PATCH 0/2] docker: allow running "docker-travis" with arbitrary parallelism

2017-07-14 Thread Paolo Bonzini
docker-travis is limited to the -j3 flag specified for running on the SaaS Travis CI infrastructure. When running the test matrix locally with docker, however, we can run much more jobs at the same time on a suitably beefy server. Let people do that with the usual J=nn option already supported by

[Qemu-devel] [PATCH 1/2] docker: allow customizing Travis global_env variables

2017-07-14 Thread Paolo Bonzini
This is useful so that we can do builds at higher than -j3 when running travis.py locally. Signed-off-by: Paolo Bonzini --- tests/docker/travis.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/docker/travis.py b/tests/docker/travis.py index 8dcc964da4..703a7fde8

[Qemu-devel] [PATCH 2/2] travis: move make -j flag out of script

2017-07-14 Thread Paolo Bonzini
Because global environment variables can be overridden when .travis.yml is processed by the docker-travis target, the effect of this patch is that docker-travis now obeys the "J=n" option. Signed-off-by: Paolo Bonzini --- .travis.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[Qemu-devel] [PATCH v13 20/26] target/arm: [tcg] Port to translate_insn

2017-07-14 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/arm/translate.c | 148 target/arm/translate.h |2 + 2 files changed, 87 insertions(+), 63 deletions(-) diff --git a/

[Qemu-devel] [PATCH v13 21/26] target/arm: [tcg, a64] Port to translate_insn

2017-07-14 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/arm/translate-a64.c | 74 +++- 1 file changed, 46 insertions(+), 28 deletions(-) diff --git a/target/arm/translate-a64.c b/targe

[Qemu-devel] [PATCHv9 0/3] fw_cfg: qdev-related tidy-ups

2017-07-14 Thread Mark Cave-Ayland
As part of some ongoing sun4u work, I need to be able to wire the fw_cfg IO interface to a separate IO space by instantiating the qdev device instead of calling fw_cfg_init_io(). This patchset brings FW_CFG_IO in line with FW_CFG_MEM and tidies up the realize methods accordingly. Signed-off-by: Ma

[Qemu-devel] [PATCHv9 1/3] fw_cfg: switch fw_cfg_find() to locate the fw_cfg device by type rather than path

2017-07-14 Thread Mark Cave-Ayland
This will enable the fw_cfg device to be placed anywhere within the QOM tree regardless of its machine location. Note that we also add a comment to document the behaviour that we return NULL to indicate failure where either no fw_cfg device or multiple fw_cfg devices are found. Signed-off-by: Mar

[Qemu-devel] [PATCHv9 2/3] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers

2017-07-14 Thread Mark Cave-Ayland
When looking to instantiate a TYPE_FW_CFG_MEM or TYPE_FW_CFG_IO device to be able to wire it up differently, it is much more convenient for the caller to instantiate the device and have the fw_cfg default files already preloaded during realize. Move fw_cfg_init1() to the end of both the fw_cfg_mem

[Qemu-devel] [PATCHv9 3/3] fw_cfg: move QOM type defines and fw_cfg types into fw_cfg.h

2017-07-14 Thread Mark Cave-Ayland
By exposing FWCfgIoState and FWCfgMemState internals we allow the possibility for the internal MemoryRegion fields to be mapped by name for boards that wish to wire up the fw_cfg device themselves. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laszlo Ersek --- hw/nvram/fw_cfg.c | 49 +-

[Qemu-devel] [PATCH v13 22/26] target/arm: [tcg] Port to tb_stop

2017-07-14 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/arm/translate.c | 165 +--- target/arm/translate.h |1 2 files changed, 87 insertions(+), 79 deletions(-) diff --git a/t

Re: [Qemu-devel] [PATCH v4 00/20] qdev: Introduce DEFINE_PROP_LINK

2017-07-14 Thread Paolo Bonzini
On 14/07/2017 04:14, Fam Zheng wrote: > v4: Add a pointer type param to DEFINE_PROP_LINK, don't change pointer types > to > "Object *". [Paolo] > > v3: Include Igor's patch, and fix virtio-crypto too. > Always use qdev_prop_allow_set_link_before_realize and > OBJ_PROP_LINK_UNREF_ON_RE

[Qemu-devel] [PATCH 7/7] block: add throttle block filter driver interface tests

2017-07-14 Thread Manos Pitsidianakis
Signed-off-by: Manos Pitsidianakis --- tests/qemu-iotests/184 | 237 + tests/qemu-iotests/184.out | 319 + tests/qemu-iotests/group | 1 + 3 files changed, 557 insertions(+) create mode 100755 tests/qemu-iotests/

  1   2   3   4   5   6   >