[Qemu-devel] [PATCH v22 15/30] block/dirty-bitmap: add autoload field to BdrvDirtyBitmap

2017-06-28 Thread Vladimir Sementsov-Ogievskiy
Mirror AUTO flag from Qcow2 bitmap in BdrvDirtyBitmap. This will be needed in future, to save this flag back to Qcow2 for persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 18 ++ block/qcow2-bitmap.c | 2 ++ include/block/

[Qemu-devel] [PATCH v22 07/30] qcow2-refcount: rename inc_refcounts() and make it public

2017-06-28 Thread Vladimir Sementsov-Ogievskiy
This is needed for the following patch, which will introduce refcounts checking for qcow2 bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- block/qcow2-refcount.c | 53 ++ block/qcow2.h

[Qemu-devel] [PATCH v22 21/30] block: add bdrv_can_store_new_dirty_bitmap

2017-06-28 Thread Vladimir Sementsov-Ogievskiy
This will be needed to check some restrictions before making bitmap persistent in qmp-block-dirty-bitmap-add (this functionality will be added by future patch) Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- block.c | 22 +

[Qemu-devel] [PATCH v22 09/30] block/dirty-bitmap: fix comment for BlockDirtyBitmap.disabled field

2017-06-28 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Reviewed-by: Max Reitz --- block/dirty-bitmap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index f502c45a70..a8fe149c4a 100644 --- a/block/dirty-bitmap.c +++

[Qemu-devel] [PATCH v22 18/30] block/dirty-bitmap: add bdrv_dirty_bitmap_next()

2017-06-28 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- block/dirty-bitmap.c | 7 +++ include/block/dirty-bitmap.h | 2 ++ 2 files changed, 9 insertions(+) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index 3c17c452ae..d1469418e6 10

[Qemu-devel] [PATCH v22 06/30] block/dirty-bitmap: add deserialize_ones func

2017-06-28 Thread Vladimir Sementsov-Ogievskiy
Add bdrv_dirty_bitmap_deserialize_ones() function, which is needed for qcow2 bitmap loading, to handle unallocated bitmap parts, marked as all-ones. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Kevin Wolf Reviewed-by: John Snow --- block/dirty-bitmap.c | 7 +++ include

[Qemu-devel] [PATCH v22 04/30] tests: add hbitmap iter test

2017-06-28 Thread Vladimir Sementsov-Ogievskiy
Test that hbitmap iter is resistant to bitmap resetting. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz Reviewed-by: John Snow --- tests/test-hbitmap.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/test-hbitmap

[Qemu-devel] [PATCH v22 14/30] qcow2: support .bdrv_reopen_bitmaps_rw

2017-06-28 Thread Vladimir Sementsov-Ogievskiy
Realize bdrv_reopen_bitmaps_rw interface. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Reviewed-by: Max Reitz --- block/qcow2-bitmap.c | 61 block/qcow2.c| 2 ++ block/qcow2.h| 1 + 3 files changed, 64

[Qemu-devel] [PATCH v22 10/30] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-06-28 Thread Vladimir Sementsov-Ogievskiy
It will be needed in following commits for persistent bitmaps. If bitmap is loaded from read-only storage (and we can't mark it "in use" in this storage) corresponding BdrvDirtyBitmap should be read-only. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 36 +

[Qemu-devel] [PATCH v22 12/30] block: refactor bdrv_reopen_commit

2017-06-28 Thread Vladimir Sementsov-Ogievskiy
Add bs local variable to simplify code. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- block.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/block.c b/block.c index 694396281b..37d68e3276 100644 --- a/block.c +++ b/block.c @@ -2989,9

Re: [Qemu-devel] [Qemu-block] [PATCH RFC v3 3/8] block: add throttle block filter driver

2017-06-28 Thread Stefan Hajnoczi
On Tue, Jun 27, 2017 at 04:34:22PM +0300, Manos Pitsidianakis wrote: > On Tue, Jun 27, 2017 at 01:45:40PM +0100, Stefan Hajnoczi wrote: > > On Mon, Jun 26, 2017 at 07:26:41PM +0300, Manos Pitsidianakis wrote: > > > On Mon, Jun 26, 2017 at 03:30:55PM +0100, Stefan Hajnoczi wrote: > > > > > +bs->

[Qemu-devel] [PATCH v22 26/30] iotests: test qcow2 persistent dirty bitmap

2017-06-28 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/165 | 105 + tests/qemu-iotests/165.out | 5 +++ tests/qemu-iotests/group | 1 + 3 files changed, 111 insertions(+) create mode 100755 tests/qemu-iotes

Re: [Qemu-devel] [PATCH 1/5] virtio-pci: use ioeventfd even when KVM is disabled

2017-06-28 Thread Stefan Hajnoczi
On Tue, Jun 27, 2017 at 01:07:35PM +0200, Kevin Wolf wrote: > Am 27.06.2017 um 10:43 hat Fam Zheng geschrieben: > > On Thu, 06/15 17:38, Stefan Hajnoczi wrote: > > > Old kvm.ko versions only supported a tiny number of ioeventfds so > > > virtio-pci avoids ioeventfds when kvm_has_many_ioeventfds() r

Re: [Qemu-devel] [PATCH v22 13/30] block: new bdrv_reopen_bitmaps_rw interface

2017-06-28 Thread Vladimir Sementsov-Ogievskiy
28.06.2017 15:05, Vladimir Sementsov-Ogievskiy wrote: Add format driver handler, which should mark loaded read-only bitmaps as 'IN_USE' in the image and unset read_only field in corresponding BdrvDirtyBitmap's. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Forgot to add:

Re: [Qemu-devel] [PATCH] qga:windows os lost ip when network nic change pic order

2017-06-28 Thread indiffpig
That's true. Let me confirm to you whether this problem exists or whether there are any solutions already available. If so, I would like you to tell me the existing solution. My patch comes from the company code, and the code is long.The notes are written in Chinese. We work too much and don't h

[Qemu-devel] [PATCH v22 00/30] qcow2: persistent dirty bitmaps

2017-06-28 Thread Vladimir Sementsov-Ogievskiy
Hi all! There is a new update of qcow2-bitmap series - v22. web: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=qcow2-bitmap-v22 git: https://src.openvz.org/scm/~vsementsov/qemu.git (tag qcow2-bitmap-v22) v22: Rebase on master, so changes, mostly related to new dirty bitmaps mute

[Qemu-devel] [PULL 1/2] virtio-blk: trace vdev so devices can be distinguished

2017-06-28 Thread Stefan Hajnoczi
It is hard to analyze trace logs with multiple virtio-blk devices because none of the trace events include the VirtIODevice *vdev. This patch adds vdev so it's clear which device a request is associated with. I considered using VirtIOBlock *s instead but VirtIODevice *vdev is more general and may

[Qemu-devel] [PATCH v11 00/29] translate: [tcg] Generic translation framework

2017-06-28 Thread Lluís Vilanova
This series proposes a generic (target-agnostic) instruction translation framework. It basically provides a generic main loop for instruction disassembly, which calls target-specific functions when necessary. This generalization makes inserting new code in the main loop easier, and helps in keepin

[Qemu-devel] [PATCH v11 02/29] cpu-exec: Avoid global variables in icount-related functions

2017-06-28 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- include/exec/gen-icount.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/exec/gen-icount.h b/include/exec/gen-icount.h index 62d462e494..3fb17d435a 100644 --- a/include/exec/gen-icount.h +++ b/include/exec/gen-icount.h @@ -

[Qemu-devel] [PATCH v22 08/30] qcow2: add bitmaps extension

2017-06-28 Thread Vladimir Sementsov-Ogievskiy
Add bitmap extension as specified in docs/specs/qcow2.txt. For now, just mirror extension header into Qcow2 state and check constraints. Also, calculate refcounts for qcow2 bitmaps, to not break qemu-img check. For now, disable image resize if it has bitmaps. It will be fixed later. Signed-off-by

Re: [Qemu-devel] [PATCH v1] virtio-net: code cleanup

2017-06-28 Thread Eric Blake
On 06/28/2017 12:53 AM, Wei Wang wrote: > Use is_power_of_2(), and remove trailing "." from error_setg(). > > Signed-off-by: Wei Wang > --- > hw/net/virtio-net.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer R

[Qemu-devel] [PULL 2/2] virtio-pci: use ioeventfd even when KVM is disabled

2017-06-28 Thread Stefan Hajnoczi
Old kvm.ko versions only supported a tiny number of ioeventfds so virtio-pci avoids ioeventfds when kvm_has_many_ioeventfds() returns 0. Do not check kvm_has_many_ioeventfds() when KVM is disabled since it always returns 0. Since commit 8c56c1a592b5092d91da8d8943c1d6462a6f ("memory: emulate i

[Qemu-devel] [PATCH v22 17/30] block: introduce persistent dirty bitmaps

2017-06-28 Thread Vladimir Sementsov-Ogievskiy
New field BdrvDirtyBitmap.persistent means, that bitmap should be saved by format driver in .bdrv_close and .bdrv_inactivate. No format driver supports it for now. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 29 + block/qcow2-bitmap.

[Qemu-devel] [PATCH v11 04/29] target: [tcg] Add generic translation framework

2017-06-28 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- accel/tcg/Makefile.objs |1 accel/tcg/translator.c| 153 + include/exec/gen-icount.h |2 - include/exec/translator.h | 104 +++ 4 files changed, 259 insertions(+), 1 deletion

[Qemu-devel] [PATCH v22 19/30] qcow2: add persistent dirty bitmaps support

2017-06-28 Thread Vladimir Sementsov-Ogievskiy
Store persistent dirty bitmaps in qcow2 image. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/qcow2-bitmap.c | 475 +++ block/qcow2.c| 9 + block/qcow2.h| 1 + 3 files changed, 485 insertions(+) d

[Qemu-devel] [PATCH v11 03/29] target: [tcg] Use a generic enum for DISAS_ values

2017-06-28 Thread Lluís Vilanova
Used later. An enum makes expected values explicit and bounds the value space of switches. Signed-off-by: Lluís Vilanova --- include/exec/exec-all.h |6 -- include/exec/translator.h | 38 ++ target/arm/translate.h| 26

Re: [Qemu-devel] [Qemu-block] [PATCH RFC v3 4/8] block: convert ThrottleGroup to object with QOM

2017-06-28 Thread Stefan Hajnoczi
On Tue, Jun 27, 2017 at 06:05:55PM +0200, Alberto Garcia wrote: > On Mon 26 Jun 2017 06:58:32 PM CEST, Manos Pitsidianakis wrote: > > On Mon, Jun 26, 2017 at 03:52:34PM +0100, Stefan Hajnoczi wrote: > >>On Fri, Jun 23, 2017 at 03:46:56PM +0300, Manos Pitsidianakis wrote: > >>> +static bool throttle

Re: [Qemu-devel] [PATCH v3] ARM: KVM: Enable in-kernel timers with user space gic

2017-06-28 Thread Alexander Graf
On 28.06.17 13:51, Andrew Jones wrote: On Tue, Jun 27, 2017 at 05:35:37PM +0200, Alexander Graf wrote: When running with KVM enabled, you can choose between emulating the gic in kernel or user space. If the kernel supports in-kernel virtualization of the interrupt controller, it will default t

Re: [Qemu-devel] [PATCH v22 13/30] block: new bdrv_reopen_bitmaps_rw interface

2017-06-28 Thread Eric Blake
[meta-comment] On 06/28/2017 07:10 AM, Vladimir Sementsov-Ogievskiy wrote: > 28.06.2017 15:05, Vladimir Sementsov-Ogievskiy wrote: >> Add format driver handler, which should mark loaded read-only >> bitmaps as 'IN_USE' in the image and unset read_only field in >> corresponding BdrvDirtyBitmap's. >

Re: [Qemu-devel] [PATCH 3/5] qemu-iotests: 068: extract _qemu() function

2017-06-28 Thread Stefan Hajnoczi
On Tue, Jun 27, 2017 at 06:40:04AM -0500, Eric Blake wrote: > On 06/15/2017 11:38 AM, Stefan Hajnoczi wrote: > > Avoid duplicating the QEMU command-line. > > > > Signed-off-by: Stefan Hajnoczi > > --- > > tests/qemu-iotests/068 | 13 - > > 1 file changed, 8 insertions(+), 5 deletions

Re: [Qemu-devel] [PATCH RFC v3 2/8] block: Add aio_context field in ThrottleGroupMember

2017-06-28 Thread Manos Pitsidianakis
On Wed, Jun 28, 2017 at 01:27:36PM +0200, Kevin Wolf wrote: Am 23.06.2017 um 14:46 hat Manos Pitsidianakis geschrieben: timer_cb() needs to know about the current Aio context of the throttle request that is woken up. In order to make ThrottleGroupMember backend agnostic, this information is stor

[Qemu-devel] [PATCH v11 06/29] target/i386: [tcg] Refactor init_disas_context

2017-06-28 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/i386/translate.c | 43 --- 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/target/i386/translate.c b/target/i386/

[Qemu-devel] [PULL 0/2] Block patches

2017-06-28 Thread Stefan Hajnoczi
The following changes since commit 577caa2672ccde7352fda3ef17e44993de862f0e: Merge remote-tracking branch 'remotes/edgar/tags/edgar/mmio-exec-v2.for-upstream' into staging (2017-06-27 16:56:55 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull

[Qemu-devel] [PATCH v3] KVM: Add async pf flag to KVM_GET/SET_VCPU_EVENTS interface

2017-06-28 Thread Wanpeng Li
From: Wanpeng Li This patch adds async page fault flag to KVM_GET/SET_VCPU_EVENTS interface. Cc: Paolo Bonzini Cc: Radim Krčmář Signed-off-by: Wanpeng Li --- v2 -> v3: * nested_apf for vcpu events v1 -> v2: * reuse the pad for async_page_fault * cleanup coding style linux-headers/asm-x86

[Qemu-devel] [PATCH v11 01/29] Pass generic CPUState to gen_intermediate_code()

2017-06-28 Thread Lluís Vilanova
Needed to implement a target-agnostic gen_intermediate_code() in the future. Signed-off-by: Lluís Vilanova Reviewed-by: David Gibson Reviewed-by: Richard Henderson --- accel/tcg/translate-all.c |2 +- include/exec/exec-all.h |2 +- target/alpha/translate.c | 11 +--

[Qemu-devel] [PATCH v11 07/29] target/i386: [tcg] Refactor init_globals

2017-06-28 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/i386/translate.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c in

Re: [Qemu-devel] [PATCH RFC v3 2/8] block: Add aio_context field in ThrottleGroupMember

2017-06-28 Thread Kevin Wolf
Am 28.06.2017 um 14:15 hat Manos Pitsidianakis geschrieben: > On Wed, Jun 28, 2017 at 01:27:36PM +0200, Kevin Wolf wrote: > >Am 23.06.2017 um 14:46 hat Manos Pitsidianakis geschrieben: > >>timer_cb() needs to know about the current Aio context of the throttle > >>request that is woken up. In order

[Qemu-devel] [PATCH v11 05/29] target/i386: [tcg] Port to DisasContextBase

2017-06-28 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/i386/translate.c | 142 +++ 1 file changed, 70 insertions(+), 72 deletions(-) diff --git a/target/i386/translate.c b/target/i

Re: [Qemu-devel] [PULL 0/2] Block patches

2017-06-28 Thread Stefan Hajnoczi
On Wed, Jun 28, 2017 at 1:20 PM, Stefan Hajnoczi wrote: > The following changes since commit 577caa2672ccde7352fda3ef17e44993de862f0e: > > Merge remote-tracking branch > 'remotes/edgar/tags/edgar/mmio-exec-v2.for-upstream' into staging (2017-06-27 > 16:56:55 +0100) > > are available in the git

[Qemu-devel] [PATCH 1/7] qom: Make link property API public

2017-06-28 Thread Fam Zheng
The get/set pair and the struct will be reused by qdev link prop, make them public. Signed-off-by: Fam Zheng --- include/qom/object.h | 13 + qom/object.c | 18 ++ 2 files changed, 19 insertions(+), 12 deletions(-) diff --git a/include/qom/object.h b/include/

[Qemu-devel] [PATCH 0/7] qdev: Introduce DEFINE_PROP_LINK

2017-06-28 Thread Fam Zheng
Link properties of devices created with object_property_add_link() are not reflected in HMP "info qtree". For example, whether a virtio-blk device has an iothread (i.e. has enabled data plane) can not be introspected easily. Introduce a new type of qdev property to fix that. Because QOM is not my

[Qemu-devel] [PATCH 2/7] qom: Handle property lookup failure in object_resolve_link

2017-06-28 Thread Fam Zheng
Since we have made object_set_link_property a public function, it is possible that it will be called with a nonexistent property name. Let's survive this error case and report error to avoid segfault in the future. Signed-off-by: Fam Zheng --- qom/object.c | 5 - 1 file changed, 4 insertion

Re: [Qemu-devel] [PATCH 3/5] qemu-iotests: 068: extract _qemu() function

2017-06-28 Thread Eric Blake
On 06/28/2017 07:13 AM, Stefan Hajnoczi wrote: > On Tue, Jun 27, 2017 at 06:40:04AM -0500, Eric Blake wrote: >> On 06/15/2017 11:38 AM, Stefan Hajnoczi wrote: >>> Avoid duplicating the QEMU command-line. >>> >>> Signed-off-by: Stefan Hajnoczi >>> --- >>> tests/qemu-iotests/068 | 13 -

[Qemu-devel] [PATCH v11 08/29] target/i386: [tcg] Refactor insn_start

2017-06-28 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/i386/translate.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index d015ea73fa..ad57be2

[Qemu-devel] [PATCH 4/7] qdev: Introduce DEFINE_PROP_LINK

2017-06-28 Thread Fam Zheng
This property can be used to replace the object_property_add_link in device code, to add a link to other objects. It's implemented by creating a wrapper property that basically forwards operations to a QOM "link-FOO" property, which handles the check callback and flags. The feature that is missing

[Qemu-devel] [PATCH v6 2/3] migration: introduce qemu_ufd_copy_ioctl helper

2017-06-28 Thread Alexey Perevalov
Just for placing auxilary operations inside helper, auxilary operations like: track received pages, notify about copying operation in futher patches. Reviewed-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Signed-off-by: Alexey Perevalov --- migration/postcopy-ram

[Qemu-devel] [PATCH 3/7] qom: Save type name in LinkProperty

2017-06-28 Thread Fam Zheng
Signed-off-by: Fam Zheng --- include/qom/object.h | 1 + qom/object.c | 1 + 2 files changed, 2 insertions(+) diff --git a/include/qom/object.h b/include/qom/object.h index 4659e6a..262cd44 100644 --- a/include/qom/object.h +++ b/include/qom/object.h @@ -1618,6 +1618,7 @@ typedef struct

[Qemu-devel] [PATCH v6 0/3] Add bitmap for received pages in postcopy migration

2017-06-28 Thread Alexey Perevalov
This is 6th version of [PATCH v1 0/2] Add bitmap for copied pages in postcopy migration cover message from there This is a separate patch set, it derived from https://www.mail-archive.com/qemu-devel@nongnu.org/msg456004.html There are several possible use cases: 1. solve issue with postcopy live

[Qemu-devel] [PATCH 6/7] virtio-scsi: Use DEFINE_PROP_LINK

2017-06-28 Thread Fam Zheng
Signed-off-by: Fam Zheng --- hw/scsi/virtio-scsi-dataplane.c | 2 +- hw/scsi/virtio-scsi.c | 15 --- hw/virtio/virtio-pci.c | 2 -- include/hw/virtio/virtio-scsi.h | 2 +- 4 files changed, 6 insertions(+), 15 deletions(-) diff --git a/hw/scsi/virtio-scsi-datapla

Re: [Qemu-devel] [Xen-devel] [PATCH v2 0/3] xen-disk: performance improvements

2017-06-28 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > Sent: 27 June 2017 23:07 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org; qemu- > bl...@nongnu.org > Subject: Re: [Xen-devel] [PATCH v2 0/3] xen-disk: performance > improvements

[Qemu-devel] [PATCH 5/7] virtio-blk: Use DEFINE_PROP_LINK

2017-06-28 Thread Fam Zheng
Signed-off-by: Fam Zheng --- hw/block/dataplane/virtio-blk.c | 2 +- hw/block/virtio-blk.c | 7 +++ hw/virtio/virtio-pci.c | 2 -- include/hw/virtio/virtio-blk.h | 2 +- 4 files changed, 5 insertions(+), 8 deletions(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/blo

[Qemu-devel] [PATCH v6 1/3] migration: postcopy_place_page factoring out

2017-06-28 Thread Alexey Perevalov
Need to mark copied pages as closer as possible to the place where it tracks down. That will be necessary in futher patch. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Alexey Perevalov --- migration/postcopy-ram.c | 13 +++-- migr

[Qemu-devel] [PATCH v11 09/29] target/i386: [tcg] Refactor breakpoint_check

2017-06-28 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/i386/translate.c | 59 ++- 1 file changed, 48 insertions(+), 11 deletions(-) diff --git a/target/i386/translate.c b/target/i

[Qemu-devel] [PATCH 7/7] virtio-rng: Use DEFINE_PROP_LINK

2017-06-28 Thread Fam Zheng
Signed-off-by: Fam Zheng --- hw/virtio/virtio-pci.c | 2 -- hw/virtio/virtio-rng.c | 16 include/hw/virtio/virtio-rng.h | 2 +- 3 files changed, 5 insertions(+), 15 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index eb03ba5..0938db4

Re: [Qemu-devel] [PATCH v3] KVM: Add async pf flag to KVM_GET/SET_VCPU_EVENTS interface

2017-06-28 Thread Paolo Bonzini
On 28/06/2017 14:28, Wanpeng Li wrote: > From: Wanpeng Li > > This patch adds async page fault flag to KVM_GET/SET_VCPU_EVENTS interface. > > Cc: Paolo Bonzini > Cc: Radim Krčmář > Signed-off-by: Wanpeng Li > --- > v2 -> v3: > * nested_apf for vcpu events > v1 -> v2: > * reuse the pad for

Re: [Qemu-devel] [PATCH 3/5] qemu-iotests: 068: extract _qemu() function

2017-06-28 Thread Kevin Wolf
Am 27.06.2017 um 13:40 hat Eric Blake geschrieben: > On 06/15/2017 11:38 AM, Stefan Hajnoczi wrote: > > Avoid duplicating the QEMU command-line. > > > > Signed-off-by: Stefan Hajnoczi > > --- > > tests/qemu-iotests/068 | 13 - > > 1 file changed, 8 insertions(+), 5 deletions(-) > >

[Qemu-devel] [PATCH v6 3/3] migration: add bitmap for received page

2017-06-28 Thread Alexey Perevalov
This patch adds ability to track down already received pages, it's necessary for calculation vCPU block time in postcopy migration feature, maybe for restore after postcopy migration failure. Also it's necessary to solve shared memory issue in postcopy livemigration. Information about received page

Re: [Qemu-devel] [PATCH v5 3/4] net/net: Convert parse_host_port() to Error

2017-06-28 Thread Mao Zhongyi
On 06/28/2017 06:56 PM, Markus Armbruster wrote: Paolo Bonzini writes: On 28/06/2017 07:51, Markus Armbruster wrote: The gethostbyname() return a null pointer if an error occurs, and the h_errno variable holds an error number. herror() and hstrerror() can prints the error message associated

[Qemu-devel] [PATCH v11 10/29] target/i386: [tcg] Refactor translate_insn

2017-06-28 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/i386/translate.c | 72 +++ 1 file changed, 48 insertions(+), 24 deletions(-) diff --git a/target/i386/translate.c b/target/i

[Qemu-devel] [PATCH v11 11/29] target/i386: [tcg] Refactor tb_stop

2017-06-28 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/i386/translate.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index

Re: [Qemu-devel] [PATCH v22 13/30] block: new bdrv_reopen_bitmaps_rw interface

2017-06-28 Thread Vladimir Sementsov-Ogievskiy
It is interesting, but I see this problem only in your answers, in my letters I see this white-space on its place. 28.06.2017 15:36, Eric Blake wrote: [meta-comment] On 06/28/2017 07:10 AM, Vladimir Sementsov-Ogievskiy wrote: 28.06.2017 15:05, Vladimir Sementsov-Ogievskiy wrote: Add format d

Re: [Qemu-devel] [PATCH v22 00/30] qcow2: persistent dirty bitmaps

2017-06-28 Thread Paolo Bonzini
On 28/06/2017 14:05, Vladimir Sementsov-Ogievskiy wrote: > Rebase on master, so changes, mostly related to new dirty bitmaps mutex: > > 10: - asserts now in bdrv_{re,}set_dirty_bitmap_locked functions. > - also add assert into bdrv_undo_clear_dirty_bitmap (the only change, not > related to

[Qemu-devel] [PATCH v11 12/29] target/i386: [tcg] Refactor disas_log

2017-06-28 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/i386/translate.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c in

Re: [Qemu-devel] [PATCH v1] virtio-net: code cleanup

2017-06-28 Thread Eric Blake
[meta-comment, replacing virtio-dev with virtio-dev-owner in cc] On 06/28/2017 07:22 AM, Eric Blake wrote: > On 06/28/2017 12:53 AM, Wei Wang wrote: >> Use is_power_of_2(), and remove trailing "." from error_setg(). >> >> Signed-off-by: Wei Wang >> --- >> hw/net/virtio-net.c | 6 +++--- >> 1 fil

Re: [Qemu-devel] [Qemu-block] [PULL 11/61] virtio-pci: use ioeventfd even when KVM is disabled

2017-06-28 Thread QingFeng Hao
在 2017/6/28 18:22, Kevin Wolf 写道: Am 28.06.2017 um 12:11 hat QingFeng Hao geschrieben: 在 2017/6/24 0:21, Kevin Wolf 写道: From: Stefan Hajnoczi Old kvm.ko versions only supported a tiny number of ioeventfds so virtio-pci avoids ioeventfds when kvm_has_many_ioeventfds() returns 0. Do not chec

[Qemu-devel] [PATCH v6 3/4] net/net: Convert parse_host_port() to Error

2017-06-28 Thread Mao Zhongyi
Cc: berra...@redhat.com Cc: kra...@redhat.com Cc: pbonz...@redhat.com Cc: jasow...@redhat.com Cc: arm...@redhat.com Signed-off-by: Mao Zhongyi --- include/qemu/sockets.h | 3 ++- net/net.c | 23 ++- net/socket.c | 19 ++- 3 files changed

[Qemu-devel] [PATCH v6 4/4] net/socket: Improve -net socket error reporting

2017-06-28 Thread Mao Zhongyi
When -net socket fails, it first reports a specific error, then a generic one, like this: $ qemu-system-x86_64 -net socket, qemu-system-x86_64: -net socket: exactly one of fd=, listen=, connect=, mcast= or udp= is required qemu-system-x86_64: -net socket: Device 'socket' could not be

[Qemu-devel] [PATCH v6 1/4] net/socket: Don't treat odd socket type as SOCK_STREAM

2017-06-28 Thread Mao Zhongyi
In net_socket_fd_init(), the 'default' case is odd: it warns, then continues as if the socket type was SOCK_STREAM. The comment explains "this could be a eg. a pty", but that makes no sense. If @fd really was a pty, getsockopt() would fail with ENOTSOCK. If @fd was a socket, but neither SOCK_DGRAM

[Qemu-devel] [PATCH v11 13/29] target/i386: [tcg] Port to generic translation framework

2017-06-28 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- target/i386/translate.c | 120 +++ 1 file changed, 18 insertions(+), 102 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index 3950fe95a4..295be26a95 100644 --- a/target/i386/translate.c ++

[Qemu-devel] [PATCH v6 0/4] Improve error reporting

2017-06-28 Thread Mao Zhongyi
v6: * PATCH 02 -rename the subject -drop the "qemu: error: " prefix. -correct inappropriate error information settings. * PATCH 03,04 -correct inappropriate error information settings.[Markus Armbruster] v5: * PATCH 01 make the commit message more exact about the actual function. [

[Qemu-devel] [PATCH v11 14/29] target/arm: [tcg] Port to DisasContextBase

2017-06-28 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/arm/translate-a64.c | 119 ++-- target/arm/translate.c | 114 +- target/arm/translate

Re: [Qemu-devel] [PATCH v22 13/30] block: new bdrv_reopen_bitmaps_rw interface

2017-06-28 Thread Vladimir Sementsov-Ogievskiy
28.06.2017 16:02, Vladimir Sementsov-Ogievskiy wrote: It is interesting, but I see this problem only in your answers, in my letters I see this white-space on its place. In outgoing letter I see this white-space, but in letter from mailing-list it is absent. 28.06.2017 15:36, Eric Blake wro

[Qemu-devel] [PATCH v6 2/4] net/socket: Convert several helper functions to Error

2017-06-28 Thread Mao Zhongyi
Currently, net_socket_mcast_create(), net_socket_fd_init_dgram() and net_socket_fd_init() use the function such as fprintf(), perror() to report an error message. Now, convert these functions to Error. Cc: jasow...@redhat.com Cc: arm...@redhat.com Signed-off-by: Mao Zhongyi --- net/socket.c | 7

[Qemu-devel] [PATCH v11 15/29] target/arm: [tcg] Port to init_disas_context

2017-06-28 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/arm/translate.c | 85 +++- 1 file changed, 47 insertions(+), 38 deletions(-) diff --git a/target/arm/translate.c b/target/ar

Re: [Qemu-devel] [PATCH v6 1/4] net/socket: Don't treat odd socket type as SOCK_STREAM

2017-06-28 Thread Daniel P. Berrange
On Wed, Jun 28, 2017 at 09:08:47PM +0800, Mao Zhongyi wrote: > In net_socket_fd_init(), the 'default' case is odd: it warns, > then continues as if the socket type was SOCK_STREAM. The > comment explains "this could be a eg. a pty", but that makes > no sense. If @fd really was a pty, getsockopt() w

[Qemu-devel] [PATCH v11 16/29] target/arm: [tcg, a64] Port to init_disas_context

2017-06-28 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/arm/translate-a64.c | 36 ++-- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/tr

Re: [Qemu-devel] [PATCH v6 2/4] net/socket: Convert several helper functions to Error

2017-06-28 Thread Daniel P. Berrange
On Wed, Jun 28, 2017 at 09:08:48PM +0800, Mao Zhongyi wrote: > Currently, net_socket_mcast_create(), net_socket_fd_init_dgram() and > net_socket_fd_init() use the function such as fprintf(), perror() to > report an error message. > > Now, convert these functions to Error. > > Cc: jasow...@redhat.

Re: [Qemu-devel] [PATCH v6 3/4] net/net: Convert parse_host_port() to Error

2017-06-28 Thread Daniel P. Berrange
On Wed, Jun 28, 2017 at 09:08:49PM +0800, Mao Zhongyi wrote: > diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h > index 5c326db..78e2b30 100644 > --- a/include/qemu/sockets.h > +++ b/include/qemu/sockets.h > if (qemu_isdigit(buf[0])) { > -if (!inet_aton(buf, &saddr

[Qemu-devel] [PATCH v11 17/29] target/arm: [tcg] Port to init_globals

2017-06-28 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/arm/translate.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 23a07fc2

Re: [Qemu-devel] [PATCH v6 4/4] net/socket: Improve -net socket error reporting

2017-06-28 Thread Daniel P. Berrange
On Wed, Jun 28, 2017 at 09:08:50PM +0800, Mao Zhongyi wrote: > When -net socket fails, it first reports a specific error, then > a generic one, like this: > > $ qemu-system-x86_64 -net socket, > qemu-system-x86_64: -net socket: exactly one of fd=, listen=, connect=, > mcast= or udp= is re

[Qemu-devel] [PATCH v11 18/29] target/arm: [tcg] Port to tb_start

2017-06-28 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/arm/translate.c | 82 ++-- 1 file changed, 44 insertions(+), 38 deletions(-) diff --git a/target/arm/translate.c b/target/ar

Re: [Qemu-devel] [PATCH v22 13/30] block: new bdrv_reopen_bitmaps_rw interface

2017-06-28 Thread Paolo Bonzini
On 28/06/2017 15:02, Vladimir Sementsov-Ogievskiy wrote: > It is interesting, but I see this problem only in your answers, in my > letters I see this white-space on its place. That's the good old Thunderbird "format=flowed" bug. Vladimir, download http://people.redhat.com/pbonzini/format-flawed

Re: [Qemu-devel] [PATCH 1/7] qom: Make link property API public

2017-06-28 Thread Paolo Bonzini
On 28/06/2017 14:48, Fam Zheng wrote: > The get/set pair and the struct will be reused by qdev link prop, make > them public. > > Signed-off-by: Fam Zheng Maybe it's better to make it a separate header file. No other objections. Paolo > --- > include/qom/object.h | 13 + > qom/

[Qemu-devel] [PATCH v11 19/29] target/arm: [tcg] Port to insn_start

2017-06-28 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/arm/translate.c | 34 ++ 1 file changed, 22 insertions(+), 12 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c

Re: [Qemu-devel] [PATCH v22 13/30] block: new bdrv_reopen_bitmaps_rw interface

2017-06-28 Thread Vladimir Sementsov-Ogievskiy
Finally, it looks like thunderbird bug https://bugzilla.mozilla.org/show_bug.cgi?id=1160880 [sorry for so much offtopic] 28.06.2017 16:13, Vladimir Sementsov-Ogievskiy wrote: 28.06.2017 16:02, Vladimir Sementsov-Ogievskiy wrote: It is interesting, but I see this problem only in your answers, in

Re: [Qemu-devel] [PATCH RFC v3 5/8] block: add BlockDevOptionsThrottle to QAPI

2017-06-28 Thread Alberto Garcia
On Fri 23 Jun 2017 02:46:57 PM CEST, Manos Pitsidianakis wrote: > +# @BlockdevOptionsThrottle: > +# > +# Driver specific block device options for Throttle > +# I would put this earlier in the json file, together with the rest of the BlockdevOptions* structs. > +# @throttling-group: the name of t

Re: [Qemu-devel] [PATCH 1/7] qom: Make link property API public

2017-06-28 Thread Andreas Färber
Am 28.06.2017 um 15:32 schrieb Paolo Bonzini: > On 28/06/2017 14:48, Fam Zheng wrote: >> The get/set pair and the struct will be reused by qdev link prop, make >> them public. >> >> Signed-off-by: Fam Zheng > > Maybe it's better to make it a separate header file. No other objections. So you thi

[Qemu-devel] [PATCH v11 20/29] target/arm: [tcg, a64] Port to insn_start

2017-06-28 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/arm/translate-a64.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 88624a7

Re: [Qemu-devel] [PATCH 4/7] qdev: Introduce DEFINE_PROP_LINK

2017-06-28 Thread Paolo Bonzini
On 28/06/2017 14:48, Fam Zheng wrote: > > It's implemented by creating a wrapper property that basically forwards > operations to a QOM "link-FOO" property, which handles the check > callback and flags. The feature that is missing from QOM is the dynamic > child pointer which is done in the adde

[Qemu-devel] [PATCH v11 21/29] target/arm: [tcg] Port to breakpoint_check

2017-06-28 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/arm/translate.c | 68 1 file changed, 46 insertions(+), 22 deletions(-) diff --git a/target/arm/translate.c b/target/ar

Re: [Qemu-devel] [PATCH RFC v3 5/8] block: add BlockDevOptionsThrottle to QAPI

2017-06-28 Thread Manos Pitsidianakis
On Wed, Jun 28, 2017 at 03:35:48PM +0200, Alberto Garcia wrote: On Fri 23 Jun 2017 02:46:57 PM CEST, Manos Pitsidianakis wrote: +# @BlockdevOptionsThrottle: +# +# Driver specific block device options for Throttle +# I would put this earlier in the json file, together with the rest of the Bloc

Re: [Qemu-devel] [PATCH RFC v3 6/8] block: add options parameter to bdrv_new_open_driver()

2017-06-28 Thread Alberto Garcia
On Fri 23 Jun 2017 02:46:58 PM CEST, Manos Pitsidianakis wrote: > BlockDriverState *bdrv_new_open_driver(BlockDriver *drv, const char > *node_name, > - int flags, Error **errp) > + int flags, QDict *options, Error > **er

Re: [Qemu-devel] [PATCH v3] ARM: KVM: Enable in-kernel timers with user space gic

2017-06-28 Thread Andrew Jones
On Wed, Jun 28, 2017 at 02:36:17PM +0200, Alexander Graf wrote: > > > On 28.06.17 13:51, Andrew Jones wrote: > > On Tue, Jun 27, 2017 at 05:35:37PM +0200, Alexander Graf wrote: > > > When running with KVM enabled, you can choose between emulating the > > > gic in kernel or user space. If the kern

[Qemu-devel] [PATCH v11 22/29] target/arm: [tcg, a64] Port to breakpoint_check

2017-06-28 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/arm/translate-a64.c | 58 +--- 1 file changed, 43 insertions(+), 15 deletions(-) diff --git a/target/arm/translate-a64.c b/targe

Re: [Qemu-devel] [PATCH RFC v3 6/8] block: add options parameter to bdrv_new_open_driver()

2017-06-28 Thread Manos Pitsidianakis
On Wed, Jun 28, 2017 at 03:42:41PM +0200, Alberto Garcia wrote: On Fri 23 Jun 2017 02:46:58 PM CEST, Manos Pitsidianakis wrote: BlockDriverState *bdrv_new_open_driver(BlockDriver *drv, const char *node_name, - int flags, Error **errp) +

[Qemu-devel] [PATCH v11 23/29] target/arm: [tcg] Port to translate_insn

2017-06-28 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/arm/translate.c | 147 +++- target/arm/translate.h |4 + 2 files changed, 88 insertions(+), 63 deletions(-) diff --git a/

[Qemu-devel] [PATCH v11 24/29] target/arm: [tcg, a64] Port to translate_insn

2017-06-28 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/arm/translate-a64.c | 74 +++- 1 file changed, 46 insertions(+), 28 deletions(-) diff --git a/target/arm/translate-a64.c b/targe

Re: [Qemu-devel] [PATCH v22 00/30] qcow2: persistent dirty bitmaps

2017-06-28 Thread Vladimir Sementsov-Ogievskiy
28.06.2017 16:01, Paolo Bonzini wrote: On 28/06/2017 14:05, Vladimir Sementsov-Ogievskiy wrote: Rebase on master, so changes, mostly related to new dirty bitmaps mutex: 10: - asserts now in bdrv_{re,}set_dirty_bitmap_locked functions. - also add assert into bdrv_undo_clear_dirty_bitmap (

[Qemu-devel] [PATCH v11 25/29] target/arm: [tcg] Port to tb_stop

2017-06-28 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/arm/translate.c | 195 ++-- 1 file changed, 104 insertions(+), 91 deletions(-) diff --git a/target/arm/translate.c b/target/a

[Qemu-devel] Fwd: migration_bitmap_sync()

2017-06-28 Thread ali saeedi
-- Forwarded message -- From: ali saeedi Date: Sat, Jun 24, 2017 at 2:50 PM Subject: migration_bitmap_sync() To: qemu-devel@nongnu.org Hello What does ' migration_bitmap_sync()' function do? thanks a lot

<    1   2   3   4   >