On Wed, Jun 28, 2017 at 09:08:49PM +0800, Mao Zhongyi wrote:
> diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h
> index 5c326db..78e2b30 100644
> --- a/include/qemu/sockets.h
> +++ b/include/qemu/sockets.h
> if (qemu_isdigit(buf[0])) {
> - if (!inet_aton(buf, &saddr->sin_addr))
> + if (!inet_aton(buf, &saddr->sin_addr)) {
> + error_setg(errp, "host address '%s' is not a valid "
> + "IPv4 address", buf);
> return -1;
> + }
> } else {
> - if ((he = gethostbyname(buf)) == NULL)
> + he = gethostbyname(buf);
> + if (he == NULL) {
> + error_setg(errp, "can't resolve host address '%s': "
> + "unknown host", buf);
> return - 1;
> + }
gethostbyname sets 'h_errno' on failure, so you should pass that
into error_setg_errno, instead of hardcoding 'unknown host' as a
message
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
