[Qemu-devel] [PATCH 0/5] target/ppc: Implement support for the Large Decrementer

2017-06-08 Thread Suraj Jitindar Singh
The POWER9 processor introduces a new operating mode of the decrementer called large decrementer mode. If large decrementer mode is disabled then the decrementer behaves before as a 32-bit decrementing register. If large decrementer mode is enabled then the decrementer behaves as a d-bit decrement

[Qemu-devel] [PATCH 2/5] target/ppc: Implement large decrementer support for KVM

2017-06-08 Thread Suraj Jitindar Singh
The large decrementer is an operating mode of the decrementer. The decrementer is normally a 32-bit register. When operating in large decrementer mode the decrementer is a d-bit register which is sign extended to 64-bits (where d is implementation dependant). Implement support for a KVM guest to u

[Qemu-devel] [PATCH 4/5] target/ppc: Enable the large decrementer for TCG and KVM guests

2017-06-08 Thread Suraj Jitindar Singh
Let the guest use the large decrementer. We have support for TCG and KVM guests to use the large decrementer and to migrate guests using the large decrementer, so add the final bits to indicate this capability to the guest. The guest will use the large decrementer if the cpu model is >= POWER9 an

[Qemu-devel] [PATCH 3/5] target/ppc: Implement migration support for large decrementer

2017-06-08 Thread Suraj Jitindar Singh
Implement support to migrate a guest which is using the large decrementer. We need to save the decrementer width to the migration stream. On incoming migration we then need to check that the hypervisor is capable of letting the guest use the large decrementer and that the decrementer width is the

[Qemu-devel] [PATCH 5/5] target/ppc: Add cmd line option to disable the large decrementer

2017-06-08 Thread Suraj Jitindar Singh
Given there is no way to tell the guest if the size of the large decrementer changes, it is not possible to migrate a guest between machines where the decrementer size differs. Add a command line option to disable the large decrementer for a guest on boot. This means we will not advertise the avai

[Qemu-devel] [PULL 5/7] gtk: add deprecation warning for gtk2

2017-06-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Message-id: 20170606105339.3613-4-kra...@redhat.com --- configure | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configure b/configure index 44c773a5cd..41c213b378 100755 --- a/configure +++ b/configure @@ -5245,6 +5245,12 @@

[Qemu-devel] [PULL 4/7] sdl: prefer sdl2 over sdl1

2017-06-08 Thread Gerd Hoffmann
In case the configure script finds both SDL 1.2 and SDL 2.x installed it still prefers SDL 1.2. Prefer SDL 2.x instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Message-id: 20170606105339.3613-3-kra...@redhat.com --- configure | 10 +- 1 file changed, 5 insertions(+)

[Qemu-devel] [PATCH 1/5] target/ppc: Implement large decrementer support for TCG

2017-06-08 Thread Suraj Jitindar Singh
The large decrementer is an operating mode of the decrementer. The decrementer is normally a 32-bit register. When operating in large decrementer mode the decrementer is a d-bit register which is sign extended to 64-bits (where d is implementation dependant). Implement support for a TCG guest to u

[Qemu-devel] [PULL 1/7] Improve Cocoa modifier key handling

2017-06-08 Thread Gerd Hoffmann
From: Ian McKellar via Qemu-devel I had two problems with QEMU on macOS: 1) Sometimes when alt-tabbing to QEMU it would act as if the 'a' key was pressed so I'd get 'a'. 2) Using Sikuli to programatically send keys to the QEMU window text like "foo_bar" would come out as "fo

Re: [Qemu-devel] [PATCH] vl: Fix broken thread=xxx option of the --accel parameter

2017-06-08 Thread Markus Armbruster
Thomas Huth writes: > Commit bde4d9205 ("Fix the -accel parameter and the documentation for > 'hax'") introduced a regression by adding a new local accel_opts > variable which shadows the variable with the same name that is > declared at the beginning of the main() scope. This causes the > qemu_t

[Qemu-devel] [PULL 6/7] sdl: add deprecation warning for sdl1

2017-06-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Message-id: 20170606105339.3613-5-kra...@redhat.com --- configure | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configure b/configure index 41c213b378..5af180c57d 100755 --- a/configure +++ b/configure @@ -5251,6 +5251,12 @@

[Qemu-devel] [PULL 3/7] gtk: prefer gtk3 over gtk2

2017-06-08 Thread Gerd Hoffmann
In case the configure script finds both gtk2 and gtk3 installed it still prefers gtk2 over gtk3. Prefer gtk3 instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Message-id: 20170606105339.3613-2-kra...@redhat.com --- configure | 14 +++--- 1 file changed, 7 insertions(

Re: [Qemu-devel] [PATCH 3/4] sdl2: use framebuffer helper functions.

2017-06-08 Thread Marc-André Lureau
Hi On Tue, Jun 6, 2017 at 3:05 PM Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > include/ui/sdl2.h | 8 ++-- > ui/sdl2-gl.c | 38 -- > 2 files changed, 14 insertions(+), 32 deletions(-) > > diff --git a/include/ui/sdl2.h b/include/ui/s

[Qemu-devel] [PULL 0/7] ui patch queue

2017-06-08 Thread Gerd Hoffmann
5 18:03:43 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-ui-20170608-1 for you to fetch changes up to 468949958fdfa4347a66e3cf5c8240a428532602: spice: don't enter opengl mode in case another UI provides opengl support (2017-06-08

Re: [Qemu-devel] [PATCH 1/3] char: fix alias devices regression

2017-06-08 Thread Markus Armbruster
Marc-André Lureau writes: > Fix regression from commit 4d43a603c71, where the serial and parallel > headers got removed from char.c, which broke the alias table. > > Signed-off-by: Marc-André Lureau > --- > chardev/char.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/chardev/char.c

[Qemu-devel] [PULL 7/7] spice: don't enter opengl mode in case another UI provides opengl support

2017-06-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Message-id: 20170606110618.10393-1-kra...@redhat.com --- include/ui/spice-display.h | 2 ++ ui/spice-core.c| 1 + ui/spice-display.c | 3 ++- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/include/ui/spice-display.h b/include/ui/spic

Re: [Qemu-devel] [PATCH 1/3] char: fix alias devices regression

2017-06-08 Thread Marc-André Lureau
Hi - Original Message - > Marc-André Lureau writes: > > > Fix regression from commit 4d43a603c71, where the serial and parallel > > headers got removed from char.c, which broke the alias table. > > > > Signed-off-by: Marc-André Lureau > > --- > > chardev/char.c | 2 ++ > > 1 file chang

[Qemu-devel] [PULL 2/7] spice: Use proper enum type for kbd led state

2017-06-08 Thread Gerd Hoffmann
From: Jonathon Jongsma Although the Qemu and spice flags currently have the same value, it seems more correct to pass the spice flag values to spice_server_kbd_leds(), especially considering that this function already makes an effort to convert between the QEMU_*_LED and SPICE_KEYBOARD_MODIFIER_*

Re: [Qemu-devel] [PATCH v2 3/7] qcow2: Make perform_cow() call do_perform_cow() twice

2017-06-08 Thread Alberto Garcia
On Wed 07 Jun 2017 11:43:34 PM CEST, Eric Blake wrote: >> block/qcow2-cluster.c | 38 +++--- >> 1 file changed, 23 insertions(+), 15 deletions(-) > >> qemu_co_mutex_unlock(&s->lock); >> -ret = do_perform_cow(bs, m->offset, m->alloc_offset, r->offset, >> r-

Re: [Qemu-devel] [PATCH RFC] block: add throttle block filter driver

2017-06-08 Thread Stefan Hajnoczi
On Wed, Jun 07, 2017 at 04:06:19PM +0300, Manos Pitsidianakis wrote: > +#define QEMU_OPT_IOPS_TOTAL "iops-total" > +#define QEMU_OPT_IOPS_TOTAL_MAX "iops-total-max" > +#define QEMU_OPT_IOPS_TOTAL_MAX_LENGTH "iops-total-max-length" > +#define QEMU_OPT_IOPS_READ "iops-read" > +#define QEMU_OPT_IOPS_R

Re: [Qemu-devel] [PATCH] block: change variable names in BlockDriverState

2017-06-08 Thread Stefan Hajnoczi
On Thu, Jun 08, 2017 at 01:43:16AM +0300, Manos Pitsidianakis wrote: > Change the 'int count' parameter in bdrv_co_pwrite_zeros and > bdrv_co_pdiscard to 'int bytes', as they both refer to bytes. > This helps with code legibility. > > Signed-off-by: Manos Pitsidianakis > --- > include/block/bloc

Re: [Qemu-devel] [Qemu-block] [PATCH] blockjob: cancel blockjobs before stopping all iothreads

2017-06-08 Thread sochin.jiang
Indeed, thank you for replying and reminding. I'll be more careful next time. On 2017/6/7 17:46, Alberto Garcia wrote: > On Sat 03 Jun 2017 07:48:37 AM CEST, sochin.jiang wrote: > >> --- a/block.c >> +++ b/block.c >> @@ -3084,9 +3084,16 @@ static void bdrv_close(BlockDriverState *bs) >>

Re: [Qemu-devel] [PATCH 2/5] coccinelle: use DIV_ROUND_UP

2017-06-08 Thread Marc-André Lureau
Hi On Thu, Jun 8, 2017 at 1:50 AM Eric Blake wrote: > On 06/07/2017 02:46 AM, Marc-André Lureau wrote: > > The coccinelle/round.cocci script doesn't catch hard coded values. > > > > I used the following script over qemu code base: > > > > ( > > - ((e1) + 3) / (4) > > + DIV_ROUND_UP(e1,4) > > As

[Qemu-devel] [PATCH v2] Makefile: Do not generate files if "configure" has not been run yet

2017-06-08 Thread Thomas Huth
When doing a "make -j10" in the vanilla QEMU source tree (without running "configure first), the Makefile currently generates two files already, qemu-version.h and qemu-options.def. This should not happen, so let's make these targets depend on config-host.mak. Also the targets that use python can

[Qemu-devel] [PATCH] xhci: only update dequeue ptr on completed transfers

2017-06-08 Thread Gerd Hoffmann
The dequeue pointer should only be updated in case the transfer is actually completed. If we update it for inflight transfers we will not pick them up again after migration, which easily triggers with HID devices as they typically have a pending transfer, waiting for user input to happen. Fixes:

Re: [Qemu-devel] [PATCH RFC] block: add throttle block filter driver

2017-06-08 Thread Manos Pitsidianakis
On Thu, Jun 08, 2017 at 08:22:28AM +0100, Stefan Hajnoczi wrote: On Wed, Jun 07, 2017 at 04:06:19PM +0300, Manos Pitsidianakis wrote: +#define QEMU_OPT_IOPS_TOTAL "iops-total" +#define QEMU_OPT_IOPS_TOTAL_MAX "iops-total-max" +#define QEMU_OPT_IOPS_TOTAL_MAX_LENGTH "iops-total-max-length" +#defi

Re: [Qemu-devel] [PATCH] xhci: only update dequeue ptr on completed transfers

2017-06-08 Thread Laurent Vivier
On 08/06/2017 09:41, Gerd Hoffmann wrote: > The dequeue pointer should only be updated in case the transfer > is actually completed. If we update it for inflight transfers > we will not pick them up again after migration, which easily > triggers with HID devices as they typically have a pending >

Re: [Qemu-devel] [PATCH v3 00/10] Clock framework API.

2017-06-08 Thread KONRAD Frederic
Le 06/06/2017 à 17:18, Peter Maydell a écrit : On 24 May 2017 at 08:35, KONRAD Frederic wrote: Le 28/02/2017 à 11:02, fred.kon...@greensocs.com a écrit : This is the third version of the clock framework API it contains: * The first 6 patches which introduce the framework. * The 7th patc

Re: [Qemu-devel] [PATCH] nvdimm acpi: fix region format interface code

2017-06-08 Thread Dan Williams
On Wed, Jun 7, 2017 at 11:50 PM, Haozhong Zhang wrote: > On 06/08/17 14:40 +0800, Xiao Guangrong wrote: >> >> >> On 06/08/2017 01:06 PM, Haozhong Zhang wrote: >> > On 06/08/17 11:07 +0800, Xiao Guangrong wrote: >> > > >> > > >> > > On 06/07/2017 04:06 PM, Haozhong Zhang wrote: >> > > > Per ACPI 6.

Re: [Qemu-devel] [PATCH 1/3] char: fix alias devices regression

2017-06-08 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> Marc-André Lureau writes: >> >> > Fix regression from commit 4d43a603c71, where the serial and parallel >> > headers got removed from char.c, which broke the alias table. >> > >> > Signed-off-by: Marc-André Lureau >> > --- >> >

Re: [Qemu-devel] [PATCH 5/5] coccinelle: prefer glib g_new/g_renew macros

2017-06-08 Thread Marc-André Lureau
Hi - Original Message - > On 06/07/2017 02:46 AM, Marc-André Lureau wrote: > > The g_new() familly of macros is simpler and safer than g_malloc(). > > s/familly/family/ > > > > > "The return pointer is cast to the given type... Care is taken to > > avoid overflow when calculating the si

Re: [Qemu-devel] [RFC PATCH 6/8] memory: introduce AddressSpaceOps

2017-06-08 Thread Liu, Yi L
Hi David, I added some update on your question. See if it make any sense. > -Original Message- > From: David Gibson [mailto:da...@gibson.dropbear.id.au] > Sent: Friday, May 26, 2017 1:30 PM > To: Peter Xu > On Thu, May 25, 2017 at 03:24:30PM +0800, Peter Xu wrote: [...] > > > > > > > >

Re: [Qemu-devel] [RFC 0/8] VIRTIO-IOMMU device

2017-06-08 Thread Jason Wang
On 2017年06月07日 18:19, Jean-Philippe Brucker wrote: Hi Jason, On 07/06/17 10:17, Jason Wang wrote: On 2017年06月07日 16:35, Eric Auger wrote: This series implements the virtio-iommu device. This is a proof of concept based on the virtio-iommu specification written by Jean-Philippe Brucker [1]. T

Re: [Qemu-devel] [PULL 22/26] target/aarch64: optimize indirect branches

2017-06-08 Thread Alex Bennée
Richard Henderson writes: > On 06/07/2017 07:11 AM, Alex Bennée wrote: >> >> Richard Henderson writes: >> >>> From: "Emilio G. Cota" >>> >>> Measurements: >>> >>> [Baseline performance is that before applying this and the previous >>> commit] >> >> Sadly this has regressed my qemu-system-aarch

Re: [Qemu-devel] [PATCH v3 3/5] xics: setup cpu at realize time

2017-06-08 Thread Greg Kurz
On Thu, 8 Jun 2017 12:01:12 +1000 David Gibson wrote: > On Wed, Jun 07, 2017 at 07:17:09PM +0200, Greg Kurz wrote: > > Until recently, spapr used to allocate ICPState objects for the lifetime > > of the machine. They would only be associated to vCPUs in xics_cpu_setup() > > when plugging a CPU co

Re: [Qemu-devel] [PATCH 5/5] coccinelle: prefer glib g_new/g_renew macros

2017-06-08 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> On 06/07/2017 02:46 AM, Marc-André Lureau wrote: >> > The g_new() familly of macros is simpler and safer than g_malloc(). >> >> s/familly/family/ >> >> > >> > "The return pointer is cast to the given type... Care is taken to >>

Re: [Qemu-devel] [PATCH v2 4/7] s390x/css: add missing css state conditionally

2017-06-08 Thread Halil Pasic
On 06/07/2017 08:03 PM, Juan Quintela wrote: > Halil Pasic wrote: >> On 06/01/2017 01:32 PM, Cornelia Huck wrote: >>> On Thu, 1 Jun 2017 11:35:27 +0200 >>> Halil Pasic wrote: >>> > > > I was about to suggest to move css from pointer to an embedded struct, > and then noticed that MA

Re: [Qemu-devel] [PATCH v3 3/5] xics: setup cpu at realize time

2017-06-08 Thread Greg Kurz
On Thu, 8 Jun 2017 07:50:08 +0200 Cédric Le Goater wrote: > On 06/07/2017 10:55 PM, Greg Kurz wrote: > [...] > >>> +obj = object_new(TYPE_PNV_ICP); > >>> +object_property_add_child(child, "icp", obj, NULL); > >>> +object_unref(obj); > >>> +object_property_add_const_link(obj, "xics

Re: [Qemu-devel] [PATCHv5 0/4] Clean up compatibility mode handling

2017-06-08 Thread Greg Kurz
On Thu, 8 Jun 2017 14:17:39 +1000 David Gibson wrote: > On Fri, Jun 02, 2017 at 01:15:03PM +1000, David Gibson wrote: > > This is a rebased and revised version of my patches revising CPU > > compatiblity mode handling on ppc, last posted in November. Since > > then, many of the patches have alre

Re: [Qemu-devel] [PATCH V2] hw/pcie: fix the generic pcie root port to support migration

2017-06-08 Thread Dr. David Alan Gilbert
* Marcel Apfelbaum (mar...@redhat.com) wrote: > Add msix state to pcie-root-ports's vmstate > in order to support migration. > > Signed-off-by: Marcel Apfelbaum > --- > v1 -> v2: > - Added x-migrate-msix compat property to avoid >breaking migration (Dave) > > hw/pci-bridge/gen_pcie_root_po

Re: [Qemu-devel] [PATCH v3 4/5] xics: directly register ICPState objects to vmstate

2017-06-08 Thread Greg Kurz
On Thu, 8 Jun 2017 13:59:21 +1000 David Gibson wrote: > On Wed, Jun 07, 2017 at 07:17:17PM +0200, Greg Kurz wrote: > > The ICPState objects are currently registered to vmstate as qdev objects. > > Their instance ids are hence computed automatically in the migration code, > > and thus depends on t

Re: [Qemu-devel] [PATCH v3 3/5] xics: setup cpu at realize time

2017-06-08 Thread Greg Kurz
On Thu, 8 Jun 2017 11:53:29 +1000 David Gibson wrote: > On Wed, Jun 07, 2017 at 10:55:07PM +0200, Greg Kurz wrote: > > On Wed, 7 Jun 2017 20:11:38 +0200 > > Cédric Le Goater wrote: > > > > > On 06/07/2017 07:17 PM, Greg Kurz wrote: > > > > Until recently, spapr used to allocate ICPState obj

[Qemu-devel] 答复: Re: [PATCHv2 01/04] colo-compare: Use IOThread context timer to Checkold packet regularly

2017-06-08 Thread wang.yong155
>> From: Wang Yong<wang.yong...@zte.com.cn> >> >> Remove the task which check old packet in the comparing thread, >> then use IOthread context timer to handle it. >> >> Signed-off-by: Wang Yong<wang.yong...@zte.com.cn> >> Signed-off-by: Wang Guang<wang.guan...@zte.com.cn> >> --- >> net/co

[Qemu-devel] 答复: Re: [PATCHv2 02/04] colo-compare: Process pactkets in the IOThread ofthe primary

2017-06-08 Thread wang.yong155
>> From: Wang Yong <wang.yong...@zte.com.cn> >> >> Process pactkets in the IOThread which arrived over the socket. >> we use qio_channel_set_aio_fd_handler to set the handlers on the >> IOThread AioContext.then the packets from the primary and the secondary >> are processed in the IOThread. >

Re: [Qemu-devel] [PATCH v3 0/4] tcg: split the tcg code and separate tcg files

2017-06-08 Thread Zhong Yang
O Wed, Jun 07, 2017 at 03:28:55PM +0200, Paolo Bonzini wrote: > > > On 02/06/2017 08:06, Yang Zhong wrote: > > In order to disable tcg, the first phase is to split some > > tcg code and separate those tcg related files into one > > directory. The next phase will disable tcg more easily and > > cl

Re: [Qemu-devel] [PATCH] vl: Fix broken thread=xxx option of the --accel parameter

2017-06-08 Thread Alex Bennée
Thomas Huth writes: > Commit bde4d9205 ("Fix the -accel parameter and the documentation for > 'hax'") introduced a regression by adding a new local accel_opts > variable which shadows the variable with the same name that is > declared at the beginning of the main() scope. This causes the > qemu_

[Qemu-devel] 答复: Re: [PATCHv2 04/04] colo-compare: Update the COLO document to fix theprocessing of secondary packets in the main thread

2017-06-08 Thread wang.yong155
>> From: Wang Yong <wang.yong...@zte.com.cn> >> >> In my test, secondary does not process the packets comparing in the IOThread >> but in the qemu main thread processing. >> secondary's configuration " -chardev socket,id=compare1,host=3.3.3.3,port=9004,server,nowait" >> here,we should use 'wa

Re: [Qemu-devel] [PATCH v3 3/5] xics: setup cpu at realize time

2017-06-08 Thread Cédric Le Goater
On 06/08/2017 11:14 AM, Greg Kurz wrote: > On Thu, 8 Jun 2017 11:53:29 +1000 > David Gibson wrote: > >> On Wed, Jun 07, 2017 at 10:55:07PM +0200, Greg Kurz wrote: >>> On Wed, 7 Jun 2017 20:11:38 +0200 >>> Cédric Le Goater wrote: >>> On 06/07/2017 07:17 PM, Greg Kurz wrote: > Until

Re: [Qemu-devel] [PATCH] Add chardev-send-break monitor command

2017-06-08 Thread Dr. David Alan Gilbert
* Stefan Fritsch (s...@sfritsch.de) wrote: > Sending a break on a serial console can be useful for debugging the > guest. But not all chardev backends support sending breaks (only telnet > and mux do). The chardev-send-break command allows to send a break even > if using other backends. > > Signed

Re: [Qemu-devel] [PATCH v3 3/5] xics: setup cpu at realize time

2017-06-08 Thread Cédric Le Goater
On 06/08/2017 10:45 AM, Greg Kurz wrote: > On Thu, 8 Jun 2017 12:01:12 +1000 > David Gibson wrote: > >> On Wed, Jun 07, 2017 at 07:17:09PM +0200, Greg Kurz wrote: >>> Until recently, spapr used to allocate ICPState objects for the lifetime >>> of the machine. They would only be associated to vCPU

Re: [Qemu-devel] [PATCH v3 5/5] spapr: fix migration of ICPState objects from/to older QEMU

2017-06-08 Thread Greg Kurz
On Thu, 8 Jun 2017 14:08:57 +1000 David Gibson wrote: > On Wed, Jun 07, 2017 at 07:17:26PM +0200, Greg Kurz wrote: > > Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under > > sPAPRCPUCore") moved ICPState objects from the machine to CPU cores. > > This is an improvement since we

Re: [Qemu-devel] [PATCH v3 3/5] xics: setup cpu at realize time

2017-06-08 Thread Greg Kurz
On Thu, 8 Jun 2017 11:25:52 +0200 Cédric Le Goater wrote: > On 06/08/2017 11:14 AM, Greg Kurz wrote: > > On Thu, 8 Jun 2017 11:53:29 +1000 > > David Gibson wrote: > > > >> On Wed, Jun 07, 2017 at 10:55:07PM +0200, Greg Kurz wrote: > >>> On Wed, 7 Jun 2017 20:11:38 +0200 > >>> Cédric Le Goat

Re: [Qemu-devel] KVM guests fail to start

2017-06-08 Thread Stefan Hajnoczi
On Thu, Jun 08, 2017 at 08:42:58AM +0100, David Cunningham wrote: > Apologies if this list is inappropriate, I've failed to come across > anything pertinent via Google. If anyone can suggest a more appropriate > forum please do. > > I'm having a problem starting KVM guests since performing a routi

Re: [Qemu-devel] [RFC] QEMU 2.10 release schedule

2017-06-08 Thread Stefan Hajnoczi
On Wed, Jun 07, 2017 at 06:24:24PM +, Marc-André Lureau wrote: > Hi > > On Wed, May 31, 2017 at 5:07 PM Stefan Hajnoczi wrote: > > > On Tue, May 30, 2017 at 01:21:01PM +0200, Christian Borntraeger wrote: > > > On 05/30/2017 12:11 PM, Stefan Hajnoczi wrote: > > > > Here is a first stab at the

Re: [Qemu-devel] [RFC] QEMU 2.10 release schedule

2017-06-08 Thread Stefan Hajnoczi
On Wed, May 31, 2017 at 04:18:41PM +0100, Alex Bennée wrote: > > Peter Maydell writes: > > > On 30 May 2017 at 11:11, Stefan Hajnoczi wrote: > >> Here is a first stab at the next release schedule: > >> > >> Beginning of development phase: 2017-04-20 > >> Soft feature freeze: 2017-07-18 > >> -rc

Re: [Qemu-devel] KVM guests fail to start

2017-06-08 Thread Michael Tokarev
08.06.2017 13:02, Stefan Hajnoczi wrote: > On Thu, Jun 08, 2017 at 08:42:58AM +0100, David Cunningham wrote: >> Apologies if this list is inappropriate, I've failed to come across >> anything pertinent via Google. If anyone can suggest a more appropriate >> forum please do. >> >> I'm having a probl

Re: [Qemu-devel] [PATCH v2 3/4] nvdimm: add a boolean option "restrict"

2017-06-08 Thread Stefan Hajnoczi
On Thu, Jun 08, 2017 at 02:39:48PM +0800, Haozhong Zhang wrote: > On 06/07/17 16:27 +0100, Stefan Hajnoczi wrote: > > On Tue, Jun 06, 2017 at 03:22:28PM +0800, Haozhong Zhang wrote: > > > If a vNVDIMM device is not backed by a DAX device and its "restrict" > > > option is enabled, bit 3 of state fl

Re: [Qemu-devel] [PATCH v2 3/4] nvdimm: add a boolean option "restrict"

2017-06-08 Thread Stefan Hajnoczi
On Thu, Jun 08, 2017 at 09:45:29AM +0800, Haozhong Zhang wrote: > On 06/07/17 16:27 +0100, Stefan Hajnoczi wrote: > > On Tue, Jun 06, 2017 at 03:22:28PM +0800, Haozhong Zhang wrote: > > > If a vNVDIMM device is not backed by a DAX device and its "restrict" > > > option is enabled, bit 3 of state fl

Re: [Qemu-devel] [PATCH RFC] block: add throttle block filter driver

2017-06-08 Thread Stefan Hajnoczi
On Thu, Jun 08, 2017 at 10:41:49AM +0300, Manos Pitsidianakis wrote: > On Thu, Jun 08, 2017 at 08:22:28AM +0100, Stefan Hajnoczi wrote: > > On Wed, Jun 07, 2017 at 04:06:19PM +0300, Manos Pitsidianakis wrote: > > > +#define QEMU_OPT_IOPS_TOTAL "iops-total" > > > +#define QEMU_OPT_IOPS_TOTAL_MAX "io

Re: [Qemu-devel] [PATCH 2/6] migration: move global_state.optional out

2017-06-08 Thread Peter Xu
On Wed, Jun 07, 2017 at 07:42:57PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > Put it into MigrationState then we can use the properties to specify > > whether to enable storing global state. > > > > Signed-off-by: Peter Xu > > --- > > include/migration/migration.h | 6 ++ > > migrati

Re: [Qemu-devel] [PATCH v3 0/4] tcg: split the tcg code and separate tcg files

2017-06-08 Thread Paolo Bonzini
On 08/06/2017 10:55, Zhong Yang wrote: >>> >> Queued, thanks (except I'm not sure why you're moving exec.c, so I've >> undone that, and tcg-runtime.c probably fits better in tcg/). >> > Thanks Paolo for your great help! > > As for exec.c, i ever thought this file is related with system and m

Re: [Qemu-devel] [PULL 22/26] target/aarch64: optimize indirect branches

2017-06-08 Thread Alex Bennée
Emilio G. Cota writes: > On Wed, Jun 07, 2017 at 15:22:48 +0100, Alex Bennée wrote: >> >> Alex Bennée writes: >> >> > Richard Henderson writes: >> > >> >> From: "Emilio G. Cota" >> >> >> >> Measurements: >> >> >> >> [Baseline performance is that before applying this and the previous >> >> com

Re: [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device

2017-06-08 Thread Felipe Franciosi
> On 8 Jun 2017, at 01:31, Michael S. Tsirkin wrote: > > On Wed, Jun 07, 2017 at 02:56:57PM -0400, Paolo Bonzini wrote: >> This could be documented, >>> >>> It is documented AFAIK. Pls take a look at the spec documentation. >> >> Found it now. It's not under GET_VRING_BASE, it's under "

Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks

2017-06-08 Thread Halil Pasic
On 06/07/2017 11:51 AM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> In some cases a failing VMSTATE_*_EQUAL does not mean we detected a bug >> (it's actually the best we can do). Especially in these cases a verbose >> error message is required. >> >> Let's i

Re: [Qemu-devel] [PATCH qemu v7] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-06-08 Thread David Gibson
On Wed, Jun 07, 2017 at 06:32:43PM +1000, Alexey Kardashevskiy wrote: > This defines new QOM object - IOMMUMemoryRegion - with MemoryRegion > as a parent. > > This moves IOMMU-related fields from MR to IOMMU MR. However to avoid > dymanic QOM casting in fast path (address_space_translate, etc), >

Re: [Qemu-devel] [RFC v2 3/8] virtio_iommu: add skeleton

2017-06-08 Thread Bharat Bhushan
> -Original Message- > From: Eric Auger [mailto:eric.au...@redhat.com] > Sent: Wednesday, June 07, 2017 9:31 PM > To: eric.auger@gmail.com; eric.au...@redhat.com; > peter.mayd...@linaro.org; alex.william...@redhat.com; m...@redhat.com; > qemu-...@nongnu.org; qemu-devel@nongnu.org; jea

Re: [Qemu-devel] [PATCH 2/6] migration: move global_state.optional out

2017-06-08 Thread Juan Quintela
Peter Xu wrote: > On Wed, Jun 07, 2017 at 07:42:57PM +0200, Juan Quintela wrote: >> > +/* This is only used if MigrationState.store_global_state is set. */ >> > static GlobalState global_state; >> > >> > int global_state_store(void) >> > @@ -179,7 +179,7 @@ static RunState global_state_get_ru

Re: [Qemu-devel] [PATCH v2] Makefile: Do not generate files if "configure" has not been run yet

2017-06-08 Thread Fam Zheng
On Thu, 06/08 09:40, Thomas Huth wrote: > When doing a "make -j10" in the vanilla QEMU source tree (without > running "configure first), the Makefile currently generates two > files already, qemu-version.h and qemu-options.def. This should not > happen, so let's make these targets depend on config-

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target/xtensa: gdbstub: drop dead return statement

2017-06-08 Thread Laurent Vivier
On 07/06/2017 21:36, Max Filippov wrote: > Signed-off-by: Max Filippov > --- > target/xtensa/gdbstub.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/target/xtensa/gdbstub.c b/target/xtensa/gdbstub.c > index da131ae..d78a1b4 100644 > --- a/target/xtensa/gdbstub.c > +++ b/target/xtensa/g

[Qemu-devel] [PULL v3 00/23] Docker and block patches

2017-06-08 Thread Fam Zheng
The following changes since commit 64175afc695c0672876fbbfc31b299c86d562cb4: arm_gicv3: Fix ICC_BPR1 reset value when EL3 not implemented (2017-06-07 17:21:44 +0100) are available in the git repository at: git://github.com/famz/qemu.git tags/docker-and-block-pull-request for you to fetch c

[Qemu-devel] [PULL v3 04/23] docker: Add flex and bison to centos6 image

2017-06-08 Thread Fam Zheng
Currently there are warnings about flex and bison being missing when building in the centos6 image: make[1]: flex: Command not found BISON dtc-parser.tab.c make[1]: bison: Command not found Add them. Reported-by: Thomas Huth Signed-off-by: Fam Zheng Message-Id: <2017052400

[Qemu-devel] [PULL v3 05/23] block: access copy_on_read with atomic ops

2017-06-08 Thread Fam Zheng
From: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Message-Id: <20170605123908.18777-2-pbonz...@redhat.com> Signed-off-by: Fam Zheng --- block.c | 6 -- block/io.c| 8 blockdev.c| 2 +- include/block/

[Qemu-devel] [PULL v3 02/23] docker: Add bzip2 and hostname to fedora image

2017-06-08 Thread Fam Zheng
It is used by qemu-iotests. Signed-off-by: Fam Zheng Message-Id: <20170505032340.26467-3-f...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Paolo Bonzini Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/fedora.docker | 2 +- 1 file changed, 1 inse

[Qemu-devel] [PULL v3 03/23] docker: Add libaio to fedora image

2017-06-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170505032340.26467-5-f...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Paolo Bonzini Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/fedora.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Qemu-devel] [PULL v3 01/23] docker: Run tests with current user

2017-06-08 Thread Fam Zheng
We've used --add-current-user to create a user in the image, use it to run tests, because root has too much priviledge, and can surprise test cases. Signed-off-by: Fam Zheng Message-Id: <20170505032340.26467-2-f...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewe

[Qemu-devel] [PULL v3 14/23] util: add stats64 module

2017-06-08 Thread Fam Zheng
From: Paolo Bonzini This module provides fast paths for 64-bit atomic operations on machines that only have 32-bit atomic access. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Signed-off-by: Fam Zheng Message-Id: <20170605123908.18777-11-pbonz...@redhat.com> Signed-off-by: Fam Zhe

[Qemu-devel] [PULL v3 11/23] throttle-groups: only start one coroutine from drained_begin

2017-06-08 Thread Fam Zheng
From: Paolo Bonzini Starting all waiting coroutines from bdrv_drain_all is unnecessary; throttle_group_co_io_limits_intercept calls schedule_next_request as soon as the coroutine restarts, which in turn will restart the next request if possible. If we only start the first request and let the cor

[Qemu-devel] [PULL v3 06/23] block: access quiesce_counter with atomic ops

2017-06-08 Thread Fam Zheng
From: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Reviewed-by: Alberto Garcia Signed-off-by: Paolo Bonzini Message-Id: <20170605123908.18777-3-pbonz...@redhat.com> Signed-off-by: Fam Zheng --- block/io.c| 4 ++-- include/block/block_int.h | 1 + 2 files changed, 3 insertions(+

[Qemu-devel] [PULL v3 19/23] migration/block: reset dirty bitmap before reading

2017-06-08 Thread Fam Zheng
From: Paolo Bonzini Any data that is returned by read may be stale already, the bitmap has to be cleared before issuing the read. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Message-Id: <20170605123908.18777-16-pbonz...@redhat.com> Signed-off-by: Fam Zheng --- migration/block.c

[Qemu-devel] [PULL v3 07/23] block: access io_limits_disabled with atomic ops

2017-06-08 Thread Fam Zheng
From: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Reviewed-by: Alberto Garcia Signed-off-by: Paolo Bonzini Message-Id: <20170605123908.18777-4-pbonz...@redhat.com> Signed-off-by: Fam Zheng --- block/block-backend.c | 4 ++-- block/throttle-groups.c| 2 +- include/sysemu/block

[Qemu-devel] [PULL v3 12/23] throttle-groups: do not use qemu_co_enter_next

2017-06-08 Thread Fam Zheng
From: Paolo Bonzini Prepare for removing this function; always restart throttled requests from coroutine context. This will matter when restarting throttled requests will have to acquire a CoMutex. Reviewed-by: Alberto Garcia Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Message-

[Qemu-devel] [PULL v3 17/23] block: protect tracked_requests and flush_queue with reqs_lock

2017-06-08 Thread Fam Zheng
From: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Message-Id: <20170605123908.18777-14-pbonz...@redhat.com> Signed-off-by: Fam Zheng --- block.c | 1 + block/io.c| 16 ++-- include/block/block_int.h | 14 +-

[Qemu-devel] [PULL v3 08/23] block: access serialising_in_flight with atomic ops

2017-06-08 Thread Fam Zheng
From: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Message-Id: <20170605123908.18777-5-pbonz...@redhat.com> Signed-off-by: Fam Zheng --- block/io.c| 6 +++--- include/block/block_int.h | 10 ++ 2 files changed, 9 insertions(+), 7 deletions(-

[Qemu-devel] [PULL v3 21/23] block: introduce block_account_one_io

2017-06-08 Thread Fam Zheng
From: Paolo Bonzini This is the common code to account operations that produced actual I/O. Reviewed-by: Alberto Garcia Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Message-Id: <20170605123908.18777-18-pbonz...@redhat.com> Signed-off-by: Fam Zheng --- block/accounting.c | 51 ++

[Qemu-devel] [PULL v3 10/23] block: access io_plugged with atomic ops

2017-06-08 Thread Fam Zheng
From: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Message-Id: <20170605123908.18777-7-pbonz...@redhat.com> Signed-off-by: Fam Zheng --- block/io.c| 4 ++-- include/block/block_int.h | 8 +--- 2 files changed, 7 insertions(+), 5 deletions(-) dif

[Qemu-devel] [PULL v3 09/23] block: access wakeup with atomic ops

2017-06-08 Thread Fam Zheng
From: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Message-Id: <20170605123908.18777-6-pbonz...@redhat.com> Signed-off-by: Fam Zheng --- block/io.c| 3 ++- block/nfs.c | 4 +++- block/sheepdog.c | 3 ++- include/block/block.h

[Qemu-devel] [PULL v3 23/23] block: make accounting thread-safe

2017-06-08 Thread Fam Zheng
From: Paolo Bonzini I'm not trying too hard yet. Later, with multiqueue support, this may cause mutex contention or cacheline bouncing. Cc: Alberto Garcia Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Message-Id: <20170605123908.18777-20-pbonz...@redhat.com> Reviewed-by: Alberto

[Qemu-devel] [PULL v3 13/23] throttle-groups: protect throttled requests with a CoMutex

2017-06-08 Thread Fam Zheng
From: Paolo Bonzini Another possibility is to use tg->lock, which we're holding anyway in both schedule_next_request and throttle_group_co_io_limits_intercept. This would require open-coding the CoQueue however, so I've chosen this alternative. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo

[Qemu-devel] [PULL v3 20/23] block: protect modification of dirty bitmaps with a mutex

2017-06-08 Thread Fam Zheng
From: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Message-Id: <20170605123908.18777-17-pbonz...@redhat.com> Signed-off-by: Fam Zheng --- block/dirty-bitmap.c | 70 ++-- block/mirror.c | 11 +-- inclu

[Qemu-devel] [PULL v3 15/23] block: use Stat64 for wr_highest_offset

2017-06-08 Thread Fam Zheng
From: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Message-Id: <20170605123908.18777-12-pbonz...@redhat.com> Signed-off-by: Fam Zheng --- block/io.c| 4 +--- block/qapi.c | 2 +- include/block/block_int.h | 7 --- 3 files changed, 6

[Qemu-devel] [PULL v3 22/23] block: split BlockAcctStats creation and setup

2017-06-08 Thread Fam Zheng
From: Paolo Bonzini block_acct_destroy is called unconditionally in blk_delete, but there is no BlockAcctStats function that is called unconditionally in blk_new. Split block_acct_init in two, so that it will be possible to create a QemuMutex in block_acct_init and destroy it in block_acct_cleanu

[Qemu-devel] [PATCH v2 0/3] char: fix chardev aliases regression

2017-06-08 Thread Marc-André Lureau
Hi, The patch "char: move CharBackend handling in char-fe unit" broke chardev aliases. Here is a small series to fix it, and add a simple unit test to check the alias keep working. v2: - move HAVE_CHARDEV_* in osdep.h (Markus Armbruster) - add r-b tags from Eric for the patches that didn't change

[Qemu-devel] [PULL v3 18/23] block: introduce dirty_bitmap_mutex

2017-06-08 Thread Fam Zheng
From: Paolo Bonzini It protects only the list of dirty bitmaps; in the next patch we will also protect their content. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Message-Id: <20170605123908.18777-15-pbonz...@redhat.com> Signed-off-by: Fam Zheng --- block/dirty-bitmap.c | 4

[Qemu-devel] [PATCH v2 1/3] char: fix alias devices regression

2017-06-08 Thread Marc-André Lureau
Fix regression from commit 4d43a603c71, where the serial and parallel headers got removed from char.c, which broke the alias table. Move the HAVE_CHARDEV_SERIAL/HAVE_CHARDEV_PARPORT to osdep.h instead of being in seperate headers. Signed-off-by: Marc-André Lureau --- include/chardev/char-parall

[Qemu-devel] [PULL v3 16/23] block: access write_gen with atomics

2017-06-08 Thread Fam Zheng
From: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Message-Id: <20170605123908.18777-13-pbonz...@redhat.com> Signed-off-by: Fam Zheng --- block.c | 2 +- block/io.c| 6 +++--- include/block/block_int.h | 2 +- 3 files changed, 5 ins

[Qemu-devel] [PATCH v2 2/3] chardev: don't use alias names in parse_compat()

2017-06-08 Thread Marc-André Lureau
"parport" is considered "old" since commit 88a946d32d, when "parallel" was added. Similarly for "tty" in commit d59044ef74d. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- chardev/char.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/chardev/char.c b/chard

[Qemu-devel] [PATCH v2 3/3] test-char: start a /char/serial test

2017-06-08 Thread Marc-André Lureau
Quite limited test, to check that the chardev can be created with a path and with the tty alias. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/test-char.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/tests/test-char.c b/tests/test-char

Re: [Qemu-devel] [PATCH v2] Makefile: Do not generate files if "configure" has not been run yet

2017-06-08 Thread Eric Blake
On 06/08/2017 02:40 AM, Thomas Huth wrote: > When doing a "make -j10" in the vanilla QEMU source tree (without > running "configure first), the Makefile currently generates two > files already, qemu-version.h and qemu-options.def. This should not > happen, so let's make these targets depend on conf

Re: [Qemu-devel] [PATCH] spice: don't enter opengl mode in case another UI provides opengl support

2017-06-08 Thread Marc-André Lureau
Hi On Tue, Jun 6, 2017 at 3:11 PM Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > Reviewed-by: Marc-André Lureau --- > include/ui/spice-display.h | 2 ++ > ui/spice-core.c| 1 + > ui/spice-display.c | 3 ++- > 3 files changed, 5 insertions(+), 1 deletion(-) > > di

Re: [Qemu-devel] [PATCH v2] Makefile: Do not generate files if "configure" has not been run yet

2017-06-08 Thread Thomas Huth
On 08.06.2017 13:16, Fam Zheng wrote: > On Thu, 06/08 09:40, Thomas Huth wrote: >> When doing a "make -j10" in the vanilla QEMU source tree (without >> running "configure first), the Makefile currently generates two >> files already, qemu-version.h and qemu-options.def. This should not >> happen, s

  1   2   3   4   >