On 08.06.2017 13:16, Fam Zheng wrote: > On Thu, 06/08 09:40, Thomas Huth wrote: >> When doing a "make -j10" in the vanilla QEMU source tree (without >> running "configure first), the Makefile currently generates two >> files already, qemu-version.h and qemu-options.def. This should not >> happen, so let's make these targets depend on config-host.mak. >> Also the targets that use python can not be executed without the >> $(PYTHON) from config-host.mak, so these should depend on the config- >> host.mak file, too (these targets generate some ugly error messages >> otherwise during "make -j10"). >> >> Signed-off-by: Thomas Huth <th...@redhat.com> >> --- >> v2: >> - Add the dependency to the targets that use $(PYTHON) instead of >> adding it to $(qapi-py) >> >> Makefile | 23 ++++++++++++----------- >> 1 file changed, 12 insertions(+), 11 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index c830d7a..b5e0731 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -286,7 +286,7 @@ endif >> >> all: $(DOCS) $(TOOLS) $(HELPERS-y) recurse-all modules > > Is it enough to add a > > $(filter-out $(GENERATED_FILES),config-host.mak): config-host.mak > > after the variable is fully built? (Seems config-host.mak is not included, > but > filtering out is safer.)
That works for the files that I've mentioned in the patch description, but I then suddenly see lots of *.pyc files in scripts/tracetool instead... Anyway, I think I've now found a way that works even more reliable: Simply disable the "Makefile: $(GENERATED_FILES)" rule if config-host.mak is missing. I'll send a v3 patch in a minute... Thomas
signature.asc
Description: OpenPGP digital signature
