From: Sameeh Jubran
The QGA schema states:
@can-offline: Whether offlining the VCPU is possible. This member
is always filled in by the guest agent when the structure
is returned, and always ignored on input (hence it can be
omitted then).
Currently
From: Sameeh Jubran
Currently the service runs in background on boot even though it is not
needed and once it is running it never stops. The service needs to be
running only during freeze operation and it should be stopped after
executing thaw.
Signed-off-by: Sameeh Jubran
Signed-off-by: Michae
From: Sameeh Jubran
When the command "guest-fsfreeze-freeze" is executed it causes
the VSS service to log the error below in the Event Viewer. This
error is caused by an issue in the function "CommitSnapshots" in
provider.cpp:
* When VSS_TIMEOUT_MSEC expires the funtion returns E_ABORT. This cau
From: Marc-André Lureau
Some users find the fsfreeze behaviour confusing. Add some notes about
invalid mount points and Windows usage.
Related to:
https://bugzilla.redhat.com/show_bug.cgi?id=1436976
Signed-off-by: Marc-André Lureau
Reviewed-by: Vinzenz Feenstra
Signed-off-by: Michael Roth
--
The following changes since commit fe491fa85c4634453b340b18046aae2eaf8147db:
Merge remote-tracking branch 'remotes/agraf/tags/signed-s390-for-upstream'
into staging (2017-04-25 14:48:55 +0100)
are available in the git repository at:
git://github.com/mdroth/qemu.git tags/qga-pull-2017-04-25-
From: Sameeh Jubran
After triggering a freeze command without any following thaw command,
qemu-ga will not respond to stop operation. This behaviour is wanted on Linux
as there is no time limit for a freeze command and we want to prevent
quitting in the middle of freeze, on the other hand on Wind
From: Vinzenz Feenstra
Retrieving the guest host name is a very useful feature for virtual management
systems. This information can help to have more user friendly VM access
details, instead of an IP there would be the host name. Also the host name
reported can be used to have automated checks fo
From: Vinzenz Feenstra
A command that will list all currently logged in users, and the time
since when they are logged in.
Examples:
virsh # qemu-agent-command F25 '{ "execute": "guest-get-users" }'
{"return":[{"login-time":1490622289.903835,"user":"root"}]}
virsh # qemu-agent-command Win2k12r
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20170425223739.6703-1-quint...@redhat.com
Subject: [Qemu-devel] [PATCH 00/26] Audio Cleanup
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BA
On Tue, 25 Apr 2017 23:32:52 +0300
"Michael S. Tsirkin" wrote:
> On Tue, Mar 28, 2017 at 08:55:04PM -0600, Alex Williamson wrote:
> > On Wed, 29 Mar 2017 02:59:34 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > On Tue, Mar 28, 2017 at 10:12:25AM -0600, Alex Williamson wrote:
> > > > On Tue,
On Tue, 04/25 16:00, Peter Maydell wrote:
>
> Coverity points out that there's a problem here -- we call
> bdrv_inc_in_flight(bs), which assumes bs is not NULL, before
> we do the test for whether bs is NULL.
>
> Presumably the NULL check needs to be pulled up earlier in
> the function?
>
Yes,
On Tue, 04/25 17:16, Kevin Wolf wrote:
> Am 10.04.2017 um 17:05 hat Fam Zheng geschrieben:
> > bdrv_inc_in_flight and bdrv_dec_in_flight are mandatory for
> > BDRV_POLL_WHILE to work, even for the shortcut case where flush is
> > unnecessary. Move the if block to below bdrv_dec_in_flight, and BTW f
＞ + */＞ +colon = strchr(line, ':')＞ +if (!colon) {＞ +
continue＞ +}＞ +*colon = '\0'＞ +if (colon - path_len
＞= line && strcmp(colon - path_len, path) == 0) {colon - path_len ＞ line would
imply the current line isn't a matcheither, so i think tha
Hi Juan,
On 04/25/2017 07:37 PM, Juan Quintela wrote:
uint8_t has existed since . all this century?
Signed-off-by: Juan Quintela
---
hw/audio/fmopl.c | 8
hw/audio/fmopl.h | 39 ---
2 files changed, 24 insertions(+), 23 deletions(-)
diff --gi
Hi Juan, is there a benefit in not squashing the previous stdint commits?
On 04/25/2017 07:37 PM, Juan Quintela wrote:
Signed-off-by: Juan Quintela
---
hw/audio/fmopl.c | 42 +-
hw/audio/fmopl.h | 54 --
Hi Juan,
Same here, why not squashing as "Use stdint instead of dead GUSEMU32"?
On 04/25/2017 07:37 PM, Juan Quintela wrote:
Signed-off-by: Juan Quintela
---
hw/audio/gus.c | 2 +-
hw/audio/gusemu.h | 12 +---
hw/audio/gusemu_hal.c | 2 +-
hw/audio/gusemu_mixer.c |
On 04/25/2017 07:37 PM, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Philippe Mathieu-Daudé
---
hw/audio/fmopl.c | 2 +-
hw/audio/fmopl.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c
index 99d09c5..dc9043c 100644
On 04/25/2017 07:37 PM, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Philippe Mathieu-Daudé
---
hw/audio/fmopl.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c
index dc9043c..202f752 100644
--- a/hw/audio/fmopl
On 04/25/2017 03:35 PM, Stefano Stabellini wrote:
Do not use the ring.h header installed on the system. Instead, import
the header into the QEMU codebase. This avoids problems when QEMU is
built against a Xen version too old to provide all the ring macros.
Signed-off-by: Stefano Stabellini
Revi
Reported by Coverity. We already use bs in bdrv_inc_in_flight before
checking for NULL. It is unnecessary as all callers pass non-NULL bs, so
drop it.
Signed-off-by: Fam Zheng
---
block/io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/io.c b/block/io.c
index a7142e0
On Tue, Apr 25, 2017 at 04:06:17PM +0200, Cédric Le Goater wrote:
> On 04/25/2017 03:31 PM, Peter Maydell wrote:
> > On 25 April 2017 at 07:51, Cédric Le Goater wrote:
> >> Currenlty, the code relies on the fact that open() handles NULL
> >> filenames but that can cause an error with new clang:
>
On Tue, Apr 25, 2017 at 08:51:41AM +0200, Cédric Le Goater wrote:
> Currenlty, the code relies on the fact that open() handles NULL
> filenames but that can cause an error with new clang:
>
> hw/core/loader.c:67:15: runtime error: null pointer passed as argument 1,
> which is declared to never
On Sun, Apr 23, 2017 at 07:37:55PM -0500, alar...@ddci.com wrote:
> David Gibson wrote on 04/23/2017 06:17:22
> PM:
>
> > From: David Gibson
> > To: Aaron Larson
> > Cc: ag...@suse.de, qemu-devel@nongnu.org, qemu-...@nongnu.org
> > Date: 04/23/2017 06:54 PM
> > Subject: Re: Subject: [PATCH] ta
On Mon, Apr 24, 2017 at 02:12:19PM +0100, Peter Maydell wrote:
> On 24 April 2017 at 02:58, David Gibson wrote:
> > The following changes since commit 32c7e0ab755745e961f1772e95cac381cc68769d:
> >
> > Merge remote-tracking branch
> > 'remotes/juanquintela/tags/migration/20170421' into staging (
v15: Rework a number of things, especially around what and how lockings are
done. [Kevin]
- Map each permission to a locked byte.
- Make the new option --force-share-perms, and require read-only=on.
- Update test case 153 accordingly.
- Only add -U where necessary in iotes
This is the order of the largest possible permission.
Signed-off-by: Fam Zheng
---
include/block/block.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/block/block.h b/include/block/block.h
index eb0565d..a798f10 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -2
Signed-off-by: Fam Zheng
---
block.c | 32
1 file changed, 24 insertions(+), 8 deletions(-)
diff --git a/block.c b/block.c
index 9db39b6..e9f4750 100644
--- a/block.c
+++ b/block.c
@@ -1430,6 +1430,22 @@ static int bdrv_child_check_perm(BdrvChild *c, uint64_t
pe
It can be used outside of block.c for making user friendly messages.
Signed-off-by: Fam Zheng
---
block.c | 2 +-
include/block/block.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/block.c b/block.c
index 1e668fb..fce77bf 100644
--- a/block.c
+++ b/block.c
This will force the opened images to allow sharing all permissions with other
programs.
Signed-off-by: Fam Zheng
---
qemu-img.c | 154 ++---
1 file changed, 118 insertions(+), 36 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index ed24
Signed-off-by: Fam Zheng
---
block.c | 17 +
include/block/block.h | 1 +
include/block/block_int.h | 1 +
qapi/block-core.json | 3 +++
4 files changed, 22 insertions(+)
diff --git a/block.c b/block.c
index fce77bf..9db39b6 100644
--- a/block.c
+++
Add --force-share/-U to program options and -U to open subcommand.
Signed-off-by: Fam Zheng
---
qemu-io.c | 42 ++
1 file changed, 34 insertions(+), 8 deletions(-)
diff --git a/qemu-io.c b/qemu-io.c
index 427cbae..cf4b876 100644
--- a/qemu-io.c
+++ b/qemu
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
---
tests/drive_del-test.c| 2 +-
tests/nvme-test.c | 2 +-
tests/usb-hcd-uhci-test.c | 2 +-
tests/usb-hcd-xhci-test.c | 2 +-
tests/virtio-blk-test.c | 2 +-
tests/virtio-scsi-test.c | 5 +++--
6 files changed, 8 insertions(+), 7 d
qemu-img and qemu-io commands when guest is running need "-U" option,
add it.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/030 | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030
index 0d472d5..e00c11b 100755
-
Signed-off-by: Fam Zheng
---
qemu-img-cmds.hx | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx
index 8ac7822..ae309c0 100644
--- a/qemu-img-cmds.hx
+++ b/qemu-img-cmds.hx
@@ -10,15 +10,15 @@ STEXI
ETEXI
The test scenario doesn't require the same image, instead it focuses on
the duplicated node-name, so use null-co to avoid locking conflict.
Reviewed-by: Max Reitz
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/087 | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tests/
The COLO block replication architecture requires one disk to be shared
between primary and secondary, in the test both processes use posix file
protocol (instead of over NBD) so it is affected by image locking.
Disable the lock.
Signed-off-by: Fam Zheng
---
tests/test-replication.c | 9 +++--
Double attach is not a valid usage of the target image, drive-backup
will open the blockdev itself so skip the add_drive call in this case.
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
---
tests/qemu-iotests/055 | 32 ++--
1 file changed, 18 insertions(+), 14 dele
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
---
tests/qemu-iotests/091 | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qemu-iotests/091 b/tests/qemu-iotests/091
index 32bbd56..10ac4a8 100755
--- a/tests/qemu-iotests/091
+++ b/tests/qemu-iotests/091
@@ -95,7 +95,9 @@ echo "vm2: qe
Signed-off-by: Fam Zheng
---
blockdev.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/blockdev.c b/blockdev.c
index 4927914..4e04dec 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3174,6 +3174,7 @@ static BlockJob *do_drive_backup(DriveBackup *backup,
BlockJob
They are wrappers of POSIX fcntl "file private locking", with a
convenient "try lock" wrapper implemented with F_OFD_GETLK.
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
---
include/qemu/osdep.h | 3 +++
util/osdep.c | 48
2 files chan
The qemu-img info command is executed while VM is running, add -U option
to avoid the image locking error.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/046 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/046 b/tests/qemu-iotests/046
index e528b67..f2ebec
Making this option available even before implementing it will let
converting tests easier: in coming patches they can specify the option
already when necessary, before we actually write code to lock the
images.
Signed-off-by: Fam Zheng
---
block/file-posix.c | 5 +
1 file changed, 5 insertio
In the case where we test the expected error when a blockdev-snapshot
target already has a backing image, the backing chain is opened multiple
times. This will be a problem when we use image locking, so use a
different backing file that is not already open.
Signed-off-by: Fam Zheng
---
tests/qem
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/153 | 220 +
tests/qemu-iotests/153.out | 390 +
tests/qemu-iotests/group | 1 +
3 files changed, 611 insertions(+)
create mode 100755 tests/qemu-iotests/153
create mode 1
To avoid image lock failures.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/172 | 55 +-
tests/qemu-iotests/172.out | 50 +
2 files changed, 56 insertions(+), 49 deletions(-)
diff --git a/tests/qemu-iotest
This extends the permission bits of op blocker API to external using
Linux OFD locks.
Each permission in @perm and @shared_perm is represented by a locked
byte in the image file. Requesting a permission in @perm is translated
to a shared lock of the corresponding byte; rejecting to share the same
The "info jit" command currently aborts on Mac OS X with the message
"qemu_mutex_lock: Invalid argument" when running with "-M accel=qtest".
We should only call into the TCG code here if TCG has really been
enabled and initialized.
Signed-off-by: Thomas Huth
---
monitor.c | 5 +
1 file chang
On Fri, Apr 21, 2017 at 02:58:23PM -0700, Aaron Larson wrote:
> Add global timer group A to open-pic. This patch is still somewhat
> dubious because I'm not sure how to determine what QEMU wants for the
> timer frequency. Suggestions solicited.
>
> Signed-off-by: Aaron Larson
> ---
> hw/intc/o
This commit duplicates header of "userfaultfd: provide pid in userfault msg"
into linux kernel.
Signed-off-by: Alexey Perevalov
---
linux-headers/linux/userfaultfd.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/linux-headers/linux/userfaultfd.h
b/linux-headers/linux/userfaultfd.h
in
This modification is necessary for userfault fd features which are
required to be requested from userspace.
UFFD_FEATURE_THREAD_ID is a one of such "on demand" feature, which will
be introduced in the next patch.
QEMU need to use separate userfault file descriptor, due to
userfault context has int
This is third version of patch set.
First version was tagged as RFC, second was without version tag.
Difference since previous version (V3 -> V2)
- Downtime calculation approach was changed, thanks to Peter Xu
- Due to previous point no more need to keep GTree as well as bitmap of
cpus.
S
This patch provides downtime calculation per vCPU,
as a summary and as a overlapped value for all vCPUs.
This approach was suggested by Peter Xu, as an improvements of
previous approch where QEMU kept tree with faulted page address and cpus bitmask
in it. Now QEMU is keeping array with faulted pag
It's not possible to transmit it back to source host,
due to RP protocol is not expandable.
Signed-off-by: Alexey Perevalov
---
migration/postcopy-ram.c | 2 ++
migration/trace-events | 1 +
2 files changed, 3 insertions(+)
diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
inde
That tiny refactoring is necessary to be able to set
UFFD_FEATURE_THREAD_ID while requesting features, and then
to create downtime context in case when kernel supports it.
Signed-off-by: Alexey Perevalov
---
include/migration/postcopy-ram.h | 2 +-
migration/migration.c| 2 +-
migr
This patch add request to kernel space for UFFD_FEATURE_THREAD_ID,
in case when this feature is provided by kernel.
DowntimeContext is incapsulated inside migration.c.
Signed-off-by: Alexey Perevalov
---
include/migration/migration.h | 12
migration/migration.c | 33 +++
On Tue, Apr 25, 2017 at 05:45:11PM -0500, Michael Roth wrote:
> Quoting Daniel Henrique Barboza (2017-04-24 17:08:26)
> > In pseries, a firmware abstraction called Dynamic Reconfiguration
> > Connector (DRC) is used to assign a particular dynamic resource
> > to the guest and provide an interface t
On 04/26/2017 04:42 AM, David Gibson wrote:
> On Tue, Apr 25, 2017 at 08:51:41AM +0200, Cédric Le Goater wrote:
>> Currenlty, the code relies on the fact that open() handles NULL
>> filenames but that can cause an error with new clang:
>>
>> hw/core/loader.c:67:15: runtime error: null pointer pas
On 04/26/2017 04:38 AM, David Gibson wrote:
> On Mon, Apr 24, 2017 at 02:12:19PM +0100, Peter Maydell wrote:
>> On 24 April 2017 at 02:58, David Gibson wrote:
>>> The following changes since commit 32c7e0ab755745e961f1772e95cac381cc68769d:
>>>
>>> Merge remote-tracking branch
>>> 'remotes/juanq
This is the v3 of this series. v2 for context:
https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg04342.html
Changes from v2 -- all due to Richard's comments:
- Inlined tb_from_jmp_cache into the TCG helper; now that this helper
is common there is no point in having a separate function
Instead of unconditionally exiting to the exec loop, use the
gen_jr helper to jump to the target if it is valid.
Perf impact: see next commit's log.
Signed-off-by: Emilio G. Cota
---
target/i386/translate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/i386/tran
Signed-off-by: Emilio G. Cota
---
tcg/i386/tcg-target.h | 2 +-
tcg/i386/tcg-target.inc.c | 15 +++
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h
index 59d9835..73a15f7 100644
--- a/tcg/i386/tcg-target.h
+++ b/tcg/i38
Instead of exporting goto_ptr directly to TCG frontends, export
tcg_gen_lookup_and_goto_ptr(), which calls goto_ptr with the pointer
returned by the lookup_tb_ptr() helper. This is the only use case
we have for goto_ptr and lookup_tb_ptr, so having this function is
very convenient. Furthermore, it
Speed up indirect branches by jumping to the target if it is valid.
Softmmu measurements (see later commit for user-mode results):
Note: baseline (i.e. speedup == 1x) is QEMU v2.9.0.
- Impact on Boot time
| setup | ARM debian jessie boot+shutdown time | stddev |
|+-
This helper will be used by subsequent changes.
Signed-off-by: Emilio G. Cota
---
target/i386/translate.c | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/target/i386/translate.c b/target/i386/translate.c
index 1d1372f..59f6eaa 100644
--- a/target/i3
This paves the way for upcoming work.
Reviewed-by: Richard Henderson
Signed-off-by: Emilio G. Cota
---
tcg-runtime.c | 21 +
tcg/tcg-runtime.h | 2 ++
tcg/tcg.h | 1 +
3 files changed, 24 insertions(+)
diff --git a/tcg-runtime.c b/tcg-runtime.c
index 4c60c96..
Signed-off-by: Emilio G. Cota
---
tcg/aarch64/tcg-target.h | 1 +
tcg/arm/tcg-target.h | 1 +
tcg/i386/tcg-target.h| 1 +
tcg/ia64/tcg-target.h| 1 +
tcg/mips/tcg-target.h| 1 +
tcg/ppc/tcg-target.h | 1 +
tcg/s390/tcg-target.h| 1 +
tcg/sparc/tcg-target.h | 1 +
tcg/tcg
Speed up indirect branches by jumping to the target if it is valid.
Softmmu measurements (see later commit for user-mode numbers):
Note: baseline (i.e. speedup == 1x) is QEMU v2.9.0.
- SPECint06 (test set), x86_64-softmmu (Ubuntu 16.04 guest).
Host: Intel i7-4790K @ 4.00GHz
2
Instead of unconditionally exiting to the exec loop, use the
lookup_and_goto_ptr helper to jump to the target if it is valid.
Perf impact: see next commit's log.
Signed-off-by: Emilio G. Cota
---
target/arm/translate.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tar
Optimizations to cross-page chaining and indirect branches make
performance more sensitive to the hit rate of tb_jmp_cache.
The constraint of reserving some bits for the page number
lowers the achievable quality of the hashing function.
However, user-mode does not have this requirement. Thus,
with
On 04/26/2017 04:43 AM, David Gibson wrote:
> On Tue, Apr 25, 2017 at 04:06:17PM +0200, Cédric Le Goater wrote:
>> On 04/25/2017 03:31 PM, Peter Maydell wrote:
>>> On 25 April 2017 at 07:51, Cédric Le Goater wrote:
Currenlty, the code relies on the fact that open() handles NULL
filenames
Stefano Stabellini writes:
> On Tue, 25 Apr 2017, Markus Armbruster wrote:
>> Stefano Stabellini writes:
[...]
>> > diff --git a/hw/9pfs/xen-9pfs.h b/hw/9pfs/xen-9pfs.h
>> > new file mode 100644
>> > index 000..6e33d77
>> > --- /dev/null
>> > +++ b/hw/9pfs/xen-9pfs.h
>> > @@ -0,0 +1,21 @@
>>
The tx_bh or tx_timer will free in virtio_net_del_queue() function, when
removing virtio-net queues if the guest doesn't support multiqueue. But
it might be still referenced by virtio_net_set_status(), which needs to
be set NULL. And also the tx_waiting needs to be set zero to prevent
virtio_net_se
401 - 472 of 472 matches
Mail list logo
