Re: [Qemu-devel] WinDbg module

2017-04-13 Thread Ladi Prosek
Hi, On Wed, Apr 12, 2017 at 4:05 PM, Mihail Abakumov wrote: > Hello. > > We made the debugger module WinDbg (like GDB) for QEMU. This is the > replacement of the remote stub in Windows kernel. Used for remote Windows > kernel debugging without debugging mode. This is awesome! > The latest build

Re: [Qemu-devel] [PATCH] arm: remove remaining cannot_destroy_with_object_finalize_yet

2017-04-13 Thread Markus Armbruster
Laurent Vivier writes: > With commit ce5b1bbf624b ("exec: move cpu_exec_init() calls to > realize functions"), we can now remove all the > remaining cannot_destroy_with_object_finalize_yet as > unsafe references have been moved to cpu_exec_realizefn(). > (tested with QOM command provided by commi

Re: [Qemu-devel] [PATCH] Add 'none' as type for drive's if option

2017-04-13 Thread Markus Armbruster
Craig Jellick writes: > Is there an action I need to take for that? Fair question. Expect e-mail from a qemu-trivial maintainer that your patch has been merged. If you don't get one within a reasonable time frame, we failed you. Send a reminder as a reply to this message then. I figure one w

Re: [Qemu-devel] [RFC 2/2] spec/vhost-user spec: Add IOMMU support

2017-04-13 Thread Jason Wang
On 2017年04月12日 17:26, Peter Xu wrote: On Wed, Apr 12, 2017 at 04:54:25PM +0800, Jason Wang wrote: On 2017年04月12日 15:17, Peter Xu wrote: On Tue, Apr 11, 2017 at 05:16:19PM +0200, Maxime Coquelin wrote: On 04/11/2017 03:20 PM, Peter Xu wrote: On Tue, Apr 11, 2017 at 12:10:02PM +0200, Maxime C

Re: [Qemu-devel] [PATCH v3 0/2] block: Quiesce old aio context during bdrv_set_aio_context

2017-04-13 Thread Fam Zheng
On Thu, 04/13 14:51, Paolo Bonzini wrote: > > > On 11/04/2017 00:04, Stefan Hajnoczi wrote: > > On Mon, Apr 10, 2017 at 10:26:34AM +0800, Fam Zheng wrote: > >> v3: Use bdrv_parent_drained_begin/end. [Kevin] > >> Do it before releasing new_context. [Stefan] > >> > >> Fam Zheng (2): > >> bloc

Re: [Qemu-devel] [PATCH] colo-compare: Fix old packet check bug.

2017-04-13 Thread Jason Wang
On 2017年04月12日 20:12, Zhang Chen wrote: If colo-compare find one old packet,we can notify colo-frame do checkpoint, no need continue find more old packet here. Signed-off-by: Zhang Chen --- net/colo-compare.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --gi

Re: [Qemu-devel] [PATCH] event: Add signal information to SHUTDOWN

2017-04-13 Thread Markus Armbruster
Paolo Bonzini writes: > On 07/04/2017 05:09, Eric Blake wrote: > >> qemu_kill_report() is already able to tell whether a shutdown >> was triggered by guest action (no output) or by a host signal >> (a message about termination is printed via error_report); but >> this information is then lost. L

[Qemu-devel] [PATCH] cpus: Fix CPU unplug for MTTCG

2017-04-13 Thread Bharata B Rao
Ensure that the unplugged CPU thread is destroyed and the waiting thread is notified about it. This is needed for CPU unplug to work correctly in MTTCG mode. Signed-off-by: Bharata B Rao --- cpus.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/cpus.c b/cpus.c index 740b8dc..79f780b 1

Re: [Qemu-devel] [Qemu-block] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-13 Thread Alberto Garcia
On Wed 12 Apr 2017 04:10:46 PM CEST, Max Reitz wrote: >> I still don't see why we can always assume OFLAG_COPIED. Before doing >> the COW one cluster can have references from multiple snapshots, > > Yes... > >> and OFLAG_COPIED is equally valid in that context. > > In what context? When having sub

Re: [Qemu-devel] [PATCH] arm: remove remaining cannot_destroy_with_object_finalize_yet

2017-04-13 Thread Laurent Vivier
On 13/04/2017 09:06, Markus Armbruster wrote: > Laurent Vivier writes: > >> With commit ce5b1bbf624b ("exec: move cpu_exec_init() calls to >> realize functions"), we can now remove all the >> remaining cannot_destroy_with_object_finalize_yet as >> unsafe references have been moved to cpu_exec_rea

Re: [Qemu-devel] [PATCH v2 1/4] Throttle: Create IOThrottle structure

2017-04-13 Thread Pradeep Jagadeesh
On 4/12/2017 5:01 PM, Alberto Garcia wrote: On Thu 30 Mar 2017 02:10:10 PM CEST, Pradeep Jagadeesh wrote: +## +# == QAPI IOThrottle definitions +## +# @IOThrottle: +# +# A set of parameters describing block +# "describing block ..." ? There's missing text here. Hmm..I will fix this. Regards,

Re: [Qemu-devel] [PATCH 0/5] mc146818rtc: fix Windows VM clock faster

2017-04-13 Thread Xiao Guangrong
On 04/13/2017 02:37 PM, Paolo Bonzini wrote: On 12/04/2017 17:51, guangrong.x...@gmail.com wrote: The root cause is that the clock will be lost if the periodic period is changed as currently code counts the next periodic time like this: next_irq_clock = (cur_clock & ~(period - 1)) + pe

Re: [Qemu-devel] [PATCH 0/5] mc146818rtc: fix Windows VM clock faster

2017-04-13 Thread Xiao Guangrong
On 04/13/2017 04:39 PM, Xiao Guangrong wrote: On 04/13/2017 02:37 PM, Paolo Bonzini wrote: On 12/04/2017 17:51, guangrong.x...@gmail.com wrote: The root cause is that the clock will be lost if the periodic period is changed as currently code counts the next periodic time like this:

Re: [Qemu-devel] [Qemu-block] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-13 Thread Kevin Wolf
Am 13.04.2017 um 10:05 hat Alberto Garcia geschrieben: > On Wed 12 Apr 2017 04:10:46 PM CEST, Max Reitz wrote: > >> I still don't see why we can always assume OFLAG_COPIED. Before doing > >> the COW one cluster can have references from multiple snapshots, > > > > Yes... > > > >> and OFLAG_COPIED i

Re: [Qemu-devel] [Qemu-block] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-13 Thread Alberto Garcia
On Thu 13 Apr 2017 11:02:10 AM CEST, Kevin Wolf wrote: > I think you still need it if you don't want to look at the refcount > blocks for every write. When you take an internal snapshot, you just > increase the refcount of the L2 tables at first and keep the contents > the same, including the subc

[Qemu-devel] 答复: [PATCH 0/5] mc146818rtc: fix Windows VM clock faster

2017-04-13 Thread Zhanghailiang
Hi, -邮件原件- 发件人: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] 代表 Xiao Guangrong 发送时间: 2017年4月13日 16:53 收件人: Paolo Bonzini; m...@redhat.com; mtosa...@redhat.com 抄送: qemu-devel@nongnu.org; k...@vger.kernel.org; yunfang...@tencent.com; Xiao Guangrong 主题: Re: [PATCH 0/5] mc146

[Qemu-devel] [PATCH v17 2/2] virtio-crypto: Add conformance clauses

2017-04-13 Thread Gonglei
Add the conformance targets and clauses for virtio-crypto device. Signed-off-by: Gonglei --- conformance.tex | 29 + 1 file changed, 29 insertions(+) diff --git a/conformance.tex b/conformance.tex index f59e360..7c7a55c 100644 --- a/conformance.tex +++ b/conformance.

[Qemu-devel] [PATCH v17 0/2] virtio-crypto: virtio crypto device specification

2017-04-13 Thread Gonglei
Thanks to Stefan, Michael, Halil, Cornelia for reviewing. The v17 has some big changes, so I don't add Stefan's R-by until I get a response for the new version :) v17 -> v16: - Some grammar fixes [Stefan, Halil, Michael] - add a section named "Supported crypto services" in order to explain bit

[Qemu-devel] [PATCH v17 1/2] virtio-crypto: Add virtio crypto device specification

2017-04-13 Thread Gonglei
The virtio crypto device is a virtual crypto device (ie. hardware crypto accelerator card). Currently, the virtio crypto device provides the following crypto services: CIPHER, MAC, HASH, and AEAD. In this patch, CIPHER, MAC, HASH, AEAD services are introduced. VIRTIO-153 Signed-off-by: Gonglei

Re: [Qemu-devel] 答复: [PATCH 0/5] mc146818rtc: fix Windows VM clock faster

2017-04-13 Thread Xiao Guangrong
On 04/13/2017 05:05 PM, Zhanghailiang wrote: Hi, -邮件原件- 发件人: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] 代表 Xiao Guangrong 发送时间: 2017年4月13日 16:53 收件人: Paolo Bonzini; m...@redhat.com; mtosa...@redhat.com 抄送: qemu-devel@nongnu.org; k...@vger.kernel.org; yunfang...@tence

Re: [Qemu-devel] [PATCH 03/12] dirty-bitmap: Drop unused functions

2017-04-13 Thread Vladimir Sementsov-Ogievskiy
13.04.2017 02:40, John Snow wrote: On 04/12/2017 07:36 PM, Eric Blake wrote: On 04/12/2017 05:47 PM, John Snow wrote: On 04/12/2017 01:49 PM, Eric Blake wrote: We had several functions that no one was using, and which used sector-based interfaces. I'm trying to convert towards byte-based in

Re: [Qemu-devel] WinDbg module

2017-04-13 Thread Mihail Abakumov
Ladi Prosek писал 2017-04-13 10:02: The linked v2.7.50-windbg seems to be a Windows release. Does it also work on Linux hosts with KVM? I haven't tested it yet, but it should work. Also, #ifdef TARGET_X86_64 // Unimplemented yet #error Unsupported Architecture #endif can you estima

Re: [Qemu-devel] 答复: [PATCH 0/5] mc146818rtc: fix Windows VM clock faster

2017-04-13 Thread Hailiang Zhang
On 2017/4/13 17:18, Xiao Guangrong wrote: On 04/13/2017 05:05 PM, Zhanghailiang wrote: Hi, -邮件原件- 发件人: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] 代表 Xiao Guangrong 发送时间: 2017年4月13日 16:53 收件人: Paolo Bonzini; m...@redhat.com; mtosa...@redhat.com 抄送: qemu-devel@nongnu.o

Re: [Qemu-devel] WinDbg module

2017-04-13 Thread Mihail Abakumov
Stefan Weil писал 2017-04-12 20:55: Am 12.04.2017 um 18:30 schrieb Roman Kagan: On Wed, Apr 12, 2017 at 05:05:45PM +0300, Mihail Abakumov wrote: Hello. We made the debugger module WinDbg (like GDB) for QEMU. This is the replacement of the remote stub in Windows kernel. Used for remote Windows

Re: [Qemu-devel] 答复: [PATCH 0/5] mc146818rtc: fix Windows VM clock faster

2017-04-13 Thread Xiao Guangrong
On 04/13/2017 05:29 PM, Hailiang Zhang wrote: On 2017/4/13 17:18, Xiao Guangrong wrote: On 04/13/2017 05:05 PM, Zhanghailiang wrote: Hi, -邮件原件- 发件人: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] 代表 Xiao Guangrong 发送时间: 2017年4月13日 16:53 收件人: Paolo Bonzini; m...@redhat.

Re: [Qemu-devel] 答复: [PATCH 0/5] mc146818rtc: fix Windows VM clock faster

2017-04-13 Thread Hailiang Zhang
On 2017/4/13 17:35, Xiao Guangrong wrote: On 04/13/2017 05:29 PM, Hailiang Zhang wrote: On 2017/4/13 17:18, Xiao Guangrong wrote: On 04/13/2017 05:05 PM, Zhanghailiang wrote: Hi, -邮件原件- 发件人: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] 代表 Xiao Guangrong 发送时间: 2017年4月1

[Qemu-devel] [PATCH v9 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2017-04-13 Thread Wei Wang
This patch series implements two optimizations: 1) transfer pages in chuncks between the guest and host; 2) transfer the guest unused pages to the host so that they can be skipped to migrate in live migration. Changes: v8->v9: 1) Split the two new features, VIRTIO_BALLOON_F_BALLOON_CHUNKS and VIRT

[Qemu-devel] [PATCH v9 2/5] virtio-balloon: VIRTIO_BALLOON_F_BALLOON_CHUNKS

2017-04-13 Thread Wei Wang
Add a new feature, VIRTIO_BALLOON_F_BALLOON_CHUNKS, which enables the transfer of the ballooned (i.e. inflated/deflated) pages in chunks to the host. The implementation of the previous virtio-balloon is not very efficient, because the ballooned pages are transferred to the host one by one. Here is

[Qemu-devel] [PATCH v9 4/5] mm: export symbol of next_zone and first_online_pgdat

2017-04-13 Thread Wei Wang
This patch enables for_each_zone()/for_each_populated_zone() to be invoked by a kernel module. Signed-off-by: Wei Wang --- mm/mmzone.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/mmzone.c b/mm/mmzone.c index 5652be8..e14b7ec 100644 --- a/mm/mmzone.c +++ b/mm/mmzone.c @@ -13,6 +13,7

[Qemu-devel] [PATCH v2 3/5] net/ftgmac100: add a 'aspeed' property

2017-04-13 Thread Cédric Le Goater
The Aspeed SoCs have a different definition of the end of the ring buffer bit. Add a property to specify which set of bits should be used by the NIC. Signed-off-by: Cédric Le Goater --- hw/net/ftgmac100.c | 17 +++-- include/hw/net/ftgmac100.h | 4 2 files changed, 19 i

[Qemu-devel] [PATCH v9 1/5] virtio-balloon: deflate via a page list

2017-04-13 Thread Wei Wang
From: Liang Li This patch saves the deflated pages to a list, instead of the PFN array. Accordingly, the balloon_pfn_to_page() function is removed. Signed-off-by: Liang Li Signed-off-by: Michael S. Tsirkin Signed-off-by: Wei Wang --- drivers/virtio/virtio_balloon.c | 22 -

[Qemu-devel] [PATCH v2 1/5] hw/net: add MII definitions

2017-04-13 Thread Cédric Le Goater
This adds comments on the Basic mode control and status registers bit definitions. It also adds a couple of bits for 1000BASE-T and the RealTek 8211E PHY for the FTGMAC100 model to use. Signed-off-by: Cédric Le Goater --- include/hw/net/mii.h | 71 +++-

[Qemu-devel] [PATCH v2 2/5] net: add FTGMAC100 support

2017-04-13 Thread Cédric Le Goater
The FTGMAC100 device is an Ethernet controller with DMA function that can be found on Aspeed SoCs (which include NCSI). It is fully compliant with IEEE 802.3 specification for 10/100 Mbps Ethernet and IEEE 802.3z specification for 1000 Mbps Ethernet and includes Reduced Media Independent Interface

[Qemu-devel] [PATCH v9 3/5] mm: function to offer a page block on the free list

2017-04-13 Thread Wei Wang
Add a function to find a page block on the free list specified by the caller. Pages from the page block may be used immediately after the function returns. The caller is responsible for detecting or preventing the use of such pages. Signed-off-by: Wei Wang Signed-off-by: Liang Li --- include/li

Re: [Qemu-devel] [Qemu-devel RFC v2 0/4] Add support for Smartfusion2 SoC

2017-04-13 Thread Peter Maydell
On 13 April 2017 at 04:21, sundeep subbaraya wrote: > Hi Qemu-devel, > > This is my first attempt in Qemu. > Please let me know am doing correct or not. > SoC is cortex M3 based so no bootrom stuff and unlike other > SoCs Qemu need not load dtb and kernel in DDR. Hence am using > u-boot (supplied

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-13 Thread Kevin Wolf
Am 12.04.2017 um 21:02 hat Denis V. Lunev geschrieben: > On 04/12/2017 09:20 PM, Eric Blake wrote: > > On 04/12/2017 12:55 PM, Denis V. Lunev wrote: > >> Let me rephrase a bit. > >> > >> The proposal is looking very close to the following case: > >> - raw sparse file > >> > >> In this case all writ

[Qemu-devel] [PATCH v9 5/5] virtio-balloon: VIRTIO_BALLOON_F_MISC_VQ

2017-04-13 Thread Wei Wang
Add a new vq, miscq, to handle miscellaneous requests between the device and the driver. This patch implemnts the VIRTIO_BALLOON_MISCQ_INQUIRE_UNUSED_PAGES request sent from the device. Upon receiving this request from the miscq, the driver offers to the device the guest unused pages. Tests have

[Qemu-devel] [PATCH v2 5/5] slirp: add a fake NC-SI backend

2017-04-13 Thread Cédric Le Goater
NC-SI (Network Controller Sideband Interface) enables a BMC to manage a set of NICs on a system. This model takes the simplest approach and reverses the NC-SI packets to pretend a NIC is present and exercise the Linux driver. The NCSI header file comes from mainline Linux and was untabified. Sig

[Qemu-devel] [PATCH v2 0/5] FTGMAC100 nic model for the Aspeed SoCs

2017-04-13 Thread Cédric Le Goater
Hi, The Aspeed SoCs AST2400 and AST2500 have two FTGMAC100 ethernet controllers. This serie proposes a model for this device and a way to customize the bit definitions which are slightly different from the Faraday definitions. The last patch adds a fake NC-SI (Network Controller Sideband Interfac

Re: [Qemu-devel] Regression from 2.8: stuck in bdrv_drain()

2017-04-13 Thread Peter Maydell
On 13 April 2017 at 00:54, Fam Zheng wrote: > John and I confirmed that this can be fixed by this pending patch: > > [PATCH for-2.9 4/5] block: Drain BH in bdrv_drained_begin > > https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg01018.html > > It didn't make it into 2.9-rc4 because of limit

[Qemu-devel] [PATCH v2 4/5] aspeed: add a FTGMAC100 nic

2017-04-13 Thread Cédric Le Goater
There is a second NIC but we do not use it for the moment. We use the 'aspeed' property to tune the definition of the end of ring buffer bit for the Aspeed SoCs. Signed-off-by: Cédric Le Goater --- hw/arm/aspeed_soc.c | 21 + include/hw/arm/aspeed_soc.h | 2 ++ 2 fil

Re: [Qemu-devel] [PULL 02/15] docs: VM Generation ID device description

2017-04-13 Thread Marc-André Lureau
Hi On Thu, Apr 13, 2017 at 1:17 AM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi > > On Thu, Apr 13, 2017 at 1:03 AM Ben Warren wrote: > > On Apr 12, 2017, at 1:47 PM, Marc-André Lureau > wrote: > > Hi > > On Thu, Apr 13, 2017 at 12:25 AM Ben Warren > wrote: > > On Apr 12, 2017,

Re: [Qemu-devel] [Qemu-devel RFC v2 0/4] Add support for Smartfusion2 SoC

2017-04-13 Thread sundeep subbaraya
Hi, On Thu, Apr 13, 2017 at 3:14 PM, Peter Maydell wrote: > On 13 April 2017 at 04:21, sundeep subbaraya wrote: >> Hi Qemu-devel, >> >> This is my first attempt in Qemu. >> Please let me know am doing correct or not. >> SoC is cortex M3 based so no bootrom stuff and unlike other >> SoCs Qemu nee

[Qemu-devel] [PATCH v4 0/1] qga: Add 'guest-get-users' command

2017-04-13 Thread Vinzenz 'evilissimo' Feenstra
From: Vinzenz Feenstra Changes since v3: - Removed ifdef/endif around QGA_MICRO_SECOND_TO_SECOND Changes since v2: - Updated the documentation of login-time to be more precise what the value contains and what time is actually reported and in which format. Changes since v1: - fixed spelling is

[Qemu-devel] [PATCH v4 1/1] qga: Add 'guest-get-users' command

2017-04-13 Thread Vinzenz 'evilissimo' Feenstra
From: Vinzenz Feenstra A command that will list all currently logged in users, and the time since when they are logged in. Examples: virsh # qemu-agent-command F25 '{ "execute": "guest-get-users" }' {"return":[{"login-time":1490622289.903835,"user":"root"}]} virsh # qemu-agent-command Win2k12r

[Qemu-devel] qemu and own disk driver writing questions

2017-04-13 Thread Vasiliy Tolstov
Hi! If i want to develop some sort of qemu network block driver to own storage. I can write qemu driver or tcmu / scst userspace driver and attach to qemu block device (i'm use linux) So in theory what path have minimal overhead in case of memory copy and performance? Where i can find some info how

Re: [Qemu-devel] [PATCH kernel v8 3/4] mm: add inerface to offer info about unused pages

2017-04-13 Thread Wei Wang
On 03/17/2017 05:28 AM, Andrew Morton wrote: On Thu, 16 Mar 2017 15:08:46 +0800 Wei Wang wrote: From: Liang Li This patch adds a function to provides a snapshot of the present system unused pages. An important usage of this function is to provide the unsused pages to the Live migration threa

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 1/5] hw/net: add MII definitions

2017-04-13 Thread Philippe Mathieu-Daudé
On 04/13/2017 06:41 AM, Cédric Le Goater wrote: This adds comments on the Basic mode control and status registers bit definitions. It also adds a couple of bits for 1000BASE-T and the RealTek 8211E PHY for the FTGMAC100 model to use. Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathi

Re: [Qemu-devel] [PATCH v2 5/5] slirp: add a fake NC-SI backend

2017-04-13 Thread Philippe Mathieu-Daudé
On 04/13/2017 06:41 AM, Cédric Le Goater wrote: NC-SI (Network Controller Sideband Interface) enables a BMC to manage a set of NICs on a system. This model takes the simplest approach and reverses the NC-SI packets to pretend a NIC is present and exercise the Linux driver. The NCSI header file

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-13 Thread Alberto Garcia
On Wed 12 Apr 2017 06:54:50 PM CEST, Denis V. Lunev wrote: > My opinion about this approach is very negative as the problem could > be (partially) solved in a much better way. Hmm... it seems to me that (some of) the problems you are describing are different from the ones this proposal tries to ad

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-13 Thread Kevin Wolf
Am 13.04.2017 um 14:44 hat Denis V. Lunev geschrieben: > On 04/13/2017 02:58 PM, Alberto Garcia wrote: > > On Wed 12 Apr 2017 06:54:50 PM CEST, Denis V. Lunev wrote: > >> My opinion about this approach is very negative as the problem could > >> be (partially) solved in a much better way. > > Hmm...

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-13 Thread Alberto Garcia
On Thu 13 Apr 2017 02:44:51 PM CEST, Denis V. Lunev wrote: >>> 1) current L2 cache management seems very wrong to me. Each cache >>> miss means that we have to read entire L2 cache block. This means >>> that in the worst case (when dataset of the test does not fit L2 >>> cache size we r

Re: [Qemu-devel] [PATCH for-2.10] Revert "block/io: Comment out permission assertions"

2017-04-13 Thread Stefan Hajnoczi
On Tue, Apr 11, 2017 at 05:52:26PM +0200, Max Reitz wrote: > This reverts commit e3e0003a8f6570aba1421ef99a0b383a43371a74. > > This commit was necessary for the 2.9 release because we were unable to > fix the underlying issue(s) in time. However, we will be for 2.10. > > Signed-off-by: Max Reitz

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-13 Thread Alberto Garcia
On Thu 13 Apr 2017 03:09:53 PM CEST, Denis V. Lunev wrote: >>> For nowadays SSD we are facing problems somewhere else. Right now I >>> can achieve only 100k IOPSes on SSD capable of 350-550k. 1 Mb block >>> with preallocation and fragmented L2 cache gives same 100k. Tests >>> for initially empty im

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-13 Thread Kevin Wolf
Am 13.04.2017 um 15:21 hat Alberto Garcia geschrieben: > This invariant is already broken by the very design of the qcow2 format, > subclusters don't really add anything new there. For any given cluster > size you can write 4k in every odd cluster, then do the same in every > even cluster, and you'

Re: [Qemu-devel] [PATCH for-2.10 10/23] numa: mirror cpu to node mapping in MachineState::possible_cpus

2017-04-13 Thread Eduardo Habkost
On Wed, Mar 22, 2017 at 02:32:35PM +0100, Igor Mammedov wrote: > Introduce machine_set_cpu_numa_node() helper that stores > node mapping for CPU in MachineState::possible_cpus. > CPU and node it belongs to is specified by 'props' argument. > > Patch doesn't remove old way of storing mapping in > n

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-13 Thread Kevin Wolf
Am 13.04.2017 um 15:30 hat Denis V. Lunev geschrieben: > On 04/13/2017 04:21 PM, Alberto Garcia wrote: > > On Thu 13 Apr 2017 02:44:51 PM CEST, Denis V. Lunev wrote: > 1) current L2 cache management seems very wrong to me. Each cache > miss means that we have to read entire L2 cache b

Re: [Qemu-devel] [PATCH v2 5/5] slirp: add a fake NC-SI backend

2017-04-13 Thread Samuel Thibault
Hello, Philippe Mathieu-Daudé, on jeu. 13 avril 2017 08:45:23 -0300, wrote: > > The NCSI header file comes from mainline Linux Please mention within the file which file it comes from exactly. > > +case NCSI_PKT_CMD_SMA: > > +rnh->common.length = htons(4); > > +break; > > +

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-13 Thread Alberto Garcia
On Thu 13 Apr 2017 03:51:55 PM CEST, Kevin Wolf wrote: >> This invariant is already broken by the very design of the qcow2 >> format, subclusters don't really add anything new there. For any >> given cluster size you can write 4k in every odd cluster, then do the >> same in every even cluster, and

Re: [Qemu-devel] [PATCH v6] migration/block: use blk_pwrite_zeroes for each zero cluster

2017-04-13 Thread Stefan Hajnoczi
On Thu, Apr 13, 2017 at 10:34:28AM +0800, jemmy858...@gmail.com wrote: > From: Lidong Chen > > BLOCK_SIZE is (1 << 20), qcow2 cluster size is 65536 by default, > this may cause the qcow2 file size to be bigger after migration. > This patch checks each cluster, using blk_pwrite_zeroes for each > z

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-13 Thread Denis V. Lunev
On 04/13/2017 02:58 PM, Alberto Garcia wrote: > On Wed 12 Apr 2017 06:54:50 PM CEST, Denis V. Lunev wrote: >> My opinion about this approach is very negative as the problem could >> be (partially) solved in a much better way. > Hmm... it seems to me that (some of) the problems you are describing ar

Re: [Qemu-devel] vmbus bridge: machine property or device?

2017-04-13 Thread Roman Kagan
On Wed, Apr 12, 2017 at 05:18:51PM +0200, Markus Armbruster wrote: > Roman Kagan writes: > > VMBus is provided by a vmbus bridge; it appears the most natural to have > > it subclassed from SysBusDevice. There can only be one VMBus in the > > VM. > > TYPE_DEVICE unless you actually need something

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-13 Thread Kevin Wolf
Am 13.04.2017 um 16:15 hat Alberto Garcia geschrieben: > On Thu 13 Apr 2017 03:51:55 PM CEST, Kevin Wolf wrote: > >> This invariant is already broken by the very design of the qcow2 > >> format, subclusters don't really add anything new there. For any > >> given cluster size you can write 4k in eve

Re: [Qemu-devel] Regression from 2.8: stuck in bdrv_drain()

2017-04-13 Thread Eric Blake
On 04/13/2017 04:48 AM, Peter Maydell wrote: > On 13 April 2017 at 00:54, Fam Zheng wrote: >> John and I confirmed that this can be fixed by this pending patch: >> >> [PATCH for-2.9 4/5] block: Drain BH in bdrv_drained_begin >> >> https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg01018.html

Re: [Qemu-devel] [PATCH for-2.10] Revert "block/io: Comment out permission assertions"

2017-04-13 Thread Max Reitz
On 13.04.2017 15:28, Stefan Hajnoczi wrote: > On Tue, Apr 11, 2017 at 05:52:26PM +0200, Max Reitz wrote: >> This reverts commit e3e0003a8f6570aba1421ef99a0b383a43371a74. >> >> This commit was necessary for the 2.9 release because we were unable to >> fix the underlying issue(s) in time. However, we

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-13 Thread Denis V. Lunev
On 04/13/2017 04:36 PM, Alberto Garcia wrote: > On Thu 13 Apr 2017 03:09:53 PM CEST, Denis V. Lunev wrote: For nowadays SSD we are facing problems somewhere else. Right now I can achieve only 100k IOPSes on SSD capable of 350-550k. 1 Mb block with preallocation and fragmented L2 cach

Re: [Qemu-devel] Regression from 2.8: stuck in bdrv_drain()

2017-04-13 Thread Stefan Hajnoczi
On Thu, Apr 13, 2017 at 01:45:55PM +0800, Paolo Bonzini wrote: > > > On 13/04/2017 09:11, Jeff Cody wrote: > >> It didn't make it into 2.9-rc4 because of limited time. :( > >> > >> Looks like there is no -rc5, we'll have to document this as a known issue. > >> Users should "block-job-complete/can

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-13 Thread Denis V. Lunev
On 04/13/2017 04:51 PM, Kevin Wolf wrote: > Am 13.04.2017 um 15:21 hat Alberto Garcia geschrieben: >> This invariant is already broken by the very design of the qcow2 format, >> subclusters don't really add anything new there. For any given cluster >> size you can write 4k in every odd cluster, the

Re: [Qemu-devel] Regression from 2.8: stuck in bdrv_drain()

2017-04-13 Thread Eric Blake
On 04/13/2017 09:39 AM, Stefan Hajnoczi wrote: > On Thu, Apr 13, 2017 at 01:45:55PM +0800, Paolo Bonzini wrote: >> >> >> On 13/04/2017 09:11, Jeff Cody wrote: It didn't make it into 2.9-rc4 because of limited time. :( Looks like there is no -rc5, we'll have to document this as a know

Re: [Qemu-devel] [PATCH v2 0/2] migration: fix virtio-rng

2017-04-13 Thread Stefan Hajnoczi
On Wed, Apr 12, 2017 at 03:53:10PM +0200, Laurent Vivier wrote: > When post-copy migration is enabled, the destination > guest can ask for memory from the source when the > vmstate is restored. > > In the case of virtio, a part of the virtqueue > is migrated by the vmstate structure (last_avail_id

Re: [Qemu-devel] Regression from 2.8: stuck in bdrv_drain()

2017-04-13 Thread Jeff Cody
On Thu, Apr 13, 2017 at 09:45:49AM -0500, Eric Blake wrote: > On 04/13/2017 09:39 AM, Stefan Hajnoczi wrote: > > On Thu, Apr 13, 2017 at 01:45:55PM +0800, Paolo Bonzini wrote: > >> > >> > >> On 13/04/2017 09:11, Jeff Cody wrote: > It didn't make it into 2.9-rc4 because of limited time. :( > >>

Re: [Qemu-devel] Regression from 2.8: stuck in bdrv_drain()

2017-04-13 Thread Peter Maydell
On 13 April 2017 at 15:33, Eric Blake wrote: > On 04/13/2017 04:48 AM, Peter Maydell wrote: >> Well, we *hope* there is no -rc5, but if the bug is genuinely >> a "we can't release like this" bug we will obviously have to >> do another rc. Basically you all as the block maintainers should >> make t

Re: [Qemu-devel] [PATCH] qga: improve fsfreeze documentations

2017-04-13 Thread Vinzenz Feenstra
Reviewed-by: Vinzenz Feenstra mailto:marcandre.lur...@redhat.com>> > On Apr 3, 2017, at 11:54 AM, Marc-André Lureau > wrote: > > Some users find the fsfreeze behaviour confusing. Add some notes about > invalid mount points and Windows usage. > > Related to: > https://bugzilla.redhat.com/show_b

Re: [Qemu-devel] [PATCH 1/3] migration/i386: Remove old non-softfloat 64bit FP support

2017-04-13 Thread Eduardo Habkost
On Wed, Apr 05, 2017 at 08:00:22PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Long long ago, we used to support storing the x86 FP registers in > a 64bit format. > > Then c31da136a0bf8caad70c348f5ffc283206e9c7fc in v0.14-rc0 removed > the last support for wri

Re: [Qemu-devel] Regression from 2.8: stuck in bdrv_drain()

2017-04-13 Thread Jeff Cody
On Thu, Apr 13, 2017 at 03:39:59PM +0100, Stefan Hajnoczi wrote: > On Thu, Apr 13, 2017 at 01:45:55PM +0800, Paolo Bonzini wrote: > > > > > > On 13/04/2017 09:11, Jeff Cody wrote: > > >> It didn't make it into 2.9-rc4 because of limited time. :( > > >> > > >> Looks like there is no -rc5, we'll ha

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-13 Thread Alberto Garcia
On Thu 13 Apr 2017 03:30:43 PM CEST, Denis V. Lunev wrote: > Yes, block size should be increased. I perfectly in agreement with > your. But I think that we could do that by plain increase of the > cluster size without any further dances. Sub-clusters as sub-clusters > will help if we are able to a

Re: [Qemu-devel] [Qemu-block] Regression from 2.8: stuck in bdrv_drain()

2017-04-13 Thread Stefan Hajnoczi
On Thu, Apr 13, 2017 at 6:45 AM, Paolo Bonzini wrote: > On 13/04/2017 09:11, Jeff Cody wrote: >>> It didn't make it into 2.9-rc4 because of limited time. :( >>> >>> Looks like there is no -rc5, we'll have to document this as a known issue. >>> Users should "block-job-complete/cancel" as soon as po

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-13 Thread Denis V. Lunev
On 04/13/2017 06:04 PM, Alberto Garcia wrote: > On Thu 13 Apr 2017 03:30:43 PM CEST, Denis V. Lunev wrote: >> Yes, block size should be increased. I perfectly in agreement with >> your. But I think that we could do that by plain increase of the >> cluster size without any further dances. Sub-clust

[Qemu-devel] [PATCH for-2.10?] block: Do not unref bs->file on error in BD's open

2017-04-13 Thread Max Reitz
The block layer takes care of removing the bs->file child if the block driver's bdrv_open()/bdrv_file_open() implementation fails. The block driver therefore does not need to do so, and indeed should not unless it sets bs->file to NULL afterwards -- because if this is not done, the bdrv_unref_child

[Qemu-devel] [PATCH for-2.10 0/2] block: An empty filename counts as no filename

2017-04-13 Thread Max Reitz
See patch 1 for what is happening when you try "qemu-img info ''" and for the fix. (Patch 2 just adds a simple test.) Max Reitz (2): block: An empty filename counts as no filename iotests/051: Add test for empty filename block.c | 2 +- tests/qemu-iotests/051|

[Qemu-devel] [PATCH for-2.10 1/2] block: An empty filename counts as no filename

2017-04-13 Thread Max Reitz
Reproducer: $ ./qemu-img info '' qemu-img: ./block.c:1008: bdrv_open_driver: Assertion `!drv->bdrv_needs_filename || bs->filename[0]' failed. [1]26105 abort (core dumped) ./qemu-img info '' This patch fixes this to be: $ ./qemu-img info '' qemu-img: Could not open

[Qemu-devel] [PATCH for-2.10 2/2] iotests/051: Add test for empty filename

2017-04-13 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/051| 1 + tests/qemu-iotests/051.out| 3 +++ tests/qemu-iotests/051.pc.out | 3 +++ 3 files changed, 7 insertions(+) diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051 index 630cb7a114..4fe676019b 100755 --- a/tests/qemu-iotes

Re: [Qemu-devel] [PATCH v2 5/5] slirp: add a fake NC-SI backend

2017-04-13 Thread Cédric Le Goater
On 04/13/2017 01:45 PM, Philippe Mathieu-Daudé wrote: > > > On 04/13/2017 06:41 AM, Cédric Le Goater wrote: >> NC-SI (Network Controller Sideband Interface) enables a BMC to manage >> a set of NICs on a system. This model takes the simplest approach and >> reverses the NC-SI packets to pretend a

[Qemu-devel] [PATCH] util/error: Fix leak in error_vprepend()

2017-04-13 Thread Max Reitz
Signed-off-by: Max Reitz --- util/error.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/error.c b/util/error.c index 9c40b1f458..020b86b9f0 100644 --- a/util/error.c +++ b/util/error.c @@ -134,6 +134,7 @@ void error_vprepend(Error **errp, const char *fmt, va_list ap) newmsg = g_s

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 0/2] block: An empty filename counts as no filename

2017-04-13 Thread Eric Blake
On 04/13/2017 11:06 AM, Max Reitz wrote: > See patch 1 for what is happening when you try "qemu-img info ''" and > for the fix. > > (Patch 2 just adds a simple test.) > > > Max Reitz (2): > block: An empty filename counts as no filename > iotests/051: Add test for empty filename Reviewed-by

Re: [Qemu-devel] [PATCH for-2.9?] block: Do not unref bs->file on error in BD's open

2017-04-13 Thread Eric Blake
On 04/13/2017 10:43 AM, Max Reitz wrote: > The block layer takes care of removing the bs->file child if the block > driver's bdrv_open()/bdrv_file_open() implementation fails. The block > driver therefore does not need to do so, and indeed should not unless it > sets bs->file to NULL afterwards --

Re: [Qemu-devel] [PATCH v9 2/5] virtio-balloon: VIRTIO_BALLOON_F_BALLOON_CHUNKS

2017-04-13 Thread Michael S. Tsirkin
On Thu, Apr 13, 2017 at 05:35:05PM +0800, Wei Wang wrote: > Add a new feature, VIRTIO_BALLOON_F_BALLOON_CHUNKS, which enables Let's find a better name here. VIRTIO_BALLOON_F_PAGE_CHUNK > the transfer of the ballooned (i.e. inflated/deflated) pages in > chunks to the host. > > The implementation

Re: [Qemu-devel] vmbus bridge: machine property or device?

2017-04-13 Thread Eduardo Habkost
On Thu, Apr 13, 2017 at 06:15:34PM +0300, Roman Kagan wrote: > On Wed, Apr 12, 2017 at 05:07:20PM -0300, Eduardo Habkost wrote: > > On Wed, Apr 12, 2017 at 05:18:51PM +0200, Markus Armbruster wrote: > > > Roman Kagan writes: > > > > VMBus is provided by a vmbus bridge; it appears the most natural

Re: [Qemu-devel] [PATCH 03/12] dirty-bitmap: Drop unused functions

2017-04-13 Thread John Snow
On 04/13/2017 05:19 AM, Vladimir Sementsov-Ogievskiy wrote: > 13.04.2017 02:40, John Snow wrote: >> >> On 04/12/2017 07:36 PM, Eric Blake wrote: >>> On 04/12/2017 05:47 PM, John Snow wrote: On 04/12/2017 01:49 PM, Eric Blake wrote: > We had several functions that no one was using, a

Re: [Qemu-devel] vmbus bridge: machine property or device?

2017-04-13 Thread Peter Maydell
On 13 April 2017 at 17:44, Eduardo Habkost wrote: > On Thu, Apr 13, 2017 at 06:15:34PM +0300, Roman Kagan wrote: >> Can you (or anybody else) please help me decide if I need >> TYPE_SYS_BUS_DEVICE? Logically the VMBus bridge is "attached directly >> to the main system bus" as written at the top o

Re: [Qemu-devel] Regression from 2.8: stuck in bdrv_drain()

2017-04-13 Thread John Snow
On 04/13/2017 11:02 AM, Jeff Cody wrote: > On Thu, Apr 13, 2017 at 03:39:59PM +0100, Stefan Hajnoczi wrote: >> On Thu, Apr 13, 2017 at 01:45:55PM +0800, Paolo Bonzini wrote: >>> >>> >>> On 13/04/2017 09:11, Jeff Cody wrote: > It didn't make it into 2.9-rc4 because of limited time. :( > >>

Re: [Qemu-devel] [PATCH v9 2/5] virtio-balloon: VIRTIO_BALLOON_F_BALLOON_CHUNKS

2017-04-13 Thread Matthew Wilcox
On Thu, Apr 13, 2017 at 07:34:19PM +0300, Michael S. Tsirkin wrote: > So we don't need the bitmap to talk to host, it is just > a data structure we chose to maintain lists of pages, right? > OK as far as it goes but you need much better isolation for it. > Build a data structure with APIs such as _

Re: [Qemu-devel] [PATCH v9 5/5] virtio-balloon: VIRTIO_BALLOON_F_MISC_VQ

2017-04-13 Thread Michael S. Tsirkin
On Thu, Apr 13, 2017 at 05:35:08PM +0800, Wei Wang wrote: > Add a new vq, miscq, to handle miscellaneous requests between the device > and the driver. > > This patch implemnts the VIRTIO_BALLOON_MISCQ_INQUIRE_UNUSED_PAGES implements > request sent from the device. Commands are sent from host an

Re: [Qemu-devel] ARM virt machine boots fail with 14 ioh3420

2017-04-13 Thread Laszlo Ersek
Adding Andrea, Ard, Drew and Marcel; and the main qemu list On 04/13/17 09:37, Shannon Zhao wrote: > Hi, > > I'm testing the PCIe devices hotplug for ARM virt machine and using > ioh3420 as root port. I found that below command line could work. > > qemu-system-aarch64 -machine virt,accel=kvm,usb

Re: [Qemu-devel] [Qemu-block] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-13 Thread Roman Kagan
On Thu, Apr 13, 2017 at 04:27:35PM +0200, Kevin Wolf wrote: > Am 13.04.2017 um 16:15 hat Alberto Garcia geschrieben: > > On Thu 13 Apr 2017 03:51:55 PM CEST, Kevin Wolf wrote: > > >> This invariant is already broken by the very design of the qcow2 > > >> format, subclusters don't really add anythin

Re: [Qemu-devel] [PATCH] i386: Allow cpuid bit override

2017-04-13 Thread Eduardo Habkost
On Tue, Mar 28, 2017 at 09:31:05AM -0300, Eduardo Habkost wrote: > On Tue, Mar 28, 2017 at 01:26:04PM +0200, Alexander Graf wrote: > > On 03/28/2017 02:41 AM, Eduardo Habkost wrote: > > > On Tue, Mar 28, 2017 at 12:19:37AM +0200, Alexander Graf wrote: > > > > KVM has a feature bitmap of CPUID bits

[Qemu-devel] [PATCH 1/3] migration: Call blk_resume_after_migration() for postcopy

2017-04-13 Thread Kevin Wolf
Commit d35ff5e6 ('block: Ignore guest dev permissions during incoming migration') added blk_resume_after_migration() to the precopy migration path, but neglected to add it to the duplicated code that is used for postcopy migration. This means that the guest device doesn't request the necessary perm

[Qemu-devel] [PATCH 2/3] qemu-iotests: Filter HMP readline escape characters

2017-04-13 Thread Kevin Wolf
The only thing the escape characters achieve is making the reference output unreadable and lines that are potentially so long that git doesn't want to put them into an email any more. Let's filter them out. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/028.out | 2 +- tests/qemu-iotests

[Qemu-devel] [PATCH 0/3] migration: Call blk_resume_after_migration() for postcopy

2017-04-13 Thread Kevin Wolf
This fixes one of the bugs that made us disable the op blocker assertions for the 2.9 release. Kevin Wolf (3): migration: Call blk_resume_after_migration() for postcopy qemu-iotests: Filter HMP readline escape characters qemu-iotests: Test postcopy migration migration/savevm.c

[Qemu-devel] [PATCH 3/3] qemu-iotests: Test postcopy migration

2017-04-13 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/qemu-iotests/181 | 117 + tests/qemu-iotests/181.out | 38 +++ tests/qemu-iotests/group | 1 + 3 files changed, 156 insertions(+) create mode 100755 tests/qemu-iotests/181 create mode 100644 tes

  1   2   >