On 13 April 2017 at 15:33, Eric Blake <ebl...@redhat.com> wrote: > On 04/13/2017 04:48 AM, Peter Maydell wrote: >> Well, we *hope* there is no -rc5, but if the bug is genuinely >> a "we can't release like this" bug we will obviously have to >> do another rc. Basically you all as the block maintainers should >> make the call about whether it's release-critical or not. > > Just curious: is there a technical reason we couldn't spin an -rc5 today > (with just the fix to this issue), and slip the schedule only by two > days instead of a full week? And/or shorten the time for testing -rc5 > from the usual 7 days into 5?
I've just heard about another issue which probably will require an rc5. Whether that means it makes sense to add this fix too I don't know. Not a technical reason, but we're a bit short on time to do an rc5 today, and I'm away on holiday until Tuesday after that anyway. My current plan is that we'll roll rc5 on Tuesday with either just the fix for that other issue or that plus this one, and then tag final release Thursday. What you lot as the block maintainers should decide is whether this is a release-critical bug that justifies sticking a fix in at the last minute, and if so make sure you have a patch on the list which fixes it and has been reviewed and flag it up to me so I can apply it on Tuesday. thanks -- PMM