On 04/13/2017 04:48 AM, Peter Maydell wrote: > On 13 April 2017 at 00:54, Fam Zheng <f...@redhat.com> wrote: >> John and I confirmed that this can be fixed by this pending patch: >> >> [PATCH for-2.9 4/5] block: Drain BH in bdrv_drained_begin >> >> https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg01018.html >> >> It didn't make it into 2.9-rc4 because of limited time. :( >> >> Looks like there is no -rc5, we'll have to document this as a known issue. > > Well, we *hope* there is no -rc5, but if the bug is genuinely > a "we can't release like this" bug we will obviously have to > do another rc. Basically you all as the block maintainers should > make the call about whether it's release-critical or not.
Just curious: is there a technical reason we couldn't spin an -rc5 today (with just the fix to this issue), and slip the schedule only by two days instead of a full week? And/or shorten the time for testing -rc5 from the usual 7 days into 5? I don't know what other constraints we have to play with, so feel free to tell me that my idea is not feasible. Also, while I'm a block layer contributor, I'm not one of its co-maintainers, so I'd trust the replies from others a bit more than mine when deciding what to do here. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature