Re: [Qemu-devel] [PATCH for-2.9] Fix check for target OS support

2017-03-28 Thread Peter Maydell
On 27 March 2017 at 21:11, Stefan Weil wrote: > This check had several problems which are fixed here: > > * Calling "configure --help" was no longer possible on Cygwin. > Fix this by introducing a third state for supported_os and > by moving the error handling code. > Move the error handlin

[Qemu-devel] [PATCH] target-i386: fix "info lapic" segfault on isapc

2017-03-28 Thread Tejaswini
From: Tejaswini Poluri Start QEMU with "qemu-system-x86_64 -nographic -M isapc -serial none-monitor stdio" and enter "info lapic" at the monitor prompt ⇒ Segmentation fault Signed-off-by: Tejaswini Poluri --- target/i386/helper.c | 4 1 file changed, 4 insertions(+) diff --git a/target/i

[Qemu-devel] [PATCH v1] qga: Add 'guest-get-users' command

2017-03-28 Thread Vinzenz 'evilissimo' Feenstra
From: Vinzenz Feenstra A command that will list all currenctly logged in users having running processes. Examples: virsh # qemu-agent-command F25 '{ "execute": "guest-get-users" }' {"return":[{"user":"root"}]} virsh # qemu-agent-command Win2k12r2 '{ "execute": "guest-get-users" }' {"return":[{

Re: [Qemu-devel] Problems with native Mingw-w64 build

2017-03-28 Thread Mark Cave-Ayland
On 27/03/17 21:19, Stefan Weil wrote: > Am 27.03.2017 um 07:48 schrieb Mark Cave-Ayland: >> Right, I see cygwin has a much newer version of glib available which >> explains how the builds are produced. >> >> What was the exact issue with global symbols which prevents the >> pre-built Win64 binarie

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 02/11] rbd: Fix to cleanly reject -drive without pool or image

2017-03-28 Thread Markus Armbruster
Jeff Cody writes: > On Mon, Mar 27, 2017 at 03:26:26PM +0200, Markus Armbruster wrote: >> qemu_rbd_open() neglects to check pool and image are present. >> Reproducer: >> >> $ qemu-system-x86_64 -nodefaults -drive if=none,driver=rbd,pool=p >> Segmentation fault (core dumped) > > This repr

[Qemu-devel] [PATCH v3 1/8] ppc/xics: introduce an 'icp' backlink under PowerPCCPU

2017-03-28 Thread Cédric Le Goater
Today, the ICPState array of the sPAPR machine is indexed with 'cpu_index' of the CPUState. This numbering of CPUs is internal to QEMU and the guest only knows about what is exposed in the device tree, that is the 'cpu_dt_id'. This is why sPAPR uses the helper xics_get_cpu_index_by_dt_id() to do th

[Qemu-devel] [PATCH v3 0/8] ppc/pnv: interrupt controller (POWER8)

2017-03-28 Thread Cédric Le Goater
Hello, Here is a series adding support for the interrupt controller as found on a POWER8 system. POWER9 uses a different interrupt controller called XIVE, still to be worked on. The initial patches are more cleanups of the XICS layer which move the IRQ 'server' number mapping under the machine ha

[Qemu-devel] [PATCH v3 6/8] ppc/pnv: add a helper to calculate MMIO addresses registers

2017-03-28 Thread Cédric Le Goater
Some controllers (ICP, PSI) have a base register address which is calculated using the chip id. Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson --- include/hw/ppc/pnv.h | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/include/hw/ppc/pnv.h b/include/hw/p

[Qemu-devel] [PATCH v3 2/8] spapr: move the IRQ server number mapping under the machine

2017-03-28 Thread Cédric Le Goater
This is the second step to abstract the IRQ 'server' number of the XICS layer. Now that the prereq cleanups have been done in the previous patch, we can move down the 'cpu_dt_id' to 'cpu_index' mapping in the sPAPR machine handler. Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson --- h

[Qemu-devel] [PATCH v3 3/8] ppc/xics: add a realize() handler to ICPStateClass

2017-03-28 Thread Cédric Le Goater
It will be used by derived classes in PowerNV for customization. Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson --- hw/intc/xics.c| 5 + include/hw/ppc/xics.h | 1 + 2 files changed, 6 insertions(+) diff --git a/hw/intc/xics.c b/hw/intc/xics.c index bb485cc5b078..bf0fa22

[Qemu-devel] [PATCH v3 4/8] ppc/pnv: add a PnvICPState object

2017-03-28 Thread Cédric Le Goater
This provides a new ICPState object for the PowerNV machine (POWER8). Access to the Interrupt Management area is done though a memory region. It contains the registers of the Interrupt Control Presenters of each thread which are used to accept, return, forward interrupts in the system. Signed-off-

Re: [Qemu-devel] [PATCH 1/5] virtio: Error object based virtio_error()

2017-03-28 Thread Cornelia Huck
On Mon, 27 Mar 2017 21:20:56 +0300 "Michael S. Tsirkin" wrote: > On Mon, Mar 27, 2017 at 07:46:03PM +0200, Greg Kurz wrote: > > This introduces an Error object based implementation of virtio_error(). It > > allows to implement virtio_error() wrappers in device-specific code. > > > > Signed-off-b

[Qemu-devel] [PATCH v3 5/8] ppc/pnv: create the ICP and ICS objects under the machine

2017-03-28 Thread Cédric Le Goater
Like this is done for the sPAPR machine, we use a simple array under the PowerNV machine to store the Interrupt Control Presenters (ICP) objects, one for each vCPU. This array is indexed by 'cpu_index' of the CPUState but the users will provide a core PIR number. The mapping is done in the icp_get(

[Qemu-devel] [PATCH v3 8/8] ppc/pnv: add memory regions for the ICP registers

2017-03-28 Thread Cédric Le Goater
This provides to a PowerNV chip (POWER8) access to the Interrupt Management area, which contains the registers of the Interrupt Control Presenters of each thread. These are used to accept, return, forward interrupts in the system. This area is modeled with a per-chip container memory region holdin

[Qemu-devel] [PATCH v3 7/8] ppc/pnv: link the CPUs to the machine XICSFabric

2017-03-28 Thread Cédric Le Goater
This assigns the ICPState object to the CPU using the PIR number for lookups before calling the XICS layer to finish the job. Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson --- hw/ppc/pnv.c | 2 ++ hw/ppc/pnv_core.c | 20 2 files changed, 18 insertions(+),

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 02/11] rbd: Fix to cleanly reject -drive without pool or image

2017-03-28 Thread Markus Armbruster
Jeff Cody writes: > On Mon, Mar 27, 2017 at 08:58:28PM +0200, Markus Armbruster wrote: >> Markus Armbruster writes: >> >> > Max Reitz writes: >> > >> >> On 27.03.2017 18:10, Max Reitz wrote: >> >>> On 27.03.2017 15:26, Markus Armbruster wrote: >> qemu_rbd_open() neglects to check pool and

Re: [Qemu-devel] [PATCH] iscsi: drop unused IscsiAIOCB.qiov field

2017-03-28 Thread Paolo Bonzini
On 27/03/2017 18:50, Stefan Hajnoczi wrote: > The IscsiAIOCB.qiov field has been unused since commit > 063c3378a9e3c25cc0afac3c72e4823d0621e352 ("block/iscsi: introduce > bdrv_co_{readv, writev, flush_to_disk}") back in 2013. > > Signed-off-by: Stefan Hajnoczi > --- > block/iscsi.c | 1 - > 1

Re: [Qemu-devel] [PATCH] Create libqemutrace.a for all trace.o

2017-03-28 Thread Paolo Bonzini
On 27/03/2017 20:21, Xu, Anthony wrote: >>> ./trace.o, ./qapi/trace.o and ./util/trace.o are added into >>> libqemuutil.a to avoid recursive dependencies between >>> libqemuutil.a and libqemutrace.a. >> Why would libqemutrace.a depend on libqemuutil.a? > Each trace.c calls trace_event_register_g

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 09/11] rbd: Revert -blockdev parameter password-secret

2017-03-28 Thread Markus Armbruster
Jeff Cody writes: > On Mon, Mar 27, 2017 at 10:32:40PM -0400, Jeff Cody wrote: >> On Mon, Mar 27, 2017 at 03:26:33PM +0200, Markus Armbruster wrote: >> > This reverts a part of commit 8a47e8e. We're having second thoughts >> > on the QAPI schema (and thus the external interface), and haven't >>

Re: [Qemu-devel] [PATCH for-2.9] Fix check for target OS support

2017-03-28 Thread Paolo Bonzini
On 27/03/2017 22:11, Stefan Weil wrote: > * Support cross compilation with the most common cross prefixes > for Mingw-w64. Other cross builds are still broken! Can you explain how it's broken? Why does check_define not work at this point, for cross builds? "../configure --cross-prefix=x86_64

Re: [Qemu-devel] [PATCH] target-i386: fix "info lapic" segfault on isapc

2017-03-28 Thread Paolo Bonzini
On 28/03/2017 09:19, Tejaswini wrote: > From: Tejaswini Poluri > > Start QEMU with > "qemu-system-x86_64 -nographic -M isapc -serial none-monitor stdio" > and enter "info lapic" at the monitor prompt ⇒ > Segmentation fault > > Signed-off-by: Tejaswini Poluri > --- > target/i386/helper.c | 4

Re: [Qemu-devel] [PATCH v2] KVM: pci-assign: do not map smm memory slot pages

2017-03-28 Thread Paolo Bonzini
On 28/03/2017 03:08, Herongguang (Stephen) wrote: > From 8f5b9d2c2944ea7cd8149e9d3b4088f487217d20 Mon Sep 17 00:00:00 2001 > From: herongguang > Date: Mon, 27 Mar 2017 15:08:59 +0800 > Subject: [PATCH] KVM: pci-assign: do not map smm memory slot pages in vt-d > page table > > or VM memory are

Re: [Qemu-devel] [PATCH 1/5] virtio: Error object based virtio_error()

2017-03-28 Thread Greg Kurz
On Mon, 27 Mar 2017 21:20:56 +0300 "Michael S. Tsirkin" wrote: > On Mon, Mar 27, 2017 at 07:46:03PM +0200, Greg Kurz wrote: > > This introduces an Error object based implementation of virtio_error(). It > > allows to implement virtio_error() wrappers in device-specific code. > > > > Signed-off-b

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 03/11] rbd: Don't limit length of parameter values

2017-03-28 Thread Markus Armbruster
Jeff Cody writes: > On Mon, Mar 27, 2017 at 03:26:27PM +0200, Markus Armbruster wrote: >> We laboriously enforce parameter values are between one and some > > s/are/that are/ > > or maybe just s/are// What about: We laboriously enforce that parameter values are between one and some >> arbit

[Qemu-devel] [PATCH qemu] spapr_pci: Warn when RAM page size is not enabled in IOMMU page mask

2017-03-28 Thread Alexey Kardashevskiy
If a page size used by QEMU is not enabled in the PHB IOMMU page mask, in-kernel acceleration of TCE handling won't be enabled and performance might be slower than expected. This prints a warning if system page size is not enabled. This should print a warning if huge pages are enabled but sphb.pgs

Re: [Qemu-devel] [PATCH v4 14/16] docs: add documentation for vfio-ccw

2017-03-28 Thread Cornelia Huck
On Wed, 22 Mar 2017 10:34:22 +0800 Dong Jia Shi wrote: > * Alex Williamson [2017-03-21 12:47:16 -0600]: > > [...] > > > > +vfio-ccw I/O region > > > +--- > > > + > > > +An I/O region is used to accept channel program request from user > > > +space and store I/O interrupt result

Re: [Qemu-devel] [PATCH 2/3] libqtest: Add a generic function to run a callback function for every machine

2017-03-28 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > On 27.03.2017 16:24, Dr. David Alan Gilbert wrote: > > * Thomas Huth (th...@redhat.com) wrote: > >> Some tests need to run single tests for every available machine of the > >> current QEMU binary. To avoid code duplication, let's extract this > >> code that

Re: [Qemu-devel] [PATCH v4 00/16] basic vfio-ccw infrastructure

2017-03-28 Thread Cornelia Huck
On Fri, 17 Mar 2017 04:17:27 +0100 Dong Jia Shi wrote: > Dong Jia Shi (16): > s390: cio: introduce cio_cancel_halt_clear > s390: cio: export more interfaces > vfio: ccw: define device_api strings > vfio: ccw: basic implementation for vfio_ccw driver > vfio: ccw: introduce channel progra

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 08/11] rbd: Revert -blockdev and -drive parameter auth-supported

2017-03-28 Thread Markus Armbruster
Eric Blake writes: > On 03/27/2017 08:26 AM, Markus Armbruster wrote: >> This reverts half of commit 0a55679. We're having second thoughts on >> the QAPI schema (and thus the external interface), and haven't reached >> consensus, yet. Issues include: >> > >> Let's avoid painting ourselves into

Re: [Qemu-devel] [PATCH 1/5] virtio: Error object based virtio_error()

2017-03-28 Thread Cornelia Huck
On Tue, 28 Mar 2017 10:14:09 +0200 Greg Kurz wrote: > On Mon, 27 Mar 2017 21:20:56 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Mar 27, 2017 at 07:46:03PM +0200, Greg Kurz wrote: > > > This introduces an Error object based implementation of virtio_error(). It > > > allows to implement virt

Re: [Qemu-devel] [PATCH] xen: additionally restrict xenforeignmemory operations

2017-03-28 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > Sent: 27 March 2017 18:46 > To: Paul Durrant > Cc: 'Stefano Stabellini' ; qemu-devel@nongnu.org; > xen-de...@lists.xenproject.org; Anthony Perard > > Subject: RE: [PATCH] xen: additionally restrict xenforeig

[Qemu-devel] [PATCH v2 3/6] ui/console: ensure do_safe_dpy_refresh holds BQL

2017-03-28 Thread Alex Bennée
I missed the fact that when an exclusive work item runs it drops the BQL to ensure all no vCPUs are stuck waiting for it, hence causing a deadlock. However the actual helper needs to take the BQL especially as we'll be messing with device emulation bits during the update which all assume BQL is hel

[Qemu-devel] [PATCH v2 1/6] user-exec: handle synchronous signals from QEMU gracefully

2017-03-28 Thread Alex Bennée
When "tcg: enable thread-per-vCPU" (commit 3725794) was merged the lifetime of current_cpu was changed. Previously a broken linux-user call might abort() which can eventually escalate into a SIGSEGV which would then crash qemu as it attempted to deref a NULL current_cpu. After commit 3725794 it wou

[Qemu-devel] [PATCH v2 6/6] replay/replay.c: bump REPLAY_VERSION

2017-03-28 Thread Alex Bennée
A previous commit (3d4d16f4) added support for audio record/playback. However this breaks the logfile ABI due to the re-ordering of the ReplayEvents enum. The REPLAY_VERSION check is meant to prevent you from using old log files in newer QEMUs but this is currently broken. Signed-off-by: Alex Benn

[Qemu-devel] [PATCH v2 0/6] MTTCG fixes for rc1

2017-03-28 Thread Alex Bennée
Hi, Here is the current batch of fixes for MTTCG regressions for the next release candidate. I've dropped the speculative atomic cputlb patch and included 2 fixes to the console code. The first fixes the taking of the BQL (which I missed) and the second uses the exclusive mechanism directly in the

[Qemu-devel] [PATCH v2 4/6] ui/console: use exclusive mechanism directly

2017-03-28 Thread Alex Bennée
The previous commit (8bb93c6f99) using async_safe_run_on_cpu() doesn't work on graphics sub-system which restrict which threads can do GUI updates. Rather the special casing MacOS we just directly call the helper and move all the exclusive handling into do_dafe_dpy_refresh(). The unfortunate bounc

Re: [Qemu-devel] [PATCH v4 00/16] basic vfio-ccw infrastructure

2017-03-28 Thread Christian Borntraeger
On 03/28/2017 10:20 AM, Cornelia Huck wrote: > On Fri, 17 Mar 2017 04:17:27 +0100 > Dong Jia Shi wrote: > >> Dong Jia Shi (16): >> s390: cio: introduce cio_cancel_halt_clear >> s390: cio: export more interfaces >> vfio: ccw: define device_api strings >> vfio: ccw: basic implementation for

[Qemu-devel] [PATCH v2 5/6] tcg: Add a new line after incompatibility warning

2017-03-28 Thread Alex Bennée
From: Pranith Kumar Signed-off-by: Pranith Kumar Signed-off-by: Alex Bennée --- cpus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpus.c b/cpus.c index 167d9615e1..68fdbc40b9 100644 --- a/cpus.c +++ b/cpus.c @@ -209,7 +209,7 @@ void qemu_tcg_configure(QemuOpts *opts, E

[Qemu-devel] [PATCH v2 2/6] bsd-user: align use of mmap_lock to that of linux-user

2017-03-28 Thread Alex Bennée
The introduction of stricter mmap_lock checking in translate-all broke the BSD user build. The working mmap_lock functions were hidden behind CONFIG_USE_NPTL which is never defined. This patch brings them inline with linux-user. Despite the disapearence of the comment "We aren't threadsafe to star

Re: [Qemu-devel] [PATCH] virtio-blk: add DISCARD support to virtio-blk driver

2017-03-28 Thread Stefan Hajnoczi
On Tue, Mar 28, 2017 at 3:15 AM, Liu, Changpeng wrote: >> -Original Message- >> From: Stefan Hajnoczi [mailto:stefa...@gmail.com] >> Sent: Tuesday, March 28, 2017 4:20 AM >> To: Liu, Changpeng >> Cc: virtio-...@lists.oasis-open.org; >> virtualizat...@lists.linux-foundation.org; linux- >>

[Qemu-devel] [PULL 2/2] tests/virtio-9p-test: Don't call le*_to_cpus on fields of packed struct

2017-03-28 Thread Greg Kurz
From: Peter Maydell For a packed struct like 'P9Hdr' the fields within it may not be aligned as much as the natural alignment for their types. This means it is not valid to pass the address of such a field to a function like le32_to_cpus() which operate on uint32_t* and assume alignment. Doing t

[Qemu-devel] [PULL 0/2] 9pfs fixes for 2.9 2017-03-28

2017-03-28 Thread Greg Kurz
The following changes since commit eb06c9e2d3c8f026a206e8402b0ffa201060ec8e: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2017-03-27 17:34:50 +0100) are available in the git repository at: https://github.com/gkurz/qemu.git tags/for-upstream for you to fetc

[Qemu-devel] [PULL 1/2] 9pfs: fix file descriptor leak

2017-03-28 Thread Greg Kurz
From: Li Qiang The v9fs_create() and v9fs_lcreate() functions are used to create a file on the backend and to associate it to a fid. The fid shouldn't be already in-use, otherwise both functions may silently leak a file descriptor or allocated memory. The current code doesn't check that. This pa

Re: [Qemu-devel] [PULL 0/9] Misc fixes for QEMU 2.9.0-rc2

2017-03-28 Thread Peter Maydell
On 27 March 2017 at 17:16, Paolo Bonzini wrote: > The following changes since commit 08329701199449bde497570dcfdb9c86062baf20: > > qom: Fix regression with 'qom-type' (2017-03-23 17:59:40 +) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git tags/for-upstream

Re: [Qemu-devel] [PATCH v4 14/16] docs: add documentation for vfio-ccw

2017-03-28 Thread Dong Jia Shi
* Cornelia Huck [2017-03-28 10:16:23 +0200]: [...] > > > > @Conny, please correct me if my understanding is not right. > > No, it's fine. Thanks! > > FWIW: > https://virtualpenguins.blogspot.com/2017/02/channel-io-demystified.html > > (I plan to write more in the future.) That's a very good

[Qemu-devel] [PATCH v4 for-2.9 07/10] rbd: Clean up qemu_rbd_create()'s detour through QemuOpts

2017-03-28 Thread Markus Armbruster
The conversion from QDict to QemuOpts is pointless. Simply get the stuff straight from the QDict. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf --- block/rbd.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/block/rb

[Qemu-devel] [PATCH v4 for-2.9 03/10] rbd: Don't limit length of parameter values

2017-03-28 Thread Markus Armbruster
We laboriously enforce that parameter values are between one and some arbitrary limit in length. Only RBD_MAX_IMAGE_NAME_SIZE comes from librbd.h, and I'm not sure it applies. Where the other limits come from is unclear. Drop the length checking. The limits librbd actually imposes must be check

[Qemu-devel] [PATCH v4 for-2.9 05/10] rbd: Don't accept -drive driver=rbd, keyvalue-pairs=...

2017-03-28 Thread Markus Armbruster
The way we communicate extra key-value pairs from qemu_rbd_parse_filename() to qemu_rbd_open() exposes option parameter "keyvalue-pairs" on the command line. It's not wanted there. Hack: rename the parameter to "=keyvalue-pairs" to make it inaccessible. Signed-off-by: Markus Armbruster Reviewed

[Qemu-devel] [PATCH v4 for-2.9 04/10] rbd: Clean up after the previous commit

2017-03-28 Thread Markus Armbruster
This code in qemu_rbd_parse_filename() found_str = qemu_rbd_next_tok(p, '\0', &p); p = found_str; has no effect. Drop it, and simplify qemu_rbd_next_tok(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Max Reitz Reviewed-by: Jeff Cody --- block/rbd.c | 24 ++

[Qemu-devel] [PATCH v4 for-2.9 10/10] rbd: Fix bugs around -drive parameter "server"

2017-03-28 Thread Markus Armbruster
qemu_rbd_open() takes option parameters as a flattened QDict, with keys of the form server.%d.host, server.%d.port, where %d counts up from zero. qemu_rbd_array_opts() extracts these values as follows. First, it calls qdict_array_entries() to find the list's length. For each list element, it for

[Qemu-devel] [PATCH v4 for-2.9 00/10] rbd: Clean up API and code

2017-03-28 Thread Markus Armbruster
I really, really want to correct a few issues in external interfaces before while I can. Bonus: several minor bug fixes. Thanks to Jeff Cody for testing this series. v4: * PATCH 01,04-06 unchanged * PATCH 02 commit message fixed up [Jeff] * PATCH 03 commit message tweak [Jeff] * PATCH 07 fixed t

[Qemu-devel] [PATCH v4 for-2.9 06/10] rbd: Clean up runtime_opts, fix -drive to reject filename

2017-03-28 Thread Markus Armbruster
runtime_opts is used for three different purposes: * qemu_rbd_open() uses it to accept options it recognizes, such as "pool" and "image". Other .bdrv_open() methods do it similarly. * qemu_rbd_open() accepts additional list-valued options auth-supported and server, with the help of qemu_rbd_

[Qemu-devel] [PATCH v4 for-2.9 01/10] rbd: Reject -blockdev server.*.{numeric, to, ipv4, ipv6}

2017-03-28 Thread Markus Armbruster
We use InetSocketAddress in the QAPI schema. However, the code doesn't use inet_connect_saddr(), but formats "host" and "port" into a configuration string for rados_conf_set(). Thus, members "numeric", "to", "ipv4" and "ipv6" are silently ignored. Not nice. Example: -blockdev rbd,node-nam

[Qemu-devel] [PATCH v4 for-2.9 02/10] rbd: Fix to cleanly reject -drive without pool or image

2017-03-28 Thread Markus Armbruster
qemu_rbd_open() neglects to check pool and image are present. Missing image is caught by rbd_open(), but missing pool crashes. Reproducer: $ qemu-system-x86_64 -nodefaults -drive driver=rbd,id=rbd,image=i,... terminate called after throwing an instance of 'std::logic_error' what():

[Qemu-devel] [PATCH v4 for-2.9 09/10] rbd: Revert -blockdev parameter password-secret

2017-03-28 Thread Markus Armbruster
This reverts a part of commit 8a47e8e. We're having second thoughts on the QAPI schema (and thus the external interface), and haven't reached consensus, yet. Issues include: * BlockdevOptionsRbd member @password-secret isn't actually a password, it's a key generated by Ceph. * We're not sure

[Qemu-devel] [PATCH v4 for-2.9 08/10] rbd: Revert -blockdev and -drive parameter auth-supported

2017-03-28 Thread Markus Armbruster
This reverts half of commit 0a55679. We're having second thoughts on the QAPI schema (and thus the external interface), and haven't reached consensus, yet. Issues include: * The implementation uses deprecated rados_conf_set() key "auth_supported". No biggie. * The implementation makes -drive

[Qemu-devel] [RFC PATCH qemu 2/3] vfio-pci: Reorder group-to-container attaching

2017-03-28 Thread Alexey Kardashevskiy
At the moment VFIO PCI device initialization works as follows: vfio_realize vfio_get_group vfio_connect_container register memory listeners (1) update QEMU groups lists vfio_kvm_device_add_group Then (example f

[Qemu-devel] [RFC PATCH qemu 0/3] vfio-pci, spapr: Allow in-kernel acceleration

2017-03-28 Thread Alexey Kardashevskiy
This is my current working tree to support kernel's "powerpc/kvm/vfio: Enable in-kernel acceleration". Please comment. Thanks. Alexey Kardashevskiy (3): memory: Add get_fd() hook for IOMMU MR vfio-pci: Reorder group-to-container attaching vfio: Enable in-kernel acceleration via VFIO KVM d

[Qemu-devel] [RFC PATCH qemu 1/3] memory: Add get_fd() hook for IOMMU MR

2017-03-28 Thread Alexey Kardashevskiy
Signed-off-by: Alexey Kardashevskiy --- include/exec/memory.h | 2 ++ hw/ppc/spapr_iommu.c | 8 2 files changed, 10 insertions(+) diff --git a/include/exec/memory.h b/include/exec/memory.h index e39256ad03..925c10b35b 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -1

[Qemu-devel] [RFC PATCH qemu 3/3] vfio: Enable in-kernel acceleration via VFIO KVM device

2017-03-28 Thread Alexey Kardashevskiy
This enables in-kernel acceleration of TCE update requests via VFIO KVM device. Signed-off-by: Alexey Kardashevskiy --- include/hw/vfio/vfio-common.h | 1 + target/ppc/kvm_ppc.h | 6 ++ hw/ppc/spapr_iommu.c | 4 hw/vfio/common.c | 13 + hw/v

Re: [Qemu-devel] [PATCH v2 0/6] MTTCG fixes for rc1

2017-03-28 Thread Paolo Bonzini
On 28/03/2017 10:36, Alex Bennée wrote: > > Here is the current batch of fixes for MTTCG regressions for the next > release candidate. I've dropped the speculative atomic cputlb patch > and included 2 fixes to the console code. The first fixes the taking > of the BQL (which I missed) and the sec

Re: [Qemu-devel] [PATCH v2] qemu-ga: add guest-get-osinfo command

2017-03-28 Thread Marc-André Lureau
Hi On Tue, Mar 28, 2017 at 7:15 AM Vinzenz Feenstra wrote: > Eric, what you think of this below way, instead? > > > > > OK So how about something like this: > > > > {‘struct’: ‘GuestWindowsVersionInfo’, > > ‘data’: { > > ‘version’: ‘str’, > > ‘name’: ‘str’, > > } } > > > > {‘struc

[Qemu-devel] [RFC] migration/block:limit the time used for block migration

2017-03-28 Thread Lidong Chen
when migration with quick speed, mig_save_device_bulk invoke bdrv_is_allocated too frequently, and cause vnc reponse slowly. this patch limit the time used for bdrv_is_allocated. Signed-off-by: Lidong Chen --- migration/block.c | 39 +++ 1 file changed, 31 ins

Re: [Qemu-devel] [RFC] migration/block:limit the time used for block migration

2017-03-28 Thread 858585 jemmy
when migrate the vm with quick speed, i find vnc response slowly. the bug can be reproduce by this command: virsh migrate-setspeed 165cf436-312f-47e7-90f2-f8aa63f34893 900 virsh migrate --live 165cf436-312f-47e7-90f2-f8aa63f34893 --copy-storage-inc qemu+ssh://10.59.163.38/system and --copy-storag

Re: [Qemu-devel] [PATCH 1/5] virtio: Error object based virtio_error()

2017-03-28 Thread Greg Kurz
On Tue, 28 Mar 2017 10:24:21 +0200 Cornelia Huck wrote: > On Tue, 28 Mar 2017 10:14:09 +0200 > Greg Kurz wrote: > > > On Mon, 27 Mar 2017 21:20:56 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Mar 27, 2017 at 07:46:03PM +0200, Greg Kurz wrote: > > > > This introduces an Error ob

Re: [Qemu-devel] [PATCH v1] qga: Add 'guest-get-users' command

2017-03-28 Thread Marc-André Lureau
Hi On Tue, Mar 28, 2017 at 9:22 AM Vinzenz 'evilissimo' Feenstra < vfeen...@redhat.com> wrote: > From: Vinzenz Feenstra > > A command that will list all currenctly logged in users having running > processes. > > Examples: > > virsh # qemu-agent-command F25 '{ "execute": "guest-get-users" }' > {"

[Qemu-devel] [PATCH for-2.9 v2] tests/bios-tables-test: Don't pass addresses of packed struct fields

2017-03-28 Thread Peter Maydell
Passing the address of a field in a packed struct to a function that expects a pointer to normally aligned data will result in a SEGBUS on architectures like SPARC that have strict alignment requirements. Pass addresses of local variables rather than addresses of packed structure fields to glib fu

Re: [Qemu-devel] [PULL 0/2] 9pfs fixes for 2.9 2017-03-28

2017-03-28 Thread Peter Maydell
On 28 March 2017 at 09:46, Greg Kurz wrote: > The following changes since commit eb06c9e2d3c8f026a206e8402b0ffa201060ec8e: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2017-03-27 17:34:50 +0100) > > are available in the git repository at: > > https://gi

Re: [Qemu-devel] [PATCH v3] scripts/qmp: python3 support for qmp.py

2017-03-28 Thread Stefan Hajnoczi
On Sat, Mar 25, 2017 at 04:56:41PM +0300, Joannah Nanjekye wrote: > From: nanjekyejoannah > > The patch provides python 3 support for one of the scripts in scripts/qmp > that is to say qmp.py. This is not a port to python 3 but rather the patch > ensures that the script runs fine for both pyth

Re: [Qemu-devel] [PATCH v2 0/6] MTTCG fixes for rc1

2017-03-28 Thread Gerd Hoffmann
Hi, > Gerd, > > Do you want to take the console patches via your tree or have me > include it in a pull request? Just include them in your pull req. Reviewed-by: Gerd Hoffmann cheers, Gerd

Re: [Qemu-devel] [RFC] migration/block:limit the time used for block migration

2017-03-28 Thread Juan Quintela
Lidong Chen wrote: > when migration with quick speed, mig_save_device_bulk invoke > bdrv_is_allocated too frequently, and cause vnc reponse slowly. > this patch limit the time used for bdrv_is_allocated. > > Signed-off-by: Lidong Chen > --- > migration/block.c | 39 ++

Re: [Qemu-devel] [PATCH for-2.10 20/23] numa: use possible_cpus for not mapped CPUs check

2017-03-28 Thread David Gibson
On Wed, Mar 22, 2017 at 02:32:45PM +0100, Igor Mammedov wrote: > and remove corresponding part in numa.c that uses > node_cpu bitmaps. > > Signed-off-by: Igor Mammedov Reviewed-by: David Gibson > --- > It's one more less user of node_cpu bitmpas, following > commit will remove the last user al

Re: [Qemu-devel] [PATCH for-2.10 21/23] numa: remove node_cpu bitmaps as they are no longer used

2017-03-28 Thread David Gibson
On Wed, Mar 22, 2017 at 02:32:46PM +0100, Igor Mammedov wrote: > Postfactum "CPU(s) present in multiple NUMA nodes" check > was the last user of node_cpu bitmaps, but it's not need > as machine_set_cpu_numa_node() does the similar check at > the time mapping is set for cpus (i.e. when -numa cpus= >

Re: [Qemu-devel] [PATCH for-2.10 22/23] numa: add '-numa cpu, ...' option for property based node mapping

2017-03-28 Thread David Gibson
On Wed, Mar 22, 2017 at 02:32:47PM +0100, Igor Mammedov wrote: > legacy cpu to node mapping is using cpu index values to map > VCPU to node with help of '-numa node,nodeid=node,cpus=x[-y]' > option. However cpu index is internal concept and QEMU users > have to guess /reimplement qemu's logic/ to m

Re: [Qemu-devel] GSoC 2017 Proposal: TCG performance enhancements

2017-03-28 Thread Stefan Hajnoczi
On Mon, Mar 27, 2017 at 11:09:23PM -0400, Pranith Kumar wrote: > On Mon, Mar 27, 2017 at 11:03 PM, Pranith Kumar wrote: > > > > > If you think the project makes sense, I will add it to the GSoC wiki > > so that others can also apply for it. Please let me know if you are > > interested in mentorin

[Qemu-devel] [PULL for-2.9 0/1] Block patches

2017-03-28 Thread Stefan Hajnoczi
The following changes since commit eb06c9e2d3c8f026a206e8402b0ffa201060ec8e: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2017-03-27 17:34:50 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for you

Re: [Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate

2017-03-28 Thread Stefan Hajnoczi
On Mon, Mar 27, 2017 at 05:38:08PM +0300, Denis V. Lunev wrote: > Parallels driver should not call bdrv_truncate if the image was opened > in the read-only mode. Without the patch > qemu-img check harddisk.hds > asserts with > bdrv_truncate: Assertion `child->perm & BLK_PERM_RESIZE' failed.

[Qemu-devel] [PULL for-2.9 1/1] parallels: wrong call to bdrv_truncate

2017-03-28 Thread Stefan Hajnoczi
From: "Denis V. Lunev" Parallels driver should not call bdrv_truncate if the image was opened in the read-only mode. Without the patch qemu-img check harddisk.hds asserts with bdrv_truncate: Assertion `child->perm & BLK_PERM_RESIZE' failed. Parameters used on the write path are not neede

Re: [Qemu-devel] [PATCH] trace: fix tcg tracing build breakage

2017-03-28 Thread Stefan Hajnoczi
On Mon, Mar 27, 2017 at 02:17:18PM +0100, Stefan Hajnoczi wrote: > Commit 0ab8ed18a6fe98bfc82705b0f041fbf2a8ca5b60 ("trace: switch to > modular code generation for sub-directories") forgot to convert "tcg" > trace events to the modular code generation approach where each > sub-directory has its own

Re: [Qemu-devel] [PATCH 1/5] virtio: Error object based virtio_error()

2017-03-28 Thread Cornelia Huck
On Tue, 28 Mar 2017 11:34:15 +0200 Greg Kurz wrote: > On Tue, 28 Mar 2017 10:24:21 +0200 > Cornelia Huck wrote: > > > On Tue, 28 Mar 2017 10:14:09 +0200 > > Greg Kurz wrote: > > > > > On Mon, 27 Mar 2017 21:20:56 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Mon, Mar 27, 2017 a

Re: [Qemu-devel] packed structures and unaligned accesses (sparc)

2017-03-28 Thread John Paul Adrian Glaubitz
On 03/27/2017 07:34 PM, Peter Maydell wrote: > That all makes sense in isolation, but shouldn't something have > at least warned that "&h.size" isn't actually a uint32_t* in > the sense of being something you can validly pass to a > function that takes a uint32_t* ? It turns out that clang actuall

Re: [Qemu-devel] packed structures and unaligned accesses (sparc)

2017-03-28 Thread Peter Maydell
On 28 March 2017 at 11:19, John Paul Adrian Glaubitz wrote: > On 03/27/2017 07:34 PM, Peter Maydell wrote: >> That all makes sense in isolation, but shouldn't something have >> at least warned that "&h.size" isn't actually a uint32_t* in >> the sense of being something you can validly pass to a >>

Re: [Qemu-devel] [PATCH for-2.9 v2 1/2] i386: Replace uint32_t* with FeatureWord on feature getter/setter

2017-03-28 Thread Igor Mammedov
On Mon, 27 Mar 2017 11:48:14 -0300 Eduardo Habkost wrote: > Instead of passing a pointer to the feature property getter and > setter functions, pass a FeatureWord enum so they can perform > other actions related to the feature flag. > > This will be used to add a new "user_features" field to kee

Re: [Qemu-devel] [PATCH for-2.9 v2 2/2] i386: Don't override -cpu options on -cpu host/max

2017-03-28 Thread Igor Mammedov
On Mon, 27 Mar 2017 11:48:15 -0300 Eduardo Habkost wrote: > The existing code for "host" and "max" CPU models overrides every > single feature in the CPU object at realize time, even the ones > that were explicitly enabled or disabled by the user using > "feat=on" or "feat=off", while features se

Re: [Qemu-devel] [PULL for-2.9 0/1] Block patches

2017-03-28 Thread Peter Maydell
On 28 March 2017 at 11:07, Stefan Hajnoczi wrote: > The following changes since commit eb06c9e2d3c8f026a206e8402b0ffa201060ec8e: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2017-03-27 17:34:50 +0100) > > are available in the git repository at: > > git:

[Qemu-devel] [Bug 1258626] Re: Curses Keyboard Broken On OS X

2017-03-28 Thread James Clarke
Yes, I can still reproduce this with 2.8.0, and it gives exactly the same output. ** Changed in: qemu Status: Expired => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1258626 Title: Cur

Re: [Qemu-devel] [PATCH 1/2] migration: Disable hotplug/unplug during migration

2017-03-28 Thread Juan Quintela
Igor Mammedov wrote: > On Thu, 23 Mar 2017 21:50:24 +0100 > Juan Quintela wrote: > >> Until we have reviewed what can/can't be hotplug during migration, >> disable it. We can enable it later for the things that we know that >> work. For instance, memory hotplug during postcopy don't work >> cur

Re: [Qemu-devel] [PATCH 02/51] ram: rename block_name to rbname

2017-03-28 Thread Juan Quintela
Eric Blake wrote: > On 03/23/2017 03:44 PM, Juan Quintela wrote: >> So all places are consisten on the nambing of a block name parameter. > > s/consisten/consistent/ > s/nambing/naming/ Done, thanks.

Re: [Qemu-devel] [PATCH for-2.10 05/23] numa: move source of default CPUs to NUMA node mapping into boards

2017-03-28 Thread Igor Mammedov
On Tue, 28 Mar 2017 15:19:20 +1100 David Gibson wrote: > On Wed, Mar 22, 2017 at 02:32:30PM +0100, Igor Mammedov wrote: > > Originally CPU threads were by default assigned in > > round-robin fashion. However it was causing issues in > > guest since CPU threads from the same socket/core could > >

Re: [Qemu-devel] [PATCH 3/4] savevm: fix savevm after migration

2017-03-28 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 25.02.2017 um 20:31 hat Vladimir Sementsov-Ogievskiy geschrieben: > > After migration all drives are inactive and savevm will fail with > > > > qemu-kvm: block/io.c:1406: bdrv_co_do_pwritev: > >Assertion `!(bs->open_flags & 0x0800)' failed. > > > >

Re: [Qemu-devel] [PATCH 05/51] ram: Move bitmap_sync_count into RAMState

2017-03-28 Thread Juan Quintela
Peter Xu wrote: > On Thu, Mar 23, 2017 at 09:44:58PM +0100, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> Reviewed-by: Dr. David Alan Gilbert > > Reviewed-by: Peter Xu > > (I see that we have MigrationStats.dirty_pages_rate which looks > similar to this one. Maybe one day we can merg

[Qemu-devel] [PATCH for-2.9] configure: Mark SPARC as supported

2017-03-28 Thread Peter Maydell
Thanks to John Paul Adrian Glaubitz and the Debian Project, we now have access to a SPARC Linux system we can use for build testing. Move SPARC back into the "supported" list. Signed-off-by: Peter Maydell --- We should also at least apply the TCG fixes: http://patchwork.ozlabs.org/patch/743890/

Re: [Qemu-devel] [PATCH 06/51] ram: Move start time into RAMState

2017-03-28 Thread Juan Quintela
Peter Xu wrote: > On Thu, Mar 23, 2017 at 09:44:59PM +0100, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> Reviewed-by: Dr. David Alan Gilbert >> --- >> migration/ram.c | 20 +++- >> 1 file changed, 11 insertions(+), 9 deletions(-) >> >> diff --git a/migration/ram.c b/

Re: [Qemu-devel] [PATCH 3/4] savevm: fix savevm after migration

2017-03-28 Thread Kevin Wolf
Am 28.03.2017 um 12:55 hat Dr. David Alan Gilbert geschrieben: > * Kevin Wolf (kw...@redhat.com) wrote: > > Am 25.02.2017 um 20:31 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > After migration all drives are inactive and savevm will fail with > > > > > > qemu-kvm: block/io.c:1406: bdrv_co_do

Re: [Qemu-devel] [PATCH for-2.10 22/23] numa: add '-numa cpu, ...' option for property based node mapping

2017-03-28 Thread Igor Mammedov
On Tue, 28 Mar 2017 16:16:02 +1100 David Gibson wrote: > On Wed, Mar 22, 2017 at 02:32:47PM +0100, Igor Mammedov wrote: > > legacy cpu to node mapping is using cpu index values to map > > VCPU to node with help of '-numa node,nodeid=node,cpus=x[-y]' > > option. However cpu index is internal conce

[Qemu-devel] [PULL 3/6] ui/console: ensure do_safe_dpy_refresh holds BQL

2017-03-28 Thread Alex Bennée
I missed the fact that when an exclusive work item runs it drops the BQL to ensure all no vCPUs are stuck waiting for it, hence causing a deadlock. However the actual helper needs to take the BQL especially as we'll be messing with device emulation bits during the update which all assume BQL is hel

[Qemu-devel] [PULL 2/6] bsd-user: align use of mmap_lock to that of linux-user

2017-03-28 Thread Alex Bennée
The introduction of stricter mmap_lock checking in translate-all broke the BSD user build. The working mmap_lock functions were hidden behind CONFIG_USE_NPTL which is never defined. This patch brings them inline with linux-user. Despite the disapearence of the comment "We aren't threadsafe to star

[Qemu-devel] [PULL 1/6] user-exec: handle synchronous signals from QEMU gracefully

2017-03-28 Thread Alex Bennée
When "tcg: enable thread-per-vCPU" (commit 3725794) was merged the lifetime of current_cpu was changed. Previously a broken linux-user call might abort() which can eventually escalate into a SIGSEGV which would then crash qemu as it attempted to deref a NULL current_cpu. After commit 3725794 it wou

[Qemu-devel] [PULL 0/6] MTTCG fixes for rc2

2017-03-28 Thread Alex Bennée
The following changes since commit ea2afcf5b6727a577cf561fd8fe0d8c397ecc927: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2017-03-24 14:14:18 +) are available in the git repository at: https://github.com/stsquad/qemu.git tags/pull-mttcg-fixups-

[Qemu-devel] [PULL 6/6] replay/replay.c: bump REPLAY_VERSION

2017-03-28 Thread Alex Bennée
A previous commit (3d4d16f4) added support for audio record/playback. However this breaks the logfile ABI due to the re-ordering of the ReplayEvents enum. The REPLAY_VERSION check is meant to prevent you from using old log files in newer QEMUs but this is currently broken. Signed-off-by: Alex Benn

  1   2   3   4   >