Jeff Cody <jc...@redhat.com> writes: > On Mon, Mar 27, 2017 at 03:26:27PM +0200, Markus Armbruster wrote: >> We laboriously enforce parameter values are between one and some > > s/are/that are/ > > or maybe just s/are//
What about: We laboriously enforce that parameter values are between one and some >> arbitrary limit in length. Only RBD_MAX_IMAGE_NAME_SIZE comes from >> librbd.h, and I'm not sure it applies. Where the other limits come >> from is unclear. >> >> Drop the length checking. The limits librbd actually imposes must be >> checked by librbd anyway. >> >> There's one minor complication: BDRVRBDState member name is a >> fixed-size array. Depends on the length limit. Make it a pointer to >> a dynamically allocated string. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> Reviewed-by: Eric Blake <ebl...@redhat.com> > > Reviewed-by: Jeff Cody <jc...@redhat.com> Thanks!
