We set it right above this one. No need to set it twice.
CC: Juan Quintela
CC: "Dr. David Alan Gilbert"
Signed-off-by: Peter Xu
---
migration/migration.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index 54060f7..f9f4d98 100644
--- a/migrati
Mostly small touch-ups, the last one looks like a cpu throttle bug on
time slice calculation (or I missed anything?). Anyway, please review,
thanks.
Peter Xu (5):
migration: set current_active_state once
migration: rename max_size to threshold_size
hmp: info migrate_capability format tunes
Dump the info in a single line is hard to read. Do it one per line.
Also, the first "capabilities:" didn't help much. Let's remove it.
CC: "Dr. David Alan Gilbert"
Signed-off-by: Peter Xu
---
hmp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hmp.c b/hmp.c
index edb897
Do the same (one per line) to the parameter list.
CC: "Dr. David Alan Gilbert"
Signed-off-by: Peter Xu
---
hmp.c | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/hmp.c b/hmp.c
index 95eef8c..b33e39e 100644
--- a/hmp.c
+++ b/hmp.c
@@ -282,46 +282,44 @@
In migration codes (especially in migration_thread()), max_size is used
in many place for the threshold value that we will start to do the final
flush and jump to the next stage to dump the whole rest things to
destination. However its name is confusing to first readers. Let's
rename it to "thresho
From f6f0ee6831488bef7af841cb86f3d85a04848fe5 Mon Sep 17 00:00:00 2001
From: herongguang
Date: Mon, 27 Mar 2017 15:08:59 +0800
Subject: [PATCH] KVM: pci-assign: do not map smm memory slot pages
in vt-d page table
or VM memory are not put thus leaked in kvm_iommu_unmap_memslots() when
destroy VM
IIUC the throttle idea is that: we split a CPU_THROTTLE_TIMESLICE_NS
time slice into two parts - one for vcpu, one for throttle thread (which
will suspend the thread by a sleep). However current algorithm on
calculating the working piece and sleeping piece is strange.
Assume a 99% throttle, what w
On Thu, Mar 23, 2017 at 09:44:57PM +0100, Juan Quintela wrote:
> We need to add a parameter to several functions to make this work.
>
> Signed-off-by: Juan Quintela
> Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
-- peterx
On Thu, Mar 23, 2017 at 09:44:58PM +0100, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
> Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
(I see that we have MigrationStats.dirty_pages_rate which looks
similar to this one. Maybe one day we can merge these two?)
> ---
> migra
On Mon, Mar 27, 2017 at 03:21:28PM +0800, Peter Xu wrote:
> IIUC the throttle idea is that: we split a CPU_THROTTLE_TIMESLICE_NS
> time slice into two parts - one for vcpu, one for throttle thread (which
> will suspend the thread by a sleep). However current algorithm on
> calculating the working p
Instead of trying to guess the Xen version to use by compiling various
test programs first just ask the system via pkg-config. Only if it
can't return the version fall back to the test program scheme.
If configure is being called with dedicated flags for the Xen libraries
use those instead of the
On Thu, Mar 23, 2017 at 09:44:59PM +0100, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
> Reviewed-by: Dr. David Alan Gilbert
> ---
> migration/ram.c | 20 +++-
> 1 file changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index f8
On 24.03.2017 18:59, Markus Armbruster wrote:
> Peter Maydell writes:
>
>> On 24 March 2017 at 16:58, Markus Armbruster wrote:
>>> "Sysbus" isn't a bus. In qdev's original design, every device had to
>>> plug into a bus, period. The ones that really didn't were made to plug
>>> into "sysbus".
> -Original Message-
[snip]
>
> To sum it up we have to care about the following scenarios:
>
> a) Xen in-tree build, Xen >= 4.9
> b) Xen in-tree build, Xen < 4.9
> c) build out-of-Xen-tree
>
> combined with any of:
>
> 1) no Xen installed on build machine
> 2) Xen >= 4.9 installed
> 3)
On Thu, Mar 23, 2017 at 09:45:00PM +0100, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
> Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
-- peterx
On 24.03.2017 23:10, John Snow wrote:
>
>
> On 03/08/2017 03:26 AM, Thomas Huth wrote:
>>
>> Hi everybody,
>>
>> what will be the next version of QEMU after 2.9? Will we go for a 2.10
>> (as I've seen it mentioned a couple of times on the mailing list
>> already), or do we dare to switch to 3.0
On Thu, Mar 23, 2017 at 09:45:01PM +0100, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
> Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
-- peterx
Currently virtio-blk driver does not provide discard feature flag, so the
filesystems which built on top of the block device will not send discard
command. This is okay for HDD backend, but it will impact the performance
for SSD backend.
Add a feature flag VIRTIO_BLK_F_DISCARD and command VIRTIO_B
> -Original Message-
> From: Qemu-devel [mailto:qemu-devel-bounces+yi.l.liu=intel@nongnu.org] On
> Behalf Of Peter Xu
> Sent: Tuesday, February 7, 2017 4:28 PM
> To: qemu-devel@nongnu.org
> Cc: Lan, Tianyu ; Tian, Kevin ;
> m...@redhat.com; jan.kis...@siemens.com; jasow...@redhat.com;
>
On Fri, 24 Mar 2017 16:23:18 -0300
Eduardo Habkost wrote:
> On Fri, Mar 24, 2017 at 05:08:56PM +, Peter Maydell wrote:
> > On 24 March 2017 at 16:58, Markus Armbruster wrote:
> > > "Sysbus" isn't a bus. In qdev's original design, every device had to
> > > plug into a bus, period. The ones
slirp/slirp.c: In function 'get_dns_addr_resolv_conf':
slirp/slirp.c:202:29: error: initialization discards 'const' qualifier from
pointer target type [-Werror=discarded-qualifiers]
char *res = inet_ntop(af, tmp_addr, s, sizeof(s));
^
slirp/sli
On 27 March 2017 at 09:44, Cornelia Huck wrote:
> ISTR some surprises that reset (or some other) callbacks were not
> called as expected if there wasn't a sysbus device among the ancestors.
> Don't know if that's still true.
Yes -- if you're a sysbus device then your reset method is
called. If yo
> -Original Message-
> From: Juergen Gross [mailto:jgr...@suse.com]
> Sent: 27 March 2017 08:43
> To: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org
> Cc: Anthony Perard ; kra...@redhat.com;
> sstabell...@kernel.org; Paul Durrant ; Juergen
> Gross
> Subject: [PATCH v2] configure: us
On Mon, Mar 27, 2017 at 08:35:05AM +, Liu, Yi L wrote:
> > -Original Message-
> > From: Qemu-devel [mailto:qemu-devel-bounces+yi.l.liu=intel@nongnu.org]
> > On
> > Behalf Of Peter Xu
> > Sent: Tuesday, February 7, 2017 4:28 PM
> > To: qemu-devel@nongnu.org
> > Cc: Lan, Tianyu ; Tia
On 27/03/17 11:07, Paul Durrant wrote:
>> -Original Message-
>> From: Juergen Gross [mailto:jgr...@suse.com]
>> Sent: 27 March 2017 08:43
>> To: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org
>> Cc: Anthony Perard ; kra...@redhat.com;
>> sstabell...@kernel.org; Paul Durrant ; Juergen
> -Original Message-
> From: Peter Xu [mailto:pet...@redhat.com]
> Sent: Monday, March 27, 2017 5:12 PM
> To: Liu, Yi L
> Cc: alex.william...@redhat.com; Lan, Tianyu ; Tian,
> Kevin
> ; m...@redhat.com; jan.kis...@siemens.com;
> jasow...@redhat.com; bd.a...@gmail.com; David Gibson
> ; qem
On Thu, Mar 23, 2017 at 09:45:04PM +0100, Juan Quintela wrote:
> Once there rename it to its actual meaning, zero_pages.
>
> Signed-off-by: Juan Quintela
> Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
Will post a question below though (not directly related to this patch
but conte
* Paolo Bonzini (bonz...@gnu.org) wrote:
>
>
> On 20/03/2017 18:16, Paolo Bonzini wrote:
> >
> >
> > On 20/03/2017 18:01, Markus Armbruster wrote:
> >> Peter Maydell writes:
> >>
> >>> On 20 March 2017 at 16:29, Markus Armbruster wrote:
> Peter Maydell writes:
> > I have some commen
On Thu, Mar 23, 2017 at 09:45:05PM +0100, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
> Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
-- peterx
On Thu, Mar 23, 2017 at 09:45:06PM +0100, Juan Quintela wrote:
> For compatibility, we need to still send a value, but just specify it
> and comment the fact.
>
> Signed-off-by: Juan Quintela
> Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
-- peterx
> -Original Message-
> From: Juergen Gross [mailto:jgr...@suse.com]
> Sent: 27 March 2017 10:15
> To: Paul Durrant ; qemu-devel@nongnu.org; xen-
> de...@lists.xenproject.org
> Cc: Anthony Perard ; kra...@redhat.com;
> sstabell...@kernel.org
> Subject: Re: [PATCH v2] configure: use pkg-confi
From: Vinzenz Feenstra
Retrieving the guest OS fully qualified domain name (FQDN) is a very
useful feature for virtual management systems. This information can help
to have more user friendly VM access details, instead of an IP there
would be the FQDN. Also the FQDN reported can be used to have a
> -Original Message-
[snip]
>
> This is OK but the file is growing too entangled. What do you think of
> the following, which moves the if CONFIG_XEN_CTRL_INTERFACE_VERSION
> <
> 40701 at the top? This way we don't have to add yet another ifdef.
>
Yes, this looks better and appears to DT
On Thu, Mar 23, 2017 at 09:45:07PM +0100, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
> Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
-- peterx
Hi Peter,
On 13/03/2017 19:03, Peter Maydell wrote:
> On 6 March 2017 at 12:48, Eric Auger wrote:
>> We change the restoration priority of both the GICv3 and ITS. The
>> GICv3 must be restored before the ITS and the ITS needs to be restored
>> before PCIe devices since it translates their MSI tran
This series allows ITS save/restore and migration use cases.
It relies on not upstreamed kernel series [1].
ITS tables are flushed into guest RAM on VM stop while registers
are save on pre_save() callback. Tables and registers are restored
on ITS post_load().
That work was tested on Cavium Thunde
This is a linux header update against 4.11-rc3 plus the non
upstreamed ITS migration series.
https://github.com/eauger/linux/tree/v4.11-rc3-its-mig-v4
It aims at enhancing the KVM user API with vITS save/restore
capability. This consists in two new groups for the
ARM_VGIC_ITS KVM device, named: K
We change the restoration priority of both the GICv3 and ITS. The
GICv3 must be restored before the ITS and the ITS needs to be restored
before PCIe devices since it translates their MSI transactions.
Signed-off-by: Eric Auger
---
v2 -> v3:
- reword migration blocker message
- remove unmigratabl
We need to handle both registers and ITS tables. While
register handling is standard, ITS table handling is more
challenging since the kernel API is devised so that the
tables are flushed into guest RAM and not in vmstate buffers.
Flushing the ITS tables on device pre_save() is too late
since the
On So, 2017-03-26 at 11:53 +0200, Javier Celaya wrote:
> The evdev devices in input-linux.c are read in blocks of one whole
> event. If there are not enough bytes available, they are discarded,
> instead of being kept for the next read operation. This results in
> lost events, of even non-working d
On Thu, Mar 23, 2017 at 9:51 PM, Vinzenz 'evilissimo' Feenstra <
vfeen...@redhat.com> wrote:
> From: Vinzenz Feenstra
>
> Retrieving the guest OS fully qualified domain name (FQDN) is a very
> useful feature for virtual management systems. This information can help
> to have more user friendly VM
On Thu, Mar 23, 2017 at 09:45:09PM +0100, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
Another comment not directly related to this patch...
> ---
> migration/ram.c | 12 +++-
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/migration/ra
On Thu, Mar 23, 2017 at 09:45:10PM +0100, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
-- peterx
On 03/26/2017 02:52 AM, Pranith Kumar wrote:
Hello,
With MTTCG code now merged in mainline, I tried to see if we are able to run
x86 SMP guests on ARM64 hosts. For this I tried running a windows XP guest on
a dragonboard 410c which has 1GB RAM. Since x86 has a strong memory model
whereas ARM64 i
On Mon, Mar 27, 2017 at 03:49:13PM +0530, Tejaswini wrote:
Thanks for the patch!
Please CC the maintainers of target/i386/helper.c:
$ scripts/get_maintainer.pl -f target/i386/helper.c
Paolo Bonzini (maintainer:X86)
Richard Henderson (maintainer:X86)
Eduardo Habkost (maintainer:X86)
P
On Thu, Mar 23, 2017 at 09:45:11PM +0100, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
-- peterx
On Thu, Mar 23, 2017 at 09:45:12PM +0100, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
-- peterx
On Thu, Mar 23, 2017 at 09:45:13PM +0100, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
-- peterx
On Thu, Mar 23, 2017 at 09:45:14PM +0100, Juan Quintela wrote:
> Once there, remove the now unused AccountingInfo struct and var.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
-- peterx
On Fri, 24 Mar 2017 17:36:45 -0300
Eduardo Habkost wrote:
> The existing code for "host" and "max" CPU models overrides every
> single feature in the CPU object at realize time, even the ones
> that were explicitly enabled or disabled by the user using
> "feat=on" or "feat=off", while features se
On Mon, Mar 27, 2017 at 04:01:02PM +0530, Tejaswini wrote:
> From: Tejaswini Poluri
Please shorten the subject line: "[PATCH] hw/sd: simplify sd_init() prototype"
> @@ -573,16 +573,19 @@ SDState *sd_init(BlockBackend *blk, bool is_spi)
> qdev_prop_set_drive(dev, "drive", blk, &err);
>
Hello Samuel,
I tested your patch and solved my problem. Thank you.
My version: qemu-kvm-2.7.1-4.fc25.x86_64 + your patch.
Original qemu-kvm-2.7.1-4.fc25.x86_64 didn't work.
Cole, thanks for reporting. Consider applying this to Fedora package.
I am not a member of qemu-devel, so this mail will
> On Mar 27, 2017, at 12:44 PM, Sameeh Jubran wrote:
>
>
>
> On Thu, Mar 23, 2017 at 9:51 PM, Vinzenz 'evilissimo' Feenstra
> mailto:vfeen...@redhat.com>> wrote:
> From: Vinzenz Feenstra mailto:vfeen...@redhat.com>>
>
> Retrieving the guest OS fully qualified domain name (FQDN) is a very
> u
Hi
Javi
2017-03-27 12:11 GMT+02:00 Gerd Hoffmann :
> On So, 2017-03-26 at 11:53 +0200, Javier Celaya wrote:
> > The evdev devices in input-linux.c are read in blocks of one whole
> > event. If there are not enough bytes available, they are discarded,
> > instead of being kept for the next read o
On 25/03/2017 17:52, Pranith Kumar wrote:
> * Implement an LRU translation block code cache.
>
> In the current TCG design, when the translation cache fills up, we flush all
> the translated blocks (TBs) to free up space. We can improve this situation
> by not flushing the TBs that were re
On 28/03/2017 10:39, Changpeng Liu wrote:
> + if (virtio_has_feature(vdev, VIRTIO_BLK_F_DISCARD)) {
> + q->limits.discard_zeroes_data = 0;
Maybe you could use another feature bit to populate discard_zeroes_data.
Paolo
> + q->limits.discard_alignment = blk_size;
> +
On Wed, Mar 08, 2017 at 06:46:13PM +0100, Auger Eric wrote:
> Hi,
> On 22/08/2016 18:17, Prem Mallappa wrote:
> > v1 -> v2:
> > - Adopted review comments from Eric Auger
> > - Make SMMU_DPRINTF to internally call qemu_log
> > (since translation requests are too many,
On 27/03/2017 09:21, Herongguang (Stephen) wrote:
> From f6f0ee6831488bef7af841cb86f3d85a04848fe5 Mon Sep 17 00:00:00 2001
> From: herongguang
> Date: Mon, 27 Mar 2017 15:08:59 +0800
> Subject: [PATCH] KVM: pci-assign: do not map smm memory slot pages
> in vt-d page table
>
> or VM memory are
Alex Bennée writes:
> Nikunj A Dadhania writes:
>
>> Richard Henderson writes:
>>
>>> On 09/12/2016 06:47 AM, Alex Bennée wrote:
> > +/* Notice an IO access, or a notdirty page. */
> > +if (unlikely(tlb_addr & ~TARGET_PAGE_MASK)) {
> > +/* There's really nothing tha
On Mon, Mar 27, 2017 at 10:06:09AM +0200, Thomas Huth wrote:
> On 24.03.2017 23:10, John Snow wrote:
> >
> >
> > On 03/08/2017 03:26 AM, Thomas Huth wrote:
> >>
> >> Hi everybody,
> >>
> >> what will be the next version of QEMU after 2.9? Will we go for a 2.10
> >> (as I've seen it mentioned a c
On Fri, Mar 24, 2017 at 02:42:47PM -0500, Brijesh Singh wrote:
>
> On 03/24/2017 10:40 AM, Stefan Hajnoczi wrote:
>
> >
> > Having one security policy doesn't make sense to me. As mentioned,
> > there are many different areas of QEMU that have security relevant
> > configuration. They are all
Hi Edgar,
removing Prem's address which is not valid anymore
On 27/03/2017 13:44, Edgar E. Iglesias wrote:
> On Wed, Mar 08, 2017 at 06:46:13PM +0100, Auger Eric wrote:
>> Hi,
>> On 22/08/2016 18:17, Prem Mallappa wrote:
>>> v1 -> v2:
>>> - Adopted review comments from Eric Auger
>>>
On 27/03/2017 09:21, Herongguang (Stephen) wrote:
> From f6f0ee6831488bef7af841cb86f3d85a04848fe5 Mon Sep 17 00:00:00 2001
> From: herongguang
> Date: Mon, 27 Mar 2017 15:08:59 +0800
> Subject: [PATCH] KVM: pci-assign: do not map smm memory slot pages
> in vt-d page table
>
> or VM memory are
On Mon, Mar 27, 2017 at 02:18:56PM +0200, Auger Eric wrote:
> Hi Edgar,
>
> removing Prem's address which is not valid anymore
>
> On 27/03/2017 13:44, Edgar E. Iglesias wrote:
> > On Wed, Mar 08, 2017 at 06:46:13PM +0100, Auger Eric wrote:
> >> Hi,
> >> On 22/08/2016 18:17, Prem Mallappa wrote:
Signed-off-by: Stefan Hajnoczi
---
block/nbd-client.h | 2 --
block/nbd.c| 2 --
2 files changed, 4 deletions(-)
diff --git a/block/nbd-client.h b/block/nbd-client.h
index 8cdfc92..891ba44 100644
--- a/block/nbd-client.h
+++ b/block/nbd-client.h
@@ -30,8 +30,6 @@ typedef struct NBDClient
On Fri, Mar 24, 2017 at 06:48:44PM +0100, Kevin Wolf wrote:
> Am 24.03.2017 um 16:47 hat Stefan Hajnoczi geschrieben:
> > On Thu, Mar 23, 2017 at 05:48:48PM +0100, Markus Armbruster wrote:
> > > BlockdevOptionsNbd has a member SocketAddress, and nbd_config() doesn't
> > > restrict variants. Thus,
On 27/03/2017 14:32, Stefan Hajnoczi wrote:
> Signed-off-by: Stefan Hajnoczi
> ---
> block/nbd-client.h | 2 --
> block/nbd.c| 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/block/nbd-client.h b/block/nbd-client.h
> index 8cdfc92..891ba44 100644
> --- a/block/nbd-client.h
> +
On 24/03/17 18:37, Stefano Stabellini wrote:
> On Fri, 24 Mar 2017, Juergen Gross wrote:
>> On 23/03/17 19:22, Stefano Stabellini wrote:
>>> On Thu, 23 Mar 2017, Paolo Bonzini wrote:
On 23/03/2017 14:55, Juergen Gross wrote:
> On 23/03/17 14:00, Greg Kurz wrote:
>> On Mon, 20 Mar 2017
On 27 March 2017 at 13:01, Stefan Hajnoczi wrote:
> It would be nice to get rid of the legacy -net option in 3.0.0. I have
> added it and included pointers to loose ends. I think this is doable
> but will require some time to achieve.
What's the syntax for using -netdev with embedded network
de
On 27.03.2017 14:01, Stefan Hajnoczi wrote:
> On Mon, Mar 27, 2017 at 10:06:09AM +0200, Thomas Huth wrote:
>> On 24.03.2017 23:10, John Snow wrote:
>>>
>>>
>>> On 03/08/2017 03:26 AM, Thomas Huth wrote:
Hi everybody,
what will be the next version of QEMU after 2.9? Will we go f
On Mon, Mar 27, 2017 at 8:22 PM, Paolo Bonzini wrote:
>
>
> On 27/03/2017 09:21, Herongguang (Stephen) wrote:
>> From f6f0ee6831488bef7af841cb86f3d85a04848fe5 Mon Sep 17 00:00:00 2001
>> From: herongguang
>> Date: Mon, 27 Mar 2017 15:08:59 +0800
>> Subject: [PATCH] KVM: pci-assign: do not map smm
On 27.03.2017 14:56, Thomas Huth wrote:
> On 27.03.2017 14:01, Stefan Hajnoczi wrote:
>> On Mon, Mar 27, 2017 at 10:06:09AM +0200, Thomas Huth wrote:
>>> On 24.03.2017 23:10, John Snow wrote:
On 03/08/2017 03:26 AM, Thomas Huth wrote:
>
> Hi everybody,
>
> what will
On 24 March 2017 at 17:24, Peter Maydell wrote:
> So far I have found that we seem to be mishandling 32-bit guest
> load/stores, which I tentatively suggest
>
> diff --git a/tcg/sparc/tcg-target.inc.c b/tcg/sparc/tcg-target.inc.c
> index d1f4c0dead..c72b57dc58 100644
> --- a/tcg/sparc/tcg-target.i
Commit 0ab8ed18a6fe98bfc82705b0f041fbf2a8ca5b60 ("trace: switch to
modular code generation for sub-directories") forgot to convert "tcg"
trace events to the modular code generation approach where each
sub-directory has its own trace-events file.
This patch fixes compilation for "tcg" trace events.
On Thu, Mar 23, 2017 at 10:39:43PM -0400, Emilio G. Cota wrote:
> On Thu, Mar 23, 2017 at 19:08:11 +, Peter Maydell wrote:
> > Hi; I thought I'd have a look at the guest_mem_before trace event,
> > but if I enable it (by deleting "disable" from the line in trace-events)
> > QEMU doesn't compile
Am 20.03.2017 um 17:56 schrieb Paolo Bonzini:
On 20/03/2017 17:43, Peter Lieven wrote:
Am 20.03.2017 um 15:05 schrieb Paolo Bonzini:
On 20/03/2017 14:35, Peter Lieven wrote:
Am 20.03.2017 um 14:23 schrieb Paolo Bonzini:
On 20/03/2017 14:13, Peter Lieven wrote:
Am 20.03.2017 um 13:47 schrieb
Richard Henderson writes:
> On 03/26/2017 02:52 AM, Pranith Kumar wrote:
>> Hello,
>>
>
>> Please let me know if you have any comments or suggestions. Also please let
>> me
>> know if there are other enhancements that are easily implementable to
>> increase
>> TCG performance as part of this
If, once the kernel has booted, we try to remove a memory
hotplugged while the kernel was not started, QEMU crashes on
an assert:
qemu-system-ppc64: hw/virtio/vhost.c:651:
vhost_commit: Assertion `r >= 0' failed.
...
#4 in vhost_commit
#5 in memory_region_t
runtime_opts is used for three different purposes:
* qemu_rbd_open() uses it to accept options it recognizes, such as
"pool" and "image". Other .bdrv_open() methods do it similarly.
* qemu_rbd_open() accepts additional list-valued options
auth-supported and server, with the help of qemu_rbd_
This is RFC because it needs more testing. I'm sending it out now in
the hope of getting some review while we test.
v3:
* PATCH 01-07 unchanged except for a doc tweak in PATCH 06
* PATCH 08-10 replace PATCH 9
* PATCH 8 becomes PATCH 11, rebased on top of 08-10, commit message
updated, R-by drop
This reverts a part of commit 8a47e8e. We're having second thoughts
on the QAPI schema (and thus the external interface), and haven't
reached consensus, yet. Issues include:
* BlockdevOptionsRbd member @password-secret isn't actually a
password, it's a key generated by Ceph.
* We're not sure
This code in qemu_rbd_parse_filename()
found_str = qemu_rbd_next_tok(p, '\0', &p);
p = found_str;
has no effect. Drop it, and simplify qemu_rbd_next_tok().
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
block/rbd.c | 24 +---
1 file changed, 9 insert
We laboriously enforce parameter values are between one and some
arbitrary limit in length. Only RBD_MAX_IMAGE_NAME_SIZE comes from
librbd.h, and I'm not sure it applies. Where the other limits come
from is unclear.
Drop the length checking. The limits librbd actually imposes must be
checked by
On Fri, Mar 24, 2017 at 04:28:32PM +, Xu, Anthony wrote:
> Create libqemutrace.a for all trace.o
> Currently all trace.o are linked into qemu-system, qemu-img,
> qemu-nbd, qemu-io etc., even the corresponding components
> are not included.
> Create a libqemutrace.a that the linker would only
This reverts half of commit 0a55679. We're having second thoughts on
the QAPI schema (and thus the external interface), and haven't reached
consensus, yet. Issues include:
* The implementation uses deprecated rados_conf_set() key
"auth_supported". No biggie.
* The implementation makes -drive
We use InetSocketAddress in the QAPI schema. However, the code
doesn't use inet_connect_saddr(), but formats "host" and "port" into a
configuration string for rados_conf_set(). Thus, members "numeric",
"to", "ipv4" and "ipv6" are silently ignored. Not nice. Example:
-blockdev
rbd,node-nam
The way we communicate extra key-value pairs from
qemu_rbd_parse_filename() to qemu_rbd_open() exposes option parameter
"keyvalue-pairs" on the command line. It's not wanted there. Hack:
rename the parameter to "=keyvalue-pairs" to make it inaccessible.
Signed-off-by: Markus Armbruster
Reviewed
This reverts commit 60390a2192e7b38aee18db6ce7fb740498709737.
The commit's rationale
Currently RBD passwords must be provided on the command line
via
$QEMU -drive file=rbd:pool/image:id=myname:\
key=QVFDVm41aE82SHpGQWhBQXEwTkN2OGp0SmNJY0UrSE9CbE1RMUE=:\
qemu_rbd_open() takes option parameters as a flattened QDict, with
keys of the form server.%d.host, server.%d.port, where %d counts up
from zero.
qemu_rbd_array_opts() extracts these values as follows. First, it
calls qdict_array_entries() to find the list's length. For each list
element, it for
qemu_rbd_open() neglects to check pool and image are present.
Reproducer:
$ qemu-system-x86_64 -nodefaults -drive if=none,driver=rbd,pool=p
Segmentation fault (core dumped)
$ qemu-system-x86_64 -nodefaults -drive if=none,driver=rbd,image=i
qemu-system-x86_64: -drive if=none,driver=
The conversion from QDict to QemuOpts is pointless. Simply get the
stuff straight from the QDict.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
---
block/rbd.c | 20 +---
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/block/rb
* Thomas Huth (th...@redhat.com) wrote:
> We currently do not test HMP commands automatically yet, so if they
> break, we do not notice this until somebody runs into the problem
> (like the "info qtree" problem that we recently had on qemu-system-ppc64).
> So let's add a simple tester that runs som
>From cddb60744808eedbadebdc4f0258ee6db694c4a3 Mon Sep 17 00:00:00 2001
From: Danil Antonov
Date: Mon, 27 Mar 2017 14:43:10 +0300
Subject: [PATCH] debug: made printf always compile in debug output
Wrapped printf calls inside debug macros (DPRINTF) in `if` statement.
This will ensure that printf f
From: Tejaswini Poluri
Changed sd_init() to take SDstate by value and return state as success/failure
Edited the rest of the functions using sd_init() to accommodate the change
Signed-off-by: Tejaswini Poluri
---
hw/sd/milkymist-memcard.c | 3 +--
hw/sd/omap_mmc.c | 6 ++
hw/sd/
* Paolo Bonzini (pbonz...@redhat.com) wrote:
> These commands are useful when testing machine-check passthrough.
> gpa2hva is useful to inject a MADV_HWPOISON madvise from gdb, while
> gpa2hpa is useful to inject an error with the mce-inject kernel
> module.
>
> Signed-off-by: Paolo Bonzini
Revi
On 23.03.2017 16:32, Stefan Hajnoczi wrote:
> On Wed, Mar 22, 2017 at 05:50:59PM +0100, Max Reitz wrote:
>> On 22.03.2017 17:28, Stefan Hajnoczi wrote:
>>> On Mon, Mar 20, 2017 at 04:07:16PM +0100, Max Reitz wrote:
On 20.03.2017 11:18, Stefan Hajnoczi wrote:
> On Mon, Mar 13, 2017 at 10:39
On Mon, Mar 27, 2017 at 01:10:59PM +0200, Igor Mammedov wrote:
> On Fri, 24 Mar 2017 17:36:45 -0300
> Eduardo Habkost wrote:
>
> > The existing code for "host" and "max" CPU models overrides every
> > single feature in the CPU object at realize time, even the ones
> > that were explicitly enabled
* Thomas Huth (th...@redhat.com) wrote:
> Some tests need to run single tests for every available machine of the
> current QEMU binary. To avoid code duplication, let's extract this
> code that deals with 'query-machines' into a separate function.
>
> Signed-off-by: Thomas Huth
Having queued it,
When opt_xfer_len is zero, Linux ignores max_xfer_len erroneously.
While that obviously should be fixed, we do older guests a favor to
always filling in a value.
Signed-off-by: Fam Zheng
---
hw/scsi/scsi-generic.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/scsi/
KVM allows trap and emulate (read: NOP) of the MONITOR and MWAIT
instructions. There is work undergoing to enable actual execution
of these inside of KVM, but nobody really wants to expose the feature
to the guest by default, as it would eat up all of the host CPU.
So today there is no streamlined
1 - 100 of 278 matches
Mail list logo
