Re: [Qemu-devel] [PATCH] trace: fix group name generation

2016-11-17 Thread Fam Zheng
On Thu, 10/20 15:25, Stefan Hajnoczi wrote: > > > > I have two other patches ready to fix the current situation: > > - one using os.getcwd() to guess the build directory > > - one implementing --group as mentioned in my other mail > > > > But the one that filters unwanted characters is a less int

Re: [Qemu-devel] QMP event on reboot when -no-reboot is set

2016-11-17 Thread Dirk Braunschweiger
On 2016-11-16 17:29, John Snow wrote: On 11/16/2016 09:01 AM, Dirk Braunschweiger wrote: Hey Guys, I want to get a qmp event when the qemu does a shutdown due to the -no-reboot flag. Looking at the code I realized that the -no-reboot flag just changes any reset request to a shutdown request.

Re: [Qemu-devel] dpdk/vpp and cross-version migration for vhost

2016-11-17 Thread Yuanhan Liu
As usaual, sorry for late response :/ On Thu, Oct 13, 2016 at 08:50:52PM +0300, Michael S. Tsirkin wrote: > Hi! > So it looks like we face a problem with cross-version > migration when using vhost. It's not new but became more > acute with the advent of vhost user. > > For users to be able to mig

Re: [Qemu-devel] [PATCH 3/4] hw/timer: Add Epson RX8900 RTC support

2016-11-17 Thread Cédric Le Goater
On 11/17/2016 05:36 AM, Alastair D'Silva wrote: > From: Alastair D'Silva > > This patch adds support for the Epson RX8900 RTC chip. It would be nice to have a short list of the features this chip has and also the main point of the design. I see you are using a BH. > Signed-off-by: Alastair D

Re: [Qemu-devel] [PATCH 1/3] virtio: add missing vdev->broken check

2016-11-17 Thread Cornelia Huck
On Wed, 16 Nov 2016 21:53:07 + Stefan Hajnoczi wrote: > virtio_queue_notify_vq() checks vdev->broken before invoking the > handler, virtio_queue_notify_aio_vq() should too. > > Signed-off-by: Stefan Hajnoczi > --- > hw/virtio/virtio.c | 4 > 1 file changed, 4 insertions(+) Reviewed-b

Re: [Qemu-devel] [PATCH 1/3] virtio: introduce grab/release_ioeventfd to fix vhost

2016-11-17 Thread Cornelia Huck
On Wed, 16 Nov 2016 19:05:49 +0100 Paolo Bonzini wrote: > Following the recent refactoring of virtio notifiers [1], more specifically > the patch ed08a2a0b ("virtio: use virtio_bus_set_host_notifier to > start/stop ioeventfd") that uses virtio_bus_set_host_notifier [2] > by default, core virtio c

Re: [Qemu-devel] dpdk/vpp and cross-version migration for vhost

2016-11-17 Thread Maxime Coquelin
On 11/17/2016 09:29 AM, Yuanhan Liu wrote: As usaual, sorry for late response :/ On Thu, Oct 13, 2016 at 08:50:52PM +0300, Michael S. Tsirkin wrote: Hi! So it looks like we face a problem with cross-version migration when using vhost. It's not new but became more acute with the advent of vhos

Re: [Qemu-devel] [PATCH 3/3] virtio: set ISR on dataplane notifications

2016-11-17 Thread Paolo Bonzini
> > > > > /* > > > > > * virtio spec 1.0 says ISR bit 0 should be ignored with MSI, but > > > > > * windows drivers included in virtio-win 1.8.0 (circa 2015) > > > > > * for Windows 8.1 only are incorrectly polling this bit during > > > > > shutdown > > > > > > > > >

Re: [Qemu-devel] [PATCH] trace: fix group name generation

2016-11-17 Thread Greg Kurz
On Thu, 17 Nov 2016 16:07:38 +0800 Fam Zheng wrote: > On Thu, 10/20 15:25, Stefan Hajnoczi wrote: > > > > > > I have two other patches ready to fix the current situation: > > > - one using os.getcwd() to guess the build directory > > > - one implementing --group as mentioned in my other mail > >

Re: [Qemu-devel] (no subject)

2016-11-17 Thread Thomas Huth
Hi Christopher, On 16.11.2016 20:41, Christopher Oliver wrote: > This patch (hack?) works around the slowness in SEEK_HOLE for large dense > files > on Linux tmpfs. It may improve life elsewhere as well, and the penalty of > the checks > should be vanishingly small where it is not needed. > >

Re: [Qemu-devel] [PATCH v2] hw/isa/lpc_ich9: inject SMI on all VCPUs if APM_STS == 'Q'

2016-11-17 Thread Laszlo Ersek
On 11/16/16 21:38, Michael S. Tsirkin wrote: > On Wed, Nov 16, 2016 at 01:04:00PM -0500, Paolo Bonzini wrote: >>> I guess that's what the next paragraph is about: >>> - we could have another magic 0xB2 value, which is implemented directly in QEMU and sets 0xB3 to a magic value. Then OVMF

Re: [Qemu-devel] [RFC PATCH 1/8] coroutine: Introduce qemu_coroutine_enter_if_inactive()

2016-11-17 Thread Alberto Garcia
On Thu 10 Nov 2016 06:19:02 PM CET, Kevin Wolf wrote: > diff --git a/util/qemu-coroutine.c b/util/qemu-coroutine.c > index 737bffa..a06befe 100644 > --- a/util/qemu-coroutine.c > +++ b/util/qemu-coroutine.c > @@ -19,6 +19,7 @@ > #include "qemu/atomic.h" > #include "qemu/coroutine.h" > #include "

Re: [Qemu-devel] [PATCH] trace: fix group name generation

2016-11-17 Thread Fam Zheng
On Thu, 11/17 10:10, Greg Kurz wrote: > On Thu, 17 Nov 2016 16:07:38 +0800 > Fam Zheng wrote: > > > On Thu, 10/20 15:25, Stefan Hajnoczi wrote: > > > > > > > > I have two other patches ready to fix the current situation: > > > > - one using os.getcwd() to guess the build directory > > > > - one

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/1] hw/net/spapr_llan: 6 byte mac address device tree entry

2016-11-17 Thread Thomas Huth
On 17.11.2016 05:24, Sam Bobroff wrote: > The spapr-vlan device in QEMU has always presented it's MAC address in > the device tree as an 8 byte value, even though PAPR requires it to be > 6 bytes. This is because, at the time, AIX required the value to be 8 > bytes. However, modern versions of AI

Re: [Qemu-devel] [PATCH] trace: fix group name generation

2016-11-17 Thread Greg Kurz
On Thu, 17 Nov 2016 17:34:44 +0800 Fam Zheng wrote: > On Thu, 11/17 10:10, Greg Kurz wrote: > > On Thu, 17 Nov 2016 16:07:38 +0800 > > Fam Zheng wrote: > > > > > On Thu, 10/20 15:25, Stefan Hajnoczi wrote: > > > > > > > > > > I have two other patches ready to fix the current situation: > >

Re: [Qemu-devel] dpdk/vpp and cross-version migration for vhost

2016-11-17 Thread Yuanhan Liu
On Thu, Nov 17, 2016 at 09:47:09AM +0100, Maxime Coquelin wrote: > > > On 11/17/2016 09:29 AM, Yuanhan Liu wrote: > >As usaual, sorry for late response :/ > > > >On Thu, Oct 13, 2016 at 08:50:52PM +0300, Michael S. Tsirkin wrote: > >>Hi! > >>So it looks like we face a problem with cross-version >

Re: [Qemu-devel] [PATCH] trace: fix group name generation

2016-11-17 Thread Fam Zheng
On Thu, 11/17 10:48, Greg Kurz wrote: > On Thu, 17 Nov 2016 17:34:44 +0800 > Fam Zheng wrote: > > > On Thu, 11/17 10:10, Greg Kurz wrote: > > > On Thu, 17 Nov 2016 16:07:38 +0800 > > > Fam Zheng wrote: > > > > > > > On Thu, 10/20 15:25, Stefan Hajnoczi wrote: > > > > > > > > > > > > I have

Re: [Qemu-devel] [PATCH] trace: fix group name generation

2016-11-17 Thread Stefan Hajnoczi
On Thu, Nov 17, 2016 at 10:48:34AM +0100, Greg Kurz wrote: > On Thu, 17 Nov 2016 17:34:44 +0800 > Fam Zheng wrote: > > > On Thu, 11/17 10:10, Greg Kurz wrote: > > > On Thu, 17 Nov 2016 16:07:38 +0800 > > > Fam Zheng wrote: > > > > > > > On Thu, 10/20 15:25, Stefan Hajnoczi wrote: > > > > >

Re: [Qemu-devel] [RFC PATCH 4/8] quorum: Do cleanup in caller coroutine

2016-11-17 Thread Alberto Garcia
On Thu 10 Nov 2016 06:19:05 PM CET, Kevin Wolf wrote: > Instead of calling quorum_aio_finalize() deeply nested in what used > to be an AIO callback, do it in the same functions that allocated the > AIOCB. > > Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

2016-11-17 Thread Stefan Hajnoczi
On Thu, Nov 17, 2016 at 08:52:12AM +0100, Laurent Vivier wrote: > Le 17/11/2016 à 08:08, Hailiang Zhang a écrit : > > Hi Laurent, > > > > On 2016/11/15 16:44, Laurent Vivier wrote: > >> Le 14/11/2016 à 14:54, Stefan Hajnoczi a écrit : > >>> On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang

[Qemu-devel] [PULL 1/1] qapi-schema: clarify 'colo' state for MigrationStatus

2016-11-17 Thread Laurent Vivier
From: zhanghailiang VM can not get into colo state unless users enable 'x-colo' capability for migration, Here it is necessary to clarify this. Suggested-by: Eric Blake Signed-off-by: zhanghailiang Message-Id: <1478072652-9884-1-git-send-email-zhang.zhanghaili...@huawei.com> Reviewed-by: Eric

[Qemu-devel] [PULL 0/1] Trivial patches patches

2016-11-17 Thread Laurent Vivier
The following changes since commit b0bcc86d2a87456f5a276f941dc775b265b309cf: Update version for v2.8.0-rc0 release (2016-11-15 20:55:12 +) are available in the git repository at: git://github.com/vivier/qemu.git tags/trivial-patches-pull-request for you to fetch changes up to 252093a726

[Qemu-devel] [PATCH for-2.8] gluster: Fix use after free in glfs_clear_preopened()

2016-11-17 Thread Kevin Wolf
This fixes a use-after-free bug introduced in commit 6349c154. We need to use QLIST_FOREACH_SAFE() when freeing elements in the loop. Spotted by Coverity. Signed-off-by: Kevin Wolf --- block/gluster.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/gluster.c b/block/g

Re: [Qemu-devel] a small issue with VSOCK

2016-11-17 Thread Stefan Hajnoczi
On Tue, Nov 15, 2016 at 07:25:59PM +0100, Claudio Imbrenda wrote: > I have found a small issue in the current implementation of VSOCK: if > you load both the vhost_vsock module (or if it's compiled in) then the > vmw_vsock_virtio_transport will not load successfully (both when > compiled as a modul

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.8 v2] hbitmap: Fix shifts of constants by granularity

2016-11-17 Thread Stefan Hajnoczi
On Tue, Nov 15, 2016 at 11:47:32PM +0100, Max Reitz wrote: > An hbitmap's granularity may be anything from 0 to 63, so when shifting > constants by its value, they should not be plain ints. > > Even having changed the types, hbitmap_serialization_granularity() still > tries to shift 64 to the righ

Re: [Qemu-devel] your mail

2016-11-17 Thread Kevin Wolf
Am 16.11.2016 um 20:41 hat Christopher Oliver geschrieben: > This patch (hack?) works around the slowness in SEEK_HOLE for large dense > files > on Linux tmpfs. It may improve life elsewhere as well, and the penalty of > the checks > should be vanishingly small where it is not needed. > > If I'

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9 0/2] hbitmap: Add hbitmap_is_serializable()

2016-11-17 Thread Stefan Hajnoczi
On Tue, Nov 15, 2016 at 11:57:44PM +0100, Max Reitz wrote: > This series is a follow-up for "hbitmap: Fix shifts of constants by > granularity". > > So far, adding the assertion in hbitmap_serialization_granularity() (as > done by said previous patch) is enough and we know that it will always > ho

Re: [Qemu-devel] [PULL 0/3] pc: remove redundant fw_cfg file "etc/boot-cpus"

2016-11-17 Thread Stefan Hajnoczi
On Wed, Nov 16, 2016 at 12:17:33PM -0200, Eduardo Habkost wrote: > Unfortunately not in time for -rc0, but we still want to remove > "etc/boot-cpus" before 2.8.0 is released. > > The following changes since commit b0bcc86d2a87456f5a276f941dc775b265b309cf: > > Update version for v2.8.0-rc0 relea

Re: [Qemu-devel] [PATCH 3/3] virtio: set ISR on dataplane notifications

2016-11-17 Thread Stefan Hajnoczi
On Wed, Nov 16, 2016 at 10:15:25PM +0200, Michael S. Tsirkin wrote: > On Wed, Nov 16, 2016 at 07:05:51PM +0100, Paolo Bonzini wrote: > > @@ -1356,6 +1349,17 @@ bool virtio_should_notify(VirtIODevice *vdev, > > VirtQueue *vq) > > return !v || vring_need_event(vring_get_used_event(vq), new, old

Re: [Qemu-devel] [PATCH v4 14/15] docs: add qemu logo

2016-11-17 Thread Marc-André Lureau
Hi On Thu, Nov 10, 2016 at 7:45 PM Daniel P. Berrange wrote: > On Thu, Nov 10, 2016 at 07:22:08PM +0400, Marc-André Lureau wrote: > > The pdf (needed by texi2pdf for vectorized images) was generated thanks > > to inkscape, from the pc-bios/qemu_logo.svg file. Move the original file > > in the do

Re: [Qemu-devel] [PATCH v2 1/2] ivshmem: fix misconfig of not_legacy_32bit

2016-11-17 Thread Markus Armbruster
Zhuangyanying writes: > From: ZhuangYanying > > After commit 5400c02, ivshmem_64bit renamed to not_legacy_32bit, > and changed the implementation of this property. > Then use64 = 1, ~PCI_BASE_ADDRESS_MEM_TYPE_64 (default for ivshmem), > the actual use is the legacy model, > can not support gre

Re: [Qemu-devel] [PATCH 1/3] virtio: add missing vdev->broken check

2016-11-17 Thread Stefan Hajnoczi
On Thu, Nov 17, 2016 at 09:31:18AM +0100, Cornelia Huck wrote: > On Wed, 16 Nov 2016 21:53:07 + > Stefan Hajnoczi wrote: > > > virtio_queue_notify_vq() checks vdev->broken before invoking the > > handler, virtio_queue_notify_aio_vq() should too. > > > > Signed-off-by: Stefan Hajnoczi > > --

Re: [Qemu-devel] [PATCH 0/3] virtio: disable notifications in blk and scsi

2016-11-17 Thread Christian Borntraeger
On 11/16/2016 10:53 PM, Stefan Hajnoczi wrote: > Disabling notifications during virtqueue processing reduces the number of > exits. The virtio-net device already uses virtio_queue_set_notifications() > but > virtio-blk and virtio-scsi do not. > > The following benchmark shows a 15% reduction in

Re: [Qemu-devel] [PULL 0/1] Trivial patches patches

2016-11-17 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PULL 0/1] Trivial patches patches Message-id: 1479378016-19022-1-git-send-email-laur...@vi

Re: [Qemu-devel] [PATCH v2 0/5] [RFC] Add HAX support

2016-11-17 Thread Vincent Palatin
On Mon, Nov 14, 2016 at 2:09 PM, Vincent Palatin wrote: > On Mon, Nov 14, 2016 at 1:36 PM, Stefan Weil wrote: >> Am 11.11.2016 um 12:28 schrieb Vincent Palatin: >> [...] >>> I have tested the end result on a Windows 10 Pro machine (with UG support) >>> with the Intel HAXM module 6.0.4 and a large

Re: [Qemu-devel] [PATCH v2] HACKING: document #include order

2016-11-17 Thread Markus Armbruster
Stefan Hajnoczi writes: > It was not obvious to me why "qemu/osdep.h" must be the first #include. > This documents the rationale and the overall #include order. > > Cc: Fam Zheng > Cc: Markus Armbruster > Cc: Eric Blake > Signed-off-by: Stefan Hajnoczi > --- > HACKING | 18 ++

[Qemu-devel] [PATCH v3 1/3] kvm: move cpu synchronization code

2016-11-17 Thread Vincent Palatin
Move the generic cpu_synchronize_ functions to the common hw_accel.h header, in order to prepare for the addition of a second hardware accelerator. Signed-off-by: Stefan Weil Signed-off-by: Vincent Palatin --- cpus.c | 1 + gdbstub.c | 1 + hw/i386/kvm/a

[Qemu-devel] [PATCH v3 0/3] Add HAX support

2016-11-17 Thread Vincent Palatin
I took a stab at trying to rebase/upstream the support for Intel HAXM. (Hardware Accelerated Execution Manager). Intel HAX is kernel-based hardware acceleration module for Windows and MacOSX. I have based my work on the last version of the source code I found: the emu-2.2-release branch in the ext

[Qemu-devel] [PATCH v3 3/3] Plumb the HAXM-based hardware acceleration support

2016-11-17 Thread Vincent Palatin
Use the Intel HAX is kernel-based hardware acceleration module for Windows (similar to KVM on Linux). Based on the "target-i386: Add Intel HAX to android emulator" patch from David Chou Signed-off-by: Vincent Palatin --- Makefile.target | 1 + configure | 18

[Qemu-devel] [PATCH v3 2/3] target-i386: Add Intel HAX files

2016-11-17 Thread Vincent Palatin
That's a forward port of the core HAX interface code from the emu-2.2-release branch in the external/qemu-android repository as used by the Android emulator. The original commit was "target-i386: Add Intel HAX to android emulator" saying: """ Backport of 2b3098ff27bab079caab9b46b58546b5036f5c0c

Re: [Qemu-devel] [PULL 0/1] Trivial patches patches

2016-11-17 Thread Fam Zheng
On Thu, 11/17 03:06, no-re...@patchew.org wrote: > Cannot create temporary file in ./: Read-only file system > cc: Internal error: Aborted (program collect2) > Please submit a full bug report. > See for instructions. > Cannot create temporary file in /tmp/: Rea

Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value

2016-11-17 Thread Paolo Bonzini
On 16/11/2016 07:29, P J P wrote: > +-- On Wed, 16 Nov 2016, Hervé Poussineau wrote --+ > | I don't have any datasheet for this device either, so I tested with real > | programs. Those initialize itr field to either 0 or to 9, so your mask > | doesn't change anything. > | > | Tested-by: Hervé

Re: [Qemu-devel] [PATCH v2 2/4] aio: add polling mode to AioContext

2016-11-17 Thread Stefan Hajnoczi
On Wed, Nov 16, 2016 at 07:14:47PM +0100, Paolo Bonzini wrote: > > > On 16/11/2016 18:47, Stefan Hajnoczi wrote: > > The AioContext event loop uses ppoll(2) or epoll_wait(2) to monitor file > > descriptors or until a timer expires. In cases like virtqueues, Linux > > AIO, and ThreadPool it is te

Re: [Qemu-devel] [PATCH 18/25] tcg/aarch64: Handle ctz and clz opcodes

2016-11-17 Thread Richard Henderson
On 11/16/2016 08:25 PM, Richard Henderson wrote: @@ -206,6 +206,9 @@ static int tcg_target_const_match(tcg_target_long val, TCGType type, if ((ct & TCG_CT_CONST_MONE) && val == -1) { return 1; } +if ((ct & TCG_CT_CONST_WSZ) && val == (type ? 64 : 32)) { +return 1;

Re: [Qemu-devel] [PATCH for-2.8] gluster: Fix use after free in glfs_clear_preopened()

2016-11-17 Thread Jeff Cody
On Thu, Nov 17, 2016 at 11:30:08AM +0100, Kevin Wolf wrote: > This fixes a use-after-free bug introduced in commit 6349c154. We need > to use QLIST_FOREACH_SAFE() when freeing elements in the loop. Spotted > by Coverity. > > Signed-off-by: Kevin Wolf > --- > block/gluster.c | 3 ++- > 1 file cha

Re: [Qemu-devel] [PATCH 1/3] virtio: add missing vdev->broken check

2016-11-17 Thread Cornelia Huck
On Thu, 17 Nov 2016 10:58:30 + Stefan Hajnoczi wrote: > On Thu, Nov 17, 2016 at 09:31:18AM +0100, Cornelia Huck wrote: > > On Wed, 16 Nov 2016 21:53:07 + > > Stefan Hajnoczi wrote: > > > > > virtio_queue_notify_vq() checks vdev->broken before invoking the > > > handler, virtio_queue_not

Re: [Qemu-devel] [PATCH for-2.9 2/2] qdev: Change signature of PropertyInfo::release

2016-11-17 Thread Markus Armbruster
Eduardo Habkost writes: > Change the function signature to make implementations simpler and > safer. No void pointers and Object->DeviceState casts inside each > release function. > > Signed-off-by: Eduardo Habkost > --- > hw/core/qdev-properties-system.c | 8 ++-- > hw/core/qdev-propertie

[Qemu-devel] [PATCH v3] ivshmem: Fix 64 bit memory bar configuration

2016-11-17 Thread Zhuangyanying
From: Zhuang Yanying Device ivshmem property use64=0 is designed to make the device expose a 32 bit shared memory BAR instead of 64 bit one. The default is a 64 bit BAR, except pc-1.2 and older retain a 32 bit BAR. A 32 bit BAR can support only up to 1 GiB of shared memory.

Re: [Qemu-devel] [PATCH for-2.9 1/2] qom: Remove release function from class properties

2016-11-17 Thread Markus Armbruster
Eduardo Habkost writes: > The release functions are never called for class properties, and > their semantics aren't even defined clearly (should the release > function be called when an instance is destroyed, or when a class > is destroyed?). Remove the unused functionality. > > Signed-off-by: Ed

Re: [Qemu-devel] [PATCH v14 12/22] vfio: Add notifier callback to parent's ops structure of mdev

2016-11-17 Thread Jike Song
On 11/17/2016 04:46 AM, Kirti Wankhede wrote: > Add a notifier calback to parent's ops structure of mdev device so that per > device notifer for vfio module is registered through vfio_mdev module. > > Signed-off-by: Kirti Wankhede > Signed-off-by: Neo Jia > Change-Id: Iafa6f1721aecdd6e50eb93b153

Re: [Qemu-devel] [PATCH for-2.9] qmp: Report QOM type name on query-cpu-definitions

2016-11-17 Thread Markus Armbruster
Eduardo Habkost writes: > The new typename attribute on query-cpu-definitions will be used > to help management software use device-list-properties to check > which properties can be set using -cpu or -global for the CPU > model. > > Signed-off-by: Eduardo Habkost > --- > qapi-schema.json

Re: [Qemu-devel] [Bug?] Guest pause because VMPTRLD failed in KVM

2016-11-17 Thread Paolo Bonzini
On 10/11/2016 15:10, gong lei wrote: >4) The isssue can't be reporduced. I search the Intel VMX sepc about > reaseons > of vmptrld failure: >The instruction fails if its operand is not properly aligned, sets > unsupported physical-address bits, or is equal to the VMXON >pointer. In a

[Qemu-devel] GPIO input?

2016-11-17 Thread Liviu Ionescu
I added graphical buttons to GNU ARM Eclipse QEMU, and I can already trigger actions when a button is pushed/released, so currently I can reset the STM32F4DISCOVERY board clicking the reset button on the board picture. Now I want to implement the user button, which on this board is connected to

Re: [Qemu-devel] [qemu patch 2/2] kvmclock: reduce kvmclock difference on migration

2016-11-17 Thread Marcelo Tosatti
On Mon, Nov 14, 2016 at 04:15:18PM -0200, Marcelo Tosatti wrote: > On Mon, Nov 14, 2016 at 06:20:29PM +0100, Paolo Bonzini wrote: > > > > > > On 14/11/2016 18:13, Marcelo Tosatti wrote: > > > On Mon, Nov 14, 2016 at 05:43:33PM +0100, Paolo Bonzini wrote: > > >> > > >> > > >> On 14/11/2016 16:40,

Re: [Qemu-devel] [qemu patch 2/2] kvmclock: reduce kvmclock difference on migration

2016-11-17 Thread Paolo Bonzini
On 17/11/2016 13:16, Marcelo Tosatti wrote: > On Mon, Nov 14, 2016 at 04:15:18PM -0200, Marcelo Tosatti wrote: >> On Mon, Nov 14, 2016 at 06:20:29PM +0100, Paolo Bonzini wrote: >>> >>> >>> On 14/11/2016 18:13, Marcelo Tosatti wrote: On Mon, Nov 14, 2016 at 05:43:33PM +0100, Paolo Bonzini wro

Re: [Qemu-devel] [PATCH v2] hw/isa/lpc_ich9: inject SMI on all VCPUs if APM_STS == 'Q'

2016-11-17 Thread Laszlo Ersek
On 11/16/16 21:27, Michael S. Tsirkin wrote: > On Wed, Nov 16, 2016 at 07:03:27PM +0100, Laszlo Ersek wrote: >> On 11/16/16 15:05, Paolo Bonzini wrote: >>> >>> >>> On 16/11/2016 14:18, Michael S. Tsirkin wrote: > - we could have another magic 0xB2 value, which is implemented directly > in Q

[Qemu-devel] [qemu patch V2 0/2] improve kvmclock difference on migration

2016-11-17 Thread Marcelo Tosatti
See individual patches for details. This patchset depends on the not yet applied "[PATCH] kvm: kvmclock: let KVM_GET_CLOCK return whether the master clock is in use" from Paolo.

Re: [Qemu-devel] [PATCH 0/3] virtio: disable notifications in blk and scsi

2016-11-17 Thread Stefan Hajnoczi
On Thu, Nov 17, 2016 at 12:17:57AM +0200, Michael S. Tsirkin wrote: > On Wed, Nov 16, 2016 at 09:53:06PM +, Stefan Hajnoczi wrote: > > Disabling notifications during virtqueue processing reduces the number of > > exits. The virtio-net device already uses virtio_queue_set_notifications() > > b

[Qemu-devel] [qemu patch V2 1/2] kvm: sync linux headers

2016-11-17 Thread Marcelo Tosatti
Import KVM_CLOCK_TSC_STABLE. Signed-off-by: Marcelo Tosatti diff --git a/include/standard-headers/linux/input.h b/include/standard-headers/linux/input.h index 7361a16..b472b85 100644 --- a/include/standard-headers/linux/input.h +++ b/include/standard-headers/linux/input.h @@ -245,6 +245,7 @@ st

[Qemu-devel] [qemu patch V2 2/2] kvmclock: reduce kvmclock difference on migration

2016-11-17 Thread Marcelo Tosatti
Check for KVM_CAP_ADJUST_CLOCK capability KVM_CLOCK_TSC_STABLE, which indicates that KVM_GET_CLOCK returns a value as seen by the guest at that moment. For new machine types, use this value rather than reading from guest memory. This reduces kvmclock difference on migration from 5s to 0.1s (when

Re: [Qemu-devel] [PATCH for-2.9] qmp: Report QOM type name on query-cpu-definitions

2016-11-17 Thread Eduardo Habkost
On Thu, Nov 17, 2016 at 01:38:54PM +0100, Markus Armbruster wrote: [...] > A bit sad that the QOM type name needs to be computed in > target-dependent code. I plan to provide a generic implementation of query-cpu-definitions later, to fix this. > > With Eric's doc fix: > Reviewed-by: Markus Armb

[Qemu-devel] 答复: [RFC, v1, 1/2] hw/vfio/platform: add hisilicon hnsvf device

2016-11-17 Thread Songwenjun (Rick Song)
Hi, Eric, OK, I will look over it and see what I can do here. BR. Rick Song Hi Rick, On 21/10/2016 03:22, Rick Song wrote: > The platform device class has become abstract. This patch introduces a > hisilicon hnsvf device that derives from it. in https://lists.gnu.org/archive/html/qemu-devel/20

Re: [Qemu-devel] [PATCH v3] ivshmem: Fix 64 bit memory bar configuration

2016-11-17 Thread Markus Armbruster
Zhuangyanying writes: > From: Zhuang Yanying > > Device ivshmem property use64=0 is designed to make the device > expose a 32 bit shared memory BAR instead of 64 bit one. The > default is a 64 bit BAR, except pc-1.2 and older retain a 32 bit > BAR. A 32 bit BAR can support only

Re: [Qemu-devel] [PATCH for-2.9 1/2] qom: Remove release function from class properties

2016-11-17 Thread Eduardo Habkost
On Thu, Nov 17, 2016 at 01:33:34PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > The release functions are never called for class properties, and > > their semantics aren't even defined clearly (should the release > > function be called when an instance is destroyed, or when a c

Re: [Qemu-devel] [Qemu-ppc] Problem with QEMU PPC test image

2016-11-17 Thread Thomas Huth
On 17.11.2016 03:25, Programmingkid wrote: > When I run this test disk image: > http://wiki.qemu.org/download/ppc-virtexml507-linux-2_6_34.tgz > > I see these error messages: > /selftest.sh: line 6: /usr/bin/sha1test: not found > /selftest.sh: line 7: /usr/bin/hmactest: not found > > Maybe /usr/

Re: [Qemu-devel] [PATCH for-2.9 2/2] qdev: Change signature of PropertyInfo::release

2016-11-17 Thread Eduardo Habkost
On Thu, Nov 17, 2016 at 01:26:47PM +0100, Markus Armbruster wrote: [...] > The transformation looks correct to me, but I'm not sure it's > worthwhile. > > Moreover, it creates an inconsistency between set()/get() and release(), > both here and in the concrete implementations. For instance, > get_

Re: [Qemu-devel] [PATCH v7 02/10] hcd-xhci: check & correct param before using it

2016-11-17 Thread Markus Armbruster
Cao jin writes: > usb_xhci_realize() corrects invalid values of property "intrs" > automatically, but the uncorrected value is passed to msi_init(), > which chokes on invalid values. Delay that until after the > correction. > > Resources allocated by usb_xhci_init() are leaked when msi_init() >

Re: [Qemu-devel] [Qemu-block] [PATCH] block: split large discard requests from block frontend

2016-11-17 Thread Olaf Hering
On Fri, May 06, Max Reitz wrote: > On 01.04.2016 19:49, Olaf Hering wrote: > > On Fri, Apr 01, Max Reitz wrote: > > > >> In any case, do you have a test case where a guest was able to submit a > >> request that led to the overflow error you described in the commit message? > > > > mkfs -t ext4 /

[Qemu-devel] [PATCH] trace: fix generated code build break

2016-11-17 Thread Greg Kurz
If the QEMU source dir is /var/tmp/aaa-qemu-clone and the build dir is /var/tmp/qemu-aio-poll-v2 Then I get an error as: trace/generated-tracers.c:15950:13: error: invalid suffix "_trace_events" on integer constant TraceEvent *2_trace_events[] = { ^ trace/generated-trace

Re: [Qemu-devel] [PULL 0/1] tags/xen-20161108-tag

2016-11-17 Thread Wei Liu
Hi Peter and Stefan, can you merge this pull request? We want to backport this patch once it is merged. Thanks Wei. On Tue, Nov 08, 2016 at 11:59:46AM -0800, Stefano Stabellini wrote: > The following changes since commit 207faf24c58859f5240f66bf6decc33b87a1776e: > > Merge remote-tracking branc

Re: [Qemu-devel] [qemu patch V2 2/2] kvmclock: reduce kvmclock difference on migration

2016-11-17 Thread Paolo Bonzini
On 17/11/2016 15:11, Eduardo Habkost wrote: > On Thu, Nov 17, 2016 at 11:24:13AM -0200, Marcelo Tosatti wrote: >> Check for KVM_CAP_ADJUST_CLOCK capability KVM_CLOCK_TSC_STABLE, which >> indicates that KVM_GET_CLOCK returns a value as seen by the guest at >> that moment. >> >> For new machine typ

Re: [Qemu-devel] [qemu patch V2 2/2] kvmclock: reduce kvmclock difference on migration

2016-11-17 Thread Eduardo Habkost
On Thu, Nov 17, 2016 at 11:24:13AM -0200, Marcelo Tosatti wrote: > Check for KVM_CAP_ADJUST_CLOCK capability KVM_CLOCK_TSC_STABLE, which > indicates that KVM_GET_CLOCK returns a value as seen by the guest at > that moment. > > For new machine types, use this value rather than reading > from guest

Re: [Qemu-devel] [PATCH v2 0/4] aio: experimental virtio-blk polling mode

2016-11-17 Thread Karl Rister
I think these results look a bit more in line with expectations on the quick sniff test: QEMU_AIO_POLL_MAX_NS IOPs unset26,299 125,929 225,753 427,214 827,053 16

Re: [Qemu-devel] [PULL v2 00/34] virtio, vhost, pc, pci: tests, documentation, fixes and cleanups

2016-11-17 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL v2 00/34] virtio, vhost, pc, pci: tests, documentation, fixes and cleanups Type: series Message-id: 1478887767-31980-1-git-send-email-...@redhat.com === TEST SCRIPT BEGIN

Re: [Qemu-devel] [PATCH] trace: fix generated code build break

2016-11-17 Thread Fam Zheng
On Thu, 11/17 14:59, Greg Kurz wrote: > If the QEMU source dir is > > /var/tmp/aaa-qemu-clone > > and the build dir is > > /var/tmp/qemu-aio-poll-v2 > > Then I get an error as: > > trace/generated-tracers.c:15950:13: error: invalid suffix "_trace_events" > on integer constant > Trace

Re: [Qemu-devel] [RFC PATCH 5/8] quorum: Inline quorum_aio_cb()

2016-11-17 Thread Alberto Garcia
On Thu 10 Nov 2016 06:19:06 PM CET, Kevin Wolf wrote: > This is a conversion to a more natural coroutine style and improves the > readability of the driver. > > Signed-off-by: Kevin Wolf With this patch read_quorum_children_entry() and write_quorum_entry() become identical (except for bdrv_co_{pr

Re: [Qemu-devel] [PATCH] trace: fix generated code build break

2016-11-17 Thread Daniel P. Berrange
On Thu, Nov 17, 2016 at 10:22:00PM +0800, Fam Zheng wrote: > On Thu, 11/17 14:59, Greg Kurz wrote: > > If the QEMU source dir is > > > > /var/tmp/aaa-qemu-clone > > > > and the build dir is > > > > /var/tmp/qemu-aio-poll-v2 > > > > Then I get an error as: > > > > trace/generated-tracer

[Qemu-devel] [PATCH] ppc: BOOK3E: nothing should be done when MSR:PR is set

2016-11-17 Thread Vladimir Svoboda
The server architecture (BOOK3S) specifies that any instruction that sets MSR:PR will also set MSR:EE, IR and DR. However there is no such behavior specification for the embedded architecture (BOOK3E). Signed-off-by: Vladimir Svoboda --- target-ppc/helper_regs.h | 11 +++ 1 file changed,

[Qemu-devel] [Bug 1642421] [NEW] qemu-system-x86_64: ipv6 and dns is broken with netdev user

2016-11-17 Thread manut
Public bug reported: Hi, dhcp inside qemu returns an ipv6 address as dns-server. However this is not working. If i replace it with the ipv4 address '10.0.0.2' dns is working again. I would expect that the qemu emulated dhcp server responds either an ipv4 configuration that is working or its dns s

[Qemu-devel] [PATCH 0/4] Add support for the Epson RX8900 RTC to the aspeed board

2016-11-17 Thread Alastair D'Silva
From: Alastair D'Silva This patch series adds support for the Epson RX8900 RTC to the Aspeed board. The tests use the existing imx25 infrastructure, and some minor changes have been made to uniquely identify the I2C buses. Support for named interrupts has been implemented in qtest to facilitate

[Qemu-devel] [PATCH 1/4] arm: Uniquely name imx25 I2C buses.

2016-11-17 Thread Alastair D'Silva
From: Alastair D'Silva The imx25 chip provides 3 i2c buses, but they have all been named "i2c", which makes it difficult to predict which bus a device will be connected to when specified on the command line. This patch addresses the issue by naming the buses uniquely: i2c.0 i2c.1 i2c.2 Signed

Re: [Qemu-devel] [PATCH] tftp: fake support for netascii protocol

2016-11-17 Thread Vincent Bernat
❦ 17 novembre 2016 13:20 +0100, Vincent Bernat  : > Some network equipments are requesting a file using the netascii > protocol and this is not configurable. Currently, qemu's tftpd only > supports the octet protocol. This commit makes it accept the netascii > protocol as well but do not perform

[Qemu-devel] [PATCH 3/4] hw/timer: Add Epson RX8900 RTC support

2016-11-17 Thread Alastair D'Silva
From: Alastair D'Silva This patch adds support for the Epson RX8900 RTC chip. Signed-off-by: Alastair D'Silva --- default-configs/arm-softmmu.mak | 1 + hw/timer/Makefile.objs | 2 + hw/timer/rx8900.c | 891 hw/timer/rx8900_re

[Qemu-devel] [PATCH 2/4] qtest: Support named interrupts

2016-11-17 Thread Alastair D'Silva
From: Alastair D'Silva The QTest framework cannot work with named interrupts. This patch adds support for them, as well as the ability to manipulate them from within a test. Read actions are via callbacks, which allows for pulsed interrupts to be read (the polled method used for the unnamed inte

[Qemu-devel] [PATCH] tftp: fake support for netascii protocol

2016-11-17 Thread Vincent Bernat
From: Vincent Bernat Some network equipments are requesting a file using the netascii protocol and this is not configurable. Currently, qemu's tftpd only supports the octet protocol. This commit makes it accept the netascii protocol as well but do not perform the requested transformation (LF -> C

[Qemu-devel] [PATCH 4/4] arm: Add an RX8900 RTC to the ASpeed board

2016-11-17 Thread Alastair D'Silva
From: Alastair D'Silva Connect an RX8900 RTC to i2c12 of the AST2500 SOC at address 0x32 Signed-off-by: Alastair D'Silva --- hw/arm/aspeed.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index c7206fd..554ae20 100644 --- a/hw/arm/aspeed.c +++ b/h

Re: [Qemu-devel] [PATCH 10/25] target-tricore: Use clz opcode

2016-11-17 Thread Bastian Koppelmann
On 11/16/2016 08:25 PM, Richard Henderson wrote: > diff --git a/target-tricore/translate.c b/target-tricore/translate.c > index 36f734a..69cdfb9 100644 > --- a/target-tricore/translate.c > +++ b/target-tricore/translate.c > @@ -6367,7 +6367,8 @@ static void decode_rr_logical_shift(CPUTriCoreState

Re: [Qemu-devel] [PATCH] trace: fix generated code build break

2016-11-17 Thread Greg Kurz
On Thu, 17 Nov 2016 22:22:00 +0800 Fam Zheng wrote: > On Thu, 11/17 14:59, Greg Kurz wrote: > > If the QEMU source dir is > > > > /var/tmp/aaa-qemu-clone > > > > and the build dir is > > > > /var/tmp/qemu-aio-poll-v2 > > > > Then I get an error as: > > > > trace/generated-tracers.c:1

Re: [Qemu-devel] [PATCH] ppc: BOOK3E: nothing should be done when MSR:PR is set

2016-11-17 Thread Thomas Huth
On 17.11.2016 14:49, Vladimir Svoboda wrote: > The server architecture (BOOK3S) specifies that any instruction that > sets MSR:PR will also set MSR:EE, IR and DR. > However there is no such behavior specification for the embedded > architecture (BOOK3E). > > Signed-off-by: Vladimir Svoboda > ---

Re: [Qemu-devel] [PATCH for-2.9 1/2] qom: Remove release function from class properties

2016-11-17 Thread Markus Armbruster
Eduardo Habkost writes: > On Thu, Nov 17, 2016 at 01:33:34PM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > The release functions are never called for class properties, and >> > their semantics aren't even defined clearly (should the release >> > function be called when an i

Re: [Qemu-devel] [RFC PATCH 6/8] quorum: Avoid bdrv_aio_writev() for rewrites

2016-11-17 Thread Alberto Garcia
On Thu 10 Nov 2016 06:19:07 PM CET, Kevin Wolf wrote: > Replacing it with bdrv_co_pwritev() prepares us for byte granularity > requests and gets us rid of the last bdrv_aio_*() user in quorum. > > Signed-off-by: Kevin Wolf > --- > block/quorum.c | 52 +-

[Qemu-devel] [PULL for-2.8 0/2] target-alpha update

2016-11-17 Thread Richard Henderson
309cf: Update version for v2.8.0-rc0 release (2016-11-15 20:55:12 +) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-axp-20161117 for you to fetch changes up to 022f52e040807363213c8752ce61a7d0f57e3078: target-alpha: Log cpuid with -d int (2016-11-17 15:

[Qemu-devel] [PULL for-2.8 2/2] target-alpha: Log cpuid with -d int

2016-11-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-alpha/helper.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target-alpha/helper.c b/target-alpha/helper.c index 2ef6cbe..a5c3088 100644 --- a/target-alpha/helper.c +++ b/target-alpha/helper.c @@ -307,8 +307,10 @@ void alpha_

Re: [Qemu-devel] [PATCH v1] qemu: command: rework cpu feature argument support

2016-11-17 Thread Markus Armbruster
Eduardo Habkost writes: > CCing qemu-devel. > > CCing Markus, in case he has any insights about the interface > introspection. > > On Tue, Nov 15, 2016 at 08:42:12AM +0100, Jiri Denemark wrote: >> On Mon, Nov 14, 2016 at 18:02:29 -0200, Eduardo Habkost wrote: >> > On Mon, Nov 14, 2016 at 02:26:03

[Qemu-devel] [PULL 1/1] ivshmem: Fix 64 bit memory bar configuration

2016-11-17 Thread Marc-André Lureau
From: Zhuang Yanying Device ivshmem property use64=0 is designed to make the device expose a 32 bit shared memory BAR instead of 64 bit one. The default is a 64 bit BAR, except pc-1.2 and older retain a 32 bit BAR. A 32 bit BAR can support only up to 1 GiB of shared memory. This worked as desi

[Qemu-devel] [PULL 0/1] ivshmem fix for 2.8

2016-11-17 Thread Marc-André Lureau
The following changes since commit b0bcc86d2a87456f5a276f941dc775b265b309cf: Update version for v2.8.0-rc0 release (2016-11-15 20:55:12 +) are available in the git repository at: g...@github.com:elmarco/qemu.git tags/ivshmem-pull-request for you to fetch changes up to b2b79a696052040389

Re: [Qemu-devel] [PATCH] tftp: fake support for netascii protocol

2016-11-17 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] tftp: fake support for netascii protocol Type: series Message-id: 20161117122000.22577-1-vincent.ber...@exoscale.ch === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v14 12/22] vfio: Add notifier callback to parent's ops structure of mdev

2016-11-17 Thread Alex Williamson
On Thu, 17 Nov 2016 20:35:38 +0800 Jike Song wrote: > On 11/17/2016 04:46 AM, Kirti Wankhede wrote: > > Add a notifier calback to parent's ops structure of mdev device so that per > > device notifer for vfio module is registered through vfio_mdev module. > > > > Signed-off-by: Kirti Wankhede >

Re: [Qemu-devel] [RFC PATCH 7/8] quorum: Implement .bdrv_co_preadv/pwritev()

2016-11-17 Thread Alberto Garcia
On Fri 11 Nov 2016 10:58:57 AM CET, Kevin Wolf wrote: >> > Note that the QMP events emitted by the driver are an external API >> > that we were careless enough to define as sector based. The offset >> > and length of requests reported in events are rounded down >> > therefore. >> >> Would it be b

Re: [Qemu-devel] [PATCH 0/4] Add support for the Epson RX8900 RTC to the aspeed board

2016-11-17 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH 0/4] Add support for the Epson RX8900 RTC to the aspeed board Type: series Message-id: 147935740

  1   2   3   >