On Thu, 17 Nov 2016 10:58:30 +0000 Stefan Hajnoczi <stefa...@gmail.com> wrote:
> On Thu, Nov 17, 2016 at 09:31:18AM +0100, Cornelia Huck wrote: > > On Wed, 16 Nov 2016 21:53:07 +0000 > > Stefan Hajnoczi <stefa...@redhat.com> wrote: > > > > > virtio_queue_notify_vq() checks vdev->broken before invoking the > > > handler, virtio_queue_notify_aio_vq() should too. > > > > > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > > > --- > > > hw/virtio/virtio.c | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com> > > > > I think this makes sense as a fix independent of your other patches. > > I'm not aware of an actual bug caused by this. virtio_queue_pop() > returns NULL when the device is broken. > > This is more for consistency than correctness, so I didn't add > qemu-stable, -rc1, or send it as a separate fix. Fair enough. It was more "we should add this patch even if we don't use the other patches in this series".
