Cao jin <caoj.f...@cn.fujitsu.com> writes: > usb_xhci_realize() corrects invalid values of property "intrs" > automatically, but the uncorrected value is passed to msi_init(), > which chokes on invalid values. Delay that until after the > correction. > > Resources allocated by usb_xhci_init() are leaked when msi_init() > fails. Fix by calling it after msi_init(). > > CC: Gerd Hoffmann <kra...@redhat.com> > CC: Markus Armbruster <arm...@redhat.com> > CC: Marcel Apfelbaum <mar...@redhat.com> > CC: Michael S. Tsirkin <m...@redhat.com> > Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com> > --- > In previous rounds, usb_xhci_init() is moved too far from its original place, > which results the segfault(XHCIState->numports is initialized in this func), > now move it adjacent to msi_init code hunk.
Thanks for explaining what you changed. Reviewed-by: Markus Armbruster <arm...@redhat.com>
