[Qemu-devel] build failures in master

2016-11-02 Thread Olaf Hering
Not sure if there are automated build tests to catch such mistakes, these errors appeared after qemu-20161028T142950.fd209e4: [ 337s] ../hw/xen/xen_pvdev.o: In function `xen_pv_printf': [ 337s] /home/abuild/rpmbuild/BUILD/qemu-20161101T165305.4eb28ab/hw/xen/xen_pvdev.c:220: undefined reference

[Qemu-devel] [PATCH v2 0/4] xed: add qdevs for each backend, correct pvUSB

2016-11-02 Thread Juergen Gross
Trying to use pvUSB in a Xen guest with a qemu emulated USB controller will crash qemu as it tries to attach a pvUSB device to the emulated controller. This can be avoided by adding a unique id to each pvUSB controller which can be used when attaching the pvUSB device. In order to make this possib

[Qemu-devel] [PATCH v2 3/4] xen: create qdev for each backend device

2016-11-02 Thread Juergen Gross
Create a qdev plugged to the xen-sysbus for each new backend device. This device can be used as a parent for all needed devices of that backend. The id of the new device will be "xen--" with being the xen backend type (e.g. "qdisk") and the xen backend number of the type under which it is to be f

[Qemu-devel] [PATCH v2 4/4] xen: attach pvusb usb bus to backend qdev

2016-11-02 Thread Juergen Gross
Attach the usb bus of a new pvusb controller to the qdev associated with the Xen backend. Any device connected to that controller can now specify the bus and port directly via its properties. Signed-off-by: Juergen Gross --- hw/usb/xen-usb.c | 23 ++- 1 file changed, 10 inser

Re: [Qemu-devel] [PATCH] migration: fix missing assignment for has_x_checkpoint_delay

2016-11-02 Thread Hailiang Zhang
On 2016/11/1 22:27, Eric Blake wrote: On 11/01/2016 12:50 AM, zhanghailiang wrote: We forgot to assign true to params->has_x_checkpoint_delay parameter in qmp_query_migrate_parameters. Without this, qmp command 'query-migrate-parameters' doesn't show the default value for x-checkpoint-delay opt

[Qemu-devel] [PATCH v2 2/4] qdev: add function qdev_set_id()

2016-11-02 Thread Juergen Gross
In order to have an easy way to add a new qdev with a specific id carve out the needed functionality from qdev_device_add() into a new function qdev_set_id(). Signed-off-by: Juergen Gross --- include/monitor/qdev.h | 1 + qdev-monitor.c | 36 2 files

[Qemu-devel] [PATCH v2 1/4] xen: add an own bus for xen backend devices

2016-11-02 Thread Juergen Gross
Add a bus for Xen backend devices in order to be able to establish a dedicated device path for pluggable devices. Signed-off-by: Juergen Gross --- hw/xen/xen_backend.c | 19 --- include/hw/xen/xen_backend.h | 4 2 files changed, 20 insertions(+), 3 deletions(-) dif

Re: [Qemu-devel] [PATCH 1/1] migration: fix compiler warning on uninitialized variable

2016-11-02 Thread Mark Cave-Ayland
On 31/10/16 21:50, Jeff Cody wrote: > Some older GCC versions (e.g. 4.4.7) report a warning on an > uninitialized variable for 'request', even though all possible code > paths that reference 'request' will be initialized. To appease > these versions, initialize the variable to 0. > > Reported-b

[Qemu-devel] [PATCH v2] migration: fix missing assignment for has_x_checkpoint_delay

2016-11-02 Thread zhanghailiang
We forgot to assign true to params->has_x_checkpoint_delay parameter in qmp_query_migrate_parameters. Without this, qmp command 'query-migrate-parameters' doesn't show the default value for x-checkpoint-delay option. This also fixes the fact that HMP was relying on unspecified behavior by reading

[Qemu-devel] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

2016-11-02 Thread zhanghailiang
VM can not get into colo state unless users enable 'x-colo' capability for migration, Here it is necessary to clarify this. Suggested-by: Eric Blake Signed-off-by: zhanghailiang --- v2: - Clarify colo state for RunState too as Eric suggested. --- qapi-schema.json | 8 +--- 1 file changed, 5

Re: [Qemu-devel] [PATCH v10 18/19] docs: Sysfs ABI for mediated device framework

2016-11-02 Thread Kirti Wankhede
On 10/31/2016 12:49 PM, Jike Song wrote: > On 10/27/2016 05:29 AM, Kirti Wankhede wrote: >> Added details of sysfs ABI for mediated device framework >> >> Signed-off-by: Kirti Wankhede >> Signed-off-by: Neo Jia >> Change-Id: Icb0fd4ed58a2fa793fbcb1c3d5009a4403c1f3ac >> --- >> Documentation/ABI

Re: [Qemu-devel] [PATCH v10 01/19] vfio: Mediated device Core driver

2016-11-02 Thread Kirti Wankhede
On 10/29/2016 11:41 PM, Jike Song wrote: > On 10/29/2016 06:06 PM, Kirti Wankhede wrote: >> >> >> On 10/29/2016 10:00 AM, Jike Song wrote: >>> On 10/27/2016 05:29 AM, Kirti Wankhede wrote: +int mdev_register_device(struct device *dev, const struct parent_ops *ops) +{ + int ret; >>

Re: [Qemu-devel] [PATCH v10 07/19] vfio iommu type1: Update argument of vaddr_get_pfn()

2016-11-02 Thread Kirti Wankhede
On 10/28/2016 11:31 AM, Jike Song wrote: > On 10/27/2016 08:24 PM, Kirti Wankhede wrote: >> >> >> On 10/27/2016 5:41 PM, Jike Song wrote: >>> On 10/27/2016 05:29 AM, Kirti Wankhede wrote: Update arguments of vaddr_get_pfn() to take struct mm_struct *mm as input argument. Signe

Re: [Qemu-devel] build failures in master

2016-11-02 Thread Thomas Huth
On 02.11.2016 08:03, Olaf Hering wrote: > Not sure if there are automated build tests to catch such mistakes, > these errors appeared after qemu-20161028T142950.fd209e4: > > [ 337s] ../hw/xen/xen_pvdev.o: In function `xen_pv_printf': > [ 337s] > /home/abuild/rpmbuild/BUILD/qemu-20161101T165305.

Re: [Qemu-devel] build failures in master

2016-11-02 Thread Thomas Huth
On 02.11.2016 09:14, Thomas Huth wrote: > On 02.11.2016 08:03, Olaf Hering wrote: >> Not sure if there are automated build tests to catch such mistakes, >> these errors appeared after qemu-20161028T142950.fd209e4: >> >> [ 337s] ../hw/xen/xen_pvdev.o: In function `xen_pv_printf': >> [ 337s] >> /h

[Qemu-devel] [PULL 07/30] exec.c: check memory backend file size with 'size' option

2016-11-02 Thread Paolo Bonzini
From: Haozhong Zhang If the memory backend file is not large enough to hold the required 'size', Qemu will report error and exit. Signed-off-by: Haozhong Zhang Message-Id: <20161027042300.5929-3-haozhong.zh...@intel.com> Reviewed-by: Eduardo Habkost Message-Id: <20161102010551.2723-1-haozhong.

[Qemu-devel] [PULL v3 00/30] Misc patches for 2016-10-31

2016-11-02 Thread Paolo Bonzini
The following changes since commit 39542105bbb19c690219d2f22844d8dfbd9bba05: Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging (2016-11-01 12:48:07 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch

Re: [Qemu-devel] build failures in master

2016-11-02 Thread Gerd Hoffmann
On Mi, 2016-11-02 at 08:03 +0100, Olaf Hering wrote: > Not sure if there are automated build tests to catch such mistakes, I do test builds with both gtk2 and gtk3 before pull req goes out. > [ 220s] ui/gtk.c: In function 'gd_text_key_down': > [ 220s] ui/gtk.c:1073: error: 'GDK_KEY_Delete' unde

[Qemu-devel] [PATCH] sparc: Add slavio_misc.c and eccmemctl.c to the MAINTAINERS file

2016-11-02 Thread Thomas Huth
Both files seem to belong to the Sun4m machine. Signed-off-by: Thomas Huth --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b0712a8..79484ed 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -710,6 +710,8 @@ S: Maintained F: hw/sparc/sun4m.c F:

Re: [Qemu-devel] build failures in master

2016-11-02 Thread Olaf Hering
On Wed, Nov 02, Thomas Huth wrote: > Does it work if you add an explicit #include "qemu/log.h" at the > beginning of that file (after osdep.h)? I will try that. > system. Which version of GTK are you using? 2.18.9 as included in SLE11. Olaf signature.asc Description: PGP signature

Re: [Qemu-devel] build failures in master

2016-11-02 Thread Gerd Hoffmann
On Mi, 2016-11-02 at 09:26 +0100, Thomas Huth wrote: > On 02.11.2016 09:14, Thomas Huth wrote: > > On 02.11.2016 08:03, Olaf Hering wrote: > >> Not sure if there are automated build tests to catch such mistakes, > >> these errors appeared after qemu-20161028T142950.fd209e4: > >> > >> [ 337s] ../hw

[Qemu-devel] [PATCH] m68k: Add include/hw/m68k/ and disas/m68k.c to the MAINTAINERS file

2016-11-02 Thread Thomas Huth
The include/hw/m68k/ folder and disas/m68k.c obviously belong to the m68k section in the MAINTAINERS file. Signed-off-by: Thomas Huth --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 79484ed..5d45160 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

Re: [Qemu-devel] [PATCH] sparc: Add slavio_misc.c and eccmemctl.c to the MAINTAINERS file

2016-11-02 Thread Paolo Bonzini
On 02/11/2016 09:37, Thomas Huth wrote: > Both files seem to belong to the Sun4m machine. > > Signed-off-by: Thomas Huth > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index b0712a8..79484ed 100644 > --- a/MAINTAINERS > +++ b/MAINTAI

Re: [Qemu-devel] [PATCH] m68k: Add include/hw/m68k/ and disas/m68k.c to the MAINTAINERS file

2016-11-02 Thread Laurent Vivier
Le 02/11/2016 à 09:42, Thomas Huth a écrit : > The include/hw/m68k/ folder and disas/m68k.c obviously belong to > the m68k section in the MAINTAINERS file. > > Signed-off-by: Thomas Huth > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS >

Re: [Qemu-devel] [PATCH] sparc: Add slavio_misc.c and eccmemctl.c to the MAINTAINERS file

2016-11-02 Thread Thomas Huth
On 02.11.2016 09:50, Paolo Bonzini wrote: > > > On 02/11/2016 09:37, Thomas Huth wrote: >> Both files seem to belong to the Sun4m machine. >> >> Signed-off-by: Thomas Huth >> --- >> MAINTAINERS | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index b071

Re: [Qemu-devel] [PATCH] pci_aer_init: cleanup

2016-11-02 Thread Cao jin
ping On 10/13/2016 10:32 AM, Cao jin wrote: log_max have no chance to be PCIE_AER_LOG_MAX_UNSET, unless user specify it. Bonus: 1. remove unnecessary local variable. 2. fix a typo. Signed-off-by: Cao jin --- hw/pci/pcie_aer.c | 10 +- include/hw/pci/pcie_aer.h | 2 +- 2 f

Re: [Qemu-devel] build failures in master

2016-11-02 Thread Olaf Hering
On Wed, Nov 02, Olaf Hering wrote: > On Wed, Nov 02, Thomas Huth wrote: > > Does it work if you add an explicit #include "qemu/log.h" at the > > beginning of that file (after osdep.h)? > I will try that. Yes, that helps. Thanks. Olaf signature.asc Description: PGP signature

Re: [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses

2016-11-02 Thread Cornelia Huck
On Mon, 31 Oct 2016 16:39:29 +0100 Samuel Thibault wrote: > Cornelia Huck, on Mon 31 Oct 2016 14:08:48 +0100, wrote: > > On Mon, 31 Oct 2016 15:03:33 +0100 > > Samuel Thibault wrote: > > > > > Cornelia Huck, on Mon 31 Oct 2016 13:48:01 +0100, wrote: > > > > On Mon, 31 Oct 2016 13:39:30 +0100 >

Re: [Qemu-devel] [PATCH v2 01/11] qapi: add qapi2texi script

2016-11-02 Thread Marc-André Lureau
Hi On Fri, Oct 28, 2016 at 7:45 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > As the name suggests, the qapi2texi script converts JSON QAPI > > description into a standalone texi file suitable for different target > > formats. > > > > It parses the following kind of blocks with

Re: [Qemu-devel] [PATCH] vl.c: move pidfile creation up

2016-11-02 Thread Markus Armbruster
Michael Tokarev writes: > With current code, pid file is open after various > sockets, chardevs, fsdevs and the like. This causes > interesting effects, for example when monitor is a > unix-socket, and another qemu instance is already > running, new qemu first "damages" the socket and > next com

Re: [Qemu-devel] pci-assign fails with read error on config-space file

2016-11-02 Thread Henning Schild
Am Fri, 28 Oct 2016 17:22:41 +0200 schrieb Laszlo Ersek : > On 10/28/16 13:28, Henning Schild wrote: > > Hey, > > > > i am running an unusual setup where i assign pci devices behind the > > back of libvirt. I have two options to do that: > > 1. a wrapper script for qemu that takes care of suid-ro

[Qemu-devel] [PATCH v2] block/nbd: Fix the regression to free leaked visitor

2016-11-02 Thread Ashijeet Acharya
This patch frees the leaked visitor in nbd_refresh_filename() and uses visit_free() to fix it. The leak was introduced by the commit 491d6c7. Signed-off-by: Ashijeet Acharya Reviewed-by: Eric Blake --- Changes in v2: - Include the regression commit id in the commit message --- block/nbd.c | 1 +

Re: [Qemu-devel] pci-assign fails with read error on config-space file

2016-11-02 Thread Daniel P. Berrange
On Fri, Oct 28, 2016 at 01:28:19PM +0200, Henning Schild wrote: > Hey, > > i am running an unusual setup where i assign pci devices behind the > back of libvirt. I have two options to do that: > 1. a wrapper script for qemu that takes care of suid-root and appends > arguments for pci-assign > 2. v

Re: [Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-11-02 Thread Kevin Wolf
Am 01.11.2016 um 05:03 hat ashish mittal geschrieben: > >> >> +## > >> >> +{ 'struct': 'BlockdevOptionsVxHS', > >> >> + 'data': { 'vdisk_id': 'str', > >> >> +'server': 'InetSocketAddress' } } > >> > > >> > Is there any way to use a Unix socket, or is this server ONLY accessible > >> >

[Qemu-devel] [PATCH] ui/gtk: Fix build with older versions of gtk

2016-11-02 Thread Thomas Huth
GDK_KEY_Delete is only defined with gtk version 2.22 and newer, on older versions this key was called GDK_Delete instead. Since this is the case for all GDK_KEY_* defines, change the already existing preprocessor check there to test for version 2.22, so we know that we can remove this code block in

Re: [Qemu-devel] [PATCH] pci_aer_init: cleanup

2016-11-02 Thread Marcel Apfelbaum
On 10/13/2016 05:32 AM, Cao jin wrote: log_max have no chance to be PCIE_AER_LOG_MAX_UNSET, unless user specify it. Hi, Bonus: 1. remove unnecessary local variable. 2. fix a typo. Signed-off-by: Cao jin --- hw/pci/pcie_aer.c | 10 +- include/hw/pci/pcie_aer.h | 2 +- 2 f

Re: [Qemu-devel] [PATCH] ui/gtk: Fix build with older versions of gtk

2016-11-02 Thread Daniel P. Berrange
On Wed, Nov 02, 2016 at 11:08:48AM +0100, Thomas Huth wrote: > GDK_KEY_Delete is only defined with gtk version 2.22 and newer, > on older versions this key was called GDK_Delete instead. > Since this is the case for all GDK_KEY_* defines, change the > already existing preprocessor check there to te

[Qemu-devel] [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()

2016-11-02 Thread Thomas Huth
Olaf Hering reported a build failure due to an undefined reference to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to fix the issue. Signed-off-by: Thomas Huth --- hw/xen/xen_pvdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xen/xen_pvdev.c b/hw/xen/xen

Re: [Qemu-devel] [PATCH v2] block/nbd: Fix the regression to free leaked visitor

2016-11-02 Thread Kevin Wolf
Am 02.11.2016 um 10:48 hat Ashijeet Acharya geschrieben: > This patch frees the leaked visitor in nbd_refresh_filename() and uses > visit_free() to fix it. The leak was introduced by the commit 491d6c7. > > Signed-off-by: Ashijeet Acharya > Reviewed-by: Eric Blake I don't think this would gener

Re: [Qemu-devel] [PATCH] block/ssh: Fix the regression of unused parameter

2016-11-02 Thread Kevin Wolf
Am 31.10.2016 um 19:06 hat Ashijeet Acharya geschrieben: > This patch drops the unused parameter "BDRVSSHState" being passed into > the ssh_config() function and fixes the bug. > > Signed-off-by: Ashijeet Acharya The patch looks good, but why do claim that this is a bug fix rather than just a co

Re: [Qemu-devel] [PATCH v2] block/nbd: Fix the regression to free leaked visitor

2016-11-02 Thread Ashijeet Acharya
On Wed, Nov 2, 2016 at 4:00 PM, Kevin Wolf wrote: > Am 02.11.2016 um 10:48 hat Ashijeet Acharya geschrieben: >> This patch frees the leaked visitor in nbd_refresh_filename() and uses >> visit_free() to fix it. The leak was introduced by the commit 491d6c7. >> >> Signed-off-by: Ashijeet Acharya >>

Re: [Qemu-devel] [libvirt-users] pci-assign fails with read error on config-space file

2016-11-02 Thread Henning Schild
Am Fri, 28 Oct 2016 11:25:55 -0400 schrieb Laine Stump : > On 10/28/2016 07:28 AM, Henning Schild wrote: > > Hey, > > > > i am running an unusual setup where i assign pci devices behind the > > back of libvirt. I have two options to do that: > > 1. a wrapper script for qemu that takes care of suid

Re: [Qemu-devel] [PATCH] block/ssh: Fix the regression of unused parameter

2016-11-02 Thread Ashijeet Acharya
On Wed, Nov 2, 2016 at 4:03 PM, Kevin Wolf wrote: > Am 31.10.2016 um 19:06 hat Ashijeet Acharya geschrieben: >> This patch drops the unused parameter "BDRVSSHState" being passed into >> the ssh_config() function and fixes the bug. >> >> Signed-off-by: Ashijeet Acharya > > The patch looks good, bu

Re: [Qemu-devel] [PATCH v10 01/19] vfio: Mediated device Core driver

2016-11-02 Thread Jike Song
On 11/02/2016 03:59 PM, Kirti Wankhede wrote: > On 10/29/2016 11:41 PM, Jike Song wrote: >> On 10/29/2016 06:06 PM, Kirti Wankhede wrote: >>> >>> >>> On 10/29/2016 10:00 AM, Jike Song wrote: On 10/27/2016 05:29 AM, Kirti Wankhede wrote: > +int mdev_register_device(struct device *dev, const

Re: [Qemu-devel] [QEMU PATCH v10 1/3] migration: extend VMStateInfo

2016-11-02 Thread Juan Quintela
Jianjun Duan wrote: > Current migration code cannot handle some data structures such as > QTAILQ in qemu/queue.h. Here we extend the signatures of put/get > in VMStateInfo so that customized handling is supported. > > Signed-off-by: Jianjun Duan > +/* VMStateInfo allows customized migration of o

[Qemu-devel] [PATCH v3] block/nbd: Fix the leaked visitor

2016-11-02 Thread Ashijeet Acharya
This patch frees the leaked visitor in nbd_refresh_filename() and uses visit_free() to fix it. The leak was introduced by the commit 491d6c7. Signed-off-by: Ashijeet Acharya Reviewed-by: Eric Blake --- Changes in v3: - Modify the Subject line - Free the visitor immediately after visit_complete()

Re: [Qemu-devel] [PATCH v10 03/19] vfio: Rearrange functions to get vfio_group from dev

2016-11-02 Thread Jike Song
On 10/27/2016 05:29 AM, Kirti Wankhede wrote: > This patch rearranges functions to get vfio_group from device > > Signed-off-by: Kirti Wankhede > Signed-off-by: Neo Jia > Change-Id: I1f93262bdbab75094bc24b087b29da35ba70c4c6 > --- > drivers/vfio/vfio.c | 23 --- > 1 file chan

Re: [Qemu-devel] [PATCH v10 02/19] vfio: VFIO based driver for Mediated devices

2016-11-02 Thread Jike Song
On 10/27/2016 05:29 AM, Kirti Wankhede wrote: > vfio_mdev driver registers with mdev core driver. > mdev core driver creates mediated device and calls probe routine of > vfio_mdev driver for each device. > Probe routine of vfio_mdev driver adds mediated device to VFIO core module > > This driver f

Re: [Qemu-devel] [QEMU PATCH v10 2/3] migration: migrate QTAILQ

2016-11-02 Thread Juan Quintela
Jianjun Duan wrote: > Currently we cannot directly transfer a QTAILQ instance because of the > limitation in the migration code. Here we introduce an approach to > transfer such structures. We created VMStateInfo vmstate_info_qtailq > for QTAILQ. Similar VMStateInfo can be created for other data s

Re: [Qemu-devel] [PATCH v5 11/17] ppc/xics: Add "native" XICS subclass

2016-11-02 Thread Cédric Le Goater
On 10/28/2016 03:00 AM, David Gibson wrote: > On Thu, Oct 27, 2016 at 07:43:10PM +0200, Cédric Le Goater wrote: >> On 10/27/2016 05:09 AM, David Gibson wrote: >>> On Wed, Oct 26, 2016 at 09:13:18AM +0200, Cédric Le Goater wrote: On 10/25/2016 07:08 AM, David Gibson wrote: > On Sat, Oct 22,

Re: [Qemu-devel] [QEMU PATCH v10 3/3] tests/migration: Add test for QTAILQ migration

2016-11-02 Thread Juan Quintela
Jianjun Duan wrote: > Add a test for QTAILQ migration to tests/test-vmstate.c. > > Signed-off-by: Jianjun Duan Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH 2/3] block: Emit modules in bdrv_iterate_format()

2016-11-02 Thread Hao QingFeng
在 2016-10-13 4:49, Max Reitz 写道: Some block drivers may not be loaded yet, but qemu supports them nonetheless. bdrv_iterate_format() should report them, too. Signed-off-by: Max Reitz --- block.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/block.c b/block.c index

Re: [Qemu-devel] [PATCH v3] block/nbd: Fix the leaked visitor

2016-11-02 Thread Kevin Wolf
Am 02.11.2016 um 11:40 hat Ashijeet Acharya geschrieben: > This patch frees the leaked visitor in nbd_refresh_filename() and uses > visit_free() to fix it. The leak was introduced by the commit 491d6c7. > > Signed-off-by: Ashijeet Acharya > Reviewed-by: Eric Blake Thanks, applied to the block b

Re: [Qemu-devel] when we add EL2 to QEMU TCG ARM emulation and the virt board, should it default on or off?

2016-11-02 Thread Edgar E. Iglesias
On Tue, Nov 01, 2016 at 05:16:59PM +, Peter Maydell wrote: > I'm working on turning on EL2 support in our TCG ARM emulation, > and one area I'm not sure about is whether it should default to > on or off. > > We have a few precedents: > > For EL3 support: > * the CPU property is enabled by de

[Qemu-devel] [PATCH v2] block/ssh: Code cleanup for unused parameter

2016-11-02 Thread Ashijeet Acharya
This patch drops the unused parameter "BDRVSSHState" being passed into the ssh_config() function and does code cleanup. The unused parameter was introduced by the commit c322712. Signed-off-by: Ashijeet Acharya --- Changes in v2: - Modify the commit message and subject line --- block/ssh.c | 5 +

Re: [Qemu-devel] [PATCH 1/2] virtio/migration: Add VMStateDescription to VirtioDeviceClass

2016-11-02 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Provide a vmsd pointer for VirtIO devices to use instead of the > load/save methods. > > We'll eventually kill off the load/save methods. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela

Re: [Qemu-devel] ping Re: [PATCH 00/18] Dirty bitmaps postcopy migration

2016-11-02 Thread Stefan Hajnoczi
On Tue, Oct 25, 2016 at 04:04:35PM +0300, Vladimir Sementsov-Ogievskiy wrote: > ping > > For now there are some notes mostly about accessory patches. What about > migration itself? Is it ok? Has it a chance of being merged one day? This series mostly touches migration/ code. Juan or DaveG? > 16

Re: [Qemu-devel] [PATCH 2/2] virtio/migration: Migrate balloon to VMState

2016-11-02 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Replace the load/save with a vmsd. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH 2/3] block: Emit modules in bdrv_iterate_format()

2016-11-02 Thread Kevin Wolf
Am 02.11.2016 um 11:52 hat Hao QingFeng geschrieben: > Sorry for a bit late response. The function looks fine but just some > doubt on g_renew in this piece of code(and the legacy), does > g_renew(realloc) has much performance impact if it's call many times > since alloc and memory copy are both al

Re: [Qemu-devel] [PATCH v2] block/ssh: Code cleanup for unused parameter

2016-11-02 Thread Kevin Wolf
Am 02.11.2016 um 11:53 hat Ashijeet Acharya geschrieben: > This patch drops the unused parameter "BDRVSSHState" being passed into > the ssh_config() function and does code cleanup. The unused parameter > was introduced by the commit c322712. > > Signed-off-by: Ashijeet Acharya Thanks, applied to

Re: [Qemu-devel] [PULL 39/47] pc: memhp: enable nvdimm device hotplug

2016-11-02 Thread Igor Mammedov
On Sun, 30 Oct 2016 23:25:10 +0200 "Michael S. Tsirkin" wrote: > From: Xiao Guangrong > > _GPE.E04 is dedicated for nvdimm device hotplug > > Signed-off-by: Xiao Guangrong > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin > --- > include/hw/acpi/acpi_dev_interface.h |

Re: [Qemu-devel] [PATCH v3 4/4] pc: memhp: enable nvdimm device hotplug

2016-11-02 Thread Igor Mammedov
On Sat, 29 Oct 2016 00:35:40 +0800 Xiao Guangrong wrote: > _GPE.E04 is dedicated for nvdimm device hotplug > > Signed-off-by: Xiao Guangrong > --- > docs/specs/acpi_mem_hotplug.txt | 3 +++ > hw/acpi/memory_hotplug.c | 31 +++ > hw/i386/acpi-build.

Re: [Qemu-devel] [PATCH] m68k: Add include/hw/m68k/ and disas/m68k.c to the MAINTAINERS file

2016-11-02 Thread Thomas Huth
On 02.11.2016 09:51, Laurent Vivier wrote: > > Le 02/11/2016 à 09:42, Thomas Huth a écrit : >> The include/hw/m68k/ folder and disas/m68k.c obviously belong to >> the m68k section in the MAINTAINERS file. >> >> Signed-off-by: Thomas Huth >> --- >> MAINTAINERS | 2 ++ >> 1 file changed, 2 inserti

Re: [Qemu-devel] [RFC PATCH 1/4] tests/test-vmstate.c: add save_buffer util func

2016-11-02 Thread Juan Quintela
Halil Pasic wrote: > Let us de-duplicate some code by introducing an utility function for > saving a chunk of bytes (used when testing load based on wire). > > Signed-off-by: Halil Pasic > Reviewed-by: Guenther Hutzl Reviewed-by: Juan Quintela Included. Trivial enough.

Re: [Qemu-devel] [PATCH v10 04/19] vfio: Common function to increment container_users

2016-11-02 Thread Jike Song
On 10/27/2016 05:29 AM, Kirti Wankhede wrote: > This change rearrange functions to have common function to increment > container_users > > Signed-off-by: Kirti Wankhede > Signed-off-by: Neo Jia > Change-Id: I8bdeb352bc8439b107ffd519480fd4dc238677f2 > --- > drivers/vfio/vfio.c | 34 +

Re: [Qemu-devel] pci-assign fails with read error on config-space file

2016-11-02 Thread Henning Schild
Am Wed, 2 Nov 2016 09:54:16 + schrieb "Daniel P. Berrange" : > On Fri, Oct 28, 2016 at 01:28:19PM +0200, Henning Schild wrote: > > Hey, > > > > i am running an unusual setup where i assign pci devices behind the > > back of libvirt. I have two options to do that: > > 1. a wrapper script for q

[Qemu-devel] [Bug 1636217] Re: qemu-kvm 2.7 does not boot kvm VMs with virtio on top of VMware ESX

2016-11-02 Thread MartinSteigerwald
I confirm that "qm set ID -machine pc-i440fx-2.6" on the machine in question lets it boot as a virtio machine again with Qemu 2.7. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1636217 Title: qemu-

Re: [Qemu-devel] [PATCH 2/3] block: Emit modules in bdrv_iterate_format()

2016-11-02 Thread Hao QingFeng
在 2016-11-02 19:15, Kevin Wolf 写道: Am 02.11.2016 um 11:52 hat Hao QingFeng geschrieben: Sorry for a bit late response. The function looks fine but just some doubt on g_renew in this piece of code(and the legacy), does g_renew(realloc) has much performance impact if it's call many times since a

Re: [Qemu-devel] [PATCH v1 1/1] qemu-doc: update gluster protocol usage guide

2016-11-02 Thread Prasanna Kalever
On Tue, Nov 1, 2016 at 11:32 PM, Eric Blake wrote: > On 11/01/2016 07:29 AM, Prasanna Kumar Kalever wrote: >> Document: >> 1. The new debug and logfile options with their usages and >> 2. New json format and its usage. >> >> Signed-off-by: Prasanna Kumar Kalever >> --- >> qemu-doc.texi | 46 ++

Re: [Qemu-devel] [RFC PATCH 2/4] tests/test-vmstate.c: add array of pointer to struct

2016-11-02 Thread Juan Quintela
Halil Pasic wrote: > Increase test coverage by adding tests for the macro > VMSTATE_ARRAY_OF_POINTER_TO_STRUCT. > > Signed-off-by: Halil Pasic > Reviewed-by: Guenther Hutzl Reviewed-by: Juan Quintela Included

Re: [Qemu-devel] ping Re: [PATCH 00/18] Dirty bitmaps postcopy migration

2016-11-02 Thread Denis V. Lunev
On 11/02/2016 02:13 PM, Stefan Hajnoczi wrote: > On Tue, Oct 25, 2016 at 04:04:35PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> ping >> >> For now there are some notes mostly about accessory patches. What about >> migration itself? Is it ok? Has it a chance of being merged one day? > This series

Re: [Qemu-devel] [PATCH 0/4] target-m68k areg writeback

2016-11-02 Thread Laurent Vivier
Le 01/11/2016 à 22:29, Richard Henderson a écrit : > Here's the patch I almost wrote in the email, followed by > a cleanup that allows cmpm to be written "nicely". > > I can test this to some extent with the coldfire kernel, > but of course coldfire can't excersise any of the tricky > edge cases

Re: [Qemu-devel] [PATCH v2 00/11] qapi doc generation (whole version, squashed)

2016-11-02 Thread Markus Armbruster
Markus Armbruster writes: > Marc-André Lureau writes: > >> Hi, >> >> Add a qapi2texi script to generate the documentation from the qapi >> schemas. Build various new documentation targets for it: pdf, man, >> txt. The 7th patch in this series is a squashed version of the >> documentation move fr

[Qemu-devel] [PATCH v2 1/1] qemu-doc: update gluster protocol usage guide

2016-11-02 Thread Prasanna Kumar Kalever
Document: 1. The new debug and logfile options with their usages 2. New json format and its usage and 3. update "GlusterFS, Device URL Syntax" section in "Invocation" Signed-off-by: Prasanna Kumar Kalever --- v2: Address review comments by Eric Blake on v1 Mostly grammar related changes, form

Re: [Qemu-devel] [PATCH v4 02/10] hcd-xhci: check & correct param before using it

2016-11-02 Thread Markus Armbruster
Cao jin writes: > Param checking/correcting code of xchi->numintrs should be placed before > it is used. > Also move some resource-alloc code down, save the strenth to free them > on msi_init's failure. > > CC: Gerd Hoffmann > CC: Markus Armbruster > CC: Marcel Apfelbaum > CC: Michael S. Tsirk

Re: [Qemu-devel] [PATCH v2 1/1] qemu-doc: update gluster protocol usage guide

2016-11-02 Thread Prasanna Kalever
On Wed, Nov 2, 2016 at 5:46 PM, Prasanna Kumar Kalever wrote: > Document: > 1. The new debug and logfile options with their usages > 2. New json format and its usage and > 3. update "GlusterFS, Device URL Syntax" section in "Invocation" > > Signed-off-by: Prasanna Kumar Kalever > --- > v2: Addres

Re: [Qemu-devel] [PATCH v9 04/12] vfio iommu: Add support for mediated devices

2016-11-02 Thread Jike Song
On 11/02/2016 12:09 PM, Alexey Kardashevskiy wrote: > On 02/11/16 14:29, Kirti Wankhede wrote: >> >> >> On 11/2/2016 6:54 AM, Alexey Kardashevskiy wrote: >>> On 02/11/16 01:01, Kirti Wankhede wrote: On 10/28/2016 7:48 AM, Alexey Kardashevskiy wrote: > On 27/10/16 23:31, Kirti Wan

Re: [Qemu-devel] [PATCH v4 10/10] msi_init: convert assert to return -errno

2016-11-02 Thread Markus Armbruster
Cao jin writes: > According to the disscussion: > http://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg08215.html > > Let leaf function returns reasonable -errno, let caller decide how to > handle the return value. > > Suggested-by: Markus Armbruster > CC: Markus Armbruster > CC: Alex Wil

[Qemu-devel] [PATCH v2] pcie_aer: Convert pcie_aer_init to Error

2016-11-02 Thread Cao jin
When user specify invalid property aer_log_max, device should fail to create, and report appropriate message. Signed-off-by: Cao jin --- hw/net/e1000e.c| 2 +- hw/pci-bridge/ioh3420.c| 3 ++- hw/pci-bridge/xio3130_downstream.c | 3 ++- hw/pci-bridge/xio3130_ups

Re: [Qemu-devel] [PATCH v4 00/10] Convert msix_init() to error

2016-11-02 Thread Markus Armbruster
Cao jin writes: > v4 changelog > 1. add the missed comment of "errp" in the msix_init's function comment > 2. fix typo: msic --> msix > 3. fix a build failure due to "copy&paste" error, in patch >"megasas: change behaviour of msix switch" > 4. separate the issus-fix part of vmxnet3's patch >

Re: [Qemu-devel] [PATCH v9 04/12] vfio iommu: Add support for mediated devices

2016-11-02 Thread Kirti Wankhede
On 11/2/2016 5:51 PM, Jike Song wrote: > On 11/02/2016 12:09 PM, Alexey Kardashevskiy wrote: >> On 02/11/16 14:29, Kirti Wankhede wrote: >>> >>> >>> On 11/2/2016 6:54 AM, Alexey Kardashevskiy wrote: On 02/11/16 01:01, Kirti Wankhede wrote: > > > On 10/28/2016 7:48 AM, Alexey Kard

Re: [Qemu-devel] [PATCH v9 04/12] vfio iommu: Add support for mediated devices

2016-11-02 Thread Jike Song
On 11/02/2016 08:41 PM, Kirti Wankhede wrote: > On 11/2/2016 5:51 PM, Jike Song wrote: >> On 11/02/2016 12:09 PM, Alexey Kardashevskiy wrote: >>> Or you could just reference and use @mm as KVM and others do. Or there is >>> anything else you need from @current than just @mm? >>> >> >> I agree. If @

Re: [Qemu-devel] [PATCH 4/4] target-m68k: Use gen_ea_mode in cmpm

2016-11-02 Thread Laurent Vivier
Le 01/11/2016 à 22:29, Richard Henderson a écrit : > The writeback infrastructure takes care of ensuring that Ax == Ay > both uses the updated register value from Ay for Ax, and updating > the final register result twice. > > ??? Maybe squash into previous. I think the previous one should be co

Re: [Qemu-devel] [PULL 00/47] virtio, pc: fixes and features

2016-11-02 Thread Peter Maydell
On 2 November 2016 at 04:35, Michael S. Tsirkin wrote: > On Tue, Nov 01, 2016 at 03:22:01PM +, Peter Maydell wrote: >> On 30 October 2016 at 21:23, Michael S. Tsirkin wrote: >> > The following changes since commit >> > 5b2ecabaeabc17f032197246c4846b9ba95ba8a6: >> > >> > Merge remote-tracki

Re: [Qemu-devel] [PATCH v9 04/12] vfio iommu: Add support for mediated devices

2016-11-02 Thread Kirti Wankhede
On 11/2/2016 6:30 PM, Jike Song wrote: > On 11/02/2016 08:41 PM, Kirti Wankhede wrote: >> On 11/2/2016 5:51 PM, Jike Song wrote: >>> On 11/02/2016 12:09 PM, Alexey Kardashevskiy wrote: Or you could just reference and use @mm as KVM and others do. Or there is anything else you need from

Re: [Qemu-devel] [PATCH] docs: Fix typos found by codespell

2016-11-02 Thread Eric Blake
On 11/01/2016 08:32 PM, Zhang Chen wrote: >>> I still don't understand the comment in docs/colo-proxy.txt. >> Me neither. >> >> > > Which part of the docs/colo-proxy.txt? The one quoted below. > Perhaps I can explain it more clearly and make the doc better. > >>> +++ b/docs/colo-proxy.txt >>>

Re: [Qemu-devel] [PATCH v10 09/19] vfio iommu type1: Add support for mediated devices

2016-11-02 Thread Jike Song
On 10/27/2016 05:29 AM, Kirti Wankhede wrote: > VFIO IOMMU drivers are designed for the devices which are IOMMU capable. > Mediated device only uses IOMMU APIs, the underlying hardware can be > managed by an IOMMU domain. > > Aim of this change is: > - To use most of the code of TYPE1 IOMMU driver

Re: [Qemu-devel] [PATCH v2 3/3] ahci-test: test atapi read_cd with bcl, nb_sectors = 0

2016-11-02 Thread Kevin Wolf
Am 01.11.2016 um 04:16 hat John Snow geschrieben: > Commit 9ef2e93f introduced the concept of tagging ATAPI commands as > NONDATA, but this introduced a regression for certain commands better > described as CONDDATA. read_cd is such a command that both requires > a non-zero BCL if a transfer size i

Re: [Qemu-devel] [PATCH v2 0/3] atapi: classify read_cd as conditionally returning data

2016-11-02 Thread Kevin Wolf
Am 01.11.2016 um 04:16 hat John Snow geschrieben: > v2: > - Actually applied the changes this time ... > - And added a test to the AHCI suite... > - ...Which revealed a few small issues in the suite. > > The AHCI test should be sufficient in terms of general proof > for ATAPI regardless of the

Re: [Qemu-devel] [PATCH v9 04/12] vfio iommu: Add support for mediated devices

2016-11-02 Thread Jike Song
On 11/02/2016 09:18 PM, Kirti Wankhede wrote: > On 11/2/2016 6:30 PM, Jike Song wrote: >> On 11/02/2016 08:41 PM, Kirti Wankhede wrote: >>> On 11/2/2016 5:51 PM, Jike Song wrote: On 11/02/2016 12:09 PM, Alexey Kardashevskiy wrote: > Or you could just reference and use @mm as KVM and others

[Qemu-devel] [PATCH v4 0/2] trivial changes on util/mmap-alloc

2016-11-02 Thread Cao jin
Cao jin (2): util/mmap-alloc: check parameter before using util/mmap-alloc: refactor a little bit for readability util/mmap-alloc.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) -- 2.1.0

[Qemu-devel] [PATCH v4 2/2] util/mmap-alloc: refactor a little bit for readability

2016-11-02 Thread Cao jin
1st mmap returns *ptr* which aligns to host page size, | size + align | -- ptr input param *align* could be 1M, or 2M, or host page size. After QEMU_ALIGN_UP, offset will >= 0 2nd mmap use flag MAP_FIXED, then it return p

[Qemu-devel] [PATCH v4 1/2] util/mmap-alloc: check parameter before using

2016-11-02 Thread Cao jin
Signed-off-by: Cao jin --- util/mmap-alloc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/util/mmap-alloc.c b/util/mmap-alloc.c index 5a85aa3..d713a72 100644 --- a/util/mmap-alloc.c +++ b/util/mmap-alloc.c @@ -12,6 +12,7 @@ #include "qemu/osdep.h" #include "qemu/

Re: [Qemu-devel] [PATCH v3 3/4] nvdimm acpi: introduce _FIT

2016-11-02 Thread Igor Mammedov
On Sat, 29 Oct 2016 00:35:39 +0800 Xiao Guangrong wrote: > _FIT is required for hotplug support, guest will inquire the updated > device info from it if a hotplug event is received > > As FIT buffer is not completely mapped into guest address space, so a > new function, Read FIT whose UUID is UU

Re: [Qemu-devel] [PATCH v3 0/4] nvdimm: hotplug support

2016-11-02 Thread Igor Mammedov
On Sat, 29 Oct 2016 00:35:36 +0800 Xiao Guangrong wrote: > It is based on my previous patchset, > "[PATCH 0/8] nvdimm acpi: bug fix and cleanup", these two patchset are > against commit dea651a95af6dad099 (intel-iommu: Check IOAPIC's Trigger Mode > against the one in IRTE) on pci branch of Michae

Re: [Qemu-devel] [PATCH] cpus: make qemu_mutex_iothread_locked() understand co-routines

2016-11-02 Thread Stefan Hajnoczi
On Tue, Nov 01, 2016 at 04:21:36PM +, Alex Bennée wrote: > > Paolo Bonzini writes: > > > On 21/10/2016 13:54, Alex Bennée wrote: > >> There is a slight wart when checking for the state of the BQL when using > >> GThread base co-routines (which we keep for ThreadSanitizer runs). While > >> th

Re: [Qemu-devel] when we add EL2 to QEMU TCG ARM emulation and the virt board, should it default on or off?

2016-11-02 Thread Andrew Jones
On Tue, Nov 01, 2016 at 05:16:59PM +, Peter Maydell wrote: > I'm working on turning on EL2 support in our TCG ARM emulation, > and one area I'm not sure about is whether it should default to > on or off. > > We have a few precedents: > > For EL3 support: > * the CPU property is enabled by de

Re: [Qemu-devel] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

2016-11-02 Thread Eric Blake
On 11/02/2016 02:44 AM, zhanghailiang wrote: > VM can not get into colo state unless users enable 'x-colo' > capability for migration, Here it is necessary to clarify > this. > > Suggested-by: Eric Blake > Signed-off-by: zhanghailiang > --- > v2: > - Clarify colo state for RunState too as Eric s

Re: [Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-11-02 Thread Eric Blake
On 11/02/2016 04:57 AM, Kevin Wolf wrote: >>> IMHO it should allow use of UNIX sockets, as its possible to have >>> SSH setup a tunnel to a IP server, and expose the endpoint via a >>> UNIX socket. So even if your reference server only supports IPv4, >>> users can conceivably connect with any socke

Re: [Qemu-devel] [PATCH v10 08/19] vfio iommu type1: Add find_iommu_group() function

2016-11-02 Thread Jike Song
On 10/27/2016 05:29 AM, Kirti Wankhede wrote: > Add find_iommu_group() > > Signed-off-by: Kirti Wankhede > Signed-off-by: Neo Jia > Change-Id: I9d372f1ebe9eb01a5a21374b8a2b03f7df73601f > --- > drivers/vfio/vfio_iommu_type1.c | 58 > - > 1 file changed, 3

  1   2   3   >