在 2016-10-13 4:49, Max Reitz 写道:
Some block drivers may not be loaded yet, but qemu supports them
nonetheless. bdrv_iterate_format() should report them, too.
Signed-off-by: Max Reitz <mre...@redhat.com>
---
block.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/block.c b/block.c
index e46e4b2..88a1ea5 100644
--- a/block.c
+++ b/block.c
@@ -2815,6 +2815,24 @@ void bdrv_iterate_format(void (*it)(void *opaque, const
char *name),
}
}
+ for (i = 0; i < (int)ARRAY_SIZE(block_driver_modules); i++) {
+ const char *format_name = block_driver_modules[i].format_name;
+
+ if (format_name) {
+ bool found = false;
+ int j = count;
+
+ while (formats && j && !found) {
+ found = !strcmp(formats[--j], format_name);
+ }
+
+ if (!found) {
+ formats = g_renew(const char *, formats, count + 1);
+ formats[count++] = format_name;
+ }
+ }
+ }
+
Sorry for a bit late response. The function looks fine but just some
doubt on g_renew
in this piece of code(and the legacy), does g_renew(realloc) has much
performance
impact if it's call many times since alloc and memory copy are both also
run many times?
So how about increase the memory for more instead of 1 each time?
formats = g_renew(const char *, formats, count + 10);
A new counter also needs to be introduced to record the space size.
Thanks
qsort(formats, count, sizeof(formats[0]), qsort_strcmp);
for (i = 0; i < count; i++) {
--
QingFeng Hao(Robin)
