[Qemu-devel] [PATCH v4 1/2] scripts/clean-includes: added duplicate #include check

2016-10-21 Thread Anand J
Enhance the clean-includes script to optionally check for duplicate #include entries. Script might output false positive entries as well. Such entries should not be removed. So if it finds any duplicate entries script will terminate with an exit status 1. Then each and every file should be checked

[Qemu-devel] [PATCH v4 0/2] Script changes to find duplicate #include entries

2016-10-21 Thread Anand J
There were some files in the code base with multiple inclusion of the same header files. Following changes are made to mitigate this issue. 1) --check-dup-head option is added to the scripts/clean-includes to search files and find out such entries. This will help to catch redundant #include

[Qemu-devel] [PATCH v4 2/2] clean-up: removed duplicate #includes

2016-10-21 Thread Anand J
Some files contain multiple #includes of the same header file. Removed most of those unnecessary duplicate entries using scripts/clean-includes. Reviewed-by: Thomas Huth Signed-off-by: Anand J --- accel.c | 1 - cputlb.c| 1 - gdbstub.c

[Qemu-devel] [PATCH qemu v3 3/6] balloon: get free page info from guest

2016-10-21 Thread Liang Li
Add a new feature to get the free page information from guest, the free page information is saved in a bitmap. Please note that 'free page' means page is free sometime after host set the value of request ID and before it receive response with the same ID. Signed-off-by: Liang Li --- balloon.c

[Qemu-devel] [PATCH qemu v3 2/6] virtio-balloon: speed up inflating & deflating process

2016-10-21 Thread Liang Li
The implementation of the current virtio-balloon is not very efficient, the time spends on different stages of inflating the balloon to 7GB of a 8GB idle guest: a. allocating pages (6.5%) b. sending PFNs to host (68.3%) c. address translation (6.1%) d. madvise (19%) It takes about 4126ms for the

[Qemu-devel] [PATCH qemu v3 0/6] Fast (de)inflating & fast live migration

2016-10-21 Thread Liang Li
This patch set intends to do two optimizations, one is to speed up the (de)inflating process of virtio balloon, and another one which is to speed up the live migration process. We put them together because both of them are required to change the virtio balloon spec. The main idea of speeding up t

[Qemu-devel] [PATCH qemu v3 4/6] bitmap: Add a new bitmap_move function

2016-10-21 Thread Liang Li
Sometimes, it is need to move a portion of bitmap to another place in a large bitmap, if overlap happens, the bitmap_copy can't not work correctly, we need a new function to do this work. Signed-off-by: Liang Li --- include/qemu/bitmap.h | 13 + 1 file changed, 13 insertions(+) diff

[Qemu-devel] [PATCH qemu v3 5/6] kvm: Add two new arch specific functions

2016-10-21 Thread Liang Li
Add a new function to get the vm's max pfn and a new function to filter out the holes in the undressed free page bitmap to get a tight free page bitmap. They are implemented on X86 and should be implemented on other arches for live migration optimization. Signed-off-by: Liang Li Reviewed-by: Dr.

[Qemu-devel] [PATCH qemu v3 1/6] virtio-balloon: update linux head file

2016-10-21 Thread Liang Li
Update the new feature bit definition for virtio balloon and the page bitmap header, request header struct to keep consistent with kernel side. Signed-off-by: Liang Li --- include/standard-headers/linux/virtio_balloon.h | 41 + 1 file changed, 41 insertions(+) diff --git

[Qemu-devel] [PATCH qemu v3 6/6] migration: skip free pages during live migration

2016-10-21 Thread Liang Li
After sending out the request for free pages, live migration process will start without waiting for the free page bitmap is ready. If the free page bitmap is not ready when doing the 1st migration_bitmap_sync() after ram_save_setup(), the free page bitmap will be ignored, this means the free pages

Re: [Qemu-devel] [PATCH v4 RESEND 1/3] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

2016-10-21 Thread Jason Wang
On 2016年10月17日 23:44, Aviv B.D wrote: From: "Aviv Ben-David" This capability asks the guest to invalidate cache before each map operation. We can use this invalidation to trap map operations in the hypervisor. Signed-off-by: Aviv Ben-David --- hw/i386/intel_iommu.c | 5 + hw

Re: [Qemu-devel] [PATCH qemu v3 0/6] Fast (de)inflating & fast live migration

2016-10-21 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1477032504-12745-1-git-send-email-liang.z...@intel.com Subject: [Qemu-devel] [PATCH qemu v3 0/6] Fast

Re: [Qemu-devel] [PATCH] hostmem-file: add a property 'notrunc' to avoid data corruption

2016-10-21 Thread Haozhong Zhang
On 10/20/16 17:35 +0200, Igor Mammedov wrote: On Thu, 20 Oct 2016 12:47:34 -0200 Eduardo Habkost wrote: On Thu, Oct 20, 2016 at 04:15:21PM +0200, Igor Mammedov wrote: > On Thu, 20 Oct 2016 11:56:10 -0200 > Eduardo Habkost wrote: > > > On Thu, Oct 20, 2016 at 03:42:15PM +0200, Igor Mammedov wr

Re: [Qemu-devel] external usb flash drive support on qemu virtualization

2016-10-21 Thread Kumar Girish
Thank you for info. May I know how to goto qemu monitor from command line. Regard, Girish -Original Message- From: Stefan Hajnoczi [mailto:stefa...@gmail.com] Sent: Thursday, October 20, 2016 9:22 PM To: Kumar Girish Cc: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] external usb flash

Re: [Qemu-devel] [PATCH qemu v3 0/6] Fast (de)inflating & fast live migration

2016-10-21 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1477032504-12745-1-git-send-email-liang.z...@intel.com Subject: [Qemu-devel] [PATCH qemu v3 0/6] Fast (de)inflating & fast live migration === TEST SCRIPT BEGIN === #!/bin/ba

Re: [Qemu-devel] [Qemu-arm] [PATCH] char: cadence: check divider against baud rate

2016-10-21 Thread P J P
+-- On Thu, 20 Oct 2016, Edgar E. Iglesias wrote --+ | The UART is described in the Zynq TRMs, I think you can just | google for zynq TRM and a reference to UG585 and UG1085 will come up. Unlikely for a novice to think 'zynq TRM' as search term for cadence UART. I went with Xilinx Cadence UART

Re: [Qemu-devel] [PATCH v9 04/12] vfio iommu: Add support for mediated devices

2016-10-21 Thread Jike Song
On 10/18/2016 05:22 AM, Kirti Wankhede wrote: > diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c > index 2ba19424e4a1..5d67058a611d 100644 > --- a/drivers/vfio/vfio_iommu_type1.c > +++ b/drivers/vfio/vfio_iommu_type1.c [snip] > static int vfio_iommu_type1_attach_group

Re: [Qemu-devel] [PATCH] eepro100: Fix memory leak and simplify code for VMStateDescription

2016-10-21 Thread Dr. David Alan Gilbert
* Jason Wang (jasow...@redhat.com) wrote: > > > On 2016年10月17日 17:01, Dr. David Alan Gilbert wrote: > > * Stefan Weil (s...@weilnetz.de) wrote: > > > On 10/14/16 10:25, Dr. David Alan Gilbert wrote: > > > > * Stefan Weil (s...@weilnetz.de) wrote: > > > > > Instead of allocating a VMStateDescripti

Re: [Qemu-devel] external usb flash drive support on qemu virtualization

2016-10-21 Thread Stefan Hajnoczi
On Fri, Oct 21, 2016 at 6:47 AM, Kumar Girish wrote: > Thank you for info. May I know how to goto qemu monitor from command line. The command-line you posted says: -qmp tcp:127.0.0.1:11364,server,nowait Since you have this option I guess you already have some way of sending commands to the QMP m

[Qemu-devel] Regression caused by d2f39ad "exec.c: Ensure right alignment also for file backed ram"

2016-10-21 Thread Haozhong Zhang
Hi, Commit d2f39ad "exec.c: Ensure right alignment also for file backed ram" added an additional alignment requirement besides to the previous page size for the size of the backend file. On x86, the alignment requirement for the size of the backend file is changed from 4KB in QEMU 2.6 to 2MB in Q

Re: [Qemu-devel] [PATCHv4 08/11] tests: Clean up IO handling in ide-test

2016-10-21 Thread Laurent Vivier
On 21/10/2016 03:19, David Gibson wrote: > ide-test uses many explicit inb() / outb() operations for its IO, which > means it's not portable to non-x86 platforms. This cleans it up to use > the libqos PCI accessors instead. > > Signed-off-by: David Gibson > --- > tests/ide-test.c | 179 > +++

Re: [Qemu-devel] Regression caused by d2f39ad "exec.c: Ensure right alignment also for file backed ram"

2016-10-21 Thread Haozhong Zhang
On 10/21/2016 04:28 PM, Haozhong Zhang wrote: > Hi, > > Commit d2f39ad "exec.c: Ensure right alignment also for file backed > ram" added an additional alignment requirement besides to the previous > page size for the size of the backend file. On x86, the alignment > requirement for the size of the

Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop

2016-10-21 Thread Cornelia Huck
On Thu, 20 Oct 2016 18:53:31 +0200 Paolo Bonzini wrote: > No, it's because virtio-mmio can be created without a device > underneath. virtio_bus_start_ioeventfd in that case is wrong, but > virtio_bus_stop_ioeventfd should be a no-op. The fix is trivial: I tend to forget this virtio-mmio spec

Re: [Qemu-devel] [PATCH] fixup! pc: add 'etc/boot-cpus' fw_cfg file for machine with more than 255 CPUs

2016-10-21 Thread Igor Mammedov
On Thu, 20 Oct 2016 16:51:48 -0200 Eduardo Habkost wrote: > On Thu, Oct 20, 2016 at 04:58:42PM +0200, Igor Mammedov wrote: > > Currently firmware uses 1 byte at 0x5F offset in RTC CMOS > > to get number of CPUs present at boot. However 1 byte is > > not enough to handle more than 255 CPUs. So ad

Re: [Qemu-devel] chardev's and fd's in monitors

2016-10-21 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Daniel P. Berrange" writes: [...] >> > Realistically all the major backend subsystems (chardev, network, block, >> > ui and migration) need to be converted to Error ** propagation, since >> > they all ultimatel

Re: [Qemu-devel] chardev's and fd's in monitors

2016-10-21 Thread Markus Armbruster
Paolo Bonzini writes: > On 20/10/2016 10:37, Daniel P. Berrange wrote: >> You have a problem of context - if you have multiple monitors, how do >> you know which to send the error back to if you're not in the event >> loop thread, and thus cur_mon is NULL. With Marc-Andre's series which >> allows

Re: [Qemu-devel] my attempt at new QEMU website

2016-10-21 Thread Paolo Bonzini
On 21/10/2016 07:23, Stefan Weil wrote: > That won't make the situation better, because the desktops also include > elements with copyright. That's why the QEMU article on Wikipedia shows > ReactOS, not a Windows desktop. It's still possible to show a selection of guests (certainly not Apple one

Re: [Qemu-devel] [PATCHv4 08/11] tests: Clean up IO handling in ide-test

2016-10-21 Thread David Gibson
On Fri, Oct 21, 2016 at 10:31:27AM +0200, Laurent Vivier wrote: > > > On 21/10/2016 03:19, David Gibson wrote: > > ide-test uses many explicit inb() / outb() operations for its IO, which > > means it's not portable to non-x86 platforms. This cleans it up to use > > the libqos PCI accessors inste

Re: [Qemu-devel] external usb flash drive support on qemu virtualization

2016-10-21 Thread Markus Armbruster
Kumar Girish writes: > Thank you for info. May I know how to goto qemu monitor from command line. Please don't top-post. usb_add/usb_del are legacy; best stick to device_add/device_del. Try something like (qemu) device_add usb-host,id=my-stick,hostbus=BUS,hostaddr=ADDR,vendorid=VID,produ

Re: [Qemu-devel] [PATCH] hostmem-file: add a property 'notrunc' to avoid data corruption

2016-10-21 Thread Igor Mammedov
On Thu, 20 Oct 2016 14:56:58 -0200 Eduardo Habkost wrote: > On Thu, Oct 20, 2016 at 05:35:38PM +0200, Igor Mammedov wrote: > > On Thu, 20 Oct 2016 12:47:34 -0200 > > Eduardo Habkost wrote: > > > > > On Thu, Oct 20, 2016 at 04:15:21PM +0200, Igor Mammedov wrote: > > > > On Thu, 20 Oct 2016 1

Re: [Qemu-devel] [PATCH v14 00/19] QAPI/QOM work for non-scalar object properties

2016-10-21 Thread Markus Armbruster
Uh, replied to the wrong v14... The one I reviewed is actually v15, Message-Id: <1475246744-29302-1-git-send-email-berra...@redhat.com> http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg08238.html Markus Armbruster writes: > I've warmed quite a bit to this series while reviewing it. In >

Re: [Qemu-devel] chardev's and fd's in monitors

2016-10-21 Thread Daniel P. Berrange
On Thu, Oct 20, 2016 at 06:56:11PM +0200, Paolo Bonzini wrote: > > > On 20/10/2016 10:37, Daniel P. Berrange wrote: > > You have a problem of context - if you have multiple monitors, how do > > you know which to send the error back to if you're not in the event > > loop thread, and thus cur_mon i

Re: [Qemu-devel] [PATCHv4 00/11] Cleanups to qtest PCI handling

2016-10-21 Thread Laurent Vivier
On 21/10/2016 03:19, David Gibson wrote: > This series contains a number of cleanups to the libqos code for > accessing PCI devices, and to tests which use it. > > The general aim is to improve the consistency of semantics across > functions, and reduce the amount of intimate knowledge of the li

Re: [Qemu-devel] chardev's and fd's in monitors

2016-10-21 Thread Daniel P. Berrange
On Fri, Oct 21, 2016 at 11:06:21AM +0200, Markus Armbruster wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Daniel P. Berrange" writes: > [...] > >> > Realistically all the major backend subsystems (chardev, network, block, > >> > ui and migra

Re: [Qemu-devel] [PATCH v14 00/19] QAPI/QOM work for non-scalar object properties

2016-10-21 Thread Daniel P. Berrange
On Fri, Oct 21, 2016 at 11:35:10AM +0200, Markus Armbruster wrote: > Uh, replied to the wrong v14... The one I reviewed is actually v15, > Message-Id: <1475246744-29302-1-git-send-email-berra...@redhat.com> > http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg08238.html Sorry, my bad for scr

Re: [Qemu-devel] chardev's and fd's in monitors

2016-10-21 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Daniel P. Berrange" writes: > [...] > >> > Realistically all the major backend subsystems (chardev, network, block, > >> > ui and migration) need to be con

Re: [Qemu-devel] [PATCH RFC] tcmu: Introduce qemu-tcmu

2016-10-21 Thread Stefan Hajnoczi
On Fri, Oct 21, 2016 at 08:11:47AM +0800, Fam Zheng wrote: > On Thu, 10/20 10:21, Andy Grover wrote: > > On 10/20/2016 07:30 AM, Fam Zheng wrote: > > > On Thu, 10/20 15:08, Stefan Hajnoczi wrote: > > > > If a corrupt image is able to execute arbitrary code in the qemu-tcmu > > > > process, does /de

Re: [Qemu-devel] [PATCH v14 02/21] qdict: implement a qdict_crumple method for un-flattening a dict

2016-10-21 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Tue, Oct 18, 2016 at 04:32:13PM +0200, Markus Armbruster wrote: >> "Daniel P. Berrange" writes: >> >> > The qdict_flatten() method will take a dict whose elements are >> > further nested dicts/lists and flatten them by concatenating >> > keys. >> > >> > The qdi

Re: [Qemu-devel] [PATCHv4 04/11] libqos: Better handling of PCI legacy IO

2016-10-21 Thread Greg Kurz
On Fri, 21 Oct 2016 12:19:45 +1100 David Gibson wrote: > The usual model for PCI IO with libqos is to use qpci_iomap() to map a > specific BAR for a PCI device, then perform IOs within that BAR using > qpci_io_{read,write}*(). > > However, certain devices also have legacy PCI IO. In this case,

Re: [Qemu-devel] [PATCHv4 08/11] tests: Clean up IO handling in ide-test

2016-10-21 Thread Laurent Vivier
On 21/10/2016 11:05, David Gibson wrote: > On Fri, Oct 21, 2016 at 10:31:27AM +0200, Laurent Vivier wrote: >> >> >> On 21/10/2016 03:19, David Gibson wrote: >>> ide-test uses many explicit inb() / outb() operations for its IO, which >>> means it's not portable to non-x86 platforms. This cleans i

Re: [Qemu-devel] [PATCHv4 07/11] libqos: Implement mmio accessors in terms of mem{read, write}

2016-10-21 Thread Greg Kurz
On Fri, 21 Oct 2016 12:19:48 +1100 David Gibson wrote: > In the libqos PCI code we now have accessors both for registers (byte > significance preserving) and for streaming data (byte address order > preserving). These exist in both the interface for qtest drivers and in > the machine specific ba

Re: [Qemu-devel] [PATCH v2] ppc: allow certain HV interrupts to be delivered to guests

2016-10-21 Thread Cédric Le Goater
On 10/21/2016 06:35 AM, Nicholas Piggin wrote: > On Fri, 21 Oct 2016 12:09:54 +1100 > David Gibson wrote: > >> On Fri, Oct 21, 2016 at 12:40:58AM +1100, Nicholas Piggin wrote: >>> On Thu, 20 Oct 2016 15:08:07 +0200 >>> Cédric Le Goater wrote: >>> On 10/20/2016 08:59 AM, Nicholas Piggin w

Re: [Qemu-devel] [PATCH] hostmem-file: add a property 'notrunc' to avoid data corruption

2016-10-21 Thread Igor Mammedov
On Thu, 20 Oct 2016 14:59:11 -0200 Eduardo Habkost wrote: > On Thu, Oct 20, 2016 at 05:41:47PM +0200, Igor Mammedov wrote: > > On Thu, 20 Oct 2016 13:15:31 -0200 > > Eduardo Habkost wrote: > > > > > On Thu, Oct 20, 2016 at 04:17:35PM +0200, Igor Mammedov wrote: > > > > On Thu, 20 Oct 2016 1

Re: [Qemu-devel] [PULL v1 00/10] Merge qio 2016/10/20

2016-10-21 Thread Daniel P. Berrange
On Thu, Oct 20, 2016 at 05:11:56PM +0100, Peter Maydell wrote: > On 20 October 2016 at 14:47, Daniel P. Berrange wrote: > > The following changes since commit e8ddc2eae5ccc41f0815e5c43e70cb04a7e67e2e: > > > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' > > into staging

Re: [Qemu-devel] [PATCHv4 09/11] libqos: Add 64-bit PCI IO accessors

2016-10-21 Thread Greg Kurz
On Fri, 21 Oct 2016 12:19:50 +1100 David Gibson wrote: > Currently the libqos PCI layer includes accessor helpers for 8, 16 and 32 > bit reads and writes. It's likely that we'll want 64-bit accesses in the > future (plenty of modern peripherals will have 64-bit reigsters). This > adds them. >

Re: [Qemu-devel] [PATCH RFC] tcmu: Introduce qemu-tcmu

2016-10-21 Thread Fam Zheng
On Fri, 10/21 10:54, Stefan Hajnoczi wrote: > On Fri, Oct 21, 2016 at 08:11:47AM +0800, Fam Zheng wrote: > > On Thu, 10/20 10:21, Andy Grover wrote: > > > On 10/20/2016 07:30 AM, Fam Zheng wrote: > > > > On Thu, 10/20 15:08, Stefan Hajnoczi wrote: > > > > > If a corrupt image is able to execute arb

Re: [Qemu-devel] [PULL v1 00/10] Merge qio 2016/10/20

2016-10-21 Thread Peter Maydell
On 21 October 2016 at 11:28, Daniel P. Berrange wrote: > On Thu, Oct 20, 2016 at 05:11:56PM +0100, Peter Maydell wrote: >> Unfortunately the new test seems to fail on OSX: >> >> GTESTER tests/test-io-channel-socket >> ** >> ERROR:/Users/pm215/src/qemu-for-merges/tests/test-io-channel-socket.c:38

Re: [Qemu-devel] [PULL v1 00/10] Merge qio 2016/10/20

2016-10-21 Thread Daniel P. Berrange
On Fri, Oct 21, 2016 at 11:35:38AM +0100, Peter Maydell wrote: > On 21 October 2016 at 11:28, Daniel P. Berrange wrote: > > On Thu, Oct 20, 2016 at 05:11:56PM +0100, Peter Maydell wrote: > >> Unfortunately the new test seems to fail on OSX: > >> > >> GTESTER tests/test-io-channel-socket > >> **

Re: [Qemu-devel] [PATCH v14 03/21] qapi: add trace events for visitor

2016-10-21 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Fri, Oct 07, 2016 at 03:59:07PM +0200, Markus Armbruster wrote: >> "Daniel P. Berrange" writes: >> >> > Allow tracing of the operation of visitors >> > >> > Signed-off-by: Daniel P. Berrange >> > --- >> > Makefile.objs | 1 + >> > qapi/qapi-visit-co

Re: [Qemu-devel] [PULL v1 00/10] Merge qio 2016/10/20

2016-10-21 Thread Daniel P. Berrange
On Fri, Oct 21, 2016 at 11:41:01AM +0100, Daniel P. Berrange wrote: > On Fri, Oct 21, 2016 at 11:35:38AM +0100, Peter Maydell wrote: > > On 21 October 2016 at 11:28, Daniel P. Berrange wrote: > > > On Thu, Oct 20, 2016 at 05:11:56PM +0100, Peter Maydell wrote: > > >> Unfortunately the new test see

Re: [Qemu-devel] [PATCH v14 11/21] qapi: add integer range support for QObjectInputVisitor

2016-10-21 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Wed, Oct 12, 2016 at 05:50:41PM +0200, Markus Armbruster wrote: >> "Daniel P. Berrange" writes: >> >> > The traditional CLI arg syntax allows two ways to specify >> > integer lists, either one value per key, or a range of >> > values per key. eg the following a

Re: [Qemu-devel] [PATCH 3/9] block: Remove bdrv_aio_pdiscard()

2016-10-21 Thread Kevin Wolf
Am 20.10.2016 um 19:32 hat Eric Blake geschrieben: > On 10/20/2016 08:46 AM, Kevin Wolf wrote: > > It is unused now. > > > > Signed-off-by: Kevin Wolf > > --- > > block/io.c| 29 - > > block/trace-events| 1 - > > include/block/block.h | 3 --- > > 3

Re: [Qemu-devel] [PATCH] hostmem-file: add a property 'notrunc' to avoid data corruption

2016-10-21 Thread Igor Mammedov
On Fri, 21 Oct 2016 15:22:10 +0800 Haozhong Zhang wrote: > On 10/20/16 17:35 +0200, Igor Mammedov wrote: > >On Thu, 20 Oct 2016 12:47:34 -0200 > >Eduardo Habkost wrote: > > > >> On Thu, Oct 20, 2016 at 04:15:21PM +0200, Igor Mammedov wrote: > >> > On Thu, 20 Oct 2016 11:56:10 -0200 > >> > Ed

Re: [Qemu-devel] [PATCH v14 12/21] option: allow qemu_opts_to_qdict to merge repeated options

2016-10-21 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Wed, Oct 12, 2016 at 07:46:00PM +0200, Markus Armbruster wrote: >> "Daniel P. Berrange" writes: >> >> > If given an option string such as >> > >> > size=1024,nodes=10,nodes=4-5,nodes=1-2,policy=bind >> > >> > the qemu_opts_to_qdict() method will currently ove

Re: [Qemu-devel] [PATCH v14 12/21] option: allow qemu_opts_to_qdict to merge repeated options

2016-10-21 Thread Daniel P. Berrange
On Fri, Oct 21, 2016 at 01:09:07PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Wed, Oct 12, 2016 at 07:46:00PM +0200, Markus Armbruster wrote: > >> "Daniel P. Berrange" writes: > >> > >> > If given an option string such as > >> > > >> > size=1024,nodes=10,nodes=4-5

[Qemu-devel] [PATCH v2] ssh: switch from libssh2 to libssh

2016-10-21 Thread Pino Toscano
Rewrite the implementation of the ssh block driver to use libssh instead of libssh2. The libssh library has various advantages over libssh2: - easier API for authentication (for example for using ssh-agent) - easier API for known_hosts handling - supports newer types of keys in known_hosts Kerber

Re: [Qemu-devel] [PATCH] hostmem-file: add a property 'notrunc' to avoid data corruption

2016-10-21 Thread Haozhong Zhang
On 10/21/16 13:07 +0200, Igor Mammedov wrote: On Fri, 21 Oct 2016 15:22:10 +0800 Haozhong Zhang wrote: On 10/20/16 17:35 +0200, Igor Mammedov wrote: >On Thu, 20 Oct 2016 12:47:34 -0200 >Eduardo Habkost wrote: > >> On Thu, Oct 20, 2016 at 04:15:21PM +0200, Igor Mammedov wrote: >> > On Thu, 20

Re: [Qemu-devel] [PATCH v2] ssh: switch from libssh2 to libssh

2016-10-21 Thread Daniel P. Berrange
On Fri, Oct 21, 2016 at 01:16:11PM +0200, Pino Toscano wrote: > Rewrite the implementation of the ssh block driver to use libssh instead > of libssh2. The libssh library has various advantages over libssh2: > - easier API for authentication (for example for using ssh-agent) > - easier API for know

Re: [Qemu-devel] [PATCH v14 12/21] option: allow qemu_opts_to_qdict to merge repeated options

2016-10-21 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Thu, Oct 13, 2016 at 10:31:37AM +0200, Markus Armbruster wrote: >> "Daniel P. Berrange" writes: >> >> > If given an option string such as >> > >> > size=1024,nodes=10,nodes=4-5,nodes=1-2,policy=bind >> > >> > the qemu_opts_to_qdict() method will currently ove

Re: [Qemu-devel] [PATCH] fixup! pc: add 'etc/boot-cpus' fw_cfg file for machine with more than 255 CPUs

2016-10-21 Thread Eduardo Habkost
On Fri, Oct 21, 2016 at 10:53:27AM +0200, Igor Mammedov wrote: > On Thu, 20 Oct 2016 16:51:48 -0200 > Eduardo Habkost wrote: > > > On Thu, Oct 20, 2016 at 04:58:42PM +0200, Igor Mammedov wrote: > > > Currently firmware uses 1 byte at 0x5F offset in RTC CMOS > > > to get number of CPUs present at

Re: [Qemu-devel] [PATCH] hostmem-file: add a property 'notrunc' to avoid data corruption

2016-10-21 Thread Eduardo Habkost
On Fri, Oct 21, 2016 at 12:28:28PM +0200, Igor Mammedov wrote: > On Thu, 20 Oct 2016 14:59:11 -0200 > Eduardo Habkost wrote: > > > On Thu, Oct 20, 2016 at 05:41:47PM +0200, Igor Mammedov wrote: > > > On Thu, 20 Oct 2016 13:15:31 -0200 > > > Eduardo Habkost wrote: > > > > > > > On Thu, Oct 20,

[Qemu-devel] [Bug 636315] Re: configure and build errors on Solaris 10 due to /bin/sh usage

2016-10-21 Thread Thomas Huth
The shell-based tracetool has been replace in commit 650ab98d1d9551f0ca21 with a script that has been implemented in Python, so I think we can close this bug nowadays. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- d

Re: [Qemu-devel] [PATCH] hostmem-file: add a property 'notrunc' to avoid data corruption

2016-10-21 Thread Eduardo Habkost
On Fri, Oct 21, 2016 at 11:31:41AM +0200, Igor Mammedov wrote: > On Thu, 20 Oct 2016 14:56:58 -0200 > Eduardo Habkost wrote: > > > On Thu, Oct 20, 2016 at 05:35:38PM +0200, Igor Mammedov wrote: > > > On Thu, 20 Oct 2016 12:47:34 -0200 > > > Eduardo Habkost wrote: > > > > > > > On Thu, Oct 20,

[Qemu-devel] [PATCH] cpus: make qemu_mutex_iothread_locked() understand co-routines

2016-10-21 Thread Alex Bennée
There is a slight wart when checking for the state of the BQL when using GThread base co-routines (which we keep for ThreadSanitizer runs). While the main-loop holds the BQL it is suspended until the co-routine completes however the co-routines run in a separate thread so checking the TLS variable

Re: [Qemu-devel] chardev's and fd's in monitors

2016-10-21 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Fri, Oct 21, 2016 at 11:06:21AM +0200, Markus Armbruster wrote: > > "Dr. David Alan Gilbert" writes: > > > > > * Markus Armbruster (arm...@redhat.com) wrote: > > >> "Daniel P. Berrange" writes: > > [...] > > >> > Realistically all the major

Re: [Qemu-devel] [PATCH v14 09/21] qapi: permit auto-creating single element lists

2016-10-21 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Wed, Oct 12, 2016 at 11:18:21AM +0200, Markus Armbruster wrote: >> "Daniel P. Berrange" writes: >> >> > When converting QemuOpts to a QObject, there is no information >> > about compound types available, >> >> Yes, that's a drawback of splitting the conversion

Re: [Qemu-devel] [PATCH] hostmem-file: add a property 'notrunc' to avoid data corruption

2016-10-21 Thread Eduardo Habkost
On Fri, Oct 21, 2016 at 01:07:00PM +0200, Igor Mammedov wrote: [...] > How about following behavior: > > 1) memory-backend-file,mem-path=/some_dir,size=2G > - uses truncate to extend temporary file created in "mem-path" to 'size' > for this case to work 'size' is mandatory > > 2) memory

Re: [Qemu-devel] [PATCH 07/22] qcow2-bitmap: introduce auto-loading bitmaps

2016-10-21 Thread Vladimir Sementsov-Ogievskiy
07.10.2016 22:25, Max Reitz пишет: On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: Auto loading bitmaps are bitmaps in Qcow2, with AUTO flag set. They are loaded at image open and becomes BdrvDirtyBitmap's for corresponding drive. These bitmaps are deleted from Qcow2 image after loading

Re: [Qemu-devel] [PATCH v2] ssh: switch from libssh2 to libssh

2016-10-21 Thread Richard W.M. Jones
On Fri, Oct 21, 2016 at 01:16:11PM +0200, Pino Toscano wrote: > Rewrite the implementation of the ssh block driver to use libssh instead > of libssh2. The libssh library has various advantages over libssh2: > - easier API for authentication (for example for using ssh-agent) > - easier API for know

[Qemu-devel] [PATCH] net: rtl8139: limit processing of ring descriptors

2016-10-21 Thread P J P
From: Prasad J Pandit RTL8139 ethernet controller in C+ mode supports multiple descriptor rings, each with maximum of 64 descriptors. While processing transmit descriptor ring in 'rtl8139_cplus_transmit', it does not limit the descriptor count and runs forever. Add check to avoid it. Reported-by

[Qemu-devel] [Bug 612677] Re: qemu-kvm -curses displays garbled screen

2016-10-21 Thread Thomas Huth
I'm closing this bug now, since it is apparently working with the latest version of QEMU. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/612677 Title

[Qemu-devel] [Bug 643465] Re: Crash at network boot

2016-10-21 Thread Thomas Huth
QEMU 0.12 is very out of date nowadays, so it's unlikely that somebody will still have a look at this ticket => I'm closing this ticket now. If you still have problems with the latest version of QEMU, please feel free to open this ticket again (or a new one). ** Changed in: qemu Status: New

[Qemu-devel] [PATCH v3 0/2] Xen HVM unplug changes

2016-10-21 Thread Olaf Hering
Update unplug in Xen HVM guests to cover more cases. Please review. changes in v3: - adapt to API changes from 49137bf ("block-backend: remove blk_flush_all") changes in v2: - fix issues reported by checkpatch Olaf Hering (2): xen_platform: unplug also SCSI disks xen_platform: SUSE xenlinux

[Qemu-devel] [PATCH v3 1/2] xen_platform: unplug also SCSI disks

2016-10-21 Thread Olaf Hering
Using 'vdev=sd[a-o]' will create an emulated LSI controller, which can be used by the emulated BIOS to boot from disk. If the HVM domU has also PV driver the disk may appear twice in the guest. To avoid this an unplug of the emulated hardware is needed, similar to what is done for IDE and NIC drive

[Qemu-devel] [PATCH v3 2/2] xen_platform: SUSE xenlinux unplug for emulated PCI

2016-10-21 Thread Olaf Hering
Implement SUSE specific unplug protocol for emulated PCI devices in PVonHVM guests. Its a simple 'outl(1, (ioaddr + 4));'. This protocol was implemented and used since Xen 3.0.4. It is used in all SUSE/SLES/openSUSE releases up to SLES11SP3 and openSUSE 12.3. In addition old (pre-2011) VMDP version

Re: [Qemu-devel] Regression caused by d2f39ad "exec.c: Ensure right alignment also for file backed ram"

2016-10-21 Thread Igor Mammedov
On Fri, 21 Oct 2016 16:39:08 +0800 Haozhong Zhang wrote: > On 10/21/2016 04:28 PM, Haozhong Zhang wrote: > > Hi, > > > > Commit d2f39ad "exec.c: Ensure right alignment also for file backed > > ram" added an additional alignment requirement besides to the previous > > page size for the size of the

[Qemu-devel] [PULL v3] linux-user changes

2016-10-21 Thread riku . voipio
From: Riku Voipio The following changes since commit da158a86c407fa7b9da848b571356a26809d8df9: Merge remote-tracking branch 'remotes/berrange/tags/pull-qcrypto-2016-10-20-1' into staging (2016-10-20 14:46:19 +0100) are available in the git repository at: git://git.linaro.org/people/riku.

Re: [Qemu-devel] [kvm-unit-tests PATCH v3 07/10] arm/arm64: add initial gicv3 support

2016-10-21 Thread Andrew Jones
Hi Andre, On Thu, Oct 20, 2016 at 06:29:01PM +0100, Andre Przywara wrote: > Hi Drew, > > On 15/07/16 14:00, Andrew Jones wrote: > > Signed-off-by: Andrew Jones > > > > --- > > v2: configure irqs as NS GRP1 > > --- > > lib/arm/asm/arch_gicv3.h | 184 ++ > > lib/arm/as

Re: [Qemu-devel] Assertion failure on qcow2 disk with cluster_size != 64k

2016-10-21 Thread Ed Swierk
On Thu, Oct 20, 2016 at 6:38 PM, Eric Blake wrote: > On 10/20/2016 07:24 PM, Ed Swierk wrote: >> Changing max_transfer in the normal write case to >> MIN_NON_ZERO(alignment, MAX_WRITE_ZEROES_BOUNCE_BUFFER) appears to fix >> the problem, but I don't pretend to understand all the subtleties >> here.

Re: [Qemu-devel] [PATCHv4 11/11] libqos: Change PCI accessors to take opaque BAR handle

2016-10-21 Thread Greg Kurz
On Fri, 21 Oct 2016 12:19:52 +1100 David Gibson wrote: > The usual use model for the libqos PCI functions is to map a specific PCI > BAR using qpci_iomap() then pass the returned token into IO accessor > functions. This, and the fact that iomap() returns a (void *) which > actually contains a PC

Re: [Qemu-devel] [PATCH] hostmem-file: add a property 'notrunc' to avoid data corruption

2016-10-21 Thread Igor Mammedov
On Fri, 21 Oct 2016 09:53:43 -0200 Eduardo Habkost wrote: > On Fri, Oct 21, 2016 at 11:31:41AM +0200, Igor Mammedov wrote: > > On Thu, 20 Oct 2016 14:56:58 -0200 > > Eduardo Habkost wrote: > > > > > On Thu, Oct 20, 2016 at 05:35:38PM +0200, Igor Mammedov wrote: > > > > On Thu, 20 Oct 2016 1

Re: [Qemu-devel] my attempt at new QEMU website

2016-10-21 Thread Daniel P. Berrange
On Wed, Oct 19, 2016 at 12:53:55PM +0200, Paolo Bonzini wrote: > Hi all, > > another small PSA. :) I have created a small but hopefully useful > example of a new QEMU website at http://qemu-bonzini.rhcloud.com/. The > site aims at providing and also a home for blog posts about QEMU. > > The sit

Re: [Qemu-devel] [PATCH 3/9] block: Remove bdrv_aio_pdiscard()

2016-10-21 Thread Eric Blake
On 10/21/2016 05:59 AM, Kevin Wolf wrote: > Am 20.10.2016 um 19:32 hat Eric Blake geschrieben: >> On 10/20/2016 08:46 AM, Kevin Wolf wrote: >>> It is unused now. >>> >>> Signed-off-by: Kevin Wolf >>> --- >>> block/io.c| 29 - >>> block/trace-events| 1

Re: [Qemu-devel] [PULL v3] linux-user changes

2016-10-21 Thread Peter Maydell
On 21 October 2016 at 13:47, wrote: > From: Riku Voipio > > The following changes since commit da158a86c407fa7b9da848b571356a26809d8df9: > > Merge remote-tracking branch > 'remotes/berrange/tags/pull-qcrypto-2016-10-20-1' into staging (2016-10-20 > 14:46:19 +0100) > > are available in the gi

Re: [Qemu-devel] [PATCH v2] qapi: fix memory leak in QmpOutputVisitor

2016-10-21 Thread Markus Armbruster
Pino Toscano writes: > qmp_output_start_struct() and qmp_output_start_list() create a new > QObject (QDict, QList) and push it to the stack of the QmpOutputVisitor, > where it is saved as 'value'. When freeing the iterator in > qmp_output_free(), these values are never freed properly. > > The si

Re: [Qemu-devel] Regression caused by d2f39ad "exec.c: Ensure right alignment also for file backed ram"

2016-10-21 Thread Igor Mammedov
On Fri, 21 Oct 2016 16:28:01 +0800 Haozhong Zhang wrote: > Hi, > > Commit d2f39ad "exec.c: Ensure right alignment also for file backed > ram" added an additional alignment requirement besides to the previous > page size for the size of the backend file. On x86, the alignment > requirement for th

[Qemu-devel] target-ppc: gdbstub breakpoints get stuck in an infinite loop on next/continue

2016-10-21 Thread Mark Cave-Ayland
Hi all, I've just noticed the above regression in git master whilst trying to debug something in openbios-ppc via QEMU's gdbstub. Reproduction here is fairly easy using a debug build of OpenBIOS which I've uploaded to https://www.ilande.co.uk/tmp/qemu/openbios-qemu.elf.nostrip for people to test a

Re: [Qemu-devel] [PATCH v9 04/12] vfio iommu: Add support for mediated devices

2016-10-21 Thread Alex Williamson
On Fri, 21 Oct 2016 15:49:07 +0800 Jike Song wrote: > On 10/18/2016 05:22 AM, Kirti Wankhede wrote: > > diff --git a/drivers/vfio/vfio_iommu_type1.c > > b/drivers/vfio/vfio_iommu_type1.c > > index 2ba19424e4a1..5d67058a611d 100644 > > --- a/drivers/vfio/vfio_iommu_type1.c > > +++ b/drivers/vfio/

[Qemu-devel] [RFC PATCH 2/4] tests/test-vmstate.c: add array of pointer to struct

2016-10-21 Thread Halil Pasic
Increase test coverage by adding tests for the macro VMSTATE_ARRAY_OF_POINTER_TO_STRUCT. Signed-off-by: Halil Pasic Reviewed-by: Guenther Hutzl --- tests/test-vmstate.c | 74 1 file changed, 74 insertions(+) diff --git a/tests/test-vmstate.c

[Qemu-devel] [RFC PATCH 3/4] migration/vmstate: fix array of pointers to struct

2016-10-21 Thread Halil Pasic
Make VMS_ARRAY_OF_POINTER cope with null pointers. Previously the reward for trying to migrate an array with some null pointers in it was an illegal memory access, that is a swift and painless death of the process. Let's make vmstate cope with this scenario at least for pointers to structs. The gen

[Qemu-devel] [RFC PATCH 1/4] tests/test-vmstate.c: add save_buffer util func

2016-10-21 Thread Halil Pasic
Let us de-duplicate some code by introducing an utility function for saving a chunk of bytes (used when testing load based on wire). Signed-off-by: Halil Pasic Reviewed-by: Guenther Hutzl --- tests/test-vmstate.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) d

Re: [Qemu-devel] [PATCH v4 RESEND 0/3] IOMMU: intel_iommu support map and unmap notifications

2016-10-21 Thread Alex Williamson
On Fri, 21 Oct 2016 13:17:08 +0800 Peter Xu wrote: > On Fri, Oct 21, 2016 at 11:50:05AM +1100, David Gibson wrote: > > [...] > > > > > In my setup the VFIO registered two memory areas with one page of > > > > unregistered memory > > > > between them. > > > > > > > > When I'm calling memory_reg

[Qemu-devel] [RFC PATCH 4/4] tests/test-vmstate.c: add array of pointers to struct with NULL

2016-10-21 Thread Halil Pasic
Increase coverage by testing VMSTATE_ARRAY_OF_POINTER_TO_STRUCT with an array containing some NULL pointer. Signed-off-by: Halil Pasic --- tests/test-vmstate.c | 41 + 1 file changed, 41 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate

[Qemu-devel] definition of struct TCGv_i64_d

2016-10-21 Thread Programmingkid
In the tcg.h file, there is this line: typedef struct TCGv_i64_d *TCGv_i64; Would anyone know where the definition of struct TCGv_i64_d is?

[Qemu-devel] [RFC PATCH 0/4] VMS_ARRAY_OF_POINTER with null pointers

2016-10-21 Thread Halil Pasic
Make VMS_ARRAY_OF_POINTER cope with null pointers. Currently the reward for trying to migrate an array with some null pointers in it is an illegal memory access, that is a swift and painless death of the process. Let's make vmstate cope with this scenario at least for pointers to structs. We need

Re: [Qemu-devel] [Qemu-arm] [PATCH v3 0/7] Runtime pagesize computation

2016-10-21 Thread Peter Maydell
On 11 October 2016 at 18:08, Peter Maydell wrote: > (I posted version 2 way back in June...) > > The basic idea here is that: > * the target CPU implementation has to opt into variable page size >by defining TARGET_PAGE_BITS_VARY, and then calling >set_preferred_target_page_bits() in its

Re: [Qemu-devel] [PATCH V5] fsdev: add IO throttle support to fsdev devices

2016-10-21 Thread Alberto Garcia
On Thu 20 Oct 2016 04:14:23 PM CEST, Pradeep Jagadeesh wrote: > +static void fsdev_throttle_schedule_next_request(FsThrottle *fst, bool > is_write) > +{ > +bool must_wait; > + > +if (qemu_co_queue_empty(&fst->throttled_reqs[is_write])) { > +return; > +} > +must_wait = fsdev

Re: [Qemu-devel] [PATCH V5] fsdev: add IO throttle support to fsdev devices

2016-10-21 Thread Alberto Garcia
On Fri 21 Oct 2016 05:02:29 PM CEST, Alberto Garcia wrote: >> +void fsdev_throttle_request(FsThrottle *fst, bool is_write, >> +struct iovec *iov, int iovcnt) > > First, mark the function as running in a coroutine context: > > void coroutine_fn fsdev_throttle_request(FsTh

Re: [Qemu-devel] definition of struct TCGv_i64_d

2016-10-21 Thread Peter Maydell
On 21 October 2016 at 15:48, Programmingkid wrote: > In the tcg.h file, there is this line: typedef struct TCGv_i64_d *TCGv_i64; > > Would anyone know where the definition of struct TCGv_i64_d is? There is none, because the "pointers" in these variables are never dereferenced. These are just magi

Re: [Qemu-devel] [PATCH 01/13] virtio: disable ioeventfd as early as possible

2016-10-21 Thread Stefan Hajnoczi
On Mon, Oct 10, 2016 at 01:53:29PM +0200, Paolo Bonzini wrote: > Avoid "tricking" virtio-blk-dataplane into thinking that ioeventfd will be > available when it is not. This bug has always been there, but it will break > TCG+ioeventfd=on once the dataplane code will be always used when > ioeventfd

  1   2   3   >