On Thu, Oct 20, 2016 at 06:56:11PM +0200, Paolo Bonzini wrote: > > > On 20/10/2016 10:37, Daniel P. Berrange wrote: > > You have a problem of context - if you have multiple monitors, how do > > you know which to send the error back to if you're not in the event > > loop thread, and thus cur_mon is NULL. With Marc-Andre's series which > > allows proper async command processing it gets even harder, because > > there's potentially many outstanding commands associated with a monitor > > and you need to decide which the error should be given to. > > Why should it even consult the current monitor? Shouldn't errors go to > all HMP monitors when QEMU falls back to error_report?
I rather think not - say you're running two monitors, one for issuing commands like hotplug, and in the other just using to query stats/info about the VM. Why should an error about a failed hotplug command pollute the output of the other monitor you're using for querying stats. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
