Re: [Qemu-devel] [PATCH v4] build: Work around SIZE_MAX bug in OSX headers

2016-10-11 Thread Markus Armbruster
Eric Blake writes: > C99 requires SIZE_MAX to be declared with the same type as the > integral promotion of size_t, but OSX mistakenly defines it as > an 'unsigned long long' expression even though size_t is only > 'unsigned long'. Rather than futzing around with whether size_t > is 32- or 64-bi

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 4/6] migration: migrate QTAILQ

2016-10-11 Thread Paolo Bonzini
On 10/10/2016 23:29, Jianjun Duan wrote: > You are right. What we have in VMSTATE now cannot handle a recursive (or > cyclic as you call it) structure. The idea was to use VMS_LINKED to > indicate a recursive structure. Sure, but it's unnecessary. If you didn't have VMS_LINKED, no one would not

[Qemu-devel] [PATCH V2] colo-proxy: fix memory leak

2016-10-11 Thread Zhang Chen
Fix memory leak in colo-compare.c and filter-rewriter.c Report by Coverity. v2: - use traces instead of fprintf in colo-compare.c v1: - initial patch Signed-off-by: Zhang Chen --- net/colo-compare.c| 11 +++ net/filter-rewriter.c | 17 + trace-events |

Re: [Qemu-devel] Deprecating old machine-types (was Re: [PATCH v4 7/8] intel_iommu: keep buggy EIM enabled in 2.7 machine type)

2016-10-11 Thread Paolo Bonzini
On 10/10/2016 19:46, Eduardo Habkost wrote: > I don't think we have a plan, but I would support deprecating and > removing very old machine-types. The question is: how old is too > old? > > For reference, the commits and dates when each machine-type was > added are below: > > machine commit

[Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-11 Thread Ashijeet Acharya
This series adds blockdev-add support for SSH block driver. Patch 1 prepares the code for the addition of a new option prefix, which is "server.". This is accomplished by adding a ssh_has_filename_options_conflict() function which helps to iterate over the various options and check for conflict.

[Qemu-devel] [PATCH 3/4] block/ssh: Use InetSocketAddress options

2016-10-11 Thread Ashijeet Acharya
Drop the use of legacy options in favour of the InetSocketAddress options. Signed-off-by: Ashijeet Acharya --- block/ssh.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index 702871a..399ed60 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -

[Qemu-devel] [PATCH 4/4] qapi: allow blockdev-add for ssh

2016-10-11 Thread Ashijeet Acharya
Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to support blockdev-add for SSH network protocol driver. Use only 'struct InetSocketAddress' since SSH only supports connection over TCP. Signed-off-by: Ashijeet Acharya --- qapi/block-core.json | 24 ++-- 1 fi

[Qemu-devel] [PATCH 2/4] block/ssh: Add InetSocketAddress and accept it

2016-10-11 Thread Ashijeet Acharya
Add InetSocketAddress compatibility to SSH driver. Add a new option "server" to the SSH block driver which then accepts a InetSocketAddress. "host" and "port" are supported as legacy options and are mapped to their InetSocketAddress representation. Signed-off-by: Ashijeet Acharya --- block/ssh

[Qemu-devel] [PATCH 1/4] block/ssh: Add ssh_has_filename_options_conflict()

2016-10-11 Thread Ashijeet Acharya
We have 5 options plus ("server") option which is added in the next patch that conflict with specifying a SSH filename. We need to iterate over all the options to check whether its key has an "server." prefix. This iteration will help us adding the new option "server" easily. Signed-off-by: Ashij

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-10-11 Thread ashish mittal
Checked in a test server to libqnio that allows to open, read, write to a vxhs vdisk using the qemu-io binary. Steps to run the test server: (1) Touch a file in /tmp with the base-name of the vdisk ID to be opened. touch /tmp/\{98f48eef-b62f-46ee-b6e3-ad48ffd9ad0a\} (2) Start the test server. It l

Re: [Qemu-devel] [PATCH v2] block: Remove "options" indirection from blockdev-add

2016-10-11 Thread Markus Armbruster
Kevin Wolf writes: > Now that QAPI supports boxed types, we can have unions at the top level > of a command, so let's put our real options directly there for > blockdev-add instead of having a single "options" dict that contains the > real arguments. > > blockdev-add is still experimental and we

Re: [Qemu-devel] [PATCH v2 0/4] generic docker run patches

2016-10-11 Thread Fam Zheng
On Tue, 10/11 07:48, Alex Bennée wrote: > > Alex Bennée writes: > > > Hi Fam, > > > > I've re-based the series for the generic run target. The aim being to > > allow a developer to run tests against any generic docker target even > > if it is not in the list of approved targets: > > Ping? Sorr

Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour

2016-10-11 Thread Paolo Bonzini
On 10/10/2016 13:50, Claudio Imbrenda wrote: > +/* > + * XXX vm_start also calls qemu_vmstop_requested(&requested); here, > is > + * it actually important? it's static in vl.c > + */ Yes, it is, :) and so is qapi_event_send_resume (which is automatically generate

Re: [Qemu-devel] [PATCH v10 03/16] block: Use block_job_add_bdrv() in mirror_start_job()

2016-10-11 Thread Paolo Bonzini
On 10/10/2016 18:03, Kevin Wolf wrote: >> > Use block_job_add_bdrv() instead of blocking all operations in >> > mirror_start_job() and unblocking them in mirror_exit(). >> > >> > Signed-off-by: Alberto Garcia > Compared to the old code, this unblocks BLOCK_OP_TYPE_DATAPLANE, i.e. > you can now

Re: [Qemu-devel] [RFC QEMU PATCH 8/8] qmp: add a qmp command 'query-nvdimms' to get plugged NVDIMM devices

2016-10-11 Thread Markus Armbruster
Haozhong Zhang writes: > On 10/10/16 14:16, Eric Blake wrote: >> On 10/09/2016 07:34 PM, Haozhong Zhang wrote: >> > Xen uses this command to get the backend resource, guest SPA and size of >> > NVDIMM devices so as to map them to guest. >> > >> > Signed-off-by: Haozhong Zhang >> > --- >> > Cc:

Re: [Qemu-devel] Deprecating old machine-types (was Re: [PATCH v4 7/8] intel_iommu: keep buggy EIM enabled in 2.7 machine type)

2016-10-11 Thread Daniel P. Berrange
On Tue, Oct 11, 2016 at 09:36:29AM +0200, Paolo Bonzini wrote: > > > On 10/10/2016 19:46, Eduardo Habkost wrote: > > I don't think we have a plan, but I would support deprecating and > > removing very old machine-types. The question is: how old is too > > old? > > > > For reference, the commits

Re: [Qemu-devel] [PULL 00/33] virtio, pc: fixes and features

2016-10-11 Thread Sascha Silbe
Dear Peter, Peter Maydell writes: > On 10 October 2016 at 15:13, Peter Maydell wrote: >> This failed 'make check' on aarch64 host (everything else was ok): >> >> TEST: tests/pxe-test... (pid=11699) >> /ppc64/pxe/virtio: ** >> ERROR:/home/petma

Re: [Qemu-devel] [PATCH v2 2/4] tests/docker: test-build script

2016-10-11 Thread Fam Zheng
On Mon, 10/03 17:32, Alex Bennée wrote: > Much like test-quick but only builds. This is useful for some of the > build targets like ThreadSanitizer that don't yet pass "make check". > > Signed-off-by: Alex Bennée > --- > tests/docker/test-build | 18 ++ > 1 file changed, 18 inser

Re: [Qemu-devel] Deprecating old machine-types (was Re: [PATCH v4 7/8] intel_iommu: keep buggy EIM enabled in 2.7 machine type)

2016-10-11 Thread Paolo Bonzini
On 11/10/2016 10:23, Daniel P. Berrange wrote: > On Tue, Oct 11, 2016 at 09:36:29AM +0200, Paolo Bonzini wrote: >> >> >> On 10/10/2016 19:46, Eduardo Habkost wrote: >>> I don't think we have a plan, but I would support deprecating and >>> removing very old machine-types. The question is: how old

Re: [Qemu-devel] [PATCH v2 2/4] tests/docker: test-build script

2016-10-11 Thread Alex Bennée
Fam Zheng writes: > On Mon, 10/03 17:32, Alex Bennée wrote: >> Much like test-quick but only builds. This is useful for some of the >> build targets like ThreadSanitizer that don't yet pass "make check". >> >> Signed-off-by: Alex Bennée >> --- >> tests/docker/test-build | 18 ++

Re: [Qemu-devel] [PATCH v5 6/7] intel_iommu: reject broken EIM

2016-10-11 Thread Peter Xu
On Mon, Oct 10, 2016 at 05:28:47PM +0200, Radim Krčmář wrote: > Cluster x2APIC cannot work without KVM's x2apic API when the maximal > APIC ID is greater than 8 and only KVM's LAPIC can support x2APIC, so we > forbid other APICs and also the old KVM case with less than 9, to > simplify the code. >

Re: [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest_init()

2016-10-11 Thread Peter Maydell
On 11 October 2016 at 02:24, David Gibson wrote: > On Mon, Oct 10, 2016 at 03:10:33PM +0100, Peter Maydell wrote: >> On 10 October 2016 at 14:39, David Gibson >> wrote: >> > In the overwhelming majority of cases the endianness of the device is >> > known independent of the guest CPU and board. >

Re: [Qemu-devel] [PATCH v2 10/11] blockjob: refactor backup_start as backup_job_create

2016-10-11 Thread Paolo Bonzini
On 11/10/2016 00:51, John Snow wrote: >> Clearing the bitmap is a bug because the caller could expect that the >> bitmap is in its original state if the transaction fails. I doubt this >> is a problem in practice, but we should fix it anyway. > > We make a backup to undo the process if it fails.

Re: [Qemu-devel] [PULL 00/33] virtio, pc: fixes and features

2016-10-11 Thread Peter Maydell
On 11 October 2016 at 09:27, Sascha Silbe wrote: > There's a race condition in the tests. Both the "i386" and the "x86_64" > set of tests are creating and removing the same set of files: > tests/acpi-test-disk.raw (hard-coded in tests/bios-tables-test.c) and > tests/pxe-test-disk.raw (hard-coded i

Re: [Qemu-devel] [PATCH 0/3] preliminaries for GICv3 virt support

2016-10-11 Thread Peter Maydell
On 6 October 2016 at 14:21, Peter Maydell wrote: > This set of three straightforward patches is a preliminary > for adding virtualization support to the GICv3 emulation: > * add a (nop implementation of) MDCCINT_EL1, since KVM >will read/write it on worldswitch > * fix some bugs in the GICv3

[Qemu-devel] [PATCH 2/2] virtio: make virtqueue_alloc_element static

2016-10-11 Thread Ladi Prosek
The function does not fully initialize the returned VirtQueueElement and should be used only internally from the virtio module. Signed-off-by: Ladi Prosek --- hw/virtio/virtio.c | 2 +- include/hw/virtio/virtio.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/vir

[Qemu-devel] [PATCH 1/2] virtio: rename virtqueue_discard to virtqueue_unpop

2016-10-11 Thread Ladi Prosek
The function undoes the effect of virtqueue_pop and doesn't do anything destructive or irreversible so virtqueue_unpop is a more fitting name. Signed-off-by: Ladi Prosek --- hw/net/virtio-net.c| 2 +- hw/virtio/virtio-balloon.c | 2 +- hw/virtio/virtio.c | 6 +++--- include/hw/vi

[Qemu-devel] [PATCH 0/2] virtio: cosmetic tweaks

2016-10-11 Thread Ladi Prosek
Just a trivial couple of patches addressing minor style issues. Enforcing the correct order of operations (pop, unpop, push, rewind) with an assert, which was another potential change discussed previously, would add a non-trivial amount of code and is not worth the effort in my opinion. A simple

Re: [Qemu-devel] [PATCH v2 10/11] blockjob: refactor backup_start as backup_job_create

2016-10-11 Thread Kevin Wolf
Am 11.10.2016 um 00:51 hat John Snow geschrieben: > >>Sadly for me, I realized this patch has a potential problem. When we > >>were adding the bitmap operations, it became clear that the > >>atomicity point was during .prepare, not .commit. > >> > >>e.g. the bitmap is cleared or created during prep

Re: [Qemu-devel] [PATCH v10 01/16] block: Pause all jobs during bdrv_reopen_multiple()

2016-10-11 Thread Kevin Wolf
Am 10.10.2016 um 18:41 hat Paolo Bonzini geschrieben: > On 10/10/2016 17:37, Kevin Wolf wrote: > > > +while ((job = block_job_next(job))) { > > > +AioContext *aio_context = blk_get_aio_context(job->blk); > > > + > > > +aio_context_acquire(aio_context); > > > +block_job_p

Re: [Qemu-devel] [PATCH v2 02/11] blockjob: centralize QMP event emissions

2016-10-11 Thread Markus Armbruster
John Snow writes: > On 10/05/2016 09:43 AM, Kevin Wolf wrote: [...] >> Here we have an additional caller in block/replication.c and qemu-img, >> so the parameters must stay. For qemu-img, nothing changes. For >> replication, the block job events are added as a side effect. >> >> Not sure if we wa

[Qemu-devel] [PATCH v3 2/2] linux-user: added support for pwritev() system call.

2016-10-11 Thread Dejan Jovicevic
This system call performs the same task as the writev() system call, with the exception of having the fourth argument, offset, which specifes the file offset at which the input operation is to be performed. Because of this, the pwritev() implementation is based on the writev() implementation in lin

[Qemu-devel] [PATCH v3 0/2] linux-user: preadv and pwritev emulation support

2016-10-11 Thread Dejan Jovicevic
v2 -> v3: - Changed from safe_syscall4() to safe_syscall5() to rightly fit the kernel implementation of preadv() and pwritev(). - Modified commit message. v1 -> v2: - Being that both of these system calls are interruptible, in QEMU they should be implemented via the safe_sy

[Qemu-devel] [PATCH v3 1/2] linux-user: added support for preadv() system call.

2016-10-11 Thread Dejan Jovicevic
This system call performs the same task as the readv() system call, with the exception of having the fourth argument, offset, which specifes the file offset at which the input operation is to be performed. Because of this, the preadv() implementation is based on the readv() implementation in linux-

Re: [Qemu-devel] [PATCH v10 01/16] block: Pause all jobs during bdrv_reopen_multiple()

2016-10-11 Thread Paolo Bonzini
On 11/10/2016 11:39, Kevin Wolf wrote: > Am 10.10.2016 um 18:41 hat Paolo Bonzini geschrieben: >> On 10/10/2016 17:37, Kevin Wolf wrote: +while ((job = block_job_next(job))) { +AioContext *aio_context = blk_get_aio_context(job->blk); + +aio_context_acquire(

Re: [Qemu-devel] [PATCH v2 2/4] tests/docker: test-build script

2016-10-11 Thread Fam Zheng
On Tue, 10/11 09:49, Alex Bennée wrote: > > Fam Zheng writes: > > > On Mon, 10/03 17:32, Alex Bennée wrote: > >> Much like test-quick but only builds. This is useful for some of the > >> build targets like ThreadSanitizer that don't yet pass "make check". > >> > >> Signed-off-by: Alex Bennée >

Re: [Qemu-devel] [PATCH v2 4/4] tests/docker/Makefile.include: add a generic docker-run target

2016-10-11 Thread Fam Zheng
On Mon, 10/03 17:32, Alex Bennée wrote: > This re-factors the docker makefile to include a docker-run target which > can be controlled entirely from environment variables specified on the > make command line. This allows us to run against any given docker image > we may have in our repository, for

Re: [Qemu-devel] [RFC QEMU PATCH 8/8] qmp: add a qmp command 'query-nvdimms' to get plugged NVDIMM devices

2016-10-11 Thread Haozhong Zhang
On 10/11/16 10:22, Markus Armbruster wrote: > Haozhong Zhang writes: > > > On 10/10/16 14:16, Eric Blake wrote: > >> On 10/09/2016 07:34 PM, Haozhong Zhang wrote: > >> > Xen uses this command to get the backend resource, guest SPA and size of > >> > NVDIMM devices so as to map them to guest. > >>

Re: [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest_init()

2016-10-11 Thread David Gibson
On Tue, Oct 11, 2016 at 09:55:54AM +0100, Peter Maydell wrote: > On 11 October 2016 at 02:24, David Gibson wrote: > > On Mon, Oct 10, 2016 at 03:10:33PM +0100, Peter Maydell wrote: > >> On 10 October 2016 at 14:39, David Gibson > >> wrote: > >> > In the overwhelming majority of cases the endiann

[Qemu-devel] [Questions] NBD issue or CoMutex->holder issue?

2016-10-11 Thread Changlong Xie
Hi all Recently during test COLO, i encounter some problems. Here is the backtrace qemu-system-x86_64: util/qemu-coroutine-lock.c:148: qemu_co_mutex_unlock: Assertion `mutex->holder == self' failed. [New Thread 0x7fff0e7fc700 (LWP 20936)] Program received signal SIGABRT, Aborted. 0x75

Re: [Qemu-devel] [PATCH v1 2/2] block/replication: Clarify 'top-id' parameter usage

2016-10-11 Thread Changlong Xie
On 10/11/2016 02:30 PM, Fam Zheng wrote: On Tue, 10/11 13:39, Changlong Xie wrote: Replication driver only support 'top-id' parameter in secondary side, and it must not be supplied in primary side Signed-off-by: Changlong Xie --- block/replication.c | 5 + qapi/block-core.json | 3 ++-

[Qemu-devel] [PATCH v2 2/2] block/replication: Clarify 'top-id' parameter usage

2016-10-11 Thread Changlong Xie
Replication driver only support 'top-id' parameter in secondary side, and it must not be supplied in primary side Signed-off-by: Changlong Xie --- block/replication.c | 5 + qapi/block-core.json | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/block/replication.c b/blo

[Qemu-devel] [PATCH v2 0/2] block/replication fixes

2016-10-11 Thread Changlong Xie
V2: 1. fix typo Changlong Xie (2): block/replication: prefect the logic to acquire 'top_id' block/replication: Clarify 'top-id' parameter usage block/replication.c | 9 +++-- qapi/block-core.json | 3 ++- 2 files changed, 9 insertions(+), 3 deletions(-) -- 1.9.3

[Qemu-devel] [PATCH v2 1/2] block/replication: prefect the logic to acquire 'top_id'

2016-10-11 Thread Changlong Xie
Only g_strdup(top_id) if 'top_id' is not NULL, although there is no memory leak here Signed-off-by: Changlong Xie --- block/replication.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/replication.c b/block/replication.c index 3bd1cf1..5b432d9 100644 --- a/block/re

Re: [Qemu-devel] [PATCH RESEND v6 00/12] virtio-crypto: introduce framework and device emulation

2016-10-11 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 1476089730-65776-1-git-send-email-arei.gong...@huawei.com Subject: [Qemu-devel] [PATCH RESEND v6 00/12] virtio-cry

Re: [Qemu-devel] [Questions] NBD issue or CoMutex->holder issue?

2016-10-11 Thread Paolo Bonzini
On 11/10/2016 12:35, Changlong Xie wrote: > For nbd client, if request number is large than MAX_NBD_REQUESTS(16), we > will queue the rest requests into free_sema->queue. > When nbd client receives one reply, it will unlock free_sema, then pop > the free_sema->queue head, so set free_sema->holde

Re: [Qemu-devel] [PATCH 1/3] block: add BDS field to count in-flight requests

2016-10-11 Thread Kevin Wolf
Am 10.10.2016 um 18:37 hat Paolo Bonzini geschrieben: > On 10/10/2016 12:36, Kevin Wolf wrote: > > > > At the BlockBackend level (or really anywhere in the graph), we have two > > different kinds of drain requests that we just fail to implement > > differently today: > > > > 1. blk_drain(), i.e.

Re: [Qemu-devel] [PATCH 0/3] preliminaries for GICv3 virt support

2016-10-11 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 1475760067-25756-1-git-send-email-peter.mayd...@linaro.org Subject: [Qemu-devel] [PATCH 0/3] preliminaries for GIC

Re: [Qemu-devel] [PATCH v10 01/16] block: Pause all jobs during bdrv_reopen_multiple()

2016-10-11 Thread Kevin Wolf
Am 11.10.2016 um 11:54 hat Paolo Bonzini geschrieben: > On 11/10/2016 11:39, Kevin Wolf wrote: > > Am 10.10.2016 um 18:41 hat Paolo Bonzini geschrieben: > >> On 10/10/2016 17:37, Kevin Wolf wrote: > +while ((job = block_job_next(job))) { > +AioContext *aio_context = blk_get_ai

Re: [Qemu-devel] [PATCH v6 08/15] qstring: Add qstring_wrap_str()

2016-10-11 Thread Marc-André Lureau
Hi On Mon, Oct 10, 2016 at 5:25 PM Eric Blake wrote: > Several spots in the code malloc a string, then wrap it in a > QString, which has to duplicate the input. Adding a new > constructor with transfer semantics makes this pattern more > efficient, comparable to the just-added transfer semantic

Re: [Qemu-devel] [PATCH 0/2] qemu-img: change img_open() and opening method in dd

2016-10-11 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH 0/2] qemu-img: change img_open() and opening method in dd Message-id: 20161007153617.28704-1-ful

Re: [Qemu-devel] [PULL 00/33] virtio, pc: fixes and features

2016-10-11 Thread Thomas Huth
On 11.10.2016 10:27, Sascha Silbe wrote: > Dear Peter, > > Peter Maydell writes: > >> On 10 October 2016 at 15:13, Peter Maydell wrote: >>> This failed 'make check' on aarch64 host (everything else was ok): >>> >>> TEST: tests/pxe-test... (pid=11699) >>> /ppc64/pxe/virtio:

Re: [Qemu-devel] [PATCH v6 12/15] qapi: Support pretty printing in JSON output visitor

2016-10-11 Thread Marc-André Lureau
On Mon, Oct 10, 2016 at 5:44 PM Eric Blake wrote: > Add pretty printing, where the format intentionally matches that of > qobject_to_json() (a later patch will then rework qobject-json.c to > work on top of the JSON visitor). The trickiest part is probably > that the testsuite now has to honor p

Re: [Qemu-devel] [PATCH] target-i386: Unset cannot_destroy_with_object_finalize_yet

2016-10-11 Thread Igor Mammedov
On Mon, 10 Oct 2016 16:34:36 -0300 Eduardo Habkost wrote: > TYPE_X86_CPU now call cpu_exec_init() on realize, so we don't > need to set cannot_destroy_with_object_finalize_yet anymore. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > target-i386/cpu.c | 5 - > 1 file

Re: [Qemu-devel] [PATCH] fixup! target-i386: x86_cpu_load_features() function

2016-10-11 Thread Igor Mammedov
On Mon, 10 Oct 2016 13:58:25 -0300 Eduardo Habkost wrote: > On Mon, Oct 10, 2016 at 02:25:32PM +0200, Igor Mammedov wrote: > > On Fri, 7 Oct 2016 17:29:01 -0300 > > Eduardo Habkost wrote: > > > > > When probing for CPU model information, we need to reuse the code > > > that initializes CPUID

Re: [Qemu-devel] [PATCH v6 3/3] target-i386: Return runnability information on query-cpu-definitions

2016-10-11 Thread Igor Mammedov
On Mon, 10 Oct 2016 14:01:10 -0300 Eduardo Habkost wrote: > On Mon, Oct 10, 2016 at 02:27:49PM +0200, Igor Mammedov wrote: > > On Fri, 7 Oct 2016 17:29:02 -0300 > > Eduardo Habkost wrote: > > > > > Fill the "unavailable-features" field on the x86 implementation > > > of query-cpu-definitions

Re: [Qemu-devel] [PATCH] kvm-all: don't use stale dbg_data->cpu

2016-10-11 Thread Claudio Imbrenda
Tested-by: Claudio Imbrenda On 10/10/16 17:46, Alex Bennée wrote: > The changes to run_on_cpu and friends mean that all helpers are passed > the CPUState of vCPU they are running on. The conversion missed the > field in commit e0eeb4a21a3ca4b296220ce4449d8acef9de9049 which > introduced bugs. > >

Re: [Qemu-devel] [PATCH v2 3/8] nvdimm acpi: introduce _FIT

2016-10-11 Thread Igor Mammedov
On Mon, 10 Oct 2016 21:09:30 +0800 Xiao Guangrong wrote: > On 10/10/2016 08:51 PM, Igor Mammedov wrote: > > On Sat, 8 Oct 2016 15:17:14 +0800 > > Xiao Guangrong wrote: > > > >> On 09/30/2016 09:14 PM, Igor Mammedov wrote: > >>> On Fri, 12 Aug 2016 14:54:05 +0800 > >>> Xiao Guangrong wrote:

Re: [Qemu-devel] [PATCH 05/22] qcow2-bitmap: structs and consts

2016-10-11 Thread Vladimir Sementsov-Ogievskiy
On 01.10.2016 17:34, Max Reitz wrote: On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: Create block/qcow2-bitmap.c Add data structures and constraints accordingly to docs/specs/qcow2.txt Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/Makefile.objs | 2 +- block/qcow2-bitmap

Re: [Qemu-devel] [PULL 00/33] virtio, pc: fixes and features

2016-10-11 Thread Sascha Silbe
Dear Thomas, Thomas Huth writes: > On 11.10.2016 10:27, Sascha Silbe wrote: [pxe-test failing during "make check"] >> There's a race condition in the tests. Both the "i386" and the "x86_64" >> set of tests are creating and removing the same set of files: >> tests/acpi-test-disk.raw (hard-coded i

Re: [Qemu-devel] [PATCH v6 3/3] target-i386: Return runnability information on query-cpu-definitions

2016-10-11 Thread Eduardo Habkost
On Tue, Oct 11, 2016 at 01:45:21PM +0200, Igor Mammedov wrote: > On Mon, 10 Oct 2016 14:01:10 -0300 > Eduardo Habkost wrote: > > On Mon, Oct 10, 2016 at 02:27:49PM +0200, Igor Mammedov wrote: > > > On Fri, 7 Oct 2016 17:29:02 -0300 > > > Eduardo Habkost wrote: [...] > > > > +static void x86_cpu_

Re: [Qemu-devel] [PATCH v5 13/35] tcg: Add atomic helpers

2016-10-11 Thread Alex Bennée
Alex Bennée writes: > Richard Henderson writes: > >> Add all of cmpxchg, op_fetch, fetch_op, and xchg. >> Handle both endian-ness, and sizes up to 8. >> Handle expanding non-atomically, when emulating in serial. >> >> Signed-off-by: Richard Henderson > > This still seems to be suffering expans

Re: [Qemu-devel] [PATCH 06/22] qcow2: add dirty bitmaps extension

2016-10-11 Thread Vladimir Sementsov-Ogievskiy
On 01.10.2016 17:46, Max Reitz wrote: On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: Add dirty bitmap extension as specified in docs/specs/qcow2.txt. For now, just mirror extension header into Qcow2 state and check constraints. For now, disable image resize if it has bitmaps. It will

Re: [Qemu-devel] [PATCH v6 00/15] Add qapi-to-JSON visitor

2016-10-11 Thread Marc-André Lureau
Hi On Mon, Oct 10, 2016 at 5:29 PM Eric Blake wrote: > [5 months later...] > Going from qapi to QObject to JSON is wasteful compared to going > straight from qapi to JSON. What's more, having QObject in the > middle means that dict keys are shuffled according to hash ordering, > while going str

Re: [Qemu-devel] [PATCH 2/2] char: use a fixed idx for child muxed chr

2016-10-11 Thread Claudio Imbrenda
Hi, I noticed that this patch kills the Qemu monitor for me. If I start a text-mode guest with -nographic, then I can't switch to the monitor any longer with Ctrl+a c . The guest works otherwise, e.g. I can login from the console. Tested on s390, but I think it's a more general issue, since the p

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-10-11 Thread Igor Mammedov
On Mon, 10 Oct 2016 21:57:55 +0800 Xiao Guangrong wrote: > On 10/10/2016 08:59 PM, Igor Mammedov wrote: > > On Sat, 8 Oct 2016 16:34:06 +0800 > > Xiao Guangrong wrote: > > > >> On 10/03/2016 09:48 PM, Igor Mammedov wrote: > >>> On Fri, 12 Aug 2016 14:54:02 +0800 > >>> Xiao Guangrong wrote:

Re: [Qemu-devel] [PATCH v2] MAINTAINERS: qemu-trivial information

2016-10-11 Thread Laurent Vivier
Le 08/10/2016 à 12:00, Laurent Vivier a écrit : > Information about "qemu-trivial" ML can be found in the wiki: > > http://wiki.qemu.org/Contribute/TrivialPatches > > But the first place where a developer looks is the file MAINTAINERS. > > This also allows the get_maintainer.pl script to d

[Qemu-devel] [PATCH 1/2] tests: check-qom-proplist: Remove "bv" class property from class

2016-10-11 Thread Eduardo Habkost
The object_property_add_bool() call in dummy_init() was always failing because there was a "bv" class property already. Remove the class property so both object properties and class properties are covered by the test code. Signed-off-by: Eduardo Habkost --- tests/check-qom-proplist.c | 4 1

[Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes

2016-10-11 Thread Eduardo Habkost
A few fixes on check-qom-proplist that will ensure we test both class properties and object properties, and catch errors when registering properties in test code. Eduardo Habkost (2): tests: check-qom-proplist: Remove "bv" class property from class tests: check-qom-proplist: Use &error_abort t

[Qemu-devel] [PATCH 2/2] tests: check-qom-proplist: Use &error_abort to catch errors

2016-10-11 Thread Eduardo Habkost
Use &error_abort so we don't ignore any errors on the property registration calls. Signed-off-by: Eduardo Habkost --- tests/check-qom-proplist.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c index 693dc4c..a92acc

Re: [Qemu-devel] [PATCH 1/2] tests: check-qom-proplist: Remove "bv" class property from class

2016-10-11 Thread Daniel P. Berrange
On Tue, Oct 11, 2016 at 09:37:46AM -0300, Eduardo Habkost wrote: > The object_property_add_bool() call in dummy_init() was always > failing because there was a "bv" class property already. Remove > the class property so both object properties and class properties > are covered by the test code. >

Re: [Qemu-devel] [PATCH 2/2] tests: check-qom-proplist: Use &error_abort to catch errors

2016-10-11 Thread Daniel P. Berrange
On Tue, Oct 11, 2016 at 09:37:47AM -0300, Eduardo Habkost wrote: > Use &error_abort so we don't ignore any errors on the property > registration calls. > > Signed-off-by: Eduardo Habkost > --- > tests/check-qom-proplist.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by

[Qemu-devel] Windows 7 guest not starting with HyperV features enabled

2016-10-11 Thread Aleksei
Hi, I'm using libvirt, but folks on libvirt mailing list said it makes more sense to post here. I have a Windows 7 SP1 Pro 64-bit VM which works fine on libvirt 2.3.0 and Qemu 2.7.0. If I enable HyperV features (https://libvirt.org/formatdomain.html#elementsFeatures) like "relaxed", "spinl

Re: [Qemu-devel] top(1) utility implementation in QEMU

2016-10-11 Thread Fam Zheng
On Tue, 10/04 09:42, Markus Armbruster wrote: > >> What's the advantage over simply using another QMP monitor? Naturally, > >> injecting arbitrary QMP commands behind libvirt's back isn't going to > >> end well, but "don't do that then". Information queries and listening > >> to events should be

[Qemu-devel] Potential Bug in vIOMMU which may result in memory wasting

2016-10-11 Thread Liu, Yi L
Hi, Apologize for failing to make this email in short. Log is too long. If the following statements failed to make me understood, you are welcomed to ping me. 1. Problem description: Recently, I find a strange thing with vIOMMU in QEMU. It looks like g_hash_table_lookup() is not 100% give same re

[Qemu-devel] Multiple QMP socket clients

2016-10-11 Thread Samuel Ortiz
Hi, On a qemu instance started with a qmp unix socket: -qmp unix:/tmp/ctrl.sock,server,nowait I am trying to have multiple clients working on that socket but although the qmp server seems to accept the connections, only the first connected client gets his request processed. The next client reque

Re: [Qemu-devel] top(1) utility implementation in QEMU

2016-10-11 Thread Daniel P. Berrange
On Tue, Oct 11, 2016 at 08:51:01PM +0800, Fam Zheng wrote: > On Tue, 10/04 09:42, Markus Armbruster wrote: > > >> What's the advantage over simply using another QMP monitor? Naturally, > > >> injecting arbitrary QMP commands behind libvirt's back isn't going to > > >> end well, but "don't do that

Re: [Qemu-devel] Multiple QMP socket clients

2016-10-11 Thread Daniel P. Berrange
On Tue, Oct 11, 2016 at 12:26:37PM +0200, Samuel Ortiz wrote: > Hi, > > On a qemu instance started with a qmp unix socket: > > -qmp unix:/tmp/ctrl.sock,server,nowait > > I am trying to have multiple clients working on that socket but > although the qmp server seems to accept the connections, onl

[Qemu-devel] KVM call for 2016-10-25

2016-10-11 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details: By

Re: [Qemu-devel] [PATCH 09/22] block: introduce persistent dirty bitmaps

2016-10-11 Thread Vladimir Sementsov-Ogievskiy
On 07.10.2016 20:54, Max Reitz wrote: On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: New field BdrvDirtyBitmap.persistent means, that bitmap should be saved on bdrv_close, using format driver. Format driver should maintain bitmap storing. Signed-off-by: Vladimir Sementsov-Ogievskiy -

Re: [Qemu-devel] [PATCH v6 3/3] target-i386: Return runnability information on query-cpu-definitions

2016-10-11 Thread Igor Mammedov
On Tue, 11 Oct 2016 08:58:02 -0300 Eduardo Habkost wrote: > On Tue, Oct 11, 2016 at 01:45:21PM +0200, Igor Mammedov wrote: > > On Mon, 10 Oct 2016 14:01:10 -0300 > > Eduardo Habkost wrote: > > > On Mon, Oct 10, 2016 at 02:27:49PM +0200, Igor Mammedov wrote: > > > > On Fri, 7 Oct 2016 17:29:

Re: [Qemu-devel] [PATCH v6 3/3] target-i386: Return runnability information on query-cpu-definitions

2016-10-11 Thread Eduardo Habkost
On Tue, Oct 11, 2016 at 03:21:05PM +0200, Igor Mammedov wrote: > On Tue, 11 Oct 2016 08:58:02 -0300 > Eduardo Habkost wrote: > > > On Tue, Oct 11, 2016 at 01:45:21PM +0200, Igor Mammedov wrote: > > > On Mon, 10 Oct 2016 14:01:10 -0300 > > > Eduardo Habkost wrote: > > > > On Mon, Oct 10, 2016 a

[Qemu-devel] [PATCH v3] block: Remove "options" indirection from blockdev-add

2016-10-11 Thread Kevin Wolf
Now that QAPI supports boxed types, we can have unions at the top level of a command, so let's put our real options directly there for blockdev-add instead of having a single "options" dict that contains the real arguments. blockdev-add is still experimental and we already made substantial changes

Re: [Qemu-devel] [PATCH RFC] docs: add PCIe devices placement guidelines

2016-10-11 Thread Andrea Bolognani
On Mon, 2016-10-10 at 17:15 +0300, Marcel Apfelbaum wrote: > > > > 2) can you really only plug a pcie-root-port (ioh3420) > > > > into a pxb-pcie? Or will it accept anything that pcie.0 > > > > accepts? > > >  > > > It supports only PCI Express Root Ports. It does not > > > support Integrated Devic

Re: [Qemu-devel] [PATCH v2 02/11] blockjob: centralize QMP event emissions

2016-10-11 Thread Kashyap Chamarthy
On Mon, Oct 10, 2016 at 02:28:52PM -0500, Eric Blake wrote: > On 10/10/2016 01:36 PM, John Snow wrote: [...] > > I'll be honest that I don't know; this is related to Replication which I > > know reasonably little about overall. It got added in the 2.8 timeframe, > > so the behavior it currently e

[Qemu-devel] [PATCH] tests/boot-sector: Use mkstemp() to create a unique file name

2016-10-11 Thread Thomas Huth
The pxe-test is run for three different targets now (x86_64, i386 and ppc64), and the bios-tables-test is run for two targets (x86_64 and i386). But each of the tests is using an invariant name for the disk image with the boot sector code - so if the tests are running in parallel, there is a race c

Re: [Qemu-devel] [PATCH] tests/boot-sector: Use mkstemp() to create a unique file name

2016-10-11 Thread Peter Maydell
On 11 October 2016 at 14:32, Thomas Huth wrote: > The pxe-test is run for three different targets now (x86_64, i386 > and ppc64), and the bios-tables-test is run for two targets (x86_64 > and i386). But each of the tests is using an invariant name for the > disk image with the boot sector code - s

Re: [Qemu-devel] [PATCH v10 03/16] block: Use block_job_add_bdrv() in mirror_start_job()

2016-10-11 Thread Alberto Garcia
On Mon 10 Oct 2016 06:03:41 PM CEST, Kevin Wolf wrote: >> Use block_job_add_bdrv() instead of blocking all operations in >> mirror_start_job() and unblocking them in mirror_exit(). >> >> Signed-off-by: Alberto Garcia > > Compared to the old code, this unblocks BLOCK_OP_TYPE_DATAPLANE, i.e. > you

Re: [Qemu-devel] [PATCH v5 13/35] tcg: Add atomic helpers

2016-10-11 Thread Richard Henderson
On 10/11/2016 01:47 AM, Alex Bennée wrote: Richard Henderson writes: Add all of cmpxchg, op_fetch, fetch_op, and xchg. Handle both endian-ness, and sizes up to 8. Handle expanding non-atomically, when emulating in serial. Signed-off-by: Richard Henderson This still seems to be suffering e

[Qemu-devel] [PATCH] monitor: deprecate 'default' option

2016-10-11 Thread Marc-André Lureau
This option appears to be unused and undocumented, deprecate it. Signed-off-by: Marc-André Lureau --- vl.c | 5 +++-- include/monitor/monitor.h | 7 +++ qemu-options.hx | 8 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/vl.c b/vl.c i

Re: [Qemu-devel] [PATCH v6 3/3] target-i386: Return runnability information on query-cpu-definitions

2016-10-11 Thread Igor Mammedov
On Tue, 11 Oct 2016 10:24:38 -0300 Eduardo Habkost wrote: > On Tue, Oct 11, 2016 at 03:21:05PM +0200, Igor Mammedov wrote: > > On Tue, 11 Oct 2016 08:58:02 -0300 > > Eduardo Habkost wrote: > > > > > On Tue, Oct 11, 2016 at 01:45:21PM +0200, Igor Mammedov wrote: > > > > On Mon, 10 Oct 2016 1

Re: [Qemu-devel] [PATCH 11/29] target-sparc: implement UA2005 GL register

2016-10-11 Thread Artyom Tarasenko
On Mon, Oct 10, 2016 at 11:45 PM, Richard Henderson wrote: > On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: >> >> case 16: // UA2005 gl >> CHECK_IU_FEATURE(dc, GL); >> -tcg_gen_st32_tl(cpu_tmp0, cpu_env,

Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines

2016-10-11 Thread Artyom Tarasenko
On Tue, Oct 11, 2016 at 7:50 AM, Richard Henderson wrote: > On 10/10/2016 04:45 PM, Artyom Tarasenko wrote: >>> >>> Hmm. Would it make more sense to reorg these as >>> >>> TTE_US1_* >>> TTE_UA2005_* >>> >>> with some duplication for the bits that are shared? >>> As is, it's pretty hard to tel

Re: [Qemu-devel] [PATCH] tests/boot-sector: Use mkstemp() to create a unique file name

2016-10-11 Thread Greg Kurz
On Tue, 11 Oct 2016 15:32:02 +0200 Thomas Huth wrote: > The pxe-test is run for three different targets now (x86_64, i386 > and ppc64), and the bios-tables-test is run for two targets (x86_64 > and i386). But each of the tests is using an invariant name for the > disk image with the boot sector c

Re: [Qemu-devel] [PATCH 01/15] xen: Fix coding style errors

2016-10-11 Thread Anthony PERARD
On Tue, Oct 04, 2016 at 09:43:30AM +0300, Emil Condrea wrote: > Fixes the following errors: > * ERROR: line over 90 characters It's 80 ;), and there are a few more left in this patch. > * ERROR: code indent should never use tabs > * ERROR: space prohibited after that open square bracket '[' >

Re: [Qemu-devel] [PATCH 18/29] target-sparc: use SparcV9MMU type for sparc64 I/D-MMUs

2016-10-11 Thread Artyom Tarasenko
On Mon, Oct 10, 2016 at 10:13 PM, Richard Henderson wrote: > On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: >> >> -//typedef struct SparcMMU >> -union { >> -uint64_t immuregs[16]; >> -struct { >> -uint64_t tsb_tag_target; >> -uint64_t unused_mmu_pri

Re: [Qemu-devel] [PATCH 15/29] target-sparc: allow priveleged ASIs in hyperprivileged mode

2016-10-11 Thread Richard Henderson
On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: @@ -1295,10 +1295,9 @@ uint64_t helper_ld_asi(CPUSPARCState *env, target_ulong addr, asi &= 0xff; -if ((asi < 0x80 && (env->pstate & PS_PRIV) == 0) -|| (cpu_has_hypervisor(env) -&& asi >= 0x30 && asi < 0x80 -

Re: [Qemu-devel] [PATCH v4 03/20] ppc/pnv: add a core mask to PnvChip

2016-10-11 Thread David Gibson
On Mon, Oct 10, 2016 at 02:56:25PM +0200, Cédric Le Goater wrote: > > >> @@ -227,11 +227,44 @@ static void ppc_powernv_init(MachineState *machine) > >> snprintf(chip_name, sizeof(chip_name), "chip[%d]", CHIP_HWID(i)); > >> object_property_add_child(OBJECT(pnv), chip_name, chip,

Re: [Qemu-devel] [PATCH 16/29] target-sparc: ignore writes to UA2005 CPU mondo queue register

2016-10-11 Thread Richard Henderson
On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: Signed-off-by: Artyom Tarasenko --- target-sparc/ldst_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-sparc/ldst_helper.c b/target-sparc/ldst_helper.c index 70febcb..250c23f 100644 --- a/target-sparc/ldst_helper

Re: [Qemu-devel] [PATCH 20/29] target-sparc: simplify ultrasparc_tsb_pointer

2016-10-11 Thread Richard Henderson
On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: Signed-off-by: Artyom Tarasenko --- target-sparc/ldst_helper.c | 51 ++ 1 file changed, 15 insertions(+), 36 deletions(-) Perhaps this should be folded with patch 19. +static uint64_t ultrasparc_tsb_

  1   2   3   4   >