Re: [Qemu-devel] [PATCH v4 4/9] virtio: handle virtqueue_map_desc() errors

2016-09-21 Thread Greg Kurz
On Tue, 20 Sep 2016 15:49:33 +0100 Stefan Hajnoczi wrote: > Errors can occur during virtqueue_pop(), especially in > virtqueue_map_desc(). In order to handle this we must unmap iov[] > before returning NULL. The caller will consider the virtqueue empty and > the virtio_error() call will have ma

Re: [Qemu-devel] [PATCH v3 04/10] ppc/pnv: add a PIR handler to PnvChip

2016-09-21 Thread Cédric Le Goater
On 09/21/2016 03:29 AM, David Gibson wrote: > On Thu, Sep 15, 2016 at 02:45:54PM +0200, Cédric Le Goater wrote: >> P9 and P8 have some differences in the CPU PIR encoding. > > The thread id isn't in the PIR at all? The thread id from what I have seen is basically a +1. So this is why in PnvCore t

Re: [Qemu-devel] [PATCH v3 05/10] ppc/pnv: add a PnvCore object

2016-09-21 Thread Cédric Le Goater
On 09/21/2016 03:51 AM, David Gibson wrote: > On Thu, Sep 15, 2016 at 02:45:55PM +0200, Cédric Le Goater wrote: >> This is largy inspired by sPAPRCPUCore with some simplification, no >> hotplug for instance. But the differences are small and the objects >> could possibly be merged. >> >> A set of P

Re: [Qemu-devel] [V0 1/1] virtio crypto device specification: asymmetric crypto service

2016-09-21 Thread Gonglei (Arei)
Hi Xin, Here you go. ;) > -Original Message- > From: Xin Zeng [mailto:xin.z...@intel.com] > Sent: Wednesday, September 21, 2016 1:15 PM > To: virtio-...@lists.oasis-open.org; qemu-devel@nongnu.org; Gonglei (Arei) > Cc: m...@redhat.com; brian.a.keat...@intel.com; john.grif...@intel.com; >

Re: [Qemu-devel] [PATCH v3 05/10] ppc/pnv: add a PnvCore object

2016-09-21 Thread Cédric Le Goater
On 09/21/2016 04:05 AM, Benjamin Herrenschmidt wrote: > On Wed, 2016-09-21 at 11:51 +1000, David Gibson wrote: >> Ok, as noted elsewhere, I think you need to disassociate the PIR value >> from the cpu_index. It may be a little less elegant, but it'll make >> your life much easier in the short and

Re: [Qemu-devel] [PATCH v3 01/10] ppc/pnv: add skeleton PowerNV platform

2016-09-21 Thread Cédric Le Goater
On 09/20/2016 09:53 AM, David Gibson wrote: > On Thu, Sep 15, 2016 at 02:45:51PM +0200, Cédric Le Goater wrote: >> From: Benjamin Herrenschmidt >> >> The goal is to emulate a PowerNV system at the level of the skiboot >> firmware, which loads the OS and provides some runtime services. Power >> Sys

Re: [Qemu-devel] [PATCH]MC146818 RTC: coordinate guest clock base to destination host after migration

2016-09-21 Thread zhong...@sangfor.com.cn
Hi, Paolo YES, in terms of logic, both approaches do nearly the same things, and meanwhile, your approach is quite simple. exactly, I like it really. I tried to accept your way, but I found there is still some key difference between them, especially in terms of design and concept model. What th

Re: [Qemu-devel] [PATCH V4 0/2] Add option to configure guest vPMU

2016-09-21 Thread Andrew Jones
On Tue, Sep 20, 2016 at 10:33:52PM -0400, Wei Huang wrote: > This patchset adds a pmu=[on/off] option to enable/disable vPMU support > for guest VM. There are several reasons to justify this option. First, > vPMU can be problematic for cross-migration between different SoC as perf > counters are a

Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure

2016-09-21 Thread Benjamin Herrenschmidt
On Wed, 2016-09-21 at 15:56 +1000, David Gibson wrote: > > Yes, I think that's the way to go. > > That also means on P9 you can potentially just map the scom address > space directly into address_space_memory, instead of requiring a > redispatcher to do the address mangling. No. You still need a

Re: [Qemu-devel] [PATCH v3 02/10] ppc/pnv: add a PnvChip object

2016-09-21 Thread Cédric Le Goater
On 09/20/2016 03:50 PM, David Gibson wrote: > On Thu, Sep 15, 2016 at 02:45:52PM +0200, Cédric Le Goater wrote: >> This is is an abstraction of a POWER8 chip which is a set of cores >> plus other 'units', like the pervasive unit, the interrupt controller, >> the memory controller, the on-chip micro

Re: [Qemu-devel] KVM-PR is broken with current QEMU

2016-09-21 Thread Thomas Huth
On 20.09.2016 23:45, Benjamin Herrenschmidt wrote: > On Tue, 2016-09-20 at 13:44 +0200, Thomas Huth wrote: >> >> Seems like KVM PR is using the "degraded" ISA variants (without the >> 1TB >> segments), but the new POWERPC_MMU_64K flag has not been added to >> those. >> Has this been done on purpose

Re: [Qemu-devel] [RFC] test/docker/Makefile.include: add a generic docker-run target

2016-09-21 Thread Alex Bennée
Fam Zheng writes: > On Tue, 09/20 14:56, Alex Bennée wrote: >> This re-factors the docker makefile to include a docker-run target which >> can be controlled entirely from environment variables specified on the >> make command line. This allows us to run against any given docker image >> we may h

Re: [Qemu-devel] [PATCH V4 1/2] arm64: Add an option to turn on/off vPMU support

2016-09-21 Thread Andrew Jones
On Tue, Sep 20, 2016 at 10:33:53PM -0400, Wei Huang wrote: > This patch adds a pmu=[on/off] option to enable/disable vPMU support > in guest vCPU. This option is only available for cortex-a57/cortex-53/ > host under both TCG and KVM modes, but unavailable on ARMv7 and other > processors. It allows

Re: [Qemu-devel] [PATCH v3 03/10] ppc/pnv: add a core mask to PnvChip

2016-09-21 Thread Cédric Le Goater
On 09/20/2016 03:57 PM, David Gibson wrote: > On Thu, Sep 15, 2016 at 02:45:53PM +0200, Cédric Le Goater wrote: >> This will be used to build real HW ids for the cores and enforce some >> limits on the available cores per chip. >> >> Signed-off-by: Cédric Le Goater >> --- >> >> Changes since v2 :

Re: [Qemu-devel] [PATCH V4 2/2] arm: virt: add PMU property to mach-virt machine type

2016-09-21 Thread Andrew Jones
On Tue, Sep 20, 2016 at 10:33:54PM -0400, Wei Huang wrote: > CPU vPMU is now turned off by default, but it was ON in virt-2.7 > machine type. To solve this problem, this patch adds a PMU option > in machine state, which is used to control CPU's vPMU status. This > PMU option is not exposed to comma

Re: [Qemu-devel] [PATCH v3 06/10] monitor: fix crash for platforms without a CPU 0

2016-09-21 Thread Cédric Le Goater
On 09/21/2016 07:30 AM, David Gibson wrote: > On Thu, Sep 15, 2016 at 02:45:56PM +0200, Cédric Le Goater wrote: >> On PowerNV, CPU ids start at 0x8 or 0x20, we don't have a CPU 0 >> anymore. So let's use the first_cpu index to initialize the monitor. >> >> Signed-off-by: Cédric Le Goater > > I've

[Qemu-devel] [PATCH 0/2] target-mips: rework conditional stores for mttcg

2016-09-21 Thread Leon Alrae
This small series changes MIPS conditional stores implementation for mttcg. Specifically we compare virtual address of LL and SC (rather than physical) which allows us to have just a single inlined implementation for user and system emulation and to use new atomic helpers. This is done in 2 steps:

[Qemu-devel] [PATCH 2/2] target-mips: reimplement SC instruction and use cmpxchg

2016-09-21 Thread Leon Alrae
This patch completely rewrites conditional stores. Now we use cmpxchg and no longer need separate implementations for user and system emulation. Signed-off-by: Leon Alrae --- linux-user/main.c | 58 -- target-mips/cpu.h | 4 -- target-mips/helper.c| 6

[Qemu-devel] [PATCH 1/2] target-mips: compare virtual addresses in LL/SC sequence

2016-09-21 Thread Leon Alrae
Until now we have been comparing physical addresses in LL/SC sequence. Unfortunately that means that on each SC we have to do the address translation which is a quite complex operation. If we could get rid of it then it would allow us to throw away SC helpers and benefit from having common implemen

Re: [Qemu-devel] [RFC] test/docker/Makefile.include: add a generic docker-run target

2016-09-21 Thread Fam Zheng
On Wed, 09/21 08:50, Alex Bennée wrote: > > Fam Zheng writes: > > > On Tue, 09/20 14:56, Alex Bennée wrote: > >> This re-factors the docker makefile to include a docker-run target which > >> can be controlled entirely from environment variables specified on the > >> make command line. This allow

Re: [Qemu-devel] [Qemu-ppc] KVM-PR is broken with current QEMU

2016-09-21 Thread Thomas Huth
On 20.09.2016 16:39, Cédric Le Goater wrote: > On 09/20/2016 04:24 PM, Thomas Huth wrote: >> On 20.09.2016 16:04, Cédric Le Goater wrote: [...] >>> There are other issues after in the guest (kernel crashing). But I think >>> these are related to TM which is not supported in KVM-PR. I am not sure >>

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-21 Thread Daniel P. Berrange
On Tue, Sep 20, 2016 at 07:21:07PM +0200, Paolo Bonzini wrote: > > > On 20/09/2016 17:14, Daniel P. Berrange wrote: > > Any VM which > > uses the separate namespace is tainted, which means if theres a bug > > report we'll require the reported to remove whatever config caused > > the tainting and

[Qemu-devel] [Bug 1625987] [NEW] target-arm/translate-a64.c:2028: possible coding error ?

2016-09-21 Thread dcb
Public bug reported: target-arm/translate-a64.c:2028:37: warning: ?: using integer constants in boolean context [-Wint-in-bool-context] Source code is bool iss_sf = opc == 0 ? 32 : 64; Maybe better code bool iss_sf = (opc == 0) ? 32 : 64; ** Affects: qemu Importance: Unde

Re: [Qemu-devel] [PATCH 1/9] docker: Generate /packages.txt in centos6 image

2016-09-21 Thread Daniel P. Berrange
On Wed, Sep 21, 2016 at 11:49:20AM +0800, Fam Zheng wrote: > Put the list of package names in an environment, and output their > package names to the target file in the end. > > Signed-off-by: Fam Zheng > --- > tests/docker/dockerfiles/centos6.docker | 6 -- > 1 file changed, 4 insertions(+)

Re: [Qemu-devel] [PATCH 3/9] docker: Generate /packages.txt in ubuntu image

2016-09-21 Thread Daniel P. Berrange
On Wed, Sep 21, 2016 at 11:49:22AM +0800, Fam Zheng wrote: > Put the list of package names in an environment, and output their > package names to the target file in the end. > > Signed-off-by: Fam Zheng > --- > tests/docker/dockerfiles/ubuntu.docker | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [Qemu-devel] [PATCH 2/9] docker: Generate /packages.txt in fedora image

2016-09-21 Thread Daniel P. Berrange
On Wed, Sep 21, 2016 at 11:49:21AM +0800, Fam Zheng wrote: > Put the list of package names in an environment, and output their > package names to the target file in the end. > > Signed-off-by: Fam Zheng > --- > tests/docker/dockerfiles/fedora.docker | 14 -- > 1 file changed, 12 inse

Re: [Qemu-devel] [PATCH 4/9] docker: Update fedora image to latest

2016-09-21 Thread Daniel P. Berrange
On Wed, Sep 21, 2016 at 11:49:23AM +0800, Fam Zheng wrote: > Now that 23 is becoming an "old" release with 24 available. Fedora has a > quick release cycle, so use latest to follow more closely. > > Signed-off-by: Fam Zheng > --- > tests/docker/dockerfiles/fedora.docker | 2 +- > 1 file changed,

Re: [Qemu-devel] [PATCH 7/9] docker: Support showing environment information

2016-09-21 Thread Daniel P. Berrange
On Wed, Sep 21, 2016 at 11:49:26AM +0800, Fam Zheng wrote: > Add a make variable SHOW_ENV. When it's set to non empty, print the > package information and environment variables. > > Signed-off-by: Fam Zheng > --- > tests/docker/Makefile.include | 2 +- > tests/docker/run | 11 +

Re: [Qemu-devel] [PATCH 5/9] docker: Flatten default target list in test-quick

2016-09-21 Thread Daniel P. Berrange
On Wed, Sep 21, 2016 at 11:49:24AM +0800, Fam Zheng wrote: > Previously it is expanded to a whitespace separated list which is not > the most appropriate format. Since it's only two items, flatten it. > > Signed-off-by: Fam Zheng > --- > tests/docker/test-quick | 2 +- > 1 file changed, 1 insert

Re: [Qemu-devel] [PATCH 6/9] docker: Print used options before doing configure

2016-09-21 Thread Daniel P. Berrange
On Wed, Sep 21, 2016 at 11:49:25AM +0800, Fam Zheng wrote: > This makes the configure command more obvious which usually has useful > information. > > Signed-off-by: Fam Zheng > --- > tests/docker/common.rc | 14 -- > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/

Re: [Qemu-devel] [PATCH v9 07/13] tests: No longer dependent on CONFIG_UUID

2016-09-21 Thread Daniel P. Berrange
On Wed, Sep 21, 2016 at 12:27:20PM +0800, Fam Zheng wrote: > crypto now uses built-in uuid implementation, so this check is not > needed. > > Signed-off-by: Fam Zheng > Reviewed-by: Eric Blake > Reviewed-by: Jeff Cody > --- > tests/test-crypto-block.c | 2 +- > 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [PATCH 9/9] docker: exec $CMD

2016-09-21 Thread Daniel P. Berrange
On Wed, Sep 21, 2016 at 11:49:28AM +0800, Fam Zheng wrote: > This is the last command to run (unless DEBUG), make it 'exec' to > simplify the process tree. > > Signed-off-by: Fam Zheng > --- > tests/docker/run | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --gi

Re: [Qemu-devel] [PATCH 8/9] docker: Terminate instances at SIGTERM and SIGHUP

2016-09-21 Thread Daniel P. Berrange
On Wed, Sep 21, 2016 at 11:49:27AM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/docker/docker.py | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tests/docker/docker.py b/tests/docker/docker.py > index b85c165..552608e 100755 > --- a/tests/docker/d

Re: [Qemu-devel] [PATCH v9 06/13] crypto: Switch to QEMU UUID API

2016-09-21 Thread Daniel P. Berrange
On Wed, Sep 21, 2016 at 12:27:19PM +0800, Fam Zheng wrote: > The uuid generation doesn't return error, so update the function > signature and calling code accordingly. > > Signed-off-by: Fam Zheng > Reviewed-by: Eric Blake > Reviewed-by: Jeff Cody > --- > crypto/block-luks.c | 26 +++--

Re: [Qemu-devel] [PATCH v9 13/13] tests: Ignore test-uuid

2016-09-21 Thread Daniel P. Berrange
On Wed, Sep 21, 2016 at 12:27:26PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/.gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/.gitignore b/tests/.gitignore > index b4a9cfc..24ac6cf 100644 > --- a/tests/.gitignore > +++ b/tests/.gitignore > @@ -70,6

Re: [Qemu-devel] [PATCH v9 12/13] Add UUID files to MAINTAINERS

2016-09-21 Thread Daniel P. Berrange
On Wed, Sep 21, 2016 at 12:27:25PM +0800, Fam Zheng wrote: > I understand that we've been keeping eyes on the uncovered files. Since > I'm adding some more files I volunteer to look after them in the futuer. > > Signed-off-by: Fam Zheng > Reviewed-by: Jeff Cody > --- > MAINTAINERS | 6 ++ >

Re: [Qemu-devel] [PATCH] Add resolutions via the command-line

2016-09-21 Thread Benjamin Herrenschmidt
On Tue, 2016-09-20 at 22:54 -0400, G 3 wrote: > You really want to remove the included list of resolutions? I was   > thinking about adding a lot more built-in resolutions in another   > patch. A built-in list is very convenient. I mean remove it from the driver and put it in OpenBIOS instead. Ie

Re: [Qemu-devel] [Qemu-ppc] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth

2016-09-21 Thread Benjamin Herrenschmidt
On Wed, 2016-09-21 at 13:18 +1000, David Gibson wrote: > > There are actually a couple of places where I agree with the style > > change, so I'll include that in a futher post after more useful > review > > has been posted (seriously, stylebots are just infuriating). > > So.. as irritating as you

[Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

2016-09-21 Thread Felipe Franciosi
If compiling with -Werror=unused-result, replay-internal.c won't build due to a call to fwrite() where the returned value is ignored. A simple cast to (void) is not sufficient on recent GCCs, so this fixes it. Signed-off-by: Felipe Franciosi --- replay/replay-internal.c | 2 +- 1 file changed, 1

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

2016-09-21 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1474391326-871-1-git-send-email-fel...@nutanix.com Subject: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

Re: [Qemu-devel] [PATCH v4 2/9] ppc/xics: Fix migration failure with kernel-irqchip=off

2016-09-21 Thread David Gibson
On Mon, Sep 19, 2016 at 11:59:30AM +0530, Nikunj A Dadhania wrote: > With a single cpu VM running with kernel-irqchip=off and a flood ping > running in the guest. Migration fails once in few times. > > Found that whenever there is an interrupt (in this case lsi int 3 from > e1000), we raise an int

Re: [Qemu-devel] [PATCH v4 1/9] ppc/xics: account correct irq status

2016-09-21 Thread David Gibson
On Mon, Sep 19, 2016 at 11:59:29AM +0530, Nikunj A Dadhania wrote: > Fix inconsistent irq status, because of this in the trace logs, for e.g. > LSI status was 0x7, i.e. XICS_STATUS_ASSERTED, XICS_STATUS_SENT and > XICS_STATUS_REJECTED all set, which did not make sense. So the REJECTED > would have

Re: [Qemu-devel] [PATCH v4 4/9] ppc/xics: An ICS with offset 0 is assumed to be uninitialized

2016-09-21 Thread David Gibson
On Mon, Sep 19, 2016 at 11:59:32AM +0530, Nikunj A Dadhania wrote: > From: Benjamin Herrenschmidt > > This will make life easier for dealing with dynamically configured > ICSes such as PHB3 > > Signed-off-by: Benjamin Herrenschmidt > Reviewed-by: David Gibson > Signed-off-by: Nikunj A Dadhania

Re: [Qemu-devel] [PATCH v4 3/9] ppc/xics: Make the ICSState a list

2016-09-21 Thread David Gibson
On Mon, Sep 19, 2016 at 11:59:31AM +0530, Nikunj A Dadhania wrote: > From: Benjamin Herrenschmidt > > Instead of an array of fixed sized blocks, use a list, as we will need > to have sources with variable number of interrupts. SPAPR only uses > a single entry. Native will create more. If performa

Re: [Qemu-devel] [PATCH]MC146818 RTC: coordinate guest clock base to destination host after migration

2016-09-21 Thread zhong...@sangfor.com.cn
By the way, is this full patch of you? --- diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c index ea625f2..dd4ef5c 100644 --- a/hw/timer/mc146818rtc.c +++ b/hw/timer/mc146818rtc.c @@ -721,7 +722,7 @@ static int rtc_post_load(void *opaque, int version_id) { RTCState *s = opaque; -

[Qemu-devel] [PULL 00/01] seccomp branch queue

2016-09-21 Thread Eduardo Otubo
The following changes since commit a008535b9fa396226ff9cf78b8ac5f3584bda58e: build-sys: fix make install regression (2016-09-20 11:32:43 +0100) are available in the git repository at: git://github.com/otubo/qemu.git tags/pull-seccomp-20160921 for you to fetch changes up to

[Qemu-devel] [PULL 01/01] seccomp: adding getrusage to the whitelist

2016-09-21 Thread Eduardo Otubo
getrusage is used in a number of places throughout the qemu codebase (notably, in crypto/pbkdf.c). Without this syscall being whitelisted, qemu ends up getting killed by the kernel whenever you try to connect to a VNC console. Signed-off-by: Brian Rak Acked-by: Eduardo Otubo --- qemu-seccomp.c

[Qemu-devel] [PATCH] ppc/kvm: Mark 64kB page size support as disabled if not available

2016-09-21 Thread Thomas Huth
QEMU currently refuses to start with KVM-PR and only prints out qemu: fatal: Unknown MMU model 851972 when being started there. This is because commit 4322e8ced5aaac719 ("ppc: Fix 64K pages support in full emulation") introduced a new POWERPC_MMU_64K bit to indicate support for this page

Re: [Qemu-devel] [RFC] test/docker/Makefile.include: add a generic docker-run target

2016-09-21 Thread Alex Bennée
Fam Zheng writes: > On Wed, 09/21 08:50, Alex Bennée wrote: >> >> Fam Zheng writes: >> >> > On Tue, 09/20 14:56, Alex Bennée wrote: >> >> This re-factors the docker makefile to include a docker-run target which >> >> can be controlled entirely from environment variables specified on the >> >> m

[Qemu-devel] [PATCH v2] linux-user: ppc64: fix ARCH_206 bit in AT_HWCAP

2016-09-21 Thread Michael Walle
Only the POWER[789] CPUs should have the ARCH_206 bit set. This is what the linux kernel does. I guess this was also the intention of commit 0e019746. We have to make sure all *206 bits are set. Before this patch, the flags check in the GET_FEATURES2 macro returned true if _any_ bit was set. This

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

2016-09-21 Thread Felipe Franciosi
> On 21 Sep 2016, at 07:24, Markus Armbruster wrote: > > "Pavel Dovgalyuk" writes: > >>> From: Felipe Franciosi [mailto:fel...@nutanix.com] >>> If compiling with -Werror=unused-result, replay-internal.c won't build >>> due to a call to fwrite() where the returned value is ignored. A simple >>>

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

2016-09-21 Thread Pavel Dovgalyuk
> From: Felipe Franciosi [mailto:fel...@nutanix.com] > > On 21 Sep 2016, at 07:24, Markus Armbruster wrote: > > > > "Pavel Dovgalyuk" writes: > > > >>> From: Felipe Franciosi [mailto:fel...@nutanix.com] > >>> If compiling with -Werror=unused-result, replay-internal.c won't build > >>> due to a ca

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

2016-09-21 Thread Daniel P. Berrange
On Wed, Sep 21, 2016 at 10:00:23AM +, Felipe Franciosi wrote: > > > On 21 Sep 2016, at 07:24, Markus Armbruster wrote: > > > > "Pavel Dovgalyuk" writes: > > > >>> From: Felipe Franciosi [mailto:fel...@nutanix.com] > >>> If compiling with -Werror=unused-result, replay-internal.c won't build

Re: [Qemu-devel] [RFC] test/docker/Makefile.include: add a generic docker-run target

2016-09-21 Thread Fam Zheng
On Wed, 09/21 10:44, Alex Bennée wrote: > > FWIW we already have some coverage of the MacOSX builds via Travis > (although being able to run it quickly on a dev system would be useful). Being able to detect breakage earlier than a pull req bounce from Peter would also be good. > > > > > I haven

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Enable H_CLEAR_MOD and H_CLEAR_REF hypercalls on KVM/PPC64.

2016-09-21 Thread David Gibson
On Wed, Sep 21, 2016 at 01:20:57PM +1000, David Gibson wrote: > On Tue, Aug 30, 2016 at 01:02:47AM +, Nathan Whitehorn wrote: > > These are mandatory per PAPR and available on Linux 4.3 and newer kernels. > > The calls in question are required to run FreeBSD guests with reasonable > > perform

Re: [Qemu-devel] [PATCH v2] linux-user: ppc64: fix ARCH_206 bit in AT_HWCAP

2016-09-21 Thread David Gibson
On Wed, Sep 21, 2016 at 11:57:05AM +0200, Michael Walle wrote: > Only the POWER[789] CPUs should have the ARCH_206 bit set. This is what the > linux kernel does. I guess this was also the intention of commit 0e019746. > We have to make sure all *206 bits are set. > > Before this patch, the flags c

Re: [Qemu-devel] [PATCH] ppc/kvm: Mark 64kB page size support as disabled if not available

2016-09-21 Thread David Gibson
On Wed, Sep 21, 2016 at 11:42:15AM +0200, Thomas Huth wrote: > QEMU currently refuses to start with KVM-PR and only prints out > > qemu: fatal: Unknown MMU model 851972 > > when being started there. This is because commit 4322e8ced5aaac719 > ("ppc: Fix 64K pages support in full emulation")

Re: [Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth

2016-09-21 Thread Alex Bennée
Benjamin Herrenschmidt writes: > On Sun, 2016-08-14 at 15:54 -0700, no-reply@ec2-52-6-146-230.compute- > 1.amazonaws.com wrote: >> Hi, >> >> Your series seems to have some coding style problems. See output >> below for more information: > > Bla bla bla bla ... > > Seriously, we have nazi stylebo

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-09-21 Thread Pradeep Jagadeesh
Hi Greg, Thanks for having a look at patchset. See the replies below. On Fri, 16 Sep 2016 04:33:36 -0400 Pradeep Jagadeesh wrote: Uses throttling APIs to limit I/O bandwidth and number of operations on the fsdev devices. Signed-off-by: Pradeep Jagadeesh --- Hi Pradeep, Please find some

Re: [Qemu-devel] [RFC] test/docker/Makefile.include: add a generic docker-run target

2016-09-21 Thread Alex Bennée
Fam Zheng writes: > On Wed, 09/21 10:44, Alex Bennée wrote: >> >> FWIW we already have some coverage of the MacOSX builds via Travis >> (although being able to run it quickly on a dev system would be useful). > > Being able to detect breakage earlier than a pull req bounce from Peter would > als

[Qemu-devel] [PATCH 0/3] qapi: return 'missing parameter' error

2016-09-21 Thread Marc-André Lureau
Hi, 'monitor: use qmp_dispatch()' patch broke some iotests expecting a 'missing parameter' error. This series fixes qapi visitors to return this error for all types. Marc-André Lureau (3): qapi: return a 'missing parameter' error qapi: clear given pointer iotests: fix expected error message

[Qemu-devel] [PATCH 1/3] qapi: return a 'missing parameter' error

2016-09-21 Thread Marc-André Lureau
The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing parameters, but the qapi qmp_dispatch() code uses QERR_INVALID_PARAMETER_TYPE. Improve qapi code to return QERR_INVALID_PARAMETER_TYPE where appropriate. Signed-off-by: Marc-André Lureau --- qapi/qmp-input-visitor.c | 109 +++

[Qemu-devel] [PATCH 2/3] qapi: clear given pointer

2016-09-21 Thread Marc-André Lureau
Some getters already set *obj argument to NULL early, let's do this for all for consistent behaviour in case of errors. Signed-off-by: Marc-André Lureau --- qapi/qmp-input-visitor.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-inpu

Re: [Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth

2016-09-21 Thread Benjamin Herrenschmidt
On Wed, 2016-09-21 at 11:16 +0100, Alex Bennée wrote: >  > > > > > > total: 428 errors, 73 warnings, 1950 lines checked > > > > > > Your patch has style problems, please review.If any of these > > > errors > > > are false positives report them to the maintainer, see > > > CHECKPATCH in MAINTAINER

[Qemu-devel] [PATCH 3/3] iotests: fix expected error message

2016-09-21 Thread Marc-André Lureau
Missing argument returns a corresponding error message for all types now. Signed-off-by: Marc-André Lureau --- tests/qemu-iotests/087.out | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/087.out b/tests/qemu-iotests/087.out index a95c4b0..b213db2 100644 ---

Re: [Qemu-devel] [PATCH] linux-user: ppc64: set MSR_CM bit for BookE 2.06 MMU

2016-09-21 Thread Michael Walle
Am 2016-08-16 15:56, schrieb Michael Walle: Am 2016-08-16 15:41, schrieb Riku Voipio: On Tue, Aug 16, 2016 at 03:32:56PM +0200, Michael Walle wrote: Am 2016-07-22 17:57, schrieb Alexander Graf: >On 07/22/2016 05:18 PM, Michael Walle wrote: >>64 bit user mode doesn't work for the e5500 core beca

Re: [Qemu-devel] [PATCH v3 00/10] block: Accept qdev IDs in device level QMP commands

2016-09-21 Thread Kevin Wolf
Am 20.09.2016 um 20:01 hat Eric Blake geschrieben: > On 09/20/2016 06:38 AM, Kevin Wolf wrote: > > In order to remove the necessity to use BlockBackend names in the external > > API, > > we already converted all block layer QMP commands on the node level to > > accept > > node names instead of Bl

Re: [Qemu-devel] [PATCH v4 0/9] virtio: avoid exit() when device enters invalid states

2016-09-21 Thread Cornelia Huck
On Tue, 20 Sep 2016 15:49:29 +0100 Stefan Hajnoczi wrote: > v4: > * Rebase to qemu.git/master > * Use "unsigned int" instead of "unsigned" in virtqueue_undo_map_desc() > [Cornelia] > FWIW, any unchanged or only trivially-rebased patch retains my r-b or a-b. > v3: > * Patch 1: Fix typo and

Re: [Qemu-devel] [PATCH v4 4/9] virtio: handle virtqueue_map_desc() errors

2016-09-21 Thread Cornelia Huck
On Wed, 21 Sep 2016 09:02:35 +0200 Greg Kurz wrote: > On Tue, 20 Sep 2016 15:49:33 +0100 > Stefan Hajnoczi wrote: > > > Errors can occur during virtqueue_pop(), especially in > > virtqueue_map_desc(). In order to handle this we must unmap iov[] > > before returning NULL. The caller will consi

[Qemu-devel] [PATCH v2 1/2] util: Introduce qemu_get_pid_name

2016-09-21 Thread Michal Privoznik
This is a small helper that tries to fetch binary name for given PID. Signed-off-by: Michal Privoznik --- include/qemu/osdep.h | 10 ++ util/oslib-posix.c | 37 + util/oslib-win32.c | 7 +++ 3 files changed, 54 insertions(+) diff --git a/incl

[Qemu-devel] [PATCH v2 0/2] Produce better termination message

2016-09-21 Thread Michal Privoznik
v2 of: http://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg04710.html The checkpatch.pl shows the following error for 1/2: ERROR: architecture specific defines should be avoided #63: FILE: util/oslib-posix.c:441: +#if defined(__FreeBSD__) But I guess we should ignore the error, sin

[Qemu-devel] [PATCH v2 2/2] qemu_kill_report: Report PID name too

2016-09-21 Thread Michal Privoznik
When qemu is being killed, its last words are: 2016-08-31T11:48:15.293587Z qemu-system-x86_64: terminating on signal 15 from pid 11180 That's nice, but what process is 11180? What if I told you we can do better: 2016-08-31T11:48:15.293587Z qemu-system-x86_64: terminating on signal 15 from pid

[Qemu-devel] [PATCH v4 4/8] block: implement bdrv_recurse_is_first_non_filter for blkreplay

2016-09-21 Thread Pavel Dovgalyuk
This patch adds bdrv_recurse_is_first_non_filter implementation for blkreplay driver. It allows creating snapshots when blkreplay is enabled. Signed-off-by: Pavel Dovgalyuk --- block/blkreplay.c |9 + 1 file changed, 9 insertions(+) diff --git a/block/blkreplay.c b/block/blkreplay.c

[Qemu-devel] [PATCH v4 0/8] replay additions

2016-09-21 Thread Pavel Dovgalyuk
This set of patches includes several fixes for replay and adds network record/replay for network devices. It also makes possible saving/restoring vmstate in replay mode. Record and replay for network interactions is performed with the network filter. Each backend must have its own instance of the

[Qemu-devel] [PATCH v4 5/8] replay: move internal data to the structure

2016-09-21 Thread Pavel Dovgalyuk
This patch moves replay static variables into the structure to allow saving and loading them with savevm/loadvm. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- replay/replay-events.c |2 +- replay/replay-internal.c | 20 +--- replay/replay-internal.h |

[Qemu-devel] [PATCH v4 6/8] replay: vmstate for replay module

2016-09-21 Thread Pavel Dovgalyuk
This patch introduces vmstate for replay data structures. It allows saving and loading vmstate while replaying. Signed-off-by: Pavel Dovgalyuk --- replay/replay-internal.h |9 + replay/replay-snapshot.c | 40 replay/replay.c |1

[Qemu-devel] [PATCH v4 1/8] record/replay: add network support

2016-09-21 Thread Pavel Dovgalyuk
This patch adds support of recording and replaying network packets in irount rr mode. Record and replay for network interactions is performed with the network filter. Each backend must have its own instance of the replay filter as follows: -netdev user,id=net1 -device rtl8139,netdev=net1 -object

[Qemu-devel] [PATCH v4 7/8] replay: allow replay stopping and restarting

2016-09-21 Thread Pavel Dovgalyuk
This patch fixes bug with stopping and restarting replay through monitor. Signed-off-by: Pavel Dovgalyuk --- block/blkreplay.c| 15 +-- cpus.c |1 + include/sysemu/replay.h |4 replay/replay-events.c |8 replay/replay-internal.

Re: [Qemu-devel] [PATCH] monitor: fix crash for platforms without a CPU 0

2016-09-21 Thread Igor Mammedov
On Wed, 21 Sep 2016 15:29:26 +1000 David Gibson wrote: > Now that we allow CPU hot unplug on a few platforms, we can end up in a > situation where we don't have a CPU with index 0. Or at least we could, > if we didn't have code to explicitly prohibit unplug of CPU 0. > > Longer term we want to

[Qemu-devel] [PATCH v4 3/8] block: don't make snapshots for filters

2016-09-21 Thread Pavel Dovgalyuk
This patch disables snapshotting for block driver filters. It is needed, because snapshots should be created in underlying disk images, not in filters itself. Signed-off-by: Pavel Dovgalyuk --- block/snapshot.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/block/snapshot.c b/block/sn

[Qemu-devel] [PATCH v4 8/8] integratorcp: adding vmstate for save/restore

2016-09-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk VMState added by this patch preserves correct loading of the integratorcp device state. Signed-off-by: Pavel Dovgalyuk --- hw/arm/integratorcp.c | 62 + 1 file changed, 62 insertions(+) diff --git a/hw/arm/integratorcp.c

[Qemu-devel] [PATCH v4 2/8] replay: save/load initial state

2016-09-21 Thread Pavel Dovgalyuk
This patch implements initial vmstate creation or loading at the start of record/replay. It is needed for rewinding the execution in the replay mode. v4 changes: - snapshots are not created by default anymore v3 changes: - added rrsnapshot option Signed-off-by: Pavel Dovgalyuk --- docs/repla

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

2016-09-21 Thread Felipe Franciosi
> On 21 Sep 2016, at 11:07, Daniel P. Berrange wrote: > > On Wed, Sep 21, 2016 at 10:00:23AM +, Felipe Franciosi wrote: >> >>> On 21 Sep 2016, at 07:24, Markus Armbruster wrote: >>> >>> "Pavel Dovgalyuk" writes: >>> > From: Felipe Franciosi [mailto:fel...@nutanix.com] > If compi

[Qemu-devel] QEMU dtc submodule

2016-09-21 Thread Leon Alrae
Hi, What's the procedure to update / who can update QEMU's dtc mirror git://git.qemu.org/dtc.git which is used as submodule? There's a patch series relying on the dtc v1.4.2 tag: https://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg01815.html but the dtc mirror is outdated and that tag is

Re: [Qemu-devel] [PATCH v2 2/8] nvdimm acpi: prebuild nvdimm devices for available slots

2016-09-21 Thread Igor Mammedov
On Fri, 12 Aug 2016 14:54:04 +0800 Xiao Guangrong wrote: > For each NVDIMM present or intended to be supported by platform, > platform firmware also exposes an ACPI Namespace Device under > the root device > > So it builds nvdimm devices for all slots to support vNVDIMM hotplug > > Signed-off-b

Re: [Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth

2016-09-21 Thread Alex Bennée
Benjamin Herrenschmidt writes: > On Wed, 2016-09-21 at 11:16 +0100, Alex Bennée wrote: >> >> > > >> > > total: 428 errors, 73 warnings, 1950 lines checked >> > > >> > > Your patch has style problems, please review.If any of these >> > > errors >> > > are false positives report them to the mainta

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-09-21 Thread Greg Kurz
On Wed, 21 Sep 2016 12:22:25 +0200 Pradeep Jagadeesh wrote: > Hi Greg, > > Thanks for having a look at patchset. > See the replies below. > > > On Fri, 16 Sep 2016 04:33:36 -0400 > > Pradeep Jagadeesh wrote: > > > >> Uses throttling APIs to limit I/O bandwidth and number of operations on the

Re: [Qemu-devel] [PATCH] monitor: fix crash for platforms without a CPU 0

2016-09-21 Thread Eduardo Habkost
On Wed, Sep 21, 2016 at 03:29:26PM +1000, David Gibson wrote: > Now that we allow CPU hot unplug on a few platforms, we can end up in a > situation where we don't have a CPU with index 0. Or at least we could, > if we didn't have code to explicitly prohibit unplug of CPU 0. > > Longer term we wan

[Qemu-devel] [PATCH] virtio-serial: virtio console emergency write support

2016-09-21 Thread Sascha Silbe
Add support for the virtio 1.0 "emergency write" (VIRTIO_CONSOLE_F_EMERG_WRITE) feature. This is useful for early guest debugging and might be used in cases where the guest crashes so badly that it cannot use virtqueues. Disabled for compatibility machines to avoid exposing a new feature to existi

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

2016-09-21 Thread Felipe Franciosi
Actually, I just noticed Pavel is in the middle of submitting a "replay additions" series (currently at v4). Pavel: is this something you can address as part of that series? Thanks, Felipe > On 21 Sep 2016, at 11:12, Felipe Franciosi wrote: > > >> On 21 Sep 2016, at 11:07, Daniel P. Berrange

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

2016-09-21 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Wed, Sep 21, 2016 at 10:00:23AM +, Felipe Franciosi wrote: >> >> > On 21 Sep 2016, at 07:24, Markus Armbruster wrote: >> > >> > "Pavel Dovgalyuk" writes: >> > >> >>> From: Felipe Franciosi [mailto:fel...@nutanix.com] >> >>> If compiling with -Werror=unus

Re: [Qemu-devel] [PATCH v2 0/2] Produce better termination message

2016-09-21 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1474456806.git.mpriv...@redhat.com Subject: [Qemu-devel] [PATCH v2 0/2] Produce better termination message === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(

Re: [Qemu-devel] [PATCH v2 0/2] Produce better termination message

2016-09-21 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: cover.1474456806.git.mpriv...@redhat.com Subject: [Qemu-devel] [PATCH v2 0/2] Produce better terminat

[Qemu-devel] [PATCH v3 02/12] qemu-iotests/067: Avoid blockdev-add with id

2016-09-21 Thread Kevin Wolf
We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. In order to keep the test meaningful, some instances of query-block that want to check whether the node still exists and would now turn up empty must be converted to query-name

[Qemu-devel] [PATCH v3 01/12] qemu-iotests/041: Avoid blockdev-add with id

2016-09-21 Thread Kevin Wolf
We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- tests/qemu-iotests/041 | 71 +++--- 1 file changed, 32 insertions(+), 39 de

[Qemu-devel] [PATCH v3 06/12] qemu-iotests/117: Avoid blockdev-add with id

2016-09-21 Thread Kevin Wolf
We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- tests/qemu-iotests/117 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/117 b

[Qemu-devel] [PATCH v3 04/12] qemu-iotests/081: Avoid blockdev-add with id

2016-09-21 Thread Kevin Wolf
We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- tests/qemu-iotests/081 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/081 b/tes

[Qemu-devel] [PATCH v3 00/12] block: Remove BB interface from blockdev-add/del

2016-09-21 Thread Kevin Wolf
This series makes the next step towards a QAPI interface that doesn't require clients to know about BlockBackends. By removing the support for 'id' from blockdev-add, it becomes a command that always only creates a BDS (with a node name). Existing interfaces have already been changed to accept node

[Qemu-devel] [PATCH v3 08/12] qemu-iotests/124: Avoid blockdev-add with id

2016-09-21 Thread Kevin Wolf
We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- tests/qemu-iotests/124 | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/tests/qem

[Qemu-devel] [PATCH v3 09/12] qemu-iotests/139: Avoid blockdev-add with id

2016-09-21 Thread Kevin Wolf
We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. Some test cases that used to work with an unattached BlockBackend are removed, either because they don't make sense with an attached device or because the equivalent test case

  1   2   3   4   5   >