On 09/20/2016 09:53 AM, David Gibson wrote: > On Thu, Sep 15, 2016 at 02:45:51PM +0200, Cédric Le Goater wrote: >> From: Benjamin Herrenschmidt <b...@kernel.crashing.org> >> >> The goal is to emulate a PowerNV system at the level of the skiboot >> firmware, which loads the OS and provides some runtime services. Power >> Systems have a lower firmware (HostBoot) that does low level system >> initialization, like DRAM training. This is beyond the scope of what >> qemu will address in a PowerNV guest. >> >> No devices yet, not even an interrupt controller. Just to get started, >> some RAM to load the skiboot firmware, the kernel and initrd. The >> device tree is fully created in the machine reset op. >> >> Signed-off-by: Benjamin Herrenschmidt <b...@kernel.crashing.org> >> [clg: - updated for qemu-2.7 >> - replaced fprintf by error_report >> - used a common definition of _FDT macro >> - removed VMStateDescription as migration is not yet supported >> - added IBM Copyright statements >> - reworked kernel_filename handling >> - merged PnvSystem and sPowerNVMachineState >> - removed PHANDLE_XICP >> - added ppc_create_page_sizes_prop helper >> - removed nmi support >> - removed kvm support >> - updated powernv machine to version 2.8 >> - removed chips and cpus, They will be provided in another patches >> - added a machine reset routine to initialize the device tree (also) >> - french has a squelette and english a skeleton. >> - improved commit log. >> - reworked prototypes parameters >> - added a check on the ram size (thanks to Michael Ellerman) >> - fixed chip-id cell >> - changed MAX_CPUS to 2048 >> - simplified memory node creation to one node only >> - removed machine version >> - rewrote the device tree creation with the fdt "rw" routines >> - s/sPowerNVMachineState/PnvMachineState/ >> - etc. >> ] >> Signed-off-by: Cédric Le Goater <c...@kaod.org> > > Looking pretty good, just a couple of minor details noted below.
I will add the fixes in v4. Thanks, C.
