Benjamin Herrenschmidt <b...@kernel.crashing.org> writes: > On Wed, 2016-09-21 at 11:16 +0100, Alex Bennée wrote: >> >> > > >> > > total: 428 errors, 73 warnings, 1950 lines checked >> > > >> > > Your patch has style problems, please review.If any of these >> > > errors >> > > are false positives report them to the maintainer, see >> > > CHECKPATCH in MAINTAINERS. >> >> It seems very unlikely all of the reported errors here can be >> justified >> along the lines of internal consistency, especially for adding a new >> file. > > It's actually an old thread ;-) I've already fixed some of these, just > haven't had a chance to finish and submit a new version.
I'll blame my mailer for bringing old-threads up when new posts are made ;-) > > However *most* of the above are intentional and I won't fix, it's about > the .h file describing the registers that is essentially lifted from > Linux and that I want to keep largely identical for obvious reasons > (thus including the use of tabs). Unless it is highly likely you'll be re-importing changes it is a bit of a thin justification. For things like linux-headers we obviously already have a mechanism that allows for raw import of violating headers. In this case you are just grabbing a bunch of magic numbers that haven't been updated for at least 11 years (if not more, the numbers pre-date Linux's git history). But hey I'll happily defer to the maintainers on this one! -- Alex Bennée
