Re: [Qemu-devel] [PATCH v2 2/7] ppc/pnv: add a PnvChip object

2016-09-05 Thread Benjamin Herrenschmidt
On Mon, 2016-09-05 at 12:58 +1000, David Gibson wrote: > > With the new chip class per cpu class, does this chip_type field > serve > any purpose any more? > > > +    k->chip_f000f = 0x120d30498000ull; > > A comment somewhere explaining what this cryptic value is would be > nice. It's snaps

Re: [Qemu-devel] [PATCH v2 3/7] ppc/pnv: Add XSCOM infrastructure

2016-09-05 Thread Benjamin Herrenschmidt
On Mon, 2016-09-05 at 13:39 +1000, David Gibson wrote: > > +static XScomDevice *xscom_find_target(XScomState *s, uint32_t > pcb_addr, > > +  uint32_t *range) > > +{ > > +    BusChild *bc; > > + > > +    QTAILQ_FOREACH(bc, &s->bus->bus.children, sibling) { > > +  

[Qemu-devel] [PATCH 2/3] memory: add iommu_notify_flag

2016-09-05 Thread Peter Xu
When there are active IOMMU notify registers, the iommu_notify_flag will cache existing notify flag. When notifiers are triggered, flag will be checked against the cached result. Signed-off-by: Peter Xu --- hw/ppc/spapr_iommu.c | 2 +- hw/s390x/s390-pci-inst.c | 2 +- include/exec/memory.h

[Qemu-devel] [PATCH 1/3] memory: add one flag for IOMMU notifier

2016-09-05 Thread Peter Xu
With the new flag, now we allow to register two kinds of IOMMU notifiers: - IOMMU_RW: All DMA mapping changes will be notified. - IOMMU_NONE: will only be notified when there are cache invalidations. Here IOMMU_RW is the original scemantics for existing IOMMU notifiers. VFIO is the only registe

[Qemu-devel] [PATCH 0/3] memory: add IOMMU notifier type

2016-09-05 Thread Peter Xu
In the thread: https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg00254.html Alex proposed a way for vhost DMAR to be enabled without breaking existing protections on vIOMMU and device assignments. This series tried to implement the idea, by introducing a IOMMU notifier type for each IOMM

[Qemu-devel] [PATCH 3/3] intel_iommu: allow IOMMU_NONE typed notifiers

2016-09-05 Thread Peter Xu
Intel vIOMMU is still lacking of a complete IOMMU notifier mechanism. Before that is achieved, let's open a door for vhost DMAR support, which only requires device-IOTLB based cache invalidations (IOMMU_NONE typed notifies). Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 10 ++ 1 fi

Re: [Qemu-devel] [PATCH for-2.8 00/38] s390x patches for 2.8

2016-09-05 Thread David Hildenbrand
> Here are the s390x patches I have queued for 2.8 on s390-next. > > The biggest chunk are the cpumodel patches. Other than that, the > introduction of the 2.8 machine and various fixes and enhancements. > > I plan to send a pull request once 2.7 has been released. Hi Conny, as discussed offlin

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-05 Thread Alexander Graf
On 09/03/2016 05:18 AM, Gonglei (Arei) wrote: Hi, -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Friday, September 02, 2016 10:05 PM Subject: Re: [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification On 02.09.16 14:16, Ola Liljedahl wrote: On 0

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-05 Thread Alexander Graf
On 09/04/2016 05:47 PM, Ola Liljedahl wrote: > > On 02/09/2016, 16:05, "Alexander Graf" wrote: > There is a big problem that the control handle logic is synchronization, but the data queue handling logic is asynchronization. We can't combine them into one queue. It will de

Re: [Qemu-devel] [PATCH v2 2/7] ppc/pnv: add a PnvChip object

2016-09-05 Thread Cédric Le Goater
On 09/05/2016 08:59 AM, Benjamin Herrenschmidt wrote: > On Mon, 2016-09-05 at 12:58 +1000, David Gibson wrote: >> >> With the new chip class per cpu class, does this chip_type field >> serve >> any purpose any more? >> >>> +k->chip_f000f = 0x120d30498000ull; >> >> A comment somewhere explai

[Qemu-devel] [PATCH v4 1/2] pc: Add 2.8 machine

2016-09-05 Thread Longpeng(Mike)
Signed-off-by: Longpeng(Mike) --- hw/i386/pc_piix.c| 17 ++--- hw/i386/pc_q35.c | 16 +--- include/hw/compat.h | 2 ++ include/hw/i386/pc.h | 3 +++ 4 files changed, 32 insertions(+), 6 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index a07dc

[Qemu-devel] [PATCH v4 2/2] target-i386: present virtual L3 cache info for vcpus

2016-09-05 Thread Longpeng(Mike)
Some software algorithms are based on the hardware's cache info, for example, for x86 linux kernel, when cpu1 want to wakeup a task on cpu2, cpu1 will trigger a resched IPI and told cpu2 to do the wakeup if they don't share low level cache. Oppositely, cpu1 will access cpu2's runqueue directly if t

[Qemu-devel] [PATCH] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

2016-09-05 Thread Ashijeet Acharya
Include migrate_set_speed and migrate_set_downtime inside migrate_set_parameters respectively for setting maximum migration speed and expected downtime parameters. Also add the query part for both in qmp and hmp qemu control interfaces. Signed-off-by: Ashijeet Acharya --- hmp-commands.hx

[Qemu-devel] [PATCH v4 0/2] targte-i386: Add virtual L3 cache support

2016-09-05 Thread Longpeng(Mike)
This patchset add virtual L3 cache support. For KVM's linux guest, this will reduces amouts of IPIs under some workloads. In our experiments(vm:1*socket,8*cores,2threads workload:SAP-HANA-PB-testsuite), this reduces 85% guest's resched-IPIs, and the performance improves 7.2%~33.1%. --- Changes s

Re: [Qemu-devel] [libvirt] [PATCH v7 0/4] Add Mediated device support

2016-09-05 Thread Paolo Bonzini
On 03/09/2016 01:57, Laine Stump wrote: >> >> mdevs do not exist on the host (they do not have a driver on the host >> because they are not PCI devices) so they do need any management. At >> least I hope that's good news. :) > > What's your definition of "management"? They don't need the same t

Re: [Qemu-devel] [PATCH 1/1] ARM: ACPI: fix the AML ID format for CPU devices

2016-09-05 Thread Auger Eric
Hi Wei, On 02/09/2016 23:46, Wei Huang wrote: > Current QEMU will stall guest VM booting under ACPI mode when vcpu count > is >= 12. Analyzing the booting log, it turns out that DSDT table can't > be loaded correctly due to "Invalid character(s) in name (0x62303043), > repaired: [C00*]". This is b

[Qemu-devel] [PATCH RESEND v4 1/2] pc: Add 2.8 machine

2016-09-05 Thread Longpeng(Mike)
Signed-off-by: Longpeng(Mike) --- hw/i386/pc_piix.c| 16 +--- hw/i386/pc_q35.c | 13 +++-- include/hw/compat.h | 2 ++ include/hw/i386/pc.h | 3 +++ 4 files changed, 29 insertions(+), 5 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index a07dc81..

[Qemu-devel] [PATCH RESEND v4 2/2] target-i386: present virtual L3 cache info for vcpus

2016-09-05 Thread Longpeng(Mike)
Some software algorithms are based on the hardware's cache info, for example, for x86 linux kernel, when cpu1 want to wakeup a task on cpu2, cpu1 will trigger a resched IPI and told cpu2 to do the wakeup if they don't share low level cache. Oppositely, cpu1 will access cpu2's runqueue directly if t

Re: [Qemu-devel] [PATCH v2 2/7] ppc/pnv: add a PnvChip object

2016-09-05 Thread Cédric Le Goater
On 09/05/2016 04:58 AM, David Gibson wrote: > On Wed, Aug 31, 2016 at 06:34:10PM +0200, Cédric Le Goater wrote: >> This is is an abstraction of a POWER8 chip which is a set of cores >> plus other 'units', like the pervasive unit, the interrupt controller, >> the memory controller, the on-chip micro

Re: [Qemu-devel] [libvirt] [PATCH v7 0/4] Add Mediated device support

2016-09-05 Thread Paolo Bonzini
On 03/09/2016 13:57, John Ferlan wrote: After creating the vGPU, if required by the host driver, all the other type ids would disappear from "virsh nodedev-dumpxml pci__86_00_0" too. >>> >>> Not wanting to make assumptions, but this reads as if I create one type >>> 11 vGPU, then I

Re: [Qemu-devel] [PATCH] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

2016-09-05 Thread Paolo Bonzini
On 05/09/2016 09:45, Ashijeet Acharya wrote: > Include migrate_set_speed and migrate_set_downtime inside > migrate_set_parameters respectively for setting maximum migration > speed and expected downtime parameters. Also add the query part for > both in qmp and hmp qemu control interfaces. > > Si

[Qemu-devel] [PATCH RESEND v4 0/2] targte-i386: Add virtual L3 cache support

2016-09-05 Thread Longpeng(Mike)
This patchset add virtual L3 cache support. For KVM's linux guest, this will reduces amouts of IPIs under some workloads. In our experiments(vm:1*socket,8*cores,2threads workload:SAP-HANA-PB-testsuite), this reduces 85% guest's resched-IPIs, and the performance improves 7.2%~33.1%. --- Changes si

Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: resume collecting stats on vmload

2016-09-05 Thread Roman Kagan
On Sat, Sep 03, 2016 at 01:53:53AM +0300, Michael S. Tsirkin wrote: > On Fri, Sep 02, 2016 at 10:21:58AM +0300, Roman Kagan wrote: > > On Thu, Sep 01, 2016 at 10:26:54PM +0300, Michael S. Tsirkin wrote: > > > I'm sorry - I don't like this patch. This means that > > > virtio_balloon_receive_stats wi

Re: [Qemu-devel] [PATCH 2/3] memory: add iommu_notify_flag

2016-09-05 Thread Paolo Bonzini
On 05/09/2016 09:21, Peter Xu wrote: > void memory_region_notify_iommu(MemoryRegion *mr, > -IOMMUTLBEntry entry) > +IOMMUTLBEntry entry, IOMMUAccessFlags flag) > { > assert(memory_region_is_iommu(mr)); > +assert(flag == mr

Re: [Qemu-devel] [PATCH] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

2016-09-05 Thread Ashijeet Acharya
On Mon, Sep 5, 2016 at 1:31 PM, Paolo Bonzini wrote: > > > On 05/09/2016 09:45, Ashijeet Acharya wrote: >> Include migrate_set_speed and migrate_set_downtime inside >> migrate_set_parameters respectively for setting maximum migration >> speed and expected downtime parameters. Also add the query pa

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-05 Thread Gonglei (Arei)
> > > On 09/03/2016 05:18 AM, Gonglei (Arei) wrote: > > Hi, > > > >> -Original Message- > >> From: Alexander Graf [mailto:ag...@suse.de] > >> Sent: Friday, September 02, 2016 10:05 PM > >> Subject: Re: [PATCH v8 1/2] virtio-crypto: Add virtio crypto device > specification > >> > >> > >> >

Re: [Qemu-devel] [PATCH] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

2016-09-05 Thread Paolo Bonzini
On 05/09/2016 10:11, Ashijeet Acharya wrote: > > > Include migrate_set_speed and migrate_set_downtime inside > > > migrate_set_parameters respectively for setting maximum migration > > > speed and expected downtime parameters. Also add the query part for > > > both in qmp and hmp qemu control int

Re: [Qemu-devel] [PATCH] virtio-blk: Remove hw/virtio/dataplane folder from MAINTAINERS file

2016-09-05 Thread Markus Armbruster
Thomas Huth writes: > The folder does not exist anymore, thus should be removed from the > MAINTAINERS file, too. > > Signed-off-by: Thomas Huth > --- > MAINTAINERS | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index b6fb84e..ff45f8c 100644 > --- a/MAINTAIN

Re: [Qemu-devel] [PATCH] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

2016-09-05 Thread Ashijeet Acharya
On Mon, Sep 5, 2016 at 1:46 PM, Paolo Bonzini wrote: > > > On 05/09/2016 10:11, Ashijeet Acharya wrote: >> > > Include migrate_set_speed and migrate_set_downtime inside >> > > migrate_set_parameters respectively for setting maximum migration >> > > speed and expected downtime parameters. Also add

Re: [Qemu-devel] [PATCH v2 2/7] ppc/pnv: add a PnvChip object

2016-09-05 Thread Benjamin Herrenschmidt
On Mon, 2016-09-05 at 09:41 +0200, Cédric Le Goater wrote: > yeah. I have not found a clear definition of all the bits. > > I will try to make a macro with what I can collect from the  > specs and the code. It's the CFAM stuff, there's some doco internally but nothing releasable publicly... Chee

Re: [Qemu-devel] [PATCH v4 0/2] targte-i386: Add virtual L3 cache support

2016-09-05 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v4 0/2] targte-i386: Add virtual L3 cache support Type: series Message-id: 1473061557-41096-1-git

Re: [Qemu-devel] [Qemu-discuss] Throttle in virtio-net

2016-09-05 Thread Alberto Garcia
On Fri, Sep 02, 2016 at 05:13:40PM +0200, Pradeep Kiruvale wrote: > I am planning to implement throttling functionality for virtio-net > driver using the throttling APIs that exist inside qemu. Hi Pradeep, the problem with implementing throttling for the network is that it's useless if you use t

Re: [Qemu-devel] [PATCH] virtio-blk: Remove hw/virtio/dataplane folder from MAINTAINERS file

2016-09-05 Thread Thomas Huth
On 05.09.2016 10:22, Markus Armbruster wrote: > Thomas Huth writes: > >> The folder does not exist anymore, thus should be removed from the >> MAINTAINERS file, too. >> >> Signed-off-by: Thomas Huth >> --- >> MAINTAINERS | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/MAINTAINERS b/M

Re: [Qemu-devel] [PATCH 2/3] memory: add iommu_notify_flag

2016-09-05 Thread Peter Xu
On Mon, Sep 05, 2016 at 10:04:42AM +0200, Paolo Bonzini wrote: > > > On 05/09/2016 09:21, Peter Xu wrote: > > void memory_region_notify_iommu(MemoryRegion *mr, > > -IOMMUTLBEntry entry) > > +IOMMUTLBEntry entry, IOMMUAccessFlags fla

Re: [Qemu-devel] [Qemu-discuss] Throttle in virtio-net

2016-09-05 Thread Pradeep Kiruvale
Hi Alberto, Thanks for your reply. > > > I am planning to implement throttling functionality for virtio-net > > driver using the throttling APIs that exist inside qemu. > > Hi Pradeep, > > the problem with implementing throttling for the network is that > it's useless if you use the vhost_net ker

[Qemu-devel] [Patch v4 21/30] s390x/kvm: implement CPU model support

2016-09-05 Thread David Hildenbrand
Let's implement our two hooks so we can support CPU models. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- target-s390x/cpu_models.c | 75 +++- target-s390x/cpu_models.h | 50 target-s390x/kvm.c| 295 ++ 3 file

[Qemu-devel] [Patch v4 19/30] linux-headers: update against kvm/next

2016-09-05 Thread David Hildenbrand
Update against 29b4817d4018 ("Linux 4.8-rc1") Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- include/standard-headers/linux/input-event-codes.h | 32 + include/standard-headers/linux/input.h | 1 + include/standard-headers/linux/virtio_config.h | 1

[Qemu-devel] [Patch v4 07/30] s390x/cpumodel: introduce CPU feature group definitions

2016-09-05 Thread David Hildenbrand
Let's use the generated groups to create feature group representations for the user. These groups can later be used to enable/disable multiple features in one shot and will be used to reduce the amount of reported features to the user if all subfeatures are in place. We want to work on features us

[Qemu-devel] [Patch v4 05/30] s390x/cpumodel: generate CPU feature lists for CPU models

2016-09-05 Thread David Hildenbrand
From: Michael Mueller This patch introduces the helper "gen-features" which allows to generate feature list definitions at compile time. Its flexibility is better and the error-proneness is lower when compared to static programming time added statements. The helper includes "target-s390x/cpu_fea

[Qemu-devel] [Patch v4 13/30] s390x/sclp: factor out preparation of cpu entries

2016-09-05 Thread David Hildenbrand
Let's factor out the common code of "read cpu info" and "read scp info". This will make the introduction of new cpu entry fields easier. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- hw/s390x/sclp.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) d

[Qemu-devel] [Patch v4 01/30] qmp: details about CPU definitions in query-cpu-definitions

2016-09-05 Thread David Hildenbrand
It might be of interest for tooling whether a CPU definition can be safely used when migrating, or if e.g. CPU features might get lost during migration when migrationg from/to a different QEMU version or host, even if the same compatibility machine is used. Also, we want to know if a CPU definitio

[Qemu-devel] [Patch v4 16/30] s390x/sclp: propagate the ibc val(lowest and unblocked ibc)

2016-09-05 Thread David Hildenbrand
If we have a lowest ibc, we can indicate the ibc to the guest. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- hw/s390x/sclp.c | 2 ++ include/hw/s390x/sclp.h | 3 ++- target-s390x/cpu_models.c | 21 + target-s390x/cpu_models.h | 12 4

[Qemu-devel] [Patch v4 28/30] s390x/cpumodel: implement QMP interface "query-cpu-model-expansion"

2016-09-05 Thread David Hildenbrand
In order to expand CPU models, we create temporary cpus that handle the feature/group parsing. Only CPU feature properties are expanded. When converting the data structure back, we always fall back to the static base CPU model, which is by definition migration-safe. Acked-by: Cornelia Huck Signe

[Qemu-devel] [Patch v4 14/30] s390x/sclp: introduce sclp feature blocks

2016-09-05 Thread David Hildenbrand
The sclp "read cpu info" and "read scp info" commands can include features for the cpu info and configuration characteristics (extended), decribing some advanced features available in the configuration. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- include/hw/s390x/sclp.h | 12 ++

[Qemu-devel] [Patch v4 06/30] s390x/cpumodel: generate CPU feature group lists

2016-09-05 Thread David Hildenbrand
Feature groups will be very helpful to reduce the amount of features typically available in sane configurations. E.g. the MSA facilities introduced loads of subfunctions, which could - in theory - go away in the future, but we want to avoid reporting hundrets of features to the user if usually all

[Qemu-devel] [Patch v4 09/30] s390x/cpumodel: store the CPU model in the CPU instance

2016-09-05 Thread David Hildenbrand
A CPU model consists of a CPU definition, to which delta changes are applied - features added or removed (e.g. z13-base,vx=on). In addition, certain properties (e.g. cpu id) can later on change during migration but belong into the CPU model. This data will later be filled from the host model in the

[Qemu-devel] [Patch v4 29/30] s390x/cpumodel: implement QMP interface "query-cpu-model-comparison"

2016-09-05 Thread David Hildenbrand
Let's implement that interface by reusing our convertion code implemented for expansion. We use CPU generations and CPU features to calculate the result. This means, that a zEC12 cannot simply be converted into a z13 by stripping of features. This is required, as other magic values (e.g. maximum a

[Qemu-devel] [Patch v4 04/30] s390x/cpumodel: introduce CPU features

2016-09-05 Thread David Hildenbrand
From: Michael Mueller The patch introduces s390x CPU features (most of them refered to as facilities) along with their discription and some functions that will be helpful when working with the features later on. Please note that we don't introduce all known CPU features, only the ones currently

[Qemu-devel] [Patch v4 03/30] s390x/cpumodel: expose CPU class properties

2016-09-05 Thread David Hildenbrand
Let's expose the description and migration safety and whether a definition is static, as class properties, this can be helpful in the future. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- target-s390x/cpu.c| 1 + target-s390x/cpu.h| 1 + target-s390x/cpu_models.

[Qemu-devel] [Patch v4 20/30] s390x/kvm: allow runtime-instrumentation for "none" machine

2016-09-05 Thread David Hildenbrand
To be able to query the correct host model for the "none" machine, let's allow runtime-instrumentation for that machine. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/s390x/s390-virtio-ccw.c b/

[Qemu-devel] [Patch v4 12/30] s390x/cpumodel: check and apply the CPU model

2016-09-05 Thread David Hildenbrand
We have to test if a configured CPU model is runnable in the current configuration, and if not report why that is the case. This is done by comparing it to the maximum supported model (host for KVM or z900 for TCG). Also, we want to do some base sanity checking for a configured CPU model. We'll ca

[Qemu-devel] [Patch v4 00/30] s390x CPU models: exposing features

2016-09-05 Thread David Hildenbrand
Hi, no logical changes this time. In this version, cross-compilation and compilation with mingw32 are fixed. Our feature generation script gen-features has to be compiled for the host architecture, where we do the compilation and bitmaps cannot be directly initialized from the generated data, bec

[Qemu-devel] [Patch v4 15/30] s390x/sclp: indicate sclp features

2016-09-05 Thread David Hildenbrand
We have three different blocks in the SCLP read-SCP information response that indicate sclp features. Let's prepare propagation. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- hw/s390x/sclp.c | 9 + target-s390x/cpu_models.c | 14 ++ target-s390x/cpu

Re: [Qemu-devel] [Patch v4 00/30] s390x CPU models: exposing features

2016-09-05 Thread Cornelia Huck
On Mon, 5 Sep 2016 10:52:14 +0200 David Hildenbrand wrote: > Hi, > > no logical changes this time. > > In this version, cross-compilation and compilation with mingw32 are fixed. > Our feature generation script gen-features has to be compiled for the > host architecture, where we do the compila

[Qemu-devel] [Patch v4 02/30] s390x/cpumodel: "host" and "qemu" as CPU subclasses

2016-09-05 Thread David Hildenbrand
This patch introduces two CPU models, "host" and "qemu". "qemu" is used as default when running under TCG. "host" is used as default when running under KVM. "host" cannot be used without KVM. "host" is not migration-safe. They both inherit from the base s390x CPU, which is turned into an abstract c

[Qemu-devel] [Patch v4 27/30] qmp: add QMP interface "query-cpu-model-baseline"

2016-09-05 Thread David Hildenbrand
Let's provide a standardized interface to baseline two CPU models, to create a third, compatible one. This is especially helpful when two CPU models are not identical, but a CPU model is required that is guaranteed to run under both configurations, where the original models run. "query-cpu-model-b

[Qemu-devel] [Patch v4 17/30] s390x/sclp: propagate the mha via sclp

2016-09-05 Thread David Hildenbrand
The mha is provided in the CPU model, so get any CPU and extract the value. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- hw/s390x/sclp.c | 1 + include/hw/s390x/sclp.h | 3 ++- target-s390x/cpu_models.c | 14 ++ target-s390x/cpu_models.h | 1 + 4 files

[Qemu-devel] [Patch v4 25/30] qmp: add QMP interface "query-cpu-model-expansion"

2016-09-05 Thread David Hildenbrand
Let's provide a standardized interface to expand CPU models. This interface can be used by tooling to get details about a specific CPU model in a certain configuration, e.g. about the "host" model. To take care of all architectures, two detail levels for an expansion are introduced. Certain archit

[Qemu-devel] [Patch v4 10/30] s390x/cpumodel: expose features and feature groups as properties

2016-09-05 Thread David Hildenbrand
Let's add all features and feature groups as properties to all CPU models. If the "host" CPU model is unknown, we can neither query nor change features. KVM will just continue to work like it did until now. We will not allow to enable features that were not part of the original CPU model, because

[Qemu-devel] [Patch v4 08/30] s390x/cpumodel: register defined CPU models as subclasses

2016-09-05 Thread David Hildenbrand
This patch adds the CPU model definitions that are known on s390x - like z900, zBC12 or z13. For each definition, introduce two CPU models: 1. Base model (e.g. z13-base): Minimum feature set we expect to be around on all z13 systems. These models are migration-safe and will never change. 2.

[Qemu-devel] [Patch v4 11/30] s390x/cpumodel: let the CPU model handle feature checks

2016-09-05 Thread David Hildenbrand
If we have certain features enabled, we have to migrate additional state (e.g. vector registers or runtime-instrumentation registers). Let the CPU model control that unless we have no "host" CPU model in the KVM case. This will later on be the case for compatibility machines, so migration from QEMU

[Qemu-devel] [Patch v4 22/30] s390x/kvm: disable host model for problematic compat machines

2016-09-05 Thread David Hildenbrand
Compatibility machines that touch runtime-instrumentation should not be used with the CPU model. Otherwise the host model will look different, depending on the QEMU machine QEMU has been started with. So let's simply disable the host model for existing compatibility machines that all disable ri. T

[Qemu-devel] [Patch v4 30/30] s390x/cpumodel: implement QMP interface "query-cpu-model-baseline"

2016-09-05 Thread David Hildenbrand
Let's implement that interface by reusing our conversion code and lookup code for CPU definitions. In order to find a compatible CPU model, we first detect the maximum possible CPU generation and then try to find a maximum model, satisfying all base features (not exceeding the maximum generation).

[Qemu-devel] [Patch v4 26/30] qmp: add QMP interface "query-cpu-model-comparison"

2016-09-05 Thread David Hildenbrand
Let's provide a standardized interface to compare two CPU models. "query-cpu-model-compare" takes two models and returns how they compare in a specific configuration. The result will give guarantees about runnability. E.g. if a CPU model A is a subset of CPU model B, model A is guaranteed to run

[Qemu-devel] [Patch v4 18/30] s390x/sclp: propagate hmfai

2016-09-05 Thread David Hildenbrand
hmfai is provided on CPU models >= z196. Let's propagate it properly. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- hw/s390x/sclp.c | 1 + include/hw/s390x/sclp.h | 3 ++- target-s390x/cpu_models.c | 14 ++ target-s390x/cpu_models.h | 1 + 4 files chang

[Qemu-devel] [Patch v4 23/30] s390x/kvm: let the CPU model control CMM(A)

2016-09-05 Thread David Hildenbrand
Starting with recent kernels, if the cmma attributes are available, we actually have hardware support. Enabling CMMA then means providing the guest VCPU with CMM, therefore enabling its CMM facility. Let's not blindly enable CMM anymore but let's control it using CPU models. For disabled CPU model

[Qemu-devel] TPM Passthrough

2016-09-05 Thread Kelvin Middleton
Hi all, sorry for the repeat emails...I sent in a question during the days running up to the 2.7 release and I understand you were all busy working to get that complete. My question is about whether my expectations are correct or not with TPM passthrough. I have a known good device but when passe

Re: [Qemu-devel] [virtio-comment] [PATCH] *** Vhost-pci RFC v2 ***

2016-09-05 Thread Marc-André Lureau
Hi On Sat, Sep 3, 2016 at 5:36 PM Wang, Wei W wrote: > Marc-André and I just got different thoughts about a design direction. I > prefer to have all the frontend virtio devices (net, scsi, console etc.) > from the same VM to be supported by one backend vhost-pci device (N-1), > while Marc-André

Re: [Qemu-devel] [PATCH v2 2/7] ppc/pnv: add a PnvChip object

2016-09-05 Thread David Gibson
On Mon, Sep 05, 2016 at 04:59:23PM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2016-09-05 at 12:58 +1000, David Gibson wrote: > > > > With the new chip class per cpu class, does this chip_type field > > serve > > any purpose any more? > > > > > +    k->chip_f000f = 0x120d30498000ull; > >

[Qemu-devel] [Patch v4 24/30] s390x/kvm: don't enable key wrapping if msa3 is disabled

2016-09-05 Thread David Hildenbrand
As the CPU model now controls msa3, trying to set wrapping keys without msa3 being around/enable in the kernel will produce misleading errors. So let's simply not configure key wrapping if msa3 is not enabled and make compat machines with disabled CPU model work correctly. Signed-off-by: David Hi

[Qemu-devel] [PATCH V13 04/12] net/colo.c: add colo.c to define and handle packet

2016-09-05 Thread Zhang Chen
The net/colo.c is used by colo-compare and filter-rewriter. this can share common data structure like net packet, and other functions. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/Makefile.objs | 1 + net/colo-compare.c | 113 ++

Re: [Qemu-devel] [PATCH] scsi: pvscsi: request descriptor data_length to 32 bit

2016-09-05 Thread Paolo Bonzini
On 03/09/2016 08:33, P J P wrote: > From: Prasad J Pandit > > In PVSCSI paravirtual SCSI bus, the request descriptor data > length is defined to be 64 bit. While building SG list from > a request descriptor, it gets truncated to 32bit in routine > 'pvscsi_convert_sglist'. This could lead to an

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-05 Thread Ola Liljedahl
On 05/09/2016, 09:40, "Alexander Graf" wrote: >On 09/04/2016 05:47 PM, Ola Liljedahl wrote: >> >> On 02/09/2016, 16:05, "Alexander Graf" wrote: >> > There is a big problem that the control handle logic is >synchronization, > but the data queue > handling logic is asynchronizati

Re: [Qemu-devel] [libvirt] qapi DEVICE_DELETED event issued *before* instance_finalize?!

2016-09-05 Thread Markus Armbruster
Adding Paolo. Michal Privoznik writes: > On 02.09.2016 01:11, Alex Williamson wrote: >> Hey, >> >> I'm out of my QOM depth, so I'll just beg for help in advance. I >> noticed in testing vfio-pci hotunplug that the host seems to be trying >> to reclaim the device before QEMU is actually done wi

Re: [Qemu-devel] question with usb stick host pass-through do ejection in guest

2016-09-05 Thread Gerd Hoffmann
Hi, > It appears that "eject" the stick in the guest may also actually eject it on > the host, Yes, that is the case. > which however, is not rational. Why? I see the same behavior on physical machines. If I want to use a usb stick after ejecting it I have to unplug and re-plug it. > Could

[Qemu-devel] [PATCH] net: hmp_host_net_remove: Del the -net option of the removed host_net

2016-09-05 Thread Shmulik Ladkani
Upon hmp_host_net_remove(), the appropriate -net client is deleted (according to the given vlan_id and device id), as well as the corresponsing hub port. However, the relevant '-net' option that was added by former hmp_host_net_add() call is still present in "net" options group. This makes the fo

Re: [Qemu-devel] [PATCH v2 1/1] block-backend: allow flush on devices with open tray

2016-09-05 Thread Markus Armbruster
John Snow writes: > On 09/02/2016 01:44 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> If a device still has an attached BDS because the medium has not yet >>> been removed, we will be unable to migrate to a new host because >>> blk_flush will return an error for that backend. >>> >>>

Re: [Qemu-devel] [PATCH v2 0/2] Delay initialization of memory backends

2016-09-05 Thread Markus Armbruster
Eduardo Habkost writes: > While trying to fix the original bug in v1, another bug was fixed > by accident: TCG initialization of dirty_log_mask was broken when > using memory backends. > > The fix, on the other hand, broke vhost-user-test because it > relied on TCG, even though TCG is incompatibl

Re: [Qemu-devel] [libvirt] qapi DEVICE_DELETED event issued *before* instance_finalize?!

2016-09-05 Thread Paolo Bonzini
On 05/09/2016 11:23, Markus Armbruster wrote: >> > >> > On the other hand, it is clearly documented that the DEVICE_DELETED >> > event is sent as soon as guest acknowledges completion of device >> > removal. So libvirt's buggy if we'd follow documentation strictly. But >> > then again, I don't se

Re: [Qemu-devel] [PATCH v2 2/7] ppc/pnv: add a PnvChip object

2016-09-05 Thread Cédric Le Goater
On 09/05/2016 09:41 AM, David Gibson wrote: > On Mon, Sep 05, 2016 at 04:59:23PM +1000, Benjamin Herrenschmidt wrote: >> On Mon, 2016-09-05 at 12:58 +1000, David Gibson wrote: >>> >>> With the new chip class per cpu class, does this chip_type field >>> serve >>> any purpose any more? >>> +

[Qemu-devel] [PATCH V13 00/12] Introduce COLO-Proxy

2016-09-05 Thread Zhang Chen
COLO-proxy is a part of COLO project. COLO project is composed of COLO-frame, COLO-proxy and block-replication. It is used to compare the network package to help COLO decide whether to do checkpoint. With COLO-proxy's help, COLO greatly improves the performance. The filter-redirector, filter-mirro

[Qemu-devel] [PATCH V13 09/12] filter-rewriter: introduce filter-rewriter initialization

2016-09-05 Thread Zhang Chen
Filter-rewriter is a part of COLO project. It will rewrite some of secondary packet to make secondary guest's tcp connection established successfully. In this module we will rewrite tcp packet's ack to the secondary from primary,and rewrite tcp packet's seq to the primary from secondary. usage: c

[Qemu-devel] [PATCH V13 08/12] colo-compare: add TCP, UDP, ICMP packet comparison

2016-09-05 Thread Zhang Chen
We add TCP,UDP,ICMP packet comparison to replace IP packet comparison. This can increase the accuracy of the package comparison. Less checkpoint more efficiency. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo-compare.c | 145 +++

Re: [Qemu-devel] hostdev / iSCSI issue in QEMU 2.7

2016-09-05 Thread Kevin Wolf
Am 01.09.2016 um 22:21 hat Holger Schranz geschrieben: > Hello, > > we need help for an issue we have sice QEMU 2.7. > May be we use the wrong mailing list. If so please let me know which > mail list we have to use to report problems in QEMU. > > Best regards > > Holger Eric, a quick look sugge

[Qemu-devel] [PATCH V13 01/12] docs: Add documentation for COLO-proxy

2016-09-05 Thread Zhang Chen
Introduce the design of COLO-proxy, and how to use it. Signed-off-by: Zhang Chen --- docs/colo-proxy.txt | 188 1 file changed, 188 insertions(+) create mode 100644 docs/colo-proxy.txt diff --git a/docs/colo-proxy.txt b/docs/colo-proxy.txt n

Re: [Qemu-devel] [PATCH 2/3] memory: add iommu_notify_flag

2016-09-05 Thread Paolo Bonzini
On 05/09/2016 10:38, Peter Xu wrote: > However in this patch I was not meant to do that. I made it an > exclusive flag to identify two different use cases. I don't know > whether this is good, but at least for Intel IOMMU's current use case, > these two types should be totally isolated from each

[Qemu-devel] [PATCH V13 11/12] filter-rewriter: rewrite tcp packet to keep secondary connection

2016-09-05 Thread Zhang Chen
We will rewrite tcp packet secondary received and sent. When colo guest is a tcp server. Firstly, client start a tcp handshake. the packet's seq=client_seq, ack=0,flag=SYN. COLO primary guest get this pkt and mirror(filter-mirror) to secondary guest, secondary get it use filter-redirector. Then,pr

[Qemu-devel] [PATCH V13 05/12] Jhash: add linux kernel jhashtable in qemu

2016-09-05 Thread Zhang Chen
Jhash will be used by colo-compare and filter-rewriter to save and lookup net connection info Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- include/qemu/jhash.h | 59 net/colo.h | 1 + 2 files

[Qemu-devel] [PATCH V13 03/12] colo-compare: introduce colo compare initialization

2016-09-05 Thread Zhang Chen
This a COLO net ascii figure: Primary qemu Secondary qemu +--+ ++ | +--

Re: [Qemu-devel] [PATCH] scsi: pvscsi: request descriptor data_length to 32 bit

2016-09-05 Thread Paolo Bonzini
On 05/09/2016 11:50, P J P wrote: > Hello Paolo, all > > +-- On Mon, 5 Sep 2016, Paolo Bonzini wrote --+ > | > -uint64_t data_length = r->req.dataLen; > | > +uint32_t data_length = r->req.dataLen; > | > | Why is this needed if you remove the cast in MIN, below? > > The outer while lo

Re: [Qemu-devel] proposed release timetable for 2.8

2016-09-05 Thread Kevin Wolf
Am 01.09.2016 um 16:08 hat Stefan Hajnoczi geschrieben: > On Thu, Sep 01, 2016 at 12:18:10PM +0100, Peter Maydell wrote: > > I know 2.7 isn't quite out the door yet, but I figured we should > > kick off the discussion of 2.8's schedule. At the QEMU Summit there > > was some discussion on how we're

[Qemu-devel] [PATCH V13 07/12] colo-compare: introduce packet comparison thread

2016-09-05 Thread Zhang Chen
If primary packet is same with secondary packet, we will send primary packet and drop secondary packet, otherwise notify COLO frame to do checkpoint. If primary packet comes but secondary packet does not, after REGULAR_PACKET_CHECK_MS milliseconds we set the primary packet as old_packet,then do a c

Re: [Qemu-devel] [PATCH 06/12] cpus-common: move CPU list management to common code

2016-09-05 Thread Alex Bennée
Paolo Bonzini writes: > Add a mutex for the CPU list to system emulation, as it will be used to > manage safe work. Abstract manipulation of the CPU list in new functions > cpu_list_add and cpu_list_remove. > > Signed-off-by: Paolo Bonzini > index a440bcb..73d0c2f 100644 What tree are you ba

Re: [Qemu-devel] [PATCH] scsi: pvscsi: request descriptor data_length to 32 bit

2016-09-05 Thread P J P
Hello Paolo, all +-- On Mon, 5 Sep 2016, Paolo Bonzini wrote --+ | > -uint64_t data_length = r->req.dataLen; | > +uint32_t data_length = r->req.dataLen; | | Why is this needed if you remove the cast in MIN, below? The outer while loop below is controlled by 'data_length'. The cast in M

[Qemu-devel] [PATCH V13 10/12] filter-rewriter: track connection and parse packet

2016-09-05 Thread Zhang Chen
We use net/colo.h to track connection and parse packet Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo.c| 14 ++ net/colo.h| 1 + net/filter-rewriter.c | 50 ++ 3 f

[Qemu-devel] [PATCH V13 02/12] qemu-char: Add qemu_chr_add_handlers_full() for GMaincontext

2016-09-05 Thread Zhang Chen
Add qemu_chr_add_handlers_full() API, we can use this API pass in a GMainContext,make handler run in the context rather than main_loop. This comments from Daniel P . Berrange. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang Reviewed-by: Daniel P. Berrange --- i

Re: [Qemu-devel] [Patch v4 00/30] s390x CPU models: exposing features

2016-09-05 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [Patch v4 00/30] s390x CPU models: exposing features Type: series Message-id: 20160905085244.99980-1-d...@linux.vnet.ibm.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH V13 12/12] MAINTAINERS: add maintainer for COLO-proxy

2016-09-05 Thread Zhang Chen
add Zhang Chen and Li zhijian as co-maintainers of COLO-proxy. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b6fb84e..4781f9f 100644 --- a/MAINTAINERS

[Qemu-devel] [PATCH V13 06/12] colo-compare: track connection and enqueue packet

2016-09-05 Thread Zhang Chen
In this patch we use kernel jhash table to track connection, and then enqueue net packet like this: + CompareState ++ | | +---+ +---+ +---+ |conn list +--->conn +->conn | +---+ +-

Re: [Qemu-devel] question with usb stick host pass-through do ejection in guest

2016-09-05 Thread Gonglei (Arei)
Hi Gerd, Thank you very much for your reply, it's very useful! Regards, -Gonglei > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Monday, September 05, 2016 4:58 PM > To: wangxin (U) > Cc: qemu-devel@nongnu.org; fuweiwei (C); Gonglei (Arei) > Subject: Re: qu

  1   2   3   4   5   6   >