[Qemu-devel] [PATCH v2] target-i386: present virtual L3 cache info for vcpus

2016-09-01 Thread l00371263
From: "Longpeng(Mike)" Some software algorithms are based on the hardware's cache info, for example, for x86 linux kernel, when cpu1 want to wakeup a task on cpu2, cpu1 will trigger a resched IPI and told cpu2 to do the wakeup if they don't share low level cache. Oppositely, cpu1 will access cpu2

[Qemu-devel] [Bug 1414466] Re: -net user, hostfwd=... is not working(qemu-system-aarch64)

2016-09-01 Thread T. Huth
I think this is not a bug, but you are using the command line parameters in a wrong way. When you use "-net user,hostfwd=tcp:127.0.0.1:1122-:22" you are creating a *new*, second host network device which is not connected to the guest NIC device that you specified. Please try to avoid mixing "-net"

Re: [Qemu-devel] [PATCH v2] scsi: check page count while initialising descriptor rings

2016-09-01 Thread Dmitry Fleytman
> On 1 Sep 2016, at 07:50 AM, P J P wrote: > > Hello Dmitry, > > +-- On Wed, 31 Aug 2016, Dmitry Fleytman wrote --+ > | > -if ((ri->reqRingNumPages > PVSCSI_SETUP_RINGS_MAX_NUM_PAGES) > | > -|| (ri->cmpRingNumPages > PVSCSI_SETUP_RINGS_MAX_NUM_PAGES)) { > | > -return -1; >

Re: [Qemu-devel] [PATCH for 2.8 11/11] vhost_net: device IOTLB support

2016-09-01 Thread Jason Wang
On 2016年09月01日 11:34, Peter Xu wrote: On Tue, Aug 30, 2016 at 11:06:59AM +0800, Jason Wang wrote: This patches implements Device IOTLB support for vhost kernel. This is done through: 1) switch to use dma helpers when map/unmap vrings from vhost codes 2) kernel support for Device IOTLB API: -

Re: [Qemu-devel] [PATCH V12 06/10] colo-compare: introduce packet comparison thread

2016-09-01 Thread Jason Wang
On 2016年09月01日 12:50, Zhang Chen wrote: + sprintf(thread_name, "colo-compare %d", compare_id); +qemu_thread_create(&s->thread, thread_name, + colo_compare_thread, s, + QEMU_THREAD_JOINABLE); +compare_id++; + +/* A regular timer to kick a

Re: [Qemu-devel] [PATCH V12 07/10] colo-compare: add TCP, UDP, ICMP packet comparison

2016-09-01 Thread Jason Wang
On 2016年09月01日 13:00, Zhang Chen wrote: +/* + * The 'identification' field in the IP header is *very* random + * it almost never matches. Fudge this by ignoring differences in + * unfragmented packets; they'll normally sort themselves out if different + * anyway, and it s

Re: [Qemu-devel] [PATCH COLO-Frame v18 00/34] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-09-01 Thread Hailiang Zhang
On 2016/8/26 5:52, Amit Shah wrote: On (Wed) 03 Aug 2016 [20:25:38], zhanghailiang wrote: This is the 18th version of COLO FT feature. It is based on '[PATCH v24 00/12] Block replication for continuous checkpoints' series. The complete codes can be found from the link: https://github.com/colof

[Qemu-devel] [PATCH] spapr: implement H_CHANGE_LOGICAL_LAN_MAC h_call

2016-09-01 Thread Laurent Vivier
Since kernel v4.0, linux uses H_CHANGE_LOGICAL_LAN_MAC to change lively the MAC address of an ibmveth interface. As QEMU doesn't implement this h_call, we can't change anymore the MAC address of an spapr-vlan interface. Signed-off-by: Laurent Vivier --- hw/net/spapr_llan.c | 30

Re: [Qemu-devel] [PATCH] *** Vhost-pci RFC v2 ***

2016-09-01 Thread Wei Wang
On 08/31/2016 08:30 PM, Marc-André Lureau wrote: Hi On Sun, Jun 19, 2016 at 10:19 AM Wei Wang > wrote: This RFC proposes a design of vhost-pci, which is a new virtio device type. The vhost-pci device is used for inter-VM communication. Before I send a

Re: [Qemu-devel] [virtio-comment] [PATCH] *** Vhost-pci RFC v2 ***

2016-09-01 Thread Wei Wang
On 09/01/2016 12:07 AM, Stefan Hajnoczi wrote: On Tue, Aug 30, 2016 at 10:08:01AM +, Wang, Wei W wrote: On Monday, August 29, 2016 11:25 PM, Stefan Hajnoczi wrote: To: Wang, Wei W Cc: k...@vger.kernel.org; qemu-devel@nongnu.org; virtio- comm...@lists.oasis-open.org; m...@redhat.com; pbonz.

Re: [Qemu-devel] [PATCH v2 4/6] virtio-balloon: keep collecting stats on save/restore

2016-09-01 Thread Ladi Prosek
On Fri, Aug 19, 2016 at 3:39 PM, Roman Kagan wrote: > Upon save/restore virtio-balloon stats acquisition stops. The reason is > that the fact that the (only) virtqueue element is being used by QEMU is > not recorded anywhere on save, so upon restore it's not released to the > guest, making furthe

Re: [Qemu-devel] [PATCH] *** Vhost-pci RFC v2 ***

2016-09-01 Thread Marc-André Lureau
Hi On Thu, Sep 1, 2016 at 12:19 PM Wei Wang wrote: > On 08/31/2016 08:30 PM, Marc-André Lureau wrote: > > - If it could be made not pci-specific, a better name for the device could > be simply "driver": the driver of a virtio device. Or the "slave" in > vhost-user terminology - consumer of virtq

[Qemu-devel] [PATCH] tests: Fix broken tcg test compilation

2016-09-01 Thread Michal Privoznik
The first build error to be seen is that linux-test.c fails to include cutils.h: linux-test.c:42:25: fatal error: qemu/cutils.h: No such file or directory This is because toplevel include/ dir is not put onto compiler's command line. After that: qemu.git/include/qemu/cutils.h:171:1: error: unkno

[Qemu-devel] [PATCH] vhost-user: return if no net clients found

2016-09-01 Thread Chen Hanxiao
From: Chen Hanxiao If we can't find a suitable net client, return directly. Or we will got a segmentation fault. Signed-off-by: Chen Hanxiao --- net/vhost-user.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/vhost-user.c b/net/vhost-user.c index b0595f8..fb96db7 100644 --- a/net/v

Re: [Qemu-devel] [PATCH] vhost-user: return if no net clients found

2016-09-01 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] vhost-user: return if no net clients found Type: series Message-id: 1472724830-15537-1-git-send-email-chen_han_x...@126.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=b

Re: [Qemu-devel] [kvm-unit-tests PATCH v3 04/10] arm/arm64: add some delay routines

2016-09-01 Thread Auger Eric
Hi Drew, On 15/07/2016 15:00, Andrew Jones wrote: > Allow a thread to wait some specified amount of time. Can > specify in cycles, usecs, and msecs. > > Reviewed-by: Alex Bennée > Signed-off-by: Andrew Jones > --- > lib/arm/asm/processor.h | 19 +++ > lib/arm/processor.c

Re: [Qemu-devel] [kvm-unit-tests PATCH v3 05/10] arm/arm64: irq enable/disable

2016-09-01 Thread Auger Eric
Hi, On 15/07/2016 15:00, Andrew Jones wrote: > Reviewed-by: Alex Bennée > Signed-off-by: Andrew Jones > --- > lib/arm/asm/processor.h | 10 ++ > lib/arm64/asm/processor.h | 10 ++ > 2 files changed, 20 insertions(+) > > diff --git a/lib/arm/asm/processor.h b/lib/arm/asm/proce

Re: [Qemu-devel] [kvm-unit-tests PATCH v3 07/10] arm/arm64: add initial gicv3 support

2016-09-01 Thread Auger Eric
Hi Drew, On 15/07/2016 15:00, Andrew Jones wrote: > Signed-off-by: Andrew Jones > > --- > v2: configure irqs as NS GRP1 > --- > lib/arm/asm/arch_gicv3.h | 184 ++ > lib/arm/asm/gic-v3.h | 321 > + > lib/arm/asm/gic.h

[Qemu-devel] [PATCH 04/12] linux-user: Use QemuMutex and QemuCond

2016-09-01 Thread Paolo Bonzini
From: Sergey Fedorov Convert pthread_mutex_t and pthread_cond_t to QemuMutex and QemuCond. This will allow to make some locks and conditional variables common between user and system mode emulation. Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov Reviewed-by: Alex Bennée Signed-of

[Qemu-devel] [PATCH 05/12] linux-user: Add qemu_cpu_is_self() and qemu_cpu_kick()

2016-09-01 Thread Paolo Bonzini
From: Sergey Fedorov Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée Message-Id: <1470158864-17651-9-git-send-email-alex.ben...@linaro.org> Signed-off-by: Paolo Bonzini --- linux-user/main.c | 10 ++ 1 file changed, 10

[Qemu-devel] [PATCH 11/12] tcg: Make tb_flush() thread safe

2016-09-01 Thread Paolo Bonzini
From: Sergey Fedorov Use async_safe_run_on_cpu() to make tb_flush() thread safe. This is possible now that code generation does not happen in the middle of execution. It can happen that multiple threads schedule a safe work to flush the translation buffer. To keep statistics and debugging outpu

Re: [Qemu-devel] [kvm-unit-tests PATCH v3 06/10] arm/arm64: add initial gicv2 support

2016-09-01 Thread Auger Eric
On 15/07/2016 15:00, Andrew Jones wrote: > Add some gicv2 support. This just adds init and enable > functions, allowing unit tests to start messing with it. > > Signed-off-by: Andrew Jones > --- > arm/Makefile.common| 1 + > lib/arm/asm/gic-v2.h | 74 > +

[Qemu-devel] [PATCH 08/12] cpus-common: move exclusive work infrastructure from

2016-09-01 Thread Paolo Bonzini
This will serve as the base for async_safe_run_on_cpu. Signed-off-by: Paolo Bonzini --- bsd-user/main.c | 17 --- cpus-common.c | 82 +++ cpus.c| 2 ++ include/qom/cpu.h | 40 - linux-user/main.c |

[Qemu-devel] [PATCH 02/12] cpus: Move common code out of {async_, }run_on_cpu()

2016-09-01 Thread Paolo Bonzini
From: Sergey Fedorov Move the code common between run_on_cpu() and async_run_on_cpu() into a new function queue_work_on_cpu(). Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée Message-Id: <1470158864-17651-4-git-send-email-alex.b

[Qemu-devel] [PATCH 10/12] cpus-common: Introduce async_safe_run_on_cpu()

2016-09-01 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- cpus-common.c | 25 + include/qom/cpu.h | 12 2 files changed, 37 insertions(+) diff --git a/cpus-common.c b/cpus-common.c index 59c8dc8..88cf5ec 100644 --- a/cpus-common.c +++ b/cpus-common.c @@ -144,6 +144,11 @@ void asy

[Qemu-devel] [PATCH v6 00/12] cpu-exec: Safe work in quiescent state

2016-09-01 Thread Paolo Bonzini
This is not the code I promised at the beginning of the week. It's better, and not only in that this one works. :) Instead of reinventing the wheel and using the new wheel for linux-user's start_exclusive/end_exclusive, the linux-user/ code is moved to cpus-common.c and reused as the synchronizati

[Qemu-devel] [PATCH 01/12] cpus: pass CPUState to run_on_cpu helpers

2016-09-01 Thread Paolo Bonzini
From: Alex Bennée CPUState is a fairly common pointer to pass to these helpers. This means if you need other arguments for the async_run_on_cpu case you end up having to do a g_malloc to stuff additional data into the routine. For the current users this isn't a massive deal but for MTTCG this get

[Qemu-devel] [PATCH 03/12] cpus: Rename flush_queued_work()

2016-09-01 Thread Paolo Bonzini
From: Sergey Fedorov To avoid possible confusion, rename flush_queued_work() to process_queued_cpu_work(). Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée Message-Id: <1470158864-17651-6-git-send-email-alex.ben...@linaro.org> Si

[Qemu-devel] [PATCH 06/12] cpus-common: move CPU list management to common code

2016-09-01 Thread Paolo Bonzini
Add a mutex for the CPU list to system emulation, as it will be used to manage safe work. Abstract manipulation of the CPU list in new functions cpu_list_add and cpu_list_remove. Signed-off-by: Paolo Bonzini --- Makefile.target | 2 +- bsd-user/main.c | 9 +- cpus-comm

[Qemu-devel] [PATCH 07/12] cpus-common: move CPU work item management to common

2016-09-01 Thread Paolo Bonzini
From: Sergey Fedorov Make CPU work core functions common between system and user-mode emulation. User-mode does not use run_on_cpu, so do not implement it. Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée Message-Id: <1470158864-

[Qemu-devel] [PATCH 12/12] cpus-common: lock-free fast path for cpu_exec_start/end

2016-09-01 Thread Paolo Bonzini
Set cpu->running without taking the cpu_list lock, only look at it if there is a concurrent exclusive section. This requires adding a new field to CPUState, which records whether a running CPU is being counted in pending_cpus. When an exclusive section is started concurrently with cpu_exec_start,

[Qemu-devel] [PATCH 09/12] cpus-common: always defer async_run_on_cpu work items

2016-09-01 Thread Paolo Bonzini
async_run_on_cpu is only called from the I/O thread, not from CPU threads, so it doesn't make any difference. It will make a difference however for async_safe_run_on_cpu. Signed-off-by: Paolo Bonzini --- cpus-common.c | 5 - 1 file changed, 5 deletions(-) diff --git a/cpus-common.c b/cpus-

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: implement H_CHANGE_LOGICAL_LAN_MAC h_call

2016-09-01 Thread Greg Kurz
On Thu, 1 Sep 2016 10:10:49 +0200 Laurent Vivier wrote: > Since kernel v4.0, linux uses H_CHANGE_LOGICAL_LAN_MAC to change lively > the MAC address of an ibmveth interface. > > As QEMU doesn't implement this h_call, we can't change anymore the > MAC address of an spapr-vlan interface. > > Sign

[Qemu-devel] [PATCH v3] scsi: check page count while initialising descriptor rings

2016-09-01 Thread P J P
From: Prasad J Pandit Vmware Paravirtual SCSI emulation uses command descriptors to process SCSI commands. These descriptors come with their ring buffers. A guest could set the page count for these rings to an arbitrary value, leading to infinite loop or OOB access. Add check to avoid it. Report

Re: [Qemu-devel] [PATCH] aio: Remove spurious smp_read_barrier_depends()

2016-09-01 Thread Paolo Bonzini
On 01/09/2016 00:29, Pranith Kumar wrote: > smp_read_barrier_depends() should be used only if you are reading > dependent pointers which are shared. bh is shared since it is equal to ctx->first_bh or ctx->first_bh->...->next. While the compiler will always order the load of bh->next after the l

Re: [Qemu-devel] [PATCH v2] scsi: check page count while initialising descriptor rings

2016-09-01 Thread P J P
+-- On Thu, 1 Sep 2016, Dmitry Fleytman wrote --+ | In this case, please change pvscsi_ring_init_data() return value type to | void. Also I would suggest to do the new verification after | "trace_pvscsi_on_cmd_arrived("PVSCSI_CMD_SETUP_RINGS”)”. Done; I've sent a revised patch v3. Thank you.

Re: [Qemu-devel] [PATCH] i8257: Make device "i8257" unavailable with -device

2016-09-01 Thread Paolo Bonzini
On 31/08/2016 18:15, Markus Armbruster wrote: > The ISA DMA controller needs to be wired up to the ISA bus by > isa_bus_dma() to actually work. > > Signed-off-by: Markus Armbruster > --- > hw/dma/i8257.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/dma/i8257.c b/hw/dma/i8257.

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: implement H_CHANGE_LOGICAL_LAN_MAC h_call

2016-09-01 Thread Laurent Vivier
On 01/09/2016 12:55, Greg Kurz wrote: > On Thu, 1 Sep 2016 10:10:49 +0200 > Laurent Vivier wrote: > >> Since kernel v4.0, linux uses H_CHANGE_LOGICAL_LAN_MAC to change lively >> the MAC address of an ibmveth interface. >> >> As QEMU doesn't implement this h_call, we can't change anymore the >>

Re: [Qemu-devel] Implementation of BusLogic SCSI host adapter (BT-958)

2016-09-01 Thread Paolo Bonzini
On 31/08/2016 15:48, Денис Дмитриев wrote: > uint64_t buslogicReadOutgoingMailbox(BuslogicState *s, BUSLOGICTASKSTATE > *TaskState) > { > uint64_tGCMailbox; > Mailbox24 Mbx24; > Mbx24.uCmdState = 0; > PCIDevice *pci_dev = PCI_DEVICE(s); > if (s->fMbxIs24Bit) > { >

Re: [Qemu-devel] [PATCH 2/2] scsi: mptconfig: fix an assert expression

2016-09-01 Thread Paolo Bonzini
On 31/08/2016 14:06, P J P wrote: > diff --git a/hw/scsi/mptconfig.c b/hw/scsi/mptconfig.c > index 1ec895b..531947f 100644 > --- a/hw/scsi/mptconfig.c > +++ b/hw/scsi/mptconfig.c > @@ -158,7 +158,7 @@ static size_t mptsas_config_pack(uint8_t **data, const > char *fmt, ...) > va_end(ap); >

[Qemu-devel] proposed release timetable for 2.8

2016-09-01 Thread Peter Maydell
I know 2.7 isn't quite out the door yet, but I figured we should kick off the discussion of 2.8's schedule. At the QEMU Summit there was some discussion on how we're doing with releases, and I think the consensus view was that we should try to cut down the softfreeze period and also be stricter abo

Re: [Qemu-devel] [PATCH v3] scsi: check page count while initialising descriptor rings

2016-09-01 Thread Paolo Bonzini
On 01/09/2016 13:00, P J P wrote: > From: Prasad J Pandit > > Vmware Paravirtual SCSI emulation uses command descriptors to > process SCSI commands. These descriptors come with their ring > buffers. A guest could set the page count for these rings to > an arbitrary value, leading to infinite lo

Re: [Qemu-devel] Implementation of BusLogic SCSI host adapter (BT-958)

2016-09-01 Thread Peter Maydell
On 1 September 2016 at 12:11, Paolo Bonzini wrote: > That said, this looks very much like VirtualBox code. Do not use it if > you want to contribute code to QEMU, because QEMU does not accept > GPLv2-only code. I don't think this is the consensus view. We'd prefer v2-or-later, sure, but we haven

Re: [Qemu-devel] [PATCH] vhost-user: return if no net clients found

2016-09-01 Thread Marc-André Lureau
Hi On Thu, Sep 1, 2016 at 2:15 PM Chen Hanxiao wrote: > From: Chen Hanxiao > > If we can't find a suitable net client, return directly. > Or we will got a segmentation fault. > > Signed-off-by: Chen Hanxiao > --- > net/vhost-user.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/n

Re: [Qemu-devel] [PATCH v3] scsi: check page count while initialising descriptor rings

2016-09-01 Thread Dmitry Fleytman
Reviewed-by: Dmitry Fleytman > On 1 Sep 2016, at 14:00 PM, P J P wrote: > > From: Prasad J Pandit > > Vmware Paravirtual SCSI emulation uses command descriptors to > process SCSI commands. These descriptors come with their ring > buffers. A guest could set the page count for these rings to >

[Qemu-devel] [PATCH 3/4] linux-user: Fix structure target_flock definition for Mips

2016-09-01 Thread Aleksandar Markovic
From: Aleksandar Markovic Structure flock is defined for Mips in a way different from any other platform. For reference, see Linux kernel source code files: arch/mips/include/uapi/asm/fcntl.h#L63 (for Mips) include/uapi/asm-generic/fcntl.h#L195 (for all other platforms) This patch fix this prob

[Qemu-devel] [PATCH 1/4] linux-user: Fix TARGET_SIOCATMARK definition for Mips

2016-09-01 Thread Aleksandar Markovic
From: Aleksandar Markovic This patch fixes wrong definition of TARGET_SIOCATMARK for Mips. The current definition is: #define SIOCATMARK 0x8905 while the correct definition is: #define SIOCATMARK TARGET_IOR('s', 7, int) See Linux kernel source file arch/mips/include/uapi/asm/so

[Qemu-devel] [PATCH 0/3] linux-user: Fix miscellaneous Mips-specific issues

2016-09-01 Thread Aleksandar Markovic
From: Aleksandar Markovic v1 -> v2: - Improved a comment in the patch about target_semid64_ds. - Added a patch that fixes TARGET_SIOCATMARK for Mips. This series fixes several wrong definitions of preprocessor constants and structures in Qemu user mode. It also fixes certain number of LTP t

[Qemu-devel] [PATCH 4/4] linux-user: Fix structure target_semid64_ds definition for Mips

2016-09-01 Thread Aleksandar Markovic
From: Aleksandar Markovic This patch corrects target_semid64_ds structure definition for Mips. See, for example definition of semid64_ds for Mips in Linux kernel: arch/mips/include/uapi/asm/sembuf.h#L13. This patch will also fix certain semaphore-related LTP tests for Mips, if they are executed

[Qemu-devel] [PATCH 2/2] xen_platform: SUSE xenlinux unplug for emulated PCI

2016-09-01 Thread Olaf Hering
Implement SUSE specific unplug protocol for emulated PCI devices in PVonHVM guests. Its a simple 'outl(1, (ioaddr + 4));'. This protocol was implemented and used since Xen 3.0.4. It is used in all SUSE/SLES/openSUSE releases up to SLES11SP3 and openSUSE 12.3. Signed-off-by: Olaf Hering --- hw/i3

Re: [Qemu-devel] [PATCH] vhost-user: return if no net clients found

2016-09-01 Thread Chen Hanxiao
在 2016-09-01 19:43:31,"Marc-André Lureau" 写道: Hi On Thu, Sep 1, 2016 at 2:15 PM Chen Hanxiao wrote: From: Chen Hanxiao If we can't find a suitable net client, return directly. Or we will got a segmentation fault. Signed-off-by: Chen Hanxiao --- net/vhost-user.c | 3 +++ 1 file changed,

Re: [Qemu-devel] [virtio-comment] Re: [PATCH] *** Vhost-pci RFC v2 ***

2016-09-01 Thread Wei Wang
On 09/01/2016 04:49 PM, Marc-André Lureau wrote: Hi On Thu, Sep 1, 2016 at 12:19 PM Wei Wang > wrote: On 08/31/2016 08:30 PM, Marc-André Lureau wrote: - If it could be made not pci-specific, a better name for the device could be simply "driver": the d

[Qemu-devel] [PATCH 0/2] Xen HVM unplug changes

2016-09-01 Thread Olaf Hering
Update unplug in Xen HVM guests to cover more cases. Please review. Olaf Olaf Hering (2): xen_platform: unplug also SCSI disks xen_platform: SUSE xenlinux unplug for emulated PCI hw/i386/xen/xen_platform.c | 36 +++- 1 file changed, 35 insertions(+), 1 deleti

[Qemu-devel] [PATCH 2/4] linux-user: Fix TARGET_F_GETOWN definition for Mips

2016-09-01 Thread Aleksandar Markovic
From: Aleksandar Markovic For some reason, Qemu's TARGET_F_GETOWN constant for Mips does not match the correct value of correspondant F_GETOWN. This patch fixes this problem. For reference, see Mips' F_GETOWN definition in Linux kernel at arch/mips/include/uapi/asm/fcntl.h#L44. This patch also

[Qemu-devel] [PATCH 1/2] xen_platform: unplug also SCSI disks

2016-09-01 Thread Olaf Hering
Using 'vdev=sd[a-o]' will create an emulated LSI controller, which can be used by the emulated BIOS to boot from disk. If the HVM domU has also PV driver the disk may appear twice in the guest. To avoid this an unplug of the emulated hardware is needed, similar to what is done for IDE and NIC drive

Re: [Qemu-devel] [PATCH 0/2] Xen HVM unplug changes

2016-09-01 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 0/2] Xen HVM unplug changes Type: series Message-id: 20160901121131.16007-1-o...@aepfle.de === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline

[Qemu-devel] [Bug 1617929] Re: qemu hangs in pselect syscall

2016-09-01 Thread Peter Maydell
Can you provide sufficient instructions for me to reproduce this on my machine, please? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1617929 Title: qemu hangs in pselect syscall Status in QEMU:

Re: [Qemu-devel] Implementation of BusLogic SCSI host adapter (BT-958)

2016-09-01 Thread Paolo Bonzini
On 01/09/2016 13:19, Peter Maydell wrote: > On 1 September 2016 at 12:11, Paolo Bonzini wrote: >> That said, this looks very much like VirtualBox code. Do not use it if >> you want to contribute code to QEMU, because QEMU does not accept >> GPLv2-only code. > > I don't think this is the consen

Re: [Qemu-devel] [PATCH] vhost-user: return if no net clients found

2016-09-01 Thread Marc-André Lureau
Hi On Thu, Sep 1, 2016 at 4:00 PM Chen Hanxiao wrote: > > Hi, here is the backtrace: > > #0 net_vhost_user_event (opaque=0x7fc2f6893be0, event=5) at > net/vhost-user.c:196 > #1 0x7fc2f4ebfb2b in tcp_chr_disconnect (chr=0x7fc2f68cc400) at > qemu-char.c:2837 > #2 0x7fc2f4ebfba9 in tcp_c

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2016-09-01 Thread Luke Kim
Hello, Peter Maydell we have new qemu-arm hang issue. I guess you are busy for new qemu 2.7 release. But, could you please help us if you have time? https://bugs.launchpad.net/qemu/+bug/1617929 Very thank you in advance :-) -- You received this bug notification because you are a member of qemu-

Re: [Qemu-devel] Implementation of BusLogic SCSI host adapter (BT-958)

2016-09-01 Thread Peter Maydell
On 1 September 2016 at 13:59, Paolo Bonzini wrote: > On 01/09/2016 13:19, Peter Maydell wrote: >> On 1 September 2016 at 12:11, Paolo Bonzini wrote: >>> That said, this looks very much like VirtualBox code. Do not use it if >>> you want to contribute code to QEMU, because QEMU does not accept >>

Re: [Qemu-devel] [virtio-comment] Re: [PATCH] *** Vhost-pci RFC v2 ***

2016-09-01 Thread Marc-André Lureau
Hi On Thu, Sep 1, 2016 at 4:13 PM Wei Wang wrote: > On 09/01/2016 04:49 PM, Marc-André Lureau wrote: > > Hi > > > > On Thu, Sep 1, 2016 at 12:19 PM Wei Wang > > wrote: > > > > On 08/31/2016 08:30 PM, Marc-André Lureau wrote: > > > >> - If it could be made no

Re: [Qemu-devel] [PATCH] spapr: implement H_CHANGE_LOGICAL_LAN_MAC h_call

2016-09-01 Thread Thomas Huth
On 01.09.2016 10:10, Laurent Vivier wrote: > Since kernel v4.0, linux uses H_CHANGE_LOGICAL_LAN_MAC to change lively > the MAC address of an ibmveth interface. > > As QEMU doesn't implement this h_call, we can't change anymore the > MAC address of an spapr-vlan interface. > > Signed-off-by: Laure

Re: [Qemu-devel] Implementation of BusLogic SCSI host adapter (BT-958)

2016-09-01 Thread Denis Dmitriev
2016-09-01 14:11 GMT+03:00 Paolo Bonzini : > > > > On 31/08/2016 15:48, Денис Дмитриев wrote: > > uint64_t buslogicReadOutgoingMailbox(BuslogicState *s, BUSLOGICTASKSTATE > > *TaskState) > > { > > uint64_tGCMailbox; > > Mailbox24 Mbx24; > > Mbx24.uCmdState = 0; > > PCIDevice *

[Qemu-devel] [PATCH RFC] docs: add PCIe devices placement guidelines

2016-09-01 Thread Marcel Apfelbaum
Proposes best practices on how to use PCIe/PCI device in PCIe based machines and explain the reasoning behind them. Signed-off-by: Marcel Apfelbaum --- Hi, Please add your comments on what to add/remove/edit to make this doc usable. Thanks, Marcel docs/pcie.txt | 145

Re: [Qemu-devel] [PATCH RFC] docs: add PCIe devices placement guidelines

2016-09-01 Thread Peter Maydell
On 1 September 2016 at 14:22, Marcel Apfelbaum wrote: > Proposes best practices on how to use PCIe/PCI device > in PCIe based machines and explain the reasoning behind them. > > Signed-off-by: Marcel Apfelbaum > --- > > Hi, > > Please add your comments on what to add/remove/edit to make this doc

Re: [Qemu-devel] [PATCH v2] target-i386: present virtual L3 cache info for vcpus

2016-09-01 Thread Michael S. Tsirkin
On Thu, Sep 01, 2016 at 02:58:05PM +0800, l00371263 wrote: > From: "Longpeng(Mike)" > > Some software algorithms are based on the hardware's cache info, for example, > for x86 linux kernel, when cpu1 want to wakeup a task on cpu2, cpu1 will > trigger > a resched IPI and told cpu2 to do the wakeu

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-01 Thread Alexander Graf
On 08/30/2016 02:12 PM, Gonglei wrote: The virtio crypto device is a virtual crypto device (ie. hardware crypto accelerator card). The virtio crypto device can provide five crypto services: CIPHER, MAC, HASH, AEAD, KDF, ASYM, PRIMITIVE. In this patch, CIPHER, MAC, HASH, AEAD services are introdu

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-09-01 Thread Michael S. Tsirkin
On Wed, Aug 31, 2016 at 01:19:47PM +0200, Maxime Coquelin wrote: > > > On 08/14/2016 11:42 AM, Prerna Saxena wrote: > > On 14/08/16 8:21 am, "Michael S. Tsirkin" wrote: > > > > > > > On Fri, Aug 12, 2016 at 07:16:34AM +, Prerna Saxena wrote: > > > > > > > > On 12/08/16 12:08 pm, "Fam Zhen

Re: [Qemu-devel] [PATCH RFC] docs: add PCIe devices placement guidelines

2016-09-01 Thread Marcel Apfelbaum
On 09/01/2016 04:27 PM, Peter Maydell wrote: On 1 September 2016 at 14:22, Marcel Apfelbaum wrote: Proposes best practices on how to use PCIe/PCI device in PCIe based machines and explain the reasoning behind them. Signed-off-by: Marcel Apfelbaum --- Hi, Please add your comments on what to

Re: [Qemu-devel] proposed release timetable for 2.8

2016-09-01 Thread Stefan Hajnoczi
On Thu, Sep 01, 2016 at 12:18:10PM +0100, Peter Maydell wrote: > I know 2.7 isn't quite out the door yet, but I figured we should > kick off the discussion of 2.8's schedule. At the QEMU Summit there > was some discussion on how we're doing with releases, and I think > the consensus view was that w

Re: [Qemu-devel] [PATCH RFC v2 00/22] I/O prefetch cache

2016-09-01 Thread Kevin Wolf
Am 29.08.2016 um 19:09 hat Pavel Butsykin geschrieben: > The prefetch cache aims to improve the performance of sequential read data. > Of most interest here are the requests of a small size of data for sequential > read, such requests can be optimized by extending them and moving into > the prefet

Re: [Qemu-devel] [PATCH] tests: Fix broken tcg test compilation

2016-09-01 Thread Eric Blake
On 09/01/2016 04:02 AM, Michal Privoznik wrote: > The first build error to be seen is that linux-test.c fails to > include cutils.h: > > linux-test.c:42:25: fatal error: qemu/cutils.h: No such file or directory > > This is because toplevel include/ dir is not put onto compiler's > command line. A

Re: [Qemu-devel] [PATCH RFC v2 01/22] block/pcache: empty pcache driver filter

2016-09-01 Thread Kevin Wolf
Am 29.08.2016 um 19:10 hat Pavel Butsykin geschrieben: > The basic version of pcache driver for easy preparation of a patch set. > > Signed-off-by: Pavel Butsykin > +.bdrv_aio_readv = pcache_aio_readv, > +.bdrv_aio_writev= pcache_aio_writev, Can y

Re: [Qemu-devel] [PATCH RFC v2 03/22] util/rbtree: add rbtree from linux kernel

2016-09-01 Thread Kevin Wolf
Am 29.08.2016 um 19:10 hat Pavel Butsykin geschrieben: > Why don't we use rbtree from glib? We need pointer to the parent node. > For optimal implementation storing of cached chunks in the rbtree > need to get next and previous nodes and content of parent node > is very useful for effective implem

Re: [Qemu-devel] [PATCH] aio: Remove spurious smp_read_barrier_depends()

2016-09-01 Thread Pranith Kumar
On Thu, Sep 1, 2016 at 7:01 AM, Paolo Bonzini wrote: > > > On 01/09/2016 00:29, Pranith Kumar wrote: >> smp_read_barrier_depends() should be used only if you are reading >> dependent pointers which are shared. > > bh is shared since it is equal to ctx->first_bh or > ctx->first_bh->...->next. Whil

Re: [Qemu-devel] [PATCH] vl: Delay initialization of memory backends

2016-09-01 Thread Eduardo Habkost
On Wed, Aug 31, 2016 at 02:47:21PM -0700, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: [...] > GTESTER check-qtest-x86_64 > qemu-system-x86_64: Failed initializing vhost-user memory map, consider using > -object memory-backend-file share=on > qemu-system-x86_64: vhost_set_mem_table fa

Re: [Qemu-devel] [PATCH] aio: Remove spurious smp_read_barrier_depends()

2016-09-01 Thread Paolo Bonzini
On 01/09/2016 16:40, Pranith Kumar wrote: >> > >> > bh is shared since it is equal to ctx->first_bh or >> > ctx->first_bh->...->next. While the compiler will always order the load >> > of bh->next after the load of ctx->first_bh and any previous load of >> > bh->next, this may not be the case fo

Re: [Qemu-devel] Implementation of BusLogic SCSI host adapter (BT-958)

2016-09-01 Thread Paolo Bonzini
On 01/09/2016 15:17, Denis Dmitriev wrote: > > I think that I am missing some initialization or something like that. > To work with the registers I create a memory region, and associate it > with the read and write handlers (as an example I used lsi53c895a.c). > Maybe work with memory in which m

Re: [Qemu-devel] [PATCH RFC v2 00/22] I/O prefetch cache

2016-09-01 Thread Avi Kivity
On 08/29/2016 08:09 PM, Pavel Butsykin wrote: The prefetch cache aims to improve the performance of sequential read data. Of most interest here are the requests of a small size of data for sequential read, such requests can be optimized by extending them and moving into the prefetch cache. Howeve

Re: [Qemu-devel] [PATCH RFC v2 05/22] block/pcache: add aio requests into cache

2016-09-01 Thread Kevin Wolf
Am 29.08.2016 um 19:10 hat Pavel Butsykin geschrieben: > For storing requests use an rbtree, here are add basic operations on the > rbtree to work with cache nodes. > > Signed-off-by: Pavel Butsykin > --- > block/pcache.c | 190 > - > 1 f

Re: [Qemu-devel] [PATCH] vl: Delay initialization of memory backends

2016-09-01 Thread Paolo Bonzini
On 01/09/2016 17:10, Eduardo Habkost wrote: > Ouch. It looks like the ordering requirements are messier than I > thought. vhost-user depends on the memory backends to be already > initialized. You could also look at delaying initialization of vhost-user, not sending anything on the wire until af

Re: [Qemu-devel] [PATCH] Fix memory leak in ide_register_restart_cb()

2016-09-01 Thread Paolo Bonzini
On 01/09/2016 07:31, Ashijeet Acharya wrote: > I am still waiting for review on this one. Hi, QEMU is in hard freeze now so it's normal to have some delay in patch review. Maintainers often use this time to work on their own features. I'm sure John will get to it in short time. Paolo > On Tue

Re: [Qemu-devel] [PATCH v2 4/6] virtio-balloon: keep collecting stats on save/restore

2016-09-01 Thread Ladi Prosek
On Thu, Sep 1, 2016 at 4:17 PM, Roman Kagan wrote: > On Thu, Sep 01, 2016 at 10:35:49AM +0200, Ladi Prosek wrote: >> On Fri, Aug 19, 2016 at 3:39 PM, Roman Kagan wrote: >> > Upon save/restore virtio-balloon stats acquisition stops. The reason is >> > that the fact that the (only) virtqueue eleme

Re: [Qemu-devel] [PATCH] Fix memory leak in ide_register_restart_cb()

2016-09-01 Thread Ashijeet Acharya
On Thu, Sep 1, 2016 at 9:13 PM, Paolo Bonzini wrote: > On 01/09/2016 07:31, Ashijeet Acharya wrote: >> I am still waiting for review on this one. > > Hi, > > QEMU is in hard freeze now so it's normal to have some delay in patch > review. Maintainers often use this time to work on their own featur

Re: [Qemu-devel] [PATCH v2 4/6] virtio-balloon: keep collecting stats on save/restore

2016-09-01 Thread Roman Kagan
On Thu, Sep 01, 2016 at 10:35:49AM +0200, Ladi Prosek wrote: > On Fri, Aug 19, 2016 at 3:39 PM, Roman Kagan wrote: > > Upon save/restore virtio-balloon stats acquisition stops. The reason is > > that the fact that the (only) virtqueue element is being used by QEMU is > > not recorded anywhere on

[Qemu-devel] Deprecate/remove AIX host support? Solaris?

2016-09-01 Thread Peter Maydell
Hi; I was wondering whether we should remove the probably-broken and certainly-untested support for some of the more obscure host OSes we have ifdefs lurking around for. AIX host support seems like an easy one to me. As far as I can tell it's been impossible to build QEMU since 2013 without editin

Re: [Qemu-devel] [PATCH] doc/rcu: fix typo

2016-09-01 Thread Paolo Bonzini
On 01/09/2016 04:21, Cao jin wrote: > Signed-off-by: Cao jin > --- > docs/rcu.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/rcu.txt b/docs/rcu.txt > index 2f70954..a70b72c 100644 > --- a/docs/rcu.txt > +++ b/docs/rcu.txt > @@ -37,7 +37,7 @@ do not matter; as

Re: [Qemu-devel] [PATCH v5 2/5] target-ppc: add vector extract instructions

2016-09-01 Thread Richard Henderson
On 08/31/2016 11:36 PM, Rajalakshmi Srinivasaraghavan wrote: +#if defined(HOST_WORDS_BIGENDIAN) +#define VEXTRACT(suffix, element)\ +void helper_vextract##suffix(ppc_avr_t *r, ppc_avr_t *b, uint32_t index) \ +{

Re: [Qemu-devel] Deprecate/remove AIX host support? Solaris?

2016-09-01 Thread Karel Gardas
>From time to time I'm using Qemu on my Solaris 11/amd64 workstation. But as in case of AIX, Solaris build was neither done easily in IIRC I also tweaked configure in a place or two. So if you keep it, good, if not, no end of world as I'm planning to migrate to some other OS anyway in the future be

[Qemu-devel] how to monitor vm exit

2016-09-01 Thread Yuxin Ren
Hi All, I have two questions. 1. How can I track how many vm exit happens during vm execution using KVM under Ubuntu? 2. How can I config KVM to enable/disable conditional vm exiting. For example, how can I disable WBINVD exiting? Thanks a lot Yuxin

Re: [Qemu-devel] [PATCH v2 4/6] virtio-balloon: keep collecting stats on save/restore

2016-09-01 Thread Michael S. Tsirkin
On Thu, Sep 01, 2016 at 05:43:05PM +0200, Ladi Prosek wrote: > On Thu, Sep 1, 2016 at 4:17 PM, Roman Kagan wrote: > > On Thu, Sep 01, 2016 at 10:35:49AM +0200, Ladi Prosek wrote: > >> On Fri, Aug 19, 2016 at 3:39 PM, Roman Kagan wrote: > >> > Upon save/restore virtio-balloon stats acquisition sto

Re: [Qemu-devel] [PATCH 0/2] Xen HVM unplug changes

2016-09-01 Thread Paolo Bonzini
On 01/09/2016 14:11, Olaf Hering wrote: > Update unplug in Xen HVM guests to cover more cases. > Please review. > > Olaf > > Olaf Hering (2): > xen_platform: unplug also SCSI disks > xen_platform: SUSE xenlinux unplug for emulated PCI > > hw/i386/xen/xen_platform.c | 36 ++

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/7] ppc/pnv: add skeleton PowerNV platform

2016-09-01 Thread Greg Kurz
On Wed, 31 Aug 2016 18:34:09 +0200 Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > The goal is to emulate a PowerNV system at the level of the skiboot > firmware, which loads the OS and provides some runtime services. Power > Systems have a lower firmware (HostBoot) that does low lev

Re: [Qemu-devel] [PATCH] spapr: implement H_CHANGE_LOGICAL_LAN_MAC h_call

2016-09-01 Thread Laurent Vivier
On 01/09/2016 15:13, Thomas Huth wrote: > On 01.09.2016 10:10, Laurent Vivier wrote: >> Since kernel v4.0, linux uses H_CHANGE_LOGICAL_LAN_MAC to change lively >> the MAC address of an ibmveth interface. >> >> As QEMU doesn't implement this h_call, we can't change anymore the >> MAC address of an

Re: [Qemu-devel] [kvm-unit-tests PATCH v3 09/10] arm/arm64: gicv3: add an IPI test

2016-09-01 Thread Auger Eric
Hi Drew, On 15/07/2016 15:00, Andrew Jones wrote: > Signed-off-by: Andrew Jones > > --- > v2: use IRM for gicv3 broadcast > --- > arm/gic.c | 157 > ++ > arm/unittests.cfg | 6 +++ > 2 files changed, 154 insertions(+), 9 deletions(-

Re: [Qemu-devel] [kvm-unit-tests PATCH v3 08/10] arm/arm64: gicv2: add an IPI test

2016-09-01 Thread Auger Eric
Hi Drew, On 15/07/2016 15:00, Andrew Jones wrote: > Signed-off-by: Andrew Jones > --- > v2: add more details in the output if a test fails, > report spurious interrupts if we get them > --- > arm/Makefile.common | 6 +- > arm/gic.c | 194 > +++

Re: [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-01 Thread Michal Privoznik
On 31.08.2016 08:12, Tian, Kevin wrote: >> From: Alex Williamson [mailto:alex.william...@redhat.com] >> Sent: Wednesday, August 31, 2016 12:17 AM >> >> Hi folks, >> >> At KVM Forum we had a BoF session primarily around the mediated device >> sysfs interface. I'd like to share what I think we agree

Re: [Qemu-devel] [PATCH] vl: Delay initialization of memory backends

2016-09-01 Thread Michal Privoznik
On 01.09.2016 17:10, Eduardo Habkost wrote: > On Wed, Aug 31, 2016 at 02:47:21PM -0700, > no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > [...] >> GTESTER check-qtest-x86_64 >> qemu-system-x86_64: Failed initializing vhost-user memory map, consider >> using -object memory-backend-file

Re: [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-01 Thread Alex Williamson
On Thu, 1 Sep 2016 18:47:06 +0200 Michal Privoznik wrote: > On 31.08.2016 08:12, Tian, Kevin wrote: > >> From: Alex Williamson [mailto:alex.william...@redhat.com] > >> Sent: Wednesday, August 31, 2016 12:17 AM > >> > >> Hi folks, > >> > >> At KVM Forum we had a BoF session primarily around the me

  1   2   >