Re: [Qemu-devel] [PATCH V2] add migration capability to bypass the shared memory

2016-08-11 Thread Li, Liang Z
> >> > >> I might have missed something, could you tell me more? > >> > >> void bitmap_set(unsigned long *map, long start, long nr); I think the > >> @start and @nr are both the number of the bits. > >> > >> thanks, > >> Lai > > > > You are right, I have make a mistake by checking the code. Sorry

[Qemu-devel] [PATCH] ui/console: Fix non-working backspace key in monitor of gtk UI

2016-08-11 Thread Thomas Huth
In the QEMU monitor pane of the gtk user interface, the backspace key is not working at all. This happens because of a missing mapping of the key in the qcode_to_keysym[] table. Thus let's add an entry there to get the backspace key working again. Buglink: https://bugs.launchpad.net/qemu/+bug/1611

[Qemu-devel] [Bug 1611979] Re: GTK+ interface, backspace is broken in the monitor console

2016-08-11 Thread T. Huth
Confirmed, this is indeed broken. I sent a patch with a fix to the mailing list: https://marc.info/?i=1470900060-25821-1-git-send-email-thuth%40redhat.com ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which i

[Qemu-devel] [PATCH v3 3/5] target-ppc: add vector count trailing zeros instructions

2016-08-11 Thread Rajalakshmi Srinivasaraghavan
The following vector count trailing zeros instructions are added from ISA 3.0. vctzb - Vector Count Trailing Zeros Byte vctzh - Vector Count Trailing Zeros Halfword vctzw - Vector Count Trailing Zeros Word vctzd - Vector Count Trailing Zeros Doubleword Signed-off-by: Rajalakshmi Srinivasaraghavan

[Qemu-devel] [PATCH v3 1/5] target-ppc: add vector insert instructions

2016-08-11 Thread Rajalakshmi Srinivasaraghavan
The following vector insert instructions are added from ISA 3.0. vinsertb - Vector Insert Byte vinserth - Vector Insert Halfword vinsertw - Vector Insert Word vinsertd - Vector Insert Doubleword Signed-off-by: Rajalakshmi Srinivasaraghavan --- target-ppc/helper.h |4 target

[Qemu-devel] [PATCH v3 4/5] target-ppc: add vector bit permute doubleword instruction

2016-08-11 Thread Rajalakshmi Srinivasaraghavan
Add vbpermd instruction from ISA 3.0. Signed-off-by: Rajalakshmi Srinivasaraghavan --- target-ppc/helper.h |1 + target-ppc/int_helper.c | 22 ++ target-ppc/translate/vmx-impl.c |1 + target-ppc/translate/vmx-ops.c |1 + 4 files changed, 25

[Qemu-devel] [PATCH v3 0/5] POWER9 TCG enablement - part3

2016-08-11 Thread Rajalakshmi Srinivasaraghavan
This series contains 14 new instructions for POWER9 described in ISA3.0. Patches: 01: Adds vector insert instructions. vinsertb - Vector Insert Byte vinserth - Vector Insert Halfword vinsertw - Vector Insert Word vinsertd - Vector Insert Doub

[Qemu-devel] [PATCH v3 2/5] target-ppc: add vector extract instructions

2016-08-11 Thread Rajalakshmi Srinivasaraghavan
The following vector extract instructions are added from ISA 3.0. vextractub - Vector Extract Unsigned Byte vextractuh - Vector Extract Unsigned Halfword vextractuw - Vector Extract Unsigned Word vextractd - Vector Extract Unsigned Doubleword Signed-off-by: Rajalakshmi Srinivasaraghavan --- tar

[Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit()

2016-08-11 Thread Peter Xu
There are many places in current QEMU codes that needs to print some error and then quit QEMU. Provide a macro for it. Also, one coccinelle script is added to convert existing cases to leverage this new macro. Signed-off-by: Peter Xu --- include/qemu/error-report.h| 8

[Qemu-devel] [PATCH 0/2] error-report: introduce error_report_exit()

2016-08-11 Thread Peter Xu
We use these lines frequently in codes: error_report(SOME_ERROR_STRING); exit(1|EXIT_FAILURE); This patchset provide error_report_exit() to do the above in one line. Peter Xu (2): error-report: provide error_report_exit() error-report: leveraging error_report_exit() arch_init.c

[Qemu-devel] [PATCH v3 5/5] target-ppc: add vector permute right indexed instruction

2016-08-11 Thread Rajalakshmi Srinivasaraghavan
Add vpermr instruction from ISA 3.0. Signed-off-by: Rajalakshmi Srinivasaraghavan --- target-ppc/helper.h |1 + target-ppc/int_helper.c | 23 +++ target-ppc/translate/vmx-impl.c | 18 ++ target-ppc/translate/vmx-ops.c |1 + 4 f

[Qemu-devel] [PATCH 2/2] error-report: leveraging error_report_exit()

2016-08-11 Thread Peter Xu
Replace possible places in current codes to leverage the new macro. Most of the changes are done by spatch using error_report_exit.cocci script, with some further manual fixes on the format (line width not exceeding 80 chars). Signed-off-by: Peter Xu --- arch_init.c| 6 +-

Re: [Qemu-devel] [PATCH 0/2] error-report: introduce error_report_exit()

2016-08-11 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 0/2] error-report: introduce error_report_exit() Message-id: 1470901038-9409-1-git-send-email-pet...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=b

[Qemu-devel] [PATCH v2] error-report: leveraging error_report_exit()

2016-08-11 Thread Peter Xu
Replace possible places in current codes to leverage the new macro. Most of the changes are done by spatch using error_report_exit.cocci script, with some further manual fixes on the format (line width not exceeding 80 chars). Signed-off-by: Peter Xu --- V1 of this patch didn't pass checkpatch..

Re: [Qemu-devel] [PATCH] net: vmxnet: initialise local tx descriptor

2016-08-11 Thread Dmitry Fleytman
Reviewed-by: Dmitry Fleytman > On 10 Aug 2016, at 22:12 PM, P J P wrote: > > From: Li Qiang > > In Vmxnet3 device emulator while processing transmit(tx) queue, > when it reaches end of packet, it calls vmxnet3_complete_packet. > In that local 'txcq_descr' object is not initialised, which coul

Re: [Qemu-devel] [PATCH v2] error-report: leveraging error_report_exit()

2016-08-11 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v2] error-report: leveraging error_report_exit() Message-id: 1470902156-11471-1-git-send-email-pe

Re: [Qemu-devel] [PATCH] migration: fix live migration failure with compression

2016-08-11 Thread Dr. David Alan Gilbert
* Amit Shah (amit.s...@redhat.com) wrote: > On (Wed) 10 Aug 2016 [18:58:21], Dr. David Alan Gilbert wrote: > > * Li, Liang Z (liang.z...@intel.com) wrote: > > > > Subject: Re: [PATCH] migration: fix live migration failure with > > > > compression > > > > > > > > * Liang Li (liang.z...@intel.com)

Re: [Qemu-devel] [V1 0/4] AMD-Vi Interrupt Remapping

2016-08-11 Thread David Kiarie
On Thu, Aug 11, 2016 at 9:39 AM, Valentine Sinitsyn < valentine.sinit...@gmail.com> wrote: > Hi David, > > On 11.08.2016 00:42, David Kiarie wrote: > >> Hello all, >> >> The following patchset adds AMD-Vi interrupt remapping logic >> to Qemu and hooks it onto existing interrupt remapping infrastru

Re: [Qemu-devel] [PATCH] net: vmxnet: check fragments count at pkt initialisation

2016-08-11 Thread Dmitry Fleytman
Acked-by: Dmitry Fleytman > On 10 Aug 2016, at 23:38 PM, P J P wrote: > > From: Li Qiang > > When net transport abstraction layer initialises the pkt, > the maximum fragmentation count is not checked. This could > lead to an integer overflow causing a NULL pointer dereference. > Add check to

Re: [Qemu-devel] [PATCH for-2.8 v1 60/60] trace: update docs to reflect new code generation approach

2016-08-11 Thread Daniel P. Berrange
On Wed, Aug 10, 2016 at 06:11:24PM +0200, Lluís Vilanova wrote: > Daniel P Berrange writes: > > > On Wed, Aug 10, 2016 at 04:33:47PM +0200, Lluís Vilanova wrote: > >> Daniel P Berrange writes: > >> > >> > Describe use of per-subdir trace events files and how it impacts > >> > code generation. > >

Re: [Qemu-devel] [PATCH] trace: Remove 'trace_events_dstate_init'

2016-08-11 Thread Daniel P. Berrange
On Wed, Aug 10, 2016 at 06:57:34PM +0200, Lluís Vilanova wrote: > Removes the event state array used for early initialization. Since only > events with the "vcpu" property need a late initialization fixup, > threats their initialization specially. > > Assumes that the user won't touch the state of

Re: [Qemu-devel] [PATCH] net: vmxnet: check fragments count at pkt initialisation

2016-08-11 Thread Dmitry Fleytman
> On 11 Aug 2016, at 11:08 AM, Dmitry Fleytman wrote: > > > Acked-by: Dmitry Fleytman Oops, please ignore this ACK, I replied to the wrong e-mail. As far as I see max_frags for VMXNET3 is a size of device’s TX ring so this will always assert. I don’t think we need this limitation in the de

Re: [Qemu-devel] Dangling change state handler while hot unplugging ahci adapter

2016-08-11 Thread Ashijeet Acharya
On Wed, Aug 10, 2016 at 11:12 AM, Ashijeet Acharya wrote: > On Tue, Aug 9, 2016 at 11:48 PM, John Snow wrote: >> >> >> On 08/09/2016 01:16 PM, Ashijeet Acharya wrote: >>> >>> Hi again, >>> I am still waiting for some guidance...Can I please get some help with >>> this? >>> >>> Also.. I tried hotp

Re: [Qemu-devel] [V15 3/4] hw/i386: Introduce AMD IOMMU

2016-08-11 Thread Valentine Sinitsyn
Hi, On 02.08.2016 13:39, David Kiarie wrote: Add AMD IOMMU emulaton to Qemu in addition to Intel IOMMU. The IOMMU does basic translation, error checking and has a minimal IOTLB implementation. This IOMMU bypassed the need for target aborts by responding with IOMMU_NONE access rights and exempts

Re: [Qemu-devel] [V15 3/4] hw/i386: Introduce AMD IOMMU

2016-08-11 Thread David Kiarie
On Thu, Aug 11, 2016 at 11:23 AM, Valentine Sinitsyn < valentine.sinit...@gmail.com> wrote: > Hi, > > > On 02.08.2016 13:39, David Kiarie wrote: > >> +static void amdvi_writeq_raw(AMDVIState *s, uint64_t val, hwaddr addr) >> +{+ >> +static void amdvi_generate_msi_interrupt(AMDVIState *s) >> +{ >>

Re: [Qemu-devel] [V15 3/4] hw/i386: Introduce AMD IOMMU

2016-08-11 Thread Valentine Sinitsyn
On 11.08.2016 13:32, David Kiarie wrote: On Thu, Aug 11, 2016 at 11:23 AM, Valentine Sinitsyn mailto:valentine.sinit...@gmail.com>> wrote: Hi, On 02.08.2016 13:39, David Kiarie wrote: +static void amdvi_writeq_raw(AMDVIState *s, uint64_t val, hwaddr addr) +

Re: [Qemu-devel] [PATCH] qht: support resetting an uninitialized qht

2016-08-11 Thread Igor Mammedov
On Wed, 10 Aug 2016 15:25:49 -0400 "Emilio G. Cota" wrote: Emilio, Pls also see https://www.mail-archive.com/qemu-devel@nongnu.org/msg391669.html which fixed issue for me, I've CCed you. > tb_flush() is called when debugging the guest (under both KVM > and TCG accelerators) with gdb. tb_flush

Re: [Qemu-devel] [PATCH] correctly handle resize of empty hash tree

2016-08-11 Thread Igor Mammedov
On Wed, 10 Aug 2016 17:19:48 +0200 Paolo Bonzini wrote: CCing original author, here is his varinat how to fix it https://www.mail-archive.com/qemu-devel@nongnu.org/msg391790.html > On 10/08/2016 03:05, Brent W. Baccala wrote: > > Hi - > > > > This is a bug report that includes a patch. My und

Re: [Qemu-devel] [Qemu-block] [PATCH] test-coroutine: Fix coroutine pool corruption

2016-08-11 Thread Stefan Hajnoczi
On Wed, Aug 10, 2016 at 01:17:27PM +0200, Kevin Wolf wrote: > The test case overwrites the Coroutine object with 0xff as a way to > assert that the coroutine isn't used any more. However, this means that > the coroutine pool now contains a corrupted object and later test cases > may get this corrup

Re: [Qemu-devel] [PATCH v2] error-report: leveraging error_report_exit()

2016-08-11 Thread Peter Xu
On Thu, Aug 11, 2016 at 01:01:58AM -0700, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > Hi, > > Your series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. This fault sh

Re: [Qemu-devel] [PATCH v2] error-report: leveraging error_report_exit()

2016-08-11 Thread Fam Zheng
On Thu, 08/11 16:47, Peter Xu wrote: > On Thu, Aug 11, 2016 at 01:01:58AM -0700, > no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > > Hi, > > > > Your series failed automatic build test. Please find the testing commands > > and > > their output below. If you have docker installed, you

Re: [Qemu-devel] [PATCH for-2.8 00/18] pc: q35: x2APIC support in kvm_apic mode

2016-08-11 Thread Igor Mammedov
On Thu, 11 Aug 2016 13:10:57 +0800 Peter Xu wrote: > On Wed, Aug 10, 2016 at 10:51:51AM +0200, Igor Mammedov wrote: > > [...] > > > > > Upstream guest kernel 4.7.0+ (d52bd54db) crashes when booting with irq > > > > remapping on: > > > > > > > > ./qemu-system-x86_64 -enable-kvm -smp > > > > 1

Re: [Qemu-devel] [PATCH v2] error-report: leveraging error_report_exit()

2016-08-11 Thread Peter Xu
On Thu, Aug 11, 2016 at 04:45:00PM +0800, Fam Zheng wrote: > On Thu, 08/11 16:47, Peter Xu wrote: > > On Thu, Aug 11, 2016 at 01:01:58AM -0700, > > no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > > > Hi, > > > > > > Your series failed automatic build test. Please find the testing comma

Re: [Qemu-devel] [Qemu-block] [PATCH v2] qemu-img: add conv=notrunc option to dd

2016-08-11 Thread Stefan Hajnoczi
On Thu, Aug 11, 2016 at 05:51:43AM +0200, Reda Sallahi wrote: > @@ -3997,6 +4017,14 @@ static int img_dd(int argc, char **argv) > g_free(arg); > arg = NULL; > } > +if (!(dd.conv & C_NOTRUNC)) { > +/* We make conv=notrunc mandatory for the moment to avoid accidenta

Re: [Qemu-devel] [PATCH] qemu-img: change opening method for the output in dd

2016-08-11 Thread Stefan Hajnoczi
On Thu, Aug 11, 2016 at 06:02:32AM +0200, Reda Sallahi wrote: > +bs = bdrv_open(out.filename, NULL, qoptions, BDRV_O_RDWR, &local_err); Why are bdrv_*() functions used instead of blk_*()? signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH] qemu-img: change opening method for the output in dd

2016-08-11 Thread Fam Zheng
On Thu, 08/11 06:02, Reda Sallahi wrote: > dd was creating an output image regardless of whether there was one already > created. With this patch we try to open first the output image and resize it > if necessary. > > Signed-off-by: Reda Sallahi > --- > Depends on: > [PATCH v2] qemu-img: add conv

Re: [Qemu-devel] [PATCH V5 1/6] oslib-posix: add helpers for stack alloc and free

2016-08-11 Thread Stefan Hajnoczi
On Mon, Aug 08, 2016 at 08:29:58PM +0200, Peter Lieven wrote: > Am 08.08.2016 um 12:37 schrieb Stefan Hajnoczi: > > On Tue, Jul 12, 2016 at 06:23:01PM +0200, Peter Lieven wrote: > >> the allocated stack will be adjusted to the minimum supported stack size > >> by the OS and rounded up to be a multi

[Qemu-devel] [PATCH v3 1/2] ACPI: Cleanup -acpitable option code

2016-08-11 Thread Lv Zheng
In -acpitable options, at least/most one data/file sub-option is mandatory, this patch cleans up the code to reflect this in a managed manner so that the follow-up mandatory sub-options can be added to -acpitable. Signed-off-by: Lv Zheng --- hw/acpi/core.c | 32 +++---

[Qemu-devel] [PATCH v3 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes

2016-08-11 Thread Lv Zheng
This patch allows FADT to be built with different revisions. When the revision is greater than 1.0, 64-bit address fields may also be filled. Note that FADT revision 2 has never been defined by the ACPI specification. So this patch only adds an option -acpitable fadt= to allow revision 1,3,5 to be

[Qemu-devel] [PATCH v3 0/2] ACPI: Add FADT revision support

2016-08-11 Thread Lv Zheng
This patchset adds revision support for FADT. Lv Zheng (2): ACPI: Cleanup -acpitable option code ACPI: Add -acpitable fadt= to allow FADT revision changes hw/acpi/core.c | 50 +-- hw/i386/acpi-build.c | 76 ++--

Re: [Qemu-devel] [PATCH 05/29] qcow2-bitmap: structs and consts

2016-08-11 Thread Kevin Wolf
Am 08.08.2016 um 17:04 hat Vladimir Sementsov-Ogievskiy geschrieben: > Create block/qcow2-bitmap.c > Add data structures and constraints accordingly to docs/specs/qcow2.txt > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/Makefile.objs | 2 +- > block/qcow2-bitmap.c | 47 +

Re: [Qemu-devel] QEMU-guestOS latencies.

2016-08-11 Thread Stefan Hajnoczi
On Tue, Aug 09, 2016 at 11:45:54AM +, Nir Levy wrote: > I am continuing to learn your simple trace. > I have used it and seen how it is working. > the get_clock is saved as 8 octets but is converted via > ./scripts/simpletrace.py to delta_ns = timestamp - self.last_timestamp > which result wit

Re: [Qemu-devel] [PATCH v3 0/2] ACPI: Add FADT revision support

2016-08-11 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: cover.1470905888.git.lv.zh...@intel.com Subject: [Qemu-devel] [PATCH v3 0/2] ACPI: Add FADT revision support Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

[Qemu-devel] [PATCH v4 0/2] ACPI: Add FADT revision support

2016-08-11 Thread Lv Zheng
This patchset adds revision support for FADT. History: v1: Initial support v2: Coding style cleanup v3: Cleanup -acpitable code (remove useless hdrs->data/file) Change -acpifadt to -acpitable fadt= Shrink v1 FADT table length v4: Coding style cleanup Lv Zheng (2): ACPI: Cleanup -acp

[Qemu-devel] [PATCH v4 1/2] ACPI: Cleanup -acpitable option code

2016-08-11 Thread Lv Zheng
In -acpitable options, at least/most one data/file sub-option is mandatory, this patch cleans up the code to reflect this in a managed manner so that the follow-up mandatory sub-options can be added to -acpitable. Signed-off-by: Lv Zheng --- hw/acpi/core.c | 32 +++---

Re: [Qemu-devel] [PATCH v4 1/2] ACPI: Cleanup -acpitable option code

2016-08-11 Thread Zheng, Lv
Hi, > From: Zheng, Lv > Subject: [PATCH v4 1/2] ACPI: Cleanup -acpitable option code > > In -acpitable options, at least/most one data/file sub-option is mandatory, > this patch cleans up the code to reflect this in a managed manner so that > the follow-up mandatory sub-options can be added to -

[Qemu-devel] [PATCH v4 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes

2016-08-11 Thread Lv Zheng
This patch allows FADT to be built with different revisions. When the revision is greater than 1.0, 64-bit address fields may also be filled. Note that FADT revision 2 has never been defined by the ACPI specification. So this patch only adds an option -acpitable fadt= to allow revision 1,3,5 to be

Re: [Qemu-devel] [PATCH 0/2] vhost-user: release chardev on cleanup

2016-08-11 Thread Marc-André Lureau
Hi On Thu, Jun 16, 2016 at 1:05 PM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > ping > 2nd ping, probably for-2.8 now > > On Wed, Apr 6, 2016 at 5:38 PM, wrote: > > From: Marc-André Lureau > > > > The following 2 one-liners remove the chardev from the vhost-user > > netdev it is

Re: [Qemu-devel] [PATCH for-2.7] pc-bios/optionrom: Fix OpenBSD build with better detection of linker emulation

2016-08-11 Thread Peter Maydell
On 11 August 2016 at 00:42, Brad Smith wrote: > On 08/08/16 12:11, Peter Maydell wrote: >> >> The various host OSes are irritatingly variable about the name >> of the linker emulation we need to pass to ld's -m option to >> build the i386 option ROMs. Instead of doing this via a >> CONFIG ifdef, c

[Qemu-devel] [PATCH v3] qemu-img: add conv=notrunc option to dd

2016-08-11 Thread Reda Sallahi
This adds the conv=notrunc option to dd which tells dd to not truncate the output. Signed-off-by: Reda Sallahi --- Depends on: [PATCH v5] qemu-img: add skip option to dd Changes from v2: * Delete the mandatory conv=notrunc Changes from v1: * Added comment qemu-img-cmds.hx | 4 ++-- qemu

Re: [Qemu-devel] [PATCH 06/29] qcow2-bitmap: add qcow2_read_bitmaps()

2016-08-11 Thread Kevin Wolf
Am 08.08.2016 um 17:04 hat Vladimir Sementsov-Ogievskiy geschrieben: > Add qcow2_read_bitmaps, reading bitmap directory as specified in > docs/specs/qcow2.txt > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2-bitmap.c | 100 > +++

[Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes

2016-08-11 Thread Lv Zheng
This patch allows FADT to be built with different revisions. When the revision is greater than 1.0, 64-bit address fields may also be filled. Note that FADT revision 2 has never been defined by the ACPI specification. So this patch only adds an option -acpitable fadt= to allow revision 1,3,5 to be

[Qemu-devel] [PATCH v5 0/2] ACPI: Add FADT revision support

2016-08-11 Thread Lv Zheng
This patchset adds revision support for FADT. History: v1: Initial support v2: Coding style cleanup v3: Cleanup -acpitable code (remove useless hdrs->data/file) Change -acpifadt to -acpitable fadt= Shrink v1 FADT table length v4: Coding style cleanup v5: Correct change block residenc

[Qemu-devel] [PATCH v5 1/2] ACPI: Cleanup -acpitable option code

2016-08-11 Thread Lv Zheng
In -acpitable options, at least/most one data/file sub-option is mandatory, this patch cleans up the code to reflect this in a managed manner so that the follow-up mandatory sub-options can be added to -acpitable. Signed-off-by: Lv Zheng --- hw/acpi/core.c | 32 +++---

Re: [Qemu-devel] [PATCH] correctly handle resize of empty hash tree

2016-08-11 Thread Emilio G. Cota
On Thu, Aug 11, 2016 at 10:45:02 +0200, Igor Mammedov wrote: > On Wed, 10 Aug 2016 17:19:48 +0200 > Paolo Bonzini wrote: > > The patch makes sense, but I think we don't need to call qht_reset_size > > at all. > > > > tb_flush should not do anything if using KVM. There are several ways to > > do t

Re: [Qemu-devel] [PATCH v2 10/27] tcg: Add atomic128 helpers

2016-08-11 Thread Alex Bennée
Richard Henderson writes: > Force the use of cmpxchg16b on x86_64. > > Wikipedia suggests that only very old AMD64 (circa 2004) did not have > this instruction. Further, it's required by Windows 8 so no new cpus > will ever omit it. > > If we truely care about these, then we could check this at

[Qemu-devel] [Bug 1611979] Re: GTK+ interface, backspace is broken in the monitor console

2016-08-11 Thread Bug Report
thank you -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1611979 Title: GTK+ interface, backspace is broken in the monitor console Status in QEMU: Confirmed Bug description: this has been brok

Re: [Qemu-devel] [PATCH for-2.8 v1 60/60] trace: update docs to reflect new code generation approach

2016-08-11 Thread Lluís Vilanova
Daniel P Berrange writes: > On Wed, Aug 10, 2016 at 06:11:24PM +0200, Lluís Vilanova wrote: >> Daniel P Berrange writes: >> >> > On Wed, Aug 10, 2016 at 04:33:47PM +0200, Lluís Vilanova wrote: >> >> Daniel P Berrange writes: [...] >> >> For example, first we concatenate /trace-events, /io/trace-e

Re: [Qemu-devel] [PATCH] trace: Remove 'trace_events_dstate_init'

2016-08-11 Thread Lluís Vilanova
Daniel P Berrange writes: > On Wed, Aug 10, 2016 at 06:57:34PM +0200, Lluís Vilanova wrote: >> Removes the event state array used for early initialization. Since only >> events with the "vcpu" property need a late initialization fixup, >> threats their initialization specially. >> >> Assumes that

Re: [Qemu-devel] [PATCH v3 03/10] aspeed-soc: provide a framework to add new SoCs

2016-08-11 Thread Peter Maydell
On 2 August 2016 at 18:15, Cédric Le Goater wrote: > Let's define an object class for each Aspeed SoC we support. A > AspeedSoCInfo struct gathers the SoC specifications which can later be > used by an instance of the class or by a board using the SoC. > > Signed-off-by: Cédric Le Goater > diff

[Qemu-devel] [PATCH v2] trace: Remove 'trace_events_dstate_init'

2016-08-11 Thread Lluís Vilanova
Removes the event state array used for early initialization. Since only events with the "vcpu" property need a late initialization fixup, threats their initialization specially. Assumes that the user won't touch the state of "vcpu" events between early and late initialization (e.g., through QMP).

Re: [Qemu-devel] [PATCH v3 01/10] ast2400: rename the Aspeed SoC files to aspeed_soc

2016-08-11 Thread Peter Maydell
On 2 August 2016 at 18:15, Cédric Le Goater wrote: > Let's prepare for new Aspeed SoCs and rename the ast2400 file to a > more generic one. There are no changes in the code apart from the > header file include. > > Signed-off-by: Cédric Le Goater > --- > hw/arm/Makefile.objs| 2 +- > h

Re: [Qemu-devel] [PATCH v3 05/10] palmetto-bmc: replace palmetto_bmc with aspeed

2016-08-11 Thread Peter Maydell
On 2 August 2016 at 18:15, Cédric Le Goater wrote: > This is mostly a name replacement to prepare ground for other SoCs > specificities. It also adds a TypeInfo struct for the palmetto-bmc > board with a custom initialization for the same reason. > > Signed-off-by: Cédric Le Goater Reviewed-by:

Re: [Qemu-devel] [PATCH v3 04/10] palmetto-bmc: rename the Aspeed board file to aspeed.c

2016-08-11 Thread Peter Maydell
On 2 August 2016 at 18:15, Cédric Le Goater wrote: > We plan to add more Aspeed boards to this file. There are no changes > in the code. > > Signed-off-by: Cédric Le Goater > --- > hw/arm/Makefile.objs | 2 +- > hw/arm/aspeed.c | 106 > ++

Re: [Qemu-devel] [PATCH v3 02/10] ast2400: replace ast2400 with aspeed_soc

2016-08-11 Thread Peter Maydell
On 2 August 2016 at 18:15, Cédric Le Goater wrote: > This is a name replacement to prepare ground for other SoCs. > > Let's also remove the AST2400_SMC_BASE definition from the address > space mappings, as it is not used. This controller was removed from > the Aspeed SoC AST2500, so this provides

Re: [Qemu-devel] [PATCH v2] trace: Remove 'trace_events_dstate_init'

2016-08-11 Thread Daniel P. Berrange
On Thu, Aug 11, 2016 at 12:23:05PM +0200, Lluís Vilanova wrote: > Removes the event state array used for early initialization. Since only > events with the "vcpu" property need a late initialization fixup, > threats their initialization specially. > > Assumes that the user won't touch the state of

Re: [Qemu-devel] [PATCH v3 07/10] hw/misc: use macros to define hw-strap1 register on the AST2400 Aspeed SoC

2016-08-11 Thread Peter Maydell
On 2 August 2016 at 18:15, Cédric Le Goater wrote: > This gives some explanation behind the magic number 0x120CE416. > > Signed-off-by: Cédric Le Goater > --- > > Changes since v2: > > - more precise definitions of the hw-strap1 register > - moved hw-strap1 to the board level. > > hw/arm/aspe

Re: [Qemu-devel] [PATCH v3 06/10] palmetto-bmc: add board specific configuration

2016-08-11 Thread Peter Maydell
On 2 August 2016 at 18:15, Cédric Le Goater wrote: > aspeed_board_init() now uses a board identifier to customize some values > specific to the board. > > Signed-off-by: Cédric Le Goater > --- > > Changes since v2: > > - removed silicon-rev and cpu-model. This is now in the SoC. > > Changes si

Re: [Qemu-devel] [PATCH v3 01/10] ast2400: rename the Aspeed SoC files to aspeed_soc

2016-08-11 Thread Cédric Le Goater
On 08/11/2016 12:22 PM, Peter Maydell wrote: > On 2 August 2016 at 18:15, Cédric Le Goater wrote: >> Let's prepare for new Aspeed SoCs and rename the ast2400 file to a >> more generic one. There are no changes in the code apart from the >> header file include. >> >> Signed-off-by: Cédric Le Goater

Re: [Qemu-devel] [PATCH v3 09/10] arm: add support for an ast2500 evaluation board

2016-08-11 Thread Peter Maydell
On 2 August 2016 at 18:15, Cédric Le Goater wrote: > The ast2500 eval board has a hardware strapping register value of > 0xF100C2E6 which we use for a definition of AST2500_EVB_HW_STRAP1 > below. > > Signed-off-by: Cédric Le Goater > --- > > Changes since v2: > > - removed silicon-rev and cpu-m

Re: [Qemu-devel] [PATCH v3 08/10] aspeed: add a AST2500 SoC and support to the SCU and SDMC controllers controllers

2016-08-11 Thread Peter Maydell
On 2 August 2016 at 18:15, Cédric Le Goater wrote: > Based on previous work done by Andrew Jeffery . > > Signed-off-by: Cédric Le Goater > --- > > Changes since v2: > > - more precise definitions of the hw-strap1 register > > hw/arm/aspeed_soc.c | 2 ++ > hw/misc/aspeed_scu.c

[Qemu-devel] [PULL 1/1] linux-aio: Handle io_submit() failure gracefully

2016-08-11 Thread Stefan Hajnoczi
From: Kevin Wolf It is generally not expected that io_submit() fails other than with -EAGAIN, but corner cases like SELinux refusing I/O when permissions are revoked are still possible. In this case, we shouldn't abort, but just return an I/O error for the request. Signed-off-by: Kevin Wolf Mes

Re: [Qemu-devel] [PATCH v3 10/10] palmetto-bmc: remove extra no_sdcard assignement

2016-08-11 Thread Peter Maydell
On 2 August 2016 at 18:15, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > hw/arm/aspeed.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c > index e71500c64bd3..6d7b70df70da 100644 > --- a/hw/arm/aspeed.c > +++ b/hw/arm/aspeed.c > @@ -1

[Qemu-devel] [PULL 0/1] Block patches

2016-08-11 Thread Stefan Hajnoczi
The following changes since commit d08306dc42ea599ffcf8aad056fa9c23acfbe230: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2016-08-10 17:14:35 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for you to f

Re: [Qemu-devel] [PATCH v2 04/27] int128: Use __int128 if available

2016-08-11 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson > --- > include/qemu/int128.h | 135 > +- > 1 file changed, 134 insertions(+), 1 deletion(-) > > diff --git a/include/qemu/int128.h b/include/qemu/int128.h > index 52aaf99..08f1db1 100

Re: [Qemu-devel] [PATCH v3 00/10] arm: add ast2500 support

2016-08-11 Thread Peter Maydell
On 2 August 2016 at 18:15, Cédric Le Goater wrote: > On the AST2500, I am still having a little issue under uboot which > sets the vbar doing : > > mcr p15, 0, r0, c12, c0, 0 /* Set VBAR */ > > and this is trapped as an undefined instruction by qemu. > > Looking at hw/

Re: [Qemu-devel] [PATCH 5/5] target-arm: Fix warn about implicit conversion

2016-08-11 Thread Peter Maydell
On 9 August 2016 at 20:02, Pranith Kumar wrote: > Clang warns about an implicit conversion as follows: > > /mnt/devops/code/qemu/target-arm/neon_helper.c:1075:1: warning: implicit > conversion from 'int' to 'int8_t' (aka 'signed char') changes value from 128 > to -128 [-Wconstant-conversion] > N

[Qemu-devel] [Bug 829455] Re: user mode network stack - hostfwd not working with restrict=y

2016-08-11 Thread prochazka nicolas
It seems that's problem persist with this patch ( qemu 2.7rc2) Regards -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/829455 Title: user mode network stack - hostfwd not working with restrict=y Sta

Re: [Qemu-devel] [PATCH v2] trace: Remove 'trace_events_dstate_init'

2016-08-11 Thread Lluís Vilanova
Daniel P Berrange writes: > On Thu, Aug 11, 2016 at 12:23:05PM +0200, Lluís Vilanova wrote: >> Removes the event state array used for early initialization. Since only >> events with the "vcpu" property need a late initialization fixup, >> threats their initialization specially. >> >> Assumes that

[Qemu-devel] [PATCH v2] vfio: Add support for mmapping sub-page MMIO BARs

2016-08-11 Thread Yongji Xie
Now the kernel commit 05f0c03fbac1 ("vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive") allows VFIO to mmap sub-page BARs. This is the corresponding QEMU patch. With those patches applied, we could passthrough sub-page BARs to guest, which can help to improve IO performance

Re: [Qemu-devel] [PATCH v2] vfio: Add support for mmapping sub-page MMIO BARs

2016-08-11 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 1470913557-4355-1-git-send-email-xyj...@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH v2] vfio: Add support for mmapping sub-page MMIO BARs Type: series === TEST SCRIPT BEGIN === #!/bi

Re: [Qemu-devel] [PATCH v2] trace: Remove 'trace_events_dstate_init'

2016-08-11 Thread Daniel P. Berrange
On Thu, Aug 11, 2016 at 01:03:10PM +0200, Lluís Vilanova wrote: > Daniel P Berrange writes: > > > On Thu, Aug 11, 2016 at 12:23:05PM +0200, Lluís Vilanova wrote: > >> Removes the event state array used for early initialization. Since only > >> events with the "vcpu" property need a late initializa

[Qemu-devel] [PATCH] qmp-commands.hx: remove outdated note

2016-08-11 Thread Marc-André Lureau
input-send-event is now stable since 6575ccddf4e7c2484bc14b10d5e89f57506c3953. Signed-off-by: Marc-André Lureau --- qmp-commands.hx | 2 -- 1 file changed, 2 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index c8d360a..6866264 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@

[Qemu-devel] [PULL 2.7 1/1] virtio-console: set frontend open permanently for console devs

2016-08-11 Thread Amit Shah
From: "Daniel P. Berrange" The virtio-console.c file handles both serial consoles and interactive consoles, since they're backed by the same device model. Since serial devices are expected to be reliable and need to notify the guest when the backend is opened or closed, the virtio-console.c file

Re: [Qemu-devel] [PATCH 16/29] block: add bdrv_load_dirty_bitmap()

2016-08-11 Thread Kevin Wolf
Am 08.08.2016 um 17:05 hat Vladimir Sementsov-Ogievskiy geschrieben: > The funcion loads dirty bitmap from file, using underlying driver > function. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/dirty-bitmap.c | 16 > include/block/dirty-bitmap.h | 2 ++

[Qemu-devel] [PULL 2.7 0/1] virtio-console: fix receiving data from guest

2016-08-11 Thread Amit Shah
The following changes since commit d08306dc42ea599ffcf8aad056fa9c23acfbe230: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2016-08-10 17:14:35 +0100) are available in the git repository at: http://git.kernel.org/pub/scm/virt/qemu/amit/virtio-serial.git tags/vse

Re: [Qemu-devel] [PATCH 16/29] block: add bdrv_load_dirty_bitmap()

2016-08-11 Thread Vladimir Sementsov-Ogievskiy
On 11.08.2016 14:24, Kevin Wolf wrote: Am 08.08.2016 um 17:05 hat Vladimir Sementsov-Ogievskiy geschrieben: The funcion loads dirty bitmap from file, using underlying driver function. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 16 include

[Qemu-devel] [PULL 2.7 1/4] migration/ram: fix typo

2016-08-11 Thread Amit Shah
From: Cao jin Signed-off-by: Cao jin Message-Id: <1469776231-23820-1-git-send-email-caoj.f...@cn.fujitsu.com> Signed-off-by: Amit Shah --- migration/ram.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 815bc0e..a3d70c4 100644 ---

[Qemu-devel] [PULL 2.7 0/4] migration: fixes

2016-08-11 Thread Amit Shah
The following changes since commit d08306dc42ea599ffcf8aad056fa9c23acfbe230: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2016-08-10 17:14:35 +0100) are available in the git repository at: http://git.kernel.org/pub/scm/virt/qemu/amit/migration.git tags/migrati

[Qemu-devel] [PULL 2.7 3/4] migration: fix live migration failure with compression

2016-08-11 Thread Amit Shah
From: Liang Li Because of commit 11808bb0c422, which remove some condition checks of 'f->ops->writev_buffer', 'qemu_put_qemu_file' should be enhanced to clear the 'f_src->iovcnt', or 'f_src->iovcnt' may exceed the MAX_IOV_SIZE which will break live migration. This should be fixed. Signed-off-by:

[Qemu-devel] [PULL 2.7 2/4] migration: mmap error check fix

2016-08-11 Thread Amit Shah
From: Evgeny Yakovlev mmap man page: "On success, mmap() returns a pointer to the mapped area. On error, the value MAP_FAILED (that is, (void *) -1) is returned, and errno is set to indicate the cause of the error." The check in postcopy_get_tmp_page is definitely wrong and should be fixed. S

[Qemu-devel] [PULL 2.7 4/4] migration/socket: fix typo in file header

2016-08-11 Thread Amit Shah
From: Cao jin Code of inet socket & unix socket is merged together. Also add some newlines, make code block well separated. Cc: Daniel P. Berrange Cc: Juan Quintela Cc: Amit Shah Reviewed-by: Daniel P. Berrange Signed-off-by: Cao jin Message-Id: <1469696074-12744-4-git-send-email-caoj.f...

Re: [Qemu-devel] [PATCH v2] virtio-net: allow increasing rx queue size

2016-08-11 Thread Cornelia Huck
On Wed, 10 Aug 2016 17:47:16 +0300 "Michael S. Tsirkin" wrote: > This allows increasing the rx queue size up to 1024: unlike with tx, > guests don't put in huge S/G lists into RX so the risk of running into > the max 1024 limitation due to some off-by-one seems small. > > It's helpful for users

[Qemu-devel] [Bug 829455] Re: user mode network stack - hostfwd not working with restrict=y

2016-08-11 Thread prochazka nicolas
Sorry for this spam, it's just a routing problem . Regards -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/829455 Title: user mode network stack - hostfwd not working with restrict=y Status in QEMU

Re: [Qemu-devel] [PATCH 06/29] qcow2-bitmap: add qcow2_read_bitmaps()

2016-08-11 Thread Vladimir Sementsov-Ogievskiy
On 11.08.2016 12:36, Kevin Wolf wrote: Am 08.08.2016 um 17:04 hat Vladimir Sementsov-Ogievskiy geschrieben: Add qcow2_read_bitmaps, reading bitmap directory as specified in docs/specs/qcow2.txt Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 100 +++

Re: [Qemu-devel] [PATCH v2] trace: Remove 'trace_events_dstate_init'

2016-08-11 Thread Lluís Vilanova
Daniel P Berrange writes: > On Thu, Aug 11, 2016 at 01:03:10PM +0200, Lluís Vilanova wrote: >> Daniel P Berrange writes: >> >> > On Thu, Aug 11, 2016 at 12:23:05PM +0200, Lluís Vilanova wrote: >> >> Removes the event state array used for early initialization. Since only >> >> events with the "vcp

Re: [Qemu-devel] [PULL 0/1] Block patches

2016-08-11 Thread Peter Maydell
On 11 August 2016 at 11:35, Stefan Hajnoczi wrote: > The following changes since commit d08306dc42ea599ffcf8aad056fa9c23acfbe230: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2016-08-10 17:14:35 +0100) > > are available in the git repository at: > > git://g

Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes

2016-08-11 Thread Igor Mammedov
On Thu, 11 Aug 2016 17:36:45 +0800 Lv Zheng wrote: > This patch allows FADT to be built with different revisions. When the revision > is greater than 1.0, 64-bit address fields may also be filled. > > Note that FADT revision 2 has never been defined by the ACPI specification. So > this patch onl

Re: [Qemu-devel] [PATCH 06/29] qcow2-bitmap: add qcow2_read_bitmaps()

2016-08-11 Thread Kevin Wolf
Am 11.08.2016 um 14:00 hat Vladimir Sementsov-Ogievskiy geschrieben: > On 11.08.2016 12:36, Kevin Wolf wrote: > >Am 08.08.2016 um 17:04 hat Vladimir Sementsov-Ogievskiy geschrieben: > >>Add qcow2_read_bitmaps, reading bitmap directory as specified in > >>docs/specs/qcow2.txt > >> > >>Signed-off-by:

Re: [Qemu-devel] [PATCH 07/29] qcow2-bitmap: add qcow2_bitmap_load()

2016-08-11 Thread Kevin Wolf
Am 08.08.2016 um 17:04 hat Vladimir Sementsov-Ogievskiy geschrieben: > This function loads block dirty bitmap from qcow2. > > Signed-off-by: Vladimir Sementsov-Ogievskiy As you said this is really unused at the moment, I'll mostly skip this patch. Just one thing: > diff --git a/include/block/bl

  1   2   3   >