On 2 August 2016 at 18:15, Cédric Le Goater <c...@kaod.org> wrote: > The ast2500 eval board has a hardware strapping register value of > 0xF100C2E6 which we use for a definition of AST2500_EVB_HW_STRAP1 > below. > > Signed-off-by: Cédric Le Goater <c...@kaod.org> > --- > > Changes since v2: > > - removed silicon-rev and cpu-model. This is now in the SoC. > > Changes since v1: > > - changed AST2500_EDK to AST2500_EVB > - fixed white space issues > - added AST2500_HW_STRAP1 > > hw/arm/aspeed.c | 39 ++++++++++++++++++++++++++++++++++++++- > 1 file changed, 38 insertions(+), 1 deletion(-) > > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c > index 80907b4244ea..e71500c64bd3 100644 > --- a/hw/arm/aspeed.c > +++ b/hw/arm/aspeed.c > @@ -36,7 +36,8 @@ typedef struct AspeedBoardConfig { > } AspeedBoardConfig; > > enum { > - PALMETTO_BMC > + PALMETTO_BMC, > + AST2500_EVB
Prefer trailing comma. > }; Otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM