Re: [Qemu-devel] [RFC PATCH V3 2/4] colo-compare: track connection and enqueue packet

2016-04-29 Thread Zhang Chen
On 04/29/2016 10:05 AM, Jason Wang wrote: On 04/28/2016 06:25 PM, Zhang Chen wrote: +static Packet *packet_new(CompareState *s, const void *data, + int size, ConnectionKey *key) +{ +Packet *pkt = g_slice_new(Packet); + +pkt->data = g_memdup(data, size); +

Re: [Qemu-devel] [PATCH] exec.c: Ensure right alignment also for file backed ram

2016-04-29 Thread Dominik Dingel
On Fri, 29 Apr 2016 15:32:22 +0800 Fam Zheng wrote: > On Mon, 04/25 13:55, Dominik Dingel wrote: > > While in the anonymous ram case we already take care of the right alignment > > such an alignment gurantee does not exist for file backed ram allocation. > > s/gurantee/guarantee/ > > Otherwise

Re: [Qemu-devel] [RFC PATCH v2 2/2] spapr: Memory hot-unplug support

2016-04-29 Thread Thomas Huth
On 29.04.2016 08:59, Bharata B Rao wrote: > On Fri, Apr 29, 2016 at 08:45:37AM +0200, Thomas Huth wrote: >> On 29.04.2016 05:24, David Gibson wrote: >>> On Tue, Apr 26, 2016 at 04:03:37PM -0500, Michael Roth wrote: >> ... In the case of pseries, the DIMM abstraction isn't really exposed to >>>

Re: [Qemu-devel] [V9 2/4] hw/i386: ACPI table for AMD IOMMU

2016-04-29 Thread David Kiarie
On Fri, Apr 29, 2016 at 9:09 AM, Jan Kiszka wrote: > On 2016-04-25 00:12, David Kiarie wrote: >> Add IVRS table for AMD IOMMU. Generate IVRS or DMAR >> depending on emulated IOMMU > > It seems you lack scope descriptions for the PCI devices in the system. > At least, this is what our jailhouse con

Re: [Qemu-devel] [RFC PATCH V3 3/4] colo-compare: introduce packet comparison thread

2016-04-29 Thread Zhang Chen
On 04/29/2016 10:07 AM, Jason Wang wrote: On 04/28/2016 06:31 PM, Zhang Chen wrote: +/* + * called from the compare thread on the primary + * for compare connection + */ +static void colo_compare_connection(void *opaque, void *user_data) +{ +Connection *conn = opaque; +Packet *pkt = N

Re: [Qemu-devel] [PATCH] configure: Check if struct fsxattr is available from linux header

2016-04-29 Thread Markus Armbruster
Jan Vesely writes: > On Tue, 2016-04-12 at 17:09 -0400, Jan Vesely wrote: >> On Sat, 2016-03-19 at 21:18 -0400, Jan Vesely wrote: >> > >> > Fixes build with new linux headers. >> > >> > Signed-off-by: Jan Vesely >> > --- >> > linux-headers-4.5 and xfsprogs-3.2.4 in my case >> > >> >  configur

Re: [Qemu-devel] [RFC PATCH v2 2/2] spapr: Memory hot-unplug support

2016-04-29 Thread Igor Mammedov
On Fri, 29 Apr 2016 10:22:03 +0200 Thomas Huth wrote: > On 29.04.2016 08:59, Bharata B Rao wrote: > > On Fri, Apr 29, 2016 at 08:45:37AM +0200, Thomas Huth wrote: > >> On 29.04.2016 05:24, David Gibson wrote: > >>> On Tue, Apr 26, 2016 at 04:03:37PM -0500, Michael Roth wrote: > >> ... > >

Re: [Qemu-devel] [PATCH v16 02/24] qapi: Guarantee NULL obj on input visitor callback error

2016-04-29 Thread Markus Armbruster
Eric Blake writes: > Our existing input visitors were not very consistent on errors > in a function taking 'TYPE **obj' (that is, start_struct(), > start_alternate(), type_str(), and type_any(). next_list() is > similar, except that since commit 08f9541, it can't fail). Multiple sentences in a p

Re: [Qemu-devel] [PATCH v3 16/18] sockets: Use new QAPI cloning

2016-04-29 Thread Daniel P. Berrange
On Thu, Apr 28, 2016 at 10:23:37PM -0600, Eric Blake wrote: > Rather than rolling our own clone via an expensive conversion > in and back out of QObject, use the generated QAPI version. > > Signed-off-by: Eric Blake > > --- > v3: new patch > --- > util/qemu-sockets.c | 22 +-

Re: [Qemu-devel] [PATCH for 2.6] configure: Allow builds -Weverything

2016-04-29 Thread Daniel P. Berrange
On Thu, Apr 28, 2016 at 11:33:41PM +0200, Stefan Weil wrote: > The clang compiler supports a useful compiler option -Weverything. > > As this option triggers warnings in glib header files, too, testing > glib with -Werror will always fail. A size mismatch is also detected > without -Werror, so sim

Re: [Qemu-devel] [PATCH 2/3] exec: adjuest rcu_read_lock requiement

2016-04-29 Thread Fam Zheng
In the subject line, s/adjuest/adjust/ and s/requiement/requirement/. On Wed, 04/20 11:34, Gonglei wrote: > qemu_ram_unset_idstr() don't need rcu lock anymore, s/don't/doesn't/ > meanwhile adjuest the range of rcu lock in s/adjuest/adjust/ or just s/adjuest/make/ > qemu_ram_set_idstr() as smal

Re: [Qemu-devel] [PATCH] Allow users to specify the vmdk virtual hardware version.

2016-04-29 Thread Fam Zheng
On Thu, 04/21 12:29, Janne Karhunen wrote: > From: Janne Karhunen > > Vmdk images have metadata to indicate the vmware virtual > hardware version image was created/tested to run with. > Allow users to specify that version via new 'hwversion' > option. > > Signed-off-by: Janne Karhunen Sorry fo

Re: [Qemu-devel] [RFC PATCH v2 2/2] spapr: Memory hot-unplug support

2016-04-29 Thread Thomas Huth
On 29.04.2016 05:24, David Gibson wrote: > On Tue, Apr 26, 2016 at 04:03:37PM -0500, Michael Roth wrote: ... >> In the case of pseries, the DIMM abstraction isn't really exposed to >> the guest, but rather the memory blocks we use to make the backing >> memdev memory available to the guest. During

Re: [Qemu-devel] [RFC PATCH v2 2/2] spapr: Memory hot-unplug support

2016-04-29 Thread Igor Mammedov
On Fri, 29 Apr 2016 13:28:50 +1000 David Gibson wrote: > On Wed, Apr 27, 2016 at 03:37:05PM +0200, Igor Mammedov wrote: > > On Tue, 26 Apr 2016 16:03:37 -0500 > > Michael Roth wrote: > > > > > Quoting Igor Mammedov (2016-04-26 02:52:36) > > > > On Tue, 26 Apr 2016 10:39:23 +0530 > > > > Bha

Re: [Qemu-devel] [PATCH 3/3] memory: pass RAMBlock as a agrument

2016-04-29 Thread Fam Zheng
On Wed, 04/20 11:34, Gonglei wrote: > In this way, we can avoid to invoke qemu_get_ram_block() > at most time, which can save cpu cycle. > > Signed-off-by: Gonglei > --- > exec.c | 48 ++-- > hw/misc/ivshmem.c | 6 -- > hw/v

Re: [Qemu-devel] [PATCH 1/3] memory: drop find_ram_block()

2016-04-29 Thread Fam Zheng
On Wed, 04/20 11:34, Gonglei wrote: > On the one hand, we have already qemu_get_ram_block() whose function > is similar. On the other hand, we can directly use mr->ram_block but > searching RAMblock by ram_addr which is a kind of waste. > > Signed-off-by: Gonglei > --- > exec.c

Re: [Qemu-devel] [PATCH] exec.c: Ensure right alignment also for file backed ram

2016-04-29 Thread Fam Zheng
On Mon, 04/25 13:55, Dominik Dingel wrote: > While in the anonymous ram case we already take care of the right alignment > such an alignment gurantee does not exist for file backed ram allocation. s/gurantee/guarantee/ Otherwise looks good to me, Reviewed-by: Fam Zheng > > Instead, pagesize i

Re: [Qemu-devel] [PATCH v2 13/17] vmdk: Implement .bdrv_co_pwritev() interface

2016-04-29 Thread Pavel Butsykin
On 29.04.2016 06:08, Fam Zheng wrote: On Thu, 04/28 15:16, Kevin Wolf wrote: +typedef struct VmdkWriteCompressedCo { +BlockDriverState *bs; +int64_t sector_num; +const uint8_t *buf; +int nb_sectors; +int ret; +} VmdkWriteCompressedCo; + +static void vmdk_co_write_compressed(v

Re: [Qemu-devel] [PATCH v16 11/24] qmp-input: Refactor when list is advanced

2016-04-29 Thread Markus Armbruster
Eric Blake writes: > In the QMP input visitor, visiting a list traverses two objects: > the QAPI GenericList of the caller (which gets advanced in > visit_next_list() regardless of this patch), and the QList input > that we are converting to QAPI. For consistency with QDict > visits, we want to

Re: [Qemu-devel] [PATCH for 2.6] configure: Allow builds -Weverything

2016-04-29 Thread Peter Maydell
On 28 April 2016 at 22:33, Stefan Weil wrote: > The clang compiler supports a useful compiler option -Weverything. > > As this option triggers warnings in glib header files, too, testing > glib with -Werror will always fail. A size mismatch is also detected > without -Werror, so simply remove it.

Re: [Qemu-devel] [PATCH 1/3] memory: drop find_ram_block()

2016-04-29 Thread Gonglei (Arei)
Hi, > > > > @@ -1447,8 +1432,9 @@ void qemu_ram_set_idstr(ram_addr_t addr, const > char *name, DeviceState *dev) > > } > > pstrcat(new_block->idstr, sizeof(new_block->idstr), name); > > > > -QLIST_FOREACH_RCU(block, &ram_list.blocks, next) { > > -if (block != new_block && !st

Re: [Qemu-devel] [PATCH v2 13/17] vmdk: Implement .bdrv_co_pwritev() interface

2016-04-29 Thread Kevin Wolf
Am 29.04.2016 um 05:08 hat Fam Zheng geschrieben: > On Thu, 04/28 15:16, Kevin Wolf wrote: > > +typedef struct VmdkWriteCompressedCo { > > +BlockDriverState *bs; > > +int64_t sector_num; > > +const uint8_t *buf; > > +int nb_sectors; > > +int ret; > > +} VmdkWriteCompressedCo; >

Re: [Qemu-devel] [BUG 2.6] Broken CONFIG_TPM?

2016-04-29 Thread Markus Armbruster
Stefan Weil writes: > A compilation test with clang -Weverything reported this problem: > > config-host.h:112:20: warning: '$' in identifier > [-Wdollar-in-identifier-extension] > > The line of code looks like this: > > #define CONFIG_TPM $(CONFIG_SOFTMMU) > > This is fine for Makefile code, but

Re: [Qemu-devel] [PATCH 2/3] exec: adjuest rcu_read_lock requiement

2016-04-29 Thread Gonglei (Arei)
> From: Fam Zheng [mailto:f...@redhat.com] > Sent: Friday, April 29, 2016 3:57 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; Huangpeng (Peter) > Subject: Re: [PATCH 2/3] exec: adjuest rcu_read_lock requiement > > In the subject line, s/adjuest/adjust/ and s/requiement/r

Re: [Qemu-devel] [PATCH v16 20/24] qapi: Don't pass NULL to printf in string input visitor

2016-04-29 Thread Markus Armbruster
Eric Blake writes: > Make sure the error message for visit_type_uint64() gracefully > handles a NULL 'name' when called from the top level or a list > context, as not all the world behaves like glibc in allowing > NULL through a printf-family %s. > > Signed-off-by: Eric Blake > > --- > v16: spli

Re: [Qemu-devel] [PATCH 3/3] memory: pass RAMBlock as a agrument

2016-04-29 Thread Gonglei (Arei)
> From: Fam Zheng [mailto:f...@redhat.com] > Sent: Friday, April 29, 2016 4:07 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; Huangpeng (Peter) > Subject: Re: [PATCH 3/3] memory: pass RAMBlock as a agrument > > On Wed, 04/20 11:34, Gonglei wrote: > > In this way, we can

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/2] vvfat: Fix volume name assertion

2016-04-29 Thread Stefan Hajnoczi
On Thu, Apr 28, 2016 at 01:36:05PM +0200, Kevin Wolf wrote: > Commit d5941dd made the volume name configurable, but it didn't consider > that the rw code compares the volume name string to assert that the > first directory entry is the volume name. This made vvfat crash in rw > mode. > > This fixe

Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/2] vvfat: Fix default volume label

2016-04-29 Thread Stefan Hajnoczi
On Thu, Apr 28, 2016 at 01:36:06PM +0200, Kevin Wolf wrote: > Commit d5941dd documented that it leaves the default volume name as it > was ("QEMU VVFAT"), but it doesn't actually implement this. You get an > empty name (eleven space characters) instead. > > This fixes the implementation to apply t

Re: [Qemu-devel] [Bug 1576347] [NEW] Only one NVMe device is usable in Windows (10) guest

2016-04-29 Thread Stefan Hajnoczi
On Thu, Apr 28, 2016 at 05:44:21PM -, Tom Yan wrote: CCing Keith Busch , maintainer of QEMU NVMe. Maybe he has an idea. > Public bug reported: > > Full command: qemu-system-x86_64 -enable-kvm -cpu host -smp cores=4 -m > 4G -net bridge -net nic -full-screen -drive > file=ovmf_x64.bin,format=r

Re: [Qemu-devel] [RFC PATCH v2 2/2] spapr: Memory hot-unplug support

2016-04-29 Thread Bharata B Rao
On Fri, Apr 29, 2016 at 08:45:37AM +0200, Thomas Huth wrote: > On 29.04.2016 05:24, David Gibson wrote: > > On Tue, Apr 26, 2016 at 04:03:37PM -0500, Michael Roth wrote: > ... > >> In the case of pseries, the DIMM abstraction isn't really exposed to > >> the guest, but rather the memory blocks we u

Re: [Qemu-devel] [PATCH] rng-random: rename RndRandom to RngRandom

2016-04-29 Thread Pankaj Gupta
Code changes look fine to me. > > Usually, Random Number Generator is abbreviated to RNG/rng. > so replacing RndRandom with RngRandom seems more reasonable > and keep consistent with RngBackend. Reviewed-by: Pankaj Gupta > > Signed-off-by: Wei Jiangang > --- > backends/rng-random.c

[Qemu-devel] qcow2 resize with snapshots

2016-04-29 Thread zhangzm
hi, i want to implement the function of qcow2 resize which has snapshots. each snapshot of qcow2 will have a separate total size, and when apply a snapshot, the image can be shrunk, and the total size of image will change after apply to a snapshot with different size. now, there is a disk_si

[Qemu-devel] [PULL for-2.6 0/1] QAPI patches for 2016-04-29

2016-04-29 Thread Markus Armbruster
Potential crash bug. Missing 2.6 wouldn't be a big deal, but it's an obvious one-liner, so let's try. The following changes since commit 736f85d5db701cc9d464a03b583d4a04606a0dd5: Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2016-04-28' into staging (2016-04-28 11:05:37 +0100)

[Qemu-devel] [PULL for-2.6 1/1] qapi: Don't pass NULL to printf in string input visitor

2016-04-29 Thread Markus Armbruster
From: Eric Blake Make sure the error message for visit_type_uint64() gracefully handles a NULL 'name' when called from the top level or a list context, as not all the world behaves like glibc in allowing NULL through a printf-family %s. Signed-off-by: Eric Blake Message-Id: <1461879932-9020-21-

Re: [Qemu-devel] [PATCH for 2.6] configure: Allow builds -Weverything

2016-04-29 Thread Stefan Weil
Am 29.04.2016 um 10:51 schrieb Peter Maydell: > On 28 April 2016 at 22:33, Stefan Weil wrote: >> The clang compiler supports a useful compiler option -Weverything. >> >> As this option triggers warnings in glib header files, too, testing >> glib with -Werror will always fail. A size mismatch is al

[Qemu-devel] [PULL 1/2] vvfat: Fix volume name assertion

2016-04-29 Thread Kevin Wolf
Commit d5941dd made the volume name configurable, but it didn't consider that the rw code compares the volume name string to assert that the first directory entry is the volume name. This made vvfat crash in rw mode. This fixes the assertion to compare with the configured volume name instead of a

Re: [Qemu-devel] [PATCH v2 00/17] block: Convert .bdrv_read/write to .bdrv_preadv/pwritev

2016-04-29 Thread Kevin Wolf
Am 28.04.2016 um 15:16 hat Kevin Wolf geschrieben: > This series introduces a new BlockDriver interface, which will hopefully be > the > final one, or at least good enough for another few years: > .bdrv_preadv/pwritev. > It is based on coroutines, vectored, has flags and uses a byte granularity.

[Qemu-devel] [PULL 0/2] vvfat fixes for 2.6.0-rc4

2016-04-29 Thread Kevin Wolf
The following changes since commit 0d48dfedc5c2beb418ad4c08b78de14e794bb199: slirp: fix guest network access with darwin host (2016-04-28 18:12:08 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch changes up to d208c50d9dbf98c0

Re: [Qemu-devel] [PATCH v2 00/13] block: Move I/O throttling to BlockBackend

2016-04-29 Thread Kevin Wolf
Am 22.04.2016 um 19:42 hat Kevin Wolf geschrieben: > This is another feature that was "logically" part of the BlockBackend, but > implemented as a BlockDriverState feature. It was always kept on top using > swap_feature_fields(). > > This series moves it to be actually implemented in the BlockBack

[Qemu-devel] [PULL 2/2] vvfat: Fix default volume label

2016-04-29 Thread Kevin Wolf
Commit d5941dd documented that it leaves the default volume name as it was ("QEMU VVFAT"), but it doesn't actually implement this. You get an empty name (eleven space characters) instead. This fixes the implementation to apply the advertised default. Cc: qemu-sta...@nongnu.org Signed-off-by: Kevi

Re: [Qemu-devel] [PATCH v2 13/17] vmdk: Implement .bdrv_co_pwritev() interface

2016-04-29 Thread Kevin Wolf
Am 29.04.2016 um 10:49 hat Pavel Butsykin geschrieben: > On 29.04.2016 06:08, Fam Zheng wrote: > >On Thu, 04/28 15:16, Kevin Wolf wrote: > >> static int vmdk_write_compressed(BlockDriverState *bs, > >> int64_t sector_num, > >> con

Re: [Qemu-devel] [PATCH v2] migration: skip sending ram pages released by virtio-balloon driver.

2016-04-29 Thread Jitendra Kolhe
On 4/13/2016 5:06 PM, Michael S. Tsirkin wrote: > On Wed, Apr 13, 2016 at 12:15:38PM +0100, Dr. David Alan Gilbert wrote: >> * Michael S. Tsirkin (m...@redhat.com) wrote: >>> On Wed, Apr 13, 2016 at 04:24:55PM +0530, Jitendra Kolhe wrote: Can we extend support for post-copy in a different patc

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-04-29 Thread Marc-André Lureau
Hi On Thu, Apr 28, 2016 at 7:23 AM, Yuanhan Liu wrote: > On Fri, Apr 01, 2016 at 01:16:21PM +0200, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> Signed-off-by: Marc-André Lureau >> --- >> docs/specs/vhost-user.txt | 15 +++ >> hw/virtio/vhost-user.c| 16 ++

Re: [Qemu-devel] [PATCH v2 13/17] vmdk: Implement .bdrv_co_pwritev() interface

2016-04-29 Thread Pavel Butsykin
On 29.04.2016 12:49, Kevin Wolf wrote: Am 29.04.2016 um 10:49 hat Pavel Butsykin geschrieben: On 29.04.2016 06:08, Fam Zheng wrote: On Thu, 04/28 15:16, Kevin Wolf wrote: static int vmdk_write_compressed(BlockDriverState *bs, int64_t sector_num,

Re: [Qemu-devel] [RFC PATCH v2 2/2] spapr: Memory hot-unplug support

2016-04-29 Thread David Gibson
On Fri, Apr 29, 2016 at 08:45:37AM +0200, Thomas Huth wrote: > On 29.04.2016 05:24, David Gibson wrote: > > On Tue, Apr 26, 2016 at 04:03:37PM -0500, Michael Roth wrote: > ... > >> In the case of pseries, the DIMM abstraction isn't really exposed to > >> the guest, but rather the memory blocks we u

Re: [Qemu-devel] [PATCH] fix xen hvm direct kernel boot

2016-04-29 Thread Stefano Stabellini
Please use my kernel.org email address. Also CC relevant maintainers. On Fri, 29 Apr 2016, Chunyan Liu wrote: > Since commit a1666142: acpi-build: make ROMs RAM blocks resizeable, > xen HVM direct kernel boot failed. Xen HVM direct kernel boot will > insert a linuxboot.bin or multiboot.bin to /gen

Re: [Qemu-devel] [RFC PATCH v2 2/2] spapr: Memory hot-unplug support

2016-04-29 Thread Thomas Huth
On 29.04.2016 10:30, Igor Mammedov wrote: > On Fri, 29 Apr 2016 10:22:03 +0200 > Thomas Huth wrote: > >> On 29.04.2016 08:59, Bharata B Rao wrote: >>> On Fri, Apr 29, 2016 at 08:45:37AM +0200, Thomas Huth wrote: On 29.04.2016 05:24, David Gibson wrote: > On Tue, Apr 26, 2016 at 04:03

Re: [Qemu-devel] [PATCH v4 5/5] Add param Error ** for msi_init()

2016-04-29 Thread Cao jin
Hi Markus, sorry for replying so late, I am stucked by other tasks for a while. On 04/12/2016 07:50 PM, Markus Armbruster wrote: Examine how it uses msi_init(). That's how we give a PCI device capability MSI. If the device model treats msi_init() failure as fatal, it doesn't have a non-MS

Re: [Qemu-devel] [PULL for-2.6 0/1] QAPI patches for 2016-04-29

2016-04-29 Thread Peter Maydell
On 29 April 2016 at 10:19, Markus Armbruster wrote: > Potential crash bug. Missing 2.6 wouldn't be a big deal, but it's an > obvious one-liner, so let's try. > > The following changes since commit 736f85d5db701cc9d464a03b583d4a04606a0dd5: > > Merge remote-tracking branch 'remotes/armbru/tags/pu

Re: [Qemu-devel] [PATCH v16 00/24] qapi visitor cleanups (post-introspection cleanups subset E)

2016-04-29 Thread Markus Armbruster
Eric Blake writes: > 2.7 material; much less churn this time through, but enough > that it was easier for me to repost than to make Markus do > the touchups his review found. > > Based on master, with no prerequisite patches. > > Also available as a tag at this location: > git fetch git://repo.or

Re: [Qemu-devel] emulation details of qemu

2016-04-29 Thread tutu sky
Yeah, thank you Alex. If I use a linux on top of the qemu, for entering debug mode, do i need to compile kernel from source or it is not dependent on debugging qemu itself? and then is it possible to define a heterogeneous multicore platform in qemu? Thanks and regards.

Re: [Qemu-devel] [RFC PATCH V3 3/4] colo-compare: introduce packet comparison thread

2016-04-29 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > > > On 04/29/2016 10:07 AM, Jason Wang wrote: > > > >On 04/28/2016 06:31 PM, Zhang Chen wrote: > +/* > + * called from the compare thread on the primary > + * for compare connection > + */ > +static void colo_compare_connec

Re: [Qemu-devel] [PATCH 2/4] Postcopy: Add stats on page requests

2016-04-29 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 04/27/2016 01:08 PM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > On the source, add a count of page requests received from the > > destination. > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > hmp.c

Re: [Qemu-devel] [PATCH v3 02/18] qapi: Improve use of qmp/types.h

2016-04-29 Thread Markus Armbruster
Eric Blake writes: > 'qobject-json.h' is not a QObject subtype; include this file > directly in .c files that are using it, rather than abusing > qmp/types.h for that purpose. > > Meanwhile, for files that include a list of individual QObject > subtypes, it's easier to just use qmp/types.h for th

Re: [Qemu-devel] [PATCH v2 4/8] target-arm: Add more fields to the data abort syndrome generator

2016-04-29 Thread Edgar E. Iglesias
On Thu, Feb 25, 2016 at 05:41:00PM +, Peter Maydell wrote: > On 19 February 2016 at 20:04, Edgar E. Iglesias > wrote: > > From: "Edgar E. Iglesias" > > > > Add the following flags to the data abort syndrome generator: > > * isv - Instruction syndrome valid > > * sas - Syndrome access size > >

Re: [Qemu-devel] [PATCH v2 00/13] block: Move I/O throttling to BlockBackend

2016-04-29 Thread Alberto Garcia
On Fri 29 Apr 2016 12:01:08 PM CEST, Kevin Wolf wrote: >> This is another feature that was "logically" part of the >> BlockBackend, but implemented as a BlockDriverState feature. It was >> always kept on top using swap_feature_fields(). >> >> This series moves it to be actually implemented in the

Re: [Qemu-devel] [PATCH v2 7/8] target-arm: A64: Create Instruction Syndromes for Data Aborts

2016-04-29 Thread Edgar E. Iglesias
On Thu, Feb 25, 2016 at 06:26:45PM +, Peter Maydell wrote: > On 19 February 2016 at 20:04, Edgar E. Iglesias > wrote: > > From: "Edgar E. Iglesias" > > > > Add support for generating the instruction syndrome for Data Aborts. > > These syndromes are used by hypervisors for example to trap and

Re: [Qemu-devel] [PULL 0/2] vvfat fixes for 2.6.0-rc4

2016-04-29 Thread Peter Maydell
On 29 April 2016 at 10:55, Kevin Wolf wrote: > The following changes since commit 0d48dfedc5c2beb418ad4c08b78de14e794bb199: > > slirp: fix guest network access with darwin host (2016-04-28 18:12:08 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-

[Qemu-devel] [PATCH v3 2/7] gen-icount: Use tcg_set_insn_param

2016-04-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Use tcg_set_insn_param() instead of directly accessing internal tcg data structures to update an insn param. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- include/exec/gen-icount.h | 16 1 file changed, 8 insertions(+), 8 deleti

[Qemu-devel] [PATCH v3 1/7] tcg: Add tcg_set_insn_param

2016-04-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add tcg_set_insn_param as a mechanism to modify an insn parameter after emiting the insn. This is useful for icount and also for embedding fault information for a specific insn. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- tcg/tcg.h | 6 ++

[Qemu-devel] [PATCH v3 0/7] arm: Steps towards EL2 support round 6

2016-04-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Hi, Another round of patches towards EL2 support. This one adds partial Instruction Syndrome generation for Data Aborts while running in AArch64. I don't feel very confident with the way I collect the regsize info used to fill out the SF field. Feedback on that would b

Re: [Qemu-devel] [PATCH v3 03/18] qapi: Factor out JSON string escaping

2016-04-29 Thread Markus Armbruster
Eric Blake writes: > Pull out a new qstring_append_json_string() helper, so that all > JSON output producers can use the same output escaping rules. > > While it appears that vmstate's use of the simpler qjson.c > formatter is not currently encountering any string that needs > escapes to be valid

[Qemu-devel] [PATCH v3 6/7] target-arm/translate-a64.c: Unify some of the ldst_reg decoding

2016-04-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" The various load/store variants under disas_ldst_reg can all reuse the same decoding for opc, size, rt and is_vector. This patch unifies the decoding in preparation for generating instruction syndromes for data aborts. This will allow us to reduce the number of places t

[Qemu-devel] [PATCH v3 4/7] target-arm: Split data abort syndrome generator

2016-04-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Split the data abort syndrome generator into two versions. One with a valid Instruction Specific Syndrome (ISS) and another without. The following new flags are supported by the syndrome generator with ISS: * isv - Instruction syndrome valid * sas - Syndrome access size

[Qemu-devel] [PATCH v3 7/7] target-arm: A64: Create Instruction Syndromes for Data Aborts

2016-04-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add support for generating the instruction syndrome for Data Aborts. These syndromes are used by hypervisors for example to trap and emulate memory accesses. We save the decoded data out-of-band with the TBs at translation time. When exceptions hit, the extra data attac

Re: [Qemu-devel] [PATCH v16 02/24] qapi: Guarantee NULL obj on input visitor callback error

2016-04-29 Thread Eric Blake
On 04/29/2016 02:28 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Our existing input visitors were not very consistent on errors >> in a function taking 'TYPE **obj' (that is, start_struct(), >> start_alternate(), type_str(), and type_any(). next_list() is >> similar, except that since c

Re: [Qemu-devel] [PATCH v16 11/24] qmp-input: Refactor when list is advanced

2016-04-29 Thread Eric Blake
On 04/29/2016 02:50 AM, Markus Armbruster wrote: > Eric Blake writes: > >> In the QMP input visitor, visiting a list traverses two objects: >> the QAPI GenericList of the caller (which gets advanced in >> visit_next_list() regardless of this patch), and the QList input >> that we are converting t

Re: [Qemu-devel] [PATCH v16 00/24] qapi visitor cleanups (post-introspection cleanups subset E)

2016-04-29 Thread Eric Blake
On 04/29/2016 05:13 AM, Markus Armbruster wrote: > Eric Blake writes: > >> 2.7 material; much less churn this time through, but enough >> that it was easier for me to repost than to make Markus do >> the touchups his review found. >> >> Based on master, with no prerequisite patches. >> >> Also av

Re: [Qemu-devel] [PATCH v16 02/24] qapi: Guarantee NULL obj on input visitor callback error

2016-04-29 Thread Eric Blake
On 04/29/2016 06:10 AM, Eric Blake wrote: > On 04/29/2016 02:28 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Our existing input visitors were not very consistent on errors >>> in a function taking 'TYPE **obj' (that is, start_struct(), >>> start_alternate(), type_str(), and type_any()

Re: [Qemu-devel] emulation details of qemu

2016-04-29 Thread Alex Bennée
tutu sky writes: > Yeah, thank you Alex. > If I use a linux on top of the qemu, for entering debug mode, do i > need to compile kernel from source or it is not dependent on debugging > qemu itself? I'm not sure I follow. As far as QEMU is concerned it provides a stub for GDB to talk to and does

Re: [Qemu-devel] emulation details of qemu

2016-04-29 Thread tutu sky
Magic answer, Thanks a lot Alex. you mean GDB will be enabled for just QEMU's itself internals? It does not make importance or any difference for guest running on it? if i want describe my opinion in another way, i think you said that when enabling GDB for QEMU, it is usable and is just important

[Qemu-devel] [PATCH for-2.6] acpi: fix bios linker loadder COMMAND_ALLOCATE on bigendian host

2016-04-29 Thread Igor Mammedov
'make check' fails with: ERROR:tests/bios-tables-test.c:493:load_expected_aml: assertion failed: (g_file_test(aml_file, G_FILE_TEST_EXISTS)) since commit: caf50c7166a6ed96c462ab5db4b495e1234e4cc6 tests: pc: acpi: drop not needed 'expected SSDT' blobs Assert happens because qemu-system-x86_64

Re: [Qemu-devel] [PATCH v4 5/5] Add param Error ** for msi_init()

2016-04-29 Thread Markus Armbruster
Cao jin writes: > Hi Markus, > sorry for replying so late, I am stucked by other tasks for a while. > > On 04/12/2016 07:50 PM, Markus Armbruster wrote: >> >> Examine how it uses msi_init(). That's how we give a PCI device >> capability MSI. If the device model treats msi_init() failure as

Re: [Qemu-devel] [PATCH v16 02/24] qapi: Guarantee NULL obj on input visitor callback error

2016-04-29 Thread Markus Armbruster
Eric Blake writes: > On 04/29/2016 06:10 AM, Eric Blake wrote: >> On 04/29/2016 02:28 AM, Markus Armbruster wrote: >>> Eric Blake writes: >>> Our existing input visitors were not very consistent on errors in a function taking 'TYPE **obj' (that is, start_struct(), start_alternate(

Re: [Qemu-devel] [PATCH v16 11/24] qmp-input: Refactor when list is advanced

2016-04-29 Thread Markus Armbruster
Eric Blake writes: > On 04/29/2016 02:50 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> In the QMP input visitor, visiting a list traverses two objects: >>> the QAPI GenericList of the caller (which gets advanced in >>> visit_next_list() regardless of this patch), and the QList input

[Qemu-devel] [PATCH v3 5/7] target-arm/translate-a64.c: Use extract32 in disas_ldst_reg_imm9

2016-04-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Use extract32 instead of open coding the bit masking when decoding is_signed and is_extended. This streamlines the decoding with some of the other ldst variants. No functional change. Reviewed-by: Sergey Fedorov Signed-off-by: Edgar E. Iglesias --- target-arm/transl

[Qemu-devel] [engineering.redhat.com #398672] [QEMU-SECURITY] Out-of-bands write in uart_write()

2016-04-29 Thread Red Hat Product Security
On Sun Apr 24 22:05:43 2016, liqiang...@360.cn wrote: > Hi, Is there any progress in requesting CVE for this issue ? > > -邮件原件- > 发件人: Michael S. Tsirkin [mailto:m...@redhat.com] > 发送时间: 2016年4月18日 17:29 > 收件人: 李强 > 抄送: Peter Maydell; pmato...@redhat.com; sstabell...@kernel.org; > secal...@

[Qemu-devel] [PATCH] configure: Check if struct fsxattr is available from linux header

2016-04-29 Thread Jan Vesely
Fixes build failure with --enable-xfsctl and new linux headers (>=4.5) and older xfsprogs(<4.5): In file included from /usr/include/xfs/xfs.h:38:0, from /var/tmp/portage/app-emulation/qemu-2.5.0-r1/work/qemu-2.5.0/block/raw-posix.c:97: /usr/include/xfs/xfs_fs.h:42:8: error: redefi

Re: [Qemu-devel] [PATCH v16 00/24] qapi visitor cleanups (post-introspection cleanups subset E)

2016-04-29 Thread Markus Armbruster
Eric Blake writes: > On 04/29/2016 05:13 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> 2.7 material; much less churn this time through, but enough >>> that it was easier for me to repost than to make Markus do >>> the touchups his review found. >>> >>> Based on master, with no prere

Re: [Qemu-devel] [PATCH for-2.6] acpi: fix bios linker loadder COMMAND_ALLOCATE on bigendian host

2016-04-29 Thread Laurent Vivier
On 29/04/2016 14:44, Igor Mammedov wrote: > 'make check' fails with: > > ERROR:tests/bios-tables-test.c:493:load_expected_aml: >assertion failed: (g_file_test(aml_file, G_FILE_TEST_EXISTS)) > > since commit: > caf50c7166a6ed96c462ab5db4b495e1234e4cc6 > tests: pc: acpi: drop not needed 'expe

[Qemu-devel] [PATCH v3 3/7] target-arm: Add the IL flag to syn_data_abort

2016-04-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add the IL flag to syn_data_abort(). Since we at the moment never set ISV, the IL flag is always set to one. Signed-off-by: Edgar E. Iglesias --- target-arm/internals.h | 4 +++- target-arm/op_helper.c | 6 -- 2 files changed, 7 insertions(+), 3 deletions(-) diff

Re: [Qemu-devel] [PATCH v3 04/18] qapi: Factor out JSON number formatting

2016-04-29 Thread Markus Armbruster
Eric Blake writes: > Pull out a new qstring_append_json_number() helper, so that all > JSON output producers can use a consistent style for printing > floating point without duplicating code (since we are doing more > data massaging than a simple printf format can handle). > > Address one FIXME b

Re: [Qemu-devel] [PATCH v3 05/18] qapi: Use qstring_append_chr() where appropriate

2016-04-29 Thread Markus Armbruster
Eric Blake writes: > No need to create a temporary buffer, when we already have a > function available for our needs. > > Signed-off-by: Eric Blake > Reviewed-by: Fam Zheng > > --- > v3: no change > v2: no change > --- > qobject/json-parser.c | 7 +-- > 1 file changed, 1 insertion(+), 6 de

Re: [Qemu-devel] [PATCH] target-i386: add Skylake-Client cpu mode

2016-04-29 Thread Huang, Kai
Hi Guangrong, How about also add SGX to Skylake? Thanks, -Kai On 4/27/2016 8:13 PM, Xiao Guangrong wrote: From: Eduardo Habkost Introduce Skylake-Client cpu mode which inherits the features from Broadwell and supports some additional features that are: MPX, XSAVEC, XSAVES and XGETBV1 Note:

[Qemu-devel] [PATCH RFC 5/9] s390x/css: realize css_sch_build_schib

2016-04-29 Thread Xiao Feng Ren
The S390 virtual css support already has a mechanism to build virtual schib and provide virtual subchannels to the guest. However, to pass-through ccw device to a guest, we need to introduce a new mechanism to build its schib according to the real device information. Thus we realize a new css_sch_b

[Qemu-devel] [PATCH RFC 1/9] vfio: linux-headers update for vfio-ccw

2016-04-29 Thread Xiao Feng Ren
This is a placeholder for a linux-headers update. Signed-off-by: Xiao Feng Ren --- linux-headers/linux/vfio.h | 32 1 file changed, 32 insertions(+) diff --git a/linux-headers/linux/vfio.h b/linux-headers/linux/vfio.h index 759b850..4059e3e 100644 --- a/linux-he

[Qemu-devel] [PATCH RFC 2/9] vfio: No-IOMMU mode support

2016-04-29 Thread Xiao Feng Ren
Add qemu support for the newly introduced VFIO No-IOMMU driver. We need to add special handling for: - Group character device is /dev/vfio/noiommu-$GROUP. - No-IOMMU does not rely on a memory listener. - No IOMMU will be set for its group, so no need to call vfio_kvm_device_add_group. Signed-of

[Qemu-devel] qcow2 resize with snapshots

2016-04-29 Thread zhangzm
hi, i want to implement the function of qcow2 resize which has snapshots. each snapshot of qcow2 will have a separate total size, and when apply a snapshot, the image can be shrunk, and the total size of image will change after apply to a snapshot with different size. now, there is a disk_si

[Qemu-devel] [PATCH RFC 9/9] s390x/css: ccws translation infrastructure

2016-04-29 Thread Xiao Feng Ren
Implement a basic infrastructure of handling channel I/O instruction interception for passed through devices: 1. Branch the code path of instruction interception handling by SubChannel type. 2. For a passed through device, issue the ORB to do ccw translation and perform an I/O operation. 3. I

[Qemu-devel] [PATCH RFC 0/9] basic channel IO passthrough infrastructure based on vfio

2016-04-29 Thread Xiao Feng Ren
The patch series introduce a basic channel I/O passthrough infrastructure based on vfio. - Focus on supporting dasd-eckd(cu_type/dev_type = 0x3990/0x3390) as the target device. - Support new qemu parameters in the style of: "-machine s390-ccw-virtio(,s390-map-css=on|off) ... -device vfio

[Qemu-devel] [PATCH RFC 4/9] s390x/css: add s390-map-css machine option

2016-04-29 Thread Xiao Feng Ren
We want to support real (i.e. not virtual) channel devices even for guests that do not support MCSS-E (where guests may see devices from any channel subsystem image at once). As all virtio-ccw devices are in css 0xfe (and show up in the default css 0 for guests not activating MCSS-E), we need an op

[Qemu-devel] [PATCH RFC 6/9] s390x/css: device and bus support for s390-ccw passthrough

2016-04-29 Thread Xiao Feng Ren
In order to support ccw device pass-through, we introduce a s390 ccw device called "s390-ccw" to hold the real device info. As the existing virtual-css-bridge and virtual-css-bus are designed to support virtio_ccw devices for S390x virtio machine. We want to put passthroughed devices on a different

[Qemu-devel] [PATCH RFC 7/9] vfio/ccw: vfio based ccw passthrough driver

2016-04-29 Thread Xiao Feng Ren
We use the No-IOMMU mode of VFIO to realize the ccw device passthrough, implement a vfio based ccw passthrough driver called "vfio-ccw". Support qemu parameters in the style of: "-device vfio-ccw,id=xx,hostid=xx(,guestid=xx)" Signed-off-by: Xiao Feng Ren --- default-configs/s390x-softmmu.mak |

[Qemu-devel] [PATCH RFC 3/9] s390x/css: introduce ccw chain interfaces

2016-04-29 Thread Xiao Feng Ren
Introduce CcwChain structures and helper functions that can be used to translate a guest ccw program to a user-space ccw program. The following limitations apply: 1. Support only prefetch enable mode. 2. Support chain for idal(c64) ccws. 3. Detect chain end only by CC and DC flags. This work prepa

[Qemu-devel] [PATCH RFC 4/8] vfio: ccw: realize VFIO_DEVICE_GET_INFO ioctl

2016-04-29 Thread Dong Jia Shi
Introduce device information about vfio-ccw: VFIO_DEVICE_FLAGS_CCW. Realize VFIO_DEVICE_GET_INFO ioctl for vfio-ccw. Signed-off-by: Dong Jia Shi Reviewed-by: Pierre Morel --- drivers/vfio/ccw/vfio_ccw.c | 20 include/uapi/linux/vfio.h | 1 + 2 files changed, 21 insertion

[Qemu-devel] [PATCH RFC 7/8] vfio: ccw: introduce ccw chain interfaces

2016-04-29 Thread Dong Jia Shi
Introduce ccwchain structure and helper functions that can be used to handle special ccw programs issued from user-space. The following limitations apply: 1. Supports only prefetch enabled mode. 2. Supports direct ccw chaining by translating them to idal ccws. 3. Supports idal(c64) ccw chaining.

[Qemu-devel] [PATCH RFC 8/9] s390x/css: introduce and realize ccw-request callback

2016-04-29 Thread Xiao Feng Ren
Introduce a new callback on ccw device to handle ccw-request. Realize the callback in vfio-ccw device. Signed-off-by: Xiao Feng Ren --- hw/s390x/s390-ccw.h | 1 + hw/vfio/ccw.c | 42 ++ 2 files changed, 43 insertions(+) diff --git a/hw/s390x/s390-c

[Qemu-devel] [PATCH RFC 2/8] s390: move orb.h from drivers/s390/ to arch/s390/

2016-04-29 Thread Dong Jia Shi
Let's make orb-related definitions available outside of the common I/O layer for future use (e.g. for passing channel devices to a guest). Signed-off-by: Dong Jia Shi Reviewed-by: Pierre Morel --- {drivers/s390/cio => arch/s390/include/asm}/orb.h | 0 drivers/s390/cio/eadm_sch.c

[Qemu-devel] [PATCH RFC 1/8] iommu: s390: enable iommu api for s390 ccw devices

2016-04-29 Thread Dong Jia Shi
This enables IOMMU API if CONFIG_CCW is configured. Signed-off-by: Dong Jia Shi Reviewed-by: Pierre Morel --- drivers/iommu/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig index dd1dc39..63bbc3d 100644 --- a/drivers

[Qemu-devel] [PATCH RFC 0/8] basic vfio-ccw infrastructure

2016-04-29 Thread Dong Jia Shi
vfio: ccw: basic vfio-ccw infrastructure Introduction Here we describe the vfio support for Channel I/O devices (aka. CCW devices) for Linux/s390. Motivation for vfio-ccw is to passthrough CCW devices to a virtual machine, while vfio is the me

  1   2   >