Hi,
> >
> > @@ -1447,8 +1432,9 @@ void qemu_ram_set_idstr(ram_addr_t addr, const
> char *name, DeviceState *dev)
> > }
> > pstrcat(new_block->idstr, sizeof(new_block->idstr), name);
> >
> > - QLIST_FOREACH_RCU(block, &ram_list.blocks, next) {
> > - if (block != new_block && !strcmp(block->idstr, new_block->idstr))
> {
> > + QLIST_FOREACH_RCU(old_block, &ram_list.blocks, next) {
> > + if (old_block != new_block &&
> > + !strcmp(old_block->idstr, new_block->idstr)) {
>
> Cosmetic point: maybe you don't need to touch these lines if you name the
> function parameter to new_block.
>
Yes, we can.
> Reviewed-by: Fam Zheng <f...@redhat.com>
>
Thanks.
Regards,
-Gonglei
