* Eric Blake (ebl...@redhat.com) wrote:
> On 04/27/2016 01:08 PM, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com>
> >
> > On the source, add a count of page requests received from the
> > destination.
> >
> > Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
> > ---
> > hmp.c | 4 +++
> > include/migration/migration.h | 2 ++
> > migration/migration.c | 59
> > ++++++++++++++++++-------------------------
> > migration/ram.c | 1 +
> > qapi-schema.json | 6 ++++-
> > 5 files changed, 36 insertions(+), 36 deletions(-)
> >
>
> > +++ b/migration/migration.c
> > @@ -561,6 +561,26 @@ static void get_xbzrle_cache_stats(MigrationInfo *info)
> > }
> > }
> >
> > +static void populate_ram_info(MigrationInfo *info, MigrationState *s)
> > +{
> > + info->has_ram = true;
> > + info->ram = g_malloc0(sizeof(*info->ram));
>
> > @@ -585,18 +605,7 @@ MigrationInfo *qmp_query_migrate(Error **errp)
> > info->has_setup_time = true;
> > info->setup_time = s->setup_time;
> >
> > - info->has_ram = true;
> > - info->ram = g_malloc0(sizeof(*info->ram));
>
> If you respin, please split the refactoring into one patch, and the
> addition of postcopy stats in another, so that the addition is not lost
> in the noise.
Done.
> Otherwise looks fine.
Thanks.
Dave
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
